)]}'
{"monascaclient/v2_0/shell.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"dc9407e5ab57436a3347755390e4be39a5f5b545","unresolved":false,"context_lines":[{"line_number":1315,"context_line":""},{"line_number":1316,"context_line":""},{"line_number":1317,"context_line":"def _arg_split_patch_update(arg, patch\u003dFalse):"},{"line_number":1318,"context_line":"    if patch:"},{"line_number":1319,"context_line":"        arg \u003d \u0027,\u0027.join(arg)"},{"line_number":1320,"context_line":"    if not arg or arg \u003d\u003d \"[]\":"},{"line_number":1321,"context_line":"        arg_split \u003d []"},{"line_number":1322,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_680a9927","line":1319,"range":{"start_line":1318,"start_character":0,"end_line":1319,"end_character":27},"updated":"2016-04-27 17:32:01.000000000","message":"I don\u0027t understand the purpose of this. If I pass in \"[]\", then it gets changed to \"[,]\" which I don\u0027t believe is what you want","commit_id":"0dc4b0329cb1d3456c962f760562aa14832eee97"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"0c433a528d04bb9a25d7a5537090b9218d77dfc7","unresolved":false,"context_lines":[{"line_number":1315,"context_line":""},{"line_number":1316,"context_line":""},{"line_number":1317,"context_line":"def _arg_split_patch_update(arg, patch\u003dFalse):"},{"line_number":1318,"context_line":"    if patch:"},{"line_number":1319,"context_line":"        arg \u003d \u0027,\u0027.join(arg)"},{"line_number":1320,"context_line":"    if not arg or arg \u003d\u003d \"[]\":"},{"line_number":1321,"context_line":"        arg_split \u003d []"},{"line_number":1322,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_c24629bf","line":1319,"range":{"start_line":1318,"start_character":0,"end_line":1319,"end_character":27},"in_reply_to":"1a122d0e_680a9927","updated":"2016-04-27 19:50:40.000000000","message":"For update, the input arguments are treated as string but for patch, they are list. That\u0027s why I have to add this if statement here. I just talked with Ryan and we think it\u0027s good to make update and patch the same. So I will change the patch arguments as string and post a new patch.","commit_id":"0dc4b0329cb1d3456c962f760562aa14832eee97"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"434b3618ce080ba37ca4b1b4cb0d25cf85ba4ac1","unresolved":false,"context_lines":[{"line_number":1315,"context_line":""},{"line_number":1316,"context_line":""},{"line_number":1317,"context_line":"def _arg_split_patch_update(arg, patch\u003dFalse):"},{"line_number":1318,"context_line":"    if patch:"},{"line_number":1319,"context_line":"        arg \u003d \u0027,\u0027.join(arg)"},{"line_number":1320,"context_line":"    if not arg or arg \u003d\u003d \"[]\":"},{"line_number":1321,"context_line":"        arg_split \u003d []"},{"line_number":1322,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_f83792ad","line":1319,"range":{"start_line":1318,"start_character":0,"end_line":1319,"end_character":27},"in_reply_to":"1a122d0e_c24629bf","updated":"2016-04-27 20:47:39.000000000","message":"Hi Craig, I just took a look at this problem again. In do_alarm_definition_patch, for input argument ok-actions, alarm-actions and undetermined-actions, it specified \"action\u003d\u0027append\u0027\" which stores these args as a list, and appends each argument value to the list. This is useful to allow an option to be specified multiple times such as \"monasca alarm-definition-patch \u003cID\u003e --ok-actions \u0027AAA\u0027 --ok-actions \u0027BBB\u0027\". I think it\u0027s better to keep it this way so users don\u0027t need to deal with the sudden change. What you think about this?","commit_id":"0dc4b0329cb1d3456c962f760562aa14832eee97"}]}