)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19861,"name":"Igor Natanael","email":"igornsa@lsd.ufcg.edu.br","username":"igorn"},"change_message_id":"e08340efbdde9d33aab2a5d1f9974d11281b8ddc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add support for notification-method/types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I322d1277c1859c990e150f22eceff122ffd77cea"},{"line_number":10,"context_line":"Implements: blueprint Notification Engine Plugin System"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_46522f36","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":55},"updated":"2016-07-12 23:04:21.000000000","message":"This link is not good.\n\nActually, I think it should be used in this way:\nImplements: blueprint notification-engine-plugin\n\nOr better:\nPartially-implements: blueprint notification-engine-plugin, because the blue-print requires changes in others components. About this, I\u0027m not sure, but I think that is this the correct usage","commit_id":"0d948bfa40edf9e8f5e1e23e66ac493b7e42cb32"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"f5fb401f36da4d49673711239a5adb51666e0aee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add support for notification-method/types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I322d1277c1859c990e150f22eceff122ffd77cea"},{"line_number":10,"context_line":"Implements: blueprint Notification Engine Plugin System"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_1ecfa329","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":55},"in_reply_to":"1aa78d24_46522f36","updated":"2016-07-13 15:17:00.000000000","message":"Changed it to Parially-implements","commit_id":"0d948bfa40edf9e8f5e1e23e66ac493b7e42cb32"}],"monascaclient/tests/fakes.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"7d76db99e8393091d96419837227e644e6e9304b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_e673724c","line":1,"updated":"2016-07-26 19:07:42.000000000","message":"copyright","commit_id":"c56d759e1c7599ab9890707266178384f505df6a"}],"monascaclient/tests/test_shell.py":[{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"e57dddead60a53e331d35b0201ec0e09b949d940","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            retvalue \u003d self.shell(argstr)"},{"line_number":218,"context_line":"            self.assertRegexpMatches(retvalue, \"^Invalid type\")"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def test_notifications_create_type_sms(self):"},{"line_number":221,"context_line":"        self._script_keystone_client()"},{"line_number":222,"context_line":"        argstrings \u003d ["},{"line_number":223,"context_line":"            \u0027notification-create sms1 SMS myphonenumber\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_209eb054","side":"PARENT","line":220,"range":{"start_line":220,"start_character":47,"end_line":220,"end_character":49},"updated":"2016-07-13 19:47:52.000000000","message":"Can you explain here why you deleted these two tests? Thank you.","commit_id":"834d7c740eeb6a0b1f276a12b3ae70b534f2f588"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"f2354270baa7cf39f239d720ec7efb071a1ce07d","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            retvalue \u003d self.shell(argstr)"},{"line_number":218,"context_line":"            self.assertRegexpMatches(retvalue, \"^Invalid type\")"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def test_notifications_create_type_sms(self):"},{"line_number":221,"context_line":"        self._script_keystone_client()"},{"line_number":222,"context_line":"        argstrings \u003d ["},{"line_number":223,"context_line":"            \u0027notification-create sms1 SMS myphonenumber\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_17e657b0","side":"PARENT","line":220,"range":{"start_line":220,"start_character":47,"end_line":220,"end_character":49},"in_reply_to":"1aa78d24_14dbf550","updated":"2016-07-13 20:25:31.000000000","message":"Fine with me.","commit_id":"834d7c740eeb6a0b1f276a12b3ae70b534f2f588"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"625bd7ea1edb4c7e8b5c845762ae78273cdc7148","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            retvalue \u003d self.shell(argstr)"},{"line_number":218,"context_line":"            self.assertRegexpMatches(retvalue, \"^Invalid type\")"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def test_notifications_create_type_sms(self):"},{"line_number":221,"context_line":"        self._script_keystone_client()"},{"line_number":222,"context_line":"        argstrings \u003d ["},{"line_number":223,"context_line":"            \u0027notification-create sms1 SMS myphonenumber\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_b78ae318","side":"PARENT","line":220,"range":{"start_line":220,"start_character":47,"end_line":220,"end_character":49},"in_reply_to":"1aa78d24_14dbf550","updated":"2016-07-13 20:18:27.000000000","message":"Thanks!","commit_id":"834d7c740eeb6a0b1f276a12b3ae70b534f2f588"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"8b9e9d5c37f9a589f2feb4b2892b96fe012cb950","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            retvalue \u003d self.shell(argstr)"},{"line_number":218,"context_line":"            self.assertRegexpMatches(retvalue, \"^Invalid type\")"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def test_notifications_create_type_sms(self):"},{"line_number":221,"context_line":"        self._script_keystone_client()"},{"line_number":222,"context_line":"        argstrings \u003d ["},{"line_number":223,"context_line":"            \u0027notification-create sms1 SMS myphonenumber\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_14dbf550","side":"PARENT","line":220,"range":{"start_line":220,"start_character":47,"end_line":220,"end_character":49},"in_reply_to":"1aa78d24_209eb054","updated":"2016-07-13 19:53:28.000000000","message":"Notification types are configured as plugins and user can create any notification type. Previously we can\u0027t have notification of type \"sms\". Now they can create it, but allowed types are verified at server side and not at client side.  This checking will happen in server side","commit_id":"834d7c740eeb6a0b1f276a12b3ae70b534f2f588"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"7d76db99e8393091d96419837227e644e6e9304b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2014-2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_e6aa5270","line":1,"updated":"2016-07-26 19:07:42.000000000","message":"Company should be removed","commit_id":"c56d759e1c7599ab9890707266178384f505df6a"}],"monascaclient/v2_0/client.py":[{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"7d76db99e8393091d96419837227e644e6e9304b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2014-2015 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_46b23ee6","line":1,"updated":"2016-07-26 19:07:42.000000000","message":"Company should be removed","commit_id":"c56d759e1c7599ab9890707266178384f505df6a"}],"monascaclient/v2_0/notificationtypes.py":[{"author":{"_account_id":19861,"name":"Igor Natanael","email":"igornsa@lsd.ufcg.edu.br","username":"igorn"},"change_message_id":"e08340efbdde9d33aab2a5d1f9974d11281b8ddc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class NotificationTypes(base.Resource):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def __repr__(self):"},{"line_number":24,"context_line":"        return \"\u003cNotification Tpes%s\u003e\" % self._info"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class NotificationTypesManager(monasca_manager.MonascaManager):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_ab911c49","line":24,"range":{"start_line":24,"start_character":30,"end_line":24,"end_character":34},"updated":"2016-07-12 23:04:21.000000000","message":"It shouldn\u0027t be \"NotificationTypes %s\"?\nhttps://github.com/openstack/python-monascaclient/search?utf8\u003d%E2%9C%93\u0026q\u003d__repr__","commit_id":"0d948bfa40edf9e8f5e1e23e66ac493b7e42cb32"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"f5fb401f36da4d49673711239a5adb51666e0aee","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class NotificationTypes(base.Resource):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def __repr__(self):"},{"line_number":24,"context_line":"        return \"\u003cNotification Tpes%s\u003e\" % self._info"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class NotificationTypesManager(monasca_manager.MonascaManager):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_3ed89fee","line":24,"range":{"start_line":24,"start_character":30,"end_line":24,"end_character":34},"in_reply_to":"1aa78d24_ab911c49","updated":"2016-07-13 15:17:00.000000000","message":"Done","commit_id":"0d948bfa40edf9e8f5e1e23e66ac493b7e42cb32"},{"author":{"_account_id":19861,"name":"Igor Natanael","email":"igornsa@lsd.ufcg.edu.br","username":"igorn"},"change_message_id":"e08340efbdde9d33aab2a5d1f9974d11281b8ddc","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        resp, body \u003d self.client.json_request(\u0027GET\u0027, url_str,"},{"line_number":39,"context_line":"                                              headers\u003dnewheaders)"},{"line_number":40,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_c610df02","line":40,"range":{"start_line":40,"start_character":15,"end_line":40,"end_character":19},"updated":"2016-07-12 23:04:21.000000000","message":"You don\u0027t have to check if body is a dict and if it is return body[\u0027elements\u0027] as the others Managers?","commit_id":"0d948bfa40edf9e8f5e1e23e66ac493b7e42cb32"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"f5fb401f36da4d49673711239a5adb51666e0aee","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        resp, body \u003d self.client.json_request(\u0027GET\u0027, url_str,"},{"line_number":39,"context_line":"                                              headers\u003dnewheaders)"},{"line_number":40,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_9e7f13aa","line":40,"range":{"start_line":40,"start_character":15,"end_line":40,"end_character":19},"in_reply_to":"1aa78d24_c610df02","updated":"2016-07-13 15:17:00.000000000","message":"This returns {\"types\": [\"WEBHOOK\", \"EMAIL\", \"PAGERDUTY\"]}, so I know for sure there is no body[elements]","commit_id":"0d948bfa40edf9e8f5e1e23e66ac493b7e42cb32"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"7d76db99e8393091d96419837227e644e6e9304b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_43035142","line":1,"updated":"2016-07-26 19:07:42.000000000","message":"(C) Copyright 2016 Hewlett Packard Enterprise Development LP","commit_id":"c56d759e1c7599ab9890707266178384f505df6a"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"1f4aeb067ba4373ede5a077f361f06643536d532","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def list(self, **kwargs):"},{"line_number":32,"context_line":"        \"\"\"Get a list of notifications.\"\"\""},{"line_number":33,"context_line":"        newheaders \u003d self.get_headers()"},{"line_number":34,"context_line":"        url_str \u003d self.base_url"},{"line_number":35,"context_line":"        if kwargs:"},{"line_number":36,"context_line":"            url_str \u003d url_str + \u0027?%s\u0027 % urlutils.urlencode(kwargs, True)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_c28ec626","line":33,"updated":"2016-07-27 15:31:59.000000000","message":"new_headers ? ;-)","commit_id":"053e9d9f6202d5fb9f9843cb77ebc6ad2d0f722f"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"29ea1113b9920aa2995aec099b3b5acff7331c66","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def list(self, **kwargs):"},{"line_number":32,"context_line":"        \"\"\"Get a list of notifications.\"\"\""},{"line_number":33,"context_line":"        newheaders \u003d self.get_headers()"},{"line_number":34,"context_line":"        url_str \u003d self.base_url"},{"line_number":35,"context_line":"        if kwargs:"},{"line_number":36,"context_line":"            url_str \u003d url_str + \u0027?%s\u0027 % urlutils.urlencode(kwargs, True)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_8c53b96a","line":33,"in_reply_to":"bacf61ea_72c5255a","updated":"2016-08-01 05:36:15.000000000","message":"No, no :)\nI meant that it should be new_headers instead of newheaders :)","commit_id":"053e9d9f6202d5fb9f9843cb77ebc6ad2d0f722f"},{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"33d06d2de6c3692adade74be15db8fbe39c595d2","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def list(self, **kwargs):"},{"line_number":32,"context_line":"        \"\"\"Get a list of notifications.\"\"\""},{"line_number":33,"context_line":"        newheaders \u003d self.get_headers()"},{"line_number":34,"context_line":"        url_str \u003d self.base_url"},{"line_number":35,"context_line":"        if kwargs:"},{"line_number":36,"context_line":"            url_str \u003d url_str + \u0027?%s\u0027 % urlutils.urlencode(kwargs, True)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bacf61ea_72c5255a","line":33,"in_reply_to":"bacf61ea_c28ec626","updated":"2016-07-27 16:23:24.000000000","message":"Not really new headers. Th existing headers like auth token etc","commit_id":"053e9d9f6202d5fb9f9843cb77ebc6ad2d0f722f"}]}