)]}'
{"monascaclient/tests/test_shell.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"2c5a8be33acfc8d50e1a60223b4a81bd9d56c277","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        http.HTTPClient.json_request("},{"line_number":292,"context_line":"            \u0027PATCH\u0027,"},{"line_number":293,"context_line":"            \u0027/notification-methods/\u0027 + id_str,"},{"line_number":294,"context_line":"            data\u003d{\u0027type\u0027: \u0027EMAIL\u0027,"},{"line_number":295,"context_line":"                  \u0027address\u0027: \u0027john.doe@hpe.com\u0027,"},{"line_number":296,"context_line":"                  \u0027period\u0027: 0},"},{"line_number":297,"context_line":"            headers\u003d{\u0027X-Auth-Key\u0027: \u0027password\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_74403ea6","line":294,"range":{"start_line":294,"start_character":27,"end_line":294,"end_character":32},"updated":"2016-07-19 03:18:14.000000000","message":"Can you do this on a webhook? Then you can change it from 60 to 0 and ensure it works","commit_id":"5711177b4e505f99d99a827465ee81824de48d3e"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"011f5cea0633d85df12cafd3b695c573daefd33f","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        http.HTTPClient.json_request("},{"line_number":292,"context_line":"            \u0027PATCH\u0027,"},{"line_number":293,"context_line":"            \u0027/notification-methods/\u0027 + id_str,"},{"line_number":294,"context_line":"            data\u003d{\u0027type\u0027: \u0027EMAIL\u0027,"},{"line_number":295,"context_line":"                  \u0027address\u0027: \u0027john.doe@hpe.com\u0027,"},{"line_number":296,"context_line":"                  \u0027period\u0027: 0},"},{"line_number":297,"context_line":"            headers\u003d{\u0027X-Auth-Key\u0027: \u0027password\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_afab4bd5","line":294,"range":{"start_line":294,"start_character":27,"end_line":294,"end_character":32},"in_reply_to":"dada55a8_5e324711","updated":"2016-07-19 20:45:10.000000000","message":"Done","commit_id":"5711177b4e505f99d99a827465ee81824de48d3e"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"7b68f909ac26884ea46535903813b4e0b2dcac33","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        http.HTTPClient.json_request("},{"line_number":292,"context_line":"            \u0027PATCH\u0027,"},{"line_number":293,"context_line":"            \u0027/notification-methods/\u0027 + id_str,"},{"line_number":294,"context_line":"            data\u003d{\u0027type\u0027: \u0027EMAIL\u0027,"},{"line_number":295,"context_line":"                  \u0027address\u0027: \u0027john.doe@hpe.com\u0027,"},{"line_number":296,"context_line":"                  \u0027period\u0027: 0},"},{"line_number":297,"context_line":"            headers\u003d{\u0027X-Auth-Key\u0027: \u0027password\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_930688cc","line":294,"range":{"start_line":294,"start_character":27,"end_line":294,"end_character":32},"in_reply_to":"dada55a8_74403ea6","updated":"2016-07-19 15:06:54.000000000","message":"Hmmm I don\u0027t think it works that way. These tests are only comparing the json_request with the argstring and see if they match.","commit_id":"5711177b4e505f99d99a827465ee81824de48d3e"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"ba9e70692fa4c6f6aa410ada734585903a00a6fe","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        http.HTTPClient.json_request("},{"line_number":292,"context_line":"            \u0027PATCH\u0027,"},{"line_number":293,"context_line":"            \u0027/notification-methods/\u0027 + id_str,"},{"line_number":294,"context_line":"            data\u003d{\u0027type\u0027: \u0027EMAIL\u0027,"},{"line_number":295,"context_line":"                  \u0027address\u0027: \u0027john.doe@hpe.com\u0027,"},{"line_number":296,"context_line":"                  \u0027period\u0027: 0},"},{"line_number":297,"context_line":"            headers\u003d{\u0027X-Auth-Key\u0027: \u0027password\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_5e324711","line":294,"range":{"start_line":294,"start_character":27,"end_line":294,"end_character":32},"in_reply_to":"dada55a8_930688cc","updated":"2016-07-19 19:56:37.000000000","message":"could you do a negative test with patch as the client does catch that if you try to patch with type email and period \u003e 0","commit_id":"5711177b4e505f99d99a827465ee81824de48d3e"}],"monascaclient/v2_0/shell.py":[{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"666af9a911f0bd716853f9d329cf70c6ef191967","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2014-2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_b2c4b240","line":1,"range":{"start_line":1,"start_character":65,"end_line":1,"end_character":72},"updated":"2016-07-15 21:48:02.000000000","message":"take out","commit_id":"35d86305e763ec1c3b173c09bb721659b300a372"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"f2c6d999da7f3f5d7756129801271e3c701e9760","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (C) Copyright 2014-2016 Hewlett Packard Enterprise Development Company LP"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"fad55976_b2583258","line":1,"range":{"start_line":1,"start_character":65,"end_line":1,"end_character":72},"in_reply_to":"fad55976_b2c4b240","updated":"2016-07-15 21:48:43.000000000","message":"oops","commit_id":"35d86305e763ec1c3b173c09bb721659b300a372"},{"author":{"_account_id":15027,"name":"Michael Hoppal","email":"michael.jam.hoppal@hpe.com","username":"michael-hoppal"},"change_message_id":"80090cf9d7d9a06fc712f4706996ca41686b7b2b","unresolved":false,"context_lines":[{"line_number":693,"context_line":"        fields[\u0027type\u0027] \u003d args.type"},{"line_number":694,"context_line":"    if args.address:"},{"line_number":695,"context_line":"        fields[\u0027address\u0027] \u003d args.address"},{"line_number":696,"context_line":"    if args.period or args.period \u003d\u003d 0:"},{"line_number":697,"context_line":"        if args.type and not _validate_notification_period("},{"line_number":698,"context_line":"                args.period, args.type.upper()):"},{"line_number":699,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"fad55976_09a0e99e","line":696,"range":{"start_line":696,"start_character":22,"end_line":696,"end_character":26},"updated":"2016-07-18 19:16:35.000000000","message":"could you create a test case for this in https://github.com/openstack/python-monascaclient/blob/master/monascaclient/tests/test_shell.py?","commit_id":"a21e5acd4adc1d80f3a30c3caa38906ac5e76bc3"}]}