)]}'
{"monascaclient/common/http.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"37f5347f9185946f526589ce4bbce3b00866687f","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import requests"},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":"from six.moves.urllib.parse import urlparse"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from monascaclient import exc"},{"line_number":26,"context_line":"from monascaclient import ksclient"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_231fa85c","line":23,"updated":"2016-11-14 10:57:53.000000000","message":"Importing top-level modules is recommended in the openstack.","commit_id":"01425a1576d6597db5df44eb4a257ff9b5651d85"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1ef190d67c7360d8c74c8e253dcc959aa470c5f0","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import requests"},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":"from six.moves.urllib.parse import urlparse"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from monascaclient import exc"},{"line_number":26,"context_line":"from monascaclient import ksclient"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_e82bc892","line":23,"in_reply_to":"9a629dbe_231fa85c","updated":"2016-11-14 12:40:54.000000000","message":"Done","commit_id":"01425a1576d6597db5df44eb4a257ff9b5651d85"}],"monascaclient/openstack/common/apiclient/base.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5044c7fe23f154ff78f2066456b5e665ec4f6328","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from monascaclient.openstack.common.apiclient import exceptions"},{"line_number":33,"context_line":"from monascaclient.openstack.common.py3kcompat import urlutils"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from oslo_utils import strutils"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def getid(obj):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_0b61a839","side":"PARENT","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":31},"updated":"2016-11-08 21:46:52.000000000","message":"this is unrelated, but in the wrong group, so i grouped it with other third party libs","commit_id":"aef0d28d85459f47b49c7406d7e75119900c968e"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"37f5347f9185946f526589ce4bbce3b00866687f","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from oslo_utils import strutils"},{"line_number":31,"context_line":"import six"},{"line_number":32,"context_line":"from six.moves.urllib.parse import urlencode"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from monascaclient.openstack.common.apiclient import exceptions"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_b8ff63a9","line":32,"updated":"2016-11-14 10:57:53.000000000","message":"Everything fine, but openstack guidelines recommends importing modules instead of actual members. Would you mind changing that ?","commit_id":"01425a1576d6597db5df44eb4a257ff9b5651d85"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1ef190d67c7360d8c74c8e253dcc959aa470c5f0","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from oslo_utils import strutils"},{"line_number":31,"context_line":"import six"},{"line_number":32,"context_line":"from six.moves.urllib.parse import urlencode"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from monascaclient.openstack.common.apiclient import exceptions"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_08171c55","line":32,"in_reply_to":"9a629dbe_b8ff63a9","updated":"2016-11-14 12:40:54.000000000","message":"Done","commit_id":"01425a1576d6597db5df44eb4a257ff9b5651d85"}],"monascaclient/v2_0/alarm_definitions.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"37f5347f9185946f526589ce4bbce3b00866687f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from six.moves.urllib.parse import urlencode"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from monascaclient.common import monasca_manager"},{"line_number":19,"context_line":"from monascaclient.openstack.common.apiclient import base"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_6339a0d8","line":16,"updated":"2016-11-14 10:57:53.000000000","message":"Same here.","commit_id":"01425a1576d6597db5df44eb4a257ff9b5651d85"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1ef190d67c7360d8c74c8e253dcc959aa470c5f0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from six.moves.urllib.parse import urlencode"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from monascaclient.common import monasca_manager"},{"line_number":19,"context_line":"from monascaclient.openstack.common.apiclient import base"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_281ce076","line":16,"in_reply_to":"9a629dbe_6339a0d8","updated":"2016-11-14 12:40:54.000000000","message":"Done","commit_id":"01425a1576d6597db5df44eb4a257ff9b5651d85"}]}
