)]}'
{"monascaclient/common/monasca_manager.py":[{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"834137f47dbb763d4ba9f203303944035fe5d54a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from monascaclient.apiclient import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import urllib"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class MonascaManager(base.BaseManager):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_a95b4286","line":18,"updated":"2016-11-16 15:51:59.000000000","message":"shouldn\u0027t it be sth similar to six.moves.urllib ?","commit_id":"1ed20099b38a9f4a5caf52df8272eef730cfad46"},{"author":{"_account_id":11155,"name":"Ryan Bak","email":"ryan.bak@twcable.com","username":"ryanmbak"},"change_message_id":"8f7028178a1c1a20bff85da5d56517c76e552365","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from monascaclient.apiclient import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import urllib"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class MonascaManager(base.BaseManager):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_98c08ee2","line":18,"in_reply_to":"7a77a97e_a242770e","updated":"2016-11-16 17:01:24.000000000","message":"I didn\u0027t know about those oslo changes.  Fixed now.","commit_id":"1ed20099b38a9f4a5caf52df8272eef730cfad46"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"f3d40ae20d8e00d03c7d190abc65621e5f396c81","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from monascaclient.apiclient import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import urllib"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class MonascaManager(base.BaseManager):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_cc808c49","line":18,"in_reply_to":"7a77a97e_a95b4286","updated":"2016-11-16 15:59:38.000000000","message":"what I mean here, is that recent change for removing oslo incubated code were also importing urllib but it was done from six.moves library.","commit_id":"1ed20099b38a9f4a5caf52df8272eef730cfad46"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"f64c9ac160d668e25a7a20d844caa3d458fda567","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from monascaclient.apiclient import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import urllib"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class MonascaManager(base.BaseManager):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_a242770e","line":18,"in_reply_to":"7a77a97e_cc808c49","updated":"2016-11-16 16:30:59.000000000","message":"It probably should be. I\u0027m assuming some form of python 2/3 compatibility.","commit_id":"1ed20099b38a9f4a5caf52df8272eef730cfad46"},{"author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"change_message_id":"ff7b068e822314b50ebe4254e9094adef44f41f0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        if type(body) is dict:"},{"line_number":28,"context_line":"            self.next \u003d None"},{"line_number":29,"context_line":"            for link in body[\u0027links\u0027]:"},{"line_number":30,"context_line":"                if link[\u0027rel\u0027] \u003d\u003d \u0027next\u0027:"},{"line_number":31,"context_line":"                    self.next \u003d link[\u0027href\u0027]"},{"line_number":32,"context_line":"            return body[\u0027elements\u0027]"},{"line_number":33,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_e9037a40","line":30,"updated":"2016-11-16 15:53:03.000000000","message":"Don\u0027t you want to also have prev here ?","commit_id":"1ed20099b38a9f4a5caf52df8272eef730cfad46"},{"author":{"_account_id":2419,"name":"Roland Hochmuth","email":"roland.hochmuth@hpe.com","username":"roland-hochmuth-s"},"change_message_id":"f64c9ac160d668e25a7a20d844caa3d458fda567","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        if type(body) is dict:"},{"line_number":28,"context_line":"            self.next \u003d None"},{"line_number":29,"context_line":"            for link in body[\u0027links\u0027]:"},{"line_number":30,"context_line":"                if link[\u0027rel\u0027] \u003d\u003d \u0027next\u0027:"},{"line_number":31,"context_line":"                    self.next \u003d link[\u0027href\u0027]"},{"line_number":32,"context_line":"            return body[\u0027elements\u0027]"},{"line_number":33,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_ffca4c6d","line":30,"in_reply_to":"7a77a97e_e9037a40","updated":"2016-11-16 16:30:59.000000000","message":"We don\u0027t currently support prev link anywhere in the result sets that are returned. RIght?","commit_id":"1ed20099b38a9f4a5caf52df8272eef730cfad46"},{"author":{"_account_id":11155,"name":"Ryan Bak","email":"ryan.bak@twcable.com","username":"ryanmbak"},"change_message_id":"8f7028178a1c1a20bff85da5d56517c76e552365","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        if type(body) is dict:"},{"line_number":28,"context_line":"            self.next \u003d None"},{"line_number":29,"context_line":"            for link in body[\u0027links\u0027]:"},{"line_number":30,"context_line":"                if link[\u0027rel\u0027] \u003d\u003d \u0027next\u0027:"},{"line_number":31,"context_line":"                    self.next \u003d link[\u0027href\u0027]"},{"line_number":32,"context_line":"            return body[\u0027elements\u0027]"},{"line_number":33,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_186abe1a","line":30,"in_reply_to":"7a77a97e_ffca4c6d","updated":"2016-11-16 17:01:24.000000000","message":"Not that I saw.  If we ever do it should be easy to add similar behavior here.","commit_id":"1ed20099b38a9f4a5caf52df8272eef730cfad46"}],"monascaclient/v2_0/alarm_definitions.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"3e1fdc36c06f22619ade94f15b374999618ae2ad","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        # print url_str"},{"line_number":58,"context_line":"        resp, body \u003d self.client.json_request("},{"line_number":59,"context_line":"            \u0027GET\u0027, url_str, headers\u003dnewheaders)"},{"line_number":60,"context_line":"        if type(body) is dict:"},{"line_number":61,"context_line":"            self.next \u003d None"},{"line_number":62,"context_line":"            for link in body[\u0027links\u0027]:"},{"line_number":63,"context_line":"                if link[\u0027rel\u0027] \u003d\u003d \u0027next\u0027:"},{"line_number":64,"context_line":"                    self.next \u003d link[\u0027href\u0027]"},{"line_number":65,"context_line":"            return body[\u0027elements\u0027]"},{"line_number":66,"context_line":"        else:"},{"line_number":67,"context_line":"            return body"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def delete(self, **kwargs):"},{"line_number":70,"context_line":"        \"\"\"Delete a specific alarm definition.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a629dbe_ce22dea2","line":67,"range":{"start_line":60,"start_character":0,"end_line":67,"end_character":23},"updated":"2016-11-10 23:45:20.000000000","message":"Can this code be moved to monasca_manager as well? I see it duplicated multiple times","commit_id":"78a30ea668aa65f6196276cf05dd762c9d30513d"}],"monascaclient/v2_0/metrics.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"4fc8bac6fa0e269dbba238bfa6b092f4538c679c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        return resp"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def list_next(self):"},{"line_number":54,"context_line":"        if self.next:"},{"line_number":55,"context_line":"            path \u003d self.next.split(self.base_url, 1)[-1]"},{"line_number":56,"context_line":"            return self._list(path)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_1fb8ece4","line":54,"range":{"start_line":54,"start_character":11,"end_line":54,"end_character":20},"updated":"2016-11-08 23:42:19.000000000","message":"Note that this will fail with a NameError if this is called before a list() or if body was not a dict. That is not helpful for determining what the caller did wrong","commit_id":"14327d067228f002753c66a3dc741e540665aa34"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"4fc8bac6fa0e269dbba238bfa6b092f4538c679c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def list_next(self):"},{"line_number":54,"context_line":"        if self.next:"},{"line_number":55,"context_line":"            path \u003d self.next.split(self.base_url, 1)[-1]"},{"line_number":56,"context_line":"            return self._list(path)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _list(self, path, **kwargs):"},{"line_number":59,"context_line":"        \"\"\"Get a list of metrics.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_7f1ba81b","line":56,"updated":"2016-11-08 23:42:19.000000000","message":"I prefer to see the explicit \"return None\" if self.next is empty","commit_id":"14327d067228f002753c66a3dc741e540665aa34"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"77792e77eb16b173c87158962f36f3bb0887b256","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        else:"},{"line_number":72,"context_line":"            return body"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def list_next(self):"},{"line_number":75,"context_line":"        if hasattr(self, \u0027next\u0027) and self.next:"},{"line_number":76,"context_line":"            path \u003d self.next.split(self.base_url, 1)[-1]"},{"line_number":77,"context_line":"            return self._list(path)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_27bd8ab7","line":74,"updated":"2016-11-09 15:28:12.000000000","message":"can this method be in Baseresource?","commit_id":"fc69f6ad34904af73ba12e0e2fe8498a44a25983"},{"author":{"_account_id":11155,"name":"Ryan Bak","email":"ryan.bak@twcable.com","username":"ryanmbak"},"change_message_id":"40ca6c7fe30f34d0b13ce0d927e71df1eb4f4aaf","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        else:"},{"line_number":72,"context_line":"            return body"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def list_next(self):"},{"line_number":75,"context_line":"        if hasattr(self, \u0027next\u0027) and self.next:"},{"line_number":76,"context_line":"            path \u003d self.next.split(self.base_url, 1)[-1]"},{"line_number":77,"context_line":"            return self._list(path)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_8d7e7517","line":74,"in_reply_to":"9a629dbe_27bd8ab7","updated":"2016-11-09 16:07:23.000000000","message":"I\u0027m not sure Baseresource is the right place, but I can move it to MonascaManager.","commit_id":"fc69f6ad34904af73ba12e0e2fe8498a44a25983"}]}