)]}'
{"id":"openstack%2Fpython-monascaclient~396838","triplet_id":"openstack%2Fpython-monascaclient~master~Ic7af17e278a44e96fa203648bb3da21825e654ed","project":"openstack/python-monascaclient","branch":"master","hashtags":[],"change_id":"Ic7af17e278a44e96fa203648bb3da21825e654ed","subject":"Fixed cli default notification types not allowing a slack or hipchat notification. Added documentation on readme for slack \u0026 hipchat notification.","status":"ABANDONED","created":"2016-11-12 06:42:49.000000000","updated":"2017-08-02 21:26:29.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d2ebf87d15480c49ee15422bafed811bf72f56a1","_number":396838,"virtual_id_number":396838,"owner":{"_account_id":22263,"name":"Ramon Melero","email":"rmelero@mirantis.com","username":"rmelero"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-11-30 16:12:54.000000000","_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},{"value":1,"date":"2016-11-12 06:46:11.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-11-29 23:41:57.000000000","_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},{"date":"2016-11-30 14:14:00.000000000","_account_id":22263,"name":"Ramon Melero","email":"rmelero@mirantis.com","username":"rmelero"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22263,"name":"Ramon Melero","email":"rmelero@mirantis.com","username":"rmelero"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},{"date":"2016-11-30 21:30:59.000000000","_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":22263,"name":"Ramon Melero","email":"rmelero@mirantis.com","username":"rmelero"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},{"_account_id":22263,"name":"Ramon Melero","email":"rmelero@mirantis.com","username":"rmelero"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-12 06:46:11.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-11-29 23:41:57.000000000","updated_by":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"reviewer":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"state":"REVIEWER"},{"updated":"2016-11-30 16:12:54.000000000","updated_by":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"reviewer":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"state":"REVIEWER"},{"updated":"2016-11-30 21:30:59.000000000","updated_by":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"reviewer":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"state":"REVIEWER"}],"messages":[{"id":"0615cb0d78a9f4f0538094e604b3c153f485170a","author":{"_account_id":22263,"name":"Ramon Melero","email":"rmelero@mirantis.com","username":"rmelero"},"date":"2016-11-12 06:42:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"81a30e42b6123f027f0bf03e16dc67107b0bba37","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-12 06:46:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-monascaclient-pep8-ubuntu-xenial http://logs.openstack.org/38/396838/1/check/gate-python-monascaclient-pep8-ubuntu-xenial/dbc3743/ : SUCCESS in 3m 11s\n- gate-python-monascaclient-python27-ubuntu-xenial http://logs.openstack.org/38/396838/1/check/gate-python-monascaclient-python27-ubuntu-xenial/68dcbb3/ : SUCCESS in 2m 19s","accounts_in_message":[],"_revision_number":1},{"id":"db91a0813a0d66ab3c5ef127e5af91596b799bac","author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"date":"2016-11-29 23:41:57.000000000","message":"Patch Set 1:\n\nPerhaps the type validation here no longer makes sense, with the plugin capability of the notification engine.","accounts_in_message":[],"_revision_number":1},{"id":"2aa64fe2acb4581e95ad78e3b28f1782f8788b69","author":{"_account_id":22263,"name":"Ramon Melero","email":"rmelero@mirantis.com","username":"rmelero"},"date":"2016-11-30 14:14:00.000000000","message":"Patch Set 1:\n\n\u003e Perhaps the type validation here no longer makes sense, with the\n \u003e plugin capability of the notification engine.\n\nWhat would be a good solution? Simply remove the type check? There\u0027s no way that I can think of to populate the list with implemented types other than a runtime check against notification-methods/types to see if it\u0027s valid.\n\nSomething like:\n\nif type !\u003d email,webhook,pagerduty\n   implemented_types \u003d get notification-methods/types\n   if type in implemented_types\n     success\n   else\n     unknown type error\n\nDoes that sound like a good solution?","accounts_in_message":[],"_revision_number":1},{"id":"b3b4a9f5a81dabc6052cdc0513953a9a61a967a6","author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"date":"2016-11-30 15:27:24.000000000","message":"Patch Set 1:\n\nI agree there is no simple way to populate the list, I would propose simply removing the validation for notification types.","accounts_in_message":[],"_revision_number":1},{"id":"0bd6159095ec1fa9a7978ef2f1caf13d56bd24df","author":{"_account_id":14273,"name":"Joe Keen","email":"joe.keen@hpe.com","username":"jkeen"},"date":"2016-11-30 16:12:54.000000000","message":"Patch Set 1:\n\nI would agree with Ryan.  The API will already validate notification types.  The only benefit to doing it in the CLI is that you can see you used an invalid type slightly more efficiently but now we have to maintain the list somehow.  If we\u0027re having to go to the API to check what types are valid we might as well just send in the entire notification method and see what happens.","accounts_in_message":[],"_revision_number":1},{"id":"d2ebf87d15480c49ee15422bafed811bf72f56a1","author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"date":"2017-08-02 21:26:29.000000000","message":"Abandoned\n\nNo action from the owner, if you still feel like this change is needed - please resubmit (reopen).","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4c0250c98b9de997da8778db51982ed696707fb1","revisions":{"4c0250c98b9de997da8778db51982ed696707fb1":{"kind":"REWORK","_number":1,"created":"2016-11-12 06:42:49.000000000","uploader":{"_account_id":22263,"name":"Ramon Melero","email":"rmelero@mirantis.com","username":"rmelero"},"ref":"refs/changes/38/396838/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-monascaclient","ref":"refs/changes/38/396838/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/38/396838/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/38/396838/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/38/396838/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-monascaclient refs/changes/38/396838/1"}}},"commit":{"parents":[{"commit":"aef0d28d85459f47b49c7406d7e75119900c968e","subject":"Merge \"Sample nagios plugin and examples directory.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/aef0d28d85459f47b49c7406d7e75119900c968e"}]}],"author":{"name":"Ramon Melero","email":"rmelero@mirantis.com","date":"2016-11-12 06:41:53.000000000","tz":-360},"committer":{"name":"Ramon Melero","email":"rmelero@mirantis.com","date":"2016-11-12 06:41:53.000000000","tz":-360},"subject":"Fixed cli default notification types not allowing a slack or hipchat notification. Added documentation on readme for slack \u0026 hipchat notification.","message":"Fixed cli default notification types not allowing a slack or hipchat\nnotification. Added documentation on readme for slack \u0026 hipchat notification.\n\nChange-Id: Ic7af17e278a44e96fa203648bb3da21825e654ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/4c0250c98b9de997da8778db51982ed696707fb1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/4c0250c98b9de997da8778db51982ed696707fb1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}