)]}'
{"id":"openstack%2Fpython-monascaclient~478728","triplet_id":"openstack%2Fpython-monascaclient~master~I37090045a61a5c170cce0203aef20cfcbf70d022","project":"openstack/python-monascaclient","branch":"master","hashtags":[],"change_id":"I37090045a61a5c170cce0203aef20cfcbf70d022","subject":"Replace six.iteritems() with .items()","status":"ABANDONED","created":"2017-06-29 04:42:12.000000000","updated":"2017-06-29 05:29:09.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"25c989a695991dc0adbfa854aded19441e6c7e37","_number":478728,"virtual_id_number":478728,"owner":{"_account_id":24924,"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","username":"Kiran_totad"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2017-06-29 05:26:48.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2017-06-29 05:21:24.000000000","_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-29 05:21:24.000000000","updated_by":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"reviewer":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"state":"REVIEWER"},{"updated":"2017-06-29 05:26:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"82948e61e6aabc364e7668690b0cf924598e68f2","author":{"_account_id":24924,"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","username":"Kiran_totad"},"date":"2017-06-29 04:42:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dfca737af909ac8592f3a60b03c8d229a1ba8f60","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-29 04:46:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-monascaclient-python35 http://logs.openstack.org/28/478728/1/check/gate-python-monascaclient-python35/4f2acf9/ : FAILURE in 1m 57s\n- gate-python-monascaclient-pep8-ubuntu-xenial http://logs.openstack.org/28/478728/1/check/gate-python-monascaclient-pep8-ubuntu-xenial/ce608e7/ : FAILURE in 3m 39s\n- gate-python-monascaclient-python27-ubuntu-xenial http://logs.openstack.org/28/478728/1/check/gate-python-monascaclient-python27-ubuntu-xenial/b441a8a/ : FAILURE in 2m 26s\n- python-monascaclient-coverage-ubuntu-xenial http://logs.openstack.org/28/478728/1/check/python-monascaclient-coverage-ubuntu-xenial/e9ee88e/ : FAILURE in 1m 57s","accounts_in_message":[],"_revision_number":1},{"id":"85a3111802e11091db663474cac65b91b1d40f49","author":{"_account_id":24924,"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","username":"Kiran_totad"},"date":"2017-06-29 05:19:48.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"a2ebebcc47eb48bec3a3ce608a1bb7fc06e8a43a","author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"date":"2017-06-29 05:21:24.000000000","message":"Patch Set 2:\n\nKiran, that shouldn\u0027t be a problem in https://review.openstack.org/#/c/461142.\n\nIf you want, please review the other change.","accounts_in_message":[],"_revision_number":2},{"id":"8df6bebd79363b5bf8fdad2e6930d420335ee3fe","author":{"_account_id":16168,"name":"Tomasz Trębski","email":"kornicameister@gmail.com","username":"trebskit"},"date":"2017-06-29 05:22:04.000000000","message":"Patch Set 2:\n\nAlso it duplicates different change ( https://review.openstack.org/#/c/453961 )","accounts_in_message":[],"_revision_number":2},{"id":"5ddf1cd18cf83dfd46bd1585e7d02370cc0202b3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-29 05:26:48.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-monascaclient-python35 http://logs.openstack.org/28/478728/2/check/gate-python-monascaclient-python35/cc9fdb6/ : FAILURE in 2m 43s\n- gate-python-monascaclient-pep8-ubuntu-xenial http://logs.openstack.org/28/478728/2/check/gate-python-monascaclient-pep8-ubuntu-xenial/5aba2b2/ : FAILURE in 2m 05s\n- gate-python-monascaclient-python27-ubuntu-xenial http://logs.openstack.org/28/478728/2/check/gate-python-monascaclient-python27-ubuntu-xenial/03c8898/ : FAILURE in 6m 20s\n- python-monascaclient-coverage-ubuntu-xenial http://logs.openstack.org/28/478728/2/check/python-monascaclient-coverage-ubuntu-xenial/e5bafa8/ : FAILURE in 3m 13s","accounts_in_message":[],"_revision_number":2},{"id":"25c989a695991dc0adbfa854aded19441e6c7e37","author":{"_account_id":24924,"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","username":"Kiran_totad"},"date":"2017-06-29 05:29:09.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c5057b16874ac23c093336039b1e699f209f5420","revisions":{"d2378bcaf3556faf3275e9300562b18f4fbdf452":{"kind":"REWORK","_number":1,"created":"2017-06-29 04:42:12.000000000","uploader":{"_account_id":24924,"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","username":"Kiran_totad"},"ref":"refs/changes/28/478728/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-monascaclient","ref":"refs/changes/28/478728/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/28/478728/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/28/478728/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/28/478728/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-monascaclient refs/changes/28/478728/1"}}},"commit":{"parents":[{"commit":"d18e339037e41ad0350aeb4443d2e2078de1a5e6","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/d18e339037e41ad0350aeb4443d2e2078de1a5e6"}]}],"author":{"name":"Kiran_totad","email":"kiran.totad@nectechnologies.in","date":"2017-06-29 04:42:37.000000000","tz":330},"committer":{"name":"Kiran_totad","email":"kiran.totad@nectechnologies.in","date":"2017-06-29 04:43:27.000000000","tz":330},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using six.iteritems to achieve\niterators. We can use dict.items instead, as it will return iterators\nin PY3 as well. And dict.items/keys will more readable.\n2.In py2, the performance about list should be negligible, see the\nlink [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I37090045a61a5c170cce0203aef20cfcbf70d022\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/d2378bcaf3556faf3275e9300562b18f4fbdf452"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/d2378bcaf3556faf3275e9300562b18f4fbdf452"}]},"branch":"refs/heads/master"},"c5057b16874ac23c093336039b1e699f209f5420":{"kind":"REWORK","_number":2,"created":"2017-06-29 05:19:48.000000000","uploader":{"_account_id":24924,"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","username":"Kiran_totad"},"ref":"refs/changes/28/478728/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-monascaclient","ref":"refs/changes/28/478728/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/28/478728/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/28/478728/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/28/478728/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-monascaclient refs/changes/28/478728/2"}}},"commit":{"parents":[{"commit":"d18e339037e41ad0350aeb4443d2e2078de1a5e6","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/d18e339037e41ad0350aeb4443d2e2078de1a5e6"}]}],"author":{"name":"Kiran_totad","email":"kiran.totad@nectechnologies.in","date":"2017-06-29 04:42:37.000000000","tz":330},"committer":{"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","date":"2017-06-29 05:19:26.000000000","tz":0},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using six.iteritems to achieve\niterators. We can use dict.items instead, as it will return iterators\nin PY3 as well. And dict.items/keys will more readable.\n2.In py2, the performance about list should be negligible, see the\nlink [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I37090045a61a5c170cce0203aef20cfcbf70d022\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/c5057b16874ac23c093336039b1e699f209f5420"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/c5057b16874ac23c093336039b1e699f209f5420"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}