)]}'
{"id":"openstack%2Fpython-monascaclient~636150","triplet_id":"openstack%2Fpython-monascaclient~master~Ib008ed2aacd93f499b15094cf5a7e1bb0bb50a1f","project":"openstack/python-monascaclient","branch":"master","hashtags":[],"change_id":"Ib008ed2aacd93f499b15094cf5a7e1bb0bb50a1f","subject":"Fix alarm-definition-list in Python 3","status":"MERGED","created":"2019-02-11 15:14:22.000000000","updated":"2019-02-14 16:17:31.000000000","submitted":"2019-02-14 16:17:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"636150-1550161051523-ba88c93f","meta_rev_id":"ff05524fd6c9e0c1bf375abf249ad71cb4bfec41","_number":636150,"virtual_id_number":636150,"owner":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"value":2,"date":"2019-02-14 16:17:31.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"recommended":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"all":[{"value":1,"date":"2019-02-13 15:51:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-02-14 12:09:59.000000000","_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"all":[{"value":1,"date":"2019-02-14 16:04:48.000000000","_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-02-14 12:09:59.000000000","updated_by":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"reviewer":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"state":"REVIEWER"},{"updated":"2019-02-14 16:04:48.000000000","updated_by":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"reviewer":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"state":"REVIEWER"},{"updated":"2019-02-14 16:17:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"811cc7aad8f8fa5c33c4455e941f5f684e09521d","author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"date":"2019-02-11 15:14:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"09c2e5f6fba5db3895f6df50571ad3b171e1c267","author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"date":"2019-02-11 15:25:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b6fb60eb4c6929805fd76f67ab2b271e74d2f141","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-11 15:36:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/50/636150/2/check/openstack-tox-cover/952d933/cover/ : SUCCESS in 8m 28s\n- openstack-tox-lower-constraints http://logs.openstack.org/50/636150/2/check/openstack-tox-lower-constraints/70b84c2/ : SUCCESS in 5m 52s\n- openstack-tox-pep8 http://logs.openstack.org/50/636150/2/check/openstack-tox-pep8/c2941d2/ : SUCCESS in 4m 50s\n- openstack-tox-py27 http://logs.openstack.org/50/636150/2/check/openstack-tox-py27/2ec6a0f/ : SUCCESS in 4m 49s\n- openstack-tox-py35 http://logs.openstack.org/50/636150/2/check/openstack-tox-py35/5ce3ee4/ : SUCCESS in 5m 34s\n- openstack-tox-py36 http://logs.openstack.org/50/636150/2/check/openstack-tox-py36/9a89e46/ : SUCCESS in 5m 50s\n- openstack-tox-docs http://logs.openstack.org/50/636150/2/check/openstack-tox-docs/ad4aeca/html/ : SUCCESS in 4m 51s","accounts_in_message":[],"_revision_number":2},{"id":"848f2945425fbcb551e10baf14580a9cb337dfe1","author":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"date":"2019-02-13 15:51:35.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"b2785adb14cc3192b133460fd78cb0bacc8d00e0","author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"date":"2019-02-14 12:09:59.000000000","message":"Patch Set 2: Code-Review+2\n\nLooks good and thanks for the test.\nalarm-definition-list is the only method using this code, so it should be safe.","accounts_in_message":[],"_revision_number":2},{"id":"fcce5be4905ecebe826ecc3edde881a1a9f9895d","author":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"date":"2019-02-14 16:04:48.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"44afdc754a1a1a98d22a6b31949382e0e6167a0f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-14 16:05:00.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"8acc0af6f29d549681a72aebe348baa54c50cf92","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-14 16:17:31.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"ff05524fd6c9e0c1bf375abf249ad71cb4bfec41","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-14 16:17:31.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/50/636150/2/gate/openstack-tox-lower-constraints/847dea3/ : SUCCESS in 6m 17s\n- openstack-tox-pep8 http://logs.openstack.org/50/636150/2/gate/openstack-tox-pep8/9e68663/ : SUCCESS in 3m 59s\n- openstack-tox-py27 http://logs.openstack.org/50/636150/2/gate/openstack-tox-py27/322a8fc/ : SUCCESS in 5m 03s\n- openstack-tox-py35 http://logs.openstack.org/50/636150/2/gate/openstack-tox-py35/92aa4f6/ : SUCCESS in 4m 32s\n- openstack-tox-py36 http://logs.openstack.org/50/636150/2/gate/openstack-tox-py36/085f7ad/ : SUCCESS in 4m 42s\n- openstack-tox-docs http://logs.openstack.org/50/636150/2/gate/openstack-tox-docs/74601dd/html/ : SUCCESS in 4m 11s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"59e2a9bd2f4288d68c6c266fbdd138583802431c","revisions":{"91d1223ffef14954ac87091db91b78faf0785197":{"kind":"REWORK","_number":1,"created":"2019-02-11 15:14:22.000000000","uploader":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"ref":"refs/changes/50/636150/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-monascaclient","ref":"refs/changes/50/636150/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/50/636150/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/50/636150/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/50/636150/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-monascaclient refs/changes/50/636150/1"}}},"commit":{"parents":[{"commit":"0b14b4d492386938788efe83fc5acc9f833b6f3c","subject":"Return status from running command","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/0b14b4d492386938788efe83fc5acc9f833b6f3c"}]}],"author":{"name":"Doug Szumski","email":"doug@stackhpc.com","date":"2019-02-11 15:00:47.000000000","tz":0},"committer":{"name":"Doug Szumski","email":"doug@stackhpc.com","date":"2019-02-11 15:12:36.000000000","tz":0},"subject":"Fix alarm-definition-list in Python 3","message":"Fix alarm-definition-list in Python 3\n\nPython 3 uses unicode strings by default. This bug was caused by\nattempting to join a byte string to a unicode string when running\nwith the Python 3 interpreter.\n\nA unit test was added to reproduce the problem.\n\nWhilst this fix allows alarm definitions to be listed, it doesn\u0027t\nfix the formatting problem in Python 3. A better fix may be\nto return unicode strings in Python 3 as part of a wider code\naudit.\n\nStory: 2004972\nTask: 29427\nChange-Id: Ib008ed2aacd93f499b15094cf5a7e1bb0bb50a1f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/91d1223ffef14954ac87091db91b78faf0785197"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/91d1223ffef14954ac87091db91b78faf0785197"}]},"branch":"refs/heads/master"},"59e2a9bd2f4288d68c6c266fbdd138583802431c":{"kind":"REWORK","_number":2,"created":"2019-02-11 15:25:07.000000000","uploader":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"ref":"refs/changes/50/636150/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-monascaclient","ref":"refs/changes/50/636150/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/50/636150/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/50/636150/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-monascaclient refs/changes/50/636150/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-monascaclient refs/changes/50/636150/2"}}},"commit":{"parents":[{"commit":"0b14b4d492386938788efe83fc5acc9f833b6f3c","subject":"Return status from running command","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/0b14b4d492386938788efe83fc5acc9f833b6f3c"}]}],"author":{"name":"Doug Szumski","email":"doug@stackhpc.com","date":"2019-02-11 15:00:47.000000000","tz":0},"committer":{"name":"Doug Szumski","email":"doug@stackhpc.com","date":"2019-02-11 15:24:57.000000000","tz":0},"subject":"Fix alarm-definition-list in Python 3","message":"Fix alarm-definition-list in Python 3\n\nPython 3 uses unicode strings by default. This bug was caused by\nattempting to join a byte string to a unicode string when running\nwith the Python 3 interpreter.\n\nA unit test was added to reproduce the problem.\n\nWhilst this fix allows alarm definitions to be listed, it doesn\u0027t\nfix the formatting problem in Python 3. A better fix may be\nto return unicode strings in Python 3 as part of a wider code\naudit.\n\nStory: 2004972\nTask: 29427\nChange-Id: Ib008ed2aacd93f499b15094cf5a7e1bb0bb50a1f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/59e2a9bd2f4288d68c6c266fbdd138583802431c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-monascaclient/commit/59e2a9bd2f4288d68c6c266fbdd138583802431c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}