)]}'
{"docker/Dockerfile":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"ef91df7a36c3a6365a43e4a6f52a5be9f7781634","unresolved":false,"context_lines":[{"line_number":2,"context_line":"ARG APP_REPO\u003dhttps://opendev.org/openstack/python-monascaclient"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Branch, tag or git hash to build from."},{"line_number":5,"context_line":"ARG REPO_VERSION\u003dstable/pike"},{"line_number":6,"context_line":"ARG CONSTRAINTS_BRANCH\u003dstable/pike"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Always start from `monasca-base` image and use specific tag of it."}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"dfbec78f_5dcae94d","line":5,"range":{"start_line":5,"start_character":17,"end_line":5,"end_character":28},"updated":"2019-05-14 15:31:18.000000000","message":"master","commit_id":"46416e9624354e7f381c81570a15a025d3914a67"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"ef91df7a36c3a6365a43e4a6f52a5be9f7781634","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Branch, tag or git hash to build from."},{"line_number":5,"context_line":"ARG REPO_VERSION\u003dstable/pike"},{"line_number":6,"context_line":"ARG CONSTRAINTS_BRANCH\u003dstable/pike"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Always start from `monasca-base` image and use specific tag of it."},{"line_number":9,"context_line":"ARG BASE_TAG\u003dmaster"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"dfbec78f_1dc0f129","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":34},"updated":"2019-05-14 15:31:18.000000000","message":"master","commit_id":"46416e9624354e7f381c81570a15a025d3914a67"}],"docker/build_image.sh":[{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"ef91df7a36c3a6365a43e4a6f52a5be9f7781634","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    CONSTRAINTS_BRANCH\u003d$(\\grep CONSTRAINTS_BRANCH Dockerfile | cut -f2 -d\"\u003d\")"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"# When using stable version of repository use same stable constraints file."},{"line_number":75,"context_line":"# When using stable version of repository use same stable constraints file."},{"line_number":76,"context_line":"case \"$REPO_VERSION\" in"},{"line_number":77,"context_line":"    *stable*)"},{"line_number":78,"context_line":"        CONSTRAINTS_BRANCH_CLEAN\u003d\"$REPO_VERSION\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"dfbec78f_3dd29501","line":75,"updated":"2019-05-14 15:31:18.000000000","message":"Please remove.","commit_id":"46416e9624354e7f381c81570a15a025d3914a67"},{"author":{"_account_id":16222,"name":"witek","email":"witold.bedyk@suse.com","username":"witek"},"change_message_id":"ef91df7a36c3a6365a43e4a6f52a5be9f7781634","unresolved":false,"context_lines":[{"line_number":76,"context_line":"case \"$REPO_VERSION\" in"},{"line_number":77,"context_line":"    *stable*)"},{"line_number":78,"context_line":"        CONSTRAINTS_BRANCH_CLEAN\u003d\"$REPO_VERSION\""},{"line_number":79,"context_line":"        CONSTRAINTS_FILE\u003d${CONSTRAINTS_FILE/master/$CONSTRAINTS_BRANCH_CLEAN}"},{"line_number":80,"context_line":"        # Get monasca-common version from stable upper constraints file."},{"line_number":81,"context_line":"        CONSTRAINTS_TMP_FILE\u003d$(mktemp)"},{"line_number":82,"context_line":"        wget --output-document \"$CONSTRAINTS_TMP_FILE\" \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"dfbec78f_9d02a16e","line":79,"updated":"2019-05-14 15:31:18.000000000","message":"Is it correct?","commit_id":"46416e9624354e7f381c81570a15a025d3914a67"},{"author":{"_account_id":30221,"name":"Arseni Lipinski","email":"arseni.lipinski@ts.fujitsu.com","username":"arseni.lipinski"},"change_message_id":"62188e9e041117e28813e3225fe1d1c5fdadac5a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"case \"$REPO_VERSION\" in"},{"line_number":77,"context_line":"    *stable*)"},{"line_number":78,"context_line":"        CONSTRAINTS_BRANCH_CLEAN\u003d\"$REPO_VERSION\""},{"line_number":79,"context_line":"        CONSTRAINTS_FILE\u003d${CONSTRAINTS_FILE/master/$CONSTRAINTS_BRANCH_CLEAN}"},{"line_number":80,"context_line":"        # Get monasca-common version from stable upper constraints file."},{"line_number":81,"context_line":"        CONSTRAINTS_TMP_FILE\u003d$(mktemp)"},{"line_number":82,"context_line":"        wget --output-document \"$CONSTRAINTS_TMP_FILE\" \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"dfbec78f_ea7c2373","line":79,"in_reply_to":"dfbec78f_9d02a16e","updated":"2019-05-16 11:28:14.000000000","message":"it\u0027s a string substitution","commit_id":"46416e9624354e7f381c81570a15a025d3914a67"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"5bce9a33f2c9fa3aa916c982c4a6f55c6c831e62","unresolved":false,"context_lines":[{"line_number":75,"context_line":"case \"$REPO_VERSION\" in"},{"line_number":76,"context_line":"    *stable*)"},{"line_number":77,"context_line":"        CONSTRAINTS_BRANCH_CLEAN\u003d\"$REPO_VERSION\""},{"line_number":78,"context_line":"        CONSTRAINTS_FILE\u003d${CONSTRAINTS_FILE/master/$CONSTRAINTS_BRANCH_CLEAN}"},{"line_number":79,"context_line":"        # Get monasca-common version from stable upper constraints file."},{"line_number":80,"context_line":"        CONSTRAINTS_TMP_FILE\u003d$(mktemp)"},{"line_number":81,"context_line":"        wget --output-document \"$CONSTRAINTS_TMP_FILE\" \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dfbec78f_b0c8dea5","line":78,"updated":"2019-05-15 10:37:36.000000000","message":"Please explain the reason for this change, looks ok to me otherwise.","commit_id":"847f50d025b59a3862f494e2011a0484199dc930"},{"author":{"_account_id":30221,"name":"Arseni Lipinski","email":"arseni.lipinski@ts.fujitsu.com","username":"arseni.lipinski"},"change_message_id":"62188e9e041117e28813e3225fe1d1c5fdadac5a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"case \"$REPO_VERSION\" in"},{"line_number":76,"context_line":"    *stable*)"},{"line_number":77,"context_line":"        CONSTRAINTS_BRANCH_CLEAN\u003d\"$REPO_VERSION\""},{"line_number":78,"context_line":"        CONSTRAINTS_FILE\u003d${CONSTRAINTS_FILE/master/$CONSTRAINTS_BRANCH_CLEAN}"},{"line_number":79,"context_line":"        # Get monasca-common version from stable upper constraints file."},{"line_number":80,"context_line":"        CONSTRAINTS_TMP_FILE\u003d$(mktemp)"},{"line_number":81,"context_line":"        wget --output-document \"$CONSTRAINTS_TMP_FILE\" \\"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dfbec78f_b0069e51","line":78,"in_reply_to":"dfbec78f_b0c8dea5","updated":"2019-05-16 11:28:14.000000000","message":"previously we could select the branch using e.g ?h\u003dstable/pike. since now the branch is selected with, e.g.\nopendev.org/openstack/requirements/raw/branch/master/upper-constraints.txt, if user selects a \u0027stable\u0027 branch, the master part gets replaced using this command and becomes like this:\nopendev.org/openstack/requirements/raw/branch/stable/pike/upper-constraints.txt","commit_id":"847f50d025b59a3862f494e2011a0484199dc930"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"73a51a923b469736dd080b608133745b8ebef739","unresolved":false,"context_lines":[{"line_number":75,"context_line":"case \"$REPO_VERSION\" in"},{"line_number":76,"context_line":"    *stable*)"},{"line_number":77,"context_line":"        CONSTRAINTS_BRANCH_CLEAN\u003d\"$REPO_VERSION\""},{"line_number":78,"context_line":"        CONSTRAINTS_FILE\u003d${CONSTRAINTS_FILE/master/$CONSTRAINTS_BRANCH_CLEAN}"},{"line_number":79,"context_line":"        # Get monasca-common version from stable upper constraints file."},{"line_number":80,"context_line":"        CONSTRAINTS_TMP_FILE\u003d$(mktemp)"},{"line_number":81,"context_line":"        wget --output-document \"$CONSTRAINTS_TMP_FILE\" \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"dfbec78f_8d757cfc","line":78,"range":{"start_line":78,"start_character":7,"end_line":78,"end_character":77},"updated":"2019-05-15 14:57:15.000000000","message":"For stable rocky are you going to generate something like this:\n\n`https://opendev.org/openstack/requirements/raw/branch/master/upper-constraints.txt/master/stable/rocky\n`\n\nWhen what you want is this?\n\n`\nhttps://opendev.org/openstack/requirements/raw/branch/stable/rocky/upper-constraints.txt\n`","commit_id":"3c910ec440ff12839e1611a65babae104e388911"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"4fb7a5c1ca018e7a8c90b27b785a306016d5f2c3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"case \"$REPO_VERSION\" in"},{"line_number":76,"context_line":"    *stable*)"},{"line_number":77,"context_line":"        CONSTRAINTS_BRANCH_CLEAN\u003d\"$REPO_VERSION\""},{"line_number":78,"context_line":"        CONSTRAINTS_FILE\u003d${CONSTRAINTS_FILE/master/$CONSTRAINTS_BRANCH_CLEAN}"},{"line_number":79,"context_line":"        # Get monasca-common version from stable upper constraints file."},{"line_number":80,"context_line":"        CONSTRAINTS_TMP_FILE\u003d$(mktemp)"},{"line_number":81,"context_line":"        wget --output-document \"$CONSTRAINTS_TMP_FILE\" \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"dfbec78f_ed019839","line":78,"range":{"start_line":78,"start_character":7,"end_line":78,"end_character":77},"in_reply_to":"dfbec78f_8d757cfc","updated":"2019-05-15 15:05:30.000000000","message":"I missed this was a pattern replacement, I think this is ok.","commit_id":"3c910ec440ff12839e1611a65babae104e388911"},{"author":{"_account_id":30221,"name":"Arseni Lipinski","email":"arseni.lipinski@ts.fujitsu.com","username":"arseni.lipinski"},"change_message_id":"62188e9e041117e28813e3225fe1d1c5fdadac5a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"case \"$REPO_VERSION\" in"},{"line_number":76,"context_line":"    *stable*)"},{"line_number":77,"context_line":"        CONSTRAINTS_BRANCH_CLEAN\u003d\"$REPO_VERSION\""},{"line_number":78,"context_line":"        CONSTRAINTS_FILE\u003d${CONSTRAINTS_FILE/master/$CONSTRAINTS_BRANCH_CLEAN}"},{"line_number":79,"context_line":"        # Get monasca-common version from stable upper constraints file."},{"line_number":80,"context_line":"        CONSTRAINTS_TMP_FILE\u003d$(mktemp)"},{"line_number":81,"context_line":"        wget --output-document \"$CONSTRAINTS_TMP_FILE\" \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"dfbec78f_0d9e6c06","line":78,"range":{"start_line":78,"start_character":7,"end_line":78,"end_character":77},"in_reply_to":"dfbec78f_8d757cfc","updated":"2019-05-16 11:28:14.000000000","message":"this operator replaces \u0027master\u0027 with $constraints_branch_clean in $constraints_file so the output is exactly the way we need","commit_id":"3c910ec440ff12839e1611a65babae104e388911"},{"author":{"_account_id":21922,"name":"Dobroslaw Zybort","email":"dobroslaw.zybort@ts.fujitsu.com","username":"dobrolaw.zybort"},"change_message_id":"d48c74b832df065b509a46dc1175738563799e11","unresolved":false,"context_lines":[{"line_number":59,"context_line":"REPO_VERSION_CLEAN\u003d$(echo \"$REPO_VERSION\" | sed \u0027s|/|-|g\u0027)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"[ -z \"$APP_REPO\" ] \u0026\u0026 APP_REPO\u003d$(\\grep APP_REPO Dockerfile | cut -f2 -d\"\u003d\")"},{"line_number":62,"context_line":"GITHUB_REPO\u003d$(echo \"$APP_REPO\" | sed \u0027s/opendev.org/github.com/\u0027 | \\"},{"line_number":63,"context_line":"              sed \u0027s/ssh:/https:/\u0027)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"if [ -z \"$CONSTRAINTS_FILE\" ]; then"}],"source_content_type":"text/x-sh","patch_set":10,"id":"bfb3d3c7_823b95cf","line":62,"range":{"start_line":62,"start_character":40,"end_line":62,"end_character":47},"updated":"2019-05-21 12:14:09.000000000","message":"review.opendev","commit_id":"8f191304feb86ecfbe35ca3ae4ab7c7aaa2f74c0"}]}
