)]}'
{"id":"openstack%2Fpython-neutronclient~12662","triplet_id":"openstack%2Fpython-neutronclient~master~I87a66e80a42304508e3e9bc3afbe275b41918404","project":"openstack/python-neutronclient","branch":"master","topic":"bug/1048081","hashtags":[],"change_id":"I87a66e80a42304508e3e9bc3afbe275b41918404","subject":"Send all options with CreateFloatingIP","status":"MERGED","created":"2012-09-10 23:09:22.000000000","updated":"2012-09-10 23:09:22.000000000","submitted":"2012-09-10 23:09:22.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b721c8021b65793154469b9444d2d6b2c0d0a399","_number":12662,"virtual_id_number":12662,"owner":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2012-09-10 23:09:22.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":0,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-09-10 23:09:22.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"date":"2012-09-10 23:09:22.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":2,"date":"2012-09-10 23:09:22.000000000","_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":0,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-09-10 23:09:22.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"date":"2012-09-10 23:09:22.000000000","_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":1,"date":"2012-09-10 23:09:22.000000000","_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":0,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-09-10 23:09:22.000000000","updated_by":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"reviewer":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"state":"REVIEWER"},{"updated":"2012-09-10 23:09:22.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2012-09-10 23:09:22.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2012-09-10 23:09:22.000000000","updated_by":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"reviewer":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"state":"REVIEWER"},{"updated":"2012-09-10 23:09:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8cdca147d050abf689ccb7942f988039b82d984c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-10 23:09:22.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/12662/1/check/gate-python-quantumclient-merge/221 : SUCCESS\n- http://logs.openstack.org/12662/1/check/gate-python-quantumclient-docs/104 : SUCCESS\n- http://logs.openstack.org/12662/1/check/gate-python-quantumclient-pep8/186 : FAILURE\n- http://logs.openstack.org/12662/1/check/gate-python-quantumclient-python26/165 : SUCCESS\n- http://logs.openstack.org/12662/1/check/gate-python-quantumclient-python27/164 : SUCCESS\n- http://logs.openstack.org/12662/1/check/gate-tempest-devstack-vm/10907 : SUCCESS\n- http://logs.openstack.org/12662/1/check/gate-tempest-devstack-vm-cinder/888 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"3556377f1fcba56e16075ac22f0bae5ead01c390","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-10 23:09:22.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12662/2/check/gate-python-quantumclient-merge/223 : SUCCESS\n- http://logs.openstack.org/12662/2/check/gate-python-quantumclient-docs/106 : SUCCESS\n- http://logs.openstack.org/12662/2/check/gate-python-quantumclient-pep8/188 : SUCCESS\n- http://logs.openstack.org/12662/2/check/gate-python-quantumclient-python26/167 : SUCCESS\n- http://logs.openstack.org/12662/2/check/gate-python-quantumclient-python27/166 : SUCCESS\n- http://logs.openstack.org/12662/2/check/gate-tempest-devstack-vm/10933 : SUCCESS\n- http://logs.openstack.org/12662/2/check/gate-tempest-devstack-vm-cinder/914 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"19f283c7a036d6507e0af5dce5ee74c1b046a97a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-10 23:09:22.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"94adef6cd85c2537c973db75bf366e9f148b0962","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2012-09-10 23:09:22.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b8b4bdb79aea42f11aca960a3904adc4fc053a11","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2012-09-10 23:09:22.000000000","message":"Patch Set 2:\n\nIn my environment instead I see a different behaviour. Hopefully it\u0027s just me not using the CLI in the right way - so we can just abandon the patch.\n\nWithout the change: http://paste.openstack.org/show/20789/\nFloating IP with missing data created\n\nWith the change: http://paste.openstack.org/show/20790/\nFloating IP creation fails because the address does not exist on the specified port (and hence the server has received port_id and fixed_ip_address)\n\nI\u0027ve noticed that this change is transparent to unit tests. args2body is invoked by the unit tests, I am trying to understand why the difference is not spotted there.","accounts_in_message":[],"_revision_number":2},{"id":"f42711f94bd31c9787c6965c96b5d0367a9b9c16","author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"date":"2012-09-10 23:09:22.000000000","message":"Patch Set 1:\n\ni\u0027m not sure this is needed.... my testing shows that --port_id works without this change.  I\u0027d like yong to comment.","accounts_in_message":[],"_revision_number":1},{"id":"40b51e532d1d69737745cadd32ab135e21e3e22c","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2012-09-10 23:09:22.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"e5f8035beef1d0e736f49821792494532e2cd356","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2012-09-10 23:09:22.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"7221bbd7fa2b61f80631dd3668db73d725e0a4e9","author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"date":"2012-09-10 23:09:22.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"ddbecf2e5a943ea106af2827d17c172268fe236c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-10 23:09:22.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/12662/2/gate/gate-python-quantumclient-merge/227 : SUCCESS\n- http://logs.openstack.org/12662/2/gate/gate-python-quantumclient-docs/110 : SUCCESS\n- http://logs.openstack.org/12662/2/gate/gate-python-quantumclient-pep8/192 : SUCCESS\n- http://logs.openstack.org/12662/2/gate/gate-python-quantumclient-python26/171 : SUCCESS\n- http://logs.openstack.org/12662/2/gate/gate-python-quantumclient-python27/170 : SUCCESS\n- http://logs.openstack.org/12662/2/gate/gate-tempest-devstack-vm/11083 : SUCCESS\n- http://logs.openstack.org/12662/2/gate/gate-tempest-devstack-vm-cinder/1064 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"5630e2876f0fb7b4abf4e91122e1f02a25ed3c94","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-10 23:09:22.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2dd97991dff0831689fdad29d2ff2b942bf75ae9","revisions":{"7c804e6a1e81a5af2bf0d85ae870074e2945dc1e":{"kind":"REWORK","_number":1,"created":"2012-09-10 23:09:22.000000000","uploader":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"ref":"refs/changes/62/12662/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/62/12662/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/62/12662/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/62/12662/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/62/12662/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/62/12662/1"}}},"commit":{"parents":[{"commit":"99d7d7000da385aec82a900ed180014402f783d6","subject":"router/floating commands support resource reference by name","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/99d7d7000da385aec82a900ed180014402f783d6"}]}],"author":{"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","date":"2012-09-09 01:11:14.000000000","tz":-420},"committer":{"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","date":"2012-09-09 01:42:02.000000000","tz":-420},"subject":"Send all options with CreateFloatingIP","message":"Send all options with CreateFloatingIP\n\nFix Bug 1048081\n\nChange-Id: I87a66e80a42304508e3e9bc3afbe275b41918404\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/7c804e6a1e81a5af2bf0d85ae870074e2945dc1e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/7c804e6a1e81a5af2bf0d85ae870074e2945dc1e"}]},"branch":"refs/heads/master"},"2dd97991dff0831689fdad29d2ff2b942bf75ae9":{"kind":"REWORK","_number":2,"created":"2012-09-10 23:09:22.000000000","uploader":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"ref":"refs/changes/62/12662/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/62/12662/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/62/12662/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/62/12662/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/62/12662/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/62/12662/2"}}},"commit":{"parents":[{"commit":"99d7d7000da385aec82a900ed180014402f783d6","subject":"router/floating commands support resource reference by name","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/99d7d7000da385aec82a900ed180014402f783d6"}]}],"author":{"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","date":"2012-09-09 01:11:14.000000000","tz":-420},"committer":{"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","date":"2012-09-09 09:59:57.000000000","tz":-420},"subject":"Send all options with CreateFloatingIP","message":"Send all options with CreateFloatingIP\n\nFix Bug 1048081\n\nChange-Id: I87a66e80a42304508e3e9bc3afbe275b41918404\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/2dd97991dff0831689fdad29d2ff2b942bf75ae9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/2dd97991dff0831689fdad29d2ff2b942bf75ae9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}