)]}'
{"id":"openstack%2Fpython-neutronclient~12663","triplet_id":"openstack%2Fpython-neutronclient~master~I5939a2a28ae4abf94d44fadb75a657fe706f1295","project":"openstack/python-neutronclient","branch":"master","topic":"bug/1048088","hashtags":[],"change_id":"I5939a2a28ae4abf94d44fadb75a657fe706f1295","subject":"prevent floatingip-show and floatingip-delete from querying by \"name\"","status":"MERGED","created":"2012-09-10 23:06:45.000000000","updated":"2012-09-10 23:06:45.000000000","submitted":"2012-09-10 23:06:45.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"78ea339cddaced7aa89cd6c5a0de201f516e2108","_number":12663,"virtual_id_number":12663,"owner":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},{"value":2,"date":"2012-09-10 23:06:45.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":0,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"recommended":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"all":[{"value":1,"date":"2012-09-10 23:06:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-09-10 23:06:45.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":2,"date":"2012-09-10 23:06:45.000000000","_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":0,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"all":[{"value":0,"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-09-10 23:06:45.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":1,"date":"2012-09-10 23:06:45.000000000","_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"value":0,"date":"2012-09-10 23:06:45.000000000","_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-09-10 23:06:45.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2012-09-10 23:06:45.000000000","updated_by":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"reviewer":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"state":"REVIEWER"},{"updated":"2012-09-10 23:06:45.000000000","updated_by":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"reviewer":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"state":"REVIEWER"},{"updated":"2012-09-10 23:06:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"039efd0c7085ed3363641dd1d2f2a426c633ab23","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-10 23:06:45.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed\n\n- http://logs.openstack.org/12663/1/check/gate-python-quantumclient-merge/222 : SUCCESS\n- http://logs.openstack.org/12663/1/check/gate-python-quantumclient-docs/105 : SUCCESS\n- http://logs.openstack.org/12663/1/check/gate-python-quantumclient-pep8/187 : FAILURE\n- http://logs.openstack.org/12663/1/check/gate-python-quantumclient-python26/166 : SUCCESS\n- http://logs.openstack.org/12663/1/check/gate-python-quantumclient-python27/165 : SUCCESS\n- http://logs.openstack.org/12663/1/check/gate-tempest-devstack-vm/10908 : SUCCESS\n- http://logs.openstack.org/12663/1/check/gate-tempest-devstack-vm-cinder/889 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"506d8759535a1ad9fd019be72f2a152953a2b403","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-10 23:06:45.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12663/2/check/gate-python-quantumclient-merge/224 : SUCCESS\n- http://logs.openstack.org/12663/2/check/gate-python-quantumclient-docs/107 : SUCCESS\n- http://logs.openstack.org/12663/2/check/gate-python-quantumclient-pep8/189 : SUCCESS\n- http://logs.openstack.org/12663/2/check/gate-python-quantumclient-python26/168 : SUCCESS\n- http://logs.openstack.org/12663/2/check/gate-python-quantumclient-python27/167 : SUCCESS\n- http://logs.openstack.org/12663/2/check/gate-tempest-devstack-vm/10949 : SUCCESS\n- http://logs.openstack.org/12663/2/check/gate-tempest-devstack-vm-cinder/930 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"8dd68b79fe548c12de5278f15eba9f4d6043d364","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-10 23:06:45.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"a6e626fc00016ccd69f5fef6ede8922356dc4fad","author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"date":"2012-09-10 23:06:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"fd31b1ff3fafcb400655282b294fa4627e7b6f3c","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2012-09-10 23:06:45.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nLooks good. Tested and works","accounts_in_message":[],"_revision_number":2},{"id":"798f5ba772667466ccdf038f967543b620d99a75","author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"date":"2012-09-10 23:06:45.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"c25790e14cc44ea33e5ad569ae53ebc555f482a8","author":{"_account_id":3217,"name":"Ian Wells","username":"ijw-ubuntu"},"date":"2012-09-10 23:06:45.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"0aeab714561b86554019d55b89fdf02e8e8970f3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-10 23:06:45.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/12663/2/gate/gate-python-quantumclient-merge/226 : SUCCESS\n- http://logs.openstack.org/12663/2/gate/gate-python-quantumclient-docs/109 : SUCCESS\n- http://logs.openstack.org/12663/2/gate/gate-python-quantumclient-pep8/191 : SUCCESS\n- http://logs.openstack.org/12663/2/gate/gate-python-quantumclient-python26/170 : SUCCESS\n- http://logs.openstack.org/12663/2/gate/gate-python-quantumclient-python27/169 : SUCCESS\n- http://logs.openstack.org/12663/2/gate/gate-tempest-devstack-vm/11082 : SUCCESS\n- http://logs.openstack.org/12663/2/gate/gate-tempest-devstack-vm-cinder/1063 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"cdb5cbe0664843108fb65bf25629bc438f36e2a1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-10 23:06:45.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"75fcafbbc6872be61dab3cbdd3c9f63dec3cf09c","revisions":{"74c24c45bdf329503ef57f70e85d73326a8f4508":{"kind":"REWORK","_number":1,"created":"2012-09-10 23:06:45.000000000","uploader":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"ref":"refs/changes/63/12663/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/63/12663/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/63/12663/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/63/12663/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/63/12663/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/63/12663/1"}}},"commit":{"parents":[{"commit":"99d7d7000da385aec82a900ed180014402f783d6","subject":"router/floating commands support resource reference by name","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/99d7d7000da385aec82a900ed180014402f783d6"}]}],"author":{"name":"Dan Wendlandt","email":"dan@nicira.com","date":"2012-09-09 02:44:24.000000000","tz":-420},"committer":{"name":"Dan Wendlandt","email":"dan@nicira.com","date":"2012-09-09 02:44:24.000000000","tz":-420},"subject":"prevent floatingip-show and floatingip-delete from querying by \"name\"","message":"prevent floatingip-show and floatingip-delete from querying by \"name\"\n\nbug 1048088\n\nfloating IPs do not have names, but the show and delete commands\ninherited logic that implied that they did, leading to very odd results\nthat would result is \"floating-ip show X\" return a result even if X\nwas not a valid UUID for any floating IP.\n\nChange-Id: I5939a2a28ae4abf94d44fadb75a657fe706f1295\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/74c24c45bdf329503ef57f70e85d73326a8f4508"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/74c24c45bdf329503ef57f70e85d73326a8f4508"}]},"branch":"refs/heads/master"},"75fcafbbc6872be61dab3cbdd3c9f63dec3cf09c":{"kind":"REWORK","_number":2,"created":"2012-09-10 23:06:45.000000000","uploader":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"ref":"refs/changes/63/12663/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/63/12663/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/63/12663/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/63/12663/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/63/12663/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/63/12663/2"}}},"commit":{"parents":[{"commit":"99d7d7000da385aec82a900ed180014402f783d6","subject":"router/floating commands support resource reference by name","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/99d7d7000da385aec82a900ed180014402f783d6"}]}],"author":{"name":"Dan Wendlandt","email":"dan@nicira.com","date":"2012-09-09 16:14:33.000000000","tz":-420},"committer":{"name":"Dan Wendlandt","email":"dan@nicira.com","date":"2012-09-09 16:14:33.000000000","tz":-420},"subject":"prevent floatingip-show and floatingip-delete from querying by \"name\"","message":"prevent floatingip-show and floatingip-delete from querying by \"name\"\n\nbug 1048088\n\nfloating IPs do not have names, but the show and delete commands\ninherited logic that implied that they did, leading to very odd results\nthat would result is \"floating-ip show X\" return a result even if X\nwas not a valid UUID for any floating IP.\n\nChange-Id: I5939a2a28ae4abf94d44fadb75a657fe706f1295\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/75fcafbbc6872be61dab3cbdd3c9f63dec3cf09c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/75fcafbbc6872be61dab3cbdd3c9f63dec3cf09c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}