)]}'
{"neutronclient/neutron/v2_0/port.py":[{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"f420bcee6ecfca99c9a9a41aad01c34912e55cbe","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            \u0027--admin-state-up\u0027,"},{"line_number":238,"context_line":"            dest\u003d\u0027admin_state\u0027,"},{"line_number":239,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":240,"context_line":"            help\u003d_(\u0027Set a value of Admin State Up\u0027))"},{"line_number":241,"context_line":"        parser.add_argument("},{"line_number":242,"context_line":"            \u0027--admin_state_up\u0027,"},{"line_number":243,"context_line":"            dest\u003d\u0027admin_state\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_fd7ee168","line":240,"updated":"2014-11-17 16:41:37.000000000","message":"nit: loss dot here.","commit_id":"3c2f1decfeca69dfa420e2a02a7f15966581c736"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a67c0e6efd34978d906cf68d1183fe4a46c6ab51","unresolved":false,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    resource \u003d \u0027port\u0027"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":233,"context_line":"        parser.add_argument("},{"line_number":234,"context_line":"            \u0027--name\u0027,"},{"line_number":235,"context_line":"            help\u003d_(\u0027Name of this port.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_b67e1c17","line":232,"updated":"2014-11-18 12:54:22.000000000","message":"Could you share common argument definitions between create and update as some other commands do?","commit_id":"afce65b2b33f5f07a04aa4491c6551e19ae2c7ee"},{"author":{"_account_id":13467,"name":"P. Watsalya Mishra","email":"watsalya.mishra@tcs.com","username":"watsalya"},"change_message_id":"b7963f78ff7b5c19bd5a986640512b00d8f175f0","unresolved":false,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    resource \u003d \u0027port\u0027"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":233,"context_line":"        parser.add_argument("},{"line_number":234,"context_line":"            \u0027--name\u0027,"},{"line_number":235,"context_line":"            help\u003d_(\u0027Name of this port.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_50e87c16","line":232,"in_reply_to":"5a890539_b67e1c17","updated":"2014-11-21 05:42:24.000000000","message":"Ok. I can create functions containing common argument definitions between create and update as used in \"subnet\" command. But their are only 2 common arguments(viz. --name and --device-id) shared between create and update port commands. I have also checked code for \"security-group\" command that uses the same convention for its 2 common arguments (viz. --name and --description) as I have used here. So, what is your suggestion on the convention that should be followed here?","commit_id":"afce65b2b33f5f07a04aa4491c6551e19ae2c7ee"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a67c0e6efd34978d906cf68d1183fe4a46c6ab51","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            \u0027--admin_state_up\u0027,"},{"line_number":243,"context_line":"            dest\u003d\u0027admin_state\u0027,"},{"line_number":244,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":245,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":246,"context_line":"        parser.add_argument("},{"line_number":247,"context_line":"            \u0027--device-id\u0027,"},{"line_number":248,"context_line":"            help\u003d_(\u0027Device ID of this port.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_16a7f0a7","line":245,"updated":"2014-11-18 12:54:22.000000000","message":"Do we still define the underscore style option here?","commit_id":"afce65b2b33f5f07a04aa4491c6551e19ae2c7ee"},{"author":{"_account_id":13467,"name":"P. Watsalya Mishra","email":"watsalya.mishra@tcs.com","username":"watsalya"},"change_message_id":"b7963f78ff7b5c19bd5a986640512b00d8f175f0","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            \u0027--admin_state_up\u0027,"},{"line_number":243,"context_line":"            dest\u003d\u0027admin_state\u0027,"},{"line_number":244,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":245,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":246,"context_line":"        parser.add_argument("},{"line_number":247,"context_line":"            \u0027--device-id\u0027,"},{"line_number":248,"context_line":"            help\u003d_(\u0027Device ID of this port.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_04407534","line":245,"in_reply_to":"5a890539_16a7f0a7","updated":"2014-11-21 05:42:24.000000000","message":"Yes. The user can use underscore style as well to update port using this option. I have followed the same coding convention as was used for other options and in other commands as well. If I don\u0027t use it here then it will become inconsistent with respect to other such options.","commit_id":"afce65b2b33f5f07a04aa4491c6551e19ae2c7ee"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a67c0e6efd34978d906cf68d1183fe4a46c6ab51","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    def args2body(self, parsed_args):"},{"line_number":262,"context_line":"        body \u003d {\u0027port\u0027: {}}"},{"line_number":263,"context_line":"        if parsed_args.name:"},{"line_number":264,"context_line":"            body[\u0027port\u0027].update({\u0027name\u0027: parsed_args.name})"},{"line_number":265,"context_line":"        if parsed_args.admin_state:"},{"line_number":266,"context_line":"            body[\u0027port\u0027].update({\u0027admin_state_up\u0027: parsed_args.admin_state})"},{"line_number":267,"context_line":"        if parsed_args.device_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_d679e82f","line":264,"updated":"2014-11-18 12:54:22.000000000","message":"There is no need to use update().\n\n  if parsed_args.name:\n      body[\u0027port\u0027][\u0027name\u0027] \u003d parsed_args.name","commit_id":"afce65b2b33f5f07a04aa4491c6551e19ae2c7ee"},{"author":{"_account_id":13467,"name":"P. Watsalya Mishra","email":"watsalya.mishra@tcs.com","username":"watsalya"},"change_message_id":"b7963f78ff7b5c19bd5a986640512b00d8f175f0","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    def args2body(self, parsed_args):"},{"line_number":262,"context_line":"        body \u003d {\u0027port\u0027: {}}"},{"line_number":263,"context_line":"        if parsed_args.name:"},{"line_number":264,"context_line":"            body[\u0027port\u0027].update({\u0027name\u0027: parsed_args.name})"},{"line_number":265,"context_line":"        if parsed_args.admin_state:"},{"line_number":266,"context_line":"            body[\u0027port\u0027].update({\u0027admin_state_up\u0027: parsed_args.admin_state})"},{"line_number":267,"context_line":"        if parsed_args.device_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_f5723ae2","line":264,"in_reply_to":"5a890539_d679e82f","updated":"2014-11-21 05:42:24.000000000","message":"I have checked \"securitygroup.py\" and \"subnet.py\" scripts in the same directory where this \"port.py\" file is present. The \"UpdateSecurityGroup\" and \"UpdateSubnet\" has used the similar way to update name in their \"args2body\" method as I have used here. Could you please explain, why do I need to change it the way you have suggested here, as this change will make it inconsistent with respect to same option in other commands.","commit_id":"afce65b2b33f5f07a04aa4491c6551e19ae2c7ee"}]}