)]}'
{".eggs/README.txt":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4869e8b4c2da9723f61be3992ba799b4273852fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory contains eggs that were downloaded by setuptools to build, test, and run plug-ins."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This directory caches those eggs to prevent repeated downloads."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"However, it is safe to delete this directory."},{"line_number":6,"context_line":""}],"source_content_type":"text/plain","patch_set":7,"id":"7a740942_014c1841","line":3,"updated":"2015-12-04 03:43:57.000000000","message":"Is this file really required?","commit_id":"c43b032825b6f1178fe1eccb713787e9593459b0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"09e549c9142250fad55b6e465ee9bf198a886b4d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory contains eggs that were downloaded by setuptools to build, test, and run plug-ins."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This directory caches those eggs to prevent repeated downloads."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"However, it is safe to delete this directory."},{"line_number":6,"context_line":""}],"source_content_type":"text/plain","patch_set":7,"id":"7a740942_855c4dee","line":3,"in_reply_to":"7a740942_014c1841","updated":"2015-12-07 01:56:36.000000000","message":"I dont know where it came from :)\nRemoving it","commit_id":"c43b032825b6f1178fe1eccb713787e9593459b0"}],"/COMMIT_MSG":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"abcda7d471d98f50f58e1aab115ad2465e66ed61","unresolved":false,"context_lines":[{"line_number":7,"context_line":"\"neutron help net-list\" help info updated"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Initially we were unable to see complete help info for \"neutron net-list\""},{"line_number":10,"context_line":"command.Now, with this patch complete help info is displayed to the user."},{"line_number":11,"context_line":"Apart from the existing information, the following information will also"},{"line_number":12,"context_line":"be displayed:-"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a740942_c050a70d","line":10,"updated":"2015-12-08 14:09:49.000000000","message":"nit: space after period","commit_id":"c7da46fec82683718cdd577484c7f3a39a5c988f"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"abcda7d471d98f50f58e1aab115ad2465e66ed61","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Initially we were unable to see complete help info for \"neutron net-list\""},{"line_number":10,"context_line":"command.Now, with this patch complete help info is displayed to the user."},{"line_number":11,"context_line":"Apart from the existing information, the following information will also"},{"line_number":12,"context_line":"be displayed:-"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    --name"},{"line_number":15,"context_line":"    --status"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a740942_a059db36","line":12,"updated":"2015-12-08 14:09:49.000000000","message":"nit: remove trailing dash","commit_id":"c7da46fec82683718cdd577484c7f3a39a5c988f"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b921a7867bdf3d1156ea48ec0ac40b03f247020a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Reedip \u003creedip.banerjee@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-29 09:07:17 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\"neutron help net-list\" help info updated"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This implements a common framework for attribute filtering arguments"},{"line_number":10,"context_line":"and arguments for net-list as an initial support."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"5a5ae5dd_cf5d7116","line":7,"updated":"2016-02-05 04:58:50.000000000","message":"I think this summary statement isn\u0027t quite accurate. This is support for filtering arguments isn\u0027t it?","commit_id":"c0d79dc971dae90e9b6ce9f462b77de844568c43"}],"neutronclient/common/utils.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4869e8b4c2da9723f61be3992ba799b4273852fc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import logging"},{"line_number":22,"context_line":"import os"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import netaddr"},{"line_number":25,"context_line":"from oslo_utils import encodeutils"},{"line_number":26,"context_line":"from oslo_utils import importutils"},{"line_number":27,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_4158e0fa","line":24,"updated":"2015-12-04 03:43:57.000000000","message":"I believe this change is relevant for this patch.","commit_id":"c43b032825b6f1178fe1eccb713787e9593459b0"},{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"c428392ba06d2442babe19c493f83cff28ebd698","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import logging"},{"line_number":22,"context_line":"import os"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import netaddr"},{"line_number":25,"context_line":"from oslo_utils import encodeutils"},{"line_number":26,"context_line":"from oslo_utils import importutils"},{"line_number":27,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_0c78cfc3","line":24,"updated":"2015-12-04 05:07:49.000000000","message":"why import netaddr moved to down?","commit_id":"c43b032825b6f1178fe1eccb713787e9593459b0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"09e549c9142250fad55b6e465ee9bf198a886b4d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import logging"},{"line_number":22,"context_line":"import os"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import netaddr"},{"line_number":25,"context_line":"from oslo_utils import encodeutils"},{"line_number":26,"context_line":"from oslo_utils import importutils"},{"line_number":27,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_25fa3976","line":24,"in_reply_to":"7a740942_0c78cfc3","updated":"2015-12-07 01:56:36.000000000","message":"Was some issue with pep8 earlier.\nrearranged it","commit_id":"c43b032825b6f1178fe1eccb713787e9593459b0"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5c4ba90eb9081fb6133fb15fbf49724e791348a4","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        return False"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"def convert_to_uppercase(string):"},{"line_number":192,"context_line":"    return string.upper()"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_63250009","line":191,"updated":"2015-12-09 13:26:58.000000000","message":"Could you please make your patch dependent upon \"https://review.openstack.org/#/c/238325\". Similar function is being defined in this patch.","commit_id":"1c2fe19fb40c7ab6a3ab1017a605a92785569034"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"90567806cbf4a81091f00fc11f7c9be6d8e802c0","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        return False"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"def convert_to_uppercase(string):"},{"line_number":192,"context_line":"    return string.upper()"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_c38ccd81","line":191,"in_reply_to":"7a740942_63250009","updated":"2015-12-10 03:36:36.000000000","message":"Done\n\nBut I suggest keeping this function at the bottom( generally new functions should be added at the end instead of adding in the middle , atleast for utils.)","commit_id":"1c2fe19fb40c7ab6a3ab1017a605a92785569034"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6db97cff789c2bbc2361bc8831991465c66ef30f","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"def convert_to_lowercase(string):"},{"line_number":196,"context_line":"    return string.lower()"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a740942_695b7755","line":196,"updated":"2015-12-10 06:52:37.000000000","message":"Consider moving it to around convert_to_uppercase.","commit_id":"6b35e5255e11870309c287099fb802826167cc8a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"11eb1cb1044a7a4c5b218887d83301caa3de87ed","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"def convert_to_lowercase(string):"},{"line_number":196,"context_line":"    return string.lower()"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a740942_299ec1b8","line":196,"in_reply_to":"7a740942_54ac12ed","updated":"2015-12-10 11:07:55.000000000","message":"I just want to say that these two methods should be located at some place. The exact place does not matter.","commit_id":"6b35e5255e11870309c287099fb802826167cc8a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"683a0d24ef9fe7b36b374a8c4abcbe743556bfca","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"def convert_to_lowercase(string):"},{"line_number":196,"context_line":"    return string.lower()"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a740942_54ac12ed","line":196,"in_reply_to":"7a740942_695b7755","updated":"2015-12-10 07:00:16.000000000","message":"Ok, but I disagree with the fact that the function convert_to_uppercase is declared in the middle of the file.","commit_id":"6b35e5255e11870309c287099fb802826167cc8a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ff0896df4f3bbbcd78ad8490cafa295649ed89ad","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def convert_to_lowercase(string):"},{"line_number":50,"context_line":"    return string.lower()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def get_client_class(api_name, version, version_map):"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a710552_5ddac779","line":50,"updated":"2015-12-16 07:50:30.000000000","message":"unrelated change?","commit_id":"33e5691464a2b53c8c4d9ce228de87f1082ac5ad"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"4e912a2ba1aaeb6faa3f3a25215d24b4d1e1e357","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def convert_to_lowercase(string):"},{"line_number":50,"context_line":"    return string.lower()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def get_client_class(api_name, version, version_map):"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa69d971_8a96b24a","line":50,"in_reply_to":"1a7b0d38_3aa146aa","updated":"2016-01-04 04:26:53.000000000","message":"I would suggest this to be a separate change.","commit_id":"33e5691464a2b53c8c4d9ce228de87f1082ac5ad"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7e3f00b8a406943cbd9c5661c320444b28650bd5","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def convert_to_lowercase(string):"},{"line_number":50,"context_line":"    return string.lower()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def get_client_class(api_name, version, version_map):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a7b0d38_3aa146aa","line":50,"in_reply_to":"5a710552_5ddac779","updated":"2015-12-23 04:31:10.000000000","message":"No, it is related.\nKeeping this function here is required for the patches dependent on the following code change.As this is a central patch with multiple cross dependencies across other patches, I thought of keeping the central change here","commit_id":"33e5691464a2b53c8c4d9ce228de87f1082ac5ad"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d2e1e48725b0079faa5ef355a80a2435fa6b61d2","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def convert_to_lowercase(string):"},{"line_number":50,"context_line":"    return string.lower()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def get_client_class(api_name, version, version_map):"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa69d971_2426ab15","line":50,"in_reply_to":"fa69d971_35791b30","updated":"2016-01-05 02:46:07.000000000","message":"Hi Vikram, \nThanks for the support, but I guess the score is 3-Against and 2-For.\nAnyways, this is a very small change, I will put up a patch for this and work it out","commit_id":"33e5691464a2b53c8c4d9ce228de87f1082ac5ad"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c0ab4326251ef34674cb23a5d79c29d688a87918","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def convert_to_lowercase(string):"},{"line_number":50,"context_line":"    return string.lower()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def get_client_class(api_name, version, version_map):"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa69d971_35791b30","line":50,"in_reply_to":"fa69d971_8a96b24a","updated":"2016-01-04 13:07:34.000000000","message":"I am with Reedip. IMO, this doesn\u0027t require a separate patch.","commit_id":"33e5691464a2b53c8c4d9ce228de87f1082ac5ad"}],"neutronclient/neutron/v2_0/__init__.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"b0e0d111b7afb76385bc58cf80804bb442b24dfc","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    parser.add_argument("},{"line_number":154,"context_line":"        \u0027--admin_state_up\u0027,"},{"line_number":155,"context_line":"        dest\u003d\u0027admin_state\u0027,"},{"line_number":156,"context_line":"        choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":157,"context_line":"        help\u003dargparse.SUPPRESS)"},{"line_number":158,"context_line":"    parser.add_argument("},{"line_number":159,"context_line":"        \u0027--shared\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_885a2628","line":156,"updated":"2015-02-04 20:39:02.000000000","message":"boolean values are not case sensitive\n\nalso shouldn\u0027t this be argparse.SUPPRESS?","commit_id":"09bdd8bfb691a45a0e8c2b582aa02f93af8a4fa8"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"b0e0d111b7afb76385bc58cf80804bb442b24dfc","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        help\u003dargparse.SUPPRESS)"},{"line_number":158,"context_line":"    parser.add_argument("},{"line_number":159,"context_line":"        \u0027--shared\u0027,"},{"line_number":160,"context_line":"        choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":161,"context_line":"        help\u003d_(\u0027Show list of networks with specified shared option.\u0027))"},{"line_number":162,"context_line":"    parser.add_argument("},{"line_number":163,"context_line":"        \u0027--tenant-id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_686c12d1","line":160,"updated":"2015-02-04 20:39:02.000000000","message":"same as above","commit_id":"09bdd8bfb691a45a0e8c2b582aa02f93af8a4fa8"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2e6caa4813c25048adeb1acd9444bba6e56fcb78","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        default\u003dNone)"},{"line_number":148,"context_line":"    utils.add_boolean_argument("},{"line_number":149,"context_line":"        parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state\u0027,"},{"line_number":150,"context_line":"        help\u003d_(\u0027Show list of networks with specified admin state.\u0027))"},{"line_number":151,"context_line":"    utils.add_boolean_argument("},{"line_number":152,"context_line":"        parser, \u0027--admin_state_up\u0027, dest\u003d\u0027admin_state\u0027,"},{"line_number":153,"context_line":"        help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_c880868d","line":150,"updated":"2015-03-09 13:12:49.000000000","message":"consider: filter network according to their administrative state","commit_id":"9bf58d148c474844af801874a0f61e2500601e32"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2e6caa4813c25048adeb1acd9444bba6e56fcb78","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        help\u003dargparse.SUPPRESS)"},{"line_number":154,"context_line":"    utils.add_boolean_argument("},{"line_number":155,"context_line":"        parser, \u0027--shared\u0027, dest\u003d\u0027shared\u0027,"},{"line_number":156,"context_line":"        help\u003d_(\u0027Show list of networks with specified shared option.\u0027))"},{"line_number":157,"context_line":"    parser.add_argument("},{"line_number":158,"context_line":"        \u0027--tenant-id\u0027,"},{"line_number":159,"context_line":"        help\u003d_(\u0027List networks that belong to the given tenant-id.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_a87512cc","line":156,"updated":"2015-03-09 13:12:49.000000000","message":"consider rephrase: filter networks according to their sharing status","commit_id":"9bf58d148c474844af801874a0f61e2500601e32"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"2e6caa4813c25048adeb1acd9444bba6e56fcb78","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        help\u003d_(\u0027Show list of networks with specified shared option.\u0027))"},{"line_number":157,"context_line":"    parser.add_argument("},{"line_number":158,"context_line":"        \u0027--tenant-id\u0027,"},{"line_number":159,"context_line":"        help\u003d_(\u0027List networks that belong to the given tenant-id.\u0027))"},{"line_number":160,"context_line":"    parser.add_argument("},{"line_number":161,"context_line":"        \u0027--tenant_id\u0027,"},{"line_number":162,"context_line":"        help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_c89246f5","line":159,"updated":"2015-03-09 13:12:49.000000000","message":"just tenant, if you do not mind.","commit_id":"9bf58d148c474844af801874a0f61e2500601e32"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d971ec867750823b6e6d0094b40bd6b897a2158a","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state\u0027,"},{"line_number":150,"context_line":"        help\u003d_(\u0027Filter networks according to their administrative state.\u0027))"},{"line_number":151,"context_line":"    utils.add_boolean_argument("},{"line_number":152,"context_line":"        parser, \u0027--admin_state_up\u0027, dest\u003d\u0027admin_state\u0027,"},{"line_number":153,"context_line":"        help\u003dargparse.SUPPRESS)"},{"line_number":154,"context_line":"    utils.add_boolean_argument("},{"line_number":155,"context_line":"        parser, \u0027--shared\u0027, dest\u003d\u0027shared\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_af174ea2","line":152,"updated":"2015-04-07 16:09:30.000000000","message":"why defining a deprecated option?","commit_id":"9865d97709dd89871657053ccdb8b52feb3f7640"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7287685426bb71909508cd3f7f2f5509728f3e50","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state\u0027,"},{"line_number":150,"context_line":"        help\u003d_(\u0027Filter networks according to their administrative state.\u0027))"},{"line_number":151,"context_line":"    utils.add_boolean_argument("},{"line_number":152,"context_line":"        parser, \u0027--admin_state_up\u0027, dest\u003d\u0027admin_state\u0027,"},{"line_number":153,"context_line":"        help\u003dargparse.SUPPRESS)"},{"line_number":154,"context_line":"    utils.add_boolean_argument("},{"line_number":155,"context_line":"        parser, \u0027--shared\u0027, dest\u003d\u0027shared\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_bd2f6fa0","line":152,"in_reply_to":"9aa53dc9_af174ea2","updated":"2015-11-04 01:38:09.000000000","message":"Done","commit_id":"9865d97709dd89871657053ccdb8b52feb3f7640"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d971ec867750823b6e6d0094b40bd6b897a2158a","unresolved":false,"context_lines":[{"line_number":666,"context_line":"            search_opts.update("},{"line_number":667,"context_line":"                {\u0027admin_state_up\u0027: parsed_args.admin_state})"},{"line_number":668,"context_line":"        if hasattr(parsed_args, \u0027shared\u0027):"},{"line_number":669,"context_line":"            search_opts.update({\u0027shared\u0027: parsed_args.shared})"},{"line_number":670,"context_line":"        if parsed_args.tenant_id:"},{"line_number":671,"context_line":"            search_opts.update({\u0027tenant_id\u0027: parsed_args.tenant_id})"},{"line_number":672,"context_line":"        if self.pagination_support:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_cf605238","line":669,"updated":"2015-04-07 16:09:30.000000000","message":"use: \n\n  search_opts[key] \u003d values\n\ninstead of:\n\n  search_opts.update({key: value})","commit_id":"9865d97709dd89871657053ccdb8b52feb3f7640"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7287685426bb71909508cd3f7f2f5509728f3e50","unresolved":false,"context_lines":[{"line_number":666,"context_line":"            search_opts.update("},{"line_number":667,"context_line":"                {\u0027admin_state_up\u0027: parsed_args.admin_state})"},{"line_number":668,"context_line":"        if hasattr(parsed_args, \u0027shared\u0027):"},{"line_number":669,"context_line":"            search_opts.update({\u0027shared\u0027: parsed_args.shared})"},{"line_number":670,"context_line":"        if parsed_args.tenant_id:"},{"line_number":671,"context_line":"            search_opts.update({\u0027tenant_id\u0027: parsed_args.tenant_id})"},{"line_number":672,"context_line":"        if self.pagination_support:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_1d231bbf","line":669,"in_reply_to":"9aa53dc9_cf605238","updated":"2015-11-04 01:38:09.000000000","message":"Done","commit_id":"9865d97709dd89871657053ccdb8b52feb3f7640"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"f54e3170282711615aac6f46a8afb835a24311f1","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        default\u003d[])"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def add_additional_argument(parser):"},{"line_number":161,"context_line":"    parser.add_argument("},{"line_number":162,"context_line":"        \u0027--name\u0027,"},{"line_number":163,"context_line":"        help\u003d_(\"Filter networks according to their name.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_98907697","line":160,"updated":"2015-11-04 03:55:17.000000000","message":"Why we can\u0027t add inside \"add_show_list_common_argument\"?","commit_id":"908a1ee20145f3c6088ec95831bea785181c7b5d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"61ef0bab121476994b01681ed40e2e2bf19f998e","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        default\u003d[])"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def add_additional_argument(parser):"},{"line_number":161,"context_line":"    parser.add_argument("},{"line_number":162,"context_line":"        \u0027--name\u0027,"},{"line_number":163,"context_line":"        help\u003d_(\"Filter networks according to their name.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_783cb293","line":160,"in_reply_to":"fa80f949_98907697","updated":"2015-11-04 03:59:41.000000000","message":"Hm, they can be combined as the function add_show_list_common_argument  is concerned mainly  concerned with the LIST CLI´s output.","commit_id":"908a1ee20145f3c6088ec95831bea785181c7b5d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"f54e3170282711615aac6f46a8afb835a24311f1","unresolved":false,"context_lines":[{"line_number":681,"context_line":"                    self.values_specs)"},{"line_number":682,"context_line":"        search_opts \u003d self.args2search_opts(parsed_args)"},{"line_number":683,"context_line":"        search_opts.update(_extra_values)"},{"line_number":684,"context_line":"        if parsed_args.name:"},{"line_number":685,"context_line":"            search_opts[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":686,"context_line":"        if parsed_args.status:"},{"line_number":687,"context_line":"            search_opts[\u0027status\u0027] \u003d parsed_args.status"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_98b95631","line":684,"updated":"2015-11-04 03:55:17.000000000","message":"IMO. it\u0027s better to use update_dict() instead of following defined if statements.","commit_id":"908a1ee20145f3c6088ec95831bea785181c7b5d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"61ef0bab121476994b01681ed40e2e2bf19f998e","unresolved":false,"context_lines":[{"line_number":681,"context_line":"                    self.values_specs)"},{"line_number":682,"context_line":"        search_opts \u003d self.args2search_opts(parsed_args)"},{"line_number":683,"context_line":"        search_opts.update(_extra_values)"},{"line_number":684,"context_line":"        if parsed_args.name:"},{"line_number":685,"context_line":"            search_opts[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":686,"context_line":"        if parsed_args.status:"},{"line_number":687,"context_line":"            search_opts[\u0027status\u0027] \u003d parsed_args.status"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_585e8eea","line":684,"in_reply_to":"fa80f949_98b95631","updated":"2015-11-04 03:59:41.000000000","message":"update_dict takes 3 X more time than the following allocation procedure. So I would prefer using this method than the update_dict()","commit_id":"908a1ee20145f3c6088ec95831bea785181c7b5d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"28009f2945d9b59eac1e8a7c10adb2032178401b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        default\u003dNone)"},{"line_number":162,"context_line":"    parser.add_argument("},{"line_number":163,"context_line":"        \u0027--status\u0027,"},{"line_number":164,"context_line":"        help\u003d_(\"Filter networks according to their status.\"),"},{"line_number":165,"context_line":"        default\u003dNone)"},{"line_number":166,"context_line":"    utils.add_boolean_argument("},{"line_number":167,"context_line":"        parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_06fad542","line":164,"updated":"2015-11-04 13:32:07.000000000","message":"What status? This could be little confusing to the end-user.","commit_id":"71a9cb2228e26e48693e9dc214dff48383fa9159"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"28009f2945d9b59eac1e8a7c10adb2032178401b","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        default\u003dNone)"},{"line_number":166,"context_line":"    utils.add_boolean_argument("},{"line_number":167,"context_line":"        parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state\u0027,"},{"line_number":168,"context_line":"        help\u003d_(\u0027Filter networks according to their administrative state.\u0027))"},{"line_number":169,"context_line":"    utils.add_boolean_argument("},{"line_number":170,"context_line":"        parser, \u0027--shared\u0027, dest\u003d\u0027shared\u0027,"},{"line_number":171,"context_line":"        help\u003d_(\u0027Filter networks according to their sharing status.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_e620f1f9","line":168,"updated":"2015-11-04 13:32:07.000000000","message":"AFAIK, \u0027--admin-state-up\u0027 option will only consider networks which are UP. Help says \u0027Filter networks according to their administrative state.\u0027 which may also convey \u0027admin-state-down\u0027.  Can we be specific and state that the filtering will only be done for the networks which are active by the administrator.","commit_id":"71a9cb2228e26e48693e9dc214dff48383fa9159"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"aec8219292360666398354f17b8d76a30cfe08bb","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        default\u003dNone)"},{"line_number":166,"context_line":"    utils.add_boolean_argument("},{"line_number":167,"context_line":"        parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state\u0027,"},{"line_number":168,"context_line":"        help\u003d_(\u0027Filter networks according to their administrative state.\u0027))"},{"line_number":169,"context_line":"    utils.add_boolean_argument("},{"line_number":170,"context_line":"        parser, \u0027--shared\u0027, dest\u003d\u0027shared\u0027,"},{"line_number":171,"context_line":"        help\u003d_(\u0027Filter networks according to their sharing status.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_6c3609e9","line":168,"in_reply_to":"fa80f949_e620f1f9","updated":"2015-11-05 01:27:24.000000000","message":"Can be reworded as  \"Filter and list the networks which are active for the administrator.¨\nAny other rewording suggestion is welcome.","commit_id":"71a9cb2228e26e48693e9dc214dff48383fa9159"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"28009f2945d9b59eac1e8a7c10adb2032178401b","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        help\u003d_(\u0027Filter networks according to their administrative state.\u0027))"},{"line_number":169,"context_line":"    utils.add_boolean_argument("},{"line_number":170,"context_line":"        parser, \u0027--shared\u0027, dest\u003d\u0027shared\u0027,"},{"line_number":171,"context_line":"        help\u003d_(\u0027Filter networks according to their sharing status.\u0027))"},{"line_number":172,"context_line":"    parser.add_argument("},{"line_number":173,"context_line":"        \u0027--tenant-id\u0027,"},{"line_number":174,"context_line":"        help\u003d_(\u0027Filter networks belonging to the given tenant.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_266ef92f","line":171,"updated":"2015-11-04 13:32:07.000000000","message":"ditto. IMO, only shared networks will be displayed. \u0027sharing status\u0027 can be either shared or un-shared.","commit_id":"71a9cb2228e26e48693e9dc214dff48383fa9159"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"aec8219292360666398354f17b8d76a30cfe08bb","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        help\u003d_(\u0027Filter networks according to their administrative state.\u0027))"},{"line_number":169,"context_line":"    utils.add_boolean_argument("},{"line_number":170,"context_line":"        parser, \u0027--shared\u0027, dest\u003d\u0027shared\u0027,"},{"line_number":171,"context_line":"        help\u003d_(\u0027Filter networks according to their sharing status.\u0027))"},{"line_number":172,"context_line":"    parser.add_argument("},{"line_number":173,"context_line":"        \u0027--tenant-id\u0027,"},{"line_number":174,"context_line":"        help\u003d_(\u0027Filter networks belonging to the given tenant.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_6c3da9ba","line":171,"in_reply_to":"fa80f949_266ef92f","updated":"2015-11-05 01:27:24.000000000","message":"Can be reworded as : ¨Filter and list the networks which are shared¨\nLemme know if you want this to be changed.","commit_id":"71a9cb2228e26e48693e9dc214dff48383fa9159"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4869e8b4c2da9723f61be3992ba799b4273852fc","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    parser.add_argument("},{"line_number":163,"context_line":"        \u0027--status\u0027,"},{"line_number":164,"context_line":"        help\u003d_(\"Filter networks according to their operation status\""},{"line_number":165,"context_line":"               \"(For eg.ACTIVE, ERROR etc.) \"),"},{"line_number":166,"context_line":"        default\u003dNone)"},{"line_number":167,"context_line":"    utils.add_boolean_argument("},{"line_number":168,"context_line":"        parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_a13184a4","line":165,"updated":"2015-12-04 03:43:57.000000000","message":"Is the status value case sensitive? If so, better we can mention.","commit_id":"c43b032825b6f1178fe1eccb713787e9593459b0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"09e549c9142250fad55b6e465ee9bf198a886b4d","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    parser.add_argument("},{"line_number":163,"context_line":"        \u0027--status\u0027,"},{"line_number":164,"context_line":"        help\u003d_(\"Filter networks according to their operation status\""},{"line_number":165,"context_line":"               \"(For eg.ACTIVE, ERROR etc.) \"),"},{"line_number":166,"context_line":"        default\u003dNone)"},{"line_number":167,"context_line":"    utils.add_boolean_argument("},{"line_number":168,"context_line":"        parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_2528f9e1","line":165,"in_reply_to":"7a740942_a13184a4","updated":"2015-12-07 01:56:36.000000000","message":"I have made it case in-sensitive, so that it is easier for the user to pass any of the values among (Active/ACTIVE/active)\nThere is no disadvantage of this from my understanding, in fact such case-insensitivity for attributes having a value among a fixed set of values would be helpful to the user.\n\nBesides, the case criteria is already mentioned in the examples.\nIf you disagree with the case-insensitivity, please let me know.","commit_id":"c43b032825b6f1178fe1eccb713787e9593459b0"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4869e8b4c2da9723f61be3992ba799b4273852fc","unresolved":false,"context_lines":[{"line_number":170,"context_line":"               \u0027 are active for the administrator.\u0027))"},{"line_number":171,"context_line":"    utils.add_boolean_argument("},{"line_number":172,"context_line":"        parser, \u0027--shared\u0027, dest\u003d\u0027shared\u0027,"},{"line_number":173,"context_line":"        help\u003d_(\u0027Filter and list the networks which are share.\u0027))"},{"line_number":174,"context_line":"    parser.add_argument("},{"line_number":175,"context_line":"        \u0027--tenant-id\u0027,"},{"line_number":176,"context_line":"        help\u003d_(\u0027Filter networks belonging to the given tenant.\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_a1d8a454","line":173,"updated":"2015-12-04 03:43:57.000000000","message":"share \u003d\u003d\u003e shared","commit_id":"c43b032825b6f1178fe1eccb713787e9593459b0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"09e549c9142250fad55b6e465ee9bf198a886b4d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"               \u0027 are active for the administrator.\u0027))"},{"line_number":171,"context_line":"    utils.add_boolean_argument("},{"line_number":172,"context_line":"        parser, \u0027--shared\u0027, dest\u003d\u0027shared\u0027,"},{"line_number":173,"context_line":"        help\u003d_(\u0027Filter and list the networks which are share.\u0027))"},{"line_number":174,"context_line":"    parser.add_argument("},{"line_number":175,"context_line":"        \u0027--tenant-id\u0027,"},{"line_number":176,"context_line":"        help\u003d_(\u0027Filter networks belonging to the given tenant.\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_c52fb5f4","line":173,"in_reply_to":"7a740942_4c6d7703","updated":"2015-12-07 01:56:36.000000000","message":"Yeah, silly mistake :)","commit_id":"c43b032825b6f1178fe1eccb713787e9593459b0"},{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"c428392ba06d2442babe19c493f83cff28ebd698","unresolved":false,"context_lines":[{"line_number":170,"context_line":"               \u0027 are active for the administrator.\u0027))"},{"line_number":171,"context_line":"    utils.add_boolean_argument("},{"line_number":172,"context_line":"        parser, \u0027--shared\u0027, dest\u003d\u0027shared\u0027,"},{"line_number":173,"context_line":"        help\u003d_(\u0027Filter and list the networks which are share.\u0027))"},{"line_number":174,"context_line":"    parser.add_argument("},{"line_number":175,"context_line":"        \u0027--tenant-id\u0027,"},{"line_number":176,"context_line":"        help\u003d_(\u0027Filter networks belonging to the given tenant.\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_4c6d7703","line":173,"in_reply_to":"7a740942_a1d8a454","updated":"2015-12-04 05:07:49.000000000","message":"ir should be \"shared\"","commit_id":"c43b032825b6f1178fe1eccb713787e9593459b0"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4869e8b4c2da9723f61be3992ba799b4273852fc","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        search_opts.update(_extra_values)"},{"line_number":682,"context_line":"        if parsed_args.name:"},{"line_number":683,"context_line":"            search_opts[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":684,"context_line":"        if parsed_args.status:"},{"line_number":685,"context_line":"            search_opts[\u0027status\u0027] \u003d parsed_args.status"},{"line_number":686,"context_line":"        if hasattr(parsed_args, \u0027admin_state\u0027):"},{"line_number":687,"context_line":"            search_opts[\u0027admin_state_up\u0027] \u003d parsed_args.admin_state"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_e1c54c5b","line":684,"updated":"2015-12-04 03:43:57.000000000","message":"Why hasattr check is not done for name \u0026 status? I can find from the above line that these parameters are optional and not mandatory (L159 \u0026 L163)?","commit_id":"c43b032825b6f1178fe1eccb713787e9593459b0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8bcf95bd80df87fe20f91f51c331f92237b6cd47","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        search_opts.update(_extra_values)"},{"line_number":682,"context_line":"        if parsed_args.name:"},{"line_number":683,"context_line":"            search_opts[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":684,"context_line":"        if parsed_args.status:"},{"line_number":685,"context_line":"            search_opts[\u0027status\u0027] \u003d parsed_args.status"},{"line_number":686,"context_line":"        if hasattr(parsed_args, \u0027admin_state\u0027):"},{"line_number":687,"context_line":"            search_opts[\u0027admin_state_up\u0027] \u003d parsed_args.admin_state"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_203c67c7","line":684,"in_reply_to":"7a740942_a59629ee","updated":"2015-12-07 02:07:32.000000000","message":"On the other hand, I found that all the test cases ( almost 309 of them) want this check to exist.","commit_id":"c43b032825b6f1178fe1eccb713787e9593459b0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"09e549c9142250fad55b6e465ee9bf198a886b4d","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        search_opts.update(_extra_values)"},{"line_number":682,"context_line":"        if parsed_args.name:"},{"line_number":683,"context_line":"            search_opts[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":684,"context_line":"        if parsed_args.status:"},{"line_number":685,"context_line":"            search_opts[\u0027status\u0027] \u003d parsed_args.status"},{"line_number":686,"context_line":"        if hasattr(parsed_args, \u0027admin_state\u0027):"},{"line_number":687,"context_line":"            search_opts[\u0027admin_state_up\u0027] \u003d parsed_args.admin_state"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_a59629ee","line":684,"in_reply_to":"7a740942_e1c54c5b","updated":"2015-12-07 01:56:36.000000000","message":"The use of \n\n  if parsed_args.XXX \n\nand \n\n  if hasattr(parsed_args, XXX)\n\nis not ideal. I am changing it , as per the above review comment.","commit_id":"c43b032825b6f1178fe1eccb713787e9593459b0"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"65c4ddb005ae8fdc29d58c3d1c7c131c1945bcfe","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        \u0027--name\u0027,"},{"line_number":164,"context_line":"        help\u003d_(\"Filter networks according to their name.\"))"},{"line_number":165,"context_line":"    parser.add_argument("},{"line_number":166,"context_line":"        \u0027--status\u0027,"},{"line_number":167,"context_line":"        help\u003d_(\"Filter networks according to their operation status\""},{"line_number":168,"context_line":"               \"(For eg.ACTIVE, ERROR etc.) \"),"},{"line_number":169,"context_line":"        type\u003dconvert_to_uppercase)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_38133f68","line":166,"updated":"2015-12-07 05:28:50.000000000","message":"I am not sure whether we should extend the common list API.  If we do this then these option will be available to all the CLI\u0027s and they might not support these args.","commit_id":"e1ed9b8230b4c1ab593b8ff48c9edefb142cc32e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8d54d44409f9a0c3f0941cfa4374a266920d4f00","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        \u0027--name\u0027,"},{"line_number":164,"context_line":"        help\u003d_(\"Filter networks according to their name.\"))"},{"line_number":165,"context_line":"    parser.add_argument("},{"line_number":166,"context_line":"        \u0027--status\u0027,"},{"line_number":167,"context_line":"        help\u003d_(\"Filter networks according to their operation status\""},{"line_number":168,"context_line":"               \"(For eg.ACTIVE, ERROR etc.) \"),"},{"line_number":169,"context_line":"        type\u003dconvert_to_uppercase)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_9bba6dbf","line":166,"in_reply_to":"7a740942_38133f68","updated":"2015-12-07 07:48:32.000000000","message":"Agreed, moving this to network.py","commit_id":"e1ed9b8230b4c1ab593b8ff48c9edefb142cc32e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8d54d44409f9a0c3f0941cfa4374a266920d4f00","unresolved":false,"context_lines":[{"line_number":682,"context_line":"                    self.values_specs)"},{"line_number":683,"context_line":"        search_opts \u003d self.args2search_opts(parsed_args)"},{"line_number":684,"context_line":"        search_opts.update(_extra_values)"},{"line_number":685,"context_line":"        if parsed_args.name:"},{"line_number":686,"context_line":"            search_opts[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":687,"context_line":"        if parsed_args.status:"},{"line_number":688,"context_line":"            search_opts[\u0027status\u0027] \u003d parsed_args.status"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_bbae4983","line":685,"updated":"2015-12-07 07:48:32.000000000","message":"On a rehash, I found that this change is actually NOT required, due to the _extra_values which are being sent to search_opts in the line above.","commit_id":"e1ed9b8230b4c1ab593b8ff48c9edefb142cc32e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c9cb968130f46cecb27ed6d80740d0bc6fb9b607","unresolved":false,"context_lines":[{"line_number":633,"context_line":"    # For more details, see ListNetworks.filter_attrs."},{"line_number":634,"context_line":"    filter_attrs \u003d []"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"    default_attr_defs \u003d {"},{"line_number":637,"context_line":"        \u0027name\u0027: {"},{"line_number":638,"context_line":"            \u0027help\u0027: _(\"Filter %s according to their name.\"),"},{"line_number":639,"context_line":"            \u0027boolean\u0027: False,"}],"source_content_type":"text/x-python","patch_set":20,"id":"ba63e191_dff9f8c9","line":636,"range":{"start_line":636,"start_character":4,"end_line":636,"end_character":21},"updated":"2016-01-19 11:09:57.000000000","message":"My intention of this variable is to make this a common place to define help messages of attributes which are frequently used.\n\nAll options shown in a help message are controlled by \"filter_attrs\" above.\n\nThis is the reason I add \u0027admin_state_up\u0027 to this list.\n\n\"status\" is really a gray zone because available statuses depend on a resource type.\n\nPerhaps the variable name should be improved.","commit_id":"81f42a4db1afb73fc12b0ea860015c88e98d94bb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2efc503ad21a39a1f871bf0db2d57da5a1f2bdcb","unresolved":false,"context_lines":[{"line_number":651,"context_line":"            \u0027help\u0027: _(\"Filter %s according to their operation status\""},{"line_number":652,"context_line":"                      \"(For example: ACTIVE, ERROR parser.) \"),"},{"line_number":653,"context_line":"            \u0027boolean\u0027: False,"},{"line_number":654,"context_line":"            \u0027extra\u0027: {\u0027type\u0027: utils.convert_to_uppercase},"},{"line_number":655,"context_line":"        },"},{"line_number":656,"context_line":"    }"},{"line_number":657,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa69d971_0cbf3a61","line":654,"updated":"2016-01-08 13:18:12.000000000","message":"I am not sure \u0027status\u0027 should be included in this default list.","commit_id":"81f42a4db1afb73fc12b0ea860015c88e98d94bb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c9cb968130f46cecb27ed6d80740d0bc6fb9b607","unresolved":false,"context_lines":[{"line_number":651,"context_line":"            \u0027help\u0027: _(\"Filter %s according to their operation status\""},{"line_number":652,"context_line":"                      \"(For example: ACTIVE, ERROR parser.) \"),"},{"line_number":653,"context_line":"            \u0027boolean\u0027: False,"},{"line_number":654,"context_line":"            \u0027extra\u0027: {\u0027type\u0027: utils.convert_to_uppercase},"},{"line_number":655,"context_line":"        },"},{"line_number":656,"context_line":"    }"},{"line_number":657,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba63e191_5fbae8e2","line":654,"in_reply_to":"da6ed579_faa987e0","updated":"2016-01-19 11:09:57.000000000","message":"My intention of default_attr_defs is described above.\n\nI agree \u0027status\u0027 should be pulled out.","commit_id":"81f42a4db1afb73fc12b0ea860015c88e98d94bb"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d3e4a506979e07dc11aac9d7487cf17cfc2f7177","unresolved":false,"context_lines":[{"line_number":651,"context_line":"            \u0027help\u0027: _(\"Filter %s according to their operation status\""},{"line_number":652,"context_line":"                      \"(For example: ACTIVE, ERROR parser.) \"),"},{"line_number":653,"context_line":"            \u0027boolean\u0027: False,"},{"line_number":654,"context_line":"            \u0027extra\u0027: {\u0027type\u0027: utils.convert_to_uppercase},"},{"line_number":655,"context_line":"        },"},{"line_number":656,"context_line":"    }"},{"line_number":657,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"da6ed579_faa987e0","line":654,"in_reply_to":"fa69d971_0cbf3a61","updated":"2016-01-12 07:51:48.000000000","message":"No, it ideally should not.\nStatus is not a part of all resources I guess, so its better to let required resource to override the default attributes with the additional value of Status","commit_id":"81f42a4db1afb73fc12b0ea860015c88e98d94bb"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ec89256dc5cd53924e0b6917a73b17f2067d5f9a","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                      \u0027state is active\u0027),"},{"line_number":629,"context_line":"            \u0027boolean\u0027: True,"},{"line_number":630,"context_line":"        },"},{"line_number":631,"context_line":"        \u0027status\u0027: {"},{"line_number":632,"context_line":"            \u0027help\u0027: _(\"Filter %s according to their operation status\""},{"line_number":633,"context_line":"                      \"(For example: ACTIVE, ERROR parser.) \"),"},{"line_number":634,"context_line":"            \u0027boolean\u0027: False,"}],"source_content_type":"text/x-python","patch_set":25,"id":"ba63e191_d22a187e","line":631,"updated":"2016-01-20 04:36:08.000000000","message":"As discussed earlier, removing status in the next PS","commit_id":"ae020f21e1346f79ca36e6fa5b2342432622fb3c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"be8bfa91bea52241f5e5ad775f0807756ca083d2","unresolved":false,"context_lines":[{"line_number":609,"context_line":"    # {\u0027name\u0027: attribute name, (mandatory)"},{"line_number":610,"context_line":"    #  \u0027help\u0027: help message for CLI (mandatory)"},{"line_number":611,"context_line":"    #  \u0027boolean\u0027: boolean parameter or not. (Default: False) (optional)"},{"line_number":612,"context_line":"    #  \u0027extra\u0027: a dict of extra parameters to pass argparse add_argument"},{"line_number":613,"context_line":"    # }"},{"line_number":614,"context_line":"    # For more details, see ListNetworks.filter_attrs."},{"line_number":615,"context_line":"    filter_attrs \u003d []"}],"source_content_type":"text/x-python","patch_set":28,"id":"9a68dd71_ec643ae6","line":612,"range":{"start_line":612,"start_character":8,"end_line":612,"end_character":14},"updated":"2016-01-21 14:49:19.000000000","message":"I start to think \u0027argparse_kwargs\u0027 is a better name.\n\nIn addition, \u0027(optional)\u0027 needs to be added.","commit_id":"70d8b554b2ad92356e04a665d1c673ec17ba0983"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b5d6e6c563ded491c3980e131d8a3fe9bfc30e04","unresolved":false,"context_lines":[{"line_number":609,"context_line":"    # {\u0027name\u0027: attribute name, (mandatory)"},{"line_number":610,"context_line":"    #  \u0027help\u0027: help message for CLI (mandatory)"},{"line_number":611,"context_line":"    #  \u0027boolean\u0027: boolean parameter or not. (Default: False) (optional)"},{"line_number":612,"context_line":"    #  \u0027extra\u0027: a dict of extra parameters to pass argparse add_argument"},{"line_number":613,"context_line":"    # }"},{"line_number":614,"context_line":"    # For more details, see ListNetworks.filter_attrs."},{"line_number":615,"context_line":"    filter_attrs \u003d []"}],"source_content_type":"text/x-python","patch_set":28,"id":"9a68dd71_23048148","line":612,"range":{"start_line":612,"start_character":8,"end_line":612,"end_character":14},"in_reply_to":"9a68dd71_ec643ae6","updated":"2016-01-22 03:13:40.000000000","message":"I think it can be reworded to add_kwargs\nargparse_kwargs seems a bit big, and extra is bit inconclusive.","commit_id":"70d8b554b2ad92356e04a665d1c673ec17ba0983"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"98957fdcb4151ee25d492b5c3895f81bcda2def6","unresolved":false,"context_lines":[{"line_number":609,"context_line":"    # {\u0027name\u0027: attribute name, (mandatory)"},{"line_number":610,"context_line":"    #  \u0027help\u0027: help message for CLI (mandatory)"},{"line_number":611,"context_line":"    #  \u0027boolean\u0027: boolean parameter or not. (Default: False) (optional)"},{"line_number":612,"context_line":"    #  \u0027argparse_kwargs\u0027: a dict of parameters to pass argparse add_argument"},{"line_number":613,"context_line":"    #                     (Default: {}) (optional)"},{"line_number":614,"context_line":"    # }"},{"line_number":615,"context_line":"    # For more details, see ListNetworks.filter_attrs."}],"source_content_type":"text/x-python","patch_set":29,"id":"9a68dd71_686d1fcb","line":612,"updated":"2016-01-25 01:14:50.000000000","message":"This statement does not seem to be complete.\nSuggested re-wording : a dict of parameters, passed to the argparse add_argument()","commit_id":"ada92a802d978d42f344f22e55490ecd571c9e8b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6741f2f8a1178bbc24d6c8e041a90cfd79ce5b31","unresolved":false,"context_lines":[{"line_number":609,"context_line":"    # {\u0027name\u0027: attribute name, (mandatory)"},{"line_number":610,"context_line":"    #  \u0027help\u0027: help message for CLI (mandatory)"},{"line_number":611,"context_line":"    #  \u0027boolean\u0027: boolean parameter or not. (Default: False) (optional)"},{"line_number":612,"context_line":"    #  \u0027argparse_kwargs\u0027: a dict of parameters to pass argparse add_argument"},{"line_number":613,"context_line":"    #                     (Default: {}) (optional)"},{"line_number":614,"context_line":"    # }"},{"line_number":615,"context_line":"    # For more details, see ListNetworks.filter_attrs."}],"source_content_type":"text/x-python","patch_set":29,"id":"7a5de9d1_facfdf7c","line":612,"in_reply_to":"9a68dd71_686d1fcb","updated":"2016-01-29 07:22:41.000000000","message":"Done","commit_id":"ada92a802d978d42f344f22e55490ecd571c9e8b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"61d185c8adcdb1f45835c7c9ef0e6638fcf0fa58","unresolved":false,"context_lines":[{"line_number":496,"context_line":"    \"\"\"Update resource\u0027s information.\"\"\""},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    log \u003d None"},{"line_number":499,"context_line":"    allow_names \u003d True"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    def get_parser(self, prog_name):"},{"line_number":502,"context_line":"        parser \u003d super(UpdateCommand, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":31,"id":"7a5de9d1_fa403fa7","line":499,"updated":"2016-01-29 07:29:49.000000000","message":"Please do not delete the help_resource variable, as it is used for the VPN messages","commit_id":"96aacd7395a28a0ee9eaf4115f6ef7da8c576cd3"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"61d185c8adcdb1f45835c7c9ef0e6638fcf0fa58","unresolved":false,"context_lines":[{"line_number":503,"context_line":"        if self.allow_names:"},{"line_number":504,"context_line":"            help_str \u003d _(\u0027ID or name of %s to update.\u0027)"},{"line_number":505,"context_line":"        else:"},{"line_number":506,"context_line":"            help_str \u003d _(\u0027ID of %s to update.\u0027)"},{"line_number":507,"context_line":"        parser.add_argument("},{"line_number":508,"context_line":"            \u0027id\u0027, metavar\u003dself.resource.upper(),"},{"line_number":509,"context_line":"            help\u003dhelp_str % self.resource)"}],"source_content_type":"text/x-python","patch_set":31,"id":"7a5de9d1_1a3c3b2e","line":506,"updated":"2016-01-29 07:29:49.000000000","message":"Same here","commit_id":"96aacd7395a28a0ee9eaf4115f6ef7da8c576cd3"}],"neutronclient/neutron/v2_0/network.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"abcda7d471d98f50f58e1aab115ad2465e66ed61","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    pagination_support \u003d True"},{"line_number":48,"context_line":"    sorting_support \u003d True"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def get_parser(self, prog_name):"},{"line_number":51,"context_line":"        parser \u003d super(ListNetwork, self).get_parser(prog_name)"},{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \u0027--name\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_001d4f65","line":50,"updated":"2015-12-08 14:09:49.000000000","message":"Maybe I missed it, but I didn\u0027t find unit tests for these arguments.","commit_id":"c7da46fec82683718cdd577484c7f3a39a5c988f"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"abcda7d471d98f50f58e1aab115ad2465e66ed61","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        parser.add_argument("},{"line_number":56,"context_line":"            \u0027--status\u0027,"},{"line_number":57,"context_line":"            help\u003d_(\"Filter networks according to their operation status\""},{"line_number":58,"context_line":"                   \"(For eg.ACTIVE, ERROR etc.) \"),"},{"line_number":59,"context_line":"            type\u003dconvert_to_uppercase)"},{"line_number":60,"context_line":"        utils.add_boolean_argument("},{"line_number":61,"context_line":"            parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_5d24a4c3","line":58,"updated":"2015-12-08 14:09:49.000000000","message":"I suggest spelling out \u0027eg.\u0027 and be sure to add a space after.  Also is one example sufficient for the documentation?","commit_id":"c7da46fec82683718cdd577484c7f3a39a5c988f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"5dad63234c856a3ce116e7796b9454a251d38196","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        parser.add_argument("},{"line_number":56,"context_line":"            \u0027--status\u0027,"},{"line_number":57,"context_line":"            help\u003d_(\"Filter networks according to their operation status\""},{"line_number":58,"context_line":"                   \"(For eg.ACTIVE, ERROR etc.) \"),"},{"line_number":59,"context_line":"            type\u003dconvert_to_uppercase)"},{"line_number":60,"context_line":"        utils.add_boolean_argument("},{"line_number":61,"context_line":"            parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_e85b2584","line":58,"in_reply_to":"7a740942_5d24a4c3","updated":"2015-12-09 05:47:19.000000000","message":"Hi Richard, I added it to be more informative to the user. Maybe you have any suggestions for this on which I can work upon?","commit_id":"c7da46fec82683718cdd577484c7f3a39a5c988f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ddf8ce91228a5d30de0240e250d0719708b1cab3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            \u0027--status\u0027,"},{"line_number":54,"context_line":"            help\u003d_(\"Filter networks according to their operation status\""},{"line_number":55,"context_line":"                   \"(For example: ACTIVE, ERROR etc.) \"),"},{"line_number":56,"context_line":"            type\u003dutils.convert_to_uppercase)"},{"line_number":57,"context_line":"        utils.add_boolean_argument("},{"line_number":58,"context_line":"            parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state\u0027,"},{"line_number":59,"context_line":"            help\u003d_(\u0027Filter and list the networks which\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa69d971_314cd96f","line":56,"updated":"2016-01-04 08:37:57.000000000","message":"I don\u0027t think it is related. convert_to_upper/lowercase is an additional feature and we don\u0027t have this kind of feature now.\nThis patch should focus on adding the help message.","commit_id":"8638de12b576f955394102b9e6f56672a8713795"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"de046a653268268c08d8915a3ccc3366d3b9b7c3","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            help\u003d_(\u0027Filter and list the networks which\u0027"},{"line_number":60,"context_line":"                   \u0027 are active for the administrator.\u0027))"},{"line_number":61,"context_line":"        utils.add_boolean_argument("},{"line_number":62,"context_line":"            parser, \u0027--shared\u0027, dest\u003d\u0027shared\u0027,"},{"line_number":63,"context_line":"            help\u003d_(\u0027Filter and list the networks which are shared.\u0027))"},{"line_number":64,"context_line":"        parser.add_argument("},{"line_number":65,"context_line":"            \u0027--tenant-id\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa69d971_ff9c87c1","line":62,"updated":"2016-01-05 15:04:18.000000000","message":"dest looks un-necessary","commit_id":"e63b59aa5177628895cae2c15c68e1b88514c506"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b66ad122cd652778b81d6a6fc3f33fc3e2b6116","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027name\u0027, \u0027subnets\u0027]"},{"line_number":44,"context_line":"    pagination_support \u003d True"},{"line_number":45,"context_line":"    sorting_support \u003d True"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_parser(self, prog_name):"},{"line_number":48,"context_line":"        parser \u003d super(ListNetwork, self).get_parser(prog_name)"},{"line_number":49,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":19,"id":"fa69d971_c081e9fc","line":46,"updated":"2016-01-08 12:04:30.000000000","message":"Some attributes (like tenant_id, name) are common across most resources. Can we define a common way?","commit_id":"3ab699d8ecdca15063e3f5bf8b25b17f80e8959a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"83e2ac41e5826d455c2c55f9c2dc52616e0b66f8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                   \"(For example: ACTIVE, ERROR etc.) \"),"},{"line_number":56,"context_line":"            type\u003dutils.convert_to_uppercase)"},{"line_number":57,"context_line":"        utils.add_boolean_argument("},{"line_number":58,"context_line":"            parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state\u0027,"},{"line_number":59,"context_line":"            help\u003d_(\u0027Filter and list the networks which\u0027"},{"line_number":60,"context_line":"                   \u0027 are active for the administrator.\u0027))"},{"line_number":61,"context_line":"        utils.add_boolean_argument("}],"source_content_type":"text/x-python","patch_set":19,"id":"fa69d971_acb38e09","line":58,"range":{"start_line":58,"start_character":40,"end_line":58,"end_character":59},"updated":"2016-01-08 13:13:45.000000000","message":"It is unnecessary.","commit_id":"3ab699d8ecdca15063e3f5bf8b25b17f80e8959a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d3e4a506979e07dc11aac9d7487cf17cfc2f7177","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        {\u0027name\u0027: \u0027router:external\u0027,"},{"line_number":56,"context_line":"         \u0027help\u0027: _(\u0027Filter and list the networks which are external.\u0027),"},{"line_number":57,"context_line":"         \u0027boolean\u0027: True},"},{"line_number":58,"context_line":"    ]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def extend_list(self, data, parsed_args):"},{"line_number":61,"context_line":"        \"\"\"Add subnet information to a network list.\"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"da6ed579_bada2f77","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":5},"updated":"2016-01-12 07:51:48.000000000","message":"I think admin-state can also be added for resources as it will provide the User an option to see which resources are accessible with administartor","commit_id":"81f42a4db1afb73fc12b0ea860015c88e98d94bb"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"548fa9954bd547e07d2b268cc7af71562d7bd303","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        {\u0027name\u0027: \u0027router:external\u0027,"},{"line_number":56,"context_line":"         \u0027help\u0027: _(\u0027Filter and list the networks which are external.\u0027),"},{"line_number":57,"context_line":"         \u0027boolean\u0027: True},"},{"line_number":58,"context_line":"    ]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def extend_list(self, data, parsed_args):"},{"line_number":61,"context_line":"        \"\"\"Add subnet information to a network list.\"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba63e191_ef309903","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":5},"in_reply_to":"ba63e191_9fdb801b","updated":"2016-01-20 04:34:25.000000000","message":"I think Admin state is also a part of the Neutron API.\nBut yes, as my understanding suggests, Admin State is not a part of all resources, so yes, maybe it can be skipped","commit_id":"81f42a4db1afb73fc12b0ea860015c88e98d94bb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c9cb968130f46cecb27ed6d80740d0bc6fb9b607","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        {\u0027name\u0027: \u0027router:external\u0027,"},{"line_number":56,"context_line":"         \u0027help\u0027: _(\u0027Filter and list the networks which are external.\u0027),"},{"line_number":57,"context_line":"         \u0027boolean\u0027: True},"},{"line_number":58,"context_line":"    ]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def extend_list(self, data, parsed_args):"},{"line_number":61,"context_line":"        \"\"\"Add subnet information to a network list.\"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"ba63e191_9fdb801b","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":5},"in_reply_to":"da6ed579_bada2f77","updated":"2016-01-19 11:09:57.000000000","message":"I can not understand your comment. Could you elaborate more?\n\nI think elements of filter_attrs should be limited to attribute names defined in Neutron API.","commit_id":"81f42a4db1afb73fc12b0ea860015c88e98d94bb"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b921a7867bdf3d1156ea48ec0ac40b03f247020a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        \u0027admin_state_up\u0027,"},{"line_number":51,"context_line":"        {\u0027name\u0027: \u0027status\u0027,"},{"line_number":52,"context_line":"         \u0027help\u0027: _(\"Filter %s according to their operation status\""},{"line_number":53,"context_line":"                   \"(For example: ACTIVE, ERROR parser.) \"),"},{"line_number":54,"context_line":"         \u0027boolean\u0027: False,"},{"line_number":55,"context_line":"         \u0027argparse_kwargs\u0027: {\u0027type\u0027: utils.convert_to_uppercase}},"},{"line_number":56,"context_line":"        {\u0027name\u0027: \u0027shared\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"5a5ae5dd_6f9d5dbb","line":53,"updated":"2016-02-05 04:58:50.000000000","message":"ERROR parser?","commit_id":"c0d79dc971dae90e9b6ce9f462b77de844568c43"}],"neutronclient/tests/unit/test_cli20_network.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"557f11c4bcc277d8949abbaf330128e4d5ffc02e","unresolved":false,"context_lines":[{"line_number":603,"context_line":"        self._test_extend_list(mox_calls)"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"    def _test_list_shared_networks(self):"},{"line_number":606,"context_line":"        \"\"\"list nets : --shared \"\"\""},{"line_number":607,"context_line":"        cmd \u003d network.ListNetwork(test_cli20.MyApp(sys.stdout), None)"},{"line_number":608,"context_line":"        self._test_list_networks(cmd, base_args\u003d\u0027--shared\u0027)"},{"line_number":609,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a740942_a5149ee8","line":606,"updated":"2015-12-13 00:07:55.000000000","message":"We use # instead of \"\"\".","commit_id":"51f7d397a3ff9532148c83955b7569a1b30243a4"}]}