)]}'
{"neutronclient/neutron/v2_0/lb/v2/loadbalancer.py":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"ce99b4f13bb9d863579d291c36374f5555107b51","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                for pool in listener.get(\u0027pools\u0027, []):"},{"line_number":121,"context_line":"                    values.append(self._build_row(\u0027pool\u0027, pool, listener))"},{"line_number":122,"context_line":"                    values.append(self._build_row("},{"line_number":123,"context_line":"                        \u0027healthmonitor\u0027, pool.get(\u0027healthmonitor\u0027, {}), pool))"},{"line_number":124,"context_line":"                    for member in pool.get(\u0027members\u0027, []):"},{"line_number":125,"context_line":"                        values.append(self._build_row(\u0027member\u0027, member, pool))"},{"line_number":126,"context_line":"        return columns, values"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_921f225b","line":123,"updated":"2015-03-17 18:39:58.000000000","message":"If a health monitor doesn\u0027t exist on a pool you\u0027ll add it with all the fields associated in the tree as \u0027-\u0027.  Should possibly check for it existing first.","commit_id":"7111bc368232737bf2644f3236cffdd6857b1f33"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"3bc4dc14aebfd85d300eeafa6c3220ba62c218f9","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        statuses \u003d data[\u0027statuses\u0027]"},{"line_number":146,"context_line":"        if \u0027statuses\u0027 in data:"},{"line_number":147,"context_line":"            return self._build_data(statuses, lb_id)"},{"line_number":148,"context_line":"        else:"},{"line_number":149,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_12bdf202","line":148,"updated":"2015-03-17 18:44:00.000000000","message":"Else is unnecessary here.  Last behavior should be just \u0027return\u0027.  Also \u0027return None\u0027 is redundant","commit_id":"7111bc368232737bf2644f3236cffdd6857b1f33"}],"neutronclient/tests/unit/lb/v2/test_cli20_loadbalancer.py":[{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"1d8dd26aa66d997c3de6e4440ddda03e91422e27","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                parent_id \u003d \u0027-\u0027"},{"line_number":173,"context_line":"                parent_name \u003d \u0027-\u0027"},{"line_number":174,"context_line":"            if entity \u003d\u003d \u0027listener\u0027:"},{"line_number":175,"context_line":"                parent_id \u003d \u0027my-id\u0027"},{"line_number":176,"context_line":"            self.assertIn(parent_id, row)"},{"line_number":177,"context_line":"            self.assertIn(parent_name, row)"},{"line_number":178,"context_line":"            self.assertIn(\u0027ACTIVE\u0027, row)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_32ebd6dd","line":175,"updated":"2015-03-17 20:15:06.000000000","message":"Nit: Is this a constant somewhere?  Maybe avoid duplication?","commit_id":"7111bc368232737bf2644f3236cffdd6857b1f33"},{"author":{"_account_id":10806,"name":"Trevor Vardeman","email":"tvardema@redhat.com","username":"tvardeman"},"change_message_id":"1d8dd26aa66d997c3de6e4440ddda03e91422e27","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                parent_id \u003d \u0027my-id\u0027"},{"line_number":176,"context_line":"            self.assertIn(parent_id, row)"},{"line_number":177,"context_line":"            self.assertIn(parent_name, row)"},{"line_number":178,"context_line":"            self.assertIn(\u0027ACTIVE\u0027, row)"},{"line_number":179,"context_line":"            o_status \u003d \u0027ONLINE\u0027"},{"line_number":180,"context_line":"            if entity \u003d\u003d \u0027healthmonitor\u0027:"},{"line_number":181,"context_line":"                o_status \u003d \u0027-\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_72bc6edc","line":178,"updated":"2015-03-17 20:15:06.000000000","message":"Nit: Constant again?","commit_id":"7111bc368232737bf2644f3236cffdd6857b1f33"}]}