)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7ef195468ae3ba71203ec226d467ad6a3c7c6ac4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     JoeJiang \u003cshunqiaoj@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-03-23 02:23:15 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set specify IP address when use \u0027router-gateway-set\u0027 subcommand."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"e.g."},{"line_number":10,"context_line":"neutron router-gateway-set router-id ext-network-id --fixed-ip x.x.x.x"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a6ced46_481a846f","line":7,"updated":"2015-03-23 13:01:54.000000000","message":"Set specify? \n\n  Allow to specify IP address in router-gateway-set\n\nseems better","commit_id":"51d844c422c9222cb7237f36ffcec22a94a1b2b9"}],"neutronclient/neutron/v2_0/router.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"961dc59fa9c1bbfc101b96754bc77e6d1c7e7dc6","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            help\u003d_(\u0027Disable source NAT on the router gateway.\u0027))"},{"line_number":187,"context_line":"        parser.add_argument("},{"line_number":188,"context_line":"            \u0027--fixed-ip\u0027,"},{"line_number":189,"context_line":"            help\u003d_(\u0027Set IP for the gateway.\u0027))"},{"line_number":190,"context_line":"        return parser"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def run(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_ecad0834","line":189,"updated":"2015-03-17 07:36:33.000000000","message":"\"gateway\" is misleading and confusing.\nAlso \"IP\" -\u003e \"IP address\".\n\nAs a result, I would suggest:\n\n  IP address on the external network of the router.\n\nor\n\n  External IP address of the router.","commit_id":"74479dd06333c097bc37fc073b6af117c6dc68e5"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7ef195468ae3ba71203ec226d467ad6a3c7c6ac4","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            \u0027--disable-snat\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":186,"context_line":"            help\u003d_(\u0027Disable source NAT on the router gateway.\u0027))"},{"line_number":187,"context_line":"        parser.add_argument("},{"line_number":188,"context_line":"            \u0027--fixed-ip\u0027,"},{"line_number":189,"context_line":"            help\u003d_(\u0027Set IP for the gateway.\u0027))"},{"line_number":190,"context_line":"        return parser"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_e83970d9","line":188,"updated":"2015-03-23 13:01:54.000000000","message":"--router-ip or --external-fixed-ip seem better?","commit_id":"51d844c422c9222cb7237f36ffcec22a94a1b2b9"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a9d386d241ddea64288eba2d685f59f9479a6b5a","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            \u0027--disable-snat\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":186,"context_line":"            help\u003d_(\u0027Disable source NAT on the router gateway.\u0027))"},{"line_number":187,"context_line":"        parser.add_argument("},{"line_number":188,"context_line":"            \u0027--fixed-ip\u0027,"},{"line_number":189,"context_line":"            help\u003d_(\u0027Set IP for the gateway.\u0027))"},{"line_number":190,"context_line":"        return parser"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_4bea5d10","line":188,"in_reply_to":"1a6ced46_e83970d9","updated":"2015-03-24 03:35:07.000000000","message":"we can add subnet and address","commit_id":"51d844c422c9222cb7237f36ffcec22a94a1b2b9"}],"neutronclient/tests/unit/test_cli20_router.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7ef195468ae3ba71203ec226d467ad6a3c7c6ac4","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        fixed_ip \u003d \u002710.0.0.100\u0027"},{"line_number":251,"context_line":"        cmd \u003d router.SetGatewayRouter(test_cli20.MyApp(sys.stdout), None)"},{"line_number":252,"context_line":"        args \u003d [\u0027myid\u0027, \u0027externalid\u0027, \u0027--fixed-ip\u0027, fixed_ip]"},{"line_number":253,"context_line":"        self._test_update_resource(resource, cmd, \u0027myid\u0027,"},{"line_number":254,"context_line":"                                   args,"},{"line_number":255,"context_line":"                                   {\"external_gateway_info\":"},{"line_number":256,"context_line":"                                    {\"network_id\": \"externalid\"}}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_c8aaf4d3","line":253,"updated":"2015-03-23 13:01:54.000000000","message":"the test seems incorrect","commit_id":"51d844c422c9222cb7237f36ffcec22a94a1b2b9"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a9d386d241ddea64288eba2d685f59f9479a6b5a","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        fixed_ip \u003d \u002710.0.0.100\u0027"},{"line_number":251,"context_line":"        cmd \u003d router.SetGatewayRouter(test_cli20.MyApp(sys.stdout), None)"},{"line_number":252,"context_line":"        args \u003d [\u0027myid\u0027, \u0027externalid\u0027, \u0027--fixed-ip\u0027, fixed_ip]"},{"line_number":253,"context_line":"        self._test_update_resource(resource, cmd, \u0027myid\u0027,"},{"line_number":254,"context_line":"                                   args,"},{"line_number":255,"context_line":"                                   {\"external_gateway_info\":"},{"line_number":256,"context_line":"                                    {\"network_id\": \"externalid\"}}"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6ced46_abf751f4","line":253,"in_reply_to":"1a6ced46_c8aaf4d3","updated":"2015-03-24 03:35:07.000000000","message":"Done","commit_id":"51d844c422c9222cb7237f36ffcec22a94a1b2b9"},{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"b90e45a485efd0dea0e92fd760801f9000457db3","unresolved":false,"context_lines":[{"line_number":275,"context_line":"    def test_set_gateway_with_subnet_address(self):"},{"line_number":276,"context_line":"        \"\"\"set external gateway for router: myid externalid"},{"line_number":277,"context_line":"        --address xxx --subnet y."},{"line_number":278,"context_line":"        \"\"\""},{"line_number":279,"context_line":"        resource \u003d \u0027router\u0027"},{"line_number":280,"context_line":"        cmd \u003d router.SetGatewayRouter(test_cli20.MyApp(sys.stdout), None)"},{"line_number":281,"context_line":"        address \u003d \"address\""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba3cc151_1bbb2574","line":278,"updated":"2015-06-29 12:14:31.000000000","message":"Move \"\"\" to above line","commit_id":"0d1284e834afc53f6363d50b5472599eae8a00c6"}],"tox.ini":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"961dc59fa9c1bbfc101b96754bc77e6d1c7e7dc6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# E265 block comment should start with \u0027# \u0027"},{"line_number":47,"context_line":"# H405 multi line docstring summary not separated with an empty line"},{"line_number":48,"context_line":"# H307 like imports should be grouped together"},{"line_number":49,"context_line":"ignore \u003d E121,E127,E125,E265,H302,H307,H405"},{"line_number":50,"context_line":"show-source \u003d true"},{"line_number":51,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,tools"}],"source_content_type":"text/x-properties","patch_set":2,"id":"9a80dd14_ac423066","line":49,"updated":"2015-03-17 07:36:33.000000000","message":"Please do not add new entries.\nThe fix should be done without violating existing rules.\n\nThe latest code in the master branch passes the hacking rule.","commit_id":"74479dd06333c097bc37fc073b6af117c6dc68e5"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7ef195468ae3ba71203ec226d467ad6a3c7c6ac4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# E265 block comment should start with \u0027# \u0027"},{"line_number":47,"context_line":"# H405 multi line docstring summary not separated with an empty line"},{"line_number":48,"context_line":"# H307 like imports should be grouped together"},{"line_number":49,"context_line":"ignore \u003d E121,E127,E125,E265,H302,H307,H405"},{"line_number":50,"context_line":"show-source \u003d true"},{"line_number":51,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,tools"}],"source_content_type":"text/x-properties","patch_set":4,"id":"1a6ced46_88a0fcf5","line":49,"updated":"2015-03-23 13:01:54.000000000","message":"Why? Please respect current rules","commit_id":"51d844c422c9222cb7237f36ffcec22a94a1b2b9"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a9d386d241ddea64288eba2d685f59f9479a6b5a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# E265 block comment should start with \u0027# \u0027"},{"line_number":47,"context_line":"# H405 multi line docstring summary not separated with an empty line"},{"line_number":48,"context_line":"# H307 like imports should be grouped together"},{"line_number":49,"context_line":"ignore \u003d E121,E127,E125,E265,H302,H307,H405"},{"line_number":50,"context_line":"show-source \u003d true"},{"line_number":51,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,tools"}],"source_content_type":"text/x-properties","patch_set":4,"id":"1a6ced46_4bc89d22","line":49,"in_reply_to":"1a6ced46_88a0fcf5","updated":"2015-03-24 03:35:07.000000000","message":"Done","commit_id":"51d844c422c9222cb7237f36ffcec22a94a1b2b9"}]}
