)]}'
{"neutronclient/neutron/v2_0/fw/firewall.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e9c5f95e00ac6f4f797fcef2f02985eac9e406a0","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                client, \u0027firewall_policy\u0027,"},{"line_number":116,"context_line":"                parsed_args.policy)"},{"line_number":117,"context_line":"            data[\u0027firewall_policy_id\u0027] \u003d _policy_id"},{"line_number":118,"context_line":"        if parsed_args.routers:"},{"line_number":119,"context_line":"            data[\u0027router_ids\u0027] \u003d ["},{"line_number":120,"context_line":"                neutronv20.find_resourceid_by_name_or_id(client, \u0027router\u0027, r)"},{"line_number":121,"context_line":"                for r in parsed_args.routers]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_34f127ce","line":118,"updated":"2015-03-23 11:24:31.000000000","message":"I would like to have a way to specify an empty list for firewall-update. \"--no-router\" may help us as port-update --no-security-groups option does.","commit_id":"b150f38bf29f73e19792ac5dcee7112bdfba7c97"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"2078c5a60e52fcc0cac6f116ff18e0d33700d926","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                client, \u0027firewall_policy\u0027,"},{"line_number":116,"context_line":"                parsed_args.policy)"},{"line_number":117,"context_line":"            data[\u0027firewall_policy_id\u0027] \u003d _policy_id"},{"line_number":118,"context_line":"        if parsed_args.routers:"},{"line_number":119,"context_line":"            data[\u0027router_ids\u0027] \u003d ["},{"line_number":120,"context_line":"                neutronv20.find_resourceid_by_name_or_id(client, \u0027router\u0027, r)"},{"line_number":121,"context_line":"                for r in parsed_args.routers]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6ced46_adf30a09","line":118,"in_reply_to":"1a6ced46_34f127ce","updated":"2015-03-23 12:47:58.000000000","message":"Done","commit_id":"b150f38bf29f73e19792ac5dcee7112bdfba7c97"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3595023cad89349f90d6c111802d5e2fd173bef4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            metavar\u003d\u0027ROUTER\u0027,"},{"line_number":70,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":71,"context_line":"            help\u003d_(\u0027Firewall associated router names or IDs (requires \u0027"},{"line_number":72,"context_line":"                   \u0027fwaasrouterinsertion extension)\u0027))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def args2body(self, parsed_args):"},{"line_number":75,"context_line":"        client \u003d self.get_client()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_b0635a19","line":72,"updated":"2015-03-23 14:45:48.000000000","message":"Though \"fwaasrouterinsertion\" is the string we actually use in the API, it is hard to read as the help text and in the configuration guide. How about rewording it to \"(FWaaS) router insertion extension\"?\n\nI didn\u0027t notice in the previous patch set.","commit_id":"03f69bef1e4cbd9d52c3eeb4dceacb951fa7db82"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0dc776d238daf4167d0f86fec06e9f2a74c9cada","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            metavar\u003d\u0027ROUTER\u0027,"},{"line_number":70,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":71,"context_line":"            help\u003d_(\u0027Firewall associated router names or IDs (requires \u0027"},{"line_number":72,"context_line":"                   \u0027fwaasrouterinsertion extension)\u0027))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def args2body(self, parsed_args):"},{"line_number":75,"context_line":"        client \u003d self.get_client()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6ced46_3c8901cb","line":72,"in_reply_to":"1a6ced46_b0635a19","updated":"2015-03-23 15:52:50.000000000","message":"Done","commit_id":"03f69bef1e4cbd9d52c3eeb4dceacb951fa7db82"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"26702190ad7af600a3e35ac59dde585154c63bf2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":65,"context_line":"            help\u003d_(\u0027Set admin state up to false.\u0027))"},{"line_number":66,"context_line":"        parser.add_argument("},{"line_number":67,"context_line":"            \u0027--router\u0027,"},{"line_number":68,"context_line":"            dest\u003d\u0027routers\u0027,"},{"line_number":69,"context_line":"            metavar\u003d\u0027ROUTER\u0027,"},{"line_number":70,"context_line":"            action\u003d\u0027append\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_88ef02b0","line":67,"updated":"2015-04-02 05:15:18.000000000","message":"if multiple routers can be specified, this should be in plural form: --routers","commit_id":"d55bab4a05273bc8d0a8a2c5d2d55b23e860e234"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1b94c32ead5e03f41d559bcf94a3585e980b5085","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":65,"context_line":"            help\u003d_(\u0027Set admin state up to false.\u0027))"},{"line_number":66,"context_line":"        parser.add_argument("},{"line_number":67,"context_line":"            \u0027--router\u0027,"},{"line_number":68,"context_line":"            dest\u003d\u0027routers\u0027,"},{"line_number":69,"context_line":"            metavar\u003d\u0027ROUTER\u0027,"},{"line_number":70,"context_line":"            action\u003d\u0027append\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_b088e423","line":67,"in_reply_to":"baa041b7_5073d8b1","updated":"2015-04-02 09:33:18.000000000","message":"Done","commit_id":"d55bab4a05273bc8d0a8a2c5d2d55b23e860e234"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"8355a57bb586c477962591cf3422dc5d85a6f946","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":65,"context_line":"            help\u003d_(\u0027Set admin state up to false.\u0027))"},{"line_number":66,"context_line":"        parser.add_argument("},{"line_number":67,"context_line":"            \u0027--router\u0027,"},{"line_number":68,"context_line":"            dest\u003d\u0027routers\u0027,"},{"line_number":69,"context_line":"            metavar\u003d\u0027ROUTER\u0027,"},{"line_number":70,"context_line":"            action\u003d\u0027append\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_5073d8b1","line":67,"in_reply_to":"baa041b7_88ef02b0","updated":"2015-04-02 09:27:20.000000000","message":"To specify multiple routers, use --router multiple times:\n\n  neutron firewall-create/update .... --router $router_id_or_name0 --router $router_id_or_name1 ...\n\nlike subnet-create --host_route/allocation_pool/dns_nameserver options.\n\nI will clarify it in option help.","commit_id":"d55bab4a05273bc8d0a8a2c5d2d55b23e860e234"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"26702190ad7af600a3e35ac59dde585154c63bf2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            dest\u003d\u0027routers\u0027,"},{"line_number":69,"context_line":"            metavar\u003d\u0027ROUTER\u0027,"},{"line_number":70,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":71,"context_line":"            help\u003d_(\u0027Firewall associated router names or IDs (requires \u0027"},{"line_number":72,"context_line":"                   \u0027FWaaS router insertion extension)\u0027))"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_c83cea31","line":71,"updated":"2015-04-02 05:15:18.000000000","message":"I would prefer that you specify what delimiter is used to specify more than one router","commit_id":"d55bab4a05273bc8d0a8a2c5d2d55b23e860e234"}]}