)]}'
{"id":"openstack%2Fpython-neutronclient~17862","triplet_id":"openstack%2Fpython-neutronclient~master~Ic27b278484133c8b83e3b031a0810a76b050219f","project":"openstack/python-neutronclient","branch":"master","topic":"bp/options-location","hashtags":[],"change_id":"Ic27b278484133c8b83e3b031a0810a76b050219f","subject":"Allow known options defined after position arguments.","status":"MERGED","created":"2013-01-14 09:08:12.000000000","updated":"2013-01-14 09:08:12.000000000","submitted":"2013-01-14 09:08:12.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"885beb37dd151e19e9890b46ed2679b5f8930020","_number":17862,"virtual_id_number":17862,"owner":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-01-14 09:08:12.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-01-14 09:08:12.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":2,"date":"2013-01-14 09:08:12.000000000","_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-01-14 09:08:12.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"date":"2013-01-14 09:08:12.000000000","_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-01-14 09:08:12.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2013-01-14 09:08:12.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2013-01-14 09:08:12.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"bf4961b65a8158162a42e5f88d60c89c7725016f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/17862/1/check/gate-python-quantumclient-merge/316 : SUCCESS\n- http://logs.openstack.org/17862/1/check/gate-python-quantumclient-docs/199 : SUCCESS\n- http://logs.openstack.org/17862/1/check/gate-python-quantumclient-pep8/281 : SUCCESS\n- http://logs.openstack.org/17862/1/check/gate-python-quantumclient-python26/260 : SUCCESS\n- http://logs.openstack.org/17862/1/check/gate-python-quantumclient-python27/259 : SUCCESS\n- http://logs.openstack.org/17862/1/check/gate-tempest-devstack-vm/21771 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"2e3679c326308c0b6c21b59082c464b12ad1e98f","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 1:\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"544c24e1685b3ee5240ecbc15d8fdd0e87b49996","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"03907213874f6b2b01bd737657f3157d6a4ec828","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 1: (4 inline comments)\n\nA couple of cleanups is required. The main changes looks good.\n\nI tested list the new features (arg merge and conversion from - to _ for unknown options) and they works well.\n\nDuring the review I have resolved the conflict in quantum/v2_0/subnet.py and tests/unit/test_cli20_subnet.py. I will upload it as the next patch set. I believe no your changes are lost (I checked there is no difference between checkout and cherry-pick versions).","accounts_in_message":[],"_revision_number":1},{"id":"fbcba2c56d941ba967a4af132c376743b53a875e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/17862/2/check/gate-python-quantumclient-docs/238 : SUCCESS\n- http://logs.openstack.org/17862/2/check/gate-python-quantumclient-pep8/320 : SUCCESS\n- http://logs.openstack.org/17862/2/check/gate-python-quantumclient-python26/299 : SUCCESS\n- http://logs.openstack.org/17862/2/check/gate-python-quantumclient-python27/298 : SUCCESS\n- http://logs.openstack.org/17862/2/check/gate-tempest-devstack-vm/26065 : SUCCESS\n- http://logs.openstack.org/17862/2/check/gate-devstack-vm-quantum/2734 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"363e3a8e28dfe72180a03e6c016bd4b639d29f59","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-01-14 09:08:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3c51e1f62ae0344b0dfa32c4567f04624493c7aa","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nI just rebased and did not update the codes based on my comments. I will do it from now.","accounts_in_message":[],"_revision_number":2},{"id":"6f59bbfb46f0988d0ce99c354e6f347d0dd8a211","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 3: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/17862/3/check/gate-python-quantumclient-docs/241 : SUCCESS\n- http://logs.openstack.org/17862/3/check/gate-python-quantumclient-pep8/323 : SUCCESS\n- http://logs.openstack.org/17862/3/check/gate-python-quantumclient-python26/302 : SUCCESS\n- http://logs.openstack.org/17862/3/check/gate-python-quantumclient-python27/301 : SUCCESS\n- http://logs.openstack.org/17862/3/check/gate-tempest-devstack-vm/26385 : SUCCESS\n- http://logs.openstack.org/17862/3/check/gate-devstack-vm-quantum/3129 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"cb8bf521d5c9849a8b6d13e4b7a39c9e6d061cc8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"0f1177d28919223f1f9f6bdd54f2e320b3f3fb40","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-01-14 09:08:12.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"4d1614206683c2d161e8b801600723cc8b115763","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"a149aa20e9be335e84751a1ade9305187088e3e3","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"4b4fc079f15a2971eb0d0fadf2ad194cf518d384","author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 1: Restored","accounts_in_message":[],"_revision_number":1},{"id":"5f632d17f8c734cfc5e195969f99c29bd5839bb7","author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 1:\n\none of my test cases is:\nquantum subnet-create --allocation-pool start\u003d30.0.2.3,end\u003d30.0.2.10 mynet1 30.0.2.0/24 --gateway 30.0.2.1 --allocation-pool start\u003d30.0.2.50,end\u003d30.0.2.60 --allocation-pools list\u003dtrue type\u003ddict start\u003d30.0.2.70,end\u003d30.0.2.80","accounts_in_message":[],"_revision_number":1},{"id":"319357fe54294296919c49910261a3ba34983b57","author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 2:\n\nthanks Akihiro Motoki","accounts_in_message":[],"_revision_number":2},{"id":"1b8a0ede1223f2df9d2ce27fac34429b944de215","author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"5e051bb5ff5c5f7c508ff8cdd35e2f91bd8564df","author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"5a71a70a8270d705bbfe26e11c1215d45b096941","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-14 09:08:12.000000000","message":"Patch Set 3: Verified\n\nBuild successful\n\n- http://logs.openstack.org/17862/3/gate/gate-python-quantumclient-docs/242 : SUCCESS\n- http://logs.openstack.org/17862/3/gate/gate-python-quantumclient-pep8/324 : SUCCESS\n- http://logs.openstack.org/17862/3/gate/gate-python-quantumclient-python26/303 : SUCCESS\n- http://logs.openstack.org/17862/3/gate/gate-python-quantumclient-python27/302 : SUCCESS\n- http://logs.openstack.org/17862/3/gate/gate-tempest-devstack-vm/26459 : SUCCESS\n- http://logs.openstack.org/17862/3/gate/gate-devstack-vm-quantum/3225 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"d979866ccf499dfdfd73647bb8c999b669886964","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-01-14 09:08:12.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"ee3ab2d7afb57abf574a31bbb72e4c94dde099df","revisions":{"66159342b4ff94808d6954b59e803f738025172d":{"kind":"REWORK","_number":1,"created":"2013-01-14 09:08:12.000000000","uploader":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"ref":"refs/changes/62/17862/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/62/17862/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/62/17862/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/62/17862/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/62/17862/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/62/17862/1"}}},"commit":{"parents":[{"commit":"d48d35aa9bb1ef38714d7b8eb7859fc59a5df0ec","subject":"Ensures that help alignment is not hard coded","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/d48d35aa9bb1ef38714d7b8eb7859fc59a5df0ec"}]}],"author":{"name":"gongysh","email":"gongysh@cn.ibm.com","date":"2012-12-11 15:40:16.000000000","tz":480},"committer":{"name":"gongysh","email":"gongysh@cn.ibm.com","date":"2012-12-11 16:10:24.000000000","tz":480},"subject":"Allow known options defined after position arguments.","message":"Allow known options defined after position arguments.\n\nWe run the argument parser to split known options and unknown options.\nMake \u0027-\u0027 work and have the same effect as \u0027_\u0027 in both known and unknown\noption parts.\nMake metavar Uppercase.\n\nblueprint options-location\n\nChange-Id: Ic27b278484133c8b83e3b031a0810a76b050219f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/66159342b4ff94808d6954b59e803f738025172d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/66159342b4ff94808d6954b59e803f738025172d"}]},"branch":"refs/heads/master"},"1ddd703cff591b11e57c0d0dbb631fa82daf7c49":{"kind":"REWORK","_number":2,"created":"2013-01-14 09:08:12.000000000","uploader":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"ref":"refs/changes/62/17862/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/62/17862/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/62/17862/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/62/17862/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/62/17862/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/62/17862/2"}}},"commit":{"parents":[{"commit":"093bac1bc6749326857241ca226a4219917891e7","subject":"Fix import order nits","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/093bac1bc6749326857241ca226a4219917891e7"}]}],"author":{"name":"gongysh","email":"gongysh@cn.ibm.com","date":"2012-12-11 15:40:16.000000000","tz":480},"committer":{"name":"Akihiro MOTOKI","email":"motoki@da.jp.nec.com","date":"2013-01-11 11:38:19.000000000","tz":540},"subject":"Allow known options defined after position arguments.","message":"Allow known options defined after position arguments.\n\nWe run the argument parser to split known options and unknown options.\nMake \u0027-\u0027 work and have the same effect as \u0027_\u0027 in both known and unknown\noption parts.\nMake metavar Uppercase.\n\nblueprint options-location\n\nChange-Id: Ic27b278484133c8b83e3b031a0810a76b050219f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/1ddd703cff591b11e57c0d0dbb631fa82daf7c49"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/1ddd703cff591b11e57c0d0dbb631fa82daf7c49"}]},"branch":"refs/heads/master"},"ee3ab2d7afb57abf574a31bbb72e4c94dde099df":{"kind":"REWORK","_number":3,"created":"2013-01-14 09:08:12.000000000","uploader":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"ref":"refs/changes/62/17862/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/62/17862/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/62/17862/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/62/17862/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/62/17862/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/62/17862/3"}}},"commit":{"parents":[{"commit":"093bac1bc6749326857241ca226a4219917891e7","subject":"Fix import order nits","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/093bac1bc6749326857241ca226a4219917891e7"}]}],"author":{"name":"gongysh","email":"gongysh@cn.ibm.com","date":"2012-12-11 15:40:16.000000000","tz":480},"committer":{"name":"Akihiro MOTOKI","email":"motoki@da.jp.nec.com","date":"2013-01-13 14:09:08.000000000","tz":540},"subject":"Allow known options defined after position arguments.","message":"Allow known options defined after position arguments.\n\nWe run the argument parser to split known options and unknown options.\nMake \u0027-\u0027 work and have the same effect as \u0027_\u0027 in both known and unknown\noption parts.\nMake metavar Uppercase.\n\nblueprint options-location\n\nChange-Id: Ic27b278484133c8b83e3b031a0810a76b050219f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/ee3ab2d7afb57abf574a31bbb72e4c94dde099df"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/ee3ab2d7afb57abf574a31bbb72e4c94dde099df"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}