)]}'
{"quantumclient/quantum/v2_0/securitygroup.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"155ef7460c07b911b118b54660e03687c265a6db","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                rule[\u0027security_group_id\u0027] \u003d sg_dict[sg_id]"},{"line_number":103,"context_line":"            group_id \u003d rule[\u0027source_group_id\u0027]"},{"line_number":104,"context_line":"            if group_id in sg_dict:"},{"line_number":105,"context_line":"                rule[\u0027source_group_id\u0027] \u003d sg_dict[group_id]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class ShowSecurityGroupRule(quantumv20.ShowCommand):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fpho%3D","line":105,"updated":"2013-01-11 01:39:09.000000000","message":"1. name can be empty\n2. use the name under xxx_id columns will be confusing","commit_id":"b52b1b6a6bebc24028abe9a923fd0f48c323a1b1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":102,"context_line":"                rule[\u0027security_group_id\u0027] \u003d sg_dict[sg_id]"},{"line_number":103,"context_line":"            group_id \u003d rule[\u0027source_group_id\u0027]"},{"line_number":104,"context_line":"            if group_id in sg_dict:"},{"line_number":105,"context_line":"                rule[\u0027source_group_id\u0027] \u003d sg_dict[group_id]"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class ShowSecurityGroupRule(quantumv20.ShowCommand):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FpaE%3D","line":105,"in_reply_to":"AAAAM3%2F%2Fpho%3D","updated":"2013-01-11 06:01:31.000000000","message":"1. L.98 checks if name is empty. security_group_id is replaced with its name only when name is non-empty.\n\n2. Agreed. It is easy just to change column name to name without \u0027_id\u0027.\nOne question: Is it better to support \"-c secrutiy_group\" in addition to \"-c security_group_id\"?","commit_id":"b52b1b6a6bebc24028abe9a923fd0f48c323a1b1"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"155ef7460c07b911b118b54660e03687c265a6db","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        for rule in data:"},{"line_number":114,"context_line":"            for key in self.replace_rules:"},{"line_number":115,"context_line":"                rule[key] \u003d sg_dict.get(rule[key], rule[key])"},{"line_number":116,"context_line":"        return data"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def setup_columns(self, info, parsed_args):"},{"line_number":119,"context_line":"        parsed_args.columns \u003d self.replace_columns(parsed_args.columns,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FlUA%3D","line":116,"updated":"2013-01-15 01:33:56.000000000","message":"we cannot have different meanings for return value. one return None, one returned changed data.","commit_id":"621df107b16b7be4c366046aee12ff3bac8ce7c2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":113,"context_line":"        for rule in data:"},{"line_number":114,"context_line":"            for key in self.replace_rules:"},{"line_number":115,"context_line":"                rule[key] \u003d sg_dict.get(rule[key], rule[key])"},{"line_number":116,"context_line":"        return data"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def setup_columns(self, info, parsed_args):"},{"line_number":119,"context_line":"        parsed_args.columns \u003d self.replace_columns(parsed_args.columns,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FlIE%3D","line":116,"in_reply_to":"AAAAM3%2F%2FlUA%3D","updated":"2013-01-15 06:08:05.000000000","message":"Done. I forgot to remove it.","commit_id":"621df107b16b7be4c366046aee12ff3bac8ce7c2"}]}