)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"263837f0b09a50dc0e680476febf240f6da525af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     8557cd9e (Updated from global requirements)"},{"line_number":2,"context_line":"Author:     Ramanjaneya \u003cramanjieee@gmail.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2015-06-23 17:19:45 +0530"},{"line_number":4,"context_line":"Commit:     vikram.choudhary \u003cvikram.choudhary@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-06-29 17:52:21 +0530"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba3cc151_49052ec0","line":2,"updated":"2015-07-07 05:43:47.000000000","message":"Specify Co-author as\nRamanjaneya Reddy Palleti \u003cramanjieee@gmail.com\u003e","commit_id":"ea941fe27ada11be7ec0934ea73fcc77781be739"}],"neutronclient/neutron/v2_0/address_scope.py":[{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"263837f0b09a50dc0e680476febf240f6da525af","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\"List address scopes that belong to a given tenant.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    resource \u003d \u0027address_scope\u0027"},{"line_number":25,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027name\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ShowAddressScope(neutronV20.ShowCommand):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_a9b95a17","line":25,"updated":"2015-07-07 05:43:47.000000000","message":"Support for pagination and sort.\n\n\t    pagination_support \u003d True\t\n           sorting_support \u003d True","commit_id":"ea941fe27ada11be7ec0934ea73fcc77781be739"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a248916c9929bacd36f39e469bebf0305bf582f0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\"List address scopes that belong to a given tenant.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    resource \u003d \u0027address_scope\u0027"},{"line_number":25,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027name\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ShowAddressScope(neutronV20.ShowCommand):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_d18239c8","line":25,"in_reply_to":"ba3cc151_a9b95a17","updated":"2015-07-07 10:02:59.000000000","message":"Ok. Done!","commit_id":"ea941fe27ada11be7ec0934ea73fcc77781be739"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a708fb6da9f1f101ae7debf5128a569944140c0e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def args2body(self, parsed_args):"},{"line_number":49,"context_line":"        body \u003d {self.resource: {\u0027name\u0027: parsed_args.name}}"},{"line_number":50,"context_line":"        if parsed_args.shared:"},{"line_number":51,"context_line":"            body[\u0027address_scope\u0027][\u0027shared\u0027] \u003d True"},{"line_number":52,"context_line":"        neutronV20.update_dict(parsed_args, body[self.resource],"},{"line_number":53,"context_line":"                               [\u0027name\u0027, \u0027tenant_id\u0027])"},{"line_number":54,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_6ac4e85e","line":51,"updated":"2015-07-04 07:33:15.000000000","message":"\u0027address_scope\u0027 -\u003e self.resource for consistency","commit_id":"ea941fe27ada11be7ec0934ea73fcc77781be739"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a248916c9929bacd36f39e469bebf0305bf582f0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def args2body(self, parsed_args):"},{"line_number":49,"context_line":"        body \u003d {self.resource: {\u0027name\u0027: parsed_args.name}}"},{"line_number":50,"context_line":"        if parsed_args.shared:"},{"line_number":51,"context_line":"            body[\u0027address_scope\u0027][\u0027shared\u0027] \u003d True"},{"line_number":52,"context_line":"        neutronV20.update_dict(parsed_args, body[self.resource],"},{"line_number":53,"context_line":"                               [\u0027name\u0027, \u0027tenant_id\u0027])"},{"line_number":54,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_916d9134","line":51,"in_reply_to":"ba3cc151_511f53b7","updated":"2015-07-07 10:02:59.000000000","message":"Ok. Done!","commit_id":"ea941fe27ada11be7ec0934ea73fcc77781be739"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d0e1bfef38643fbc73c4f95cc412fca0a22e79ae","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def args2body(self, parsed_args):"},{"line_number":49,"context_line":"        body \u003d {self.resource: {\u0027name\u0027: parsed_args.name}}"},{"line_number":50,"context_line":"        if parsed_args.shared:"},{"line_number":51,"context_line":"            body[\u0027address_scope\u0027][\u0027shared\u0027] \u003d True"},{"line_number":52,"context_line":"        neutronV20.update_dict(parsed_args, body[self.resource],"},{"line_number":53,"context_line":"                               [\u0027name\u0027, \u0027tenant_id\u0027])"},{"line_number":54,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_511f53b7","line":51,"in_reply_to":"ba3cc151_6ac4e85e","updated":"2015-07-05 05:54:47.000000000","message":"Will change as suggested in the below comment.","commit_id":"ea941fe27ada11be7ec0934ea73fcc77781be739"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a708fb6da9f1f101ae7debf5128a569944140c0e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if parsed_args.shared:"},{"line_number":51,"context_line":"            body[\u0027address_scope\u0027][\u0027shared\u0027] \u003d True"},{"line_number":52,"context_line":"        neutronV20.update_dict(parsed_args, body[self.resource],"},{"line_number":53,"context_line":"                               [\u0027name\u0027, \u0027tenant_id\u0027])"},{"line_number":54,"context_line":"        return body"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_4ac7a464","line":53,"updated":"2015-07-04 07:33:15.000000000","message":"body[self.resoruce] is usually used in nuutronclient, but it is not a very good convention. How about the following? It is more simple.\n\n  body \u003d {\u0027name\u0027: parsed_args.name}\n  if parsed_args.shared:\n      body[\u0027shared\u0027] \u003d True\n  neutronV20.update_dict(parsed_args, body, [\u0027name\u0027, \u0027tenant_id\u0027])\n  return {self.resource: body}","commit_id":"ea941fe27ada11be7ec0934ea73fcc77781be739"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d0e1bfef38643fbc73c4f95cc412fca0a22e79ae","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if parsed_args.shared:"},{"line_number":51,"context_line":"            body[\u0027address_scope\u0027][\u0027shared\u0027] \u003d True"},{"line_number":52,"context_line":"        neutronV20.update_dict(parsed_args, body[self.resource],"},{"line_number":53,"context_line":"                               [\u0027name\u0027, \u0027tenant_id\u0027])"},{"line_number":54,"context_line":"        return body"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_b1225f00","line":53,"in_reply_to":"ba3cc151_4ac7a464","updated":"2015-07-05 05:54:47.000000000","message":"Thanks for the suggestion. Will do it.","commit_id":"ea941fe27ada11be7ec0934ea73fcc77781be739"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a248916c9929bacd36f39e469bebf0305bf582f0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if parsed_args.shared:"},{"line_number":51,"context_line":"            body[\u0027address_scope\u0027][\u0027shared\u0027] \u003d True"},{"line_number":52,"context_line":"        neutronV20.update_dict(parsed_args, body[self.resource],"},{"line_number":53,"context_line":"                               [\u0027name\u0027, \u0027tenant_id\u0027])"},{"line_number":54,"context_line":"        return body"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_51770902","line":53,"in_reply_to":"ba3cc151_b1225f00","updated":"2015-07-07 10:02:59.000000000","message":"Ok. Done!","commit_id":"ea941fe27ada11be7ec0934ea73fcc77781be739"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a708fb6da9f1f101ae7debf5128a569944140c0e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def args2body(self, parsed_args):"},{"line_number":73,"context_line":"        body \u003d {self.resource: {}}"},{"line_number":74,"context_line":"        neutronV20.update_dict(parsed_args, body[\u0027address_scope\u0027], [\u0027name\u0027])"},{"line_number":75,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_caa97492","line":75,"updated":"2015-07-04 07:33:15.000000000","message":"same comment as the above.\n\n  body \u003d {}\n  update_dict(parsed_args, body, [\u0027name\u0027])\n  return {self.resource: body}","commit_id":"ea941fe27ada11be7ec0934ea73fcc77781be739"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a248916c9929bacd36f39e469bebf0305bf582f0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def args2body(self, parsed_args):"},{"line_number":73,"context_line":"        body \u003d {self.resource: {}}"},{"line_number":74,"context_line":"        neutronV20.update_dict(parsed_args, body[\u0027address_scope\u0027], [\u0027name\u0027])"},{"line_number":75,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_1160a134","line":75,"in_reply_to":"ba3cc151_711cd7c1","updated":"2015-07-07 10:02:59.000000000","message":"Ok. Done!","commit_id":"ea941fe27ada11be7ec0934ea73fcc77781be739"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d0e1bfef38643fbc73c4f95cc412fca0a22e79ae","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def args2body(self, parsed_args):"},{"line_number":73,"context_line":"        body \u003d {self.resource: {}}"},{"line_number":74,"context_line":"        neutronV20.update_dict(parsed_args, body[\u0027address_scope\u0027], [\u0027name\u0027])"},{"line_number":75,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_711cd7c1","line":75,"in_reply_to":"ba3cc151_caa97492","updated":"2015-07-05 05:54:47.000000000","message":"Will change as suggested.","commit_id":"ea941fe27ada11be7ec0934ea73fcc77781be739"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"c5991737458a3f46ee589eb6c76c31c862409d66","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        body \u003d {\u0027name\u0027: parsed_args.name}"},{"line_number":52,"context_line":"        if parsed_args.shared:"},{"line_number":53,"context_line":"            body[\u0027shared\u0027] \u003d True"},{"line_number":54,"context_line":"        neutronV20.update_dict(parsed_args, body, [\u0027name\u0027, \u0027tenant_id\u0027])"},{"line_number":55,"context_line":"        return {self.resource: body}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_5464e947","line":54,"updated":"2015-07-21 04:37:25.000000000","message":"since name is already in body, we can remove the \u0027name\u0027 here","commit_id":"f093175598cb7592b2cb85ba3e892d50436d6efe"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"6f702a66b5129579151c55df3c60c66ea72b2dd7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        body \u003d {\u0027name\u0027: parsed_args.name}"},{"line_number":52,"context_line":"        if parsed_args.shared:"},{"line_number":53,"context_line":"            body[\u0027shared\u0027] \u003d True"},{"line_number":54,"context_line":"        neutronV20.update_dict(parsed_args, body, [\u0027name\u0027, \u0027tenant_id\u0027])"},{"line_number":55,"context_line":"        return {self.resource: body}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_4a00c401","line":54,"in_reply_to":"3a50d1a3_5464e947","updated":"2015-07-21 05:29:42.000000000","message":"Ok. Will do it.","commit_id":"f093175598cb7592b2cb85ba3e892d50436d6efe"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"c5991737458a3f46ee589eb6c76c31c862409d66","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def args2body(self, parsed_args):"},{"line_number":74,"context_line":"        body \u003d {}"},{"line_number":75,"context_line":"        neutronV20.update_dict(parsed_args, body, [\u0027name\u0027])"},{"line_number":76,"context_line":"        return {self.resource: body}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_f4d175ce","line":75,"updated":"2015-07-21 04:37:25.000000000","message":"If we don\u0027t give the name, the body will be empty, what does it mean?","commit_id":"f093175598cb7592b2cb85ba3e892d50436d6efe"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"6f702a66b5129579151c55df3c60c66ea72b2dd7","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def args2body(self, parsed_args):"},{"line_number":74,"context_line":"        body \u003d {}"},{"line_number":75,"context_line":"        neutronV20.update_dict(parsed_args, body, [\u0027name\u0027])"},{"line_number":76,"context_line":"        return {self.resource: body}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_8a4c8c71","line":75,"in_reply_to":"3a50d1a3_f4d175ce","updated":"2015-07-21 05:29:42.000000000","message":"We have kept this CLI for the future as address-scope feature will extended later for various use-case. As of now what we can do is probably can just allow the user an option of giving/changing names to the existing address-scope.","commit_id":"f093175598cb7592b2cb85ba3e892d50436d6efe"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b773ccaaa79ae884e6589ad5c4071ff44d0e97ba","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    resource \u003d \u0027address_scope\u0027"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":70,"context_line":"        parser.add_argument(\u0027--name\u0027,"},{"line_number":71,"context_line":"                            help\u003d_(\u0027Name of the address scope to update.\u0027))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_3c009f65","line":70,"updated":"2015-07-23 06:44:42.000000000","message":"I was actually thinking about gongysh\u0027s comment given on PS4. I feel this won\u0027t be an issue as the existing framework mandates the user to provide at-least one param for an update call.\n\nhttps://github.com/openstack/python-neutronclient/blob/master/neutronclient/neutron/v2_0/__init__.py#L543-L545\n\nI have tested an example for this case..\n\n\nviksdeep@ubuntu:~/devstack$ neutron subnet-update a4513ac1-ba68-491e-9481-e537e35a1ee1 --help\nusage: neutron subnet-update [-h] [--request-format {json,xml}] [--name NAME]\n                             [--gateway GATEWAY_IP | --no-gateway]\n                             [--allocation-pool start\u003dIP_ADDR,end\u003dIP_ADDR]\n                             [--host-route destination\u003dCIDR,nexthop\u003dIP_ADDR]\n                             [--dns-nameserver DNS_NAMESERVER]\n                             [--disable-dhcp] [--enable-dhcp]\n                             SUBNET\n\nUpdate subnet\u0027s information.\n\npositional arguments:\n  SUBNET                ID or name of subnet to update.\n\noptional arguments:\n  -h, --help            show this help message and exit\n  --request-format {json,xml}\n                        The XML or JSON request format.\n  --name NAME           Name of this subnet.\n  --gateway GATEWAY_IP  Gateway IP of this subnet.\n  --no-gateway          No distribution of gateway.\n  --allocation-pool start\u003dIP_ADDR,end\u003dIP_ADDR\n                        Allocation pool IP addresses for this subnet (This\n                        option can be repeated).\n  --host-route destination\u003dCIDR,nexthop\u003dIP_ADDR\n                        Additional route (This option can be repeated).\n  --dns-nameserver DNS_NAMESERVER\n                        DNS name server for this subnet (This option can be\n                        repeated).\n  --disable-dhcp        Disable DHCP for this subnet.\n  --enable-dhcp         Enable DHCP for this subnet.\n\n\nviksdeep@ubuntu:~/devstack$ neutron subnet-update a4513ac1-ba68-491e-9481-e537e35a1ee1\n\nMust specify new values to update subnet\nviksdeep@ubuntu:~/devstack$\n\nPlease Note: \"subnet-update\" call without any optional parameter throws an error to the user for an input.","commit_id":"28a2064e75b7a7ba2ebbd8aa160fe1614eeb1485"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"93e7251f892af4dc927eb6aaa3a0ca38c09c0594","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\"List address scopes that belong to a given tenant.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    resource \u003d \u0027address_scope\u0027"},{"line_number":25,"context_line":"    list_columns \u003d [\u0027id\u0027]"},{"line_number":26,"context_line":"    pagination_support \u003d True"},{"line_number":27,"context_line":"    sorting_support \u003d True"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_f2f3c908","line":25,"updated":"2015-08-04 16:09:37.000000000","message":"Could we show the name too?  Right now, the list of address scopes is just a bunch of ids.","commit_id":"4501477cf468187cf4da26ed8c2e44a758375dba"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"c289538f99cd281c14f65e2ec9fbf26e140ec582","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    resource \u003d \u0027address_scope\u0027"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":70,"context_line":"        parser.add_argument(\u0027--name\u0027,"},{"line_number":71,"context_line":"                            help\u003d_(\u0027Name of the address scope to update.\u0027))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_8f7d101e","line":70,"updated":"2015-08-26 13:58:07.000000000","message":"Why \u0027--name\u0027 here, but just \u0027name\u0027 in CreateAddressScope above?\n\nWhat is there about an address scope that can be updated anyway?  Should the shared flag be updatable?","commit_id":"d749973859988e30347e94029703b508e126c79e"}],"neutronclient/neutron/v2_0/addrscope.py":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"f40712c118635004bcc7345fa3cfc2cf0cde4432","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_0429d29a","line":1,"updated":"2015-06-24 17:10:43.000000000","message":"Better to rename the file as address_scope.py","commit_id":"e9585ac60719e5c5bc76fc99dcd6e927f68709d3"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c9c3e656ce70e09f7c2daca1d14219b91b2cee55","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_f2e7a9e0","line":2,"updated":"2015-06-25 12:48:43.000000000","message":"Thanks Numan. Will change","commit_id":"e9585ac60719e5c5bc76fc99dcd6e927f68709d3"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"f40712c118635004bcc7345fa3cfc2cf0cde4432","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ListAddrScope(neutronV20.ListCommand):"},{"line_number":22,"context_line":"    \"\"\"List address scopes that belong to a given tenant.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    resource \u003d \u0027addrscope\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_44aefa2e","line":21,"updated":"2015-06-24 17:10:43.000000000","message":"To be consistent with the mainline patch, its better to use \"AddressScope\" instead of AddrScope.","commit_id":"e9585ac60719e5c5bc76fc99dcd6e927f68709d3"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c9c3e656ce70e09f7c2daca1d14219b91b2cee55","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ListAddrScope(neutronV20.ListCommand):"},{"line_number":22,"context_line":"    \"\"\"List address scopes that belong to a given tenant.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    resource \u003d \u0027addrscope\u0027"},{"line_number":25,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_52d9b520","line":22,"updated":"2015-06-25 12:48:43.000000000","message":"Will change","commit_id":"e9585ac60719e5c5bc76fc99dcd6e927f68709d3"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"f40712c118635004bcc7345fa3cfc2cf0cde4432","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class ListAddrScope(neutronV20.ListCommand):"},{"line_number":22,"context_line":"    \"\"\"List address scopes that belong to a given tenant.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    resource \u003d \u0027addrscope\u0027"},{"line_number":25,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027name\u0027]"},{"line_number":26,"context_line":"    pagination_support \u003d True"},{"line_number":27,"context_line":"    sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_445cba4a","line":24,"updated":"2015-06-24 17:10:43.000000000","message":"resource will be \"address-scope\" as the extension name chosen is \"address-scope\".","commit_id":"e9585ac60719e5c5bc76fc99dcd6e927f68709d3"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c9c3e656ce70e09f7c2daca1d14219b91b2cee55","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"\"\"List address scopes that belong to a given tenant.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    resource \u003d \u0027addrscope\u0027"},{"line_number":25,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027name\u0027]"},{"line_number":26,"context_line":"    pagination_support \u003d True"},{"line_number":27,"context_line":"    sorting_support \u003d True"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_72d4f9e7","line":25,"updated":"2015-06-25 12:48:43.000000000","message":"Will change","commit_id":"e9585ac60719e5c5bc76fc99dcd6e927f68709d3"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"f40712c118635004bcc7345fa3cfc2cf0cde4432","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    sorting_support \u003d True"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ShowAddrScope(neutronV20.ShowCommand):"},{"line_number":31,"context_line":"    \"\"\"Show information of a given address scope.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    resource \u003d \u0027addrscope\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_64421e6a","line":30,"updated":"2015-06-24 17:10:43.000000000","message":"Same as above and to all other references to \"AddrScope\" in this file","commit_id":"e9585ac60719e5c5bc76fc99dcd6e927f68709d3"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c9c3e656ce70e09f7c2daca1d14219b91b2cee55","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ShowAddrScope(neutronV20.ShowCommand):"},{"line_number":31,"context_line":"    \"\"\"Show information of a given address scope.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    resource \u003d \u0027addrscope\u0027"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_32099195","line":31,"updated":"2015-06-25 12:48:43.000000000","message":"Will change","commit_id":"e9585ac60719e5c5bc76fc99dcd6e927f68709d3"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"9b116e65171e8b92bc15ede5b62442f5a281eadf","unresolved":false,"context_lines":[{"line_number":63,"context_line":"class UpdateAddrScope(neutronV20.UpdateCommand):"},{"line_number":64,"context_line":"    \"\"\"Update address scope information.\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    resource \u003d \u0027addrscope\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_d7237756","line":66,"updated":"2015-06-25 12:31:15.000000000","message":"AFAIK For update also we need to parse arguments","commit_id":"e9585ac60719e5c5bc76fc99dcd6e927f68709d3"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c9c3e656ce70e09f7c2daca1d14219b91b2cee55","unresolved":false,"context_lines":[{"line_number":63,"context_line":"class UpdateAddrScope(neutronV20.UpdateCommand):"},{"line_number":64,"context_line":"    \"\"\"Update address scope information.\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    resource \u003d \u0027addrscope\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_b23cc12f","line":66,"updated":"2015-06-25 12:48:43.000000000","message":"This is under discussion. Will check and update","commit_id":"e9585ac60719e5c5bc76fc99dcd6e927f68709d3"}],"neutronclient/shell.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"c5991737458a3f46ee589eb6c76c31c862409d66","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    \u0027address-scope-show\u0027: address_scope.ShowAddressScope,"},{"line_number":153,"context_line":"    \u0027address-scope-create\u0027: address_scope.CreateAddressScope,"},{"line_number":154,"context_line":"    \u0027address-scope-delete\u0027: address_scope.DeleteAddressScope,"},{"line_number":155,"context_line":"    \u0027address-scope-update\u0027: address_scope.UpdateAddressScope,"},{"line_number":156,"context_line":"    \u0027net-list\u0027: network.ListNetwork,"},{"line_number":157,"context_line":"    \u0027net-external-list\u0027: network.ListExternalNetwork,"},{"line_number":158,"context_line":"    \u0027net-show\u0027: network.ShowNetwork,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_94e1119d","line":155,"updated":"2015-07-21 04:37:25.000000000","message":"We add new commands at the end.","commit_id":"f093175598cb7592b2cb85ba3e892d50436d6efe"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"6f702a66b5129579151c55df3c60c66ea72b2dd7","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    \u0027address-scope-show\u0027: address_scope.ShowAddressScope,"},{"line_number":153,"context_line":"    \u0027address-scope-create\u0027: address_scope.CreateAddressScope,"},{"line_number":154,"context_line":"    \u0027address-scope-delete\u0027: address_scope.DeleteAddressScope,"},{"line_number":155,"context_line":"    \u0027address-scope-update\u0027: address_scope.UpdateAddressScope,"},{"line_number":156,"context_line":"    \u0027net-list\u0027: network.ListNetwork,"},{"line_number":157,"context_line":"    \u0027net-external-list\u0027: network.ListExternalNetwork,"},{"line_number":158,"context_line":"    \u0027net-show\u0027: network.ShowNetwork,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_ea6430e6","line":155,"in_reply_to":"3a50d1a3_94e1119d","updated":"2015-07-21 05:29:42.000000000","message":"I have just added it as per the alphabetical order. If this is the convention will change move it to the end :-).","commit_id":"f093175598cb7592b2cb85ba3e892d50436d6efe"}],"neutronclient/tests/unit/test_cli20_address_scope.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a708fb6da9f1f101ae7debf5128a569944140c0e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(CLITestV20AddressScopeJSON, self).setUp(plurals\u003d{\u0027tags\u0027: \u0027tag\u0027})"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_create_address_scope_shared(self):"},{"line_number":30,"context_line":"        \"\"\"Create address_scope: foo-address-scope.\"\"\""},{"line_number":31,"context_line":"        resource \u003d \u0027address_scope\u0027"},{"line_number":32,"context_line":"        cmd \u003d address_scope.CreateAddressScope("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_eaaeb897","line":29,"updated":"2015-07-04 07:33:15.000000000","message":"When we consider extensibility, it is better to have tests:\n\n- test_create_address_scope_with_minimum_option\n- test_create_address_scope_with_all_options\n\nIf we have more combinations we can add it.","commit_id":"ea941fe27ada11be7ec0934ea73fcc77781be739"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a248916c9929bacd36f39e469bebf0305bf582f0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(CLITestV20AddressScopeJSON, self).setUp(plurals\u003d{\u0027tags\u0027: \u0027tag\u0027})"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_create_address_scope_shared(self):"},{"line_number":30,"context_line":"        \"\"\"Create address_scope: foo-address-scope.\"\"\""},{"line_number":31,"context_line":"        resource \u003d \u0027address_scope\u0027"},{"line_number":32,"context_line":"        cmd \u003d address_scope.CreateAddressScope("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_f15c1d7f","line":29,"in_reply_to":"ba3cc151_d18123c5","updated":"2015-07-07 10:02:59.000000000","message":"Ok. Done!","commit_id":"ea941fe27ada11be7ec0934ea73fcc77781be739"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d0e1bfef38643fbc73c4f95cc412fca0a22e79ae","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(CLITestV20AddressScopeJSON, self).setUp(plurals\u003d{\u0027tags\u0027: \u0027tag\u0027})"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_create_address_scope_shared(self):"},{"line_number":30,"context_line":"        \"\"\"Create address_scope: foo-address-scope.\"\"\""},{"line_number":31,"context_line":"        resource \u003d \u0027address_scope\u0027"},{"line_number":32,"context_line":"        cmd \u003d address_scope.CreateAddressScope("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_d18123c5","line":29,"in_reply_to":"ba3cc151_eaaeb897","updated":"2015-07-05 05:54:47.000000000","message":"Good suggestion.. Will add test cases as suggested.","commit_id":"ea941fe27ada11be7ec0934ea73fcc77781be739"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"c60424235eca7caaad5233e3e1448d7d43dbdc5e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                   position_names, position_values)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_create_address_scope_shared(self):"},{"line_number":57,"context_line":"        \"\"\"Create address_scope: foo-address-scope.\"\"\""},{"line_number":58,"context_line":"        resource \u003d \u0027address_scope\u0027"},{"line_number":59,"context_line":"        cmd \u003d address_scope.CreateAddressScope("},{"line_number":60,"context_line":"            test_cli20.MyApp(sys.stdout), None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_d3f614f9","line":57,"updated":"2015-07-16 15:01:27.000000000","message":"nit: docstring should note this is creating a shared scope","commit_id":"f093175598cb7592b2cb85ba3e892d50436d6efe"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"c60424235eca7caaad5233e3e1448d7d43dbdc5e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                   position_names, position_values)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_create_address_scope_not_shared(self):"},{"line_number":70,"context_line":"        \"\"\"Create address_scope: foo-address-scope.\"\"\""},{"line_number":71,"context_line":"        resource \u003d \u0027address_scope\u0027"},{"line_number":72,"context_line":"        cmd \u003d address_scope.CreateAddressScope("},{"line_number":73,"context_line":"            test_cli20.MyApp(sys.stdout), None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_13623cae","line":70,"updated":"2015-07-16 15:01:27.000000000","message":"nit: docstring should note this is creating a unshared scope","commit_id":"f093175598cb7592b2cb85ba3e892d50436d6efe"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"c60424235eca7caaad5233e3e1448d7d43dbdc5e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                                   position_names, position_values)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_update_address_scope_exception(self):"},{"line_number":96,"context_line":"        \"\"\"Update address_scope: myid.\"\"\""},{"line_number":97,"context_line":"        resource \u003d \u0027address_scope\u0027"},{"line_number":98,"context_line":"        cmd \u003d address_scope.UpdateAddressScope("},{"line_number":99,"context_line":"            test_cli20.MyApp(sys.stdout), None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_f30318bd","line":96,"updated":"2015-07-16 15:01:27.000000000","message":"nit: docstring should note this is a negative test","commit_id":"f093175598cb7592b2cb85ba3e892d50436d6efe"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c7b35bfbc7aee7dae13d4899fc6ddf9cf6bdee3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self._test_create_resource(resource, cmd, name, myid, args,"},{"line_number":54,"context_line":"                                   position_names, position_values)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_create_address_scope_shared(self):"},{"line_number":57,"context_line":"        \"\"\"Create shared address_scope: foo-address-scope.\"\"\""},{"line_number":58,"context_line":"        resource \u003d \u0027address_scope\u0027"},{"line_number":59,"context_line":"        cmd \u003d address_scope.CreateAddressScope("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_3c289f32","line":56,"updated":"2015-07-23 06:50:01.000000000","message":"This is a duplicate of L.43. Looks unnecessary.","commit_id":"28a2064e75b7a7ba2ebbd8aa160fe1614eeb1485"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"f2defdd5e52365146b41983dee0f0586c755e860","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self._test_create_resource(resource, cmd, name, myid, args,"},{"line_number":54,"context_line":"                                   position_names, position_values)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_create_address_scope_shared(self):"},{"line_number":57,"context_line":"        \"\"\"Create shared address_scope: foo-address-scope.\"\"\""},{"line_number":58,"context_line":"        resource \u003d \u0027address_scope\u0027"},{"line_number":59,"context_line":"        cmd \u003d address_scope.CreateAddressScope("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_bff6e15a","line":56,"in_reply_to":"3a50d1a3_3c289f32","updated":"2015-07-23 07:12:22.000000000","message":"I agree but we have added these test-cases to address your PS2 comment. Since this framework will be extended in the future so it make sense to keep it to avoid missing it in the future.","commit_id":"28a2064e75b7a7ba2ebbd8aa160fe1614eeb1485"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"994df3c03bf250ca37fd60feea5e4947760890e5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self._test_create_resource(resource, cmd, name, myid, args,"},{"line_number":54,"context_line":"                                   position_names, position_values)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_create_address_scope_shared(self):"},{"line_number":57,"context_line":"        \"\"\"Create shared address_scope: foo-address-scope.\"\"\""},{"line_number":58,"context_line":"        resource \u003d \u0027address_scope\u0027"},{"line_number":59,"context_line":"        cmd \u003d address_scope.CreateAddressScope("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_2a7051a3","line":56,"in_reply_to":"3a50d1a3_bff6e15a","updated":"2015-07-23 07:25:25.000000000","message":"OK, as discussed over the IRC, we will remove \"test_create_address_scope_shared\" and \"test_create_address_scope_not_shared\" to avoid redundancy.\n\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-neutron/%23openstack-neutron.2015-07-23.log.html","commit_id":"28a2064e75b7a7ba2ebbd8aa160fe1614eeb1485"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c7b35bfbc7aee7dae13d4899fc6ddf9cf6bdee3","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self._test_create_resource(resource, cmd, name, myid, args,"},{"line_number":67,"context_line":"                                   position_names, position_values)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_create_address_scope_not_shared(self):"},{"line_number":70,"context_line":"        \"\"\"Create unshared address_scope: foo-address-scope.\"\"\""},{"line_number":71,"context_line":"        resource \u003d \u0027address_scope\u0027"},{"line_number":72,"context_line":"        cmd \u003d address_scope.CreateAddressScope("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_9c19b324","line":69,"updated":"2015-07-23 06:50:01.000000000","message":"This is a duplicate of L.30. Looks unnecessary.","commit_id":"28a2064e75b7a7ba2ebbd8aa160fe1614eeb1485"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"994df3c03bf250ca37fd60feea5e4947760890e5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self._test_create_resource(resource, cmd, name, myid, args,"},{"line_number":67,"context_line":"                                   position_names, position_values)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_create_address_scope_not_shared(self):"},{"line_number":70,"context_line":"        \"\"\"Create unshared address_scope: foo-address-scope.\"\"\""},{"line_number":71,"context_line":"        resource \u003d \u0027address_scope\u0027"},{"line_number":72,"context_line":"        cmd \u003d address_scope.CreateAddressScope("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_8abde503","line":69,"in_reply_to":"3a50d1a3_5f98fd1b","updated":"2015-07-23 07:25:25.000000000","message":"OK, as discussed over the IRC, we will remove \"test_create_address_scope_shared\" and \"test_create_address_scope_not_shared\" to avoid redundancy.\n\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-neutron/%23openstack-neutron.2015-07-23.log.html","commit_id":"28a2064e75b7a7ba2ebbd8aa160fe1614eeb1485"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"f2defdd5e52365146b41983dee0f0586c755e860","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self._test_create_resource(resource, cmd, name, myid, args,"},{"line_number":67,"context_line":"                                   position_names, position_values)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_create_address_scope_not_shared(self):"},{"line_number":70,"context_line":"        \"\"\"Create unshared address_scope: foo-address-scope.\"\"\""},{"line_number":71,"context_line":"        resource \u003d \u0027address_scope\u0027"},{"line_number":72,"context_line":"        cmd \u003d address_scope.CreateAddressScope("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a50d1a3_5f98fd1b","line":69,"in_reply_to":"3a50d1a3_9c19b324","updated":"2015-07-23 07:12:22.000000000","message":"I agree but we have added these test-cases to address your PS2 comment. Since this framework will be extended in the future so it make sense to keep it to avoid missing it in the future.","commit_id":"28a2064e75b7a7ba2ebbd8aa160fe1614eeb1485"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"c289538f99cd281c14f65e2ec9fbf26e140ec582","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self._test_update_resource(resource, cmd, \u0027myid\u0027,"},{"line_number":83,"context_line":"                                   [\u0027myid\u0027, \u0027--name\u0027, \u0027newname-address-scope\u0027],"},{"line_number":84,"context_line":"                                   {\u0027name\u0027: \u0027newname-address-scope\u0027}"},{"line_number":85,"context_line":"                                   )"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_list_address_scope(self):"},{"line_number":88,"context_line":"        \"\"\"address_scope-list.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_cfe468a9","line":85,"updated":"2015-08-26 13:58:07.000000000","message":"Ah, so it appears it\u0027s the name of an address scope that can be updated.  OK - although question stands about whether shared should be updatable too.","commit_id":"d749973859988e30347e94029703b508e126c79e"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"f40712c118635004bcc7345fa3cfc2cf0cde4432","unresolved":false,"context_lines":[{"line_number":341,"context_line":"    subnet_path \u003d \"/subnets/%s\""},{"line_number":342,"context_line":"    subnetpools_path \u003d \"/subnetpools\""},{"line_number":343,"context_line":"    subnetpool_path \u003d \"/subnetpools/%s\""},{"line_number":344,"context_line":"    addrscopes_path \u003d \"/addrscopes\""},{"line_number":345,"context_line":"    addrscope_path \u003d \"/addrscopes/%s\""},{"line_number":346,"context_line":"    quotas_path \u003d \"/quotas\""},{"line_number":347,"context_line":"    quota_path \u003d \"/quotas/%s\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_7f214b9d","line":344,"updated":"2015-06-24 17:10:43.000000000","message":"I would prefer  : address_scopes_path \u003d \"/address-scopes\"\nSame in the below line","commit_id":"e9585ac60719e5c5bc76fc99dcd6e927f68709d3"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c9c3e656ce70e09f7c2daca1d14219b91b2cee55","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    subnetpools_path \u003d \"/subnetpools\""},{"line_number":343,"context_line":"    subnetpool_path \u003d \"/subnetpools/%s\""},{"line_number":344,"context_line":"    addrscopes_path \u003d \"/addrscopes\""},{"line_number":345,"context_line":"    addrscope_path \u003d \"/addrscopes/%s\""},{"line_number":346,"context_line":"    quotas_path \u003d \"/quotas\""},{"line_number":347,"context_line":"    quota_path \u003d \"/quotas/%s\""},{"line_number":348,"context_line":"    extensions_path \u003d \"/extensions\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_321751a4","line":345,"updated":"2015-06-25 12:48:43.000000000","message":"Ok. Will change.","commit_id":"e9585ac60719e5c5bc76fc99dcd6e927f68709d3"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"f40712c118635004bcc7345fa3cfc2cf0cde4432","unresolved":false,"context_lines":[{"line_number":668,"context_line":"                         **_params)"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":"    @APIParamsCall"},{"line_number":671,"context_line":"    def show_addrscope(self, addrscope, **_params):"},{"line_number":672,"context_line":"        \"\"\"Fetches information of a certain address scope.\"\"\""},{"line_number":673,"context_line":"        return self.get(self.addrscope_path % (addrscope), params\u003d_params)"},{"line_number":674,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_5f5567f7","line":671,"updated":"2015-06-24 17:10:43.000000000","message":"Better to rename the param to \"address_scope\"","commit_id":"e9585ac60719e5c5bc76fc99dcd6e927f68709d3"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c9c3e656ce70e09f7c2daca1d14219b91b2cee55","unresolved":false,"context_lines":[{"line_number":669,"context_line":""},{"line_number":670,"context_line":"    @APIParamsCall"},{"line_number":671,"context_line":"    def show_addrscope(self, addrscope, **_params):"},{"line_number":672,"context_line":"        \"\"\"Fetches information of a certain address scope.\"\"\""},{"line_number":673,"context_line":"        return self.get(self.addrscope_path % (addrscope), params\u003d_params)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    @APIParamsCall"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_f20c8994","line":672,"updated":"2015-06-25 12:48:43.000000000","message":"Ok. Will change.","commit_id":"e9585ac60719e5c5bc76fc99dcd6e927f68709d3"}]}