)]}'
{"neutronclient/neutron/v2_0/subnetpool.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4120e0e826a4ed82fb472032f5365db8ac6cc555","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Parse and update for \"address-scope\" option"},{"line_number":87,"context_line":"        if parsed_args.address_scope:"},{"line_number":88,"context_line":"            _addrscope_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":89,"context_line":"                self.get_client(), \u0027address-scope\u0027,"},{"line_number":90,"context_line":"                parsed_args.address_scope)"},{"line_number":91,"context_line":"            body[\u0027subnetpool\u0027][\u0027address_scope_id\u0027] \u003d _addrscope_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_3a29869e","line":88,"updated":"2015-07-23 04:46:05.000000000","message":"I believe we got to change over here as well.\n\nSome more suggestions:\n\n1. It would be better to define a separate function called \"get_address_scope_id\" inside https://review.openstack.org/#/c/194635/5/neutronclient/neutron/v2_0/address_scope.py and call the same from this file. This will ensure we don\u0027t repeat mistakes.\n\n2. Make this patch dependent upon \"https://review.openstack.org/#/c/194635/\".","commit_id":"60ac2522f665f1711e3d5bcb6536f2f96df356c9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"b47a9bbcac31673d62563ce248f2590d4775cc17","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        # Parse and update for \"address-scope\" option"},{"line_number":87,"context_line":"        if parsed_args.address_scope:"},{"line_number":88,"context_line":"            _addrscope_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":89,"context_line":"                self.get_client(), \u0027address-scope\u0027,"},{"line_number":90,"context_line":"                parsed_args.address_scope)"},{"line_number":91,"context_line":"            body[\u0027subnetpool\u0027][\u0027address_scope_id\u0027] \u003d _addrscope_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_f29f4901","line":88,"in_reply_to":"3a50d1a3_3a29869e","updated":"2015-08-04 16:20:29.000000000","message":"Good catch on #2.  In my devstack, I had this patch rebased on 194635 but for some reason which I cannot remember, I rebased it to master before pushing it up to gerrit.  Thanks for pointing out that this patch cannot work correctly without it.","commit_id":"60ac2522f665f1711e3d5bcb6536f2f96df356c9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"eec24f129f8541a14a3c3f328721c662189234b9","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            body[\u0027subnetpool\u0027][\u0027address_scope_id\u0027] \u003d None"},{"line_number":129,"context_line":"        elif parsed_args.address_scope:"},{"line_number":130,"context_line":"            _addrscope_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":131,"context_line":"                self.get_client(), \u0027address_scope\u0027,"},{"line_number":132,"context_line":"                parsed_args.address_scope)"},{"line_number":133,"context_line":"            body[\u0027subnetpool\u0027][\u0027address_scope_id\u0027] \u003d _addrscope_id"},{"line_number":134,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_589d8c64","line":131,"updated":"2015-07-22 20:32:53.000000000","message":"I tried briefly to add this to the tests.  However, the current tests are not structured to test this easily.  It may take a bit of work to add tests for this.","commit_id":"60ac2522f665f1711e3d5bcb6536f2f96df356c9"}]}