)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28c0bfc065f907edaa7fb70362f73c61a151863a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Co-Authored-By: Ryan Tidwell \u003crktidwell85@gmail.com\u003e"},{"line_number":19,"context_line":"Co-Authored-By: Numan Siddique \u003cnusiddiq@redhat.com\u003e"},{"line_number":20,"context_line":"Co-Authored-By: Jaume Devesa \u003cdevvesa@gmail.com\u003e"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I5b20bcbf6c837495d81c395f600498d2c8f3495c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa69d971_d3dcbe1a","line":21,"updated":"2015-12-29 17:26:24.000000000","message":"Could you add Depends-On to a neutron patch?\nBy doing so, we can easily know when this patch becomes ready to merge.","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb9a1131f59024385b374fc25990c9260cc1e154","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Co-Authored-By: Ryan Tidwell \u003crktidwell85@gmail.com\u003e"},{"line_number":19,"context_line":"Co-Authored-By: Numan Siddique \u003cnusiddiq@redhat.com\u003e"},{"line_number":20,"context_line":"Co-Authored-By: Jaume Devesa \u003cdevvesa@gmail.com\u003e"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I5b20bcbf6c837495d81c395f600498d2c8f3495c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa69d971_e0eb1baf","line":21,"in_reply_to":"fa69d971_d3dcbe1a","updated":"2015-12-30 04:26:17.000000000","message":"Sure, Will do. Make Sense!","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     11d9cc87 (Updated from global requirements)"},{"line_number":2,"context_line":"Author:     vikram.choudhary \u003cvikram.choudhary@huawei.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2015-12-31 20:42:17 +0530"},{"line_number":4,"context_line":"Commit:     vikram.choudhary \u003cvikram.choudhary@huawei.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5a5ae5dd_0c93fb5c","line":1,"updated":"2016-02-03 13:57:44.000000000","message":"Add release notes.","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     11d9cc87 (Updated from global requirements)"},{"line_number":2,"context_line":"Author:     vikram.choudhary \u003cvikram.choudhary@huawei.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2015-12-31 20:42:17 +0530"},{"line_number":4,"context_line":"Commit:     vikram.choudhary \u003cvikram.choudhary@huawei.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"5a5ae5dd_2d0b9a2b","line":1,"in_reply_to":"5a5ae5dd_0c93fb5c","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"}],"neutronclient/neutron/v2_0/agentscheduler.py":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"12362b2dd264cacd998e2affb65747ec52b14136","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        return data"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"class AddBgpSpeakerToDrAgent(neutronV20.NeutronCommand):"},{"line_number":339,"context_line":"    \"\"\"Add a BGP speaker to a DR agent.\"\"\""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_066074a3","line":338,"updated":"2015-07-31 12:29:47.000000000","message":"PEP8: Note: When using abbreviations in CapWords, capitalize all the letters of the abbreviation. Thus HTTPServerError is better than HttpServerError.\n\nI think you should DRAgent throughout rather than DrAgent which reads like Doctor Agent.","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4bb02eb23adf3ff725b652b189b018c43e1115f9","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        return data"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"class AddBgpSpeakerToDrAgent(neutronV20.NeutronCommand):"},{"line_number":339,"context_line":"    \"\"\"Add a BGP speaker to a DR agent.\"\"\""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_9e14a79f","line":338,"in_reply_to":"3a50d1a3_066074a3","updated":"2015-08-01 05:02:33.000000000","message":"+1. Make Sense. Will Change. I feel we capitalize BGP instead of Bgp as well. :-)","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"12362b2dd264cacd998e2affb65747ec52b14136","unresolved":false,"context_lines":[{"line_number":391,"context_line":"    pass"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"class ListBgpSpeakersOnDrAgent(neutronV20.ListCommand):"},{"line_number":395,"context_line":"    \"\"\"List BGP Speaker hosted by a DR agent.\"\"\""},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027local_as\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_4670bc40","line":394,"updated":"2015-07-31 12:29:47.000000000","message":"PEP8 again, ListBGPSpeakerOnDRAgent","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"12362b2dd264cacd998e2affb65747ec52b14136","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        return data"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"class ListDrAgentsHostingBgpSpeaker(neutronV20.ListCommand):"},{"line_number":416,"context_line":"    \"\"\"List DR agents hosting a BGP speaker.\"\"\""},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    resource \u003d \u0027agent\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_26c3303a","line":415,"updated":"2015-07-31 12:29:47.000000000","message":"Here too, ListDRAgentsHostingBGPSpeaker","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4bb02eb23adf3ff725b652b189b018c43e1115f9","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        return data"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"class ListDrAgentsHostingBgpSpeaker(neutronV20.ListCommand):"},{"line_number":416,"context_line":"    \"\"\"List DR agents hosting a BGP speaker.\"\"\""},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    resource \u003d \u0027agent\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_3e0b137f","line":415,"in_reply_to":"3a50d1a3_26c3303a","updated":"2015-08-01 05:02:33.000000000","message":"+1. Will change.","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28c0bfc065f907edaa7fb70362f73c61a151863a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fa69d971_f303020c","updated":"2015-12-29 17:26:24.000000000","message":"I think it is better to add a new module such as bgpagentscheduler.py or bgp/agentscheduler.py","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb9a1131f59024385b374fc25990c9260cc1e154","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fa69d971_c0fdb76f","in_reply_to":"fa69d971_f303020c","updated":"2015-12-30 04:26:17.000000000","message":"Ok. I can do as suggested.","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"}],"neutronclient/neutron/v2_0/bgp/agentscheduler.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"92aa09a37490ac8996c7c2c63a123671aa46e518","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Huawei Technologies India Pvt. Ltd."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_1cd462bb","line":1,"updated":"2016-01-08 07:47:01.000000000","message":"Let\u0027s roll to 2016","commit_id":"bbc4b9dea8bdc774bf588187b35d314e777296e8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"92aa09a37490ac8996c7c2c63a123671aa46e518","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from __future__ import print_function"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_bc8996cc","line":14,"updated":"2016-01-08 07:47:01.000000000","message":"Let\u0027s rename this file as \u0027dragentscheduler\u0027 for consistency with the server code.","commit_id":"bbc4b9dea8bdc774bf588187b35d314e777296e8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7a034a775c82c1949ca88d6145582f7f303ea3b3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        return parser"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def run(self, parsed_args):"},{"line_number":40,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":41,"context_line":"        neutron_client \u003d self.get_client()"},{"line_number":42,"context_line":"        _speaker_id \u003d bgp_speaker.get_bgp_speaker_id(neutron_client,"},{"line_number":43,"context_line":"                                                     parsed_args.bgp_speaker)"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_6f955085","line":40,"updated":"2016-01-11 07:11:12.000000000","message":"Remove debug and use take_action instead of run as proposed in https://review.openstack.org/#/c/265287","commit_id":"bbc4b9dea8bdc774bf588187b35d314e777296e8"}],"neutronclient/neutron/v2_0/bgp/dragentscheduler.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"720e08eb36790a44a4a21bbf2270ad87063a14db","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        parser.add_argument("},{"line_number":30,"context_line":"            \u0027dragent_id\u0027,"},{"line_number":31,"context_line":"            metavar\u003d\u0027BGP_DRAGENT_ID\u0027,"},{"line_number":32,"context_line":"            help\u003d_(\u0027ID of the DR agent.\u0027))"},{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \u0027bgp_speaker\u0027,"},{"line_number":35,"context_line":"            metavar\u003d\u0027BGP_SPEAKER\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_62f96f4d","line":32,"updated":"2016-02-03 07:33:58.000000000","message":"why cant we use a name?","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        parser.add_argument("},{"line_number":30,"context_line":"            \u0027dragent_id\u0027,"},{"line_number":31,"context_line":"            metavar\u003d\u0027BGP_DRAGENT_ID\u0027,"},{"line_number":32,"context_line":"            help\u003d_(\u0027ID of the DR agent.\u0027))"},{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \u0027bgp_speaker\u0027,"},{"line_number":35,"context_line":"            metavar\u003d\u0027BGP_SPEAKER\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_0640bd55","line":32,"in_reply_to":"5a5ae5dd_62f96f4d","updated":"2016-02-03 13:57:44.000000000","message":"Agent extension doesn\u0027t have name ;)\n\nhttps://github.com/openstack/neutron/blob/master/neutron/extensions/agent.py","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        return parser"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def run(self, parsed_args):"},{"line_number":40,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":41,"context_line":"        neutron_client \u003d self.get_client()"},{"line_number":42,"context_line":"        _speaker_id \u003d bgp_speaker.get_bgp_speaker_id(neutron_client,"},{"line_number":43,"context_line":"                                                     parsed_args.bgp_speaker)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_a1e75311","line":40,"updated":"2016-02-03 13:57:44.000000000","message":"debug not required as per \"https://review.openstack.org/#/c/265287/4/neutronclient/neutron/v2_0/agentscheduler.py\". Please remove.","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        return parser"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def run(self, parsed_args):"},{"line_number":40,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":41,"context_line":"        neutron_client \u003d self.get_client()"},{"line_number":42,"context_line":"        _speaker_id \u003d bgp_speaker.get_bgp_speaker_id(neutron_client,"},{"line_number":43,"context_line":"                                                     parsed_args.bgp_speaker)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_88ecfc2a","line":40,"in_reply_to":"5a5ae5dd_a1e75311","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"720e08eb36790a44a4a21bbf2270ad87063a14db","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                                     parsed_args.bgp_speaker)"},{"line_number":44,"context_line":"        neutron_client.add_bgp_speaker_to_dragent("},{"line_number":45,"context_line":"            parsed_args.dragent_id, {\u0027bgp_speaker_id\u0027: _speaker_id})"},{"line_number":46,"context_line":"        print(_(\u0027Associated BGP speaker %s to the DR agent.\u0027)"},{"line_number":47,"context_line":"              % parsed_args.bgp_speaker, file\u003dself.app.stdout)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_9d65eee2","line":46,"updated":"2016-02-03 07:33:58.000000000","message":"do we really need this ?","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                                                     parsed_args.bgp_speaker)"},{"line_number":44,"context_line":"        neutron_client.add_bgp_speaker_to_dragent("},{"line_number":45,"context_line":"            parsed_args.dragent_id, {\u0027bgp_speaker_id\u0027: _speaker_id})"},{"line_number":46,"context_line":"        print(_(\u0027Associated BGP speaker %s to the DR agent.\u0027)"},{"line_number":47,"context_line":"              % parsed_args.bgp_speaker, file\u003dself.app.stdout)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_e108eb2a","line":46,"in_reply_to":"5a5ae5dd_9d65eee2","updated":"2016-02-03 13:57:44.000000000","message":"Just tried to be consistent with existing implementation.\n\nhttps://github.com/openstack/python-neutronclient/blob/master/neutronclient/neutron/v2_0/agentscheduler.py#L48-L49\n\nIn addition to this, a prompt to the user is good always.","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"720e08eb36790a44a4a21bbf2270ad87063a14db","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027dragent_id\u0027,"},{"line_number":58,"context_line":"            metavar\u003d\u0027BGP_DRAGENT_ID\u0027,"},{"line_number":59,"context_line":"            help\u003d_(\u0027ID of the DR agent.\u0027))"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027bgp_speaker\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027BGP_SPEAKER\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_dd392643","line":59,"updated":"2016-02-03 07:33:58.000000000","message":"If the body same, can we use a single function for both AddBGPSpeakerToDRAgent and Remove....","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027dragent_id\u0027,"},{"line_number":58,"context_line":"            metavar\u003d\u0027BGP_DRAGENT_ID\u0027,"},{"line_number":59,"context_line":"            help\u003d_(\u0027ID of the DR agent.\u0027))"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027bgp_speaker\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027BGP_SPEAKER\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_2894e840","line":59,"in_reply_to":"5a5ae5dd_6134fbdd","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027dragent_id\u0027,"},{"line_number":58,"context_line":"            metavar\u003d\u0027BGP_DRAGENT_ID\u0027,"},{"line_number":59,"context_line":"            help\u003d_(\u0027ID of the DR agent.\u0027))"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027bgp_speaker\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027BGP_SPEAKER\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_6134fbdd","line":59,"in_reply_to":"5a5ae5dd_dd392643","updated":"2016-02-03 13:57:44.000000000","message":"Make sense. This could be made common.","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        return parser"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def run(self, parsed_args):"},{"line_number":67,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":68,"context_line":"        neutron_client \u003d self.get_client()"},{"line_number":69,"context_line":"        _speaker_id \u003d bgp_speaker.get_bgp_speaker_id(neutron_client,"},{"line_number":70,"context_line":"                                                     parsed_args.bgp_speaker)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_011427f3","line":67,"updated":"2016-02-03 13:57:44.000000000","message":"debug not required as per \"https://review.openstack.org/#/c/265287/4/neutronclient/neutron/v2_0/agentscheduler.py\". Please remove.","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        return parser"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def run(self, parsed_args):"},{"line_number":67,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":68,"context_line":"        neutron_client \u003d self.get_client()"},{"line_number":69,"context_line":"        _speaker_id \u003d bgp_speaker.get_bgp_speaker_id(neutron_client,"},{"line_number":70,"context_line":"                                                     parsed_args.bgp_speaker)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_0899ec7b","line":67,"in_reply_to":"5a5ae5dd_011427f3","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"73b825977e0825ceafb3cd4c98950943417d2d3c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from __future__ import print_function"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutronclient.i18n import _"},{"line_number":20,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":21,"context_line":"from neutronclient.neutron.v2_0.bgp import speaker as bgp_speaker"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_195be32f","line":19,"updated":"2016-02-16 00:37:14.000000000","message":"please use _i18n","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"45051d6af016f5e18bcca14623cbf5a28bcf379c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from __future__ import print_function"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutronclient.i18n import _"},{"line_number":20,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":21,"context_line":"from neutronclient.neutron.v2_0.bgp import speaker as bgp_speaker"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_31899327","line":19,"in_reply_to":"dae33548_022d2846","updated":"2016-02-16 09:47:45.000000000","message":"Done","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bf29b6d521e866423c79edce26b3d271fdd63439","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from __future__ import print_function"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutronclient.i18n import _"},{"line_number":20,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":21,"context_line":"from neutronclient.neutron.v2_0.bgp import speaker as bgp_speaker"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_022d2846","line":19,"in_reply_to":"dae33548_195be32f","updated":"2016-02-16 03:23:03.000000000","message":"Ok","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"93d0c6b4053d13bf98e36ba28390054cfd5a29b8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"def add_common_args(parser):"},{"line_number":25,"context_line":"    parser.add_argument(\u0027dragent_id\u0027,"},{"line_number":26,"context_line":"                        metavar\u003d\u0027BGP_DRAGENT_ID\u0027,"},{"line_number":27,"context_line":"                        help\u003d_(\u0027ID of the DR agent.\u0027))"},{"line_number":28,"context_line":"    parser.add_argument(\u0027bgp_speaker\u0027,"},{"line_number":29,"context_line":"                        metavar\u003d\u0027BGP_SPEAKER\u0027,"},{"line_number":30,"context_line":"                        help\u003d_(\u0027ID or name of the BGP speaker.\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_dc3180ee","line":27,"range":{"start_line":27,"start_character":42,"end_line":27,"end_character":45},"updated":"2016-02-15 14:38:16.000000000","message":"Nit: I am not sure \u0027DR\u0027 is easy to understand.\nCan we use \u0027Dynamic Routing agent\u0027 instead?\nEvery time I review this code, I wonder what DR means.\nI think most operators feel same, but I am not sure which is better.","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bf29b6d521e866423c79edce26b3d271fdd63439","unresolved":false,"context_lines":[{"line_number":24,"context_line":"def add_common_args(parser):"},{"line_number":25,"context_line":"    parser.add_argument(\u0027dragent_id\u0027,"},{"line_number":26,"context_line":"                        metavar\u003d\u0027BGP_DRAGENT_ID\u0027,"},{"line_number":27,"context_line":"                        help\u003d_(\u0027ID of the DR agent.\u0027))"},{"line_number":28,"context_line":"    parser.add_argument(\u0027bgp_speaker\u0027,"},{"line_number":29,"context_line":"                        metavar\u003d\u0027BGP_SPEAKER\u0027,"},{"line_number":30,"context_line":"                        help\u003d_(\u0027ID or name of the BGP speaker.\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_c21b401a","line":27,"range":{"start_line":27,"start_character":42,"end_line":27,"end_character":45},"in_reply_to":"dae33548_7914af43","updated":"2016-02-16 03:23:03.000000000","message":"Will make it more explicit ;)","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"45051d6af016f5e18bcca14623cbf5a28bcf379c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"def add_common_args(parser):"},{"line_number":25,"context_line":"    parser.add_argument(\u0027dragent_id\u0027,"},{"line_number":26,"context_line":"                        metavar\u003d\u0027BGP_DRAGENT_ID\u0027,"},{"line_number":27,"context_line":"                        help\u003d_(\u0027ID of the DR agent.\u0027))"},{"line_number":28,"context_line":"    parser.add_argument(\u0027bgp_speaker\u0027,"},{"line_number":29,"context_line":"                        metavar\u003d\u0027BGP_SPEAKER\u0027,"},{"line_number":30,"context_line":"                        help\u003d_(\u0027ID or name of the BGP speaker.\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_915a1f4f","line":27,"range":{"start_line":27,"start_character":42,"end_line":27,"end_character":45},"in_reply_to":"dae33548_c21b401a","updated":"2016-02-16 09:47:45.000000000","message":"Done","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"8f120d699439a11be02aacf3b4d7458668b70243","unresolved":false,"context_lines":[{"line_number":24,"context_line":"def add_common_args(parser):"},{"line_number":25,"context_line":"    parser.add_argument(\u0027dragent_id\u0027,"},{"line_number":26,"context_line":"                        metavar\u003d\u0027BGP_DRAGENT_ID\u0027,"},{"line_number":27,"context_line":"                        help\u003d_(\u0027ID of the DR agent.\u0027))"},{"line_number":28,"context_line":"    parser.add_argument(\u0027bgp_speaker\u0027,"},{"line_number":29,"context_line":"                        metavar\u003d\u0027BGP_SPEAKER\u0027,"},{"line_number":30,"context_line":"                        help\u003d_(\u0027ID or name of the BGP speaker.\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_fc9f245d","line":27,"range":{"start_line":27,"start_character":42,"end_line":27,"end_character":45},"in_reply_to":"dae33548_dc3180ee","updated":"2016-02-15 14:43:34.000000000","message":"+1\nI\u0027m much more likely to think \"Disaster Recovery\" when I see DR than I am to think \"Dynamic Routing\".","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"73b825977e0825ceafb3cd4c98950943417d2d3c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"def add_common_args(parser):"},{"line_number":25,"context_line":"    parser.add_argument(\u0027dragent_id\u0027,"},{"line_number":26,"context_line":"                        metavar\u003d\u0027BGP_DRAGENT_ID\u0027,"},{"line_number":27,"context_line":"                        help\u003d_(\u0027ID of the DR agent.\u0027))"},{"line_number":28,"context_line":"    parser.add_argument(\u0027bgp_speaker\u0027,"},{"line_number":29,"context_line":"                        metavar\u003d\u0027BGP_SPEAKER\u0027,"},{"line_number":30,"context_line":"                        help\u003d_(\u0027ID or name of the BGP speaker.\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_7914af43","line":27,"range":{"start_line":27,"start_character":42,"end_line":27,"end_character":45},"in_reply_to":"dae33548_fc9f245d","updated":"2016-02-16 00:37:14.000000000","message":"+1","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"}],"neutronclient/neutron/v2_0/bgp/peer.py":[{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"616891e07be66638429c0ae3a0e3a84680ed2ee8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":31,"context_line":"    if ((not parsed_args.auth_type) and (parsed_args.password)):"},{"line_number":32,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide auth-type, if password \u0027"},{"line_number":33,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class ListPeers(neutronv20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_4f177654","line":33,"updated":"2015-07-31 13:24:36.000000000","message":"adding a validation that `remote_as` between 1 and 65535 here?","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4bb02eb23adf3ff725b652b189b018c43e1115f9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":31,"context_line":"    if ((not parsed_args.auth_type) and (parsed_args.password)):"},{"line_number":32,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide auth-type, if password \u0027"},{"line_number":33,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class ListPeers(neutronv20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_1e689720","line":33,"in_reply_to":"3a50d1a3_4f177654","updated":"2015-08-01 05:02:33.000000000","message":"Is it really required.. anyways we have provided the range info in the help \n\nparser.add_argument(\t\n            \u0027remote_as\u0027,\n            metavar\u003d\u0027PEER_REMOTE_AS\u0027,\n            help\u003d_(\u0027Peer autonomous system number.(integer in [1, 65535]\u0027))\n\nMoreover, neutron-server will return error for this but we can do this if really required. Actually, I added and then removed :-)","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b7653800e86051a910e1399352dccffbc8c9383b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \"\"\"List BGP peers.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    resource \u003d \u0027bgp_peer\u0027"},{"line_number":43,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027peer_ip\u0027, \u0027remote_as\u0027]"},{"line_number":44,"context_line":"    pagination_support \u003d True"},{"line_number":45,"context_line":"    sorting_support \u003d True"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_578e8a2e","line":43,"updated":"2015-08-21 07:26:32.000000000","message":"Need to show Peer state. Please check how we can achieve this.","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bdce2a719caf7a1320577c2df8beee0766643b7d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \"\"\"List BGP peers.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    resource \u003d \u0027bgp_peer\u0027"},{"line_number":43,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027peer_ip\u0027, \u0027remote_as\u0027]"},{"line_number":44,"context_line":"    pagination_support \u003d True"},{"line_number":45,"context_line":"    sorting_support \u003d True"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_01323310","line":43,"in_reply_to":"fa1b9901_578e8a2e","updated":"2015-09-05 11:28:30.000000000","message":"Hold-on. Server need to implement this.","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b2d2ba0088112804494a67255663feca4ea26fa","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        parser.add_argument("},{"line_number":65,"context_line":"            \u0027remote_as\u0027,"},{"line_number":66,"context_line":"            metavar\u003d\u0027PEER_REMOTE_AS\u0027,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Peer autonomous system number.(integer in [1, 65535]\u0027))"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":70,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_8926cecc","line":67,"range":{"start_line":67,"start_character":25,"end_line":67,"end_character":49},"updated":"2015-09-28 08:53:05.000000000","message":"Isn\u0027t \"AS number\" easy to read?","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a0482e40e0d242f95bab5fd9a3d69a05ae4c8458","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        parser.add_argument("},{"line_number":65,"context_line":"            \u0027remote_as\u0027,"},{"line_number":66,"context_line":"            metavar\u003d\u0027PEER_REMOTE_AS\u0027,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Peer autonomous system number.(integer in [1, 65535]\u0027))"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":70,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_e4a52cb5","line":67,"in_reply_to":"9a1a9d01_8926cecc","updated":"2015-09-28 10:41:22.000000000","message":"+1. Ok will change.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"20df98fbeb98aab07cc7b88574c6e8dba571d198","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            metavar\u003d\u0027PEER_REMOTE_AS\u0027,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Peer autonomous system number.(integer in [1, 65535]\u0027))"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":70,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":71,"context_line":"            choices\u003d[\u0027md5\u0027],"},{"line_number":72,"context_line":"            help\u003d_(\u0027Authentication algorithm in lowercase\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_50057c77","line":69,"updated":"2015-12-03 02:11:48.000000000","message":"\u0027--\u0027 is for the parameter which is optional, since the auth-type and password is mandatory, so i think should change remove \u0027--\u0027 before auth-type and password","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"3eeaa0ce00786612d16ebfbb716b5a136e73f728","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            metavar\u003d\u0027PEER_REMOTE_AS\u0027,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Peer autonomous system number.(integer in [1, 65535]\u0027))"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":70,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":71,"context_line":"            choices\u003d[\u0027md5\u0027],"},{"line_number":72,"context_line":"            help\u003d_(\u0027Authentication algorithm in lowercase\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_accfac7d","line":69,"in_reply_to":"9a8ffd7b_3696abf0","updated":"2015-12-03 06:58:54.000000000","message":"If not mandate parameter, you have to set the default value here.\nI tried, when create bgp peer without auth-type and password, it faild with log \"Failed to parse request. Required attribute \u0027auth_type\u0027 not specified\".","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bfc0fff1fc8fe30dd82cb00754859cdb092f7f28","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            metavar\u003d\u0027PEER_REMOTE_AS\u0027,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Peer autonomous system number.(integer in [1, 65535]\u0027))"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":70,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":71,"context_line":"            choices\u003d[\u0027md5\u0027],"},{"line_number":72,"context_line":"            help\u003d_(\u0027Authentication algorithm in lowercase\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_3696abf0","line":69,"in_reply_to":"9a8ffd7b_50057c77","updated":"2015-12-03 06:17:28.000000000","message":"I disagree. Authentication is not a mandate parameter. If not specified auth-type will be specified to none i.e. BGP peering session won\u0027t be authenticated.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b2a8570098d79243b64fd07a608095aef56c0c2b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            metavar\u003d\u0027PEER_REMOTE_AS\u0027,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Peer autonomous system number.(integer in [1, 65535]\u0027))"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":70,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":71,"context_line":"            choices\u003d[\u0027md5\u0027],"},{"line_number":72,"context_line":"            help\u003d_(\u0027Authentication algorithm in lowercase\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_cc00f036","line":69,"in_reply_to":"9a8ffd7b_accfac7d","updated":"2015-12-03 07:13:58.000000000","message":"Is there any specification link for the API requests?\nThe following does not have the tabular /csv form which is currenbtly being used in most specs to highlight what can be updated( or cannot) and what are necessary/optional parameters.\nhttps://review.openstack.org/#/c/125401/21/specs/liberty/bgp-dynamic-routing.rst\nWould like to know more details about the various CLI attributes","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"9b1d1f6d9a6819a6f30a04f0a45dd6371c8b7038","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            metavar\u003d\u0027PEER_REMOTE_AS\u0027,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Peer autonomous system number.(integer in [1, 65535]\u0027))"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":70,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":71,"context_line":"            choices\u003d[\u0027md5\u0027],"},{"line_number":72,"context_line":"            help\u003d_(\u0027Authentication algorithm in lowercase\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_8a339661","line":69,"in_reply_to":"9a8ffd7b_b6dfe90b","updated":"2015-12-03 13:09:36.000000000","message":"@vikram, I do not think the server side causes the issue, the log is about neutronclient parsing attribute error, i mean you have to add default value for auth-type here, i think if the auth-type is none, no need to input password.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a99a27ab5720b1775e95cae81f76dfbaeb767121","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            metavar\u003d\u0027PEER_REMOTE_AS\u0027,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Peer autonomous system number.(integer in [1, 65535]\u0027))"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":70,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":71,"context_line":"            choices\u003d[\u0027md5\u0027],"},{"line_number":72,"context_line":"            help\u003d_(\u0027Authentication algorithm in lowercase\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_b6dfe90b","line":69,"in_reply_to":"9a8ffd7b_cc00f036","updated":"2015-12-03 12:09:28.000000000","message":"@Na Zhu: I believe some new changes at the server side has led to this issue. IMO, if the values are not specified then the server MUST set it to default.\n\n@Reedip: Unfortunately, the spec is bit old and we got to update the same. We will revise it soon. Anyways thanks for your prompt.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":17609,"name":"steve","email":"ruansx@cn.ibm.com","username":"steve.ruan"},"change_message_id":"769d28cd499bccdad802427b2c23a9e808256f3f","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def validate_peer_attributes(parsed_args):"},{"line_number":30,"context_line":"    # AS number allowed range [1,65535]"},{"line_number":31,"context_line":"    validators.validate_int_range(parsed_args, \u0027remote_as\u0027, 1, 0xffff)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    if ((parsed_args.auth_type) and (not parsed_args.password)):"},{"line_number":34,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide password, if auth-type \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_d20c8d44","line":31,"range":{"start_line":31,"start_character":63,"end_line":31,"end_character":69},"updated":"2015-12-31 05:03:40.000000000","message":"Suggest to define a const","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4d4e99299f49c9d6a2546c3f5eddd484b2b1e7ab","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def validate_peer_attributes(parsed_args):"},{"line_number":30,"context_line":"    # AS number allowed range [1,65535]"},{"line_number":31,"context_line":"    validators.validate_int_range(parsed_args, \u0027remote_as\u0027, 1, 0xffff)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    if ((parsed_args.auth_type) and (not parsed_args.password)):"},{"line_number":34,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide password, if auth-type \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_317abd25","line":31,"range":{"start_line":31,"start_character":63,"end_line":31,"end_character":69},"in_reply_to":"fa69d971_d20c8d44","updated":"2015-12-31 12:02:25.000000000","message":"Ok. Will do!","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28c0bfc065f907edaa7fb70362f73c61a151863a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    # AS number allowed range [1,65535]"},{"line_number":31,"context_line":"    validators.validate_int_range(parsed_args, \u0027remote_as\u0027, 1, 0xffff)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    if ((parsed_args.auth_type) and (not parsed_args.password)):"},{"line_number":34,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide password, if auth-type \u0027"},{"line_number":35,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":36,"context_line":"    if ((not parsed_args.auth_type) and (parsed_args.password)):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_f330e2a0","line":33,"updated":"2015-12-29 17:26:24.000000000","message":"Parentheses are unnecessary.\n\n  if parsed_args.auth_type and not parsed_args.password:","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb9a1131f59024385b374fc25990c9260cc1e154","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    # AS number allowed range [1,65535]"},{"line_number":31,"context_line":"    validators.validate_int_range(parsed_args, \u0027remote_as\u0027, 1, 0xffff)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    if ((parsed_args.auth_type) and (not parsed_args.password)):"},{"line_number":34,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide password, if auth-type \u0027"},{"line_number":35,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":36,"context_line":"    if ((not parsed_args.auth_type) and (parsed_args.password)):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_e0023b6f","line":33,"in_reply_to":"fa69d971_f330e2a0","updated":"2015-12-30 04:26:17.000000000","message":"Ok.","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28c0bfc065f907edaa7fb70362f73c61a151863a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    validators.validate_int_range(parsed_args, \u0027remote_as\u0027, 1, 0xffff)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    if ((parsed_args.auth_type) and (not parsed_args.password)):"},{"line_number":34,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide password, if auth-type \u0027"},{"line_number":35,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":36,"context_line":"    if ((not parsed_args.auth_type) and (parsed_args.password)):"},{"line_number":37,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide auth-type, if password \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_5320ce49","line":34,"updated":"2015-12-29 17:26:24.000000000","message":"nit: A comma before if is unnecessary.","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb9a1131f59024385b374fc25990c9260cc1e154","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    validators.validate_int_range(parsed_args, \u0027remote_as\u0027, 1, 0xffff)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    if ((parsed_args.auth_type) and (not parsed_args.password)):"},{"line_number":34,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide password, if auth-type \u0027"},{"line_number":35,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":36,"context_line":"    if ((not parsed_args.auth_type) and (parsed_args.password)):"},{"line_number":37,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide auth-type, if password \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_20305356","line":34,"in_reply_to":"fa69d971_5320ce49","updated":"2015-12-30 04:26:17.000000000","message":"Ok.","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28c0bfc065f907edaa7fb70362f73c61a151863a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    if ((parsed_args.auth_type) and (not parsed_args.password)):"},{"line_number":34,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide password, if auth-type \u0027"},{"line_number":35,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":36,"context_line":"    if ((not parsed_args.auth_type) and (parsed_args.password)):"},{"line_number":37,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide auth-type, if password \u0027"},{"line_number":38,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_131a5618","line":36,"updated":"2015-12-29 17:26:24.000000000","message":"ditto","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb9a1131f59024385b374fc25990c9260cc1e154","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    if ((parsed_args.auth_type) and (not parsed_args.password)):"},{"line_number":34,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide password, if auth-type \u0027"},{"line_number":35,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":36,"context_line":"    if ((not parsed_args.auth_type) and (parsed_args.password)):"},{"line_number":37,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide auth-type, if password \u0027"},{"line_number":38,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_c034d74b","line":36,"in_reply_to":"fa69d971_131a5618","updated":"2015-12-30 04:26:17.000000000","message":"Ok.","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28c0bfc065f907edaa7fb70362f73c61a151863a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide password, if auth-type \u0027"},{"line_number":35,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":36,"context_line":"    if ((not parsed_args.auth_type) and (parsed_args.password)):"},{"line_number":37,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide auth-type, if password \u0027"},{"line_number":38,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_33175aef","line":37,"updated":"2015-12-29 17:26:24.000000000","message":"ditto","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb9a1131f59024385b374fc25990c9260cc1e154","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide password, if auth-type \u0027"},{"line_number":35,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":36,"context_line":"    if ((not parsed_args.auth_type) and (parsed_args.password)):"},{"line_number":37,"context_line":"        raise exceptions.CommandError(_(\u0027Must provide auth-type, if password \u0027"},{"line_number":38,"context_line":"                                        \u0027is specified.\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_e039db42","line":37,"in_reply_to":"fa69d971_33175aef","updated":"2015-12-30 04:26:17.000000000","message":"Ok.","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28c0bfc065f907edaa7fb70362f73c61a151863a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":62,"context_line":"        parser.add_argument("},{"line_number":63,"context_line":"            \u0027name\u0027,"},{"line_number":64,"context_line":"            metavar\u003d\u0027PEER_NAME\u0027,"},{"line_number":65,"context_line":"            help\u003d_(\u0027Name of the BGP peer to create.\u0027))"},{"line_number":66,"context_line":"        parser.add_argument("},{"line_number":67,"context_line":"            \u0027--peer-ip\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_53e76e12","line":64,"updated":"2015-12-29 17:26:24.000000000","message":"Why not NAME as most resources do?","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb9a1131f59024385b374fc25990c9260cc1e154","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":62,"context_line":"        parser.add_argument("},{"line_number":63,"context_line":"            \u0027name\u0027,"},{"line_number":64,"context_line":"            metavar\u003d\u0027PEER_NAME\u0027,"},{"line_number":65,"context_line":"            help\u003d_(\u0027Name of the BGP peer to create.\u0027))"},{"line_number":66,"context_line":"        parser.add_argument("},{"line_number":67,"context_line":"            \u0027--peer-ip\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_803fbf24","line":64,"in_reply_to":"fa69d971_53e76e12","updated":"2015-12-30 04:26:17.000000000","message":"Make sense. Will make it uniform.","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28c0bfc065f907edaa7fb70362f73c61a151863a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        neutronv20.update_dict(parsed_args, body,"},{"line_number":90,"context_line":"                               [\u0027name\u0027, \u0027peer_ip\u0027, \u0027remote_as\u0027, \u0027tenant_id\u0027])"},{"line_number":91,"context_line":"        if not parsed_args.auth_type:"},{"line_number":92,"context_line":"            body[\u0027auth_type\u0027] \u003d \u0027none\u0027"},{"line_number":93,"context_line":"        else:"},{"line_number":94,"context_line":"            body[\u0027auth_type\u0027] \u003d parsed_args.auth_type"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_93aac684","line":92,"updated":"2015-12-29 17:26:24.000000000","message":"Do you use a string \u0027none\u0027 instead of JSON null (None in Python)?","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb9a1131f59024385b374fc25990c9260cc1e154","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        neutronv20.update_dict(parsed_args, body,"},{"line_number":90,"context_line":"                               [\u0027name\u0027, \u0027peer_ip\u0027, \u0027remote_as\u0027, \u0027tenant_id\u0027])"},{"line_number":91,"context_line":"        if not parsed_args.auth_type:"},{"line_number":92,"context_line":"            body[\u0027auth_type\u0027] \u003d \u0027none\u0027"},{"line_number":93,"context_line":"        else:"},{"line_number":94,"context_line":"            body[\u0027auth_type\u0027] \u003d parsed_args.auth_type"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_4049c7cf","line":92,"in_reply_to":"fa69d971_93aac684","updated":"2015-12-30 04:26:17.000000000","message":"Yes, We are currently using \u0027none\u0027 but we are open to suggestion.","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28c0bfc065f907edaa7fb70362f73c61a151863a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            body[\u0027auth_type\u0027] \u003d parsed_args.auth_type"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        if not parsed_args.password:"},{"line_number":97,"context_line":"            body[\u0027password\u0027] \u003d \u0027\u0027"},{"line_number":98,"context_line":"        else:"},{"line_number":99,"context_line":"            body[\u0027password\u0027] \u003d parsed_args.password"},{"line_number":100,"context_line":"        return {self.resource: body}"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_b3afca93","line":97,"updated":"2015-12-29 17:26:24.000000000","message":"Same question for L.92.","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb9a1131f59024385b374fc25990c9260cc1e154","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            body[\u0027auth_type\u0027] \u003d parsed_args.auth_type"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        if not parsed_args.password:"},{"line_number":97,"context_line":"            body[\u0027password\u0027] \u003d \u0027\u0027"},{"line_number":98,"context_line":"        else:"},{"line_number":99,"context_line":"            body[\u0027password\u0027] \u003d parsed_args.password"},{"line_number":100,"context_line":"        return {self.resource: body}"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_0012efb4","line":97,"in_reply_to":"fa69d971_b3afca93","updated":"2015-12-30 04:26:17.000000000","message":"ditto","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28c0bfc065f907edaa7fb70362f73c61a151863a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    def args2body(self, parsed_args):"},{"line_number":118,"context_line":"        body \u003d {}"},{"line_number":119,"context_line":"        neutronv20.update_dict(parsed_args, body,"},{"line_number":120,"context_line":"                               [\u0027name\u0027, \u0027password\u0027, \u0027tenant_id\u0027])"},{"line_number":121,"context_line":"        return {self.resource: body}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_53ce8e84","line":120,"updated":"2015-12-29 17:26:24.000000000","message":"tenant_id looks unnecessary.","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb9a1131f59024385b374fc25990c9260cc1e154","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    def args2body(self, parsed_args):"},{"line_number":118,"context_line":"        body \u003d {}"},{"line_number":119,"context_line":"        neutronv20.update_dict(parsed_args, body,"},{"line_number":120,"context_line":"                               [\u0027name\u0027, \u0027password\u0027, \u0027tenant_id\u0027])"},{"line_number":121,"context_line":"        return {self.resource: body}"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_2017f3a4","line":120,"in_reply_to":"fa69d971_53ce8e84","updated":"2015-12-30 04:26:17.000000000","message":"Good catch. will remove.","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"92aa09a37490ac8996c7c2c63a123671aa46e518","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Huawei Technologies India Pvt. Ltd."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_bc7c3621","line":1,"updated":"2016-01-08 07:47:01.000000000","message":"Let\u0027s roll to 2016 ;)","commit_id":"bbc4b9dea8bdc774bf588187b35d314e777296e8"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"8dd27ff1d478c4df51d648408447c93d8669c9cb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"class ShowPeer(neutronv20.ShowCommand):"},{"line_number":53,"context_line":"    \"\"\"Show information of a given BGP peer.\"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    resource \u003d \u0027bgp_peer\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class CreatePeer(neutronv20.CreateCommand):"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_ec3affe6","line":55,"range":{"start_line":55,"start_character":13,"end_line":55,"end_character":14},"updated":"2016-01-08 07:08:10.000000000","message":"In my test, when i show bgp peer, i can not show the password.\n(neutron) bgp-peer-show 35dcc2ae-9d2d-4a79-aa24-0f988d9d7a6f\n+-----------+--------------------------------------+\n| Field     | Value                                |\n+-----------+--------------------------------------+\n| auth_type | md5                                  |\n| id        | 35dcc2ae-9d2d-4a79-aa24-0f988d9d7a6f |\n| peer_ip   | 1.1.1.2                              |\n| remote_as | 200                                  |\n| tenant_id | f10cbbfd66c54043b26c602a6df42e55     |\n+-----------+--------------------------------------+","commit_id":"bbc4b9dea8bdc774bf588187b35d314e777296e8"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"c22f24e73b1ef3db5ae5ee85b2bcc3fa9a1b0dfe","unresolved":false,"context_lines":[{"line_number":52,"context_line":"class ShowPeer(neutronv20.ShowCommand):"},{"line_number":53,"context_line":"    \"\"\"Show information of a given BGP peer.\"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    resource \u003d \u0027bgp_peer\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class CreatePeer(neutronv20.CreateCommand):"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_3db10790","line":55,"range":{"start_line":55,"start_character":13,"end_line":55,"end_character":14},"in_reply_to":"fa69d971_b2ca1d4e","updated":"2016-01-08 14:42:53.000000000","message":"It is considered bad security practice to show passwords like you are proposing.  Vikram is correct that it is intentional and it shouldn\u0027t be changed","commit_id":"bbc4b9dea8bdc774bf588187b35d314e777296e8"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"155d2f0fc8ebe0b6a907332b41b482d0d62236df","unresolved":false,"context_lines":[{"line_number":52,"context_line":"class ShowPeer(neutronv20.ShowCommand):"},{"line_number":53,"context_line":"    \"\"\"Show information of a given BGP peer.\"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    resource \u003d \u0027bgp_peer\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class CreatePeer(neutronv20.CreateCommand):"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_b2ca1d4e","line":55,"range":{"start_line":55,"start_character":13,"end_line":55,"end_character":14},"in_reply_to":"fa69d971_dc21eafd","updated":"2016-01-08 08:11:58.000000000","message":"why do it on purpose? only admin can configure bgp dynamic routing, why admin can not show the password, i think you can hide it for tenant, not admin.","commit_id":"bbc4b9dea8bdc774bf588187b35d314e777296e8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"92aa09a37490ac8996c7c2c63a123671aa46e518","unresolved":false,"context_lines":[{"line_number":52,"context_line":"class ShowPeer(neutronv20.ShowCommand):"},{"line_number":53,"context_line":"    \"\"\"Show information of a given BGP peer.\"\"\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    resource \u003d \u0027bgp_peer\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class CreatePeer(neutronv20.CreateCommand):"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_dc21eafd","line":55,"range":{"start_line":55,"start_character":13,"end_line":55,"end_character":14},"in_reply_to":"fa69d971_ec3affe6","updated":"2016-01-08 07:47:01.000000000","message":"It\u0027s intentional. IMO, let\u0027s not show the password.\n\nhttps://review.openstack.org/#/c/201621/47/neutron/extensions/bgp.py#L101\n\nBTW, it\u0027s not the problem with neutron-client patch ;)","commit_id":"bbc4b9dea8bdc774bf588187b35d314e777296e8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"720e08eb36790a44a4a21bbf2270ad87063a14db","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            body[\u0027auth_type\u0027] \u003d parsed_args.auth_type"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if not parsed_args.password:"},{"line_number":103,"context_line":"            body[\u0027password\u0027] \u003d \u0027\u0027"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            body[\u0027password\u0027] \u003d parsed_args.password"},{"line_number":106,"context_line":"        return {self.resource: body}"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_3d2f1aa3","line":103,"updated":"2016-02-03 07:33:58.000000000","message":"Do you really need to pass password in the body ? ( Just curious)\nAnd if yes, then I think you can add default\u003d´´ in Line number 89, and forget about this if-else loop","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            body[\u0027auth_type\u0027] \u003d parsed_args.auth_type"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if not parsed_args.password:"},{"line_number":103,"context_line":"            body[\u0027password\u0027] \u003d \u0027\u0027"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            body[\u0027password\u0027] \u003d parsed_args.password"},{"line_number":106,"context_line":"        return {self.resource: body}"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_61587b57","line":103,"in_reply_to":"5a5ae5dd_3d2f1aa3","updated":"2016-02-03 13:57:44.000000000","message":"Default value for the password will be added at the server side. Hence, we will remove this ugly code.","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            body[\u0027auth_type\u0027] \u003d parsed_args.auth_type"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        if not parsed_args.password:"},{"line_number":103,"context_line":"            body[\u0027password\u0027] \u003d \u0027\u0027"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            body[\u0027password\u0027] \u003d parsed_args.password"},{"line_number":106,"context_line":"        return {self.resource: body}"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_488284c9","line":103,"in_reply_to":"5a5ae5dd_61587b57","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"720e08eb36790a44a4a21bbf2270ad87063a14db","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            metavar\u003d\u0027AUTH_PASSWORD\u0027,"},{"line_number":121,"context_line":"            help\u003d_(\u0027Authentication password.\u0027))"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def args2body(self, parsed_args):"},{"line_number":124,"context_line":"        body \u003d {}"},{"line_number":125,"context_line":"        neutronv20.update_dict(parsed_args, body, [\u0027name\u0027, \u0027password\u0027])"},{"line_number":126,"context_line":"        return {self.resource: body}"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_5d2c56ab","line":123,"updated":"2016-02-03 07:33:58.000000000","message":"args2body cor Create and Update can be made common","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            metavar\u003d\u0027AUTH_PASSWORD\u0027,"},{"line_number":121,"context_line":"            help\u003d_(\u0027Authentication password.\u0027))"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def args2body(self, parsed_args):"},{"line_number":124,"context_line":"        body \u003d {}"},{"line_number":125,"context_line":"        neutronv20.update_dict(parsed_args, body, [\u0027name\u0027, \u0027password\u0027])"},{"line_number":126,"context_line":"        return {self.resource: body}"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_09ad2de9","line":123,"in_reply_to":"5a5ae5dd_5d2c56ab","updated":"2016-02-03 13:57:44.000000000","message":"IMO, let\u0027s keep them separate for now since not many attributes are there. We can re-structure later when more attribute comes in.","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"73b825977e0825ceafb3cd4c98950943417d2d3c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutronclient.common import exceptions"},{"line_number":18,"context_line":"from neutronclient.common import validators"},{"line_number":19,"context_line":"from neutronclient.i18n import _"},{"line_number":20,"context_line":"from neutronclient.neutron import v2_0 as neutronv20"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_d9505b0d","line":19,"updated":"2016-02-16 00:37:14.000000000","message":"Please use _i18n","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"45051d6af016f5e18bcca14623cbf5a28bcf379c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutronclient.common import exceptions"},{"line_number":18,"context_line":"from neutronclient.common import validators"},{"line_number":19,"context_line":"from neutronclient.i18n import _"},{"line_number":20,"context_line":"from neutronclient.neutron import v2_0 as neutronv20"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_31323311","line":19,"in_reply_to":"dae33548_a216fcee","updated":"2016-02-16 09:47:45.000000000","message":"Done","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bf29b6d521e866423c79edce26b3d271fdd63439","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutronclient.common import exceptions"},{"line_number":18,"context_line":"from neutronclient.common import validators"},{"line_number":19,"context_line":"from neutronclient.i18n import _"},{"line_number":20,"context_line":"from neutronclient.neutron import v2_0 as neutronv20"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_a216fcee","line":19,"in_reply_to":"dae33548_d9505b0d","updated":"2016-02-16 03:23:03.000000000","message":"Will do ;)","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e5ea825da99492329da7ac968cec2617abfb37b4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":64,"context_line":"        parser.add_argument("},{"line_number":65,"context_line":"            \u0027name\u0027,"},{"line_number":66,"context_line":"            metavar\u003d\u0027NAME\u0027,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Name of the BGP peer to create.\u0027))"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--peer-ip\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_ad470d4a","line":66,"updated":"2016-02-16 03:53:53.000000000","message":"Same , do we need Name to be a positional parameter?","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"45051d6af016f5e18bcca14623cbf5a28bcf379c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":64,"context_line":"        parser.add_argument("},{"line_number":65,"context_line":"            \u0027name\u0027,"},{"line_number":66,"context_line":"            metavar\u003d\u0027NAME\u0027,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Name of the BGP peer to create.\u0027))"},{"line_number":68,"context_line":"        parser.add_argument("},{"line_number":69,"context_line":"            \u0027--peer-ip\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_0c03920e","line":66,"in_reply_to":"dae33548_ad470d4a","updated":"2016-02-16 09:47:45.000000000","message":"Then how we are going to take name field in the cli?","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"73b825977e0825ceafb3cd4c98950943417d2d3c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        parser.add_argument("},{"line_number":82,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":83,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":84,"context_line":"            choices\u003d[\u0027none\u0027, \u0027md5\u0027],"},{"line_number":85,"context_line":"            help\u003d_(\u0027Authentication algorithm in lowercase. Supported \u0027"},{"line_number":86,"context_line":"                   \u0027algorithms: [\\\u0027md5\\\u0027]\u0027))"},{"line_number":87,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_793b0fd2","line":84,"updated":"2016-02-16 00:37:14.000000000","message":"better add utils.to_lower_case() function, to allow user to enter info in any casing","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bf29b6d521e866423c79edce26b3d271fdd63439","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        parser.add_argument("},{"line_number":82,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":83,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":84,"context_line":"            choices\u003d[\u0027none\u0027, \u0027md5\u0027],"},{"line_number":85,"context_line":"            help\u003d_(\u0027Authentication algorithm in lowercase. Supported \u0027"},{"line_number":86,"context_line":"                   \u0027algorithms: [\\\u0027md5\\\u0027]\u0027))"},{"line_number":87,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_e2d64426","line":84,"in_reply_to":"dae33548_793b0fd2","updated":"2016-02-16 03:23:03.000000000","message":"Good suggestion!","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"45051d6af016f5e18bcca14623cbf5a28bcf379c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        parser.add_argument("},{"line_number":82,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":83,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":84,"context_line":"            choices\u003d[\u0027none\u0027, \u0027md5\u0027],"},{"line_number":85,"context_line":"            help\u003d_(\u0027Authentication algorithm in lowercase. Supported \u0027"},{"line_number":86,"context_line":"                   \u0027algorithms: [\\\u0027md5\\\u0027]\u0027))"},{"line_number":87,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_0c2f12f7","line":84,"in_reply_to":"dae33548_e2d64426","updated":"2016-02-16 09:47:45.000000000","message":"Done","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bf29b6d521e866423c79edce26b3d271fdd63439","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":83,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":84,"context_line":"            choices\u003d[\u0027none\u0027, \u0027md5\u0027],"},{"line_number":85,"context_line":"            help\u003d_(\u0027Authentication algorithm in lowercase. Supported \u0027"},{"line_number":86,"context_line":"                   \u0027algorithms: [\\\u0027md5\\\u0027]\u0027))"},{"line_number":87,"context_line":"        parser.add_argument("},{"line_number":88,"context_line":"            \u0027--password\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_62e35406","line":85,"updated":"2016-02-16 03:23:03.000000000","message":"Let\u0027s change the help accordingly then.","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e5ea825da99492329da7ac968cec2617abfb37b4","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":83,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":84,"context_line":"            choices\u003d[\u0027none\u0027, \u0027md5\u0027],"},{"line_number":85,"context_line":"            help\u003d_(\u0027Authentication algorithm in lowercase. Supported \u0027"},{"line_number":86,"context_line":"                   \u0027algorithms: [\\\u0027md5\\\u0027]\u0027))"},{"line_number":87,"context_line":"        parser.add_argument("},{"line_number":88,"context_line":"            \u0027--password\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_6d0fc52e","line":85,"in_reply_to":"dae33548_62e35406","updated":"2016-02-16 03:53:53.000000000","message":"Oops, didnt see the lowercase here :)\nYeah, thats right.","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"45051d6af016f5e18bcca14623cbf5a28bcf379c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":83,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":84,"context_line":"            choices\u003d[\u0027none\u0027, \u0027md5\u0027],"},{"line_number":85,"context_line":"            help\u003d_(\u0027Authentication algorithm in lowercase. Supported \u0027"},{"line_number":86,"context_line":"                   \u0027algorithms: [\\\u0027md5\\\u0027]\u0027))"},{"line_number":87,"context_line":"        parser.add_argument("},{"line_number":88,"context_line":"            \u0027--password\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_0c16f2a6","line":85,"in_reply_to":"dae33548_6d0fc52e","updated":"2016-02-16 09:47:45.000000000","message":"Done","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e5ea825da99492329da7ac968cec2617abfb37b4","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":111,"context_line":"        parser.add_argument("},{"line_number":112,"context_line":"            \u0027--name\u0027,"},{"line_number":113,"context_line":"            help\u003d_(\u0027Name of the BGP peer to update.\u0027))"},{"line_number":114,"context_line":"        parser.add_argument("},{"line_number":115,"context_line":"            \u0027--password\u0027,"},{"line_number":116,"context_line":"            metavar\u003d\u0027AUTH_PASSWORD\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_2da93de0","line":113,"updated":"2016-02-16 03:53:53.000000000","message":"I think this should be reworded as \"Updated name of the BGP peer\"\n\nThe current statement seems to portray that the --name should have the NAME of the BGP PEER whose name has to be updated.","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"be9278e43e22c7ce5c630ac34407007c62c2b659","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":111,"context_line":"        parser.add_argument("},{"line_number":112,"context_line":"            \u0027--name\u0027,"},{"line_number":113,"context_line":"            help\u003d_(\u0027Name of the BGP peer to update.\u0027))"},{"line_number":114,"context_line":"        parser.add_argument("},{"line_number":115,"context_line":"            \u0027--password\u0027,"},{"line_number":116,"context_line":"            metavar\u003d\u0027AUTH_PASSWORD\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_f6aba11b","line":113,"in_reply_to":"dae33548_2da93de0","updated":"2016-02-16 09:12:34.000000000","message":"Ok. Will change","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"45051d6af016f5e18bcca14623cbf5a28bcf379c","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":111,"context_line":"        parser.add_argument("},{"line_number":112,"context_line":"            \u0027--name\u0027,"},{"line_number":113,"context_line":"            help\u003d_(\u0027Name of the BGP peer to update.\u0027))"},{"line_number":114,"context_line":"        parser.add_argument("},{"line_number":115,"context_line":"            \u0027--password\u0027,"},{"line_number":116,"context_line":"            metavar\u003d\u0027AUTH_PASSWORD\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_ecabce1b","line":113,"in_reply_to":"dae33548_f6aba11b","updated":"2016-02-16 09:47:45.000000000","message":"Done","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e5ea825da99492329da7ac968cec2617abfb37b4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        parser.add_argument("},{"line_number":115,"context_line":"            \u0027--password\u0027,"},{"line_number":116,"context_line":"            metavar\u003d\u0027AUTH_PASSWORD\u0027,"},{"line_number":117,"context_line":"            help\u003d_(\u0027Authentication password.\u0027))"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def args2body(self, parsed_args):"},{"line_number":120,"context_line":"        body \u003d {}"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_6d64e5e4","line":117,"updated":"2016-02-16 03:53:53.000000000","message":"\"Updated Authentication password.\" would be a better message","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"be9278e43e22c7ce5c630ac34407007c62c2b659","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        parser.add_argument("},{"line_number":115,"context_line":"            \u0027--password\u0027,"},{"line_number":116,"context_line":"            metavar\u003d\u0027AUTH_PASSWORD\u0027,"},{"line_number":117,"context_line":"            help\u003d_(\u0027Authentication password.\u0027))"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def args2body(self, parsed_args):"},{"line_number":120,"context_line":"        body \u003d {}"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_f6828193","line":117,"in_reply_to":"dae33548_6d64e5e4","updated":"2016-02-16 09:12:34.000000000","message":"Ok. Will change","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"45051d6af016f5e18bcca14623cbf5a28bcf379c","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        parser.add_argument("},{"line_number":115,"context_line":"            \u0027--password\u0027,"},{"line_number":116,"context_line":"            metavar\u003d\u0027AUTH_PASSWORD\u0027,"},{"line_number":117,"context_line":"            help\u003d_(\u0027Authentication password.\u0027))"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def args2body(self, parsed_args):"},{"line_number":120,"context_line":"        body \u003d {}"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_8cacc236","line":117,"in_reply_to":"dae33548_f6828193","updated":"2016-02-16 09:47:45.000000000","message":"Done","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1b63f7dd8349d018f3636a18333ab6f8fc3c7563","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        parser.add_argument("},{"line_number":83,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":84,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":85,"context_line":"            choices\u003d[\u0027none\u0027, \u0027md5\u0027],"},{"line_number":86,"context_line":"            type\u003dutils.convert_to_lowercase,"},{"line_number":87,"context_line":"            help\u003d_(\u0027Authentication algorithm. Supported algorithms: \u0027"},{"line_number":88,"context_line":"                   \u0027[\\\u0027md5\\\u0027]\u0027))"}],"source_content_type":"text/x-python","patch_set":21,"id":"bae84128_5d016805","line":85,"range":{"start_line":85,"start_character":21,"end_line":85,"end_character":27},"updated":"2016-02-23 15:20:41.000000000","message":"what does \u0027none\u0027 mean? If \u0027none\u0027 is passed, what happens?","commit_id":"2ffa2e4f2cceebcc1a89c42439dde24b3251dbb2"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c35b103e717acc49caaa9c39bfee7ec8cd2caefe","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        parser.add_argument("},{"line_number":83,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":84,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":85,"context_line":"            choices\u003d[\u0027none\u0027, \u0027md5\u0027],"},{"line_number":86,"context_line":"            type\u003dutils.convert_to_lowercase,"},{"line_number":87,"context_line":"            help\u003d_(\u0027Authentication algorithm. Supported algorithms: \u0027"},{"line_number":88,"context_line":"                   \u0027[\\\u0027md5\\\u0027]\u0027))"}],"source_content_type":"text/x-python","patch_set":21,"id":"bae84128_9f056115","line":85,"range":{"start_line":85,"start_character":21,"end_line":85,"end_character":27},"in_reply_to":"bae84128_5d016805","updated":"2016-02-24 15:09:04.000000000","message":"none \u003d\u003d\u003e no-password. For none auth-type, peer won\u0027t be authenticated. This is in sync with the server implementation.\nhttps://github.com/openstack/neutron/blob/master/neutron/extensions/bgp.py#L28","commit_id":"2ffa2e4f2cceebcc1a89c42439dde24b3251dbb2"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"64b98aa7ca8548ddf22a01203715ea9fe860c9f7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        parser.add_argument("},{"line_number":83,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":84,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":85,"context_line":"            choices\u003d[\u0027none\u0027, \u0027md5\u0027],"},{"line_number":86,"context_line":"            type\u003dutils.convert_to_lowercase,"},{"line_number":87,"context_line":"            help\u003d_(\u0027Authentication algorithm. Supported algorithms: \u0027"},{"line_number":88,"context_line":"                   \u0027[\\\u0027md5\\\u0027]\u0027))"}],"source_content_type":"text/x-python","patch_set":21,"id":"bae84128_a0762f04","line":85,"range":{"start_line":85,"start_character":21,"end_line":85,"end_character":27},"in_reply_to":"bae84128_901f0eb6","updated":"2016-02-24 20:42:02.000000000","message":"We should probably mention \u0027none\u0027 in the help message. auth_type is a required attribute and should be treated as such, add \u0027required\u003dTrue\u0027 here as well.","commit_id":"2ffa2e4f2cceebcc1a89c42439dde24b3251dbb2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7795218d9b23fc2ed8d425cbba5cea32d2a3cef2","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        parser.add_argument("},{"line_number":83,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":84,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":85,"context_line":"            choices\u003d[\u0027none\u0027, \u0027md5\u0027],"},{"line_number":86,"context_line":"            type\u003dutils.convert_to_lowercase,"},{"line_number":87,"context_line":"            help\u003d_(\u0027Authentication algorithm. Supported algorithms: \u0027"},{"line_number":88,"context_line":"                   \u0027[\\\u0027md5\\\u0027]\u0027))"}],"source_content_type":"text/x-python","patch_set":21,"id":"bae84128_901f0eb6","line":85,"range":{"start_line":85,"start_character":21,"end_line":85,"end_character":27},"in_reply_to":"bae84128_9f056115","updated":"2016-02-24 15:39:00.000000000","message":"Don\u0027t we need to mention \u0027none\u0027 in the help message?\n\nWhen --auth-type is not specified, parsed_args.auth_type will be None and as a result \u0027none\u0027 will be sent to the neutron-server, but I wonder it is worth mentioning \u0027none\u0027.\n\nThought?","commit_id":"2ffa2e4f2cceebcc1a89c42439dde24b3251dbb2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1b63f7dd8349d018f3636a18333ab6f8fc3c7563","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":85,"context_line":"            choices\u003d[\u0027none\u0027, \u0027md5\u0027],"},{"line_number":86,"context_line":"            type\u003dutils.convert_to_lowercase,"},{"line_number":87,"context_line":"            help\u003d_(\u0027Authentication algorithm. Supported algorithms: \u0027"},{"line_number":88,"context_line":"                   \u0027[\\\u0027md5\\\u0027]\u0027))"},{"line_number":89,"context_line":"        parser.add_argument("},{"line_number":90,"context_line":"            \u0027--password\u0027,"},{"line_number":91,"context_line":"            metavar\u003d\u0027AUTH_PASSWORD\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"bae84128_1d2400c3","line":88,"range":{"start_line":87,"start_character":46,"end_line":88,"end_character":30},"updated":"2016-02-23 15:20:41.000000000","message":"I think \u0027Supported algorithms: md5\u0027 is enough.","commit_id":"2ffa2e4f2cceebcc1a89c42439dde24b3251dbb2"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c35b103e717acc49caaa9c39bfee7ec8cd2caefe","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":85,"context_line":"            choices\u003d[\u0027none\u0027, \u0027md5\u0027],"},{"line_number":86,"context_line":"            type\u003dutils.convert_to_lowercase,"},{"line_number":87,"context_line":"            help\u003d_(\u0027Authentication algorithm. Supported algorithms: \u0027"},{"line_number":88,"context_line":"                   \u0027[\\\u0027md5\\\u0027]\u0027))"},{"line_number":89,"context_line":"        parser.add_argument("},{"line_number":90,"context_line":"            \u0027--password\u0027,"},{"line_number":91,"context_line":"            metavar\u003d\u0027AUTH_PASSWORD\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"bae84128_6a17fd44","line":88,"range":{"start_line":87,"start_character":46,"end_line":88,"end_character":30},"in_reply_to":"bae84128_1d2400c3","updated":"2016-02-24 15:09:04.000000000","message":"ok.","commit_id":"2ffa2e4f2cceebcc1a89c42439dde24b3251dbb2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"31df4e7da046eb9962fb807229c15a53426cd11b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        parser.add_argument("},{"line_number":83,"context_line":"            \u0027--auth-type\u0027,"},{"line_number":84,"context_line":"            metavar\u003d\u0027PEER_AUTH_TYPE\u0027,"},{"line_number":85,"context_line":"            choices\u003d[\u0027none\u0027, \u0027md5\u0027],"},{"line_number":86,"context_line":"            type\u003dutils.convert_to_lowercase,"},{"line_number":87,"context_line":"            help\u003d_(\u0027Authentication algorithm. Supported algorithms: \u0027"},{"line_number":88,"context_line":"                   \u0027none(default), md5\u0027))"}],"source_content_type":"text/x-python","patch_set":23,"id":"bae84128_7ce15dfe","line":85,"updated":"2016-02-25 06:10:45.000000000","message":"If you add\n\n  default\u003d\u0027none\u0027\n\nhere, L.97-100 can be merged into update_dict().","commit_id":"45fd31c550e4e423c4f6a7e2ffee3cae6afdf6c5"}],"neutronclient/neutron/v2_0/bgp/speaker.py":[{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"616891e07be66638429c0ae3a0e3a84680ed2ee8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               \u0027advertised by the BGP speaker.\u0027))"},{"line_number":39,"context_line":"    utils.add_boolean_argument("},{"line_number":40,"context_line":"        parser, \u0027--advertise-tenant-networks\u0027,"},{"line_number":41,"context_line":"        dest\u003d\u0027advertise_tenant_networks\u0027,"},{"line_number":42,"context_line":"        help\u003d_(\u0027Whether to enable or disable the advertisement \u0027"},{"line_number":43,"context_line":"               \u0027of tenant network routes by the BGP speaker. \u0027"},{"line_number":44,"context_line":"               \u0027By default tenant network routes will be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_6ab820c8","line":41,"updated":"2015-07-31 13:24:36.000000000","message":"Maybe is not the place to discuss this here... but shouldn\u0027t the tenant networks not be advertised by default? I assume this functionality is mostly for IPv6, but most of the current OS deployments are using IPv4","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"616891e07be66638429c0ae3a0e3a84680ed2ee8","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            help\u003d_(\u0027Local autonomous system number.(integer in [1, 65535])\u0027))"},{"line_number":80,"context_line":"        add_updatable_arguments(parser)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def args2body(self, parsed_args):"},{"line_number":83,"context_line":"        body \u003d {"},{"line_number":84,"context_line":"            self.resource: {\u0027local_as\u0027: parsed_args.local_as},"},{"line_number":85,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_6a62603f","line":82,"updated":"2015-07-31 13:24:36.000000000","message":"no validation here?","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4bb02eb23adf3ff725b652b189b018c43e1115f9","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            help\u003d_(\u0027Local autonomous system number.(integer in [1, 65535])\u0027))"},{"line_number":80,"context_line":"        add_updatable_arguments(parser)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def args2body(self, parsed_args):"},{"line_number":83,"context_line":"        body \u003d {"},{"line_number":84,"context_line":"            self.resource: {\u0027local_as\u0027: parsed_args.local_as},"},{"line_number":85,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_5e5cdf7c","line":82,"in_reply_to":"3a50d1a3_6a62603f","updated":"2015-08-01 05:02:33.000000000","message":"Is it really required.. anyways we have provided the range info in the help \n\nparser.add_argument(\t\n            \u0027local_as\u0027,\n            metavar\u003d\u0027LOCAL_AS\u0027,\n            help\u003d_(\u0027Local autonomous system number.(integer in [1, 65535]\u0027))\n\nMoreover, neutron-server will return error for this but we can do this if really required. Actually, I added and then removed :-)","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"80eaa90c127af1aba0fa8f96781c1324f32c01d4","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \"\"\"List BGP speakers.\"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":60,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027local_as\u0027]"},{"line_number":61,"context_line":"    pagination_support \u003d True"},{"line_number":62,"context_line":"    sorting_support \u003d True"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_a036cb4e","line":60,"updated":"2015-08-12 18:38:50.000000000","message":"need ip_version here","commit_id":"68f8956020aff790b83161e18c9aa9120332de84"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"81277388946737b25c89571a32242458c0d4d709","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \"\"\"List BGP speakers.\"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":60,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027local_as\u0027]"},{"line_number":61,"context_line":"    pagination_support \u003d True"},{"line_number":62,"context_line":"    sorting_support \u003d True"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_36842a5c","line":60,"in_reply_to":"1a4dcd0f_a036cb4e","updated":"2015-08-13 07:18:24.000000000","message":"Done.","commit_id":"68f8956020aff790b83161e18c9aa9120332de84"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b7653800e86051a910e1399352dccffbc8c9383b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    \"\"\"List BGP speakers.\"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":62,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027local_as\u0027, \u0027ip_version\u0027]"},{"line_number":63,"context_line":"    pagination_support \u003d True"},{"line_number":64,"context_line":"    sorting_support \u003d True"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_179b3267","line":62,"updated":"2015-08-21 07:26:32.000000000","message":"Need to show Speaker state. Please check how we can achieve this.","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bdce2a719caf7a1320577c2df8beee0766643b7d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    \"\"\"List BGP speakers.\"\"\""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":62,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027local_as\u0027, \u0027ip_version\u0027]"},{"line_number":63,"context_line":"    pagination_support \u003d True"},{"line_number":64,"context_line":"    sorting_support \u003d True"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_21373700","line":62,"in_reply_to":"fa1b9901_179b3267","updated":"2015-09-05 11:28:30.000000000","message":"Hold on. Server need to implement this.","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d710c23ead63d49ab72c28d4c91b63e9611c1cb7","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        _peer_id \u003d bgp_peer.get_bgp_peer_id(neutron_client,"},{"line_number":147,"context_line":"                                            parsed_args.bgp_peer_id)"},{"line_number":148,"context_line":"        neutron_client.add_peer_to_bgp_speaker("},{"line_number":149,"context_line":"            parsed_args.bgp_speaker_id, {\u0027peer_id\u0027: _peer_id})"},{"line_number":150,"context_line":"        print(_(\u0027Added BGP peer %(peer)s to BGP speaker %(speaker)s.\u0027) %"},{"line_number":151,"context_line":"              {\u0027peer\u0027: _peer_id, \u0027speaker\u0027: parsed_args.bgp_speaker_id},"},{"line_number":152,"context_line":"              file\u003dself.app.stdout)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_9c01d708","line":149,"updated":"2015-08-31 06:39:09.000000000","message":"Let\u0027s use \u0027bgp_peer_id\u0027 all across and maintain uniformity with the server.","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bdce2a719caf7a1320577c2df8beee0766643b7d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        _peer_id \u003d bgp_peer.get_bgp_peer_id(neutron_client,"},{"line_number":147,"context_line":"                                            parsed_args.bgp_peer_id)"},{"line_number":148,"context_line":"        neutron_client.add_peer_to_bgp_speaker("},{"line_number":149,"context_line":"            parsed_args.bgp_speaker_id, {\u0027peer_id\u0027: _peer_id})"},{"line_number":150,"context_line":"        print(_(\u0027Added BGP peer %(peer)s to BGP speaker %(speaker)s.\u0027) %"},{"line_number":151,"context_line":"              {\u0027peer\u0027: _peer_id, \u0027speaker\u0027: parsed_args.bgp_speaker_id},"},{"line_number":152,"context_line":"              file\u003dself.app.stdout)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_e1137f63","line":149,"in_reply_to":"da20952f_9c01d708","updated":"2015-09-05 11:28:30.000000000","message":"ok.","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"8d100546c9087e12d8b4de9f1eb297a374d4565e","unresolved":false,"context_lines":[{"line_number":235,"context_line":"class ListRoutesAdvertisedBySpeaker(neutronv20.ListCommand):"},{"line_number":236,"context_line":"    \"\"\"List routes advertised by a given BGP speaker.\"\"\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027destination\u0027, \u0027next_hop\u0027]"},{"line_number":239,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":240,"context_line":"    pagination_support \u003d True"},{"line_number":241,"context_line":"    sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_5df41986","line":238,"updated":"2015-09-09 10:31:51.000000000","message":"I am not sure if we need this \u0027id\u0027? @Ryan to confirm.","commit_id":"27ed694b56b06c307e434a9c7ddb89d8eaf53e32"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b2d2ba0088112804494a67255663feca4ea26fa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"def add_updatable_arguments(parser):"},{"line_number":35,"context_line":"    utils.add_boolean_argument("},{"line_number":36,"context_line":"        parser, \u0027--advertise-floating-ip-host-routes\u0027,"},{"line_number":37,"context_line":"        dest\u003d\u0027advertise_floating_ip_host_routes\u0027,"},{"line_number":38,"context_line":"        help\u003d_(\u0027Whether to enable or disable the advertisement \u0027"},{"line_number":39,"context_line":"               \u0027of floating-ip host routes by the BGP speaker. \u0027"},{"line_number":40,"context_line":"               \u0027By default floating ip host routes will be \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_a40f392d","line":37,"updated":"2015-09-28 08:53:05.000000000","message":"dest looks unnecessary.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a0482e40e0d242f95bab5fd9a3d69a05ae4c8458","unresolved":false,"context_lines":[{"line_number":34,"context_line":"def add_updatable_arguments(parser):"},{"line_number":35,"context_line":"    utils.add_boolean_argument("},{"line_number":36,"context_line":"        parser, \u0027--advertise-floating-ip-host-routes\u0027,"},{"line_number":37,"context_line":"        dest\u003d\u0027advertise_floating_ip_host_routes\u0027,"},{"line_number":38,"context_line":"        help\u003d_(\u0027Whether to enable or disable the advertisement \u0027"},{"line_number":39,"context_line":"               \u0027of floating-ip host routes by the BGP speaker. \u0027"},{"line_number":40,"context_line":"               \u0027By default floating ip host routes will be \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_249c8468","line":37,"in_reply_to":"9a1a9d01_a40f392d","updated":"2015-09-28 10:41:22.000000000","message":"Good catch.. Will remove..","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b2d2ba0088112804494a67255663feca4ea26fa","unresolved":false,"context_lines":[{"line_number":41,"context_line":"               \u0027advertised by the BGP speaker.\u0027))"},{"line_number":42,"context_line":"    utils.add_boolean_argument("},{"line_number":43,"context_line":"        parser, \u0027--advertise-tenant-networks\u0027,"},{"line_number":44,"context_line":"        dest\u003d\u0027advertise_tenant_networks\u0027,"},{"line_number":45,"context_line":"        help\u003d_(\u0027Whether to enable or disable the advertisement \u0027"},{"line_number":46,"context_line":"               \u0027of tenant network routes by the BGP speaker. \u0027"},{"line_number":47,"context_line":"               \u0027By default tenant network routes will be \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_64192179","line":44,"updated":"2015-09-28 08:53:05.000000000","message":"dest looks unnecessary.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a0482e40e0d242f95bab5fd9a3d69a05ae4c8458","unresolved":false,"context_lines":[{"line_number":41,"context_line":"               \u0027advertised by the BGP speaker.\u0027))"},{"line_number":42,"context_line":"    utils.add_boolean_argument("},{"line_number":43,"context_line":"        parser, \u0027--advertise-tenant-networks\u0027,"},{"line_number":44,"context_line":"        dest\u003d\u0027advertise_tenant_networks\u0027,"},{"line_number":45,"context_line":"        help\u003d_(\u0027Whether to enable or disable the advertisement \u0027"},{"line_number":46,"context_line":"               \u0027of tenant network routes by the BGP speaker. \u0027"},{"line_number":47,"context_line":"               \u0027By default tenant network routes will be \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_c4890828","line":44,"in_reply_to":"9a1a9d01_64192179","updated":"2015-09-28 10:41:22.000000000","message":"Good catch.. Will remove..","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b2d2ba0088112804494a67255663feca4ea26fa","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":79,"context_line":"        parser.add_argument("},{"line_number":80,"context_line":"            \u0027local_as\u0027,"},{"line_number":81,"context_line":"            metavar\u003d\u0027LOCAL_AS\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_84e8f5e3","line":78,"updated":"2015-09-28 08:53:05.000000000","message":"Question: no \"name\" attribute?\n\nCan we consider \"LOCAL_AS\" is unique? (I should review the server side :p)","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a0482e40e0d242f95bab5fd9a3d69a05ae4c8458","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":79,"context_line":"        parser.add_argument("},{"line_number":80,"context_line":"            \u0027local_as\u0027,"},{"line_number":81,"context_line":"            metavar\u003d\u0027LOCAL_AS\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_e493ec4d","line":78,"in_reply_to":"9a1a9d01_84e8f5e3","updated":"2015-09-28 10:41:22.000000000","message":"LOCAL_AS is a mandatory parameter. Please note it\u0027s \u0027local_as\u0027 and not \u0027--local_as\u0027 ;)","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"1179b5f5c17d8392260e0500133dd9b85f87c225","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":79,"context_line":"        parser.add_argument("},{"line_number":80,"context_line":"            \u0027local_as\u0027,"},{"line_number":81,"context_line":"            metavar\u003d\u0027LOCAL_AS\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_12eb62e0","line":78,"in_reply_to":"9a1a9d01_aa6fa929","updated":"2015-09-30 06:23:38.000000000","message":"Great! Let\u0027s add \u0027name\u0027 field.. I do agree with Akihiro, it\u0027s more user friendly.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"00920bded10b1a99057c9cbdddabf5895c1ea252","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":79,"context_line":"        parser.add_argument("},{"line_number":80,"context_line":"            \u0027local_as\u0027,"},{"line_number":81,"context_line":"            metavar\u003d\u0027LOCAL_AS\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_aa6fa929","line":78,"in_reply_to":"9a1a9d01_cc19ea89","updated":"2015-09-29 22:21:24.000000000","message":"I\u0027ve been going back and forth about whether local_as should be unique or not.  However, I do intend to provide a \"name\" field that could be used instead of \"id\".  We can also re-visit local_as as a third way of referencing a bgp_speaker.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56c410cc1d1f388e03e2ec9c0a45bdd9a507e1b5","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":79,"context_line":"        parser.add_argument("},{"line_number":80,"context_line":"            \u0027local_as\u0027,"},{"line_number":81,"context_line":"            metavar\u003d\u0027LOCAL_AS\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_cc19ea89","line":78,"in_reply_to":"9a1a9d01_e493ec4d","updated":"2015-09-29 16:37:30.000000000","message":"Thanks. I just wonder there is a field which can be used like \"name\" for other resources. If LOCAL_AS is unique, we can use it to refer existing BGP speakers. I think it is convenient for CLI users. See my comment at L.140 below.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"733e728066efcee0be24b62027a83f9bda6b27f3","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            metavar\u003d\u0027LOCAL_AS\u0027,"},{"line_number":82,"context_line":"            help\u003d_(\u0027Local autonomous system number.(integer in [1, 65535])\u0027))"},{"line_number":83,"context_line":"        parser.add_argument("},{"line_number":84,"context_line":"            \u0027--ip-version\u0027,"},{"line_number":85,"context_line":"            type\u003dint,"},{"line_number":86,"context_line":"            default\u003d4, choices\u003d[4, 6],"},{"line_number":87,"context_line":"            help\u003d_(\u0027BGP speaker IP version, default is 4.\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_76cc396a","line":84,"updated":"2015-12-20 10:38:46.000000000","message":"Plz remove \u0027ip_version\u0027 and add \u0027address_scope\u0027 as per the latest design.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"7a8cd8bdbddcac718bf493e3807786454a82bec4","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            metavar\u003d\u0027LOCAL_AS\u0027,"},{"line_number":82,"context_line":"            help\u003d_(\u0027Local autonomous system number.(integer in [1, 65535])\u0027))"},{"line_number":83,"context_line":"        parser.add_argument("},{"line_number":84,"context_line":"            \u0027--ip-version\u0027,"},{"line_number":85,"context_line":"            type\u003dint,"},{"line_number":86,"context_line":"            default\u003d4, choices\u003d[4, 6],"},{"line_number":87,"context_line":"            help\u003d_(\u0027BGP speaker IP version, default is 4.\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_19715ea8","line":84,"in_reply_to":"3a7e1126_76cc396a","updated":"2015-12-21 04:25:03.000000000","message":"Where is the latest design?\nThis does not make sense, why should specify address_scope when create BGP instance?","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b2d2ba0088112804494a67255663feca4ea26fa","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            default\u003d4, choices\u003d[4, 6],"},{"line_number":87,"context_line":"            help\u003d_(\u0027BGP speaker IP version, default is 4.\u0027))"},{"line_number":88,"context_line":"        parser.add_argument("},{"line_number":89,"context_line":"            \u0027--ip_version\u0027,"},{"line_number":90,"context_line":"            type\u003dint,"},{"line_number":91,"context_line":"            choices\u003d[4, 6],"},{"line_number":92,"context_line":"            help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_a43659e5","line":89,"updated":"2015-09-28 08:53:05.000000000","message":"We don\u0027t need to support underscore version for a new option.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a0482e40e0d242f95bab5fd9a3d69a05ae4c8458","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            default\u003d4, choices\u003d[4, 6],"},{"line_number":87,"context_line":"            help\u003d_(\u0027BGP speaker IP version, default is 4.\u0027))"},{"line_number":88,"context_line":"        parser.add_argument("},{"line_number":89,"context_line":"            \u0027--ip_version\u0027,"},{"line_number":90,"context_line":"            type\u003dint,"},{"line_number":91,"context_line":"            choices\u003d[4, 6],"},{"line_number":92,"context_line":"            help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_a4b414d1","line":89,"in_reply_to":"9a1a9d01_a43659e5","updated":"2015-09-28 10:41:22.000000000","message":"It\u0027s awesome. Will remove this then.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b2d2ba0088112804494a67255663feca4ea26fa","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        parser.add_argument("},{"line_number":138,"context_line":"            \u0027bgp_peer_id\u0027,"},{"line_number":139,"context_line":"            metavar\u003d\u0027BGP_PEER_ID\u0027,"},{"line_number":140,"context_line":"            help\u003d_(\u0027ID of the BGP peer to add.\u0027))"},{"line_number":141,"context_line":"        return parser"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def run(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_a4cad96c","line":140,"updated":"2015-09-28 08:53:05.000000000","message":"Hopefully we have more convenient way to specify BGP speaker or BGP peer like LOCAL_AS or Peer name/AS.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"1179b5f5c17d8392260e0500133dd9b85f87c225","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        parser.add_argument("},{"line_number":138,"context_line":"            \u0027bgp_peer_id\u0027,"},{"line_number":139,"context_line":"            metavar\u003d\u0027BGP_PEER_ID\u0027,"},{"line_number":140,"context_line":"            help\u003d_(\u0027ID of the BGP peer to add.\u0027))"},{"line_number":141,"context_line":"        return parser"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def run(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_b2c07651","line":140,"in_reply_to":"9a1a9d01_a4cad96c","updated":"2015-09-30 06:23:38.000000000","message":"Will add \u0027name\u0027.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b2d2ba0088112804494a67255663feca4ea26fa","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            metavar\u003d\u0027BGP_SPEAKER_ID\u0027,"},{"line_number":190,"context_line":"            help\u003d_(\u0027ID of the BGP speaker.\u0027))"},{"line_number":191,"context_line":"        parser.add_argument("},{"line_number":192,"context_line":"            \u0027network_id\u0027, metavar\u003d\u0027NETWORK_ID\u0027,"},{"line_number":193,"context_line":"            help\u003d_(\u0027ID or name of the network to add.\u0027))"},{"line_number":194,"context_line":"        return parser"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_44a09d9f","line":192,"updated":"2015-09-28 08:53:05.000000000","message":"NETWORK_ID -\u003e NETWORK\n\nbecause we can specify ID or NAME.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a0482e40e0d242f95bab5fd9a3d69a05ae4c8458","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            metavar\u003d\u0027BGP_SPEAKER_ID\u0027,"},{"line_number":190,"context_line":"            help\u003d_(\u0027ID of the BGP speaker.\u0027))"},{"line_number":191,"context_line":"        parser.add_argument("},{"line_number":192,"context_line":"            \u0027network_id\u0027, metavar\u003d\u0027NETWORK_ID\u0027,"},{"line_number":193,"context_line":"            help\u003d_(\u0027ID or name of the network to add.\u0027))"},{"line_number":194,"context_line":"        return parser"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_a4ebb4af","line":192,"in_reply_to":"9a1a9d01_44a09d9f","updated":"2015-09-28 10:41:22.000000000","message":"+1. Will change to network.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"0d53913c4a6a7f78d7866083860aec926656fbfd","unresolved":false,"context_lines":[{"line_number":235,"context_line":"class ListRoutesAdvertisedBySpeaker(neutronv20.ListCommand):"},{"line_number":236,"context_line":"    \"\"\"List routes advertised by a given BGP speaker.\"\"\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027destination\u0027, \u0027next_hop\u0027]"},{"line_number":239,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":240,"context_line":"    pagination_support \u003d True"},{"line_number":241,"context_line":"    sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_cf084c2b","line":238,"updated":"2015-09-22 11:03:39.000000000","message":"I am not sure if we need this \u0027id\u0027? @Ryan to confirm.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"58c62415df69a38912b69d92c3018a2bee601fcd","unresolved":false,"context_lines":[{"line_number":235,"context_line":"class ListRoutesAdvertisedBySpeaker(neutronv20.ListCommand):"},{"line_number":236,"context_line":"    \"\"\"List routes advertised by a given BGP speaker.\"\"\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027destination\u0027, \u0027next_hop\u0027]"},{"line_number":239,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":240,"context_line":"    pagination_support \u003d True"},{"line_number":241,"context_line":"    sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_26d95a57","line":238,"in_reply_to":"9a1a9d01_549be617","updated":"2015-10-01 05:06:39.000000000","message":"@Ryan: we can filter using -F option and display only destination and nexthop.\nCan\u0027t get rid of ID as this command is registered against BGP speaker.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"4190bce689bf4a42f31a3e9599c48394dca46e01","unresolved":false,"context_lines":[{"line_number":235,"context_line":"class ListRoutesAdvertisedBySpeaker(neutronv20.ListCommand):"},{"line_number":236,"context_line":"    \"\"\"List routes advertised by a given BGP speaker.\"\"\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027destination\u0027, \u0027next_hop\u0027]"},{"line_number":239,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":240,"context_line":"    pagination_support \u003d True"},{"line_number":241,"context_line":"    sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_549be617","line":238,"in_reply_to":"9a1a9d01_7522c8a4","updated":"2015-09-30 18:53:08.000000000","message":"Pardon my ignorance, are we required to have an ID column?  This gets tricky because the routes themselves have no ID, and making one up just seems silly.  Sticking in the BGP speaker ID seems a little misleading and confusing to the user too.  I\u0027d prefer we just show the user the destination and next-hop columns only if we can.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"f9f0dfb6f019354171d7582949f979651370ba91","unresolved":false,"context_lines":[{"line_number":235,"context_line":"class ListRoutesAdvertisedBySpeaker(neutronv20.ListCommand):"},{"line_number":236,"context_line":"    \"\"\"List routes advertised by a given BGP speaker.\"\"\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027destination\u0027, \u0027next_hop\u0027]"},{"line_number":239,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":240,"context_line":"    pagination_support \u003d True"},{"line_number":241,"context_line":"    sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_d2bd3dd8","line":238,"in_reply_to":"ba15a1d1_cf084c2b","updated":"2015-09-29 15:35:05.000000000","message":"No need for \u0027id\u0027 column, \u0027next_hop\u0027 and \u0027destination\u0027 are all we need.  Advertised routes are derived data, there is no id.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"42fafdaeda1e4fb67bfeb12bda030f98f12d2045","unresolved":false,"context_lines":[{"line_number":235,"context_line":"class ListRoutesAdvertisedBySpeaker(neutronv20.ListCommand):"},{"line_number":236,"context_line":"    \"\"\"List routes advertised by a given BGP speaker.\"\"\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027destination\u0027, \u0027next_hop\u0027]"},{"line_number":239,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":240,"context_line":"    pagination_support \u003d True"},{"line_number":241,"context_line":"    sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_7522c8a4","line":238,"in_reply_to":"ba15a1d1_d2bd3dd8","updated":"2015-09-30 06:44:01.000000000","message":"ID here would refer BGP Speaker ID and not route\u0027s ID. \n\nPlease note, we register get_advertised_routes to bgp-speaker resource. (https://review.openstack.org/#/c/201621/32/neutron/extensions/bgp.py L185)","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"b86a0d439ae96724f80a6f7ab69ede5b02faeaa7","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    \"\"\"List routes advertised by a given BGP speaker.\"\"\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027destination\u0027, \u0027next_hop\u0027]"},{"line_number":239,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":240,"context_line":"    pagination_support \u003d True"},{"line_number":241,"context_line":"    sorting_support \u003d True"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_57411762","line":239,"updated":"2015-12-02 14:54:37.000000000","message":"The resource should be \u0027advertised_route\u0027 because in method get_advertised_routes, the key of routes is \u0027advertised_routes\u0027","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bfc0fff1fc8fe30dd82cb00754859cdb092f7f28","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    \"\"\"List routes advertised by a given BGP speaker.\"\"\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027destination\u0027, \u0027next_hop\u0027]"},{"line_number":239,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":240,"context_line":"    pagination_support \u003d True"},{"line_number":241,"context_line":"    sorting_support \u003d True"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_16d367d6","line":239,"in_reply_to":"9a8ffd7b_57411762","updated":"2015-12-03 06:17:28.000000000","message":"We need to revisit this patch as per the latest server code. AKAIK, there are some changes made to the API endpoints now.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"28c0bfc065f907edaa7fb70362f73c61a151863a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \"\"\"List BGP speakers.\"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":59,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027name\u0027, \u0027local_as\u0027, \u0027address-scope\u0027]"},{"line_number":60,"context_line":"    pagination_support \u003d True"},{"line_number":61,"context_line":"    sorting_support \u003d True"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_7379522f","line":59,"updated":"2015-12-29 17:26:24.000000000","message":"address_scope?\n\nAn attribute name should be delimited by underscore, so \u0027address-scope\u0027 looks wrong.","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb9a1131f59024385b374fc25990c9260cc1e154","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \"\"\"List BGP speakers.\"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    resource \u003d \u0027bgp_speaker\u0027"},{"line_number":59,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027name\u0027, \u0027local_as\u0027, \u0027address-scope\u0027]"},{"line_number":60,"context_line":"    pagination_support \u003d True"},{"line_number":61,"context_line":"    sorting_support \u003d True"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_4020e7f7","line":59,"in_reply_to":"fa69d971_7379522f","updated":"2015-12-30 04:26:17.000000000","message":"This is a mistake. It should be address_scope_id.","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb9a1131f59024385b374fc25990c9260cc1e154","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":76,"context_line":"        parser.add_argument("},{"line_number":77,"context_line":"            \u0027name\u0027,"},{"line_number":78,"context_line":"            metavar\u003d\u0027SPEAKER_NAME\u0027,"},{"line_number":79,"context_line":"            help\u003d_(\u0027Name of the BGP speaker to create.\u0027))"},{"line_number":80,"context_line":"        parser.add_argument("},{"line_number":81,"context_line":"            \u0027--local-as\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_806d7f34","line":78,"updated":"2015-12-30 04:26:17.000000000","message":"Will change to NAME as other resource do it for \u0027name\u0027 attribute.","commit_id":"b9a7a277492a7c03efcb457b6f4a5794e4694196"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"92aa09a37490ac8996c7c2c63a123671aa46e518","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Huawei Technologies India Pvt. Ltd."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_3c7926fd","line":1,"updated":"2016-01-08 07:47:01.000000000","message":"Let\u0027s roll to 2016","commit_id":"bbc4b9dea8bdc774bf588187b35d314e777296e8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c2d638a2c7b8035a7a770117848268e45c99a263","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                   \u0027is allowed.)\u0027) % {\u0027min_val\u0027: MIN_AS_NUM,"},{"line_number":90,"context_line":"                                      \u0027max_val\u0027: MAX_AS_NUM})"},{"line_number":91,"context_line":"        parser.add_argument("},{"line_number":92,"context_line":"            \u0027--address-scope\u0027,"},{"line_number":93,"context_line":"            metavar\u003d\u0027ADDRSCOPE\u0027,"},{"line_number":94,"context_line":"            required\u003dTrue,"},{"line_number":95,"context_line":"            help\u003d_(\u0027ID or name of the address scope with which the BGP speaker\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_a3e14cd2","line":92,"updated":"2016-01-22 06:30:02.000000000","message":"Address scope is being removed as per the latest design design. Addr-scope can be impliicity inferred while route advertisement.","commit_id":"bbc4b9dea8bdc774bf588187b35d314e777296e8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"720e08eb36790a44a4a21bbf2270ad87063a14db","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Allowed Autonomous number range"},{"line_number":27,"context_line":"MIN_AS_NUM \u003d 1"},{"line_number":28,"context_line":"MAX_AS_NUM \u003d 65535"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def get_bgp_speaker_id(client, id_or_name):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_786840bb","line":28,"updated":"2016-02-03 07:33:58.000000000","message":"why cant we keep it in the common section ?\nThese numbers are not specific to BGP, and can be used for other purposes as well, right?\nhttps://github.com/openstack/python-neutronclient/blob/master/neutronclient/common/constants.py","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Allowed Autonomous number range"},{"line_number":27,"context_line":"MIN_AS_NUM \u003d 1"},{"line_number":28,"context_line":"MAX_AS_NUM \u003d 65535"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def get_bgp_speaker_id(client, id_or_name):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_69886123","line":28,"in_reply_to":"5a5ae5dd_786840bb","updated":"2016-02-03 13:57:44.000000000","message":"This is specific to BGP. AFAIK, none of the neutron functionality / feature requires autonomous systems to be defined.\n\nChanging gears, our intention is to keep the code decoupled from the main code as much as possible so that it can be easily ripped-off when BGP changes are moved to it\u0027s own separate repo later.","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"93d0c6b4053d13bf98e36ba28390054cfd5a29b8","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutronclient.common import utils"},{"line_number":20,"context_line":"from neutronclient.common import validators"},{"line_number":21,"context_line":"from neutronclient.i18n import _"},{"line_number":22,"context_line":"from neutronclient.neutron import v2_0 as neutronv20"},{"line_number":23,"context_line":"from neutronclient.neutron.v2_0.bgp import peer as bgp_peer"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_c63ed4b7","line":21,"range":{"start_line":21,"start_character":19,"end_line":21,"end_character":23},"updated":"2016-02-15 14:38:16.000000000","message":"For a new code, _i18n is recommended.","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"45051d6af016f5e18bcca14623cbf5a28bcf379c","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutronclient.common import utils"},{"line_number":20,"context_line":"from neutronclient.common import validators"},{"line_number":21,"context_line":"from neutronclient.i18n import _"},{"line_number":22,"context_line":"from neutronclient.neutron import v2_0 as neutronv20"},{"line_number":23,"context_line":"from neutronclient.neutron.v2_0.bgp import peer as bgp_peer"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_0751ad0e","line":21,"range":{"start_line":21,"start_character":19,"end_line":21,"end_character":23},"in_reply_to":"dae33548_02bb68e6","updated":"2016-02-16 09:47:45.000000000","message":"Done","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"73b825977e0825ceafb3cd4c98950943417d2d3c","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutronclient.common import utils"},{"line_number":20,"context_line":"from neutronclient.common import validators"},{"line_number":21,"context_line":"from neutronclient.i18n import _"},{"line_number":22,"context_line":"from neutronclient.neutron import v2_0 as neutronv20"},{"line_number":23,"context_line":"from neutronclient.neutron.v2_0.bgp import peer as bgp_peer"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_f94d5f73","line":21,"range":{"start_line":21,"start_character":19,"end_line":21,"end_character":23},"in_reply_to":"dae33548_c63ed4b7","updated":"2016-02-16 00:37:14.000000000","message":"+1","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bf29b6d521e866423c79edce26b3d271fdd63439","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutronclient.common import utils"},{"line_number":20,"context_line":"from neutronclient.common import validators"},{"line_number":21,"context_line":"from neutronclient.i18n import _"},{"line_number":22,"context_line":"from neutronclient.neutron import v2_0 as neutronv20"},{"line_number":23,"context_line":"from neutronclient.neutron.v2_0.bgp import peer as bgp_peer"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_02bb68e6","line":21,"range":{"start_line":21,"start_character":19,"end_line":21,"end_character":23},"in_reply_to":"dae33548_f94d5f73","updated":"2016-02-16 03:23:03.000000000","message":"Will change.","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e5ea825da99492329da7ac968cec2617abfb37b4","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":91,"context_line":"        parser.add_argument("},{"line_number":92,"context_line":"            \u0027name\u0027,"},{"line_number":93,"context_line":"            metavar\u003d\u0027NAME\u0027,"},{"line_number":94,"context_line":"            help\u003d_(\u0027Name of the BGP speaker to create.\u0027))"},{"line_number":95,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_6d3d05bb","line":92,"updated":"2016-02-16 03:53:53.000000000","message":"Why is the Name a Positional Argument?\n--local-as is a required argument , so maybe you can skip the Positional Name argument ( this is just a thought)","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"be9278e43e22c7ce5c630ac34407007c62c2b659","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":91,"context_line":"        parser.add_argument("},{"line_number":92,"context_line":"            \u0027name\u0027,"},{"line_number":93,"context_line":"            metavar\u003d\u0027NAME\u0027,"},{"line_number":94,"context_line":"            help\u003d_(\u0027Name of the BGP speaker to create.\u0027))"},{"line_number":95,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_f14c4b72","line":92,"in_reply_to":"dae33548_6d3d05bb","updated":"2016-02-16 09:12:34.000000000","message":"Plz note \u0027name\u0027 is a mandatory parameter as it\u0027s not suffixed by \u0027--\u0027","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"}],"neutronclient/neutron/v2_0/network.py":[{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"616891e07be66638429c0ae3a0e3a84680ed2ee8","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def get_network_id(client, id_or_name):"},{"line_number":26,"context_line":"    return neutronV20.find_resourceid_by_name_or_id(client,"},{"line_number":27,"context_line":"                                                    \u0027network\u0027, id_or_name)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def _format_subnets(network):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_ca5db449","line":27,"updated":"2015-07-31 13:24:36.000000000","message":"Uhm... This functions seems out of place on this patch, right?","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"9581d95d41149fea2da1e27e84e57d9e245fd0e0","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def get_network_id(client, id_or_name):"},{"line_number":26,"context_line":"    return neutronV20.find_resourceid_by_name_or_id(client,"},{"line_number":27,"context_line":"                                                    \u0027network\u0027, id_or_name)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def _format_subnets(network):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_2647cabc","line":27,"in_reply_to":"3a50d1a3_9ebee762","updated":"2015-08-04 11:57:47.000000000","message":"It\u0027s required,  Please check \u0027AddNetworkToSpeaker or RemoveNetworkFromSpeaker\u0027 in speaker.py where the net-id is queried.","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4bb02eb23adf3ff725b652b189b018c43e1115f9","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def get_network_id(client, id_or_name):"},{"line_number":26,"context_line":"    return neutronV20.find_resourceid_by_name_or_id(client,"},{"line_number":27,"context_line":"                                                    \u0027network\u0027, id_or_name)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def _format_subnets(network):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_9ebee762","line":27,"in_reply_to":"3a50d1a3_ca5db449","updated":"2015-08-01 05:02:33.000000000","message":"Oppsss.. Good catch, By mistake other local changes shown up :(. Will remove. Thanks again for catching this up.","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"02189ca19491e7dfaac38b8a5f5bb50c1903709e","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def get_network_id(client, id_or_name):"},{"line_number":28,"context_line":"    return neutronV20.find_resourceid_by_name_or_id(client,"},{"line_number":29,"context_line":"                                                    \u0027network\u0027, id_or_name)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_223cd792","line":28,"updated":"2016-02-03 06:34:46.000000000","message":"why here?","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def get_network_id(client, id_or_name):"},{"line_number":28,"context_line":"    return neutronV20.find_resourceid_by_name_or_id(client,"},{"line_number":29,"context_line":"                                                    \u0027network\u0027, id_or_name)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_41f3ff73","line":28,"in_reply_to":"5a5ae5dd_223cd792","updated":"2016-02-03 13:57:44.000000000","message":"Does\u0027t wanted to have the intelligence of querying \u0027network\u0027 resource in my script hence defined here thinking that this could be a common function used by all rather than querying \u0027network\u0027 resource explicitly separately.\n\nBut if you want I can remove.","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def get_network_id(client, id_or_name):"},{"line_number":28,"context_line":"    return neutronV20.find_resourceid_by_name_or_id(client,"},{"line_number":29,"context_line":"                                                    \u0027network\u0027, id_or_name)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_087b2cc2","line":28,"in_reply_to":"5a5ae5dd_41f3ff73","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"}],"neutronclient/shell.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"e5703a533a3914690acb1820b24d8b6775dde40e","unresolved":false,"context_lines":[{"line_number":362,"context_line":"    \u0027nec-packet-filter-create\u0027: packetfilter.CreatePacketFilter,"},{"line_number":363,"context_line":"    \u0027nec-packet-filter-update\u0027: packetfilter.UpdatePacketFilter,"},{"line_number":364,"context_line":"    \u0027nec-packet-filter-delete\u0027: packetfilter.DeletePacketFilter,"},{"line_number":365,"context_line":"    \u0027dr-agent-bgp-speaker-add\u0027: ("},{"line_number":366,"context_line":"        agentscheduler.AddBgpSpeakerToDrAgent"},{"line_number":367,"context_line":"    ),"},{"line_number":368,"context_line":"    \u0027dr-agent-bgp-speaker-remove\u0027: ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_da8e0979","line":365,"updated":"2015-07-30 15:46:22.000000000","message":"Since the notion of a generic dr-agent is killed, so how about renaming it as \"bgp-dragent-speaker-add\"?","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4bb02eb23adf3ff725b652b189b018c43e1115f9","unresolved":false,"context_lines":[{"line_number":362,"context_line":"    \u0027nec-packet-filter-create\u0027: packetfilter.CreatePacketFilter,"},{"line_number":363,"context_line":"    \u0027nec-packet-filter-update\u0027: packetfilter.UpdatePacketFilter,"},{"line_number":364,"context_line":"    \u0027nec-packet-filter-delete\u0027: packetfilter.DeletePacketFilter,"},{"line_number":365,"context_line":"    \u0027dr-agent-bgp-speaker-add\u0027: ("},{"line_number":366,"context_line":"        agentscheduler.AddBgpSpeakerToDrAgent"},{"line_number":367,"context_line":"    ),"},{"line_number":368,"context_line":"    \u0027dr-agent-bgp-speaker-remove\u0027: ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_7eed1b8d","line":365,"in_reply_to":"3a50d1a3_da8e0979","updated":"2015-08-01 05:02:33.000000000","message":"+1 for \"bgp-dragent-speaker-add\" from my end.","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"e5703a533a3914690acb1820b24d8b6775dde40e","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    \u0027dr-agent-bgp-speaker-add\u0027: ("},{"line_number":366,"context_line":"        agentscheduler.AddBgpSpeakerToDrAgent"},{"line_number":367,"context_line":"    ),"},{"line_number":368,"context_line":"    \u0027dr-agent-bgp-speaker-remove\u0027: ("},{"line_number":369,"context_line":"        agentscheduler.RemoveBgpSpeakerFromDrAgent"},{"line_number":370,"context_line":"    ),"},{"line_number":371,"context_line":"    \u0027bgp-speaker-list-on-dr-agent\u0027: ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_7af6d5fa","line":368,"updated":"2015-07-30 15:46:22.000000000","message":"How about renaming it to \"bgp-dragent-speaker-remove\"?","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"379ef9ff0c80cecac2492870e9254f57f735445f","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    \u0027dr-agent-bgp-speaker-add\u0027: ("},{"line_number":366,"context_line":"        agentscheduler.AddBgpSpeakerToDrAgent"},{"line_number":367,"context_line":"    ),"},{"line_number":368,"context_line":"    \u0027dr-agent-bgp-speaker-remove\u0027: ("},{"line_number":369,"context_line":"        agentscheduler.RemoveBgpSpeakerFromDrAgent"},{"line_number":370,"context_line":"    ),"},{"line_number":371,"context_line":"    \u0027bgp-speaker-list-on-dr-agent\u0027: ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_ec77859d","line":368,"in_reply_to":"3a50d1a3_7af6d5fa","updated":"2015-07-30 21:52:42.000000000","message":"I can +1 that","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4bb02eb23adf3ff725b652b189b018c43e1115f9","unresolved":false,"context_lines":[{"line_number":365,"context_line":"    \u0027dr-agent-bgp-speaker-add\u0027: ("},{"line_number":366,"context_line":"        agentscheduler.AddBgpSpeakerToDrAgent"},{"line_number":367,"context_line":"    ),"},{"line_number":368,"context_line":"    \u0027dr-agent-bgp-speaker-remove\u0027: ("},{"line_number":369,"context_line":"        agentscheduler.RemoveBgpSpeakerFromDrAgent"},{"line_number":370,"context_line":"    ),"},{"line_number":371,"context_line":"    \u0027bgp-speaker-list-on-dr-agent\u0027: ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_dedf8fd4","line":368,"in_reply_to":"3a50d1a3_ec77859d","updated":"2015-08-01 05:02:33.000000000","message":"+1 for \"bgp-dragent-speaker-remove\" from my end.","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"e5703a533a3914690acb1820b24d8b6775dde40e","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    \u0027dr-agent-bgp-speaker-remove\u0027: ("},{"line_number":369,"context_line":"        agentscheduler.RemoveBgpSpeakerFromDrAgent"},{"line_number":370,"context_line":"    ),"},{"line_number":371,"context_line":"    \u0027bgp-speaker-list-on-dr-agent\u0027: ("},{"line_number":372,"context_line":"        agentscheduler.ListBgpSpeakersOnDrAgent"},{"line_number":373,"context_line":"    ),"},{"line_number":374,"context_line":"    \u0027dr-agent-list-hosting-bgp-speaker\u0027: ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_fa1505e5","line":371,"updated":"2015-07-30 15:46:22.000000000","message":"How about renaming it to \"bgp-dragent-speaker-list\"?","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4bb02eb23adf3ff725b652b189b018c43e1115f9","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    \u0027dr-agent-bgp-speaker-remove\u0027: ("},{"line_number":369,"context_line":"        agentscheduler.RemoveBgpSpeakerFromDrAgent"},{"line_number":370,"context_line":"    ),"},{"line_number":371,"context_line":"    \u0027bgp-speaker-list-on-dr-agent\u0027: ("},{"line_number":372,"context_line":"        agentscheduler.ListBgpSpeakersOnDrAgent"},{"line_number":373,"context_line":"    ),"},{"line_number":374,"context_line":"    \u0027dr-agent-list-hosting-bgp-speaker\u0027: ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_def6af5c","line":371,"in_reply_to":"3a50d1a3_2c5ecd12","updated":"2015-08-01 05:02:33.000000000","message":"Since, the usage of this CLI is to list all the bgp-speakers hosted by a dragent so, I feel \"bgp-dragent-speaker-list\" conveys this idea more strongly. Hence +1 for \"bgp-dragent-speaker-list\" from my end.","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"379ef9ff0c80cecac2492870e9254f57f735445f","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    \u0027dr-agent-bgp-speaker-remove\u0027: ("},{"line_number":369,"context_line":"        agentscheduler.RemoveBgpSpeakerFromDrAgent"},{"line_number":370,"context_line":"    ),"},{"line_number":371,"context_line":"    \u0027bgp-speaker-list-on-dr-agent\u0027: ("},{"line_number":372,"context_line":"        agentscheduler.ListBgpSpeakersOnDrAgent"},{"line_number":373,"context_line":"    ),"},{"line_number":374,"context_line":"    \u0027dr-agent-list-hosting-bgp-speaker\u0027: ("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_2c5ecd12","line":371,"in_reply_to":"3a50d1a3_fa1505e5","updated":"2015-07-30 21:52:42.000000000","message":"I would have suggested bgp-speaker-dragent-list","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"e5703a533a3914690acb1820b24d8b6775dde40e","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    \u0027bgp-speaker-list-on-dr-agent\u0027: ("},{"line_number":372,"context_line":"        agentscheduler.ListBgpSpeakersOnDrAgent"},{"line_number":373,"context_line":"    ),"},{"line_number":374,"context_line":"    \u0027dr-agent-list-hosting-bgp-speaker\u0027: ("},{"line_number":375,"context_line":"        agentscheduler.ListDrAgentsHostingBgpSpeaker"},{"line_number":376,"context_line":"    ),"},{"line_number":377,"context_line":"    \u0027bgp-speaker-list\u0027: bgp_speaker.ListSpeakers,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_9ace41b6","line":374,"updated":"2015-07-30 15:46:22.000000000","message":"How about renaming it to \"bgp-dragent-list-hosting-speaker\"?","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"379ef9ff0c80cecac2492870e9254f57f735445f","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    \u0027bgp-speaker-list-on-dr-agent\u0027: ("},{"line_number":372,"context_line":"        agentscheduler.ListBgpSpeakersOnDrAgent"},{"line_number":373,"context_line":"    ),"},{"line_number":374,"context_line":"    \u0027dr-agent-list-hosting-bgp-speaker\u0027: ("},{"line_number":375,"context_line":"        agentscheduler.ListDrAgentsHostingBgpSpeaker"},{"line_number":376,"context_line":"    ),"},{"line_number":377,"context_line":"    \u0027bgp-speaker-list\u0027: bgp_speaker.ListSpeakers,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_6cab75d7","line":374,"in_reply_to":"3a50d1a3_9ace41b6","updated":"2015-07-30 21:52:42.000000000","message":"I would have suggested bgp-dargent-hosting-list","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"409970d681c0b0f376230afd7cc6ca5c22a5281c","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    \u0027bgp-dragent-speaker-remove\u0027: ("},{"line_number":369,"context_line":"        agentscheduler.RemoveBGPSpeakerFromDRAgent"},{"line_number":370,"context_line":"    ),"},{"line_number":371,"context_line":"    \u0027bgp-speaker-list-on-dragent\u0027: ("},{"line_number":372,"context_line":"        agentscheduler.ListBGPSpeakersOnDRAgent"},{"line_number":373,"context_line":"    ),"},{"line_number":374,"context_line":"    \u0027bgp-dragent-list-hosting-speaker\u0027: ("}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_8e97b48f","line":371,"updated":"2015-08-04 20:34:55.000000000","message":"continuing the discussion from PS-1 - I don\u0027t care which one, but it should end with \"list\" to be consistent","commit_id":"9117e2f74722a66858d65dfaab1d44ca16445980"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"3c566035693a592653e3b3cbe1502dadbce081d7","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    \u0027bgp-dragent-speaker-remove\u0027: ("},{"line_number":369,"context_line":"        agentscheduler.RemoveBGPSpeakerFromDRAgent"},{"line_number":370,"context_line":"    ),"},{"line_number":371,"context_line":"    \u0027bgp-speaker-list-on-dragent\u0027: ("},{"line_number":372,"context_line":"        agentscheduler.ListBGPSpeakersOnDRAgent"},{"line_number":373,"context_line":"    ),"},{"line_number":374,"context_line":"    \u0027bgp-dragent-list-hosting-speaker\u0027: ("}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_6c1d830e","line":371,"in_reply_to":"1a4dcd0f_8e97b48f","updated":"2015-08-05 05:06:24.000000000","message":"@Ryan: We have followed the existing nomenclature.\n\nrouter-list-on-l3-agent\n\nnet-list-on-dhcp-agent","commit_id":"9117e2f74722a66858d65dfaab1d44ca16445980"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"409970d681c0b0f376230afd7cc6ca5c22a5281c","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    \u0027bgp-speaker-list-on-dragent\u0027: ("},{"line_number":372,"context_line":"        agentscheduler.ListBGPSpeakersOnDRAgent"},{"line_number":373,"context_line":"    ),"},{"line_number":374,"context_line":"    \u0027bgp-dragent-list-hosting-speaker\u0027: ("},{"line_number":375,"context_line":"        agentscheduler.ListDRAgentsHostingBGPSpeaker"},{"line_number":376,"context_line":"    ),"},{"line_number":377,"context_line":"    \u0027bgp-speaker-list\u0027: bgp_speaker.ListSpeakers,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_4e91ac98","line":374,"updated":"2015-08-04 20:34:55.000000000","message":"see above","commit_id":"9117e2f74722a66858d65dfaab1d44ca16445980"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"3c566035693a592653e3b3cbe1502dadbce081d7","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    \u0027bgp-speaker-list-on-dragent\u0027: ("},{"line_number":372,"context_line":"        agentscheduler.ListBGPSpeakersOnDRAgent"},{"line_number":373,"context_line":"    ),"},{"line_number":374,"context_line":"    \u0027bgp-dragent-list-hosting-speaker\u0027: ("},{"line_number":375,"context_line":"        agentscheduler.ListDRAgentsHostingBGPSpeaker"},{"line_number":376,"context_line":"    ),"},{"line_number":377,"context_line":"    \u0027bgp-speaker-list\u0027: bgp_speaker.ListSpeakers,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_0cf39fd7","line":374,"in_reply_to":"1a4dcd0f_4e91ac98","updated":"2015-08-05 05:06:24.000000000","message":"@Ryan: We have followed the existing nomenclature  :-)\n\nl3-agent-list-hosting-router\n\ndhcp-agent-list-hosting-net","commit_id":"9117e2f74722a66858d65dfaab1d44ca16445980"}],"neutronclient/tests/unit/bgp/test_cli20_agentschedulers.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"92aa09a37490ac8996c7c2c63a123671aa46e518","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Huawei Technologies India Pvt. Ltd."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_9c729210","line":1,"updated":"2016-01-08 07:47:01.000000000","message":"Let\u0027s roll to 2016","commit_id":"bbc4b9dea8bdc774bf588187b35d314e777296e8"}],"neutronclient/tests/unit/bgp/test_cli20_peer.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b7653800e86051a910e1399352dccffbc8c9383b","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                                 None)"},{"line_number":179,"context_line":"        self._test_list_resources(resources, cmd, True)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def test_list_bgp_peer_sort(self):"},{"line_number":182,"context_line":"        \"\"\"sorted list: bgp-peer-list --sort-key name --sort-key id"},{"line_number":183,"context_line":"        --sort-key asc --sort-key desc"},{"line_number":184,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_d7e5ba08","line":181,"updated":"2015-08-21 07:26:32.000000000","message":"Add test-case for \"test_list_bgp_peer_pagination\".","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"8d100546c9087e12d8b4de9f1eb297a374d4565e","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                 None)"},{"line_number":180,"context_line":"        self._test_list_resources(resources, cmd, True)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    # TODO(Vikram) : Add \u0027test_list_bgp_peer_pagination\u0027"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_list_bgp_peer_sort(self):"},{"line_number":185,"context_line":"        \"\"\"sorted list: bgp-peer-list --sort-key name --sort-key id"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_dd15899b","line":182,"updated":"2015-09-09 10:31:51.000000000","message":"Write this test scenario.","commit_id":"27ed694b56b06c307e434a9c7ddb89d8eaf53e32"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"92aa09a37490ac8996c7c2c63a123671aa46e518","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Huawei Technologies India Pvt. Ltd."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_fc594e8f","line":1,"updated":"2016-01-08 07:47:01.000000000","message":"Let\u0027s roll to 2016","commit_id":"bbc4b9dea8bdc774bf588187b35d314e777296e8"}],"neutronclient/tests/unit/bgp/test_cli20_speaker.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b7653800e86051a910e1399352dccffbc8c9383b","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                                              None)"},{"line_number":306,"context_line":"        args \u003d [\u0027myid\u0027, \u0027netid\u0027]"},{"line_number":307,"context_line":"        self._test_add_remove_network(\u0027add\u0027, cmd, args)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def test_remove_network_from_bgp_speaker(self):"},{"line_number":310,"context_line":"        \"\"\"Remove network from BGP speaker: myid network_id\u003dnetid\"\"\""},{"line_number":311,"context_line":"        cmd \u003d bgp_speaker.RemoveNetworkFromSpeaker("}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_d7f7fad0","line":308,"updated":"2015-08-21 07:26:32.000000000","message":"Add test-cases for \"ListRoutesAdvertisedBySpeaker\"","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bdce2a719caf7a1320577c2df8beee0766643b7d","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                                              None)"},{"line_number":306,"context_line":"        args \u003d [\u0027myid\u0027, \u0027netid\u0027]"},{"line_number":307,"context_line":"        self._test_add_remove_network(\u0027add\u0027, cmd, args)"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def test_remove_network_from_bgp_speaker(self):"},{"line_number":310,"context_line":"        \"\"\"Remove network from BGP speaker: myid network_id\u003dnetid\"\"\""},{"line_number":311,"context_line":"        cmd \u003d bgp_speaker.RemoveNetworkFromSpeaker("}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_71b180df","line":308,"in_reply_to":"fa1b9901_d7f7fad0","updated":"2015-09-05 11:28:30.000000000","message":"Done.","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"92aa09a37490ac8996c7c2c63a123671aa46e518","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Huawei Technologies India Pvt. Ltd."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_bc543654","line":1,"updated":"2016-01-08 07:47:01.000000000","message":"Let\u0027s roll to 2016","commit_id":"bbc4b9dea8bdc774bf588187b35d314e777296e8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"93d0c6b4053d13bf98e36ba28390054cfd5a29b8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from mox3 import mox"},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutronclient.common import exceptions"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_7cf3140b","line":17,"updated":"2016-02-15 14:38:16.000000000","message":"nit: mox3 is third-party.","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bf29b6d521e866423c79edce26b3d271fdd63439","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from mox3 import mox"},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutronclient.common import exceptions"}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_22b82ce5","line":17,"in_reply_to":"dae33548_7cf3140b","updated":"2016-02-16 03:23:03.000000000","message":"Ok will re-arrange the imports.","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"}],"neutronclient/tests/unit/test_cli20.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"edea5f5368bb6eda8383d8f0d4cdcfbd71475c4d","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                                      \u0027ipsecpolicy\u0027, \u0027metering_label\u0027,"},{"line_number":226,"context_line":"                                      \u0027metering_label_rule\u0027, \u0027net_partition\u0027,"},{"line_number":227,"context_line":"                                      \u0027fox_socket\u0027, \u0027subnetpool\u0027,"},{"line_number":228,"context_line":"                                      \u0027rbac_policy\u0027, \u0027bgp_speaker\u0027, \u0027bgp_peer\u0027]"},{"line_number":229,"context_line":"        if not cmd_resource:"},{"line_number":230,"context_line":"            cmd_resource \u003d resource"},{"line_number":231,"context_line":"        if (resource in non_admin_status_resources):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_8b60cba6","line":228,"updated":"2015-08-29 03:29:25.000000000","message":"Please use the registration interface provided in the latest code and avoid modifying non_admin_status_resources directly.","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bdce2a719caf7a1320577c2df8beee0766643b7d","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                                      \u0027ipsecpolicy\u0027, \u0027metering_label\u0027,"},{"line_number":226,"context_line":"                                      \u0027metering_label_rule\u0027, \u0027net_partition\u0027,"},{"line_number":227,"context_line":"                                      \u0027fox_socket\u0027, \u0027subnetpool\u0027,"},{"line_number":228,"context_line":"                                      \u0027rbac_policy\u0027, \u0027bgp_speaker\u0027, \u0027bgp_peer\u0027]"},{"line_number":229,"context_line":"        if not cmd_resource:"},{"line_number":230,"context_line":"            cmd_resource \u003d resource"},{"line_number":231,"context_line":"        if (resource in non_admin_status_resources):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_1175a462","line":228,"in_reply_to":"da20952f_8b60cba6","updated":"2015-09-05 11:28:30.000000000","message":"done","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4bb02eb23adf3ff725b652b189b018c43e1115f9","unresolved":false,"context_lines":[{"line_number":417,"context_line":"    LOADBALANCER_AGENT \u003d \u0027/loadbalancer-agent\u0027"},{"line_number":418,"context_line":"    AGENT_LOADBALANCERS \u003d \u0027/agent-loadbalancers\u0027"},{"line_number":419,"context_line":"    LOADBALANCER_HOSTING_AGENT \u003d \u0027/loadbalancer-hosting-agent\u0027"},{"line_number":420,"context_line":"    DR_INSTANCES \u003d \u0027/dr-instances\u0027"},{"line_number":421,"context_line":"    DR_AGENTS \u003d \u0027/dr-agents\u0027"},{"line_number":422,"context_line":"    DR_AGENT \u003d \u0027/dr-agents/%s\u0027"},{"line_number":423,"context_line":"    firewall_rules_path \u003d \"/fw/firewall_rules\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_5ea13f45","line":420,"updated":"2015-08-01 05:02:33.000000000","message":"How about renaming the resource as \"/bgp-dr-instances\"","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"e5703a533a3914690acb1820b24d8b6775dde40e","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    AGENT_LOADBALANCERS \u003d \u0027/agent-loadbalancers\u0027"},{"line_number":419,"context_line":"    LOADBALANCER_HOSTING_AGENT \u003d \u0027/loadbalancer-hosting-agent\u0027"},{"line_number":420,"context_line":"    DR_INSTANCES \u003d \u0027/dr-instances\u0027"},{"line_number":421,"context_line":"    DR_AGENTS \u003d \u0027/dr-agents\u0027"},{"line_number":422,"context_line":"    DR_AGENT \u003d \u0027/dr-agents/%s\u0027"},{"line_number":423,"context_line":"    firewall_rules_path \u003d \"/fw/firewall_rules\""},{"line_number":424,"context_line":"    firewall_rule_path \u003d \"/fw/firewall_rules/%s\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_9a93a100","line":421,"updated":"2015-07-30 15:46:22.000000000","message":"How about renaming the resource as \"/bgp-dragents\"","commit_id":"20a14ed5e4d1f07113408cc484580bd0dde016ac"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb94feb2d975f734728eb48f3ea5a42d5519970b","unresolved":false,"context_lines":[{"line_number":431,"context_line":"    BGP_DRINSTANCE \u003d \u0027/bgp-drinstance/%s\u0027"},{"line_number":432,"context_line":"    BGP_DRAGENTS \u003d \u0027/bgp-dragents\u0027"},{"line_number":433,"context_line":"    BGP_DRAGENT \u003d \u0027/bgp-dragents/%s\u0027"},{"line_number":434,"context_line":"    bgp_speakers_path \u003d \"/bgp/bgp-speakers\""},{"line_number":435,"context_line":"    bgp_speaker_path \u003d \"/bgp/bgp-speakers/%s\""},{"line_number":436,"context_line":"    bgp_peers_path \u003d \"/bgp/bgp-peers\""},{"line_number":437,"context_line":"    bgp_peer_path \u003d \"/bgp/bgp-peers/%s\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_8f70a0a5","line":434,"updated":"2015-08-06 17:47:48.000000000","message":"change it to \"bgp-speakers\" for server conformance.","commit_id":"9117e2f74722a66858d65dfaab1d44ca16445980"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb94feb2d975f734728eb48f3ea5a42d5519970b","unresolved":false,"context_lines":[{"line_number":432,"context_line":"    BGP_DRAGENTS \u003d \u0027/bgp-dragents\u0027"},{"line_number":433,"context_line":"    BGP_DRAGENT \u003d \u0027/bgp-dragents/%s\u0027"},{"line_number":434,"context_line":"    bgp_speakers_path \u003d \"/bgp/bgp-speakers\""},{"line_number":435,"context_line":"    bgp_speaker_path \u003d \"/bgp/bgp-speakers/%s\""},{"line_number":436,"context_line":"    bgp_peers_path \u003d \"/bgp/bgp-peers\""},{"line_number":437,"context_line":"    bgp_peer_path \u003d \"/bgp/bgp-peers/%s\""},{"line_number":438,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_2f6ceccc","line":435,"updated":"2015-08-06 17:47:48.000000000","message":"change it to \"bgp-speakers\" for server conformance.","commit_id":"9117e2f74722a66858d65dfaab1d44ca16445980"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb94feb2d975f734728eb48f3ea5a42d5519970b","unresolved":false,"context_lines":[{"line_number":433,"context_line":"    BGP_DRAGENT \u003d \u0027/bgp-dragents/%s\u0027"},{"line_number":434,"context_line":"    bgp_speakers_path \u003d \"/bgp/bgp-speakers\""},{"line_number":435,"context_line":"    bgp_speaker_path \u003d \"/bgp/bgp-speakers/%s\""},{"line_number":436,"context_line":"    bgp_peers_path \u003d \"/bgp/bgp-peers\""},{"line_number":437,"context_line":"    bgp_peer_path \u003d \"/bgp/bgp-peers/%s\""},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    # API has no way to report plurals, so we have to hard code them"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_4f67f8e8","line":436,"updated":"2015-08-06 17:47:48.000000000","message":"change it to \"bgp-peers\" for server conformance.","commit_id":"9117e2f74722a66858d65dfaab1d44ca16445980"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eb94feb2d975f734728eb48f3ea5a42d5519970b","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    bgp_speakers_path \u003d \"/bgp/bgp-speakers\""},{"line_number":435,"context_line":"    bgp_speaker_path \u003d \"/bgp/bgp-speakers/%s\""},{"line_number":436,"context_line":"    bgp_peers_path \u003d \"/bgp/bgp-peers\""},{"line_number":437,"context_line":"    bgp_peer_path \u003d \"/bgp/bgp-peers/%s\""},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    # API has no way to report plurals, so we have to hard code them"},{"line_number":440,"context_line":"    EXTED_PLURALS \u003d {\u0027routers\u0027: \u0027router\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_cfa1c8f9","line":437,"updated":"2015-08-06 17:47:48.000000000","message":"change it to \"bgp-peers\" for server conformance.","commit_id":"9117e2f74722a66858d65dfaab1d44ca16445980"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"c3072f6d1be5bbf7b2eb4c68f9738b5f711ed992","unresolved":false,"context_lines":[{"line_number":436,"context_line":"    bgp_peers_path \u003d \"/bgp/bgp-peers\""},{"line_number":437,"context_line":"    bgp_peer_path \u003d \"/bgp/bgp-peers/%s\""},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    # API has no way to report plurals, so we have to hard code them"},{"line_number":440,"context_line":"    EXTED_PLURALS \u003d {\u0027routers\u0027: \u0027router\u0027,"},{"line_number":441,"context_line":"                     \u0027floatingips\u0027: \u0027floatingip\u0027,"},{"line_number":442,"context_line":"                     \u0027service_types\u0027: \u0027service_type\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_f4dff966","line":439,"updated":"2015-08-05 15:21:48.000000000","message":"Do we need to add bgp-drinstance and bgp-dragent to the list of plurals below?","commit_id":"9117e2f74722a66858d65dfaab1d44ca16445980"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"08ff20b2a54438cd4d2fe77c7153c475d836fd9f","unresolved":false,"context_lines":[{"line_number":436,"context_line":"    bgp_peers_path \u003d \"/bgp/bgp-peers\""},{"line_number":437,"context_line":"    bgp_peer_path \u003d \"/bgp/bgp-peers/%s\""},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    # API has no way to report plurals, so we have to hard code them"},{"line_number":440,"context_line":"    EXTED_PLURALS \u003d {\u0027routers\u0027: \u0027router\u0027,"},{"line_number":441,"context_line":"                     \u0027floatingips\u0027: \u0027floatingip\u0027,"},{"line_number":442,"context_line":"                     \u0027service_types\u0027: \u0027service_type\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_230c2eec","line":439,"in_reply_to":"1a4dcd0f_f4dff966","updated":"2015-08-06 05:30:31.000000000","message":"Not required.","commit_id":"9117e2f74722a66858d65dfaab1d44ca16445980"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"80eaa90c127af1aba0fa8f96781c1324f32c01d4","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"    def add_network_to_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1679,"context_line":"        \"\"\"Add a network to a BGP speaker.\"\"\""},{"line_number":1680,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1681,"context_line":"                        \"/start_network_advertisement\", body\u003dbody)"},{"line_number":1682,"context_line":""},{"line_number":1683,"context_line":"    @APIParamsCall"},{"line_number":1684,"context_line":"    def remove_network_from_bgp_speaker(self, speaker_id, body\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_c0c99727","line":1681,"updated":"2015-08-12 18:38:50.000000000","message":"should be \"/add_gateway_network\"","commit_id":"68f8956020aff790b83161e18c9aa9120332de84"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"81277388946737b25c89571a32242458c0d4d709","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"    def add_network_to_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1679,"context_line":"        \"\"\"Add a network to a BGP speaker.\"\"\""},{"line_number":1680,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1681,"context_line":"                        \"/start_network_advertisement\", body\u003dbody)"},{"line_number":1682,"context_line":""},{"line_number":1683,"context_line":"    @APIParamsCall"},{"line_number":1684,"context_line":"    def remove_network_from_bgp_speaker(self, speaker_id, body\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_76e5d235","line":1681,"in_reply_to":"1a4dcd0f_c0c99727","updated":"2015-08-13 07:18:24.000000000","message":"Done.","commit_id":"68f8956020aff790b83161e18c9aa9120332de84"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"80eaa90c127af1aba0fa8f96781c1324f32c01d4","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"    def remove_network_from_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1685,"context_line":"        \"\"\"Remove a network from a BGP Speaker.\"\"\""},{"line_number":1686,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1687,"context_line":"                        \"/stop_network_advertisement\", body\u003dbody)"},{"line_number":1688,"context_line":""},{"line_number":1689,"context_line":"    @APIParamsCall"},{"line_number":1690,"context_line":"    def list_route_advertised_from_bgp_speaker(self, speaker_id, **_params):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_40dee7dd","line":1687,"updated":"2015-08-12 18:38:50.000000000","message":"should be \"/remove_gateway_network\"","commit_id":"68f8956020aff790b83161e18c9aa9120332de84"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"81277388946737b25c89571a32242458c0d4d709","unresolved":false,"context_lines":[{"line_number":1684,"context_line":"    def remove_network_from_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1685,"context_line":"        \"\"\"Remove a network from a BGP Speaker.\"\"\""},{"line_number":1686,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1687,"context_line":"                        \"/stop_network_advertisement\", body\u003dbody)"},{"line_number":1688,"context_line":""},{"line_number":1689,"context_line":"    @APIParamsCall"},{"line_number":1690,"context_line":"    def list_route_advertised_from_bgp_speaker(self, speaker_id, **_params):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_36d2ea5c","line":1687,"in_reply_to":"1a4dcd0f_40dee7dd","updated":"2015-08-13 07:18:24.000000000","message":"Done.","commit_id":"68f8956020aff790b83161e18c9aa9120332de84"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d710c23ead63d49ab72c28d4c91b63e9611c1cb7","unresolved":false,"context_lines":[{"line_number":1695,"context_line":"    @APIParamsCall"},{"line_number":1696,"context_line":"    def add_peer_to_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1697,"context_line":"        \"\"\"Add a peer to a BGP speaker.\"\"\""},{"line_number":1698,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1699,"context_line":"                        \"/add_bgp_peer\", body\u003dbody)"},{"line_number":1700,"context_line":""},{"line_number":1701,"context_line":"    @APIParamsCall"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_07a810da","line":1698,"updated":"2015-08-31 06:39:09.000000000","message":"put or post?","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bdce2a719caf7a1320577c2df8beee0766643b7d","unresolved":false,"context_lines":[{"line_number":1695,"context_line":"    @APIParamsCall"},{"line_number":1696,"context_line":"    def add_peer_to_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1697,"context_line":"        \"\"\"Add a peer to a BGP speaker.\"\"\""},{"line_number":1698,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1699,"context_line":"                        \"/add_bgp_peer\", body\u003dbody)"},{"line_number":1700,"context_line":""},{"line_number":1701,"context_line":"    @APIParamsCall"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_9160d4a6","line":1698,"in_reply_to":"da20952f_07a810da","updated":"2015-09-05 11:28:30.000000000","message":"followed existing way. Refer to router_add_interface.","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d710c23ead63d49ab72c28d4c91b63e9611c1cb7","unresolved":false,"context_lines":[{"line_number":1701,"context_line":"    @APIParamsCall"},{"line_number":1702,"context_line":"    def remove_peer_from_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1703,"context_line":"        \"\"\"Remove a peer from a BGP Speaker.\"\"\""},{"line_number":1704,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1705,"context_line":"                        \"/remove_bgp_peer\", body\u003dbody)"},{"line_number":1706,"context_line":""},{"line_number":1707,"context_line":"    @APIParamsCall"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_c76778e7","line":1704,"updated":"2015-08-31 06:39:09.000000000","message":"put or delete?","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bdce2a719caf7a1320577c2df8beee0766643b7d","unresolved":false,"context_lines":[{"line_number":1701,"context_line":"    @APIParamsCall"},{"line_number":1702,"context_line":"    def remove_peer_from_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1703,"context_line":"        \"\"\"Remove a peer from a BGP Speaker.\"\"\""},{"line_number":1704,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1705,"context_line":"                        \"/remove_bgp_peer\", body\u003dbody)"},{"line_number":1706,"context_line":""},{"line_number":1707,"context_line":"    @APIParamsCall"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_b16398b0","line":1704,"in_reply_to":"da20952f_c76778e7","updated":"2015-09-05 11:28:30.000000000","message":"put is fine.","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d710c23ead63d49ab72c28d4c91b63e9611c1cb7","unresolved":false,"context_lines":[{"line_number":1707,"context_line":"    @APIParamsCall"},{"line_number":1708,"context_line":"    def add_network_to_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1709,"context_line":"        \"\"\"Add a network to a BGP speaker.\"\"\""},{"line_number":1710,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1711,"context_line":"                        \"/add_gateway_network\", body\u003dbody)"},{"line_number":1712,"context_line":""},{"line_number":1713,"context_line":"    @APIParamsCall"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_e7a2bcfb","line":1710,"updated":"2015-08-31 06:39:09.000000000","message":"put or post?","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bdce2a719caf7a1320577c2df8beee0766643b7d","unresolved":false,"context_lines":[{"line_number":1707,"context_line":"    @APIParamsCall"},{"line_number":1708,"context_line":"    def add_network_to_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1709,"context_line":"        \"\"\"Add a network to a BGP speaker.\"\"\""},{"line_number":1710,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1711,"context_line":"                        \"/add_gateway_network\", body\u003dbody)"},{"line_number":1712,"context_line":""},{"line_number":1713,"context_line":"    @APIParamsCall"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_5156bcce","line":1710,"in_reply_to":"da20952f_e7a2bcfb","updated":"2015-09-05 11:28:30.000000000","message":"put is fine.","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d710c23ead63d49ab72c28d4c91b63e9611c1cb7","unresolved":false,"context_lines":[{"line_number":1713,"context_line":"    @APIParamsCall"},{"line_number":1714,"context_line":"    def remove_network_from_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1715,"context_line":"        \"\"\"Remove a network from a BGP Speaker.\"\"\""},{"line_number":1716,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1717,"context_line":"                        \"/remove_gateway_network\", body\u003dbody)"},{"line_number":1718,"context_line":""},{"line_number":1719,"context_line":"    @APIParamsCall"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_279d14bc","line":1716,"updated":"2015-08-31 06:39:09.000000000","message":"put or delete?","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bdce2a719caf7a1320577c2df8beee0766643b7d","unresolved":false,"context_lines":[{"line_number":1713,"context_line":"    @APIParamsCall"},{"line_number":1714,"context_line":"    def remove_network_from_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1715,"context_line":"        \"\"\"Remove a network from a BGP Speaker.\"\"\""},{"line_number":1716,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1717,"context_line":"                        \"/remove_gateway_network\", body\u003dbody)"},{"line_number":1718,"context_line":""},{"line_number":1719,"context_line":"    @APIParamsCall"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_715980fc","line":1716,"in_reply_to":"da20952f_279d14bc","updated":"2015-09-05 11:28:30.000000000","message":"put is fine.","commit_id":"2b87256867a46e89accd9c0af2090d701299b260"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"186e7c75f10f68c007bba4b184efef7d52b29df3","unresolved":false,"context_lines":[{"line_number":1670,"context_line":"    @APIParamsCall"},{"line_number":1671,"context_line":"    def show_bgp_speaker(self, speaker_id, **_params):"},{"line_number":1672,"context_line":"        \"\"\"Fetches information of a certain bgp_speaker.\"\"\""},{"line_number":1673,"context_line":"        return self.get(self.bgp_speaker_path % (speaker_id), params\u003d_params)"},{"line_number":1674,"context_line":""},{"line_number":1675,"context_line":"    @APIParamsCall"},{"line_number":1676,"context_line":"    def create_bgp_speaker(self, body\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_b66341dd","line":1673,"updated":"2015-09-08 13:38:55.000000000","message":"For consistency, shouldn\u0027t these say \"bgp_speaker_id\" rather than \"speaker_id\"? Here through line 1717.","commit_id":"27ed694b56b06c307e434a9c7ddb89d8eaf53e32"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"31ed4c208a38afcb7b6490f465ee37745b311104","unresolved":false,"context_lines":[{"line_number":1670,"context_line":"    @APIParamsCall"},{"line_number":1671,"context_line":"    def show_bgp_speaker(self, speaker_id, **_params):"},{"line_number":1672,"context_line":"        \"\"\"Fetches information of a certain bgp_speaker.\"\"\""},{"line_number":1673,"context_line":"        return self.get(self.bgp_speaker_path % (speaker_id), params\u003d_params)"},{"line_number":1674,"context_line":""},{"line_number":1675,"context_line":"    @APIParamsCall"},{"line_number":1676,"context_line":"    def create_bgp_speaker(self, body\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba15a1d1_bc3c34c0","line":1673,"in_reply_to":"da20952f_9d85d108","updated":"2015-09-22 10:59:09.000000000","message":"Done.","commit_id":"27ed694b56b06c307e434a9c7ddb89d8eaf53e32"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"0dcef4172371865259274d3d5ce5367154f1cb1d","unresolved":false,"context_lines":[{"line_number":1670,"context_line":"    @APIParamsCall"},{"line_number":1671,"context_line":"    def show_bgp_speaker(self, speaker_id, **_params):"},{"line_number":1672,"context_line":"        \"\"\"Fetches information of a certain bgp_speaker.\"\"\""},{"line_number":1673,"context_line":"        return self.get(self.bgp_speaker_path % (speaker_id), params\u003d_params)"},{"line_number":1674,"context_line":""},{"line_number":1675,"context_line":"    @APIParamsCall"},{"line_number":1676,"context_line":"    def create_bgp_speaker(self, body\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_9d85d108","line":1673,"in_reply_to":"da20952f_b66341dd","updated":"2015-09-09 10:30:01.000000000","message":"+1.. Ok, Will change.","commit_id":"27ed694b56b06c307e434a9c7ddb89d8eaf53e32"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"4eca6e501074c524593f4d5e656c6d370569f12b","unresolved":false,"context_lines":[{"line_number":1508,"context_line":"        return self.list(\u0027service_providers\u0027, self.service_providers_path,"},{"line_number":1509,"context_line":"                         retrieve_all, **_params)"},{"line_number":1510,"context_line":""},{"line_number":1511,"context_line":"    def list_credentials(self, **_params):"},{"line_number":1512,"context_line":"        \"\"\"Fetch a list of all credentials for a tenant.\"\"\""},{"line_number":1513,"context_line":"        return self.get(self.credentials_path, params\u003d_params)"},{"line_number":1514,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_97d01055","line":1511,"updated":"2015-09-22 18:44:08.000000000","message":"Is there a reason why some of these use _params and others use params?\n\nWhy does this method and list_network_profile_bindings lack the decorator but all the other methods including a couple of other list methods have it?","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4c2b198b6f19b0d89ae8391b7322dae877471f1a","unresolved":false,"context_lines":[{"line_number":1508,"context_line":"        return self.list(\u0027service_providers\u0027, self.service_providers_path,"},{"line_number":1509,"context_line":"                         retrieve_all, **_params)"},{"line_number":1510,"context_line":""},{"line_number":1511,"context_line":"    def list_credentials(self, **_params):"},{"line_number":1512,"context_line":"        \"\"\"Fetch a list of all credentials for a tenant.\"\"\""},{"line_number":1513,"context_line":"        return self.get(self.credentials_path, params\u003d_params)"},{"line_number":1514,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_c4130a64","line":1511,"in_reply_to":"ba15a1d1_97d01055","updated":"2015-09-23 16:03:41.000000000","message":"No clue :( May be legacy. I could not any find any difference between \u0027_param\u0027 and \u0027param\u0027.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b913da995d70839b9879d0f72f81db7f2b8277c8","unresolved":false,"context_lines":[{"line_number":1508,"context_line":"        return self.list(\u0027service_providers\u0027, self.service_providers_path,"},{"line_number":1509,"context_line":"                         retrieve_all, **_params)"},{"line_number":1510,"context_line":""},{"line_number":1511,"context_line":"    def list_credentials(self, **_params):"},{"line_number":1512,"context_line":"        \"\"\"Fetch a list of all credentials for a tenant.\"\"\""},{"line_number":1513,"context_line":"        return self.get(self.credentials_path, params\u003d_params)"},{"line_number":1514,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_c8f5e1cb","line":1511,"in_reply_to":"ba15a1d1_c4130a64","updated":"2015-11-13 04:53:42.000000000","message":"It is actually legacy ...\nAnd I agree it should have the decorator call","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"742cc038a0015be3eb65686504fcf0044a4da0b0","unresolved":false,"context_lines":[{"line_number":1741,"context_line":"        return self.delete(self.qos_bandwidth_limit_rule_path %"},{"line_number":1742,"context_line":"                           (policy, rule))"},{"line_number":1743,"context_line":""},{"line_number":1744,"context_line":"    def list_bgp_speakers(self, retrieve_all\u003dTrue, **_params):"},{"line_number":1745,"context_line":"        \"\"\"Fetches a list of all bgp_speakers for a tenant.\"\"\""},{"line_number":1746,"context_line":"        # Pass filters in \"params\" argument to do_request"},{"line_number":1747,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_fd675f23","line":1744,"updated":"2015-09-24 14:26:38.000000000","message":"Why no @APIParamsCall decorator on this method?","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"59501744f4c428aca82ceccb1fbaece4cb74253b","unresolved":false,"context_lines":[{"line_number":1741,"context_line":"        return self.delete(self.qos_bandwidth_limit_rule_path %"},{"line_number":1742,"context_line":"                           (policy, rule))"},{"line_number":1743,"context_line":""},{"line_number":1744,"context_line":"    def list_bgp_speakers(self, retrieve_all\u003dTrue, **_params):"},{"line_number":1745,"context_line":"        \"\"\"Fetches a list of all bgp_speakers for a tenant.\"\"\""},{"line_number":1746,"context_line":"        # Pass filters in \"params\" argument to do_request"},{"line_number":1747,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_264e28c2","line":1744,"in_reply_to":"9a1a9d01_fd675f23","updated":"2015-09-24 15:14:17.000000000","message":"Missed ;)","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"4eca6e501074c524593f4d5e656c6d370569f12b","unresolved":false,"context_lines":[{"line_number":1831,"context_line":"        self._register_extensions(self.version)"},{"line_number":1832,"context_line":""},{"line_number":1833,"context_line":"    def extend_show(self, resource_plural, path, parent_resource):"},{"line_number":1834,"context_line":"        def _fx(obj, **_params):"},{"line_number":1835,"context_line":"            return self.show_ext(path, obj, **_params)"},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"        def _parent_fx(parent_id, obj, **_params):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_f7edccb7","line":1834,"updated":"2015-09-22 18:44:08.000000000","message":"What does fx stand for? I\u0027m not clear on what this section of code is about.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4c2b198b6f19b0d89ae8391b7322dae877471f1a","unresolved":false,"context_lines":[{"line_number":1831,"context_line":"        self._register_extensions(self.version)"},{"line_number":1832,"context_line":""},{"line_number":1833,"context_line":"    def extend_show(self, resource_plural, path, parent_resource):"},{"line_number":1834,"context_line":"        def _fx(obj, **_params):"},{"line_number":1835,"context_line":"            return self.show_ext(path, obj, **_params)"},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"        def _parent_fx(parent_id, obj, **_params):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_447b7abe","line":1834,"in_reply_to":"ba15a1d1_f7edccb7","updated":"2015-09-23 16:03:41.000000000","message":"This code handles cli-extensions registered to neutron-client.","commit_id":"e60ecf4677eb2cb713eb694b8af2dd70ececa0a9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":1357,"context_line":""},{"line_number":1358,"context_line":"    @APIParamsCall"},{"line_number":1359,"context_line":"    def list_dragents_hosting_bgp_speaker(self, bgp_speaker, **_params):"},{"line_number":1360,"context_line":"        \"\"\"Fetches the list of DR agents hosting BGP speaker.\"\"\""},{"line_number":1361,"context_line":"        return self.get((self.bgp_speaker_path + self.BGP_DRAGENTS)"},{"line_number":1362,"context_line":"                        % bgp_speaker, params\u003d_params)"},{"line_number":1363,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_29e8297c","line":1360,"updated":"2016-02-03 13:57:44.000000000","message":"\"\"\"Fetches a list of DR agents hosting a BGP speaker.\"\"\"","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":1357,"context_line":""},{"line_number":1358,"context_line":"    @APIParamsCall"},{"line_number":1359,"context_line":"    def list_dragents_hosting_bgp_speaker(self, bgp_speaker, **_params):"},{"line_number":1360,"context_line":"        \"\"\"Fetches the list of DR agents hosting BGP speaker.\"\"\""},{"line_number":1361,"context_line":"        return self.get((self.bgp_speaker_path + self.BGP_DRAGENTS)"},{"line_number":1362,"context_line":"                        % bgp_speaker, params\u003d_params)"},{"line_number":1363,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_e8001004","line":1360,"in_reply_to":"5a5ae5dd_29e8297c","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":1363,"context_line":""},{"line_number":1364,"context_line":"    @APIParamsCall"},{"line_number":1365,"context_line":"    def add_bgp_speaker_to_dragent(self, bgp_dragent, body):"},{"line_number":1366,"context_line":"        \"\"\"Adds a BGP speaker to the dr agent.\"\"\""},{"line_number":1367,"context_line":"        return self.post((self.agent_path + self.BGP_DRINSTANCES)"},{"line_number":1368,"context_line":"                         % bgp_dragent, body\u003dbody)"},{"line_number":1369,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_c955d51d","line":1366,"range":{"start_line":1366,"start_character":42,"end_line":1366,"end_character":43},"updated":"2016-02-03 13:57:44.000000000","message":"\"\"\"Adds a BGP speaker to DR agent.\"\"\"","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":1363,"context_line":""},{"line_number":1364,"context_line":"    @APIParamsCall"},{"line_number":1365,"context_line":"    def add_bgp_speaker_to_dragent(self, bgp_dragent, body):"},{"line_number":1366,"context_line":"        \"\"\"Adds a BGP speaker to the dr agent.\"\"\""},{"line_number":1367,"context_line":"        return self.post((self.agent_path + self.BGP_DRINSTANCES)"},{"line_number":1368,"context_line":"                         % bgp_dragent, body\u003dbody)"},{"line_number":1369,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_c333b7f4","line":1366,"range":{"start_line":1366,"start_character":42,"end_line":1366,"end_character":43},"in_reply_to":"5a5ae5dd_c955d51d","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":"    @APIParamsCall"},{"line_number":1371,"context_line":"    def remove_bgp_speaker_from_dragent(self, bgp_dragent, bgpspeaker_id):"},{"line_number":1372,"context_line":"        \"\"\"Remove a BGP speaker from the dr agent.\"\"\""},{"line_number":1373,"context_line":"        return self.delete((self.agent_path + self.BGP_DRINSTANCES + \"/%s\")"},{"line_number":1374,"context_line":"                           % (bgp_dragent, bgpspeaker_id))"},{"line_number":1375,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_ac4bc758","line":1372,"updated":"2016-02-03 13:57:44.000000000","message":"\"\"\"Remove a BGP speaker from DR agent.\"\"","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":1369,"context_line":""},{"line_number":1370,"context_line":"    @APIParamsCall"},{"line_number":1371,"context_line":"    def remove_bgp_speaker_from_dragent(self, bgp_dragent, bgpspeaker_id):"},{"line_number":1372,"context_line":"        \"\"\"Remove a BGP speaker from the dr agent.\"\"\""},{"line_number":1373,"context_line":"        return self.delete((self.agent_path + self.BGP_DRINSTANCES + \"/%s\")"},{"line_number":1374,"context_line":"                           % (bgp_dragent, bgpspeaker_id))"},{"line_number":1375,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_e32ef38a","line":1372,"in_reply_to":"5a5ae5dd_ac4bc758","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":1375,"context_line":""},{"line_number":1376,"context_line":"    @APIParamsCall"},{"line_number":1377,"context_line":"    def list_bgp_speaker_on_dragent(self, bgp_dragent, **_params):"},{"line_number":1378,"context_line":"        \"\"\"Fetches the list of BGP speakers hosted by a dr agent.\"\"\""},{"line_number":1379,"context_line":"        return self.get((self.agent_path + self.BGP_DRINSTANCES)"},{"line_number":1380,"context_line":"                        % bgp_dragent, params\u003d_params)"},{"line_number":1381,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_8c87eb60","line":1378,"range":{"start_line":1378,"start_character":8,"end_line":1378,"end_character":63},"updated":"2016-02-03 13:57:44.000000000","message":"\"\"\"Fetches a list of BGP speakers hosted by a DR agent.\"\"\"","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":1375,"context_line":""},{"line_number":1376,"context_line":"    @APIParamsCall"},{"line_number":1377,"context_line":"    def list_bgp_speaker_on_dragent(self, bgp_dragent, **_params):"},{"line_number":1378,"context_line":"        \"\"\"Fetches the list of BGP speakers hosted by a dr agent.\"\"\""},{"line_number":1379,"context_line":"        return self.get((self.agent_path + self.BGP_DRINSTANCES)"},{"line_number":1380,"context_line":"                        % bgp_dragent, params\u003d_params)"},{"line_number":1381,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_03b30f51","line":1378,"range":{"start_line":1378,"start_character":8,"end_line":1378,"end_character":63},"in_reply_to":"5a5ae5dd_8c87eb60","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":1729,"context_line":""},{"line_number":1730,"context_line":"    @APIParamsCall"},{"line_number":1731,"context_line":"    def list_bgp_speakers(self, retrieve_all\u003dTrue, **_params):"},{"line_number":1732,"context_line":"        \"\"\"Fetches a list of all bgp_speakers for a tenant.\"\"\""},{"line_number":1733,"context_line":"        # Pass filters in \"params\" argument to do_request"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"        return self.list(\u0027bgp_speakers\u0027, self.bgp_speakers_path, retrieve_all,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_89091d98","line":1732,"range":{"start_line":1732,"start_character":33,"end_line":1732,"end_character":45},"updated":"2016-02-03 13:57:44.000000000","message":"\"\"\"Fetches a list of all BGP speakers for a tenant.\"\"\"","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":1729,"context_line":""},{"line_number":1730,"context_line":"    @APIParamsCall"},{"line_number":1731,"context_line":"    def list_bgp_speakers(self, retrieve_all\u003dTrue, **_params):"},{"line_number":1732,"context_line":"        \"\"\"Fetches a list of all bgp_speakers for a tenant.\"\"\""},{"line_number":1733,"context_line":"        # Pass filters in \"params\" argument to do_request"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"        return self.list(\u0027bgp_speakers\u0027, self.bgp_speakers_path, retrieve_all,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_23dc0b72","line":1732,"range":{"start_line":1732,"start_character":33,"end_line":1732,"end_character":45},"in_reply_to":"5a5ae5dd_89091d98","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":1737,"context_line":""},{"line_number":1738,"context_line":"    @APIParamsCall"},{"line_number":1739,"context_line":"    def show_bgp_speaker(self, bgp_speaker_id, **_params):"},{"line_number":1740,"context_line":"        \"\"\"Fetches information of a certain bgp_speaker.\"\"\""},{"line_number":1741,"context_line":"        return self.get(self.bgp_speaker_path % (bgp_speaker_id),"},{"line_number":1742,"context_line":"                        params\u003d_params)"},{"line_number":1743,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_493a4538","line":1740,"updated":"2016-02-03 13:57:44.000000000","message":"%s/bgp_speakers/BGP speaker/g","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":1737,"context_line":""},{"line_number":1738,"context_line":"    @APIParamsCall"},{"line_number":1739,"context_line":"    def show_bgp_speaker(self, bgp_speaker_id, **_params):"},{"line_number":1740,"context_line":"        \"\"\"Fetches information of a certain bgp_speaker.\"\"\""},{"line_number":1741,"context_line":"        return self.get(self.bgp_speaker_path % (bgp_speaker_id),"},{"line_number":1742,"context_line":"                        params\u003d_params)"},{"line_number":1743,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_c3e65743","line":1740,"in_reply_to":"5a5ae5dd_493a4538","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":1764,"context_line":""},{"line_number":1765,"context_line":"    @APIParamsCall"},{"line_number":1766,"context_line":"    def remove_peer_from_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1767,"context_line":"        \"\"\"Remove a peer from a BGP Speaker.\"\"\""},{"line_number":1768,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1769,"context_line":"                        \"/remove_bgp_peer\", body\u003dbody)"},{"line_number":1770,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_4c1493f4","line":1767,"updated":"2016-02-03 13:57:44.000000000","message":"%s/Speaker/speaker/g","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":1764,"context_line":""},{"line_number":1765,"context_line":"    @APIParamsCall"},{"line_number":1766,"context_line":"    def remove_peer_from_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1767,"context_line":"        \"\"\"Remove a peer from a BGP Speaker.\"\"\""},{"line_number":1768,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1769,"context_line":"                        \"/remove_bgp_peer\", body\u003dbody)"},{"line_number":1770,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_8315bf9c","line":1767,"in_reply_to":"5a5ae5dd_4c1493f4","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":1776,"context_line":""},{"line_number":1777,"context_line":"    @APIParamsCall"},{"line_number":1778,"context_line":"    def remove_network_from_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1779,"context_line":"        \"\"\"Remove a network from a BGP Speaker.\"\"\""},{"line_number":1780,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1781,"context_line":"                        \"/remove_gateway_network\", body\u003dbody)"},{"line_number":1782,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_cc0083ad","line":1779,"updated":"2016-02-03 13:57:44.000000000","message":"%s/Speaker/speaker/g","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":1776,"context_line":""},{"line_number":1777,"context_line":"    @APIParamsCall"},{"line_number":1778,"context_line":"    def remove_network_from_bgp_speaker(self, speaker_id, body\u003dNone):"},{"line_number":1779,"context_line":"        \"\"\"Remove a network from a BGP Speaker.\"\"\""},{"line_number":1780,"context_line":"        return self.put((self.bgp_speaker_path % speaker_id) +"},{"line_number":1781,"context_line":"                        \"/remove_gateway_network\", body\u003dbody)"},{"line_number":1782,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_a318fbd3","line":1779,"in_reply_to":"5a5ae5dd_cc0083ad","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":1782,"context_line":""},{"line_number":1783,"context_line":"    @APIParamsCall"},{"line_number":1784,"context_line":"    def list_route_advertised_from_bgp_speaker(self, speaker_id, **_params):"},{"line_number":1785,"context_line":"        \"\"\"List routes advertised by BGP Speaker.\"\"\""},{"line_number":1786,"context_line":"        return self.get((self.bgp_speaker_path % speaker_id) +"},{"line_number":1787,"context_line":"                        \"/get_advertised_routes\", params\u003d_params)"},{"line_number":1788,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_8c312ba5","line":1785,"range":{"start_line":1785,"start_character":41,"end_line":1785,"end_character":48},"updated":"2016-02-03 13:57:44.000000000","message":"%s/Speaker/speaker/g","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":1782,"context_line":""},{"line_number":1783,"context_line":"    @APIParamsCall"},{"line_number":1784,"context_line":"    def list_route_advertised_from_bgp_speaker(self, speaker_id, **_params):"},{"line_number":1785,"context_line":"        \"\"\"List routes advertised by BGP Speaker.\"\"\""},{"line_number":1786,"context_line":"        return self.get((self.bgp_speaker_path % speaker_id) +"},{"line_number":1787,"context_line":"                        \"/get_advertised_routes\", params\u003d_params)"},{"line_number":1788,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_630e838d","line":1785,"range":{"start_line":1785,"start_character":41,"end_line":1785,"end_character":48},"in_reply_to":"5a5ae5dd_8c312ba5","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"    @APIParamsCall"},{"line_number":1790,"context_line":"    def list_bgp_peers(self, **_params):"},{"line_number":1791,"context_line":"        \"\"\"Fetch all configured BGP peers.\"\"\""},{"line_number":1792,"context_line":"        return self.get(self.bgp_peers_path, params\u003d_params)"},{"line_number":1793,"context_line":""},{"line_number":1794,"context_line":"    @APIParamsCall"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_cc1723ec","line":1791,"updated":"2016-02-03 13:57:44.000000000","message":"\"\"\"Fetches a list of all BGP peers.\"\"\"","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"    @APIParamsCall"},{"line_number":1790,"context_line":"    def list_bgp_peers(self, **_params):"},{"line_number":1791,"context_line":"        \"\"\"Fetch all configured BGP peers.\"\"\""},{"line_number":1792,"context_line":"        return self.get(self.bgp_peers_path, params\u003d_params)"},{"line_number":1793,"context_line":""},{"line_number":1794,"context_line":"    @APIParamsCall"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_e371130d","line":1791,"in_reply_to":"5a5ae5dd_cc1723ec","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb5b20ecf11b690f4ee87d1a4e4eea6fb673e3dd","unresolved":false,"context_lines":[{"line_number":1793,"context_line":""},{"line_number":1794,"context_line":"    @APIParamsCall"},{"line_number":1795,"context_line":"    def show_bgp_peer(self, peer_id, **_params):"},{"line_number":1796,"context_line":"        \"\"\"Fetch the details for the queried BGP peer.\"\"\""},{"line_number":1797,"context_line":"        return self.get(self.bgp_peer_path % peer_id,"},{"line_number":1798,"context_line":"                        params\u003d_params)"},{"line_number":1799,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_acf187cf","line":1796,"updated":"2016-02-03 13:57:44.000000000","message":"\"\"\"Fetches information of a certain BGP peer.\"\"\"","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b5e85c41411c5bda01a258422abd58e4f15c031a","unresolved":false,"context_lines":[{"line_number":1793,"context_line":""},{"line_number":1794,"context_line":"    @APIParamsCall"},{"line_number":1795,"context_line":"    def show_bgp_peer(self, peer_id, **_params):"},{"line_number":1796,"context_line":"        \"\"\"Fetch the details for the queried BGP peer.\"\"\""},{"line_number":1797,"context_line":"        return self.get(self.bgp_peer_path % peer_id,"},{"line_number":1798,"context_line":"                        params\u003d_params)"},{"line_number":1799,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a5ae5dd_032a2fdb","line":1796,"in_reply_to":"5a5ae5dd_acf187cf","updated":"2016-02-08 12:02:41.000000000","message":"Done","commit_id":"6daa66d72b491a1927159449a072a33219509fb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"bf29b6d521e866423c79edce26b3d271fdd63439","unresolved":false,"context_lines":[{"line_number":1358,"context_line":""},{"line_number":1359,"context_line":"    @APIParamsCall"},{"line_number":1360,"context_line":"    def list_dragents_hosting_bgp_speaker(self, bgp_speaker, **_params):"},{"line_number":1361,"context_line":"        \"\"\"Fetches a list of DR agents hosting a BGP speaker.\"\"\""},{"line_number":1362,"context_line":"        return self.get((self.bgp_speaker_path + self.BGP_DRAGENTS)"},{"line_number":1363,"context_line":"                        % bgp_speaker, params\u003d_params)"},{"line_number":1364,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"dae33548_22af8c95","line":1361,"updated":"2016-02-16 03:23:03.000000000","message":"let\u0027s expand DR to Dynamic routing. Plz change all @ all the places.","commit_id":"e68123a026f6e470f889b8804fbabcd1b1331601"}],"releasenotes/notes/bgp-dynamic-routing-b97a1c81d3007049.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1b63f7dd8349d018f3636a18333ab6f8fc3c7563","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Addition of BGP dynamic routing commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    CLI support for the \"bgp-speaker\", \"bgp-peer\" and \"bgp-dragent\" helps"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"bae84128_42fa2776","line":3,"updated":"2016-02-23 15:20:41.000000000","message":"I think there is no need to add an item to \u0027prelude\u0027.\n\nhttp://docs-draft.openstack.org/56/205756/21/check/gate-python-neutronclient-releasenotes/0fa4d00//releasenotes/build/html/","commit_id":"2ffa2e4f2cceebcc1a89c42439dde24b3251dbb2"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c35b103e717acc49caaa9c39bfee7ec8cd2caefe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Addition of BGP dynamic routing commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    CLI support for the \"bgp-speaker\", \"bgp-peer\" and \"bgp-dragent\" helps"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"bae84128_8a4a4153","line":3,"in_reply_to":"bae84128_42fa2776","updated":"2016-02-24 15:09:04.000000000","message":"Will remove","commit_id":"2ffa2e4f2cceebcc1a89c42439dde24b3251dbb2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1b63f7dd8349d018f3636a18333ab6f8fc3c7563","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Addition of BGP dynamic routing commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    CLI support for the \"bgp-speaker\", \"bgp-peer\" and \"bgp-dragent\" helps"},{"line_number":7,"context_line":"    advertising neutron fixed-ips and dvr host routes using BGP."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"bae84128_424187a8","line":6,"updated":"2016-02-23 15:20:41.000000000","message":"--\u003e ``bgp-speaker``\n\nfor consistency with other entries.","commit_id":"2ffa2e4f2cceebcc1a89c42439dde24b3251dbb2"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c35b103e717acc49caaa9c39bfee7ec8cd2caefe","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Addition of BGP dynamic routing commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    CLI support for the \"bgp-speaker\", \"bgp-peer\" and \"bgp-dragent\" helps"},{"line_number":7,"context_line":"    advertising neutron fixed-ips and dvr host routes using BGP."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"bae84128_caeba911","line":6,"in_reply_to":"bae84128_424187a8","updated":"2016-02-24 15:09:04.000000000","message":"Sorry I didn\u0027t get you. Can you plz let me know what you exactly mean?","commit_id":"2ffa2e4f2cceebcc1a89c42439dde24b3251dbb2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7795218d9b23fc2ed8d425cbba5cea32d2a3cef2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Addition of BGP dynamic routing commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    CLI support for the \"bgp-speaker\", \"bgp-peer\" and \"bgp-dragent\" helps"},{"line_number":7,"context_line":"    advertising neutron fixed-ips and dvr host routes using BGP."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"bae84128_85c35237","line":6,"in_reply_to":"bae84128_caeba911","updated":"2016-02-24 15:39:00.000000000","message":"If you see http://docs-draft.openstack.org/56/205756/21/check/gate-python-neutronclient-releasenotes/0fa4d00//releasenotes/build/html/,\ncommand names like bgp-speaker, bgp-peer, bgp-dragent are rendered in a different way from command names in other notes.\n\nIt is a nit and I don\u0027t think you need to respin the patch only due to this.","commit_id":"2ffa2e4f2cceebcc1a89c42439dde24b3251dbb2"}]}
