)]}'
{"quantumclient/quantum/v2_0/nvp_qos_queue.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9d115de0fb110b2adc17516c3f4d4c5318c514e4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack LLC."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FKA8%3D","line":1,"updated":"2013-02-05 10:53:23.000000000","message":"2013","commit_id":"967024f482f38addcf28ce4e4f478af6a45d25a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \"\"\"List queues that belong to a given tenant.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    resource \u003d \u0027qos_queue\u0027"},{"line_number":27,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.ListQueue\u0027)"},{"line_number":28,"context_line":"    _formatters \u003d {}"},{"line_number":29,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027name\u0027, \u0027min\u0027, \u0027max\u0027,"},{"line_number":30,"context_line":"                    \u0027qos_marking\u0027, \u0027dscp\u0027, \u0027default\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7dU%3D","line":27,"updated":"2013-02-14 02:54:56.000000000","message":"ListQueue -\u003e ListQoSQueue","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"34e5642874c8573010c3f4b269a838c13a2dac95","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    \"\"\"List queues that belong to a given tenant.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    resource \u003d \u0027qos_queue\u0027"},{"line_number":27,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.ListQueue\u0027)"},{"line_number":28,"context_line":"    _formatters \u003d {}"},{"line_number":29,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027name\u0027, \u0027min\u0027, \u0027max\u0027,"},{"line_number":30,"context_line":"                    \u0027qos_marking\u0027, \u0027dscp\u0027, \u0027default\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7VA%3D","line":27,"in_reply_to":"AAAAM3%2F%2B7dU%3D","updated":"2013-02-14 05:09:34.000000000","message":"Done","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class ShowQoSQueue(quantumv20.ShowCommand):"},{"line_number":34,"context_line":"    \"\"\"Show information of a given Queue.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    resource \u003d \u0027qos_queue\u0027"},{"line_number":37,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.ShowQueue\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7dE%3D","line":34,"updated":"2013-02-14 02:54:56.000000000","message":"Queue -\u003e queue","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"34e5642874c8573010c3f4b269a838c13a2dac95","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class ShowQoSQueue(quantumv20.ShowCommand):"},{"line_number":34,"context_line":"    \"\"\"Show information of a given Queue.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    resource \u003d \u0027qos_queue\u0027"},{"line_number":37,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.ShowQueue\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7U8%3D","line":34,"in_reply_to":"AAAAM3%2F%2B7dE%3D","updated":"2013-02-14 05:09:34.000000000","message":"Done","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\"Show information of a given Queue.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    resource \u003d \u0027qos_queue\u0027"},{"line_number":37,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.ShowQueue\u0027)"},{"line_number":38,"context_line":"    allow_names \u003d True"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7dQ%3D","line":37,"updated":"2013-02-14 02:54:56.000000000","message":"ShowQueue -\u003e ShowQoSQueue","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \"\"\"Create a queue.\"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    resource \u003d \u0027qos_queue\u0027"},{"line_number":45,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.CreateQueue\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":48,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7dM%3D","line":45,"updated":"2013-02-14 02:54:56.000000000","message":"CreateQueue -\u003e CreateQoSQueue","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"34e5642874c8573010c3f4b269a838c13a2dac95","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    \"\"\"Create a queue.\"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    resource \u003d \u0027qos_queue\u0027"},{"line_number":45,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.CreateQueue\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":48,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7U4%3D","line":45,"in_reply_to":"AAAAM3%2F%2B7dM%3D","updated":"2013-02-14 05:09:34.000000000","message":"Done","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":48,"context_line":"        parser.add_argument("},{"line_number":49,"context_line":"            \u0027name\u0027, metavar\u003d\u0027name\u0027,"},{"line_number":50,"context_line":"            help\u003d\u0027Name of queue\u0027)"},{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \u0027--min\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7cw%3D","line":49,"updated":"2013-02-14 02:54:56.000000000","message":"Make metavar uppercase. It is the convention in quantumclient (though there are several number of lower case metavars).","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"34e5642874c8573010c3f4b269a838c13a2dac95","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":48,"context_line":"        parser.add_argument("},{"line_number":49,"context_line":"            \u0027name\u0027, metavar\u003d\u0027name\u0027,"},{"line_number":50,"context_line":"            help\u003d\u0027Name of queue\u0027)"},{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \u0027--min\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7Uw%3D","line":49,"in_reply_to":"AAAAM3%2F%2B7cw%3D","updated":"2013-02-14 05:09:34.000000000","message":"Done","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \u0027name\u0027, metavar\u003d\u0027name\u0027,"},{"line_number":50,"context_line":"            help\u003d\u0027Name of queue\u0027)"},{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \u0027--min\u0027,"},{"line_number":53,"context_line":"            help\u003d\u0027min bandwidth rate\u0027),"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--max\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7ck%3D","line":52,"updated":"2013-02-14 02:54:56.000000000","message":"min-rate is easier to understand.","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"34e5642874c8573010c3f4b269a838c13a2dac95","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \u0027name\u0027, metavar\u003d\u0027name\u0027,"},{"line_number":50,"context_line":"            help\u003d\u0027Name of queue\u0027)"},{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \u0027--min\u0027,"},{"line_number":53,"context_line":"            help\u003d\u0027min bandwidth rate\u0027),"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--max\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7Us%3D","line":52,"in_reply_to":"AAAAM3%2F%2B7ck%3D","updated":"2013-02-14 05:09:34.000000000","message":"Done","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027--min\u0027,"},{"line_number":53,"context_line":"            help\u003d\u0027min bandwidth rate\u0027),"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--max\u0027,"},{"line_number":56,"context_line":"            help\u003d\u0027max bandwidth rate\u0027),"},{"line_number":57,"context_line":"        parser.add_argument("},{"line_number":58,"context_line":"            \u0027--qos_marking\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7cg%3D","line":55,"updated":"2013-02-14 02:54:56.000000000","message":"Ditto","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"34e5642874c8573010c3f4b269a838c13a2dac95","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027--min\u0027,"},{"line_number":53,"context_line":"            help\u003d\u0027min bandwidth rate\u0027),"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--max\u0027,"},{"line_number":56,"context_line":"            help\u003d\u0027max bandwidth rate\u0027),"},{"line_number":57,"context_line":"        parser.add_argument("},{"line_number":58,"context_line":"            \u0027--qos_marking\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7Uo%3D","line":55,"in_reply_to":"AAAAM3%2F%2B7cg%3D","updated":"2013-02-14 05:09:34.000000000","message":"Done","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":55,"context_line":"            \u0027--max\u0027,"},{"line_number":56,"context_line":"            help\u003d\u0027max bandwidth rate\u0027),"},{"line_number":57,"context_line":"        parser.add_argument("},{"line_number":58,"context_line":"            \u0027--qos_marking\u0027,"},{"line_number":59,"context_line":"            help\u003d\u0027qos marking untrusted/trusted\u0027),"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027--default\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7co%3D","line":58,"updated":"2013-02-14 02:54:56.000000000","message":"Use \u0027-\u0027 instead of \u0027_\u0027","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"34e5642874c8573010c3f4b269a838c13a2dac95","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            \u0027--max\u0027,"},{"line_number":56,"context_line":"            help\u003d\u0027max bandwidth rate\u0027),"},{"line_number":57,"context_line":"        parser.add_argument("},{"line_number":58,"context_line":"            \u0027--qos_marking\u0027,"},{"line_number":59,"context_line":"            help\u003d\u0027qos marking untrusted/trusted\u0027),"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027--default\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7Uk%3D","line":58,"in_reply_to":"AAAAM3%2F%2B7co%3D","updated":"2013-02-14 05:09:34.000000000","message":"Done","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027--dscp\u0027,"},{"line_number":67,"context_line":"            help\u003d\u0027Differentiated Services Code Point\u0027),"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def args2body(self, parsed_args):"},{"line_number":70,"context_line":"        body \u003d {\u0027qos_queue\u0027: {"},{"line_number":71,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":72,"context_line":"            \u0027default\u0027: parsed_args.default}}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7cA%3D","line":69,"updated":"2013-02-14 02:54:56.000000000","message":"Consider the following style.\nI am not a fan of many repetitions of body[xxxx].update(yyy) :-(\n\n    params \u003d {\u0027name\u0027: parsed_args.name,\n              \u0027default\u0027: parsed_args.default}\n    if parsed_args.min:\n        params[\u0027min\u0027] \u003d parsed_args.min\n    if parsed_args.max:\n        params[\u0027max\u0027] \u003d parsed_args.max\n    ...\n\n    if parsed_args.tenant_id:\n        params[\u0027tenant_id\u0027] \u003d parsed_args.tenant_id\n\n    return {\u0027qos_queue\u0027: params}","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"34e5642874c8573010c3f4b269a838c13a2dac95","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            \u0027--dscp\u0027,"},{"line_number":67,"context_line":"            help\u003d\u0027Differentiated Services Code Point\u0027),"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def args2body(self, parsed_args):"},{"line_number":70,"context_line":"        body \u003d {\u0027qos_queue\u0027: {"},{"line_number":71,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":72,"context_line":"            \u0027default\u0027: parsed_args.default}}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7UA%3D","line":69,"in_reply_to":"AAAAM3%2F%2B7cA%3D","updated":"2013-02-14 05:09:34.000000000","message":"Done","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":90,"context_line":"class DeleteQoSQueue(quantumv20.DeleteCommand):"},{"line_number":91,"context_line":"    \"\"\"Delete a given queue.\"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.DeleteQueue\u0027)"},{"line_number":94,"context_line":"    resource \u003d \u0027qos_queue\u0027"},{"line_number":95,"context_line":"    allow_names \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7b8%3D","line":93,"updated":"2013-02-14 02:54:56.000000000","message":"DeleteQoSQueue","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"34e5642874c8573010c3f4b269a838c13a2dac95","unresolved":false,"context_lines":[{"line_number":90,"context_line":"class DeleteQoSQueue(quantumv20.DeleteCommand):"},{"line_number":91,"context_line":"    \"\"\"Delete a given queue.\"\"\""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.DeleteQueue\u0027)"},{"line_number":94,"context_line":"    resource \u003d \u0027qos_queue\u0027"},{"line_number":95,"context_line":"    allow_names \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7T8%3D","line":93,"in_reply_to":"AAAAM3%2F%2B7b8%3D","updated":"2013-02-14 05:09:34.000000000","message":"Done","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \u0027name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":50,"context_line":"            help\u003d\u0027Name of queue\u0027)"},{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \u0027--min\u0027,"},{"line_number":53,"context_line":"            help\u003d\u0027min-rate\u0027),"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--max\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B5Vo%3D","line":52,"updated":"2013-02-15 09:55:06.000000000","message":"--min-rate is easier to understand. According to your comment in patch set 1, you seemed to change it but it is still \"--min\".\n\nThis extension is now supported only by NVP plugin, but I saw the comment from you or Nicira guyes that you have a plan to make this extension a general one. If so \"--min-rate\" is better I believe.","commit_id":"aa2c9628dbd94871936fa6e10107e46691c038e4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \u0027name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":50,"context_line":"            help\u003d\u0027Name of queue\u0027)"},{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \u0027--min\u0027,"},{"line_number":53,"context_line":"            help\u003d\u0027min-rate\u0027),"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--max\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B2T8%3D","line":52,"in_reply_to":"AAAAM3%2F%2B2xw%3D","updated":"2013-02-17 07:07:04.000000000","message":"I understand the situation. Let\u0027s go.\n\nMy suggestion does not necessarily require the API change. We can split the discussion point into API attributes and CLI parameters. Of course it would be better if both names are same. My comments is mainly about CLI option name.","commit_id":"aa2c9628dbd94871936fa6e10107e46691c038e4"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"34e5642874c8573010c3f4b269a838c13a2dac95","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \u0027name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":50,"context_line":"            help\u003d\u0027Name of queue\u0027)"},{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \u0027--min\u0027,"},{"line_number":53,"context_line":"            help\u003d\u0027min-rate\u0027),"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--max\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B2xw%3D","line":52,"in_reply_to":"AAAAM3%2F%2B5Vo%3D","updated":"2013-02-16 19:18:26.000000000","message":"Hi, I agree --min/max-rate sounds better but we already ship a version of this where we use min/max so we\u0027d like to keep --min/max just to avoid api incompatibilities on our end for grizzly. If in Havana a plugin wants to implement qos we can look at possibly changing our api to merge the two together since i\u0027m sure other changes may be desired.  IMO changing the api now doesn\u0027t buy us anything if we are going to have to change it again later.","commit_id":"aa2c9628dbd94871936fa6e10107e46691c038e4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027--min\u0027,"},{"line_number":53,"context_line":"            help\u003d\u0027min-rate\u0027),"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--max\u0027,"},{"line_number":56,"context_line":"            help\u003d\u0027max-rate\u0027),"},{"line_number":57,"context_line":"        parser.add_argument("},{"line_number":58,"context_line":"            \u0027--qos-marking\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2B5Vk%3D","line":55,"updated":"2013-02-15 09:55:06.000000000","message":"Ditto. I prefer to \"--max-rate\"","commit_id":"aa2c9628dbd94871936fa6e10107e46691c038e4"}],"quantumclient/tests/unit/test_cli20_nvp_queue.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2012 Red Hat"},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7bs%3D","line":4,"updated":"2013-02-14 02:54:56.000000000","message":"- 2013\n- Red Hat?","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"34e5642874c8573010c3f4b269a838c13a2dac95","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Copyright 2012 Red Hat"},{"line_number":5,"context_line":"# All Rights Reserved."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7T4%3D","line":4,"in_reply_to":"AAAAM3%2F%2B7bs%3D","updated":"2013-02-14 05:09:34.000000000","message":"Done","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":50,"context_line":"        qos_marking \u003d \u0027untrusted\u0027"},{"line_number":51,"context_line":"        dscp \u003d \u00270\u0027"},{"line_number":52,"context_line":"        args \u003d [\u0027--default\u0027, default, \u0027--min\u0027, min, \u0027--max\u0027, max,"},{"line_number":53,"context_line":"                \u0027--qos_marking\u0027, qos_marking, \u0027--dscp\u0027, dscp, name]"},{"line_number":54,"context_line":"        position_names \u003d [\u0027name\u0027, \u0027default\u0027, \u0027min\u0027, \u0027max\u0027, \u0027qos_marking\u0027,"},{"line_number":55,"context_line":"                          \u0027dscp\u0027]"},{"line_number":56,"context_line":"        position_values \u003d [name, default, min, max, qos_marking, dscp]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7b0%3D","line":53,"updated":"2013-02-14 02:54:56.000000000","message":"--qos-marking","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"34e5642874c8573010c3f4b269a838c13a2dac95","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        qos_marking \u003d \u0027untrusted\u0027"},{"line_number":51,"context_line":"        dscp \u003d \u00270\u0027"},{"line_number":52,"context_line":"        args \u003d [\u0027--default\u0027, default, \u0027--min\u0027, min, \u0027--max\u0027, max,"},{"line_number":53,"context_line":"                \u0027--qos_marking\u0027, qos_marking, \u0027--dscp\u0027, dscp, name]"},{"line_number":54,"context_line":"        position_names \u003d [\u0027name\u0027, \u0027default\u0027, \u0027min\u0027, \u0027max\u0027, \u0027qos_marking\u0027,"},{"line_number":55,"context_line":"                          \u0027dscp\u0027]"},{"line_number":56,"context_line":"        position_values \u003d [name, default, min, max, qos_marking, dscp]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B7T0%3D","line":53,"in_reply_to":"AAAAM3%2F%2B7b0%3D","updated":"2013-02-14 05:09:34.000000000","message":"Done","commit_id":"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"}]}