)]}'
{"id":"openstack%2Fpython-neutronclient~20981","triplet_id":"openstack%2Fpython-neutronclient~master~Ic6d2a13ecb82e7e68b52b3143befb2f34b5e759f","project":"openstack/python-neutronclient","branch":"master","topic":"bp/nvp-qos-extension-client","hashtags":[],"change_id":"Ic6d2a13ecb82e7e68b52b3143befb2f34b5e759f","subject":"Add nvp queue support to client","status":"MERGED","created":"2013-02-17 07:59:25.000000000","updated":"2013-02-17 07:59:25.000000000","submitted":"2013-02-17 07:59:25.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":28,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a58bd846d3beee7b5c03bb498640ac391fe3bd48","_number":20981,"virtual_id_number":20981,"owner":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":2,"date":"2013-02-17 07:59:25.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"all":[{"value":0,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},{"value":2,"date":"2013-02-17 07:59:25.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"date":"2013-02-17 07:59:25.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":2,"date":"2013-02-17 07:59:25.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"all":[{"value":0,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},{"value":1,"date":"2013-02-17 07:59:25.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"date":"2013-02-17 07:59:25.000000000","_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":0,"date":"2013-02-17 07:59:25.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-02-17 07:59:25.000000000","updated_by":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"reviewer":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"state":"REVIEWER"},{"updated":"2013-02-17 07:59:25.000000000","updated_by":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"reviewer":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"state":"REVIEWER"},{"updated":"2013-02-17 07:59:25.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2013-02-17 07:59:25.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2013-02-17 07:59:25.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"485dded8685f80e201cf9a220c97b186cc931054","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-17 07:59:25.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20981/1/check/gate-python-quantumclient-docs/290 : SUCCESS\n- http://logs.openstack.org/20981/1/check/gate-python-quantumclient-pep8/372 : SUCCESS\n- http://logs.openstack.org/20981/1/check/gate-python-quantumclient-python26/351 : SUCCESS\n- http://logs.openstack.org/20981/1/check/gate-python-quantumclient-python27/350 : SUCCESS\n- http://logs.openstack.org/20981/1/check/gate-tempest-devstack-vm-full/353 : SUCCESS\n- http://logs.openstack.org/20981/1/check/gate-tempest-devstack-vm-quantum/4153 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"9d115de0fb110b2adc17516c3f4d4c5318c514e4","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-02-17 07:59:25.000000000","message":"Patch Set 1: (1 inline comment)\n\nI have a few issues with this patch:\n1. It would be nice if there was a generic support. I think that we should see if this API suits the other vendors. It does not feel right at the moment.\n2. Does this invoke and extension or is it via the NVP plugin?\nThanks\nGary","accounts_in_message":[],"_revision_number":1},{"id":"34e5642874c8573010c3f4b269a838c13a2dac95","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-17 07:59:25.000000000","message":"Patch Set 1:\n\nHi Gary, \n\nYes this coordinates to this extension  https://review.openstack.org/#/c/20979/ . When I wrote this I tried to make it some what generic. Currently, this is just targeted for used by the nvp plugin (similarly to how the cisco plugin already has it\u0027s own qos extension). If in the future other vendors decide to implement QoS  this extension can be renamed accordingly if it fits their needs.","accounts_in_message":[],"_revision_number":1},{"id":"23025d298b38f45a2c093dc7d9503ceea22896ae","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-17 07:59:25.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20981/2/check/gate-python-quantumclient-pep8/400 : SUCCESS\n- http://logs.openstack.org/20981/2/check/gate-python-quantumclient-docs/318 : SUCCESS\n- http://logs.openstack.org/20981/2/check/gate-python-quantumclient-python26/379 : SUCCESS\n- http://logs.openstack.org/20981/2/check/gate-python-quantumclient-python27/378 : SUCCESS\n- http://logs.openstack.org/20981/2/check/gate-tempest-devstack-vm-full/2658 : SUCCESS\n- http://logs.openstack.org/20981/2/check/gate-tempest-devstack-vm-postgres-full/2384 : SUCCESS\n- http://logs.openstack.org/20981/2/check/gate-tempest-devstack-vm-quantum/6879 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"1e6f337b78bda205bcfa204a9207bd973cab8458","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-02-17 07:59:25.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(12 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"8a7cddf9d7080f67c1a647ab86e74a2734f8704c","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-17 07:59:25.000000000","message":"Patch Set 2: (11 inline comments)\n\nThanks for the review!","accounts_in_message":[],"_revision_number":2},{"id":"674d042862223f5d0868527b4c956deee7d45f16","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-17 07:59:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9dd43b933c608cb68021ecbaabf9c18fb4b75d43","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-17 07:59:25.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/20981/3/check/gate-python-quantumclient-pep8/404 : SUCCESS\n- http://logs.openstack.org/20981/3/check/gate-python-quantumclient-docs/322 : SUCCESS\n- http://logs.openstack.org/20981/3/check/gate-python-quantumclient-python26/383 : SUCCESS\n- http://logs.openstack.org/20981/3/check/gate-python-quantumclient-python27/382 : SUCCESS\n- http://logs.openstack.org/20981/3/check/gate-tempest-devstack-vm-full/2834 : SUCCESS\n- http://logs.openstack.org/20981/3/check/gate-tempest-devstack-vm-postgres-full/2560 : SUCCESS\n- http://logs.openstack.org/20981/3/check/gate-tempest-devstack-vm-quantum/7081 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"d5e5e0e4c627378d2fcbdba4d86d7c3d1b76b068","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-17 07:59:25.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"0c1a7e7fda9e6ec422f89616e06a0dfaab10e246","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-02-17 07:59:25.000000000","message":"Patch Set 3: (2 inline comments)\n\nLet me confirm the comments inline just before approving.\nOtherwise looks good.","accounts_in_message":[],"_revision_number":3},{"id":"8bca70385b7378f1a31762dd7e74fe6943f59cfc","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-02-17 07:59:25.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"fcfd106d6e50c7770db852c82217b757f79fcdba","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-02-17 07:59:25.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"b15342e869a4a4693157ba8d376ab3c46d8e42d7","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-17 07:59:25.000000000","message":"Patch Set 3: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"7b63fdcf4ddbb6c1627562b4b6690cff242071b6","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-17 07:59:25.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"8a629ad9d128a039b8c33bfb577c18b385ec0622","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-17 07:59:25.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/20981/3/gate/gate-python-quantumclient-docs/325 : SUCCESS\n- http://logs.openstack.org/20981/3/gate/gate-python-quantumclient-pep8/407 : SUCCESS\n- http://logs.openstack.org/20981/3/gate/gate-python-quantumclient-python26/386 : SUCCESS\n- http://logs.openstack.org/20981/3/gate/gate-python-quantumclient-python27/385 : SUCCESS\n- http://logs.openstack.org/20981/3/gate/gate-tempest-devstack-vm-full/3408 : SUCCESS\n- http://logs.openstack.org/20981/3/gate/gate-tempest-devstack-vm-postgres-full/3131 : SUCCESS\n- http://logs.openstack.org/20981/3/gate/gate-tempest-devstack-vm-quantum/7758 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"327ca9507487d4c9ccec1ba26fdc70ef11b7ad19","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-17 07:59:25.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"aa2c9628dbd94871936fa6e10107e46691c038e4","revisions":{"967024f482f38addcf28ce4e4f478af6a45d25a1":{"kind":"REWORK","_number":1,"created":"2013-02-17 07:59:25.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/81/20981/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/81/20981/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/20981/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/20981/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/20981/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/81/20981/1"}}},"commit":{"parents":[{"commit":"2bca8ee4407aee03a83592395d3191f097c459a5","subject":"The change implements LBaaS CLI commands.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/2bca8ee4407aee03a83592395d3191f097c459a5"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2012-11-04 01:41:53.000000000","tz":-420},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-01 06:09:40.000000000","tz":-480},"subject":"Add nvp queue support to client","message":"Add nvp queue support to client\n\nThis patch adds the nvp_qos_queue commands to the client\nImplements blueprint nvp-qos-extension-client\n\nChange-Id: Ic6d2a13ecb82e7e68b52b3143befb2f34b5e759f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/967024f482f38addcf28ce4e4f478af6a45d25a1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/967024f482f38addcf28ce4e4f478af6a45d25a1"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"2bca8ee4407aee03a83592395d3191f097c459a5","is_merged_in_target_branch":true,"change_id":"Idaa569024c24955886a836e3dfedd009fed87007","change_number":18387,"patch_set_number":9,"change_status":"MERGED"}],"branch":"refs/heads/master"},"7ab3d42c3018ec2462dc56db07270a2e0c8bafa1":{"kind":"REWORK","_number":2,"created":"2013-02-17 07:59:25.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/81/20981/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/81/20981/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/20981/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/20981/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/20981/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/81/20981/2"}}},"commit":{"parents":[{"commit":"5b9f1911dce3f816bb1645dc7e7bacb3e0989681","subject":"Merge \"Add .coveragerc\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/5b9f1911dce3f816bb1645dc7e7bacb3e0989681"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2012-11-04 01:41:53.000000000","tz":-420},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-13 23:17:56.000000000","tz":-480},"subject":"Add nvp queue support to client","message":"Add nvp queue support to client\n\nThis patch adds the nvp_qos_queue commands to the client\nImplements blueprint nvp-qos-extension-client\n\nChange-Id: Ic6d2a13ecb82e7e68b52b3143befb2f34b5e759f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/7ab3d42c3018ec2462dc56db07270a2e0c8bafa1"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"5b9f1911dce3f816bb1645dc7e7bacb3e0989681","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"aa2c9628dbd94871936fa6e10107e46691c038e4":{"kind":"REWORK","_number":3,"created":"2013-02-17 07:59:25.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/81/20981/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/81/20981/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/20981/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/20981/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/20981/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/81/20981/3"}}},"commit":{"parents":[{"commit":"5b9f1911dce3f816bb1645dc7e7bacb3e0989681","subject":"Merge \"Add .coveragerc\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/5b9f1911dce3f816bb1645dc7e7bacb3e0989681"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2012-11-04 01:41:53.000000000","tz":-420},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-14 16:54:27.000000000","tz":-480},"subject":"Add nvp queue support to client","message":"Add nvp queue support to client\n\nThis patch adds the nvp_qos_queue commands to the client\nImplements blueprint nvp-qos-extension-client\n\nChange-Id: Ic6d2a13ecb82e7e68b52b3143befb2f34b5e759f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/aa2c9628dbd94871936fa6e10107e46691c038e4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/aa2c9628dbd94871936fa6e10107e46691c038e4"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"5b9f1911dce3f816bb1645dc7e7bacb3e0989681","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}