)]}'
{"neutronclient/tests/functional/hooks/gate_hook.sh":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7c43a859d1b5a316900dd9a9528be340f7be491","unresolved":false,"context_lines":[{"line_number":10,"context_line":"if [ \"$VENV\" \u003d\u003d \"dsvm-functional\" ]"},{"line_number":11,"context_line":"then"},{"line_number":12,"context_line":"    export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin neutron-vpnaas git://git.openstack.org/openstack/neutron-vpnaas\""},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a4dcd0f_9806761a","line":13,"updated":"2015-08-13 14:24:28.000000000","message":"I am confused.\n\ngate_hook has a responsibility to run the gate test.\nDon\u0027t we need to run the contents of the original gate_hook [1] ?\n\n[1] http://git.openstack.org/cgit/openstack-infra/devstack-gate/tree/devstack-vm-gate-wrap.sh#n430","commit_id":"11cd0348264cbd712b8e237c935e57f5267b55a8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2209582ba8c92871b70beff4354f0aba8371de49","unresolved":false,"context_lines":[{"line_number":10,"context_line":"if [ \"$VENV\" \u003d\u003d \"dsvm-functional\" ]"},{"line_number":11,"context_line":"then"},{"line_number":12,"context_line":"    export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin neutron-vpnaas git://git.openstack.org/openstack/neutron-vpnaas\""},{"line_number":13,"context_line":"    $BASE/new/devstack-gate/devstack-vm-gate.sh"},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"1a4dcd0f_5b7543ca","line":13,"updated":"2015-08-13 16:19:05.000000000","message":"I think we need to use timeout as the original gate_hook does like:\n\nhttps://review.openstack.org/#/c/210021/3/neutronclient/tests/functional/hooks/gate_hook.sh,cm","commit_id":"2304643bf05d83c637776cdedbc3acfb3f1ee4fb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"86b2d0129cc95cd813d4d6ff2c1c55e1c7049173","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin neutron-vpnaas git://git.openstack.org/openstack/neutron-vpnaas\""},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"$BASE/new/devstack-gate/devstack-vm-gate.sh"}],"source_content_type":"text/x-sh","patch_set":7,"id":"fa1b9901_3586e0b9","line":15,"updated":"2015-08-19 11:09:44.000000000","message":"it is better to use the same commands as devstack-gate-wrap does.\ndevstack-gate-wrap gate_hook contains \"timeout\" [1]. It is nice to have.\n\n[1] https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate-wrap.sh#L432-L433","commit_id":"5c979e59afeb3d3133027e8857dcf54f3945f4c8"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"176f79cfa945bc16f5add9674a52883ff4a5a6c5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin neutron-vpnaas git://git.openstack.org/openstack/neutron-vpnaas\""},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"$BASE/new/devstack-gate/devstack-vm-gate.sh"}],"source_content_type":"text/x-sh","patch_set":7,"id":"fa1b9901_40b71086","line":15,"in_reply_to":"fa1b9901_3586e0b9","updated":"2015-08-19 11:31:14.000000000","message":"Thanks! Will add this in.","commit_id":"5c979e59afeb3d3133027e8857dcf54f3945f4c8"}],"neutronclient/tests/functional/test_readonly_neutron.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7c43a859d1b5a316900dd9a9528be340f7be491","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import re"},{"line_number":14,"context_line":"import unittest2"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest_lib import exceptions"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_f851ba0e","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":16},"updated":"2015-08-13 14:24:28.000000000","message":"This needs to be removed.","commit_id":"11cd0348264cbd712b8e237c935e57f5267b55a8"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"05376b744c0c47b5848909851c6e4d01649088f8","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.assertTableStruct(subnet_list, [\u0027id\u0027, \u0027name\u0027, \u0027cidr\u0027,"},{"line_number":125,"context_line":"                                             \u0027allocation_pools\u0027])"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @unittest2.skip(\"Skipping until 1484148 is resolved\")"},{"line_number":128,"context_line":"    def test_neutron_vpn_ikepolicy_list(self):"},{"line_number":129,"context_line":"        ikepolicy \u003d self.parser.listing(self.neutron(\u0027vpn-ikepolicy-list\u0027))"},{"line_number":130,"context_line":"        self.assertTableStruct(ikepolicy, [\u0027id\u0027, \u0027name\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a4dcd0f_ab5ba3f5","side":"PARENT","line":127,"updated":"2015-08-14 14:51:38.000000000","message":"I think you need to make this configurable based on whether vpn is expected or not. You shouldn\u0027t hard code the presence of vpn, since it\u0027s an external plugin it might not be installed.","commit_id":"16e02dd83adabd58029e57a95f8ce844d972a469"}]}