)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ddeafd4deacd4aa8b563e7da6a4e24be3dd02809","unresolved":false,"context_lines":[{"line_number":7,"context_line":"L7 capability implementation for lbaas v2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Including L7 policies and rules CLI commands and unit testing"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I3617c7ecd2a3ac0cae555893235e34d6c2135b81"},{"line_number":12,"context_line":"Implements: blueprint lbaas-l7-rules"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba63e191_41a1c3a8","line":10,"updated":"2016-01-19 02:56:51.000000000","message":"Could you add Depends-On to neutron-lbaas L7 patch?\nIt clarifies the dependency and we can check the status easily.","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"5f22288947b351cf7427f3627904d682c1ac685a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"L7 capability implementation for lbaas v2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Including L7 policies and rules CLI commands and unit testing"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I3617c7ecd2a3ac0cae555893235e34d6c2135b81"},{"line_number":12,"context_line":"Implements: blueprint lbaas-l7-rules"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a68dd71_cd6c0bd3","line":10,"in_reply_to":"ba63e191_41a1c3a8","updated":"2016-01-28 10:12:45.000000000","message":"Will Do","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"L7 capability implementation for lbaas v2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Including L7 policies and rules CLI commands and unit testing"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: I8f9535ebf28155adf43ebe046d2dbdfa86c4d81b"},{"line_number":12,"context_line":"Change-Id: I3617c7ecd2a3ac0cae555893235e34d6c2135b81"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"9aed3d3a_967eace2","line":9,"updated":"2016-02-26 11:26:38.000000000","message":"How about adding a release notes and DocImpact flag?","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"L7 capability implementation for lbaas v2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Including L7 policies and rules CLI commands and unit testing"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: I8f9535ebf28155adf43ebe046d2dbdfa86c4d81b"},{"line_number":12,"context_line":"Change-Id: I3617c7ecd2a3ac0cae555893235e34d6c2135b81"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"9aed3d3a_f2b3a4e7","line":9,"in_reply_to":"9aed3d3a_967eace2","updated":"2016-02-26 20:15:49.000000000","message":"Will add DocImpact. \nWhat should I do for release notes? Can you please elaborate?","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5238b4771cf8365a0ac7193aedc04acf1e0a5828","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Including L7 policies and rules CLI commands and unit testing"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":"Depends-On: I8f9535ebf28155adf43ebe046d2dbdfa86c4d81b"},{"line_number":13,"context_line":"Change-Id: I3617c7ecd2a3ac0cae555893235e34d6c2135b81"},{"line_number":14,"context_line":"Implements: blueprint lbaas-l7-rules"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"9aed3d3a_754e4770","line":11,"updated":"2016-02-27 12:54:35.000000000","message":"Please add a note about the change.","commit_id":"d15ad3159c1eb7220d67865d9cfeaed5718c0d0e"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5238b4771cf8365a0ac7193aedc04acf1e0a5828","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Including L7 policies and rules CLI commands and unit testing"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":"Depends-On: I8f9535ebf28155adf43ebe046d2dbdfa86c4d81b"},{"line_number":13,"context_line":"Change-Id: I3617c7ecd2a3ac0cae555893235e34d6c2135b81"},{"line_number":14,"context_line":"Implements: blueprint lbaas-l7-rules"},{"line_number":15,"context_line":"Co-Authored-By: Evgeny Fedoruk \u003cevgenyf@radware.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"9aed3d3a_7575a796","line":12,"updated":"2016-02-27 12:54:35.000000000","message":"For release notes, plz follow \"http://docs.openstack.org/developer/reno/usage.html\"\n\nYou can have a look at the existing release notes.\nhttps://github.com/openstack/python-neutronclient/tree/master/releasenotes/notes","commit_id":"d15ad3159c1eb7220d67865d9cfeaed5718c0d0e"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"1c99f67c4b7dbb75e8c00eea663b29374ffe2031","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Including L7 policies and rules CLI commands and unit testing"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":"Depends-On: I8f9535ebf28155adf43ebe046d2dbdfa86c4d81b"},{"line_number":13,"context_line":"Change-Id: I3617c7ecd2a3ac0cae555893235e34d6c2135b81"},{"line_number":14,"context_line":"Implements: blueprint lbaas-l7-rules"},{"line_number":15,"context_line":"Co-Authored-By: Evgeny Fedoruk \u003cevgenyf@radware.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"9aed3d3a_0b74fc65","line":12,"in_reply_to":"9aed3d3a_7575a796","updated":"2016-02-27 14:56:02.000000000","message":"Will do in next commit","commit_id":"d15ad3159c1eb7220d67865d9cfeaed5718c0d0e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b8d53c3aec99b68d2660d97f1c6f9d6b4228c5c0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds CLI commands for L7 policies and rules"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":"Change-Id: I3617c7ecd2a3ac0cae555893235e34d6c2135b81"},{"line_number":13,"context_line":"Implements: blueprint lbaas-l7-rules"},{"line_number":14,"context_line":"Co-Authored-By: Evgeny Fedoruk \u003cevgenyf@radware.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"9aed3d3a_5c5dde45","line":11,"updated":"2016-02-29 22:05:26.000000000","message":"The docimpact was already filed against the server side patch, this will trigger a new bug filed.\n\n[1] https://bugs.launchpad.net/neutron/+bug/1551368","commit_id":"032c292ceb3258e33e673c69d7d9e4174b941b2d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2236bf396a328b2dadc564a9467122be31ddcc94","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds CLI commands for L7 policies and rules"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":"Change-Id: I3617c7ecd2a3ac0cae555893235e34d6c2135b81"},{"line_number":13,"context_line":"Implements: blueprint lbaas-l7-rules"},{"line_number":14,"context_line":"Co-Authored-By: Evgeny Fedoruk \u003cevgenyf@radware.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"9aed3d3a_7f741467","line":11,"in_reply_to":"9aed3d3a_5c5dde45","updated":"2016-02-29 22:14:38.000000000","message":"So, I suggest you remove this line to avoid filing a duplicate.","commit_id":"032c292ceb3258e33e673c69d7d9e4174b941b2d"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"97a05405c1410fa0da4d6309a3a0831fc4d468e9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds CLI commands for L7 policies and rules"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":"Change-Id: I3617c7ecd2a3ac0cae555893235e34d6c2135b81"},{"line_number":13,"context_line":"Implements: blueprint lbaas-l7-rules"},{"line_number":14,"context_line":"Co-Authored-By: Evgeny Fedoruk \u003cevgenyf@radware.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"9aed3d3a_bf75fcfa","line":11,"in_reply_to":"9aed3d3a_7f741467","updated":"2016-02-29 22:20:52.000000000","message":"Done","commit_id":"032c292ceb3258e33e673c69d7d9e4174b941b2d"}],"neutronclient/neutron/v2_0/lb/v2/l7policy.py":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            choices\u003d[\u0027REJECT\u0027, \u0027REDIRECT_TO_POOL\u0027, \u0027REDIRECT_TO_URL\u0027],"},{"line_number":86,"context_line":"            help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":87,"context_line":"        parser.add_argument("},{"line_number":88,"context_line":"            \u0027--redirect_pool_id\u0027,"},{"line_number":89,"context_line":"            help\u003d_(\u0027Pool id for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":90,"context_line":"        parser.add_argument("},{"line_number":91,"context_line":"            \u0027--redirect_url\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_8b30d457","line":88,"updated":"2015-09-11 05:15:24.000000000","message":"--redirect_pool_id -\u003e --redirect-pool-id","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            choices\u003d[\u0027REJECT\u0027, \u0027REDIRECT_TO_POOL\u0027, \u0027REDIRECT_TO_URL\u0027],"},{"line_number":86,"context_line":"            help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":87,"context_line":"        parser.add_argument("},{"line_number":88,"context_line":"            \u0027--redirect_pool_id\u0027,"},{"line_number":89,"context_line":"            help\u003d_(\u0027Pool id for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":90,"context_line":"        parser.add_argument("},{"line_number":91,"context_line":"            \u0027--redirect_url\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_37ebefe0","line":88,"in_reply_to":"da20952f_8b30d457","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            \u0027--redirect_pool_id\u0027,"},{"line_number":89,"context_line":"            help\u003d_(\u0027Pool id for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":90,"context_line":"        parser.add_argument("},{"line_number":91,"context_line":"            \u0027--redirect_url\u0027,"},{"line_number":92,"context_line":"            help\u003d_(\u0027URL for REDIRECT_TO_URL action type.\u0027"},{"line_number":93,"context_line":"                   \u0027This should be valid URL string.\u0027))"},{"line_number":94,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_2b318859","line":91,"updated":"2015-09-11 05:15:24.000000000","message":"--redirect_url -\u003e --redirect-url","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            \u0027--redirect_pool_id\u0027,"},{"line_number":89,"context_line":"            help\u003d_(\u0027Pool id for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":90,"context_line":"        parser.add_argument("},{"line_number":91,"context_line":"            \u0027--redirect_url\u0027,"},{"line_number":92,"context_line":"            help\u003d_(\u0027URL for REDIRECT_TO_URL action type.\u0027"},{"line_number":93,"context_line":"                   \u0027This should be valid URL string.\u0027))"},{"line_number":94,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_f7f017cb","line":91,"in_reply_to":"da20952f_2b318859","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        parser.add_argument("},{"line_number":91,"context_line":"            \u0027--redirect_url\u0027,"},{"line_number":92,"context_line":"            help\u003d_(\u0027URL for REDIRECT_TO_URL action type.\u0027"},{"line_number":93,"context_line":"                   \u0027This should be valid URL string.\u0027))"},{"line_number":94,"context_line":"        parser.add_argument("},{"line_number":95,"context_line":"            \u0027--position\u0027,"},{"line_number":96,"context_line":"            help\u003d_(\u0027L7 policy position in ordered policies list.\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_6ba1c0a8","line":93,"updated":"2015-09-11 05:15:24.000000000","message":"should be valid -\u003e should be a valid","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        parser.add_argument("},{"line_number":91,"context_line":"            \u0027--redirect_url\u0027,"},{"line_number":92,"context_line":"            help\u003d_(\u0027URL for REDIRECT_TO_URL action type.\u0027"},{"line_number":93,"context_line":"                   \u0027This should be valid URL string.\u0027))"},{"line_number":94,"context_line":"        parser.add_argument("},{"line_number":95,"context_line":"            \u0027--position\u0027,"},{"line_number":96,"context_line":"            help\u003d_(\u0027L7 policy position in ordered policies list.\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_d7c07352","line":93,"in_reply_to":"da20952f_6ba1c0a8","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            help\u003d_(\u0027L7 policy position in ordered policies list.\u0027"},{"line_number":97,"context_line":"                   \u0027This should be number from 1 to N.\u0027"},{"line_number":98,"context_line":"                   \u0027Not specifying the position will place the policy \u0027"},{"line_number":99,"context_line":"                   \u0027at the tail of policies list.\u0027))"},{"line_number":100,"context_line":"        parser.add_argument("},{"line_number":101,"context_line":"            \u0027listener\u0027, metavar\u003d\u0027LISTENER\u0027,"},{"line_number":102,"context_line":"            help\u003d_(\u0027ID or name of the listener that this policy belongs to.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_eb95d03f","line":99,"updated":"2015-09-11 05:15:24.000000000","message":"\"after all other policies in the list\"","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            help\u003d_(\u0027L7 policy position in ordered policies list.\u0027"},{"line_number":97,"context_line":"                   \u0027This should be number from 1 to N.\u0027"},{"line_number":98,"context_line":"                   \u0027Not specifying the position will place the policy \u0027"},{"line_number":99,"context_line":"                   \u0027at the tail of policies list.\u0027))"},{"line_number":100,"context_line":"        parser.add_argument("},{"line_number":101,"context_line":"            \u0027listener\u0027, metavar\u003d\u0027LISTENER\u0027,"},{"line_number":102,"context_line":"            help\u003d_(\u0027ID or name of the listener that this policy belongs to.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_37d20f29","line":99,"in_reply_to":"da20952f_eb95d03f","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                   \u0027at the tail of policies list.\u0027))"},{"line_number":100,"context_line":"        parser.add_argument("},{"line_number":101,"context_line":"            \u0027listener\u0027, metavar\u003d\u0027LISTENER\u0027,"},{"line_number":102,"context_line":"            help\u003d_(\u0027ID or name of the listener that this policy belongs to.\u0027))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def args2body(self, parsed_args):"},{"line_number":105,"context_line":"        self.parent_id \u003d _get_listener_id(self.get_client(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_2b7e681b","line":102,"updated":"2015-09-11 05:15:24.000000000","message":"this policy belongs to -\u003e to which this policy belongs\n\n(But yes, people say the former a lot, incorrectly, too.)","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                   \u0027at the tail of policies list.\u0027))"},{"line_number":100,"context_line":"        parser.add_argument("},{"line_number":101,"context_line":"            \u0027listener\u0027, metavar\u003d\u0027LISTENER\u0027,"},{"line_number":102,"context_line":"            help\u003d_(\u0027ID or name of the listener that this policy belongs to.\u0027))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def args2body(self, parsed_args):"},{"line_number":105,"context_line":"        self.parent_id \u003d _get_listener_id(self.get_client(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_57cd4383","line":102,"in_reply_to":"da20952f_2b7e681b","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return body"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"class UpdateL7Policy(neutronV20.UpdateCommand):"},{"line_number":120,"context_line":"    \"\"\"LBaaS v2 Update a given L7 policy.\"\"\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    resource \u003d \u0027l7policy\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_cb6fac5e","line":119,"updated":"2015-09-11 05:15:24.000000000","message":"Same grammar corrections from above should apply below.","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return body"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"class UpdateL7Policy(neutronV20.UpdateCommand):"},{"line_number":120,"context_line":"    \"\"\"LBaaS v2 Update a given L7 policy.\"\"\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    resource \u003d \u0027l7policy\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_f7c7b761","line":119,"in_reply_to":"da20952f_cb6fac5e","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            help\u003d_(\u0027Set admin state up to false\u0027))"},{"line_number":129,"context_line":"        parser.add_argument("},{"line_number":130,"context_line":"            \u0027--action\u0027,"},{"line_number":131,"context_line":"            help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":132,"context_line":"        parser.add_argument("},{"line_number":133,"context_line":"            \u0027--redirect_pool_id\u0027,"},{"line_number":134,"context_line":"            help\u003d_(\u0027Pool id for REDIRECT_TO_POOL action type.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_6b8f8023","line":131,"updated":"2015-09-11 05:15:24.000000000","message":"Also want to list choices here?","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            help\u003d_(\u0027Set admin state up to false\u0027))"},{"line_number":129,"context_line":"        parser.add_argument("},{"line_number":130,"context_line":"            \u0027--action\u0027,"},{"line_number":131,"context_line":"            help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":132,"context_line":"        parser.add_argument("},{"line_number":133,"context_line":"            \u0027--redirect_pool_id\u0027,"},{"line_number":134,"context_line":"            help\u003d_(\u0027Pool id for REDIRECT_TO_POOL action type.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_b7a4dfb9","line":131,"in_reply_to":"da20952f_6b8f8023","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            \u0027--action\u0027,"},{"line_number":131,"context_line":"            help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":132,"context_line":"        parser.add_argument("},{"line_number":133,"context_line":"            \u0027--redirect_pool_id\u0027,"},{"line_number":134,"context_line":"            help\u003d_(\u0027Pool id for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":135,"context_line":"        parser.add_argument("},{"line_number":136,"context_line":"            \u0027--redirect_url\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_6b2b00ec","line":133,"updated":"2015-09-11 05:15:24.000000000","message":"--redirect_pool_id -\u003e --redirect-pool-id","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            \u0027--action\u0027,"},{"line_number":131,"context_line":"            help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":132,"context_line":"        parser.add_argument("},{"line_number":133,"context_line":"            \u0027--redirect_pool_id\u0027,"},{"line_number":134,"context_line":"            help\u003d_(\u0027Pool id for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":135,"context_line":"        parser.add_argument("},{"line_number":136,"context_line":"            \u0027--redirect_url\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_d7a713bb","line":133,"in_reply_to":"da20952f_6b2b00ec","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            \u0027--redirect_pool_id\u0027,"},{"line_number":134,"context_line":"            help\u003d_(\u0027Pool id for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":135,"context_line":"        parser.add_argument("},{"line_number":136,"context_line":"            \u0027--redirect_url\u0027,"},{"line_number":137,"context_line":"            help\u003d_(\u0027URL for REDIRECT_TO_URL action type.\u0027"},{"line_number":138,"context_line":"                   \u0027This should be valid URL string.\u0027))"},{"line_number":139,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ebf8707e","line":136,"updated":"2015-09-11 05:15:24.000000000","message":"--redirect_url -\u003e --redirect-url","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            \u0027--redirect_pool_id\u0027,"},{"line_number":134,"context_line":"            help\u003d_(\u0027Pool id for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":135,"context_line":"        parser.add_argument("},{"line_number":136,"context_line":"            \u0027--redirect_url\u0027,"},{"line_number":137,"context_line":"            help\u003d_(\u0027URL for REDIRECT_TO_URL action type.\u0027"},{"line_number":138,"context_line":"                   \u0027This should be valid URL string.\u0027))"},{"line_number":139,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_3799af7c","line":136,"in_reply_to":"da20952f_ebf8707e","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def args2body(self, parsed_args):"},{"line_number":150,"context_line":"        self.parent_id \u003d _get_listener_id(self.get_client(),"},{"line_number":151,"context_line":"                                          parsed_args.listener)"},{"line_number":152,"context_line":"        body \u003d {"},{"line_number":153,"context_line":"            self.resource: {}"},{"line_number":154,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_8b09b497","line":151,"updated":"2015-09-11 05:15:24.000000000","message":"You should do a couple sanity checks here:\n\nIf redirect_to_pool is the action, then redirect_pool_id must be valid, and the loadbalancer_id for the listener and pool mush match.\n\nIf redirect_to_url is the action, the URL should pass a regex match.","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def args2body(self, parsed_args):"},{"line_number":150,"context_line":"        self.parent_id \u003d _get_listener_id(self.get_client(),"},{"line_number":151,"context_line":"                                          parsed_args.listener)"},{"line_number":152,"context_line":"        body \u003d {"},{"line_number":153,"context_line":"            self.resource: {}"},{"line_number":154,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_97843b0b","line":151,"in_reply_to":"da20952f_8b09b497","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            self.resource: {}"},{"line_number":154,"context_line":"        }"},{"line_number":155,"context_line":"        neutronV20.update_dict(parsed_args, body[self.resource],"},{"line_number":156,"context_line":"                               [\u0027admin_state_up\u0027, \u0027action\u0027,"},{"line_number":157,"context_line":"                                \u0027redirect_pool_id\u0027, \u0027redirect_url\u0027,"},{"line_number":158,"context_line":"                                \u0027position\u0027])"},{"line_number":159,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_cb424cab","line":156,"updated":"2015-09-11 05:15:24.000000000","message":"Shouldn\u0027t that be \u0027admin_state\u0027 ? Or rather, shouldn\u0027t you initialize admin_state_up when you initialize the body structure above?","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ddeafd4deacd4aa8b563e7da6a4e24be3dd02809","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                                                    cmd_resource\u003d\u0027listener\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def _get_pool_id(client, pool_id_or_name):"},{"line_number":37,"context_line":"    return neutronV20.find_resourceid_by_name_or_id(client, \u0027pool\u0027,"},{"line_number":38,"context_line":"                                                    pool_id_or_name,"},{"line_number":39,"context_line":"                                                    cmd_resource\u003d\u0027lbaas_pool\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_21bb6f74","line":36,"updated":"2016-01-19 02:56:51.000000000","message":"Where is it used?","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"5f22288947b351cf7427f3627904d682c1ac685a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                                                    cmd_resource\u003d\u0027listener\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def _get_pool_id(client, pool_id_or_name):"},{"line_number":37,"context_line":"    return neutronV20.find_resourceid_by_name_or_id(client, \u0027pool\u0027,"},{"line_number":38,"context_line":"                                                    pool_id_or_name,"},{"line_number":39,"context_line":"                                                    cmd_resource\u003d\u0027lbaas_pool\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_540ae3d3","line":36,"in_reply_to":"ba63e191_21bb6f74","updated":"2016-01-28 10:12:45.000000000","message":"Done","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ddeafd4deacd4aa8b563e7da6a4e24be3dd02809","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            message \u003d _(\u0027Redirect pool and policy listener must belong to \u0027"},{"line_number":55,"context_line":"                        \u0027the same loadbalancer\u0027)"},{"line_number":56,"context_line":"            raise exceptions.CommandError(message)"},{"line_number":57,"context_line":"    else:"},{"line_number":58,"context_line":"        message \u003d _(\u0027Redirect pool id or name must be specified \u0027"},{"line_number":59,"context_line":"                    \u0027for REDIRECT_TO_POOL action\u0027)"},{"line_number":60,"context_line":"        raise exceptions.CommandError(message)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_e1f55783","line":57,"updated":"2016-01-19 02:56:51.000000000","message":"Consider the following rather than \"else\".\n\n  if not pool_id_or_name:\n      raise exceptions.CommandError(...)","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"5f22288947b351cf7427f3627904d682c1ac685a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            message \u003d _(\u0027Redirect pool and policy listener must belong to \u0027"},{"line_number":55,"context_line":"                        \u0027the same loadbalancer\u0027)"},{"line_number":56,"context_line":"            raise exceptions.CommandError(message)"},{"line_number":57,"context_line":"    else:"},{"line_number":58,"context_line":"        message \u003d _(\u0027Redirect pool id or name must be specified \u0027"},{"line_number":59,"context_line":"                    \u0027for REDIRECT_TO_POOL action\u0027)"},{"line_number":60,"context_line":"        raise exceptions.CommandError(message)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_484d69c3","line":57,"in_reply_to":"ba63e191_e1f55783","updated":"2016-01-28 10:12:45.000000000","message":"Right, thanks!","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ddeafd4deacd4aa8b563e7da6a4e24be3dd02809","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def _validate_url(redirect_url):"},{"line_number":64,"context_line":"    \"\"\"Redirect URL must be valid URL.\"\"\""},{"line_number":65,"context_line":"    if redirect_url:"},{"line_number":66,"context_line":"        if not re.match(URL_REGEX, redirect_url):"},{"line_number":67,"context_line":"            message \u003d _(\u0027Redirect URL must be a valid URL string.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_611727a4","line":64,"updated":"2016-01-19 02:56:51.000000000","message":"Consider:\n\n  if not redirect_url:\n      raise ...\n  if not re.match(URL_REGEX, redirect_url):\n      raise ...","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"5f22288947b351cf7427f3627904d682c1ac685a","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def _validate_url(redirect_url):"},{"line_number":64,"context_line":"    \"\"\"Redirect URL must be valid URL.\"\"\""},{"line_number":65,"context_line":"    if redirect_url:"},{"line_number":66,"context_line":"        if not re.match(URL_REGEX, redirect_url):"},{"line_number":67,"context_line":"            message \u003d _(\u0027Redirect URL must be a valid URL string.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_d37a6a77","line":64,"in_reply_to":"ba63e191_611727a4","updated":"2016-01-28 10:12:45.000000000","message":"will do","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ddeafd4deacd4aa8b563e7da6a4e24be3dd02809","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":159,"context_line":"            _validate_url(parsed_args.redirect_url)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        body \u003d {"},{"line_number":162,"context_line":"            self.resource: {"},{"line_number":163,"context_line":"                \u0027admin_state_up\u0027: parsed_args.admin_state,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_21884fe7","line":160,"updated":"2016-01-19 02:56:51.000000000","message":"Consider:\n\n  body \u003d {\u0027admin_state_up\u0027: parsed_args.admin_state}\n  neutronV20.update_dict(parsed_args, body, [....])\n  return {self.resource: body}\n\nIt is the pattern used in the current neutornclient.","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"5f22288947b351cf7427f3627904d682c1ac685a","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":159,"context_line":"            _validate_url(parsed_args.redirect_url)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        body \u003d {"},{"line_number":162,"context_line":"            self.resource: {"},{"line_number":163,"context_line":"                \u0027admin_state_up\u0027: parsed_args.admin_state,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_738cde7f","line":160,"in_reply_to":"ba63e191_21884fe7","updated":"2016-01-28 10:12:45.000000000","message":"will do","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ddeafd4deacd4aa8b563e7da6a4e24be3dd02809","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":179,"context_line":"        parser.add_argument("},{"line_number":180,"context_line":"            \u0027--admin-state-down\u0027,"},{"line_number":181,"context_line":"            dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":182,"context_line":"            help\u003d_(\u0027Set admin state up to false\u0027))"},{"line_number":183,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_21edaf8b","line":180,"updated":"2016-01-19 02:56:51.000000000","message":"Use utils.add_boolean_argument() so that the command allows users to specify both True and False.","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"5f22288947b351cf7427f3627904d682c1ac685a","unresolved":false,"context_lines":[{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":179,"context_line":"        parser.add_argument("},{"line_number":180,"context_line":"            \u0027--admin-state-down\u0027,"},{"line_number":181,"context_line":"            dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":182,"context_line":"            help\u003d_(\u0027Set admin state up to false\u0027))"},{"line_number":183,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_5876693f","line":180,"in_reply_to":"ba63e191_21edaf8b","updated":"2016-01-28 10:12:45.000000000","message":"Had troubles to do that, the underlying framework was not happy with that and I didn\u0027t succeed to understand why. I gave up because admin_state_down as it is, is a common approach among lbaas entities for now.","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ddeafd4deacd4aa8b563e7da6a4e24be3dd02809","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":213,"context_line":"            _validate_url(parsed_args.redirect_url)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        body \u003d {"},{"line_number":216,"context_line":"            self.resource: {}"},{"line_number":217,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_a1f99f4f","line":214,"updated":"2016-01-19 02:56:51.000000000","message":"Same comment as at L.160.","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"5f22288947b351cf7427f3627904d682c1ac685a","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":213,"context_line":"            _validate_url(parsed_args.redirect_url)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        body \u003d {"},{"line_number":216,"context_line":"            self.resource: {}"},{"line_number":217,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_34b647dd","line":214,"in_reply_to":"ba63e191_a1f99f4f","updated":"2016-01-28 10:12:45.000000000","message":"Done","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        client, \u0027listener\u0027, listener_id_or_name, cmd_resource\u003d\u0027listener\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def _get_listener_lb_id(client, listener_id_or_name):"},{"line_number":36,"context_line":"    return neutronV20.find_resource_by_name_or_id("},{"line_number":37,"context_line":"        client, \u0027listener\u0027, listener_id_or_name,"},{"line_number":38,"context_line":"        cmd_resource\u003d\u0027listener\u0027)[\u0027loadbalancer\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_a5434341","line":35,"updated":"2016-02-01 01:03:08.000000000","message":"Function _get_listener_lb_id and  _get_pool_lb_id can be combined to a single function, with an additional resource/cmd_resource attribute passed to it (??)","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        client, \u0027listener\u0027, listener_id_or_name, cmd_resource\u003d\u0027listener\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def _get_listener_lb_id(client, listener_id_or_name):"},{"line_number":36,"context_line":"    return neutronV20.find_resource_by_name_or_id("},{"line_number":37,"context_line":"        client, \u0027listener\u0027, listener_id_or_name,"},{"line_number":38,"context_line":"        cmd_resource\u003d\u0027listener\u0027)[\u0027loadbalancer\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_1b5ea676","line":35,"in_reply_to":"7a5de9d1_a5434341","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"ec95fc89bce7f7f33188d11f8cd6b5eb51b092b5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        client, \u0027listener\u0027, listener_id_or_name, cmd_resource\u003d\u0027listener\u0027)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def _get_listener_lb_id(client, listener_id_or_name):"},{"line_number":36,"context_line":"    return neutronV20.find_resource_by_name_or_id("},{"line_number":37,"context_line":"        client, \u0027listener\u0027, listener_id_or_name,"},{"line_number":38,"context_line":"        cmd_resource\u003d\u0027listener\u0027)[\u0027loadbalancer\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_7a3b6139","line":35,"in_reply_to":"7a5de9d1_a5434341","updated":"2016-02-02 10:17:52.000000000","message":"What is full stop?","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    if not pool_id_or_name:"},{"line_number":60,"context_line":"        message \u003d _(\u0027Redirect pool id or name must be specified \u0027"},{"line_number":61,"context_line":"                    \u0027for REDIRECT_TO_POOL action\u0027)"},{"line_number":62,"context_line":"        raise exceptions.CommandError(message)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    pool_lb_id \u003d _get_pool_lb_id(client, pool_id_or_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_254f536c","line":61,"updated":"2016-02-01 01:03:08.000000000","message":"nit : Fullstop","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    if not pool_id_or_name:"},{"line_number":60,"context_line":"        message \u003d _(\u0027Redirect pool id or name must be specified \u0027"},{"line_number":61,"context_line":"                    \u0027for REDIRECT_TO_POOL action\u0027)"},{"line_number":62,"context_line":"        raise exceptions.CommandError(message)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    pool_lb_id \u003d _get_pool_lb_id(client, pool_id_or_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_bb551251","line":61,"in_reply_to":"7a5de9d1_254f536c","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    listener_lb_id \u003d _get_listener_lb_id(client, listener_id_or_name)"},{"line_number":66,"context_line":"    if pool_lb_id !\u003d listener_lb_id:"},{"line_number":67,"context_line":"        message \u003d _(\u0027Redirect pool and policy listener must belong to \u0027"},{"line_number":68,"context_line":"                    \u0027the same loadbalancer\u0027)"},{"line_number":69,"context_line":"        raise exceptions.CommandError(message)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_c540bf36","line":68,"updated":"2016-02-01 01:03:08.000000000","message":"ditto","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    listener_lb_id \u003d _get_listener_lb_id(client, listener_id_or_name)"},{"line_number":66,"context_line":"    if pool_lb_id !\u003d listener_lb_id:"},{"line_number":67,"context_line":"        message \u003d _(\u0027Redirect pool and policy listener must belong to \u0027"},{"line_number":68,"context_line":"                    \u0027the same loadbalancer\u0027)"},{"line_number":69,"context_line":"        raise exceptions.CommandError(message)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_7b4f9abd","line":68,"in_reply_to":"7a5de9d1_c540bf36","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    if not redirect_url:"},{"line_number":76,"context_line":"        message \u003d _(\u0027Redirect URL must be specified for \u0027"},{"line_number":77,"context_line":"                    \u0027REDIRECT_TO_URL action\u0027)"},{"line_number":78,"context_line":"        raise exceptions.CommandError(message)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    if not re.match(URL_REGEX, redirect_url):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_6549cb5f","line":77,"updated":"2016-02-01 01:03:08.000000000","message":"ditto","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    if not redirect_url:"},{"line_number":76,"context_line":"        message \u003d _(\u0027Redirect URL must be specified for \u0027"},{"line_number":77,"context_line":"                    \u0027REDIRECT_TO_URL action\u0027)"},{"line_number":78,"context_line":"        raise exceptions.CommandError(message)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    if not re.match(URL_REGEX, redirect_url):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_db500e61","line":77,"in_reply_to":"7a5de9d1_6549cb5f","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    resource \u003d \u0027l7policy\u0027"},{"line_number":110,"context_line":"    shadow_resource \u003d \u0027lbaas_l7policy\u0027"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027--admin-state-down\u0027,"},{"line_number":115,"context_line":"            dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_6560ebcf","line":112,"updated":"2016-02-01 01:03:08.000000000","message":"better create a single function add_common_args (), which will be called by CreateL7Policy:add_known_arguments() and UpdateL7Policy:add_known_arguments.\n\nSame for parsing of these args","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    resource \u003d \u0027l7policy\u0027"},{"line_number":110,"context_line":"    shadow_resource \u003d \u0027lbaas_l7policy\u0027"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027--admin-state-down\u0027,"},{"line_number":115,"context_line":"            dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_2fb590cf","line":112,"in_reply_to":"7a5de9d1_6560ebcf","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027--admin-state-down\u0027,"},{"line_number":115,"context_line":"            dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":116,"context_line":"            help\u003d_(\u0027Set admin state up to false\u0027))"},{"line_number":117,"context_line":"        parser.add_argument("},{"line_number":118,"context_line":"            \u0027--name\u0027,"},{"line_number":119,"context_line":"            help\u003d_(\u0027The name of the policy.\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_259d13bc","line":116,"updated":"2016-02-01 01:03:08.000000000","message":"nit: full stop ( please check other help messages and add the full stop there as well )","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027--admin-state-down\u0027,"},{"line_number":115,"context_line":"            dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":116,"context_line":"            help\u003d_(\u0027Set admin state up to false\u0027))"},{"line_number":117,"context_line":"        parser.add_argument("},{"line_number":118,"context_line":"            \u0027--name\u0027,"},{"line_number":119,"context_line":"            help\u003d_(\u0027The name of the policy.\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_3bc84222","line":116,"in_reply_to":"7a5de9d1_259d13bc","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            help\u003d_(\u0027The description of the policy.\u0027))"},{"line_number":123,"context_line":"        parser.add_argument("},{"line_number":124,"context_line":"            \u0027--action\u0027,"},{"line_number":125,"context_line":"            required\u003dTrue,"},{"line_number":126,"context_line":"            choices\u003d[\u0027REJECT\u0027, \u0027REDIRECT_TO_POOL\u0027, \u0027REDIRECT_TO_URL\u0027],"},{"line_number":127,"context_line":"            help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":128,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_858ba767","line":125,"updated":"2016-02-01 01:03:08.000000000","message":"maybe metavar\u003dACTION can be added here, like it has been done for --listener?","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            help\u003d_(\u0027The description of the policy.\u0027))"},{"line_number":123,"context_line":"        parser.add_argument("},{"line_number":124,"context_line":"            \u0027--action\u0027,"},{"line_number":125,"context_line":"            required\u003dTrue,"},{"line_number":126,"context_line":"            choices\u003d[\u0027REJECT\u0027, \u0027REDIRECT_TO_POOL\u0027, \u0027REDIRECT_TO_URL\u0027],"},{"line_number":127,"context_line":"            help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":128,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_1439cb41","line":125,"in_reply_to":"7a5de9d1_858ba767","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        parser.add_argument("},{"line_number":124,"context_line":"            \u0027--action\u0027,"},{"line_number":125,"context_line":"            required\u003dTrue,"},{"line_number":126,"context_line":"            choices\u003d[\u0027REJECT\u0027, \u0027REDIRECT_TO_POOL\u0027, \u0027REDIRECT_TO_URL\u0027],"},{"line_number":127,"context_line":"            help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":128,"context_line":"        parser.add_argument("},{"line_number":129,"context_line":"            \u0027--redirect-pool-id\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_65b78b3a","line":126,"updated":"2016-02-01 01:03:08.000000000","message":"Please use type\u003dutils.convert_to_uppercase , so that user can enter any of the following:\n- REJECT \n- Reject\n- reject\n\nAll would be accepted and the final information POST/PUT to server would be REJECT as the user information would be converted to Uppercase.\n\nCorrespondingly, import utils.","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        parser.add_argument("},{"line_number":124,"context_line":"            \u0027--action\u0027,"},{"line_number":125,"context_line":"            required\u003dTrue,"},{"line_number":126,"context_line":"            choices\u003d[\u0027REJECT\u0027, \u0027REDIRECT_TO_POOL\u0027, \u0027REDIRECT_TO_URL\u0027],"},{"line_number":127,"context_line":"            help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":128,"context_line":"        parser.add_argument("},{"line_number":129,"context_line":"            \u0027--redirect-pool-id\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_1bd546b8","line":126,"in_reply_to":"7a5de9d1_65b78b3a","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            \u0027--position\u0027,"},{"line_number":137,"context_line":"            help\u003d_(\u0027L7 policy position in ordered policies list.\u0027"},{"line_number":138,"context_line":"                   \u0027This should be number from 1 to N.\u0027"},{"line_number":139,"context_line":"                   \u0027Not specifying the position will place the policy \u0027"},{"line_number":140,"context_line":"                   \u0027at the tail of existing policies list.\u0027))"},{"line_number":141,"context_line":"        parser.add_argument("},{"line_number":142,"context_line":"            \u0027--listener\u0027, required\u003dTrue, metavar\u003d\u0027LISTENER\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_057fb766","line":139,"updated":"2016-02-01 01:03:08.000000000","message":"you can use type\u003dint here ,so that the data check for integer happens at the client side at a very early level","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            \u0027--position\u0027,"},{"line_number":137,"context_line":"            help\u003d_(\u0027L7 policy position in ordered policies list.\u0027"},{"line_number":138,"context_line":"                   \u0027This should be number from 1 to N.\u0027"},{"line_number":139,"context_line":"                   \u0027Not specifying the position will place the policy \u0027"},{"line_number":140,"context_line":"                   \u0027at the tail of existing policies list.\u0027))"},{"line_number":141,"context_line":"        parser.add_argument("},{"line_number":142,"context_line":"            \u0027--listener\u0027, required\u003dTrue, metavar\u003d\u0027LISTENER\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_0febf4b1","line":139,"in_reply_to":"7a5de9d1_057fb766","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":176,"context_line":"        parser.add_argument("},{"line_number":177,"context_line":"            \u0027--admin-state-down\u0027,"},{"line_number":178,"context_line":"            dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":179,"context_line":"            help\u003d_(\u0027Set admin state up to false\u0027))"},{"line_number":180,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_65e54b36","line":177,"updated":"2016-02-01 01:03:08.000000000","message":"It is a policy of neutronclient, that while Create* use --admin-state-down, Update* use --admin-state-up\nPlease convert the same here.\nAlso, instead of adding it as an argument, it is better to use utils.add_boolean_argumnet here.\n\n\n\n\n utils.add_boolean_argumnet(\n    parser, ¨--admin-state-up¨,\n    help\u003d_(¨Specify the admin state of the Policy.¨))","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":176,"context_line":"        parser.add_argument("},{"line_number":177,"context_line":"            \u0027--admin-state-down\u0027,"},{"line_number":178,"context_line":"            dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":179,"context_line":"            help\u003d_(\u0027Set admin state up to false\u0027))"},{"line_number":180,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_f9a991e0","line":177,"in_reply_to":"7a5de9d1_65e54b36","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            help\u003d_(\u0027The name of the policy.\u0027))"},{"line_number":183,"context_line":"        parser.add_argument("},{"line_number":184,"context_line":"            \u0027--action\u0027,"},{"line_number":185,"context_line":"            choices\u003d[\u0027REJECT\u0027, \u0027REDIRECT_TO_POOL\u0027, \u0027REDIRECT_TO_URL\u0027],"},{"line_number":186,"context_line":"            help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":187,"context_line":"        parser.add_argument("},{"line_number":188,"context_line":"            \u0027--redirect-pool-id\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_25d2f35c","line":185,"updated":"2016-02-01 01:03:08.000000000","message":"If you use add_common_arguments() for both Create and Update, you wont have to separately parse --name, --action, --position, --redirect-url and --redirect-pool-id here.","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            help\u003d_(\u0027The name of the policy.\u0027))"},{"line_number":183,"context_line":"        parser.add_argument("},{"line_number":184,"context_line":"            \u0027--action\u0027,"},{"line_number":185,"context_line":"            choices\u003d[\u0027REJECT\u0027, \u0027REDIRECT_TO_POOL\u0027, \u0027REDIRECT_TO_URL\u0027],"},{"line_number":186,"context_line":"            help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":187,"context_line":"        parser.add_argument("},{"line_number":188,"context_line":"            \u0027--redirect-pool-id\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_8f45a4b4","line":185,"in_reply_to":"7a5de9d1_25d2f35c","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                   \u0027at the tail of existing policies list.\u0027))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def args2body(self, parsed_args):"},{"line_number":202,"context_line":"        # Commented because unitest wramework doesn\u0027t like it"},{"line_number":203,"context_line":"        # if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":204,"context_line":"        #    listenet_id \u003d _get_policy_listener_id("},{"line_number":205,"context_line":"        #        self.get_client(), parsed_args.id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_e5c7fb95","line":202,"updated":"2016-02-01 01:03:08.000000000","message":"framework?","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                   \u0027at the tail of existing policies list.\u0027))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def args2body(self, parsed_args):"},{"line_number":202,"context_line":"        # Commented because unitest wramework doesn\u0027t like it"},{"line_number":203,"context_line":"        # if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":204,"context_line":"        #    listenet_id \u003d _get_policy_listener_id("},{"line_number":205,"context_line":"        #        self.get_client(), parsed_args.id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_af25000b","line":202,"in_reply_to":"7a5de9d1_e5c7fb95","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"aec6960cc8473c820d78a7f92949408be0e0a13c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        choices\u003d[\u0027REJECT\u0027, \u0027REDIRECT_TO_POOL\u0027, \u0027REDIRECT_TO_URL\u0027],"},{"line_number":58,"context_line":"        help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":59,"context_line":"    parser.add_argument("},{"line_number":60,"context_line":"        \u0027--redirect-pool-id\u0027,"},{"line_number":61,"context_line":"        help\u003d_(\u0027Pool id for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":62,"context_line":"    parser.add_argument("},{"line_number":63,"context_line":"        \u0027--redirect-url\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_a0b8ef2b","line":60,"range":{"start_line":60,"start_character":9,"end_line":60,"end_character":27},"updated":"2016-02-19 05:17:33.000000000","message":"It is better to support pool name too.","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"a9b0a0cfc589af5f5a4a39fdd0342e326ba77926","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        choices\u003d[\u0027REJECT\u0027, \u0027REDIRECT_TO_POOL\u0027, \u0027REDIRECT_TO_URL\u0027],"},{"line_number":58,"context_line":"        help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":59,"context_line":"    parser.add_argument("},{"line_number":60,"context_line":"        \u0027--redirect-pool-id\u0027,"},{"line_number":61,"context_line":"        help\u003d_(\u0027Pool id for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":62,"context_line":"    parser.add_argument("},{"line_number":63,"context_line":"        \u0027--redirect-url\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_b4b8dce6","line":60,"range":{"start_line":60,"start_character":9,"end_line":60,"end_character":27},"in_reply_to":"bae84128_c7921b4b","updated":"2016-02-22 13:53:32.000000000","message":"Done","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"15eb968fff449338fb1a9a90ddcb1de17e2d1845","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        choices\u003d[\u0027REJECT\u0027, \u0027REDIRECT_TO_POOL\u0027, \u0027REDIRECT_TO_URL\u0027],"},{"line_number":58,"context_line":"        help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":59,"context_line":"    parser.add_argument("},{"line_number":60,"context_line":"        \u0027--redirect-pool-id\u0027,"},{"line_number":61,"context_line":"        help\u003d_(\u0027Pool id for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":62,"context_line":"    parser.add_argument("},{"line_number":63,"context_line":"        \u0027--redirect-url\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_c7921b4b","line":60,"range":{"start_line":60,"start_character":9,"end_line":60,"end_character":27},"in_reply_to":"dae33548_a0b8ef2b","updated":"2016-02-22 06:24:19.000000000","message":"Yep-- it should just be \u0027--redirect-pool\u0027 and take either a pool name or ID as the argument.","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"706acbde4b7ce6ad82e3d0def35810cf0a74808d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        help\u003d_(\u0027The description of the policy.\u0027))"},{"line_number":58,"context_line":"    parser.add_argument("},{"line_number":59,"context_line":"        \u0027--action\u0027,"},{"line_number":60,"context_line":"        required\u003dTrue, metavar\u003d\u0027ACTION\u0027,"},{"line_number":61,"context_line":"        type\u003dutils.convert_to_uppercase,"},{"line_number":62,"context_line":"        choices\u003d[\u0027REJECT\u0027, \u0027REDIRECT_TO_POOL\u0027, \u0027REDIRECT_TO_URL\u0027],"},{"line_number":63,"context_line":"        help\u003d_(\u0027Action type of the policy.\u0027))"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_6b7beaf5","line":60,"updated":"2016-02-23 01:07:17.000000000","message":"NOTE: is ACTION a required parameter for UpdateL7Policy ( I do not think so, but correct me if I am wrong).\n\nUpdate: As per the discussion on the IRC, --action is not a required parameter for update.\n\nSo maybe you can have the function definition in Line#51 as \n\n def _add_common_args(parser, is_create\u003dTrue):\n\nand Line Number 60 can be \n\n required \u003d is_create, metavar\u003d\u0027ACTION\u0027\n\nand Line#146 would then be \n\n  _add_common_args(parser, is_create\u003dFalse)\n\n\nSimple and should work well","commit_id":"665960dcdd2970c6de86fb0d18c0f31a29835a93"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"3d70e8f646aaa6df7641e42cfa05850dcdd730f1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        help\u003d_(\u0027The description of the policy.\u0027))"},{"line_number":58,"context_line":"    parser.add_argument("},{"line_number":59,"context_line":"        \u0027--action\u0027,"},{"line_number":60,"context_line":"        required\u003dTrue, metavar\u003d\u0027ACTION\u0027,"},{"line_number":61,"context_line":"        type\u003dutils.convert_to_uppercase,"},{"line_number":62,"context_line":"        choices\u003d[\u0027REJECT\u0027, \u0027REDIRECT_TO_POOL\u0027, \u0027REDIRECT_TO_URL\u0027],"},{"line_number":63,"context_line":"        help\u003d_(\u0027Action type of the policy.\u0027))"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_8c511a39","line":60,"in_reply_to":"bae84128_6b7beaf5","updated":"2016-02-24 08:54:29.000000000","message":"Done","commit_id":"665960dcdd2970c6de86fb0d18c0f31a29835a93"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"706acbde4b7ce6ad82e3d0def35810cf0a74808d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":64,"context_line":"    parser.add_argument("},{"line_number":65,"context_line":"        \u0027--redirect-pool\u0027,"},{"line_number":66,"context_line":"        help\u003d_(\u0027Pool ID or name for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":67,"context_line":"    parser.add_argument("},{"line_number":68,"context_line":"        \u0027--redirect-url\u0027,"},{"line_number":69,"context_line":"        help\u003d_(\u0027URL for REDIRECT_TO_URL action type.\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_0ba97e7b","line":66,"updated":"2016-02-23 01:07:17.000000000","message":"to keep in sync with other neutronclient messages, this can be possibly reworded to \n\"ID or name of the pool for REDIRECT_TO_POOL action type\"","commit_id":"665960dcdd2970c6de86fb0d18c0f31a29835a93"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"3d70e8f646aaa6df7641e42cfa05850dcdd730f1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":64,"context_line":"    parser.add_argument("},{"line_number":65,"context_line":"        \u0027--redirect-pool\u0027,"},{"line_number":66,"context_line":"        help\u003d_(\u0027Pool ID or name for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":67,"context_line":"    parser.add_argument("},{"line_number":68,"context_line":"        \u0027--redirect-url\u0027,"},{"line_number":69,"context_line":"        help\u003d_(\u0027URL for REDIRECT_TO_URL action type.\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_ff67a6e6","line":66,"in_reply_to":"bae84128_0ba97e7b","updated":"2016-02-24 08:54:29.000000000","message":"Done","commit_id":"665960dcdd2970c6de86fb0d18c0f31a29835a93"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"706acbde4b7ce6ad82e3d0def35810cf0a74808d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    parser.add_argument("},{"line_number":72,"context_line":"        \u0027--position\u0027, type\u003dint,"},{"line_number":73,"context_line":"        help\u003d_(\u0027L7 policy position in ordered policies list.\u0027"},{"line_number":74,"context_line":"               \u0027This should be number from 1 to N.\u0027"},{"line_number":75,"context_line":"               \u0027Not specifying the position will place the policy \u0027"},{"line_number":76,"context_line":"               \u0027at the tail of existing policies list.\u0027))"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_8b38ee3e","line":74,"updated":"2016-02-23 01:07:17.000000000","message":"IMHO, N is a very oblique explanation for the maximum policy value and user can ask what is N ( frankly I am myself thinking what value would N hold ?)\nI think you can skip N, and state that the policy must be an integer, starting from 1.","commit_id":"665960dcdd2970c6de86fb0d18c0f31a29835a93"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"3d70e8f646aaa6df7641e42cfa05850dcdd730f1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    parser.add_argument("},{"line_number":72,"context_line":"        \u0027--position\u0027, type\u003dint,"},{"line_number":73,"context_line":"        help\u003d_(\u0027L7 policy position in ordered policies list.\u0027"},{"line_number":74,"context_line":"               \u0027This should be number from 1 to N.\u0027"},{"line_number":75,"context_line":"               \u0027Not specifying the position will place the policy \u0027"},{"line_number":76,"context_line":"               \u0027at the tail of existing policies list.\u0027))"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_3fa90e7c","line":74,"in_reply_to":"bae84128_8b38ee3e","updated":"2016-02-24 08:54:29.000000000","message":"Done","commit_id":"665960dcdd2970c6de86fb0d18c0f31a29835a93"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"706acbde4b7ce6ad82e3d0def35810cf0a74808d","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        parsed_args.listener \u003d _get_listener_id("},{"line_number":118,"context_line":"            self.get_client(), parsed_args.listener)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":121,"context_line":"            _validate_url(parsed_args.redirect_url)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_e6156f40","line":120,"updated":"2016-02-23 01:07:17.000000000","message":"A lot of code from Line#120 to L-135 and L153 to 165 is the same.\nCan we create a function so that the code is not repeated ( just a suggestion)","commit_id":"665960dcdd2970c6de86fb0d18c0f31a29835a93"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"3d70e8f646aaa6df7641e42cfa05850dcdd730f1","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        parsed_args.listener \u003d _get_listener_id("},{"line_number":118,"context_line":"            self.get_client(), parsed_args.listener)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":121,"context_line":"            _validate_url(parsed_args.redirect_url)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_95e59239","line":120,"in_reply_to":"bae84128_e6156f40","updated":"2016-02-24 08:54:29.000000000","message":"Done","commit_id":"665960dcdd2970c6de86fb0d18c0f31a29835a93"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"706acbde4b7ce6ad82e3d0def35810cf0a74808d","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        body \u003d {}"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        neutronV20.update_dict(parsed_args, body,"},{"line_number":163,"context_line":"                               [\u0027name\u0027, \u0027action\u0027, \u0027redirect_pool_id\u0027,"},{"line_number":164,"context_line":"                                \u0027redirect_url\u0027, \u0027position\u0027, \u0027admin_state_up\u0027])"},{"line_number":165,"context_line":"        return {self.resource: body}"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_06b5f32f","line":163,"updated":"2016-02-23 01:07:17.000000000","message":"description is missing here","commit_id":"665960dcdd2970c6de86fb0d18c0f31a29835a93"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"3d70e8f646aaa6df7641e42cfa05850dcdd730f1","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        body \u003d {}"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        neutronV20.update_dict(parsed_args, body,"},{"line_number":163,"context_line":"                               [\u0027name\u0027, \u0027action\u0027, \u0027redirect_pool_id\u0027,"},{"line_number":164,"context_line":"                                \u0027redirect_url\u0027, \u0027position\u0027, \u0027admin_state_up\u0027])"},{"line_number":165,"context_line":"        return {self.resource: body}"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_153fc287","line":163,"in_reply_to":"bae84128_06b5f32f","updated":"2016-02-24 08:54:29.000000000","message":"Done","commit_id":"665960dcdd2970c6de86fb0d18c0f31a29835a93"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e357a3425e0d8a0c45292c126491b4173233e743","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutronclient.common import exceptions"},{"line_number":20,"context_line":"from neutronclient.common import utils"},{"line_number":21,"context_line":"from neutronclient.i18n import _"},{"line_number":22,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"URL_REGEX \u003d r\u0027http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.\u0026+]|[!*(),]|\\"}],"source_content_type":"text/x-python","patch_set":16,"id":"bae84128_788cb035","line":21,"range":{"start_line":21,"start_character":19,"end_line":21,"end_character":23},"updated":"2016-02-25 14:09:49.000000000","message":"For a new code \"_i18n\" should be used. \"i18n\" module is deprecated.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutronclient.common import exceptions"},{"line_number":20,"context_line":"from neutronclient.common import utils"},{"line_number":21,"context_line":"from neutronclient.i18n import _"},{"line_number":22,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"URL_REGEX \u003d r\u0027http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.\u0026+]|[!*(),]|\\"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_e971ffa9","line":21,"range":{"start_line":21,"start_character":19,"end_line":21,"end_character":23},"in_reply_to":"bae84128_788cb035","updated":"2016-02-26 20:15:49.000000000","message":"Done","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def _get_listener_id(client, listener_id_or_name):"},{"line_number":29,"context_line":"    return neutronV20.find_resourceid_by_name_or_id("},{"line_number":30,"context_line":"        client, \u0027listener\u0027, listener_id_or_name, cmd_resource\u003d\u0027listener\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def _get_pool_id(client, pool_id_or_name):"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_131e2e0c","line":30,"updated":"2016-02-26 11:26:38.000000000","message":"I think we don\u0027t have to specify the cmd_resource if it\u0027s not diff from the resource name. Plz check https://github.com/openstack/python-neutronclient/blob/60d5ad12c565e13ae2e7c51a48e1aa27876017e3/neutronclient/neutron/v2_0/__init__.py#L85-L87 initialize cmd_resource to resource if not specified.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def _get_listener_id(client, listener_id_or_name):"},{"line_number":29,"context_line":"    return neutronV20.find_resourceid_by_name_or_id("},{"line_number":30,"context_line":"        client, \u0027listener\u0027, listener_id_or_name, cmd_resource\u003d\u0027listener\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def _get_pool_id(client, pool_id_or_name):"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_8991539c","line":30,"in_reply_to":"9aed3d3a_131e2e0c","updated":"2016-02-26 20:15:49.000000000","message":"Done","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":51,"context_line":"def _add_common_args(parser, is_create\u003dTrue):"},{"line_number":52,"context_line":"    parser.add_argument("},{"line_number":53,"context_line":"        \u0027--name\u0027,"},{"line_number":54,"context_line":"        help\u003d_(\u0027The name of the policy.\u0027))"},{"line_number":55,"context_line":"    parser.add_argument("},{"line_number":56,"context_line":"        \u0027--description\u0027,"},{"line_number":57,"context_line":"        help\u003d_(\u0027The description of the policy.\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_b3ddc216","line":54,"updated":"2016-02-26 11:26:38.000000000","message":"Most of the existing help doesn\u0027t prefix \u0027The\u0027. IMO, \u0027Name of the policy.\u0027 would be fine.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":51,"context_line":"def _add_common_args(parser, is_create\u003dTrue):"},{"line_number":52,"context_line":"    parser.add_argument("},{"line_number":53,"context_line":"        \u0027--name\u0027,"},{"line_number":54,"context_line":"        help\u003d_(\u0027The name of the policy.\u0027))"},{"line_number":55,"context_line":"    parser.add_argument("},{"line_number":56,"context_line":"        \u0027--description\u0027,"},{"line_number":57,"context_line":"        help\u003d_(\u0027The description of the policy.\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_a9d3775e","line":54,"in_reply_to":"9aed3d3a_b3ddc216","updated":"2016-02-26 20:15:49.000000000","message":"Done","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        help\u003d_(\u0027The name of the policy.\u0027))"},{"line_number":55,"context_line":"    parser.add_argument("},{"line_number":56,"context_line":"        \u0027--description\u0027,"},{"line_number":57,"context_line":"        help\u003d_(\u0027The description of the policy.\u0027))"},{"line_number":58,"context_line":"    parser.add_argument("},{"line_number":59,"context_line":"        \u0027--action\u0027,"},{"line_number":60,"context_line":"        required\u003dis_create, metavar\u003d\u0027ACTION\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_d3ecc6c9","line":57,"updated":"2016-02-26 11:26:38.000000000","message":"ditto","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        help\u003d_(\u0027The name of the policy.\u0027))"},{"line_number":55,"context_line":"    parser.add_argument("},{"line_number":56,"context_line":"        \u0027--description\u0027,"},{"line_number":57,"context_line":"        help\u003d_(\u0027The description of the policy.\u0027))"},{"line_number":58,"context_line":"    parser.add_argument("},{"line_number":59,"context_line":"        \u0027--action\u0027,"},{"line_number":60,"context_line":"        required\u003dis_create, metavar\u003d\u0027ACTION\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_69e32f34","line":57,"in_reply_to":"9aed3d3a_d3ecc6c9","updated":"2016-02-26 20:15:49.000000000","message":"Done","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"91ce2a37f5d014c19b83d3a10b25418d2c4d7ee8","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        choices\u003d[\u0027REJECT\u0027, \u0027REDIRECT_TO_POOL\u0027, \u0027REDIRECT_TO_URL\u0027],"},{"line_number":63,"context_line":"        help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":64,"context_line":"    parser.add_argument("},{"line_number":65,"context_line":"        \u0027--redirect-pool\u0027,"},{"line_number":66,"context_line":"        help\u003d_(\u0027ID or name of the pool for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":67,"context_line":"    parser.add_argument("},{"line_number":68,"context_line":"        \u0027--redirect-url\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_c9d07b56","line":65,"range":{"start_line":65,"start_character":9,"end_line":65,"end_character":24},"updated":"2016-02-26 18:24:58.000000000","message":"-redirect_to_pool","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        choices\u003d[\u0027REJECT\u0027, \u0027REDIRECT_TO_POOL\u0027, \u0027REDIRECT_TO_URL\u0027],"},{"line_number":63,"context_line":"        help\u003d_(\u0027Action type of the policy.\u0027))"},{"line_number":64,"context_line":"    parser.add_argument("},{"line_number":65,"context_line":"        \u0027--redirect-pool\u0027,"},{"line_number":66,"context_line":"        help\u003d_(\u0027ID or name of the pool for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":67,"context_line":"    parser.add_argument("},{"line_number":68,"context_line":"        \u0027--redirect-url\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_72baf40b","line":65,"range":{"start_line":65,"start_character":9,"end_line":65,"end_character":24},"in_reply_to":"9aed3d3a_c9d07b56","updated":"2016-02-26 20:15:49.000000000","message":"I think redirect-pool is self explaining enough, please elaborate why you prefer redirect-to-pool","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"91ce2a37f5d014c19b83d3a10b25418d2c4d7ee8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        \u0027--redirect-pool\u0027,"},{"line_number":66,"context_line":"        help\u003d_(\u0027ID or name of the pool for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":67,"context_line":"    parser.add_argument("},{"line_number":68,"context_line":"        \u0027--redirect-url\u0027,"},{"line_number":69,"context_line":"        help\u003d_(\u0027URL for REDIRECT_TO_URL action type.\u0027"},{"line_number":70,"context_line":"               \u0027This should be a valid URL string.\u0027))"},{"line_number":71,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_09f423f0","line":68,"range":{"start_line":68,"start_character":10,"end_line":68,"end_character":24},"updated":"2016-02-26 18:24:58.000000000","message":"-redirect_to_url\u0027","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        \u0027--redirect-pool\u0027,"},{"line_number":66,"context_line":"        help\u003d_(\u0027ID or name of the pool for REDIRECT_TO_POOL action type.\u0027))"},{"line_number":67,"context_line":"    parser.add_argument("},{"line_number":68,"context_line":"        \u0027--redirect-url\u0027,"},{"line_number":69,"context_line":"        help\u003d_(\u0027URL for REDIRECT_TO_URL action type.\u0027"},{"line_number":70,"context_line":"               \u0027This should be a valid URL string.\u0027))"},{"line_number":71,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_12428810","line":68,"range":{"start_line":68,"start_character":10,"end_line":68,"end_character":24},"in_reply_to":"9aed3d3a_09f423f0","updated":"2016-02-26 20:15:49.000000000","message":"ditto","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c40dfa0028f2e8e2537cb500ff3bba42a2e56b1b","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def _common_args2body(client, parsed_args, is_create\u003dTrue):"},{"line_number":80,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":81,"context_line":"        _validate_url(parsed_args.redirect_url)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":84,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("}],"source_content_type":"text/x-python","patch_set":16,"id":"bae84128_3b0fbbe2","line":81,"updated":"2016-02-25 16:24:27.000000000","message":"What if url is specified with some other action type, say : \u0027REJECT\u0027 or others","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def _common_args2body(client, parsed_args, is_create\u003dTrue):"},{"line_number":80,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":81,"context_line":"        _validate_url(parsed_args.redirect_url)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":84,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_38420b3f","line":81,"in_reply_to":"9aed3d3a_09b543ed","updated":"2016-02-26 20:15:49.000000000","message":"_validate_url function matches the URL with url regex. It should start with http. Added it to description of the argument. \nDo you have a real reason to support www here?","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":10477,"name":"min wang","email":"swiftwangster@gmail.com","username":"minwang"},"change_message_id":"91ce2a37f5d014c19b83d3a10b25418d2c4d7ee8","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def _common_args2body(client, parsed_args, is_create\u003dTrue):"},{"line_number":80,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":81,"context_line":"        _validate_url(parsed_args.redirect_url)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":84,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_09b543ed","line":81,"in_reply_to":"bae84128_3b0fbbe2","updated":"2016-02-26 18:24:58.000000000","message":"I tested the redirct_to_url, it is always telling me  invalid values_specs, so the url that i pass is www.google.com, not sure what format is required here, maybe give an example in the help.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def _common_args2body(client, parsed_args, is_create\u003dTrue):"},{"line_number":80,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":81,"context_line":"        _validate_url(parsed_args.redirect_url)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":84,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_2947671e","line":81,"in_reply_to":"bae84128_3b0fbbe2","updated":"2016-02-26 20:15:49.000000000","message":"It\u0027s a good point to make unnecessary arguments validation, but unfortunately the current unitest fw is not built to handle it. What I can do is to make sure unnecessary (and not validated) values are not hitting the API.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c40dfa0028f2e8e2537cb500ff3bba42a2e56b1b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":81,"context_line":"        _validate_url(parsed_args.redirect_url)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":84,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("},{"line_number":85,"context_line":"            client, parsed_args.redirect_pool)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"bae84128_380ce193","line":83,"updated":"2016-02-25 16:24:27.000000000","message":"better to have elif as only one type of action can be specified.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":81,"context_line":"        _validate_url(parsed_args.redirect_url)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":84,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("},{"line_number":85,"context_line":"            client, parsed_args.redirect_pool)"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_e9445f1c","line":83,"in_reply_to":"bae84128_380ce193","updated":"2016-02-26 20:15:49.000000000","message":"Done","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        _validate_url(parsed_args.redirect_url)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":84,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("},{"line_number":85,"context_line":"            client, parsed_args.redirect_pool)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    attributes \u003d [\u0027name\u0027, \u0027description\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_b312e2b2","line":84,"updated":"2016-02-26 11:26:38.000000000","message":"What if \u0027redirect-pool\u0027 is specified with other action? I think we are not checking this constraint.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        _validate_url(parsed_args.redirect_url)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":84,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("},{"line_number":85,"context_line":"            client, parsed_args.redirect_pool)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    attributes \u003d [\u0027name\u0027, \u0027description\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_09426310","line":84,"in_reply_to":"9aed3d3a_b312e2b2","updated":"2016-02-26 20:15:49.000000000","message":"Done","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                  \u0027action\u0027, \u0027redirect_pool_id\u0027, \u0027redirect_url\u0027,"},{"line_number":89,"context_line":"                  \u0027position\u0027, \u0027admin_state_up\u0027]"},{"line_number":90,"context_line":"    if is_create:"},{"line_number":91,"context_line":"        parsed_args.listener_id \u003d _get_listener_id("},{"line_number":92,"context_line":"            client, parsed_args.listener)"},{"line_number":93,"context_line":"        attributes.extend([\u0027listener_id\u0027, \u0027tenant_id\u0027])"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_b3182286","line":91,"updated":"2016-02-26 11:26:38.000000000","message":"\u0027listener_id\u0027 is not a common attribute. Let\u0027s move it to the specific function otherwise the motive of this function is getting lost.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                  \u0027action\u0027, \u0027redirect_pool_id\u0027, \u0027redirect_url\u0027,"},{"line_number":89,"context_line":"                  \u0027position\u0027, \u0027admin_state_up\u0027]"},{"line_number":90,"context_line":"    if is_create:"},{"line_number":91,"context_line":"        parsed_args.listener_id \u003d _get_listener_id("},{"line_number":92,"context_line":"            client, parsed_args.listener)"},{"line_number":93,"context_line":"        attributes.extend([\u0027listener_id\u0027, \u0027tenant_id\u0027])"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_090d4390","line":91,"in_reply_to":"9aed3d3a_b3182286","updated":"2016-02-26 20:15:49.000000000","message":"I do not think so, common functions may be parametrized sometimes if it serves its aim to make using it code cleaner","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    resource \u003d \u0027l7policy\u0027"},{"line_number":104,"context_line":"    shadow_resource \u003d \u0027lbaas_l7policy\u0027"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    list_columns \u003d ["},{"line_number":107,"context_line":"        \u0027id\u0027, \u0027name\u0027, \u0027action\u0027, \u0027redirect_pool_id\u0027, \u0027redirect_url\u0027,"},{"line_number":108,"context_line":"        \u0027position\u0027, \u0027admin_state_up\u0027, \u0027status\u0027"},{"line_number":109,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_76916899","line":106,"updated":"2016-02-26 11:26:38.000000000","message":"Let\u0027s put this at end for better readability.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    resource \u003d \u0027l7policy\u0027"},{"line_number":104,"context_line":"    shadow_resource \u003d \u0027lbaas_l7policy\u0027"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    list_columns \u003d ["},{"line_number":107,"context_line":"        \u0027id\u0027, \u0027name\u0027, \u0027action\u0027, \u0027redirect_pool_id\u0027, \u0027redirect_url\u0027,"},{"line_number":108,"context_line":"        \u0027position\u0027, \u0027admin_state_up\u0027, \u0027status\u0027"},{"line_number":109,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_c9c7db10","line":106,"in_reply_to":"9aed3d3a_76916899","updated":"2016-02-26 20:15:49.000000000","message":"Done","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        parser.add_argument("},{"line_number":130,"context_line":"            \u0027--admin-state-down\u0027,"},{"line_number":131,"context_line":"            dest\u003d\u0027admin_state_up\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":132,"context_line":"            help\u003d_(\u0027Set admin state up to false.\u0027))"},{"line_number":133,"context_line":"        parser.add_argument("},{"line_number":134,"context_line":"            \u0027--listener\u0027, required\u003dTrue, metavar\u003d\u0027LISTENER\u0027,"},{"line_number":135,"context_line":"            help\u003d_(\u0027ID or name of the listener this policy belongs to.\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_f6573800","line":132,"updated":"2016-02-26 11:26:38.000000000","message":"No default value for this?","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        parser.add_argument("},{"line_number":130,"context_line":"            \u0027--admin-state-down\u0027,"},{"line_number":131,"context_line":"            dest\u003d\u0027admin_state_up\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":132,"context_line":"            help\u003d_(\u0027Set admin state up to false.\u0027))"},{"line_number":133,"context_line":"        parser.add_argument("},{"line_number":134,"context_line":"            \u0027--listener\u0027, required\u003dTrue, metavar\u003d\u0027LISTENER\u0027,"},{"line_number":135,"context_line":"            help\u003d_(\u0027ID or name of the listener this policy belongs to.\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_2c3db5bb","line":132,"in_reply_to":"9aed3d3a_f6573800","updated":"2016-02-26 20:15:49.000000000","message":"No. Should be? There is no default for this at any other entity","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            dest\u003d\u0027admin_state_up\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":132,"context_line":"            help\u003d_(\u0027Set admin state up to false.\u0027))"},{"line_number":133,"context_line":"        parser.add_argument("},{"line_number":134,"context_line":"            \u0027--listener\u0027, required\u003dTrue, metavar\u003d\u0027LISTENER\u0027,"},{"line_number":135,"context_line":"            help\u003d_(\u0027ID or name of the listener this policy belongs to.\u0027))"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_73fdfa39","line":134,"updated":"2016-02-26 11:26:38.000000000","message":"please put each param in the separate line for better readability.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            dest\u003d\u0027admin_state_up\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":132,"context_line":"            help\u003d_(\u0027Set admin state up to false.\u0027))"},{"line_number":133,"context_line":"        parser.add_argument("},{"line_number":134,"context_line":"            \u0027--listener\u0027, required\u003dTrue, metavar\u003d\u0027LISTENER\u0027,"},{"line_number":135,"context_line":"            help\u003d_(\u0027ID or name of the listener this policy belongs to.\u0027))"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_6cba1d0c","line":134,"in_reply_to":"9aed3d3a_73fdfa39","updated":"2016-02-26 20:15:49.000000000","message":"Done","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5238b4771cf8365a0ac7193aedc04acf1e0a5828","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"def _common_args2body(client, parsed_args, is_create\u003dTrue):"},{"line_number":83,"context_line":"    attributes \u003d [\u0027name\u0027, \u0027description\u0027, \u0027action\u0027,"},{"line_number":84,"context_line":"                  \u0027redirect_pool_id\u0027, \u0027redirect_url\u0027,"},{"line_number":85,"context_line":"                  \u0027position\u0027, \u0027admin_state_up\u0027]"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9aed3d3a_f5b09745","line":83,"updated":"2016-02-27 12:54:35.000000000","message":"This looks redundant.. I can find the same @L98","commit_id":"d15ad3159c1eb7220d67865d9cfeaed5718c0d0e"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"1c99f67c4b7dbb75e8c00eea663b29374ffe2031","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"def _common_args2body(client, parsed_args, is_create\u003dTrue):"},{"line_number":83,"context_line":"    attributes \u003d [\u0027name\u0027, \u0027description\u0027, \u0027action\u0027,"},{"line_number":84,"context_line":"                  \u0027redirect_pool_id\u0027, \u0027redirect_url\u0027,"},{"line_number":85,"context_line":"                  \u0027position\u0027, \u0027admin_state_up\u0027]"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9aed3d3a_70e135d0","line":83,"in_reply_to":"9aed3d3a_f5b09745","updated":"2016-02-27 14:56:02.000000000","message":"Done","commit_id":"d15ad3159c1eb7220d67865d9cfeaed5718c0d0e"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5238b4771cf8365a0ac7193aedc04acf1e0a5828","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":88,"context_line":"        _validate_url(parsed_args.redirect_url)"},{"line_number":89,"context_line":"        parsed_args.redirect_pool \u003d None"},{"line_number":90,"context_line":"    elif parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":91,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("},{"line_number":92,"context_line":"            client, parsed_args.redirect_pool)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aed3d3a_158d3b7b","line":89,"updated":"2016-02-27 12:54:35.000000000","message":"IMO, it\u0027s not nice to silently ignore an invalid input... i.e. a msg to the user will useful.","commit_id":"d15ad3159c1eb7220d67865d9cfeaed5718c0d0e"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"1c99f67c4b7dbb75e8c00eea663b29374ffe2031","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    if parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":88,"context_line":"        _validate_url(parsed_args.redirect_url)"},{"line_number":89,"context_line":"        parsed_args.redirect_pool \u003d None"},{"line_number":90,"context_line":"    elif parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":91,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("},{"line_number":92,"context_line":"            client, parsed_args.redirect_pool)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aed3d3a_90de790f","line":89,"in_reply_to":"9aed3d3a_158d3b7b","updated":"2016-02-27 14:56:02.000000000","message":"Done","commit_id":"d15ad3159c1eb7220d67865d9cfeaed5718c0d0e"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5238b4771cf8365a0ac7193aedc04acf1e0a5828","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    elif parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":91,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("},{"line_number":92,"context_line":"            client, parsed_args.redirect_pool)"},{"line_number":93,"context_line":"        parsed_args.redirect_url \u003d None"},{"line_number":94,"context_line":"    else:"},{"line_number":95,"context_line":"        parsed_args.redirect_pool \u003d None"},{"line_number":96,"context_line":"        parsed_args.redirect_url \u003d None"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aed3d3a_75eac710","line":93,"updated":"2016-02-27 12:54:35.000000000","message":"ditto.","commit_id":"d15ad3159c1eb7220d67865d9cfeaed5718c0d0e"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"1c99f67c4b7dbb75e8c00eea663b29374ffe2031","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    elif parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":91,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("},{"line_number":92,"context_line":"            client, parsed_args.redirect_pool)"},{"line_number":93,"context_line":"        parsed_args.redirect_url \u003d None"},{"line_number":94,"context_line":"    else:"},{"line_number":95,"context_line":"        parsed_args.redirect_pool \u003d None"},{"line_number":96,"context_line":"        parsed_args.redirect_url \u003d None"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aed3d3a_d0e801b7","line":93,"in_reply_to":"9aed3d3a_75eac710","updated":"2016-02-27 14:56:02.000000000","message":"Done","commit_id":"d15ad3159c1eb7220d67865d9cfeaed5718c0d0e"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5238b4771cf8365a0ac7193aedc04acf1e0a5828","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        parsed_args.redirect_url \u003d None"},{"line_number":94,"context_line":"    else:"},{"line_number":95,"context_line":"        parsed_args.redirect_pool \u003d None"},{"line_number":96,"context_line":"        parsed_args.redirect_url \u003d None"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    attributes \u003d [\u0027name\u0027, \u0027description\u0027,"},{"line_number":99,"context_line":"                  \u0027action\u0027, \u0027redirect_pool_id\u0027, \u0027redirect_url\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aed3d3a_d56e3395","line":96,"updated":"2016-02-27 12:54:35.000000000","message":"How about re-arranging L87-L96 as :\n\n\nif parsed_args.redirect_url:\n    if parsed_args.action !\u003d \u0027REDIRECT_TO_URL\u0027:\n         raise exceptions.CommandError(_(\"Action must be \u0027REDIRECT_TO_URL\u0027))\n        _validate_url(parsed_args.redirect_url)\n....same for others","commit_id":"d15ad3159c1eb7220d67865d9cfeaed5718c0d0e"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"1c99f67c4b7dbb75e8c00eea663b29374ffe2031","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        parsed_args.redirect_url \u003d None"},{"line_number":94,"context_line":"    else:"},{"line_number":95,"context_line":"        parsed_args.redirect_pool \u003d None"},{"line_number":96,"context_line":"        parsed_args.redirect_url \u003d None"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    attributes \u003d [\u0027name\u0027, \u0027description\u0027,"},{"line_number":99,"context_line":"                  \u0027action\u0027, \u0027redirect_pool_id\u0027, \u0027redirect_url\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aed3d3a_30c16d2f","line":96,"in_reply_to":"9aed3d3a_d56e3395","updated":"2016-02-27 14:56:02.000000000","message":"Done","commit_id":"d15ad3159c1eb7220d67865d9cfeaed5718c0d0e"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"e64952d5c2a3f5f04843f78b8ef2504d3d16aeb7","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            raise exceptions.CommandError(_(\u0027Action must be REDIRECT_TO_POOL\u0027))"},{"line_number":90,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("},{"line_number":91,"context_line":"            client, parsed_args.redirect_pool)"},{"line_number":92,"context_line":"    if (parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027 and"},{"line_number":93,"context_line":"            not parsed_args.redirect_url):"},{"line_number":94,"context_line":"        raise exceptions.CommandError(_(\u0027Redirect URL must be specified\u0027))"},{"line_number":95,"context_line":"    if (parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027 and"}],"source_content_type":"text/x-python","patch_set":20,"id":"9aed3d3a_0cf87648","line":92,"updated":"2016-02-29 09:28:20.000000000","message":"This looks un-necessary.. Plz check \u0027 _validate_url\u0027 already ensure this.","commit_id":"1676926a9f1b34528abf55bcb673730ea1845dc0"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"e64952d5c2a3f5f04843f78b8ef2504d3d16aeb7","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    if (parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027 and"},{"line_number":93,"context_line":"            not parsed_args.redirect_url):"},{"line_number":94,"context_line":"        raise exceptions.CommandError(_(\u0027Redirect URL must be specified\u0027))"},{"line_number":95,"context_line":"    if (parsed_args.action \u003d\u003d \u0027REDIRECT_TO_POOL\u0027 and"},{"line_number":96,"context_line":"            not parsed_args.redirect_pool):"},{"line_number":97,"context_line":"        raise exceptions.CommandError(_(\u0027Redirect pool must be specified\u0027))"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"9aed3d3a_4cc39eed","line":95,"updated":"2016-02-29 09:28:20.000000000","message":"I would suggest to have a function called \u0027_validate_actions\u0027 and move all the code from L83-L97 over there.","commit_id":"1676926a9f1b34528abf55bcb673730ea1845dc0"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7823df7897974cd04cf3199600ba014144fb4482","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    if parsed_args.redirect_url:"},{"line_number":78,"context_line":"        if parsed_args.action !\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":79,"context_line":"            raise exceptions.CommandError(_(\u0027Action must be REDIRECT_TO_URL\u0027))"},{"line_number":80,"context_line":"        _validate_url(parsed_args.redirect_url)"},{"line_number":81,"context_line":"    if parsed_args.redirect_pool:"},{"line_number":82,"context_line":"        if parsed_args.action !\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":83,"context_line":"            raise exceptions.CommandError(_(\u0027Action must be REDIRECT_TO_POOL\u0027))"}],"source_content_type":"text/x-python","patch_set":21,"id":"9aed3d3a_1d925ef6","line":80,"updated":"2016-02-29 10:29:57.000000000","message":"What-if parsed_args.redirect_url is not specified? I think, you got to put L86-L88 over here.","commit_id":"340a618025e8c47e7be46785aa204346ba3297bb"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"d53a85d712fcf744155478de5fab790a56bd73a8","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    if parsed_args.redirect_url:"},{"line_number":78,"context_line":"        if parsed_args.action !\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":79,"context_line":"            raise exceptions.CommandError(_(\u0027Action must be REDIRECT_TO_URL\u0027))"},{"line_number":80,"context_line":"        _validate_url(parsed_args.redirect_url)"},{"line_number":81,"context_line":"    if parsed_args.redirect_pool:"},{"line_number":82,"context_line":"        if parsed_args.action !\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":83,"context_line":"            raise exceptions.CommandError(_(\u0027Action must be REDIRECT_TO_POOL\u0027))"}],"source_content_type":"text/x-python","patch_set":21,"id":"9aed3d3a_3ee10e9b","line":80,"in_reply_to":"9aed3d3a_1d925ef6","updated":"2016-02-29 14:06:14.000000000","message":"L77 assures the redirect_url is specified","commit_id":"340a618025e8c47e7be46785aa204346ba3297bb"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"5e01b4a486f078eb0d0c052c6c4a7eb59852cf30","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    if parsed_args.redirect_url:"},{"line_number":78,"context_line":"        if parsed_args.action !\u003d \u0027REDIRECT_TO_URL\u0027:"},{"line_number":79,"context_line":"            raise exceptions.CommandError(_(\u0027Action must be REDIRECT_TO_URL\u0027))"},{"line_number":80,"context_line":"        _validate_url(parsed_args.redirect_url)"},{"line_number":81,"context_line":"    if parsed_args.redirect_pool:"},{"line_number":82,"context_line":"        if parsed_args.action !\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":83,"context_line":"            raise exceptions.CommandError(_(\u0027Action must be REDIRECT_TO_POOL\u0027))"}],"source_content_type":"text/x-python","patch_set":21,"id":"9aed3d3a_833275f0","line":80,"in_reply_to":"9aed3d3a_3ee10e9b","updated":"2016-02-29 17:49:32.000000000","message":"Evgeny is right. +1","commit_id":"340a618025e8c47e7be46785aa204346ba3297bb"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7823df7897974cd04cf3199600ba014144fb4482","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        if parsed_args.action !\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":83,"context_line":"            raise exceptions.CommandError(_(\u0027Action must be REDIRECT_TO_POOL\u0027))"},{"line_number":84,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("},{"line_number":85,"context_line":"            client, parsed_args.redirect_pool)"},{"line_number":86,"context_line":"    if (parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027 and"},{"line_number":87,"context_line":"            not parsed_args.redirect_url):"},{"line_number":88,"context_line":"        raise exceptions.CommandError(_(\u0027Redirect URL must be specified\u0027))"}],"source_content_type":"text/x-python","patch_set":21,"id":"9aed3d3a_dd7916ca","line":85,"updated":"2016-02-29 10:29:57.000000000","message":"ditto","commit_id":"340a618025e8c47e7be46785aa204346ba3297bb"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"5e01b4a486f078eb0d0c052c6c4a7eb59852cf30","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        if parsed_args.action !\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":83,"context_line":"            raise exceptions.CommandError(_(\u0027Action must be REDIRECT_TO_POOL\u0027))"},{"line_number":84,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("},{"line_number":85,"context_line":"            client, parsed_args.redirect_pool)"},{"line_number":86,"context_line":"    if (parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027 and"},{"line_number":87,"context_line":"            not parsed_args.redirect_url):"},{"line_number":88,"context_line":"        raise exceptions.CommandError(_(\u0027Redirect URL must be specified\u0027))"}],"source_content_type":"text/x-python","patch_set":21,"id":"9aed3d3a_e359c136","line":85,"in_reply_to":"9aed3d3a_9ef01a69","updated":"2016-02-29 17:49:32.000000000","message":"Evgeny is right. +1","commit_id":"340a618025e8c47e7be46785aa204346ba3297bb"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"d53a85d712fcf744155478de5fab790a56bd73a8","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        if parsed_args.action !\u003d \u0027REDIRECT_TO_POOL\u0027:"},{"line_number":83,"context_line":"            raise exceptions.CommandError(_(\u0027Action must be REDIRECT_TO_POOL\u0027))"},{"line_number":84,"context_line":"        parsed_args.redirect_pool_id \u003d _get_pool_id("},{"line_number":85,"context_line":"            client, parsed_args.redirect_pool)"},{"line_number":86,"context_line":"    if (parsed_args.action \u003d\u003d \u0027REDIRECT_TO_URL\u0027 and"},{"line_number":87,"context_line":"            not parsed_args.redirect_url):"},{"line_number":88,"context_line":"        raise exceptions.CommandError(_(\u0027Redirect URL must be specified\u0027))"}],"source_content_type":"text/x-python","patch_set":21,"id":"9aed3d3a_9ef01a69","line":85,"in_reply_to":"9aed3d3a_dd7916ca","updated":"2016-02-29 14:06:14.000000000","message":"L81 assures the redirect_pool is specified","commit_id":"340a618025e8c47e7be46785aa204346ba3297bb"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"6ecdf18bce7fcb1ade7408e8ae4adc9069ac8b8b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"             (?:%[0-9a-fA-F][0-9a-fA-F]))+\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def _get_listener_id(client, listener_id_or_name):"},{"line_number":29,"context_line":"    return neutronV20.find_resourceid_by_name_or_id("},{"line_number":30,"context_line":"        client, \u0027listener\u0027, listener_id_or_name)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"9aed3d3a_a0796aca","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":20},"updated":"2016-02-29 19:02:21.000000000","message":"These helpers are starting to feel repetitive. Although, ideally we\u0027d just move the lb client commands in neutron-lbaas repo as a stevedore extension.","commit_id":"2ea83b3ae2536d4c8f4f6bb445558ed934990f93"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"31c08bcc47b05e91d11f560765e130c507f1baf6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"             (?:%[0-9a-fA-F][0-9a-fA-F]))+\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def _get_listener_id(client, listener_id_or_name):"},{"line_number":29,"context_line":"    return neutronV20.find_resourceid_by_name_or_id("},{"line_number":30,"context_line":"        client, \u0027listener\u0027, listener_id_or_name)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"9aed3d3a_a697c246","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":20},"in_reply_to":"9aed3d3a_a0796aca","updated":"2016-02-29 19:39:11.000000000","message":"Yes... I think the reason we define these shortcuts is because neutronV20.find_resourceid_by_name_or_id is too long and redandunt :-(\n\nI am thinking to moe find_resourceid_by_name_or_id and other stuffs into NeutronCommand. We can at least drop \u0027client\u0027.\n\n  self.find_resourceid(\u0027listener\u0027, id_or_name)","commit_id":"2ea83b3ae2536d4c8f4f6bb445558ed934990f93"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"1a691dc4d94b31edc326123da39fb0a4044d7c2b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"             (?:%[0-9a-fA-F][0-9a-fA-F]))+\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def _get_listener_id(client, listener_id_or_name):"},{"line_number":29,"context_line":"    return neutronV20.find_resourceid_by_name_or_id("},{"line_number":30,"context_line":"        client, \u0027listener\u0027, listener_id_or_name)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"9aed3d3a_d77f0ea9","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":20},"in_reply_to":"9aed3d3a_a697c246","updated":"2016-02-29 20:42:27.000000000","message":"Ok; Perhaps something for a later patch, once find_resourceid_by_name_or_id is changed?","commit_id":"2ea83b3ae2536d4c8f4f6bb445558ed934990f93"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"6ecdf18bce7fcb1ade7408e8ae4adc9069ac8b8b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        client, \u0027pool\u0027, pool_id_or_name, cmd_resource\u003d\u0027lbaas_pool\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def _validate_url(redirect_url):"},{"line_number":39,"context_line":"    \"\"\"Redirect URL must be valid URL.\"\"\""},{"line_number":40,"context_line":"    if not re.match(URL_REGEX, redirect_url):"},{"line_number":41,"context_line":"        message \u003d _(\u0027Redirect URL must be a valid URL string\u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"9aed3d3a_40a21e4c","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":17},"updated":"2016-02-29 19:02:21.000000000","message":"I\u0027m always a little leery of potentially over-restricting input, especially when it\u0027s a hand rolled validator like this one. I mean, does the CLI really care what kind of input they want to send?\n\nIsn\u0027t there a urllib helper for this?","commit_id":"2ea83b3ae2536d4c8f4f6bb445558ed934990f93"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"1a691dc4d94b31edc326123da39fb0a4044d7c2b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        client, \u0027pool\u0027, pool_id_or_name, cmd_resource\u003d\u0027lbaas_pool\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def _validate_url(redirect_url):"},{"line_number":39,"context_line":"    \"\"\"Redirect URL must be valid URL.\"\"\""},{"line_number":40,"context_line":"    if not re.match(URL_REGEX, redirect_url):"},{"line_number":41,"context_line":"        message \u003d _(\u0027Redirect URL must be a valid URL string\u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"9aed3d3a_57393ef1","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":17},"in_reply_to":"9aed3d3a_26be1265","updated":"2016-02-29 20:42:27.000000000","message":"Ok, I\u0027ll remove the _validate_url method here since the server-side code checks this anyway.","commit_id":"2ea83b3ae2536d4c8f4f6bb445558ed934990f93"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"31c08bcc47b05e91d11f560765e130c507f1baf6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        client, \u0027pool\u0027, pool_id_or_name, cmd_resource\u003d\u0027lbaas_pool\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def _validate_url(redirect_url):"},{"line_number":39,"context_line":"    \"\"\"Redirect URL must be valid URL.\"\"\""},{"line_number":40,"context_line":"    if not re.match(URL_REGEX, redirect_url):"},{"line_number":41,"context_line":"        message \u003d _(\u0027Redirect URL must be a valid URL string\u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"9aed3d3a_26be1265","line":38,"range":{"start_line":38,"start_character":4,"end_line":38,"end_character":17},"in_reply_to":"9aed3d3a_40a21e4c","updated":"2016-02-29 19:39:11.000000000","message":"I tend to agree with Doug. I am not sure what we want to check and what not. \nFor example, we can use urlparse and check if a schema is acceptable or not.","commit_id":"2ea83b3ae2536d4c8f4f6bb445558ed934990f93"}],"neutronclient/neutron/v2_0/lb/v2/l7rule.py":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":37,"context_line":"        parser.add_argument("},{"line_number":38,"context_line":"            \u0027l7policy\u0027, metavar\u003d\u0027L7POLICY\u0027,"},{"line_number":39,"context_line":"            help\u003d_(\u0027ID or name of the L7 policy this L7 rule belongs to.\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class ListL7Rule(LbaasL7RuleMixin, neutronV20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_cba6ccaa","line":39,"updated":"2015-09-11 05:15:24.000000000","message":"\"ID or name of the L7 policy to which this L7 rule belongs.\"","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":37,"context_line":"        parser.add_argument("},{"line_number":38,"context_line":"            \u0027l7policy\u0027, metavar\u003d\u0027L7POLICY\u0027,"},{"line_number":39,"context_line":"            help\u003d_(\u0027ID or name of the L7 policy this L7 rule belongs to.\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class ListL7Rule(LbaasL7RuleMixin, neutronV20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_da2c1a9b","line":39,"in_reply_to":"da20952f_cba6ccaa","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \u0027--type\u0027,"},{"line_number":84,"context_line":"            required\u003dTrue,"},{"line_number":85,"context_line":"            choices\u003d[\u0027HOST_NAME\u0027, \u0027PATH\u0027, \u0027FILE_TYPE\u0027, \u0027HEADER\u0027, \u0027COOKIE\u0027],"},{"line_number":86,"context_line":"            help\u003d_(\u0027Type of the rule.\u0027))"},{"line_number":87,"context_line":"        parser.add_argument("},{"line_number":88,"context_line":"            \u0027--compare_type\u0027,"},{"line_number":89,"context_line":"            required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_2bac2887","line":86,"updated":"2015-09-11 05:15:24.000000000","message":"Type of rule.","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \u0027--type\u0027,"},{"line_number":84,"context_line":"            required\u003dTrue,"},{"line_number":85,"context_line":"            choices\u003d[\u0027HOST_NAME\u0027, \u0027PATH\u0027, \u0027FILE_TYPE\u0027, \u0027HEADER\u0027, \u0027COOKIE\u0027],"},{"line_number":86,"context_line":"            help\u003d_(\u0027Type of the rule.\u0027))"},{"line_number":87,"context_line":"        parser.add_argument("},{"line_number":88,"context_line":"            \u0027--compare_type\u0027,"},{"line_number":89,"context_line":"            required\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_fa331ef4","line":86,"in_reply_to":"da20952f_2bac2887","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            choices\u003d[\u0027HOST_NAME\u0027, \u0027PATH\u0027, \u0027FILE_TYPE\u0027, \u0027HEADER\u0027, \u0027COOKIE\u0027],"},{"line_number":86,"context_line":"            help\u003d_(\u0027Type of the rule.\u0027))"},{"line_number":87,"context_line":"        parser.add_argument("},{"line_number":88,"context_line":"            \u0027--compare_type\u0027,"},{"line_number":89,"context_line":"            required\u003dTrue,"},{"line_number":90,"context_line":"            choices\u003d[\u0027REGEX\u0027, \u0027STARTS_WITH\u0027, \u0027ENDS_WITH\u0027, \u0027CONTAINS\u0027,"},{"line_number":91,"context_line":"                     \u0027EQUALS_TO\u0027, \u0027GREATER_THAN\u0027, \u0027LESS_THAN\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ebcab04e","line":88,"updated":"2015-09-11 05:15:24.000000000","message":"--compare_type -\u003e --compare-type","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            choices\u003d[\u0027HOST_NAME\u0027, \u0027PATH\u0027, \u0027FILE_TYPE\u0027, \u0027HEADER\u0027, \u0027COOKIE\u0027],"},{"line_number":86,"context_line":"            help\u003d_(\u0027Type of the rule.\u0027))"},{"line_number":87,"context_line":"        parser.add_argument("},{"line_number":88,"context_line":"            \u0027--compare_type\u0027,"},{"line_number":89,"context_line":"            required\u003dTrue,"},{"line_number":90,"context_line":"            choices\u003d[\u0027REGEX\u0027, \u0027STARTS_WITH\u0027, \u0027ENDS_WITH\u0027, \u0027CONTAINS\u0027,"},{"line_number":91,"context_line":"                     \u0027EQUALS_TO\u0027, \u0027GREATER_THAN\u0027, \u0027LESS_THAN\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_ba50460c","line":88,"in_reply_to":"da20952f_ebcab04e","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            choices\u003d[\u0027REGEX\u0027, \u0027STARTS_WITH\u0027, \u0027ENDS_WITH\u0027, \u0027CONTAINS\u0027,"},{"line_number":91,"context_line":"                     \u0027EQUALS_TO\u0027, \u0027GREATER_THAN\u0027, \u0027LESS_THAN\u0027,"},{"line_number":92,"context_line":"                     \u0027GREATER_OR_EQUALS_TO\u0027, \u0027LESS_OR_EQUALS_TO\u0027],"},{"line_number":93,"context_line":"            help\u003d_(\u0027Compare type of the rule.\u0027))"},{"line_number":94,"context_line":"        parser.add_argument("},{"line_number":95,"context_line":"            \u0027--key\u0027,"},{"line_number":96,"context_line":"            help\u003d_(\u0027Key to compare.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_4bb15cdf","line":93,"updated":"2015-09-11 05:15:24.000000000","message":"Compare-type of rule.","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            choices\u003d[\u0027REGEX\u0027, \u0027STARTS_WITH\u0027, \u0027ENDS_WITH\u0027, \u0027CONTAINS\u0027,"},{"line_number":91,"context_line":"                     \u0027EQUALS_TO\u0027, \u0027GREATER_THAN\u0027, \u0027LESS_THAN\u0027,"},{"line_number":92,"context_line":"                     \u0027GREATER_OR_EQUALS_TO\u0027, \u0027LESS_OR_EQUALS_TO\u0027],"},{"line_number":93,"context_line":"            help\u003d_(\u0027Compare type of the rule.\u0027))"},{"line_number":94,"context_line":"        parser.add_argument("},{"line_number":95,"context_line":"            \u0027--key\u0027,"},{"line_number":96,"context_line":"            help\u003d_(\u0027Key to compare.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_7a562e07","line":93,"in_reply_to":"da20952f_4bb15cdf","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return body"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"class UpdateL7Rule(neutronV20.UpdateCommand):"},{"line_number":120,"context_line":"    \"\"\"LBaaS v2 Update a given L7 rule.\"\"\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    resource \u003d \u0027l7rule\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_cbbd6cb2","line":119,"updated":"2015-09-11 05:15:24.000000000","message":"Again, grammar fixes above apply below.","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return body"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"class UpdateL7Rule(neutronV20.UpdateCommand):"},{"line_number":120,"context_line":"    \"\"\"LBaaS v2 Update a given L7 rule.\"\"\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    resource \u003d \u0027l7rule\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_9a59c237","line":119,"in_reply_to":"da20952f_cbbd6cb2","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            choices\u003d[\u0027HOST_NAME\u0027, \u0027PATH\u0027, \u0027FILE_TYPE\u0027, \u0027HEADER\u0027, \u0027COOKIE\u0027],"},{"line_number":132,"context_line":"            help\u003d_(\u0027Type of the rule.\u0027))"},{"line_number":133,"context_line":"        parser.add_argument("},{"line_number":134,"context_line":"            \u0027--compare_type\u0027,"},{"line_number":135,"context_line":"            choices\u003d[\u0027REGEX\u0027, \u0027STARTS_WITH\u0027, \u0027ENDS_WITH\u0027, \u0027CONTAINS\u0027,"},{"line_number":136,"context_line":"                     \u0027EQUALS_TO\u0027, \u0027GREATER_THAN\u0027, \u0027LESS_THAN\u0027,"},{"line_number":137,"context_line":"                     \u0027GREATER_OR_EQUALS_TO\u0027, \u0027LESS_OR_EQUALS_TO\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_2b08a87f","line":134,"updated":"2015-09-11 05:15:24.000000000","message":"--compare_type -\u003e --compare-type","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            choices\u003d[\u0027HOST_NAME\u0027, \u0027PATH\u0027, \u0027FILE_TYPE\u0027, \u0027HEADER\u0027, \u0027COOKIE\u0027],"},{"line_number":132,"context_line":"            help\u003d_(\u0027Type of the rule.\u0027))"},{"line_number":133,"context_line":"        parser.add_argument("},{"line_number":134,"context_line":"            \u0027--compare_type\u0027,"},{"line_number":135,"context_line":"            choices\u003d[\u0027REGEX\u0027, \u0027STARTS_WITH\u0027, \u0027ENDS_WITH\u0027, \u0027CONTAINS\u0027,"},{"line_number":136,"context_line":"                     \u0027EQUALS_TO\u0027, \u0027GREATER_THAN\u0027, \u0027LESS_THAN\u0027,"},{"line_number":137,"context_line":"                     \u0027GREATER_OR_EQUALS_TO\u0027, \u0027LESS_OR_EQUALS_TO\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_5a400a34","line":134,"in_reply_to":"da20952f_2b08a87f","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            self.resource: {}"},{"line_number":155,"context_line":"        }"},{"line_number":156,"context_line":"        neutronV20.update_dict(parsed_args, body[self.resource],"},{"line_number":157,"context_line":"                               [\u0027admin_state_up\u0027, \u0027type\u0027, \u0027compare_type\u0027,"},{"line_number":158,"context_line":"                                \u0027key\u0027, \u0027value\u0027])"},{"line_number":159,"context_line":"        return body"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_6b1220b6","line":157,"updated":"2015-09-11 05:15:24.000000000","message":"Should that be \u0027admin_state\u0027 ?  Or rather, shouldn\u0027t you set admin_state_up above when you initialize the \u0027body\u0027 structure?","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            self.resource: {}"},{"line_number":155,"context_line":"        }"},{"line_number":156,"context_line":"        neutronV20.update_dict(parsed_args, body[self.resource],"},{"line_number":157,"context_line":"                               [\u0027admin_state_up\u0027, \u0027type\u0027, \u0027compare_type\u0027,"},{"line_number":158,"context_line":"                                \u0027key\u0027, \u0027value\u0027])"},{"line_number":159,"context_line":"        return body"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_fa4a3e54","line":157,"in_reply_to":"da20952f_6b1220b6","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ddeafd4deacd4aa8b563e7da6a4e24be3dd02809","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ba63e191_e12237b9","updated":"2016-01-19 02:56:51.000000000","message":"Refer to comments for l7policy.py.\nMost comments apply to this file too.","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Mirantis Inc."},{"line_number":2,"context_line":"# Copyright 2014 Blue Box Group, Inc."},{"line_number":3,"context_line":"# Copyright 2015 Hewlett-Packard Development Company, L.P."},{"line_number":4,"context_line":"# Copyright 2016 Radware LTD."},{"line_number":5,"context_line":"# All Rights Reserved"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_458fef29","line":4,"updated":"2016-02-01 01:03:08.000000000","message":"If this is a new file, then how come it is nearly 4 years old ??? \nI guess you need to specify only 2016 Radware LTD.  ( same goes for l7policy.py file)","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Mirantis Inc."},{"line_number":2,"context_line":"# Copyright 2014 Blue Box Group, Inc."},{"line_number":3,"context_line":"# Copyright 2015 Hewlett-Packard Development Company, L.P."},{"line_number":4,"context_line":"# Copyright 2016 Radware LTD."},{"line_number":5,"context_line":"# All Rights Reserved"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_2d94bf35","line":4,"in_reply_to":"7a5de9d1_458fef29","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            help\u003d_(\u0027ID or name of L7 policy this rule belongs to.\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class ListL7Rule(LbaasL7RuleMixin, neutronV20.ListCommand):"},{"line_number":43,"context_line":"    \"\"\"LBaaS v2 List L7 rules that belong to a given L7 policy.\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    resource \u003d \u0027l7rule\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_85ec07f4","line":42,"updated":"2016-02-01 01:03:08.000000000","message":"You are calling the mixin here, and the Mixin has the add_known_arguments() function.\nWhen we run the lbaas-listl7-rule CLI from neutronclient , would the CLI need the L7POLICY parameter, which is defined in the add_known_arguments() function in the mixin?\n\nGenerally , any list* CLI should not have a necessary parameter.\n( L7Policy, being positional , is a required/necessary parameter to be provided at CLI execution)","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            help\u003d_(\u0027ID or name of L7 policy this rule belongs to.\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class ListL7Rule(LbaasL7RuleMixin, neutronV20.ListCommand):"},{"line_number":43,"context_line":"    \"\"\"LBaaS v2 List L7 rules that belong to a given L7 policy.\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    resource \u003d \u0027l7rule\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_3c8f1225","line":42,"in_reply_to":"7a5de9d1_85ec07f4","updated":"2016-02-04 09:24:06.000000000","message":"I made all commands to inherit from Mixin so policy will be mandatory for all. Also dded function for common params with \"required\" specifier for create and update differences.","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    resource \u003d \u0027l7rule\u0027"},{"line_number":73,"context_line":"    shadow_resource \u003d \u0027lbaas_l7rule\u0027"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":76,"context_line":"        parser.add_argument("},{"line_number":77,"context_line":"            \u0027--admin-state-down\u0027,"},{"line_number":78,"context_line":"            dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_05cd77b6","line":75,"updated":"2016-02-01 01:03:08.000000000","message":"As specified in the other file, please create a single function add_common_args(), which can be called from both Update and Create´s add_known_arguments().\n\nUPDATE: Infact, you can add all the common arguments to the LbaasL7RuleMixin and call it via super.","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    resource \u003d \u0027l7rule\u0027"},{"line_number":73,"context_line":"    shadow_resource \u003d \u0027lbaas_l7rule\u0027"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":76,"context_line":"        parser.add_argument("},{"line_number":77,"context_line":"            \u0027--admin-state-down\u0027,"},{"line_number":78,"context_line":"            dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_5c944e36","line":75,"in_reply_to":"7a5de9d1_05cd77b6","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            help\u003d_(\u0027The description of the rule.\u0027))"},{"line_number":86,"context_line":"        parser.add_argument("},{"line_number":87,"context_line":"            \u0027--type\u0027,"},{"line_number":88,"context_line":"            required\u003dTrue,"},{"line_number":89,"context_line":"            choices\u003d[\u0027HOST_NAME\u0027, \u0027PATH\u0027, \u0027FILE_TYPE\u0027, \u0027HEADER\u0027, \u0027COOKIE\u0027],"},{"line_number":90,"context_line":"            help\u003d_(\u0027Type of rule.\u0027))"},{"line_number":91,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_c5c3df87","line":88,"updated":"2016-02-01 01:03:08.000000000","message":"as mentioned in the other file, use utils.convert_to_uppercase here","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            help\u003d_(\u0027The description of the rule.\u0027))"},{"line_number":86,"context_line":"        parser.add_argument("},{"line_number":87,"context_line":"            \u0027--type\u0027,"},{"line_number":88,"context_line":"            required\u003dTrue,"},{"line_number":89,"context_line":"            choices\u003d[\u0027HOST_NAME\u0027, \u0027PATH\u0027, \u0027FILE_TYPE\u0027, \u0027HEADER\u0027, \u0027COOKIE\u0027],"},{"line_number":90,"context_line":"            help\u003d_(\u0027Type of rule.\u0027))"},{"line_number":91,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_9caac66f","line":88,"in_reply_to":"7a5de9d1_c5c3df87","updated":"2016-02-04 09:24:06.000000000","message":"can\u0027t find this converter. Can you please advise?","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            help\u003d_(\u0027Type of rule.\u0027))"},{"line_number":91,"context_line":"        parser.add_argument("},{"line_number":92,"context_line":"            \u0027--compare-type\u0027,"},{"line_number":93,"context_line":"            required\u003dTrue,"},{"line_number":94,"context_line":"            choices\u003d[\u0027REGEX\u0027, \u0027STARTS_WITH\u0027, \u0027ENDS_WITH\u0027, \u0027CONTAINS\u0027,"},{"line_number":95,"context_line":"                     \u0027EQUALS_TO\u0027, \u0027GREATER_THAN\u0027, \u0027LESS_THAN\u0027,"},{"line_number":96,"context_line":"                     \u0027GREATER_OR_EQUALS_TO\u0027, \u0027LESS_OR_EQUALS_TO\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_85b96717","line":93,"updated":"2016-02-01 01:03:08.000000000","message":"ditto","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            help\u003d_(\u0027ID or name of L7 policy this rule belongs to.\u0027))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def args2body(self, parsed_args):"},{"line_number":115,"context_line":"        self.parent_id \u003d _get_policy_id(self.get_client(),"},{"line_number":116,"context_line":"                                        parsed_args.l7policy)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        body \u003d {\u0027admin_state_up\u0027: parsed_args.admin_state,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_05449718","line":115,"updated":"2016-02-01 01:03:08.000000000","message":"where is this variable being used?","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            help\u003d_(\u0027ID or name of L7 policy this rule belongs to.\u0027))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def args2body(self, parsed_args):"},{"line_number":115,"context_line":"        self.parent_id \u003d _get_policy_id(self.get_client(),"},{"line_number":116,"context_line":"                                        parsed_args.l7policy)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        body \u003d {\u0027admin_state_up\u0027: parsed_args.admin_state,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_fb662928","line":115,"in_reply_to":"5a5ae5dd_c026dbcd","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7d78696820d13cdd623415ba130b32deb5246e60","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            help\u003d_(\u0027ID or name of L7 policy this rule belongs to.\u0027))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def args2body(self, parsed_args):"},{"line_number":115,"context_line":"        self.parent_id \u003d _get_policy_id(self.get_client(),"},{"line_number":116,"context_line":"                                        parsed_args.l7policy)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        body \u003d {\u0027admin_state_up\u0027: parsed_args.admin_state,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_c026dbcd","line":115,"in_reply_to":"7a5de9d1_05449718","updated":"2016-02-04 08:16:24.000000000","message":"Ok, it may be used in the listrule, but need to be sure","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        return {self.resource: body}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class UpdateL7Rule(neutronV20.UpdateCommand):"},{"line_number":128,"context_line":"    \"\"\"LBaaS v2 Update a given L7 rule.\"\"\""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    resource \u003d \u0027l7rule\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_a574a367","line":127,"updated":"2016-02-01 01:03:08.000000000","message":"Why have you created the LbaasL7RuleMixin ?\nIdeally it should be used in the UpdateL7Rule and CreateL7 Rule.\n\nI cannot understand its purpose, when it is not used in the above 2 classes, which basically define the Rule.","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        return {self.resource: body}"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class UpdateL7Rule(neutronV20.UpdateCommand):"},{"line_number":128,"context_line":"    \"\"\"LBaaS v2 Update a given L7 rule.\"\"\""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    resource \u003d \u0027l7rule\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_7cf26a9c","line":127,"in_reply_to":"7a5de9d1_a574a367","updated":"2016-02-04 09:24:06.000000000","message":"Its used in all command now","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"82ac7d79317c005b9e94431a40074d2a2b4457c4","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _add_common_args(parser, enforce_required\u003dFalse):"},{"line_number":41,"context_line":"        parser.add_argument("},{"line_number":42,"context_line":"            \u0027--name\u0027,"},{"line_number":43,"context_line":"            help\u003d_(\u0027The name of the rule.\u0027))"},{"line_number":44,"context_line":"        parser.add_argument("},{"line_number":45,"context_line":"            \u0027--description\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_0013490e","line":42,"updated":"2016-02-22 06:33:58.000000000","message":"L7 rules don\u0027t have a name or description.","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"a9b0a0cfc589af5f5a4a39fdd0342e326ba77926","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _add_common_args(parser, enforce_required\u003dFalse):"},{"line_number":41,"context_line":"        parser.add_argument("},{"line_number":42,"context_line":"            \u0027--name\u0027,"},{"line_number":43,"context_line":"            help\u003d_(\u0027The name of the rule.\u0027))"},{"line_number":44,"context_line":"        parser.add_argument("},{"line_number":45,"context_line":"            \u0027--description\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_7d30f79e","line":42,"in_reply_to":"bae84128_0013490e","updated":"2016-02-22 13:53:32.000000000","message":"Done","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"aec6960cc8473c820d78a7f92949408be0e0a13c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def take_action(self, parsed_args):"},{"line_number":88,"context_line":"        self.parent_id \u003d _get_policy_id(self.get_client(),"},{"line_number":89,"context_line":"                                        parsed_args.l7policy)"},{"line_number":90,"context_line":"        self.values_specs.append(\u0027--l7policy_id\u003d%s\u0027 % self.parent_id)"},{"line_number":91,"context_line":"        return super(ListL7Rule, self).take_action(parsed_args)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_e05e7778","line":90,"updated":"2016-02-19 05:17:33.000000000","message":"URL contains L7 policy ID. Do we need to pass L7 policy ID in a request body too?","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"15eb968fff449338fb1a9a90ddcb1de17e2d1845","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    def take_action(self, parsed_args):"},{"line_number":88,"context_line":"        self.parent_id \u003d _get_policy_id(self.get_client(),"},{"line_number":89,"context_line":"                                        parsed_args.l7policy)"},{"line_number":90,"context_line":"        self.values_specs.append(\u0027--l7policy_id\u003d%s\u0027 % self.parent_id)"},{"line_number":91,"context_line":"        return super(ListL7Rule, self).take_action(parsed_args)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_a54f0fbc","line":90,"in_reply_to":"dae33548_e05e7778","updated":"2016-02-22 06:24:19.000000000","message":"I think that\u0027s only the case for the Octavia URL. Neutron-LBaaS continues to have everything off the root.","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0d8e1a01e3b1753cc337397f9bc76e2f355f5fc0","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                \u0027invert\u0027: parsed_args.invert}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        neutronV20.update_dict("},{"line_number":120,"context_line":"            parsed_args, body, [\u0027name\u0027, \u0027description\u0027, \u0027tenant_id\u0027, \u0027type\u0027,"},{"line_number":121,"context_line":"                                \u0027compare_type\u0027, \u0027key\u0027, \u0027value\u0027])"},{"line_number":122,"context_line":"        return {self.resource: body}"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_e088e524","line":120,"updated":"2016-02-22 06:38:54.000000000","message":"The args2body for create and update are pretty similar ( if not same).\nYou can create a single function to do all the processing and call it from the individual args2body.\n(Kind of DRY principle)","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"a9b0a0cfc589af5f5a4a39fdd0342e326ba77926","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                \u0027invert\u0027: parsed_args.invert}"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        neutronV20.update_dict("},{"line_number":120,"context_line":"            parsed_args, body, [\u0027name\u0027, \u0027description\u0027, \u0027tenant_id\u0027, \u0027type\u0027,"},{"line_number":121,"context_line":"                                \u0027compare_type\u0027, \u0027key\u0027, \u0027value\u0027])"},{"line_number":122,"context_line":"        return {self.resource: body}"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_6fbe76d5","line":120,"in_reply_to":"bae84128_e088e524","updated":"2016-02-22 13:53:32.000000000","message":"I like DRY principle if there is a tangible pruning and no extra complexity added.\nHowever in this case the body and the attributes list are different, so IMO it\u0027s better to leave it as is in this case","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0d8e1a01e3b1753cc337397f9bc76e2f355f5fc0","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        super(UpdateL7Rule, self).add_known_arguments(parser)"},{"line_number":133,"context_line":"        _add_common_args(parser)"},{"line_number":134,"context_line":"        utils.add_boolean_argument("},{"line_number":135,"context_line":"            parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state\u0027,"},{"line_number":136,"context_line":"            help\u003d_(\u0027Specify the administrative state of the rule\u0027"},{"line_number":137,"context_line":"                   \u0027 (True meaning \"Up\").\u0027))"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_80c4795f","line":135,"updated":"2016-02-22 06:38:54.000000000","message":"why do you need this dest?\nYou can skip dest here, and Line#140,as you have already added admin_state_up in Line#144 which updates the body.","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"a9b0a0cfc589af5f5a4a39fdd0342e326ba77926","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        super(UpdateL7Rule, self).add_known_arguments(parser)"},{"line_number":133,"context_line":"        _add_common_args(parser)"},{"line_number":134,"context_line":"        utils.add_boolean_argument("},{"line_number":135,"context_line":"            parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state\u0027,"},{"line_number":136,"context_line":"            help\u003d_(\u0027Specify the administrative state of the rule\u0027"},{"line_number":137,"context_line":"                   \u0027 (True meaning \"Up\").\u0027))"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_e90d6991","line":135,"in_reply_to":"bae84128_80c4795f","updated":"2016-02-22 13:53:32.000000000","message":"Done","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e357a3425e0d8a0c45292c126491b4173233e743","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutronclient.common import utils"},{"line_number":18,"context_line":"from neutronclient.i18n import _"},{"line_number":19,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"bae84128_3873484f","line":18,"range":{"start_line":18,"start_character":19,"end_line":18,"end_character":23},"updated":"2016-02-25 14:09:49.000000000","message":"For a new code \"_i18n\" should be used. \"i18n\" module is deprecated.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutronclient.common import utils"},{"line_number":18,"context_line":"from neutronclient.i18n import _"},{"line_number":19,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_ec446d1c","line":18,"range":{"start_line":18,"start_character":19,"end_line":18,"end_character":23},"in_reply_to":"bae84128_3873484f","updated":"2016-02-26 20:15:49.000000000","message":"Done","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def _get_policy_id(client, policy_id_or_name):"},{"line_number":23,"context_line":"    return neutronV20.find_resourceid_by_name_or_id("},{"line_number":24,"context_line":"        client, \u0027l7policy\u0027, policy_id_or_name,"},{"line_number":25,"context_line":"        cmd_resource\u003d\u0027lbaas_l7policy\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_d65dd4ea","line":22,"updated":"2016-02-26 11:26:38.000000000","message":"IMO, this function must be present in l7policy.py","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def _get_policy_id(client, policy_id_or_name):"},{"line_number":23,"context_line":"    return neutronV20.find_resourceid_by_name_or_id("},{"line_number":24,"context_line":"        client, \u0027l7policy\u0027, policy_id_or_name,"},{"line_number":25,"context_line":"        cmd_resource\u003d\u0027lbaas_l7policy\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_4f5f4b41","line":22,"in_reply_to":"9aed3d3a_d65dd4ea","updated":"2016-02-26 20:15:49.000000000","message":"I do not think so, l7policy module is not using it and it\u0027s not a common practice among neutronclient modules","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            required\u003dis_create,"},{"line_number":44,"context_line":"            type\u003dutils.convert_to_uppercase,"},{"line_number":45,"context_line":"            choices\u003d[\u0027HOST_NAME\u0027, \u0027PATH\u0027, \u0027FILE_TYPE\u0027, \u0027HEADER\u0027, \u0027COOKIE\u0027],"},{"line_number":46,"context_line":"            help\u003d_(\u0027Type of rule.\u0027))"},{"line_number":47,"context_line":"        parser.add_argument("},{"line_number":48,"context_line":"            \u0027--compare-type\u0027,"},{"line_number":49,"context_line":"            required\u003dis_create,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_b68f7022","line":46,"updated":"2016-02-26 11:26:38.000000000","message":"How about \u0027Rule type.\"?","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            required\u003dis_create,"},{"line_number":44,"context_line":"            type\u003dutils.convert_to_uppercase,"},{"line_number":45,"context_line":"            choices\u003d[\u0027HOST_NAME\u0027, \u0027PATH\u0027, \u0027FILE_TYPE\u0027, \u0027HEADER\u0027, \u0027COOKIE\u0027],"},{"line_number":46,"context_line":"            help\u003d_(\u0027Type of rule.\u0027))"},{"line_number":47,"context_line":"        parser.add_argument("},{"line_number":48,"context_line":"            \u0027--compare-type\u0027,"},{"line_number":49,"context_line":"            required\u003dis_create,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_2c78152b","line":46,"in_reply_to":"9aed3d3a_b68f7022","updated":"2016-02-26 20:15:49.000000000","message":"Done","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            type\u003dutils.convert_to_uppercase,"},{"line_number":51,"context_line":"            choices\u003d[\u0027REGEX\u0027, \u0027STARTS_WITH\u0027, \u0027ENDS_WITH\u0027,"},{"line_number":52,"context_line":"                     \u0027CONTAINS\u0027, \u0027EQUAL_TO\u0027],"},{"line_number":53,"context_line":"            help\u003d_(\u0027Compare-type of rule.\u0027))"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--invert-compare\u0027,"},{"line_number":56,"context_line":"            dest\u003d\u0027invert\u0027, action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_167a9c24","line":53,"updated":"2016-02-26 11:26:38.000000000","message":"How about rephrasing as \u0027Rule\u0027s compare-type\u0027?","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            type\u003dutils.convert_to_uppercase,"},{"line_number":51,"context_line":"            choices\u003d[\u0027REGEX\u0027, \u0027STARTS_WITH\u0027, \u0027ENDS_WITH\u0027,"},{"line_number":52,"context_line":"                     \u0027CONTAINS\u0027, \u0027EQUAL_TO\u0027],"},{"line_number":53,"context_line":"            help\u003d_(\u0027Compare-type of rule.\u0027))"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027--invert-compare\u0027,"},{"line_number":56,"context_line":"            dest\u003d\u0027invert\u0027, action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_4ca479a5","line":53,"in_reply_to":"9aed3d3a_167a9c24","updated":"2016-02-26 20:15:49.000000000","message":"Done","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        parser.add_argument("},{"line_number":63,"context_line":"            \u0027--value\u0027,"},{"line_number":64,"context_line":"            required\u003dis_create,"},{"line_number":65,"context_line":"            help\u003d_(\u0027Value to compare.\u0027))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def _common_args2body(client, parsed_args, is_create\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_d6b5d4cd","line":65,"updated":"2016-02-26 11:26:38.000000000","message":"can we elaborate the help a little. To me \u0027value\u0027 doesn\u0027t convey what sort of values we are interested in.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        parser.add_argument("},{"line_number":63,"context_line":"            \u0027--value\u0027,"},{"line_number":64,"context_line":"            required\u003dis_create,"},{"line_number":65,"context_line":"            help\u003d_(\u0027Value to compare.\u0027))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def _common_args2body(client, parsed_args, is_create\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_ec3e2dd9","line":65,"in_reply_to":"9aed3d3a_d6b5d4cd","updated":"2016-02-26 20:15:49.000000000","message":"Can\u0027t think of any text that will elaborate but not entangle. Do you have suggestion?","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":68,"context_line":"def _common_args2body(client, parsed_args, is_create\u003dTrue):"},{"line_number":69,"context_line":"    attributes \u003d [\u0027type\u0027, \u0027compare_type\u0027,"},{"line_number":70,"context_line":"                  \u0027invert\u0027, \u0027key\u0027, \u0027value\u0027, \u0027admin_state_up\u0027]"},{"line_number":71,"context_line":"    if is_create:"},{"line_number":72,"context_line":"        attributes.append(\u0027tenant_id\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    body \u003d {}"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_5618a41d","line":71,"updated":"2016-02-26 11:26:38.000000000","message":"Please move this section to create. It looks like the function is no more common...","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":68,"context_line":"def _common_args2body(client, parsed_args, is_create\u003dTrue):"},{"line_number":69,"context_line":"    attributes \u003d [\u0027type\u0027, \u0027compare_type\u0027,"},{"line_number":70,"context_line":"                  \u0027invert\u0027, \u0027key\u0027, \u0027value\u0027, \u0027admin_state_up\u0027]"},{"line_number":71,"context_line":"    if is_create:"},{"line_number":72,"context_line":"        attributes.append(\u0027tenant_id\u0027)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    body \u003d {}"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_0fcb83a6","line":71,"in_reply_to":"9aed3d3a_5618a41d","updated":"2016-02-26 20:15:49.000000000","message":"Then it will makes this common function just defining attributes list and using it functions - longer and not DRY.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    resource \u003d \u0027rule\u0027"},{"line_number":83,"context_line":"    shadow_resource \u003d \u0027lbaas_l7rule\u0027"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    list_columns \u003d ["},{"line_number":86,"context_line":"        \u0027id\u0027, \u0027type\u0027, \u0027compare_type\u0027, \u0027invert\u0027, \u0027key\u0027, \u0027value\u0027,"},{"line_number":87,"context_line":"        \u0027admin_state_up\u0027, \u0027status\u0027"},{"line_number":88,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_56ef04e8","line":85,"updated":"2016-02-26 11:26:38.000000000","message":"move to end for better readability.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    resource \u003d \u0027rule\u0027"},{"line_number":83,"context_line":"    shadow_resource \u003d \u0027lbaas_l7rule\u0027"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    list_columns \u003d ["},{"line_number":86,"context_line":"        \u0027id\u0027, \u0027type\u0027, \u0027compare_type\u0027, \u0027invert\u0027, \u0027key\u0027, \u0027value\u0027,"},{"line_number":87,"context_line":"        \u0027admin_state_up\u0027, \u0027status\u0027"},{"line_number":88,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_6f168ff2","line":85,"in_reply_to":"9aed3d3a_56ef04e8","updated":"2016-02-26 20:15:49.000000000","message":"Done","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":113,"context_line":"        super(CreateL7Rule, self).add_known_arguments(parser)"},{"line_number":114,"context_line":"        _add_common_args(parser)"},{"line_number":115,"context_line":"        parser.add_argument("},{"line_number":116,"context_line":"            \u0027--admin-state-down\u0027,"},{"line_number":117,"context_line":"            dest\u003d\u0027admin_state_up\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":118,"context_line":"            help\u003d_(\u0027Set admin state up to false\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_1693bc5c","line":115,"updated":"2016-02-26 11:26:38.000000000","message":"I can find the same attribute in l7policy.py. Can we put this at a common place and use. Just a thought.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":113,"context_line":"        super(CreateL7Rule, self).add_known_arguments(parser)"},{"line_number":114,"context_line":"        _add_common_args(parser)"},{"line_number":115,"context_line":"        parser.add_argument("},{"line_number":116,"context_line":"            \u0027--admin-state-down\u0027,"},{"line_number":117,"context_line":"            dest\u003d\u0027admin_state_up\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":118,"context_line":"            help\u003d_(\u0027Set admin state up to false\u0027))"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_8fc9537b","line":115,"in_reply_to":"9aed3d3a_1693bc5c","updated":"2016-02-26 20:15:49.000000000","message":"I do not think so. This attribute exists in ALL entities. Your suggestion should better taken care of as a separate code enhancing patch for all neutron CLI modules.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        super(UpdateL7Rule, self).add_known_arguments(parser)"},{"line_number":132,"context_line":"        _add_common_args(parser, False)"},{"line_number":133,"context_line":"        utils.add_boolean_argument("},{"line_number":134,"context_line":"            parser, \u0027--admin-state-up\u0027,"},{"line_number":135,"context_line":"            help\u003d_(\u0027Specify the administrative state of the rule\u0027"},{"line_number":136,"context_line":"                   \u0027 (True meaning \"Up\").\u0027))"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_76a048a0","line":134,"updated":"2016-02-26 11:26:38.000000000","message":"ditto","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"}],"neutronclient/tests/unit/lb/v2/test_cli20_l7policy.py":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Radware LTD.\r"},{"line_number":2,"context_line":"# All Rights Reserved\r"},{"line_number":3,"context_line":"#\r"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_cb700c0b","line":1,"updated":"2015-09-11 05:15:24.000000000","message":"There are a lot of carriage returns in this file. Can you run it through \u0027dos2unix\u0027 or something to get rid of those?","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Radware LTD.\r"},{"line_number":2,"context_line":"# All Rights Reserved\r"},{"line_number":3,"context_line":"#\r"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_45afd029","line":1,"in_reply_to":"da20952f_cb700c0b","updated":"2015-09-20 09:59:17.000000000","message":"Done","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"66f4fa4e402f8eef13504d376bf5af9a634d2531","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                                   args, position_names, position_values,\r"},{"line_number":64,"context_line":"                                   cmd_resource\u003dcmd_resource)\r"},{"line_number":65,"context_line":"        return\r"},{"line_number":66,"context_line":"\r"},{"line_number":67,"context_line":"    def test_list_policies(self):\r"},{"line_number":68,"context_line":"        \"\"\"lbaas-l7policy-list.\"\"\"\r"},{"line_number":69,"context_line":"        resources \u003d \u0027l7policies\u0027\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_4bb71c85","line":66,"updated":"2015-09-11 05:15:24.000000000","message":"There are some other failure conditions I would like to see caught by the CLI:\n\nPlease test trying to create a policy with \u0027redirect_to_pool\u0027 that:\n\n1. Doesn\u0027t have a pool specified\n2. Has an invalid pool specified\n3. Has a valid pool specified, but does not match the listener\n\nPlease test trying to create a policy with \u0027redirect_to_url\u0027 that:\n\n1. Doesn\u0027t have a redirect_url specified\n2. Has a redirect_url specified that does not pass an HTTP regex check.","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"77b42f4191fa460e591452e185499b55a91ead2a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                                   args, position_names, position_values,\r"},{"line_number":64,"context_line":"                                   cmd_resource\u003dcmd_resource)\r"},{"line_number":65,"context_line":"        return\r"},{"line_number":66,"context_line":"\r"},{"line_number":67,"context_line":"    def test_list_policies(self):\r"},{"line_number":68,"context_line":"        \"\"\"lbaas-l7policy-list.\"\"\"\r"},{"line_number":69,"context_line":"        resources \u003d \u0027l7policies\u0027\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_37b3ef51","line":66,"in_reply_to":"da20952f_4bb71c85","updated":"2015-09-20 09:59:17.000000000","message":"Those failures are checked in API and also unit tested there.\n\nWill check the pool-id absence in here","commit_id":"7d894ee8eea8e64cdcb0c60332a2326b3ff53039"},{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"511d873280bd9219901892b27f4160e2ba45ba5c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutronclient.neutron.v2_0.lb.v2 import l7policy\r"},{"line_number":20,"context_line":"from neutronclient.tests.unit import test_cli20\r"},{"line_number":21,"context_line":"\r"},{"line_number":22,"context_line":"\r"},{"line_number":23,"context_line":"class CLITestV20LbL7PolicyJSON(test_cli20.CLITestV20Base):\r"},{"line_number":24,"context_line":"    def test_create_policy_with_mandatory_params(self):\r"},{"line_number":25,"context_line":"        \"\"\"lbaas-l7policy-create with mandatory params only.\"\"\"\r"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_6730879f","line":22,"updated":"2015-09-21 05:26:58.000000000","message":"Please check editor settings, why \u0027\\r\u0027 at end of each line.\ntest_cli20_l7rule.py file changes looks ok","commit_id":"55d576cb28fb900060a262e9a43d364ec60bedfc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"aec6960cc8473c820d78a7f92949408be0e0a13c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self._test_create_resource(resource, cmd, \u0027\u0027, my_id, args,"},{"line_number":37,"context_line":"                                   position_names, position_values,"},{"line_number":38,"context_line":"                                   cmd_resource\u003dcmd_resource)"},{"line_number":39,"context_line":"        return"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_create_policy_with_all_params(self):"},{"line_number":42,"context_line":"        # lbaas-l7policy-create with all params set."}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_20d05fc9","line":39,"range":{"start_line":39,"start_character":7,"end_line":39,"end_character":14},"updated":"2016-02-19 05:17:33.000000000","message":"\u0027return\u0027 at the bottom of a method is unnecessary","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"15eb968fff449338fb1a9a90ddcb1de17e2d1845","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self._test_create_resource(resource, cmd, \u0027\u0027, my_id, args,"},{"line_number":37,"context_line":"                                   position_names, position_values,"},{"line_number":38,"context_line":"                                   cmd_resource\u003dcmd_resource)"},{"line_number":39,"context_line":"        return"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_create_policy_with_all_params(self):"},{"line_number":42,"context_line":"        # lbaas-l7policy-create with all params set."}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_05a35b50","line":39,"range":{"start_line":39,"start_character":7,"end_line":39,"end_character":14},"in_reply_to":"dae33548_20d05fc9","updated":"2016-02-22 06:24:19.000000000","message":"+1","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"a9b0a0cfc589af5f5a4a39fdd0342e326ba77926","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self._test_create_resource(resource, cmd, \u0027\u0027, my_id, args,"},{"line_number":37,"context_line":"                                   position_names, position_values,"},{"line_number":38,"context_line":"                                   cmd_resource\u003dcmd_resource)"},{"line_number":39,"context_line":"        return"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_create_policy_with_all_params(self):"},{"line_number":42,"context_line":"        # lbaas-l7policy-create with all params set."}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_afafde92","line":39,"range":{"start_line":39,"start_character":7,"end_line":39,"end_character":14},"in_reply_to":"dae33548_20d05fc9","updated":"2016-02-22 13:53:32.000000000","message":"Done","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"15eb968fff449338fb1a9a90ddcb1de17e2d1845","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                   cmd_resource\u003dcmd_resource)"},{"line_number":39,"context_line":"        return"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_create_policy_with_all_params(self):"},{"line_number":42,"context_line":"        # lbaas-l7policy-create with all params set."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        resource \u003d \u0027l7policy\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_e563d718","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":42},"updated":"2016-02-22 06:24:19.000000000","message":"We should also test the creation of a REDIRECT_TO_POOL policy and REDIRECT_TO_URL policy, as these will have different requirements for the command-line.","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"a9b0a0cfc589af5f5a4a39fdd0342e326ba77926","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                   cmd_resource\u003dcmd_resource)"},{"line_number":39,"context_line":"        return"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_create_policy_with_all_params(self):"},{"line_number":42,"context_line":"        # lbaas-l7policy-create with all params set."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        resource \u003d \u0027l7policy\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_a55c1dee","line":41,"range":{"start_line":41,"start_character":8,"end_line":41,"end_character":42},"in_reply_to":"bae84128_e563d718","updated":"2016-02-22 13:53:32.000000000","message":"Done","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"706acbde4b7ce6ad82e3d0def35810cf0a74808d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                                   args, position_names, position_values,"},{"line_number":86,"context_line":"                                   cmd_resource\u003dcmd_resource)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_create_pool_redirect_policy_with_all_params(self):"},{"line_number":89,"context_line":"        # lbaas-l7policy-create with all params set."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        resource \u003d \u0027l7policy\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_265477c8","line":88,"updated":"2016-02-23 01:07:17.000000000","message":"Test cases for UpdatePolicy with similar scenarios should also be made","commit_id":"665960dcdd2970c6de86fb0d18c0f31a29835a93"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"3d70e8f646aaa6df7641e42cfa05850dcdd730f1","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                                   args, position_names, position_values,"},{"line_number":86,"context_line":"                                   cmd_resource\u003dcmd_resource)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_create_pool_redirect_policy_with_all_params(self):"},{"line_number":89,"context_line":"        # lbaas-l7policy-create with all params set."},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        resource \u003d \u0027l7policy\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_9ba80e79","line":88,"in_reply_to":"bae84128_265477c8","updated":"2016-02-24 08:54:29.000000000","message":"Done","commit_id":"665960dcdd2970c6de86fb0d18c0f31a29835a93"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"5277b77b57b59d7eeb76423e08265e1369a59004","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                cli_args.append(args_conf[arg][1])"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"            api_args[args_conf[arg][0]] \u003d\\"},{"line_number":56,"context_line":"                kwargs[arg] if arg in kwargs else args_conf[arg][2]"},{"line_number":57,"context_line":"        return cli_args, api_args"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _test_create_policy(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bae84128_0b1a856e","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":67},"updated":"2016-02-25 08:30:53.000000000","message":"Er... given the fact that this one-liner was too long to fit on one line, could you please re-write it in standard if / else format (ie. use 4 lines, and make it much more readable?)","commit_id":"da9edf51528074c1d7c173e1b0040a97dbe2f42a"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"5277b77b57b59d7eeb76423e08265e1369a59004","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                                    \u0027redirect-pool\u0027: \u0027id\u0027})"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def test_update_url_redirect_policy(self):"},{"line_number":188,"context_line":"        # lbaas-l7policy-update test_id --action REDIRECT_TO_URLL"},{"line_number":189,"context_line":"        #    --redirect-url http://other_url."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        self._test_update_policy(\u0027action\u0027, \u0027redirect-url\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"bae84128_b0b5c47f","line":188,"range":{"start_line":188,"start_character":49,"end_line":188,"end_character":65},"updated":"2016-02-25 08:30:53.000000000","message":"Nit: extra \u0027L\u0027","commit_id":"da9edf51528074c1d7c173e1b0040a97dbe2f42a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e357a3425e0d8a0c45292c126491b4173233e743","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class CLITestV20LbL7PolicyJSON(test_cli20.CLITestV20Base):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    \"\"\"Function for generically building testing arguments\"\"\""},{"line_number":43,"context_line":"    def _get_test_args(self, *args, **kwargs):"},{"line_number":44,"context_line":"        cli_args \u003d []"},{"line_number":45,"context_line":"        api_args \u003d {}"}],"source_content_type":"text/x-python","patch_set":16,"id":"bae84128_183f6426","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":61},"updated":"2016-02-25 14:09:49.000000000","message":"The method docstring is usually placed after the method name.\n\n  def _get_test_args(...):\n      \"\"\"Function for generically building ....\"\"\"","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class CLITestV20LbL7PolicyJSON(test_cli20.CLITestV20Base):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    \"\"\"Function for generically building testing arguments\"\"\""},{"line_number":43,"context_line":"    def _get_test_args(self, *args, **kwargs):"},{"line_number":44,"context_line":"        cli_args \u003d []"},{"line_number":45,"context_line":"        api_args \u003d {}"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_4f8aabc0","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":61},"in_reply_to":"bae84128_183f6426","updated":"2016-02-26 20:15:49.000000000","message":"Done","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"192a53c725770e91b8668ff443a0f5acf56a9b52","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        # lbaas-l7policy-create disabled REJECT policy."},{"line_number":92,"context_line":"        self._test_create_policy(\u0027action\u0027, \u0027listener\u0027, \u0027admin-state-down\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_create_url_redirect_policy(self):"},{"line_number":95,"context_line":"        # lbaas-l7policy-create REDIRECT_TO_URL policy."},{"line_number":96,"context_line":"        self._test_create_policy(\u0027name\u0027, \u0027description\u0027,"},{"line_number":97,"context_line":"                                 \u0027action\u0027, \u0027listener\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_364080a5","line":94,"updated":"2016-02-26 11:26:38.000000000","message":"Plz add tests for validating url for action\u003d\u003dREDIRECT_TO_URL only and vice-versa.\n\nSimilar tests can also be added for other actions.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5238b4771cf8365a0ac7193aedc04acf1e0a5828","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        # lbaas-l7policy-create disabled REJECT policy."},{"line_number":95,"context_line":"        self._test_create_policy(\u0027action\u0027, \u0027listener\u0027, \u0027admin-state-down\u0027)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def test_create_url_redirect_policy(self):"},{"line_number":98,"context_line":"        # lbaas-l7policy-create REDIRECT_TO_URL policy."},{"line_number":99,"context_line":"        self._test_create_policy(\u0027name\u0027, \u0027description\u0027,"},{"line_number":100,"context_line":"                                 \u0027action\u0027, \u0027listener\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aed3d3a_f5fa57bc","line":97,"updated":"2016-02-27 12:54:35.000000000","message":"Consider PS16 comment","commit_id":"d15ad3159c1eb7220d67865d9cfeaed5718c0d0e"}],"neutronclient/tests/unit/lb/v2/test_cli20_l7rule.py":[{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"15eb968fff449338fb1a9a90ddcb1de17e2d1845","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                   cmd_resource\u003dcmd_resource,"},{"line_number":40,"context_line":"                                   parent_id\u003d\u0027policy\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_create_rule_with_all_params(self):"},{"line_number":43,"context_line":"        # lbaas-l7rule-create with all params set."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        resource \u003d \u0027l7rule\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_a5826f92","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":40},"updated":"2016-02-22 06:24:19.000000000","message":"Should test creating a rule that requires the \u0027key\u0027 attribute and one that does not, so that all code paths are investigated here, eh.","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"a9b0a0cfc589af5f5a4a39fdd0342e326ba77926","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                   cmd_resource\u003dcmd_resource,"},{"line_number":40,"context_line":"                                   parent_id\u003d\u0027policy\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_create_rule_with_all_params(self):"},{"line_number":43,"context_line":"        # lbaas-l7rule-create with all params set."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        resource \u003d \u0027l7rule\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_45e711b0","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":40},"in_reply_to":"bae84128_a5826f92","updated":"2016-02-22 13:53:32.000000000","message":"Done","commit_id":"9729d2f639dd897c4ad18eb8422c28ec7a34eade"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"706acbde4b7ce6ad82e3d0def35810cf0a74808d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                                   cmd_resource\u003dcmd_resource,"},{"line_number":59,"context_line":"                                   parent_id\u003d\u0027policy\u0027)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_create_rule_with_all_params_without_key(self):"},{"line_number":62,"context_line":"        # lbaas-l7rule-create with all params set."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        resource \u003d \u0027l7rule\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_a60d27ea","line":61,"updated":"2016-02-23 01:07:17.000000000","message":"This and the above test case are pretty similar, if possible can you reuse the above code in a single function ( this is just a suggestion.. such a cleanup is necessary in neutronclient over the long haul)","commit_id":"665960dcdd2970c6de86fb0d18c0f31a29835a93"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"3d70e8f646aaa6df7641e42cfa05850dcdd730f1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                                   cmd_resource\u003dcmd_resource,"},{"line_number":59,"context_line":"                                   parent_id\u003d\u0027policy\u0027)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_create_rule_with_all_params_without_key(self):"},{"line_number":62,"context_line":"        # lbaas-l7rule-create with all params set."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        resource \u003d \u0027l7rule\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_378e152e","line":61,"in_reply_to":"bae84128_a60d27ea","updated":"2016-02-24 08:54:29.000000000","message":"Done","commit_id":"665960dcdd2970c6de86fb0d18c0f31a29835a93"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"5277b77b57b59d7eeb76423e08265e1369a59004","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                cli_args.append(args_conf[arg][1])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"            api_args[args_conf[arg][0]] \u003d\\"},{"line_number":55,"context_line":"                kwargs[arg] if arg in kwargs else args_conf[arg][2]"},{"line_number":56,"context_line":"        if \u0027invert\u0027 not in api_args:"},{"line_number":57,"context_line":"            api_args[\u0027invert\u0027] \u003d False"},{"line_number":58,"context_line":"        return cli_args, api_args"}],"source_content_type":"text/x-python","patch_set":15,"id":"bae84128_abf27904","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":67},"updated":"2016-02-25 08:30:53.000000000","message":"Same deal here: It is much easier to understand what you\u0027re doing here if you write it in standard if / else format instead of doing it as a one-liner (which is too long to fit on a single line anyway).","commit_id":"da9edf51528074c1d7c173e1b0040a97dbe2f42a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e357a3425e0d8a0c45292c126491b4173233e743","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class CLITestV20LbL7RuleJSON(test_cli20.CLITestV20Base):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    \"\"\"Function for generically building testing arguments\"\"\""},{"line_number":42,"context_line":"    def _get_test_args(self, *args, **kwargs):"},{"line_number":43,"context_line":"        cli_args \u003d []"},{"line_number":44,"context_line":"        api_args \u003d {}"}],"source_content_type":"text/x-python","patch_set":16,"id":"bae84128_18548452","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":61},"updated":"2016-02-25 14:09:49.000000000","message":"Same as for test l7policy.","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class CLITestV20LbL7RuleJSON(test_cli20.CLITestV20Base):"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    \"\"\"Function for generically building testing arguments\"\"\""},{"line_number":42,"context_line":"    def _get_test_args(self, *args, **kwargs):"},{"line_number":43,"context_line":"        cli_args \u003d []"},{"line_number":44,"context_line":"        api_args \u003d {}"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_b2611cab","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":61},"in_reply_to":"bae84128_18548452","updated":"2016-02-26 20:15:49.000000000","message":"Done","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ddeafd4deacd4aa8b563e7da6a4e24be3dd02809","unresolved":false,"context_lines":[{"line_number":972,"context_line":"        return self.delete(self.lbaas_listener_path % (lbaas_listener))"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"    @APIParamsCall"},{"line_number":975,"context_line":"    def list_l7policies(self, listener, retrieve_all\u003dTrue, **_params):"},{"line_number":976,"context_line":"        \"\"\"Fetches a list of all l7 policies for a listener.\"\"\""},{"line_number":977,"context_line":"        return self.list(\u0027l7policies\u0027, self.lbaas_l7policies_path,"},{"line_number":978,"context_line":"                         retrieve_all, **_params)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_21b5afcc","line":975,"range":{"start_line":975,"start_character":30,"end_line":975,"end_character":38},"updated":"2016-01-19 02:56:51.000000000","message":"\"listener\" is not used. Don\u0027t we need to use \"listener\"? If not used, it looks unnecessary.","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"5f22288947b351cf7427f3627904d682c1ac685a","unresolved":false,"context_lines":[{"line_number":972,"context_line":"        return self.delete(self.lbaas_listener_path % (lbaas_listener))"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"    @APIParamsCall"},{"line_number":975,"context_line":"    def list_l7policies(self, listener, retrieve_all\u003dTrue, **_params):"},{"line_number":976,"context_line":"        \"\"\"Fetches a list of all l7 policies for a listener.\"\"\""},{"line_number":977,"context_line":"        return self.list(\u0027l7policies\u0027, self.lbaas_l7policies_path,"},{"line_number":978,"context_line":"                         retrieve_all, **_params)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_89b37d0a","line":975,"range":{"start_line":975,"start_character":30,"end_line":975,"end_character":38},"in_reply_to":"ba63e191_21b5afcc","updated":"2016-01-28 10:12:45.000000000","message":"Done","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ddeafd4deacd4aa8b563e7da6a4e24be3dd02809","unresolved":false,"context_lines":[{"line_number":978,"context_line":"                         retrieve_all, **_params)"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"    @APIParamsCall"},{"line_number":981,"context_line":"    def show_l7policy(self, l7policy, listener, **_params):"},{"line_number":982,"context_line":"        \"\"\"Fetches information of a certain listener\u0027s l7 policy.\"\"\""},{"line_number":983,"context_line":"        return self.get(self.lbaas_l7policy_path % l7policy,"},{"line_number":984,"context_line":"                        params\u003d_params)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_c1ca934f","line":981,"range":{"start_line":981,"start_character":38,"end_line":981,"end_character":46},"updated":"2016-01-19 02:56:51.000000000","message":"ditto","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"5f22288947b351cf7427f3627904d682c1ac685a","unresolved":false,"context_lines":[{"line_number":978,"context_line":"                         retrieve_all, **_params)"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"    @APIParamsCall"},{"line_number":981,"context_line":"    def show_l7policy(self, l7policy, listener, **_params):"},{"line_number":982,"context_line":"        \"\"\"Fetches information of a certain listener\u0027s l7 policy.\"\"\""},{"line_number":983,"context_line":"        return self.get(self.lbaas_l7policy_path % l7policy,"},{"line_number":984,"context_line":"                        params\u003d_params)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_a9baf96c","line":981,"range":{"start_line":981,"start_character":38,"end_line":981,"end_character":46},"in_reply_to":"ba63e191_c1ca934f","updated":"2016-01-28 10:12:45.000000000","message":"Done","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ddeafd4deacd4aa8b563e7da6a4e24be3dd02809","unresolved":false,"context_lines":[{"line_number":984,"context_line":"                        params\u003d_params)"},{"line_number":985,"context_line":""},{"line_number":986,"context_line":"    @APIParamsCall"},{"line_number":987,"context_line":"    def create_l7policy(self, listener, body\u003dNone):"},{"line_number":988,"context_line":"        \"\"\"Creates l7 policy for a certain listener.\"\"\""},{"line_number":989,"context_line":"        return self.post(self.lbaas_l7policies_path, body\u003dbody)"},{"line_number":990,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_e1c79743","line":987,"range":{"start_line":987,"start_character":30,"end_line":987,"end_character":38},"updated":"2016-01-19 02:56:51.000000000","message":"ditto","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"5f22288947b351cf7427f3627904d682c1ac685a","unresolved":false,"context_lines":[{"line_number":984,"context_line":"                        params\u003d_params)"},{"line_number":985,"context_line":""},{"line_number":986,"context_line":"    @APIParamsCall"},{"line_number":987,"context_line":"    def create_l7policy(self, listener, body\u003dNone):"},{"line_number":988,"context_line":"        \"\"\"Creates l7 policy for a certain listener.\"\"\""},{"line_number":989,"context_line":"        return self.post(self.lbaas_l7policies_path, body\u003dbody)"},{"line_number":990,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_49b0258c","line":987,"range":{"start_line":987,"start_character":30,"end_line":987,"end_character":38},"in_reply_to":"ba63e191_e1c79743","updated":"2016-01-28 10:12:45.000000000","message":"Done","commit_id":"e0a3a0b86c4177f375426a5cf9f2923e91fef506"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    lbaas_listeners_path \u003d \"/lbaas/listeners\""},{"line_number":370,"context_line":"    lbaas_listener_path \u003d \"/lbaas/listeners/%s\""},{"line_number":371,"context_line":"    lbaas_l7policies_path \u003d \"/lbaas/l7policies\""},{"line_number":372,"context_line":"    lbaas_l7policy_path \u003d \"/lbaas/l7policy/%s\""},{"line_number":373,"context_line":"    lbaas_l7rules_path \u003d lbaas_l7policy_path + \"/rules\""},{"line_number":374,"context_line":"    lbaas_l7rule_path \u003d lbaas_l7policy_path + \"/rule/%s\""},{"line_number":375,"context_line":"    lbaas_pools_path \u003d \"/lbaas/pools\""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_25a3d3b3","line":372,"updated":"2016-02-01 01:03:08.000000000","message":"this will be /lbaas/l7policies/%s  ( please see ipsecpolicy, ikepolicy, loadbalancer and listener defined above for the example)","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    lbaas_listeners_path \u003d \"/lbaas/listeners\""},{"line_number":370,"context_line":"    lbaas_listener_path \u003d \"/lbaas/listeners/%s\""},{"line_number":371,"context_line":"    lbaas_l7policies_path \u003d \"/lbaas/l7policies\""},{"line_number":372,"context_line":"    lbaas_l7policy_path \u003d \"/lbaas/l7policy/%s\""},{"line_number":373,"context_line":"    lbaas_l7rules_path \u003d lbaas_l7policy_path + \"/rules\""},{"line_number":374,"context_line":"    lbaas_l7rule_path \u003d lbaas_l7policy_path + \"/rule/%s\""},{"line_number":375,"context_line":"    lbaas_pools_path \u003d \"/lbaas/pools\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_dea1dbaa","line":372,"in_reply_to":"7a5de9d1_25a3d3b3","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7ead3be94b143c9a4789950f2613ccce381eedfb","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    lbaas_l7policies_path \u003d \"/lbaas/l7policies\""},{"line_number":372,"context_line":"    lbaas_l7policy_path \u003d \"/lbaas/l7policy/%s\""},{"line_number":373,"context_line":"    lbaas_l7rules_path \u003d lbaas_l7policy_path + \"/rules\""},{"line_number":374,"context_line":"    lbaas_l7rule_path \u003d lbaas_l7policy_path + \"/rule/%s\""},{"line_number":375,"context_line":"    lbaas_pools_path \u003d \"/lbaas/pools\""},{"line_number":376,"context_line":"    lbaas_pool_path \u003d \"/lbaas/pools/%s\""},{"line_number":377,"context_line":"    lbaas_healthmonitors_path \u003d \"/lbaas/healthmonitors\""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_05aed797","line":374,"updated":"2016-02-01 01:03:08.000000000","message":"this can be simplified as : \nlbaas_l7rule_path \u003d lbaas_l7rules_path + ¨/%s¨","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"31936b5ec37b6799b4a46d532169fe170e52a818","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    lbaas_l7policies_path \u003d \"/lbaas/l7policies\""},{"line_number":372,"context_line":"    lbaas_l7policy_path \u003d \"/lbaas/l7policy/%s\""},{"line_number":373,"context_line":"    lbaas_l7rules_path \u003d lbaas_l7policy_path + \"/rules\""},{"line_number":374,"context_line":"    lbaas_l7rule_path \u003d lbaas_l7policy_path + \"/rule/%s\""},{"line_number":375,"context_line":"    lbaas_pools_path \u003d \"/lbaas/pools\""},{"line_number":376,"context_line":"    lbaas_pool_path \u003d \"/lbaas/pools/%s\""},{"line_number":377,"context_line":"    lbaas_healthmonitors_path \u003d \"/lbaas/healthmonitors\""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_fea4d7b9","line":374,"in_reply_to":"7a5de9d1_05aed797","updated":"2016-02-04 09:24:06.000000000","message":"Done","commit_id":"68dcb17f16dc1cd368125ae1e9485abc000deed5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e357a3425e0d8a0c45292c126491b4173233e743","unresolved":false,"context_lines":[{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    @APIParamsCall"},{"line_number":991,"context_line":"    def list_lbaas_l7policies(self, retrieve_all\u003dTrue, **_params):"},{"line_number":992,"context_line":"        \"\"\"Fetches a list of all l7 policies for a listener.\"\"\""},{"line_number":993,"context_line":"        return self.list(\u0027l7policies\u0027, self.lbaas_l7policies_path,"},{"line_number":994,"context_line":"                         retrieve_all, **_params)"},{"line_number":995,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"bae84128_1802c43e","line":992,"range":{"start_line":992,"start_character":33,"end_line":992,"end_character":35},"updated":"2016-02-25 14:09:49.000000000","message":"For readability in the help, I prefer to \"L7\" (upper case).","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"033875dac65c0bc6cb832cc57b3b3d41006cf636","unresolved":false,"context_lines":[{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    @APIParamsCall"},{"line_number":991,"context_line":"    def list_lbaas_l7policies(self, retrieve_all\u003dTrue, **_params):"},{"line_number":992,"context_line":"        \"\"\"Fetches a list of all l7 policies for a listener.\"\"\""},{"line_number":993,"context_line":"        return self.list(\u0027l7policies\u0027, self.lbaas_l7policies_path,"},{"line_number":994,"context_line":"                         retrieve_all, **_params)"},{"line_number":995,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_d205c0c2","line":992,"range":{"start_line":992,"start_character":33,"end_line":992,"end_character":35},"in_reply_to":"bae84128_1802c43e","updated":"2016-02-26 20:15:49.000000000","message":"Done","commit_id":"956335d24d237ac3787f36818319b850bb22bb69"}],"releasenotes/notes/add-l7-content-policies-capability-0f17cd06f044c83c.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"31c08bcc47b05e91d11f560765e130c507f1baf6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      having the ability to set policies order."},{"line_number":9,"context_line":"    * Multiple rules could be created for L7 policy."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"upgrade:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    New database tables added."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    * lbaas_l7policies table for L7 policies"},{"line_number":16,"context_line":"    * lbaas_l7rules table for L7 policy rules"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"9aed3d3a_310c8a3a","line":16,"range":{"start_line":11,"start_character":0,"end_line":16,"end_character":45},"updated":"2016-02-29 19:39:11.000000000","message":"Seems unrelated to neutronclient.","commit_id":"2ea83b3ae2536d4c8f4f6bb445558ed934990f93"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"1a691dc4d94b31edc326123da39fb0a4044d7c2b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      having the ability to set policies order."},{"line_number":9,"context_line":"    * Multiple rules could be created for L7 policy."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"upgrade:"},{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    New database tables added."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    * lbaas_l7policies table for L7 policies"},{"line_number":16,"context_line":"    * lbaas_l7rules table for L7 policy rules"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"9aed3d3a_12018405","line":16,"range":{"start_line":11,"start_character":0,"end_line":16,"end_character":45},"in_reply_to":"9aed3d3a_310c8a3a","updated":"2016-02-29 20:42:27.000000000","message":"Ok, will remove it!","commit_id":"2ea83b3ae2536d4c8f4f6bb445558ed934990f93"}]}
