)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"a6bfa18204e5ce4e021ec9f9870681e8c165cf2c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ragalahari \u003craga.lahari@tcs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-08 11:55:25 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update neutron security-group-list help text with --tenant-id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"neutron security-group-list command has support for --tenant-id but"},{"line_number":10,"context_line":"it is not mentioned in the neutron security-group-list --help."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_f984575e","line":7,"updated":"2015-09-08 09:10:38.000000000","message":"This change clearly does more than just adding some help text.  So this seems to me to be an inaccurate summary of the change.","commit_id":"25237ca0e6a2ed11a9260d2b8cee15d3e49ddcfb"},{"author":{"_account_id":14520,"name":"Raga lahari","email":"raga.lahari@tcs.com","username":"Ragalahari"},"change_message_id":"8f31228b7a26d40ed5b377e648483b32eb0f0fa8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ragalahari \u003craga.lahari@tcs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-08 11:55:25 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update neutron security-group-list help text with --tenant-id"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"neutron security-group-list command has support for --tenant-id but"},{"line_number":10,"context_line":"it is not mentioned in the neutron security-group-list --help."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_134d6499","line":7,"in_reply_to":"da20952f_f984575e","updated":"2015-09-08 12:48:06.000000000","message":"Support for --tenant-id in neutron security-group-list command.","commit_id":"25237ca0e6a2ed11a9260d2b8cee15d3e49ddcfb"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"a6bfa18204e5ce4e021ec9f9870681e8c165cf2c","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Updating the help text with --tenant-id is affecting the"},{"line_number":13,"context_line":"functionality of neutron security-group-list, since as of now the"},{"line_number":14,"context_line":"--tenant-id is being handled as an extra argument."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"So when --tenant-id is added to the help text its being parsed"},{"line_number":17,"context_line":"as a known argument, which does not have support to handle the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_198eeb79","line":14,"updated":"2015-09-08 09:10:38.000000000","message":"I\u0027m afraid I don\u0027t understand this part.","commit_id":"25237ca0e6a2ed11a9260d2b8cee15d3e49ddcfb"},{"author":{"_account_id":14520,"name":"Raga lahari","email":"raga.lahari@tcs.com","username":"Ragalahari"},"change_message_id":"8f31228b7a26d40ed5b377e648483b32eb0f0fa8","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Updating the help text with --tenant-id is affecting the"},{"line_number":13,"context_line":"functionality of neutron security-group-list, since as of now the"},{"line_number":14,"context_line":"--tenant-id is being handled as an extra argument."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"So when --tenant-id is added to the help text its being parsed"},{"line_number":17,"context_line":"as a known argument, which does not have support to handle the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_65e2d131","line":14,"in_reply_to":"da20952f_198eeb79","updated":"2015-09-08 12:48:06.000000000","message":"The command \"neutron security-group-list -h\" is not listing\n--tenant-id as a supported argument.\n\nBut if we issue the command \"neutron security-group-list \n--tenant-id \u003cTENANT_ID\u003e, it will list the security groups \nrelated to the mentioned \u003cTENANT_ID\u003e instead of throwing any error.\n\nBecause the arguments passed to neutron security-group-list \ncan be either parsed arguments (The arguments which are shown in \nhelp text) or extra values (The arguments which are not present \nin the known arguments). Here the --tenant-id is being passed\nas an extra value and then listing the security group for the\ngiven tenant id.","commit_id":"25237ca0e6a2ed11a9260d2b8cee15d3e49ddcfb"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"a6bfa18204e5ce4e021ec9f9870681e8c165cf2c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"functionality of neutron security-group-list, since as of now the"},{"line_number":14,"context_line":"--tenant-id is being handled as an extra argument."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"So when --tenant-id is added to the help text its being parsed"},{"line_number":17,"context_line":"as a known argument, which does not have support to handle the"},{"line_number":18,"context_line":"command since the search_opts does not update when the tenant id"},{"line_number":19,"context_line":"is passed as a known argument."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_f9ebf710","line":16,"updated":"2015-09-08 09:10:38.000000000","message":"s/its/it\u0027s/","commit_id":"25237ca0e6a2ed11a9260d2b8cee15d3e49ddcfb"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"a6bfa18204e5ce4e021ec9f9870681e8c165cf2c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"--tenant-id is being handled as an extra argument."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"So when --tenant-id is added to the help text its being parsed"},{"line_number":17,"context_line":"as a known argument, which does not have support to handle the"},{"line_number":18,"context_line":"command since the search_opts does not update when the tenant id"},{"line_number":19,"context_line":"is passed as a known argument."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_d934f3ad","line":17,"updated":"2015-09-08 09:10:38.000000000","message":"_What_ does not have support to handle the command?","commit_id":"25237ca0e6a2ed11a9260d2b8cee15d3e49ddcfb"},{"author":{"_account_id":14520,"name":"Raga lahari","email":"raga.lahari@tcs.com","username":"Ragalahari"},"change_message_id":"8f31228b7a26d40ed5b377e648483b32eb0f0fa8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"--tenant-id is being handled as an extra argument."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"So when --tenant-id is added to the help text its being parsed"},{"line_number":17,"context_line":"as a known argument, which does not have support to handle the"},{"line_number":18,"context_line":"command since the search_opts does not update when the tenant id"},{"line_number":19,"context_line":"is passed as a known argument."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_85d925f7","line":17,"in_reply_to":"da20952f_d934f3ad","updated":"2015-09-08 12:48:06.000000000","message":"Once the neutron security-group-list help text is updated with \nthe --tenant-id, it is then being passed as a parsed argument. \n\nThe following file is modified to search the --tenant-id in\nparsed arguments instead of extra values and  to update\nthe search_opts with this tenant-id to list the security group.\n\nneutronclient/neutron/v2_0/__init__.py","commit_id":"25237ca0e6a2ed11a9260d2b8cee15d3e49ddcfb"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"a6bfa18204e5ce4e021ec9f9870681e8c165cf2c","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The following files have been modified to update the help text"},{"line_number":22,"context_line":"with --tenant-id and to update the search opts when the"},{"line_number":23,"context_line":"--teannt-id is passed as a known argument."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"neutronclient/neutron/v2_0/__init__.py"},{"line_number":26,"context_line":"neutronclient/neutron/v2_0/securitygroup.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da20952f_796da798","line":23,"updated":"2015-09-08 09:10:38.000000000","message":"s/teannt/tenant/","commit_id":"25237ca0e6a2ed11a9260d2b8cee15d3e49ddcfb"},{"author":{"_account_id":17096,"name":"Aditi Rajagopal","email":"arajagopal@us.ibm.com","username":"aditirajagopal"},"change_message_id":"97cac12cb6dce3599f1f037d38ce2731b8e911b8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"The following files have been modified to update the help text"},{"line_number":22,"context_line":"with --tenant-id and to update the search opts when the"},{"line_number":23,"context_line":"--tenant-id is passed as a known argument."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"neutronclient/neutron/v2_0/__init__.py"},{"line_number":26,"context_line":"neutronclient/neutron/v2_0/securitygroup.py"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da20952f_66296989","line":24,"updated":"2015-09-08 18:19:26.000000000","message":"This commit message needs to be reworded. Based on the current message, and the feedback from the comments, here is a suggested rewording:\n\nSupport --tenant-id in neutron security-group-list command\n\nThe \"neutron security-groups-list\" command currently supports \"--tenant-id\" as an extra value, and is not listed when the \"neutron security-group-list --help\" command is issued. When the \"neutron security-group-list --tenant-id \u003cTENANT_ID\u003e\" command is issued, it lists the security groups related to the specified TENANT_ID rather than throwing an error. \n\nThis change adds \"--tenant-id\" to \"neutron security-group-list --help\" which causes \"--tenant-id\" to be parsed as an argument. This change also makes the applicable correction to search_opts to handle \"--tenant-id\" as an argument rather than an extra value.","commit_id":"d59c988c28bca5c2259d4d60911dcf58f0bc9275"},{"author":{"_account_id":14520,"name":"Raga lahari","email":"raga.lahari@tcs.com","username":"Ragalahari"},"change_message_id":"e534f7a739ef0d2d54b20ca63b5848cc8f41a983","unresolved":false,"context_lines":[{"line_number":21,"context_line":"The following files have been modified to update the help text"},{"line_number":22,"context_line":"with --tenant-id and to update the search opts when the"},{"line_number":23,"context_line":"--tenant-id is passed as a known argument."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"neutronclient/neutron/v2_0/__init__.py"},{"line_number":26,"context_line":"neutronclient/neutron/v2_0/securitygroup.py"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da20952f_6848428b","line":24,"in_reply_to":"da20952f_66296989","updated":"2015-09-09 07:17:32.000000000","message":"Updated the commit message considering the previous comments and the suggestions.","commit_id":"d59c988c28bca5c2259d4d60911dcf58f0bc9275"},{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"a133f65699185c3d4eabd18f60b8f03cfde72140","unresolved":false,"context_lines":[{"line_number":14,"context_line":"currently supports --tenant-id as an extra value."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The changes included in the following files add --tenant-id to"},{"line_number":17,"context_line":"\"neutron security-group-list --help\" and update the search_opts "},{"line_number":18,"context_line":"to handle --tenant-id as a parsed argument rather than extra value."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"neutronclient/neutron/v2_0/__init__.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_63862518","line":17,"updated":"2015-09-09 07:34:05.000000000","message":"remove spaces","commit_id":"3973ff47fdbfda4133554480047e7e4145fc04cd"},{"author":{"_account_id":14520,"name":"Raga lahari","email":"raga.lahari@tcs.com","username":"Ragalahari"},"change_message_id":"cd9fb1135ba68b9a94b1d746a8f28688e014bce9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"currently supports --tenant-id as an extra value."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The changes included in the following files add --tenant-id to"},{"line_number":17,"context_line":"\"neutron security-group-list --help\" and update the search_opts "},{"line_number":18,"context_line":"to handle --tenant-id as a parsed argument rather than extra value."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"neutronclient/neutron/v2_0/__init__.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_23cfcd2a","line":17,"in_reply_to":"da20952f_63862518","updated":"2015-09-09 07:45:08.000000000","message":"Removed the spaces.","commit_id":"3973ff47fdbfda4133554480047e7e4145fc04cd"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bc4620c529473428272ba4bcfc5e0d36fb6b9e26","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Raga lahari \u003craga.lahari@tcs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-09 07:43:21 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support for --tenant-id in neutron security-group-list command."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In \"neutron security-group-list --help\", --tenant-id is not listed"},{"line_number":10,"context_line":"as a supported argument. But when the command"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa80f949_a3a0acf5","line":7,"updated":"2015-11-04 02:27:40.000000000","message":"Please remove the full stop from the GIT commit heading","commit_id":"1775cbb29415c0cdccd28c4ae00ab0593ad051a5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bc4620c529473428272ba4bcfc5e0d36fb6b9e26","unresolved":false,"context_lines":[{"line_number":10,"context_line":"as a supported argument. But when the command"},{"line_number":11,"context_line":"\"neutron security-group-list --tenant-id \u003cTENANT_ID\u003e is issued, it"},{"line_number":12,"context_line":"will list the security groups related to the given \u003cTENANT_ID\u003e"},{"line_number":13,"context_line":"instead of throwing any error. As neutron security-group-list"},{"line_number":14,"context_line":"currently supports --tenant-id as an extra value."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The changes included in the following files add --tenant-id to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa80f949_43ca20a3","line":13,"updated":"2015-11-04 02:27:40.000000000","message":"Please reword : \nAs neutron security-group-list currently supports --tenant-id as an extra value. \u003d\u003d\u003d\u003e From the above example, it is concluded that the ´neutron security-group-list´ supports --tenant-id as an extra parameter.","commit_id":"1775cbb29415c0cdccd28c4ae00ab0593ad051a5"}],"neutronclient/neutron/v2_0/__init__.py":[{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"6c91481979654d3155b8e70b3fb5152f90911536","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        search_opts.update(_extra_values)"},{"line_number":671,"context_line":"        if self.tenantId_support:"},{"line_number":672,"context_line":"            if parsed_args.tenant_id:"},{"line_number":673,"context_line":"               search_opts.update({\u0027tenant_id\u0027: parsed_args.tenant_id}) "},{"line_number":674,"context_line":"        if self.pagination_support:"},{"line_number":675,"context_line":"            page_size \u003d parsed_args.page_size"},{"line_number":676,"context_line":"            if page_size:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_4447a1a2","line":673,"updated":"2015-09-08 04:32:47.000000000","message":"+1","commit_id":"408bb94490df10cb1bca7cbfbcb59a1a04786afa"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"8b11d7973c7e05be1775f463d8c71936f30c2525","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        search_opts.update(_extra_values)"},{"line_number":671,"context_line":"        if self.tenantId_support:"},{"line_number":672,"context_line":"            if parsed_args.tenant_id:"},{"line_number":673,"context_line":"               search_opts.update({\u0027tenant_id\u0027: parsed_args.tenant_id}) "},{"line_number":674,"context_line":"        if self.pagination_support:"},{"line_number":675,"context_line":"            page_size \u003d parsed_args.page_size"},{"line_number":676,"context_line":"            if page_size:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_4797b6eb","line":673,"updated":"2015-09-07 13:25:44.000000000","message":"remove space","commit_id":"408bb94490df10cb1bca7cbfbcb59a1a04786afa"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"a6bfa18204e5ce4e021ec9f9870681e8c165cf2c","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        parser \u003d super(ListCommand, self).get_parser(prog_name)"},{"line_number":634,"context_line":"        add_show_list_common_argument(parser)"},{"line_number":635,"context_line":"        if self.tenantId_support:"},{"line_number":636,"context_line":"            add_tenant_argument(parser)"},{"line_number":637,"context_line":"        if self.pagination_support:"},{"line_number":638,"context_line":"            add_pagination_argument(parser)"},{"line_number":639,"context_line":"        if self.sorting_support:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_b9b6dff7","line":636,"updated":"2015-09-08 09:10:38.000000000","message":"The implication of the implementation here seems to be that there are no existing neutron commands that support --tenant-id.  Is that really true?","commit_id":"25237ca0e6a2ed11a9260d2b8cee15d3e49ddcfb"},{"author":{"_account_id":14520,"name":"Raga lahari","email":"raga.lahari@tcs.com","username":"Ragalahari"},"change_message_id":"9dd617a6c498790366eb3f0c99f52d5cd77f69d6","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        parser \u003d super(ListCommand, self).get_parser(prog_name)"},{"line_number":634,"context_line":"        add_show_list_common_argument(parser)"},{"line_number":635,"context_line":"        if self.tenantId_support:"},{"line_number":636,"context_line":"            add_tenant_argument(parser)"},{"line_number":637,"context_line":"        if self.pagination_support:"},{"line_number":638,"context_line":"            add_pagination_argument(parser)"},{"line_number":639,"context_line":"        if self.sorting_support:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_d8438412","line":636,"in_reply_to":"da20952f_b9b6dff7","updated":"2015-09-08 12:57:25.000000000","message":"There are neutron commands that support --tenant-id. As mentioned in the commit message the --tenant-id is being passed as an extra value to support the commands, in this case the --tenant-id will not be listed in the help text.\n\nBut once the --tenant-id is added in the help text of neutron security-group-list it becomes parsed argument for this command and hence requires this further implementation.","commit_id":"25237ca0e6a2ed11a9260d2b8cee15d3e49ddcfb"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"a87b6656e63f329720e8fe8b8edd294c176bfd2a","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        parser \u003d super(ListCommand, self).get_parser(prog_name)"},{"line_number":634,"context_line":"        add_show_list_common_argument(parser)"},{"line_number":635,"context_line":"        if self.tenantId_support:"},{"line_number":636,"context_line":"            add_tenant_argument(parser)"},{"line_number":637,"context_line":"        if self.pagination_support:"},{"line_number":638,"context_line":"            add_pagination_argument(parser)"},{"line_number":639,"context_line":"        if self.sorting_support:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_e1a3fefe","line":636,"in_reply_to":"da20952f_d8438412","updated":"2015-09-09 14:09:16.000000000","message":"Hi Raga - Thanks for your replies to my various comments.  I think I am understanding this change better now.\n\nHowever, if there are other neutron commands that support --tenant-id, would it not make sense for you to make this change - i.e. make --tenant-id a parsed argument, instead of an extra value - for all of them?","commit_id":"25237ca0e6a2ed11a9260d2b8cee15d3e49ddcfb"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"1b6f3c65b233b672f1ea98248fdcd02d287bb5bf","unresolved":false,"context_lines":[{"line_number":627,"context_line":"    unknown_parts_flag \u003d True"},{"line_number":628,"context_line":"    pagination_support \u003d False"},{"line_number":629,"context_line":"    sorting_support \u003d False"},{"line_number":630,"context_line":"    tenantId_support \u003d False"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    def get_parser(self, prog_name):"},{"line_number":633,"context_line":"        parser \u003d super(ListCommand, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_f1a51147","line":630,"updated":"2015-09-09 14:01:32.000000000","message":"I am still not convinced why we need to add it at a common place. IMHO, for this specific requirement we can add_argument specifically over here.","commit_id":"1775cbb29415c0cdccd28c4ae00ab0593ad051a5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bc4620c529473428272ba4bcfc5e0d36fb6b9e26","unresolved":false,"context_lines":[{"line_number":627,"context_line":"    unknown_parts_flag \u003d True"},{"line_number":628,"context_line":"    pagination_support \u003d False"},{"line_number":629,"context_line":"    sorting_support \u003d False"},{"line_number":630,"context_line":"    tenantId_support \u003d False"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    def get_parser(self, prog_name):"},{"line_number":633,"context_line":"        parser \u003d super(ListCommand, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_e35234dd","line":630,"in_reply_to":"9a1a9d01_47261f16","updated":"2015-11-04 02:27:40.000000000","message":"I am also in favor of the common code.\nIn case any new code is added, then the common function code can directly be used.\n\nNote: please do not use camelCasing as mentioned by Ihar below\nSo the variable can be renamed as tenantid_support","commit_id":"1775cbb29415c0cdccd28c4ae00ab0593ad051a5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ac64469c5db2b8fd3a9a4e9cad55167362c36875","unresolved":false,"context_lines":[{"line_number":627,"context_line":"    unknown_parts_flag \u003d True"},{"line_number":628,"context_line":"    pagination_support \u003d False"},{"line_number":629,"context_line":"    sorting_support \u003d False"},{"line_number":630,"context_line":"    tenantId_support \u003d False"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    def get_parser(self, prog_name):"},{"line_number":633,"context_line":"        parser \u003d super(ListCommand, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_47261f16","line":630,"in_reply_to":"da20952f_7c88a822","updated":"2015-09-29 13:41:15.000000000","message":"My understanding is that --tenant-id is available for most resources. If so, then common code approach seems better. I leave others to decide though.","commit_id":"1775cbb29415c0cdccd28c4ae00ab0593ad051a5"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"081c99e76bf0ace2d0bdff24d19ef4d377119133","unresolved":false,"context_lines":[{"line_number":627,"context_line":"    unknown_parts_flag \u003d True"},{"line_number":628,"context_line":"    pagination_support \u003d False"},{"line_number":629,"context_line":"    sorting_support \u003d False"},{"line_number":630,"context_line":"    tenantId_support \u003d False"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    def get_parser(self, prog_name):"},{"line_number":633,"context_line":"        parser \u003d super(ListCommand, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_7c88a822","line":630,"in_reply_to":"da20952f_bc3080ea","updated":"2015-09-11 07:24:05.000000000","message":"Hi Raga,\n\nCommon code gives flexibility at some cost :) I don\u0027t find this is a use-case which is applicable to most for the existing CLI\u0027s. Hence, don\u0027t want to clutter the common code. This is my opinion. Rest community can decide.\n\nThanks\nVikram","commit_id":"1775cbb29415c0cdccd28c4ae00ab0593ad051a5"},{"author":{"_account_id":14520,"name":"Raga lahari","email":"raga.lahari@tcs.com","username":"Ragalahari"},"change_message_id":"d09ba635a4513beb9b156d0c63fcdce45e4857a0","unresolved":false,"context_lines":[{"line_number":627,"context_line":"    unknown_parts_flag \u003d True"},{"line_number":628,"context_line":"    pagination_support \u003d False"},{"line_number":629,"context_line":"    sorting_support \u003d False"},{"line_number":630,"context_line":"    tenantId_support \u003d False"},{"line_number":631,"context_line":""},{"line_number":632,"context_line":"    def get_parser(self, prog_name):"},{"line_number":633,"context_line":"        parser \u003d super(ListCommand, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_bc3080ea","line":630,"in_reply_to":"da20952f_f1a51147","updated":"2015-09-11 07:08:26.000000000","message":"Hello Vikram,\n\nThank you so much for your inputs.\n\nThe reason for keeping the tenant_ID in common place is that other\nneutron commands that have support of tenantID as an extra value\ncan make use of this variable in the furture if needed just like\nsorting_suport variable.\n\nAs you have suggested we have gone through the dhcp_agent argument\nand implemented the add_argument and overriding the call_server in\nListSecurtiyGroup().The result is same as our proposed change and \nno need to make any changes in the common place with this\nimplementation.\n\nBut in future if other neutron commands need to implement the same\nchange then every class need to override the call_server in the\nrespective class.\n\nPlease share your comments.","commit_id":"1775cbb29415c0cdccd28c4ae00ab0593ad051a5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ac64469c5db2b8fd3a9a4e9cad55167362c36875","unresolved":false,"context_lines":[{"line_number":632,"context_line":"    def get_parser(self, prog_name):"},{"line_number":633,"context_line":"        parser \u003d super(ListCommand, self).get_parser(prog_name)"},{"line_number":634,"context_line":"        add_show_list_common_argument(parser)"},{"line_number":635,"context_line":"        if self.tenantId_support:"},{"line_number":636,"context_line":"            add_tenant_argument(parser)"},{"line_number":637,"context_line":"        if self.pagination_support:"},{"line_number":638,"context_line":"            add_pagination_argument(parser)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a1a9d01_2770cb0a","line":635,"updated":"2015-09-29 13:41:15.000000000","message":"the name of the variable does not seem to follow guidelines (we don\u0027t use upper case letters in variable names).","commit_id":"1775cbb29415c0cdccd28c4ae00ab0593ad051a5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bc4620c529473428272ba4bcfc5e0d36fb6b9e26","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                    self.values_specs)"},{"line_number":670,"context_line":"        search_opts \u003d self.args2search_opts(parsed_args)"},{"line_number":671,"context_line":"        search_opts.update(_extra_values)"},{"line_number":672,"context_line":"        if self.tenantId_support:"},{"line_number":673,"context_line":"            if parsed_args.tenant_id:"},{"line_number":674,"context_line":"                search_opts.update({\u0027tenant_id\u0027: parsed_args.tenant_id})"},{"line_number":675,"context_line":"        if self.pagination_support:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_4358e0fa","line":672,"updated":"2015-11-04 02:27:40.000000000","message":"Same as Ihar´s comment above , please do not use camelCasing","commit_id":"1775cbb29415c0cdccd28c4ae00ab0593ad051a5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bc4620c529473428272ba4bcfc5e0d36fb6b9e26","unresolved":false,"context_lines":[{"line_number":670,"context_line":"        search_opts \u003d self.args2search_opts(parsed_args)"},{"line_number":671,"context_line":"        search_opts.update(_extra_values)"},{"line_number":672,"context_line":"        if self.tenantId_support:"},{"line_number":673,"context_line":"            if parsed_args.tenant_id:"},{"line_number":674,"context_line":"                search_opts.update({\u0027tenant_id\u0027: parsed_args.tenant_id})"},{"line_number":675,"context_line":"        if self.pagination_support:"},{"line_number":676,"context_line":"            page_size \u003d parsed_args.page_size"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_631404f5","line":673,"updated":"2015-11-04 02:27:40.000000000","message":"Also, do you need nested if loops?\nmaybe you can just do a simple :\n¨if self.tenantId_support and parsed_args.tenant_id:¨","commit_id":"1775cbb29415c0cdccd28c4ae00ab0593ad051a5"}],"neutronclient/neutron/v2_0/securitygroup.py":[{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"6c91481979654d3155b8e70b3fb5152f90911536","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    pagination_support \u003d True"},{"line_number":101,"context_line":"    sorting_support \u003d True"},{"line_number":102,"context_line":"    tenantId_support \u003d True"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"class ShowSecurityGroup(neutronV20.ShowCommand):"},{"line_number":106,"context_line":"    \"\"\"Show information of a given security group.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_84d859f0","line":103,"updated":"2015-09-08 04:32:47.000000000","message":"Why required as tenantId_support \u003d Trure?","commit_id":"408bb94490df10cb1bca7cbfbcb59a1a04786afa"},{"author":{"_account_id":14520,"name":"Raga lahari","email":"raga.lahari@tcs.com","username":"Ragalahari"},"change_message_id":"62724b92857a7404fd1efed131d647a0dc0b16d2","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    pagination_support \u003d True"},{"line_number":101,"context_line":"    sorting_support \u003d True"},{"line_number":102,"context_line":"    tenantId_support \u003d True"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"class ShowSecurityGroup(neutronV20.ShowCommand):"},{"line_number":106,"context_line":"    \"\"\"Show information of a given security group.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_3deac0d8","line":103,"in_reply_to":"da20952f_84d859f0","updated":"2015-09-08 06:43:52.000000000","message":"As tenant ID support is not applicable for all the neutron commands, this variable is checked along with the neutron security-group-list. When ever the neutron security-group-list command has been issued this variable will be true by default. But the search_opts will be updated only when the --tenant-id is present in the parsed command along with neutron security-group-list.\n\nAnd by checking this variable only the help text displays the --tenant-id option for the security-group-list of neutron.","commit_id":"408bb94490df10cb1bca7cbfbcb59a1a04786afa"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bc4620c529473428272ba4bcfc5e0d36fb6b9e26","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    _formatters \u003d {\u0027security_group_rules\u0027: _format_sg_rules}"},{"line_number":100,"context_line":"    pagination_support \u003d True"},{"line_number":101,"context_line":"    sorting_support \u003d True"},{"line_number":102,"context_line":"    tenantId_support \u003d True"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"class ShowSecurityGroup(neutronV20.ShowCommand):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_83d32838","line":102,"updated":"2015-11-04 02:27:40.000000000","message":"Maybe add a test case for tenantid_support \u003d False as well for complete coverage?\n\nAnd maybe avoid camelCasing as well?","commit_id":"1775cbb29415c0cdccd28c4ae00ab0593ad051a5"}]}