)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"0f57e6c9db0efef3218fabaf4a350bdf2e6579b8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Modification to improve error message in neutron-client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron CLIs return \"404 Not Found\" error message when they"},{"line_number":10,"context_line":"cannot work on a service( like VPNaaS, FWaaS etc) or when they"},{"line_number":11,"context_line":"are not able to determine the information."},{"line_number":12,"context_line":"However \"404 Not found\" error message if not correct and not"},{"line_number":13,"context_line":"descriptive enough for the end user to work upon. This fix tries"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba15a1d1_33bc71ba","line":10,"updated":"2015-09-24 06:12:12.000000000","message":"services or extensions","commit_id":"80620b43c35d19e731f373b20df491149f2165e1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"50e260792c3bcb9b7a92169e66f4760930ceb03e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Modification to improve error message in neutron-client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Neutron CLIs return \"404 Not Found\" error message when they"},{"line_number":10,"context_line":"cannot work on a service( like VPNaaS, FWaaS etc) or when they"},{"line_number":11,"context_line":"are not able to determine the information."},{"line_number":12,"context_line":"However \"404 Not found\" error message if not correct and not"},{"line_number":13,"context_line":"descriptive enough for the end user to work upon. This fix tries"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba15a1d1_561793ed","line":10,"in_reply_to":"ba15a1d1_33bc71ba","updated":"2015-09-24 06:41:48.000000000","message":"extensions, will correct it","commit_id":"80620b43c35d19e731f373b20df491149f2165e1"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"0f57e6c9db0efef3218fabaf4a350bdf2e6579b8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Neutron CLIs return \"404 Not Found\" error message when they"},{"line_number":10,"context_line":"cannot work on a service( like VPNaaS, FWaaS etc) or when they"},{"line_number":11,"context_line":"are not able to determine the information."},{"line_number":12,"context_line":"However \"404 Not found\" error message if not correct and not"},{"line_number":13,"context_line":"descriptive enough for the end user to work upon. This fix tries"},{"line_number":14,"context_line":"to improve on the same message."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba15a1d1_f3b119e1","line":12,"updated":"2015-09-24 06:12:12.000000000","message":"nit: \u0027if\u0027 \u003d\u003d\u003e \u0027is\u0027","commit_id":"80620b43c35d19e731f373b20df491149f2165e1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"50e260792c3bcb9b7a92169e66f4760930ceb03e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Neutron CLIs return \"404 Not Found\" error message when they"},{"line_number":10,"context_line":"cannot work on a service( like VPNaaS, FWaaS etc) or when they"},{"line_number":11,"context_line":"are not able to determine the information."},{"line_number":12,"context_line":"However \"404 Not found\" error message if not correct and not"},{"line_number":13,"context_line":"descriptive enough for the end user to work upon. This fix tries"},{"line_number":14,"context_line":"to improve on the same message."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba15a1d1_761417e8","line":12,"in_reply_to":"ba15a1d1_f3b119e1","updated":"2015-09-24 06:41:48.000000000","message":"Done","commit_id":"80620b43c35d19e731f373b20df491149f2165e1"}],"neutronclient/shell.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fcd405ba970bb61a7860a0fbd25d3c2d7a938def","unresolved":false,"context_lines":[{"line_number":819,"context_line":"            else:"},{"line_number":820,"context_line":"                raise_error \u003d False"},{"line_number":821,"context_line":"                for items in e._error_string.split(\u0027\\n\u0027):"},{"line_number":822,"context_line":"                    if \"The resource could not be found\" in items:"},{"line_number":823,"context_line":"                        raise_error \u003d True"},{"line_number":824,"context_line":"                if raise_error:"},{"line_number":825,"context_line":"                    self.log.error("}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_a881794c","line":822,"updated":"2015-09-25 14:50:05.000000000","message":"How would you distingish between actual \u0027resource not found\u0027 and \u0027404 due to service not enabled\u0027? The proper way to do it is to request the list of extensions enabled on the server, and decide about it based on the list.\n\nThat means another round trip with the server. (Also, we would need to handle potential policy errors due to extensions API forbidden, etc.)","commit_id":"80620b43c35d19e731f373b20df491149f2165e1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8f45478f55fd5f47cc1738f95e45eab12ed66be0","unresolved":false,"context_lines":[{"line_number":819,"context_line":"            else:"},{"line_number":820,"context_line":"                raise_error \u003d False"},{"line_number":821,"context_line":"                for items in e._error_string.split(\u0027\\n\u0027):"},{"line_number":822,"context_line":"                    if \"The resource could not be found\" in items:"},{"line_number":823,"context_line":"                        raise_error \u003d True"},{"line_number":824,"context_line":"                if raise_error:"},{"line_number":825,"context_line":"                    self.log.error("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_e8ee8d21","line":822,"in_reply_to":"7a2fa921_1a2b2432","updated":"2015-10-06 13:16:47.000000000","message":"See http://developer.openstack.org/api-ref-networking-v2-ext.html\n\nSpecifically, /v2.0/extensions","commit_id":"80620b43c35d19e731f373b20df491149f2165e1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"121cd31b1be489161ed04f7942e27ff2e15197f9","unresolved":false,"context_lines":[{"line_number":819,"context_line":"            else:"},{"line_number":820,"context_line":"                raise_error \u003d False"},{"line_number":821,"context_line":"                for items in e._error_string.split(\u0027\\n\u0027):"},{"line_number":822,"context_line":"                    if \"The resource could not be found\" in items:"},{"line_number":823,"context_line":"                        raise_error \u003d True"},{"line_number":824,"context_line":"                if raise_error:"},{"line_number":825,"context_line":"                    self.log.error("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_1313d5b9","line":822,"in_reply_to":"7a2fa921_e8ee8d21","updated":"2015-10-07 08:44:58.000000000","message":"I checked it , but the location where I need to call it ( run_subcommand) in shell.py is at a very high level, and there is some abstraction protecting the access of direct server calls from shell.py.\nI am trying to find out if there is any other way to call the server from shell.py","commit_id":"80620b43c35d19e731f373b20df491149f2165e1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"4653e75f4cb7f8ede431fad37bde74c1a4fba141","unresolved":false,"context_lines":[{"line_number":819,"context_line":"            else:"},{"line_number":820,"context_line":"                raise_error \u003d False"},{"line_number":821,"context_line":"                for items in e._error_string.split(\u0027\\n\u0027):"},{"line_number":822,"context_line":"                    if \"The resource could not be found\" in items:"},{"line_number":823,"context_line":"                        raise_error \u003d True"},{"line_number":824,"context_line":"                if raise_error:"},{"line_number":825,"context_line":"                    self.log.error("}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_1a2b2432","line":822,"in_reply_to":"9a1a9d01_a881794c","updated":"2015-10-06 04:28:25.000000000","message":"@Ihar:\nAny suggestions where to look for this?\nI mean how to determine the currently existing extensions enabled on the server?\nYour last comment will also be taken care by the fix here.","commit_id":"80620b43c35d19e731f373b20df491149f2165e1"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"0f57e6c9db0efef3218fabaf4a350bdf2e6579b8","unresolved":false,"context_lines":[{"line_number":824,"context_line":"                if raise_error:"},{"line_number":825,"context_line":"                    self.log.error("},{"line_number":826,"context_line":"                        \"Cannot execute CLI %s. Please check\""},{"line_number":827,"context_line":"                        \" if the settings are correct.\", cmd_name)"},{"line_number":828,"context_line":"                else:"},{"line_number":829,"context_line":"                    self.log.error(\"%s\", e)"},{"line_number":830,"context_line":"        return 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_d37e551a","line":827,"updated":"2015-09-24 06:12:12.000000000","message":"what settings user need to check? \n\nI feel with the current 404 error user can at-least make out that the resource url might not be available with the server, but asking to check the \u0027settings\u0027 looks more blunt. How as a user I should proceed?","commit_id":"80620b43c35d19e731f373b20df491149f2165e1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fcd405ba970bb61a7860a0fbd25d3c2d7a938def","unresolved":false,"context_lines":[{"line_number":824,"context_line":"                if raise_error:"},{"line_number":825,"context_line":"                    self.log.error("},{"line_number":826,"context_line":"                        \"Cannot execute CLI %s. Please check\""},{"line_number":827,"context_line":"                        \" if the settings are correct.\", cmd_name)"},{"line_number":828,"context_line":"                else:"},{"line_number":829,"context_line":"                    self.log.error(\"%s\", e)"},{"line_number":830,"context_line":"        return 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_88ca75a0","line":827,"in_reply_to":"9a1a9d01_856d8006","updated":"2015-09-25 14:50:05.000000000","message":"Client users are not responsible for server settings. Deployers are. So we must not instruct users to fix server setup.\n\nThe proper way would be to inform the user that the extension is not enabled on the server, so the request cannot be proceeded.","commit_id":"80620b43c35d19e731f373b20df491149f2165e1"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"8d17414566d158e7648d1782ee9e1a9c3e324c5f","unresolved":false,"context_lines":[{"line_number":824,"context_line":"                if raise_error:"},{"line_number":825,"context_line":"                    self.log.error("},{"line_number":826,"context_line":"                        \"Cannot execute CLI %s. Please check\""},{"line_number":827,"context_line":"                        \" if the settings are correct.\", cmd_name)"},{"line_number":828,"context_line":"                else:"},{"line_number":829,"context_line":"                    self.log.error(\"%s\", e)"},{"line_number":830,"context_line":"        return 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_856d8006","line":827,"in_reply_to":"9a1a9d01_ab03ca0e","updated":"2015-09-25 14:42:32.000000000","message":"@Reedip: I am not sure how it can be improved. To me 404 is okay. User can check the server logs for more details. Let others also provide their point of view.","commit_id":"80620b43c35d19e731f373b20df491149f2165e1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"72df7df718c8e0748095f7d4644fd5d438c140c7","unresolved":false,"context_lines":[{"line_number":824,"context_line":"                if raise_error:"},{"line_number":825,"context_line":"                    self.log.error("},{"line_number":826,"context_line":"                        \"Cannot execute CLI %s. Please check\""},{"line_number":827,"context_line":"                        \" if the settings are correct.\", cmd_name)"},{"line_number":828,"context_line":"                else:"},{"line_number":829,"context_line":"                    self.log.error(\"%s\", e)"},{"line_number":830,"context_line":"        return 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_ab03ca0e","line":827,"in_reply_to":"ba15a1d1_0ae1e729","updated":"2015-09-25 01:24:59.000000000","message":"I do agree that 404 is an HTTP standard response but as the definition for 404 suggests that the client server communication is working properly but the server is unable to access the resource whose information the client wants.\nThe client server mechanism of Openstack can avoid the rudimentary error messages of http, and present a more improvised version for the error message, cant it?","commit_id":"80620b43c35d19e731f373b20df491149f2165e1"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"2ab2ff6e0192d0ad368544fa4aefac64899e9d65","unresolved":false,"context_lines":[{"line_number":824,"context_line":"                if raise_error:"},{"line_number":825,"context_line":"                    self.log.error("},{"line_number":826,"context_line":"                        \"Cannot execute CLI %s. Please check\""},{"line_number":827,"context_line":"                        \" if the settings are correct.\", cmd_name)"},{"line_number":828,"context_line":"                else:"},{"line_number":829,"context_line":"                    self.log.error(\"%s\", e)"},{"line_number":830,"context_line":"        return 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_0ae1e729","line":827,"in_reply_to":"ba15a1d1_9621ab4f","updated":"2015-09-24 11:55:32.000000000","message":"@Reedip:\nIMO, 404 error is itself a standard. https://en.wikipedia.org/wiki/HTTP_404","commit_id":"80620b43c35d19e731f373b20df491149f2165e1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"50e260792c3bcb9b7a92169e66f4760930ceb03e","unresolved":false,"context_lines":[{"line_number":824,"context_line":"                if raise_error:"},{"line_number":825,"context_line":"                    self.log.error("},{"line_number":826,"context_line":"                        \"Cannot execute CLI %s. Please check\""},{"line_number":827,"context_line":"                        \" if the settings are correct.\", cmd_name)"},{"line_number":828,"context_line":"                else:"},{"line_number":829,"context_line":"                    self.log.error(\"%s\", e)"},{"line_number":830,"context_line":"        return 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_9621ab4f","line":827,"in_reply_to":"ba15a1d1_d37e551a","updated":"2015-09-24 06:41:48.000000000","message":"@Vikram:\n\nI am not sure about the 404 error.\nA novice / new user wont know about resource url, as it is more of an engineering term.\n\nPlease advice as to what you think would be a more appropriate message?","commit_id":"80620b43c35d19e731f373b20df491149f2165e1"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"404a898bfb5903a9939c4e0c7af0642bdcdce81c","unresolved":false,"context_lines":[{"line_number":823,"context_line":"                self.log.exception(\"%s\", e)"},{"line_number":824,"context_line":"                raise"},{"line_number":825,"context_line":"            else:"},{"line_number":826,"context_line":"                raise_error \u003d False"},{"line_number":827,"context_line":"                for items in e._error_string.split(\u0027\\n\u0027):"},{"line_number":828,"context_line":"                    if \"The resource could not be found\" in items:"},{"line_number":829,"context_line":"                        raise_error \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_1588d5e6","line":826,"updated":"2015-10-06 05:37:40.000000000","message":"I think this is un-necessary.","commit_id":"9bf88fb528eb4cc75b014047d2b242cb732b8b93"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"404a898bfb5903a9939c4e0c7af0642bdcdce81c","unresolved":false,"context_lines":[{"line_number":830,"context_line":"                if raise_error:"},{"line_number":831,"context_line":"                    self.log.error("},{"line_number":832,"context_line":"                        \"Cannot execute CLI %s. Please check\""},{"line_number":833,"context_line":"                        \" if the settings are correct.\", cmd_name)"},{"line_number":834,"context_line":"                else:"},{"line_number":835,"context_line":"                    self.log.error(\"%s\", e)"},{"line_number":836,"context_line":"        return 1"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_754ee9c2","line":833,"updated":"2015-10-06 05:37:40.000000000","message":"Error msg is too generic. I feel we got to improvise.","commit_id":"9bf88fb528eb4cc75b014047d2b242cb732b8b93"}]}