)]}'
{"id":"openstack%2Fpython-neutronclient~231883","triplet_id":"openstack%2Fpython-neutronclient~master~I83ec45af75f61f8005a60efc8176db0df5cfbe9a","project":"openstack/python-neutronclient","branch":"master","topic":"bug/1259292","hashtags":[],"change_id":"I83ec45af75f61f8005a60efc8176db0df5cfbe9a","subject":"Fix arg order of assertEqual and use assertTrue","status":"MERGED","created":"2015-10-07 08:07:25.000000000","updated":"2015-10-08 21:35:20.000000000","submitted":"2015-10-08 21:35:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8460321d838f1ca513f07ed7ee92431dc7245926","_number":231883,"virtual_id_number":231883,"owner":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},{"value":0,"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":0,"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},{"value":0,"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":2,"date":"2015-10-08 21:35:19.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"recommended":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"all":[{"value":1,"date":"2015-10-07 20:42:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},{"value":2,"date":"2015-10-08 18:52:56.000000000","_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":1,"date":"2015-10-07 15:15:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},{"value":2,"date":"2015-10-08 20:19:16.000000000","_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},{"value":1,"date":"2015-10-07 14:59:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":1,"date":"2015-10-08 06:01:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"all":[{"value":0,"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},{"value":0,"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":0,"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},{"value":1,"date":"2015-10-08 20:19:16.000000000","_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},{"value":0,"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-07 14:59:54.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2015-10-07 15:15:29.000000000","updated_by":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"reviewer":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"state":"REVIEWER"},{"updated":"2015-10-07 20:42:24.000000000","updated_by":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"reviewer":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"state":"REVIEWER"},{"updated":"2015-10-08 06:01:34.000000000","updated_by":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"reviewer":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"state":"REVIEWER"},{"updated":"2015-10-08 18:52:56.000000000","updated_by":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"reviewer":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"state":"REVIEWER"},{"updated":"2015-10-08 20:19:16.000000000","updated_by":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"reviewer":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"state":"REVIEWER"},{"updated":"2015-10-08 21:35:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d24afb76ba5211fccbf465aa6b1ac28e4d07a6c6","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2015-10-07 08:07:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"39a5e05d6aa431c713246b0e6f4ab5778de889aa","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2015-10-07 08:07:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1014a2e2b52f2074c6591890d0bf2239b8c80473","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2015-10-07 08:10:38.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"8ea1bdfbe9da974a8ffee1437fe9a1da082185d4","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2015-10-07 08:16:47.000000000","message":"Topic set to bug/1259292","accounts_in_message":[],"_revision_number":3},{"id":"8b233839c7ade995d295584623f17f56e9fee3a9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-07 09:05:01.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-python26 http://logs.openstack.org/83/231883/3/check/gate-python-neutronclient-python26/1c36f14/ : SUCCESS in 1m 16s\n- gate-python-neutronclient-pep8 http://logs.openstack.org/83/231883/3/check/gate-python-neutronclient-pep8/73fbb2c/ : SUCCESS in 53s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/83/231883/3/check/gate-python-neutronclient-docs/9cea49d//doc/build/html/ : SUCCESS in 1m 13s\n- gate-python-neutronclient-python27 http://logs.openstack.org/83/231883/3/check/gate-python-neutronclient-python27/51dc030/ : SUCCESS in 1m 23s\n- gate-python-neutronclient-python34 http://logs.openstack.org/83/231883/3/check/gate-python-neutronclient-python34/f75f83e/ : SUCCESS in 3m 41s\n- gate-python-neutronclient-pypy http://logs.openstack.org/83/231883/3/check/gate-python-neutronclient-pypy/38d4590/ : SUCCESS in 2m 29s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/83/231883/3/check/gate-tempest-dsvm-neutron-src-python-neutronclient/d90284d/ : SUCCESS in 51m 21s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/83/231883/3/check/gate-neutronclient-test-dsvm-functional/6d0d5c3/ : SUCCESS in 28m 14s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/83/231883/3/check/gate-neutronclient-test-dsvm-functional-adv-svcs/a455cf4/ : SUCCESS in 19m 21s","accounts_in_message":[],"_revision_number":3},{"id":"01d2730f5b116e51414e0ca227af9dc7dcf877dd","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2015-10-07 14:59:54.000000000","message":"Patch Set 3: Code-Review+1\n\nLooks like you fixed all of the applicable assertEqual problems.  Thank you.","accounts_in_message":[],"_revision_number":3},{"id":"e9c7d403a69fb8fcd6a28b094193d56bbdd61c45","author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"date":"2015-10-07 15:15:29.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)\n\nLooks good! With a suggestion!","accounts_in_message":[],"_revision_number":3},{"id":"bb6db24ff45876b24381ca12019628ee1b0ceb00","author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"date":"2015-10-07 20:42:24.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"33df33a9321b05c0bc8b097caf61d38878deaf9c","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2015-10-08 06:01:34.000000000","message":"Patch Set 3: Code-Review+1\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"0ffed18dc8d161cdc9174da0db024196ead55a39","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2015-10-08 18:52:56.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"705b1bff65e70b3eb1358a9342b62a5f1dd9f35f","author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"date":"2015-10-08 20:19:16.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"75eb580be877b4abe6bba9ab27f1f5a0d786200b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 20:19:24.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"2d17c6baef51ed93e9390d3cc8bcacc7ca910ebb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 21:35:19.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-neutronclient-python26 http://logs.openstack.org/83/231883/3/gate/gate-python-neutronclient-python26/a84f6b1/ : SUCCESS in 1m 27s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/83/231883/3/gate/gate-python-neutronclient-docs/a584948//doc/build/html/ : SUCCESS in 58s\n- gate-python-neutronclient-pep8 http://logs.openstack.org/83/231883/3/gate/gate-python-neutronclient-pep8/c58528e/ : SUCCESS in 50s\n- gate-python-neutronclient-python27 http://logs.openstack.org/83/231883/3/gate/gate-python-neutronclient-python27/e62e9cb/ : SUCCESS in 1m 06s\n- gate-python-neutronclient-python34 http://logs.openstack.org/83/231883/3/gate/gate-python-neutronclient-python34/c7b2901/ : SUCCESS in 1m 49s\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/83/231883/3/gate/gate-tempest-dsvm-neutron-src-python-neutronclient/2f00ac5/ : SUCCESS in 1h 13m 19s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/83/231883/3/gate/gate-neutronclient-test-dsvm-functional/890e692/ : SUCCESS in 33m 18s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/83/231883/3/gate/gate-neutronclient-test-dsvm-functional-adv-svcs/38945d4/ : SUCCESS in 34m 38s","accounts_in_message":[],"_revision_number":3},{"id":"8460321d838f1ca513f07ed7ee92431dc7245926","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-08 21:35:20.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"18ce7d9f2e95a0479841b4b48c41765644fce7aa","revisions":{"8788d093e84233a62732a3c4ed1cbdb7f693e37b":{"kind":"REWORK","_number":1,"created":"2015-10-07 08:07:25.000000000","uploader":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"ref":"refs/changes/83/231883/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/83/231883/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/83/231883/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/83/231883/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/83/231883/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/83/231883/1"}}},"commit":{"parents":[{"commit":"cc1ce7a24f80552f68259b1f9321e62dd3aecdb2","subject":"Merge \"Ensure to decode bytes or fail\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/cc1ce7a24f80552f68259b1f9321e62dd3aecdb2"}]}],"author":{"name":"Reedip Banerjee","email":"reedip.banerjee@nectechnologies.in","date":"2015-10-07 08:05:44.000000000","tz":330},"committer":{"name":"Reedip Banerjee","email":"reedip.banerjee@nectechnologies.in","date":"2015-10-07 08:05:44.000000000","tz":330},"subject":"Fix argument order of assertEqual and use assertTrue","message":"Fix argument order of assertEqual and use assertTrue\n\nassertEqual expects that the arguments provided to it should be\n(expected, observed).If a particluar order is kept as a convention,\nthen it helps to provide a cleaner message to the developer if Unit Tests\nfail. There are several Unit Test files where the arguments for assertEqual\nhave been swapped. This commit fixes the issue in python-neutronclient.\n\nAdditionally instead of using assertEqual(True,xxx), assertTrue(xxx) should\nbe used. The same has been fixed in this patch.\n\nChange-Id: I83ec45af75f61f8005a60efc8176db0df5cfbe9a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8788d093e84233a62732a3c4ed1cbdb7f693e37b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8788d093e84233a62732a3c4ed1cbdb7f693e37b"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"cc1ce7a24f80552f68259b1f9321e62dd3aecdb2","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"b97f7f734fbeb0bceba415d426baec9c8982f79b":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2015-10-07 08:07:58.000000000","uploader":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"ref":"refs/changes/83/231883/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/83/231883/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/83/231883/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/83/231883/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/83/231883/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/83/231883/2"}}},"commit":{"parents":[{"commit":"cc1ce7a24f80552f68259b1f9321e62dd3aecdb2","subject":"Merge \"Ensure to decode bytes or fail\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/cc1ce7a24f80552f68259b1f9321e62dd3aecdb2"}]}],"author":{"name":"Reedip Banerjee","email":"reedip.banerjee@nectechnologies.in","date":"2015-10-07 08:05:44.000000000","tz":330},"committer":{"name":"Reedip Banerjee","email":"reedip.banerjee@nectechnologies.in","date":"2015-10-07 08:08:40.000000000","tz":330},"subject":"Fix argument order of assertEqual and use assertTrue","message":"Fix argument order of assertEqual and use assertTrue\n\nassertEqual expects that the arguments provided to it should be\n(expected, observed).If a particluar order is kept as a convention,\nthen it helps to provide a cleaner message to the developer if Unit Tests\nfail. There are several Unit Test files where the arguments for assertEqual\nhave been swapped. This commit fixes the issue in python-neutronclient.\n\nAdditionally instead of using assertEqual(True,xxx), assertTrue(xxx) should\nbe used. The same has been fixed in this patch.\n\nPartial-Bug: #1259292\nRelated-Bug: #1259292\n\nChange-Id: I83ec45af75f61f8005a60efc8176db0df5cfbe9a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/b97f7f734fbeb0bceba415d426baec9c8982f79b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/b97f7f734fbeb0bceba415d426baec9c8982f79b"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"cc1ce7a24f80552f68259b1f9321e62dd3aecdb2","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"18ce7d9f2e95a0479841b4b48c41765644fce7aa":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2015-10-07 08:10:38.000000000","uploader":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"ref":"refs/changes/83/231883/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/83/231883/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/83/231883/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/83/231883/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/83/231883/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/83/231883/3"}}},"commit":{"parents":[{"commit":"cc1ce7a24f80552f68259b1f9321e62dd3aecdb2","subject":"Merge \"Ensure to decode bytes or fail\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/cc1ce7a24f80552f68259b1f9321e62dd3aecdb2"}]}],"author":{"name":"Reedip Banerjee","email":"reedip.banerjee@nectechnologies.in","date":"2015-10-07 08:05:44.000000000","tz":330},"committer":{"name":"Reedip Banerjee","email":"reedip.banerjee@nectechnologies.in","date":"2015-10-07 08:10:57.000000000","tz":330},"subject":"Fix arg order of assertEqual and use assertTrue","message":"Fix arg order of assertEqual and use assertTrue\n\nassertEqual expects that the arguments provided to it should be\n(expected, observed).If a particluar order is kept as a convention,\nthen it helps to provide a cleaner message to the developer if Unit Tests\nfail. There are several Unit Test files where the arguments for assertEqual\nhave been swapped. This commit fixes the issue in python-neutronclient.\n\nAdditionally instead of using assertEqual(True,xxx), assertTrue(xxx) should\nbe used. The same has been fixed in this patch.\n\nPartial-Bug: #1259292\nRelated-Bug: #1259292\n\nChange-Id: I83ec45af75f61f8005a60efc8176db0df5cfbe9a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/18ce7d9f2e95a0479841b4b48c41765644fce7aa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/18ce7d9f2e95a0479841b4b48c41765644fce7aa"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"cc1ce7a24f80552f68259b1f9321e62dd3aecdb2","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}