)]}'
{"neutronclient/neutron/v2_0/fw/firewallrule.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"edcdbd709c9d0d80520657d6c3eae52aeb036ceb","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":130,"context_line":"        parser.add_argument("},{"line_number":131,"context_line":"            \u0027--name\u0027,"},{"line_number":132,"context_line":"            help\u003d_(\u0027Updated name for the firewall rule.\u0027))"},{"line_number":133,"context_line":"        parser.add_argument("},{"line_number":134,"context_line":"            \u0027--description\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_36a73ba8","line":131,"updated":"2015-10-11 06:26:48.000000000","message":"Most of the parameters are same as CreateFirewallRule. Can you please make a common function for bot create and update?","commit_id":"b87db2fccc240a7b557be981eb3c3a4d0821c4e7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3fe0f29869b1b7802afc44479f4f3d8979bdf3e6","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":130,"context_line":"        parser.add_argument("},{"line_number":131,"context_line":"            \u0027--name\u0027,"},{"line_number":132,"context_line":"            help\u003d_(\u0027Updated name for the firewall rule.\u0027))"},{"line_number":133,"context_line":"        parser.add_argument("},{"line_number":134,"context_line":"            \u0027--description\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_0c922ef6","line":131,"in_reply_to":"7a2fa921_36a73ba8","updated":"2015-10-11 13:51:30.000000000","message":"Yes We Can ;) ( w.r.t, Mr. Obama )","commit_id":"b87db2fccc240a7b557be981eb3c3a4d0821c4e7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a00dd0109494687d1205f9eb3ba312a10e66fd48","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    resource \u003d \u0027firewall_rule\u0027"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"class DeleteFirewallRule(neutronv20.DeleteCommand):"},{"line_number":67,"context_line":"    \"\"\"Delete a given firewall rule.\"\"\""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    resource \u003d \u0027firewall_rule\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_2b523fde","line":66,"updated":"2015-10-13 01:24:02.000000000","message":"Moved the DeleteFirewallRule up so that the add_known_args function can be consolidated with the functions calling it... just to make the affected code together","commit_id":"f5b7f7922d720f50aa309d90a0ca1b1b06785254"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a00dd0109494687d1205f9eb3ba312a10e66fd48","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        # UpdateCommand \u003d isCreate : False"},{"line_number":76,"context_line":"        parser.add_argument("},{"line_number":77,"context_line":"            \u0027--name\u0027,"},{"line_number":78,"context_line":"            help\u003d_(\u0027New Name for the firewall rule.\u0027))"},{"line_number":79,"context_line":"        parser.add_argument("},{"line_number":80,"context_line":"            \u0027--description\u0027,"},{"line_number":81,"context_line":"            help\u003d_(\u0027New Description for the firewall rule.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_6b6fd792","line":78,"updated":"2015-10-13 01:24:02.000000000","message":"New keyword is added as for Create, the name would be new as the firewall itself is a New firewall.\n\nAnd if the user wants to update the firewall, he would have to provide the  \u0027New\u0027 name.\n\nSame logic implemented for other sections as well.","commit_id":"f5b7f7922d720f50aa309d90a0ca1b1b06785254"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"6bb15982ede2b8d61529b7c65b6222d8ddf9a55a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        # UpdateCommand \u003d isCreate : False"},{"line_number":76,"context_line":"        parser.add_argument("},{"line_number":77,"context_line":"            \u0027--name\u0027,"},{"line_number":78,"context_line":"            help\u003d_(\u0027New Name for the firewall rule.\u0027))"},{"line_number":79,"context_line":"        parser.add_argument("},{"line_number":80,"context_line":"            \u0027--description\u0027,"},{"line_number":81,"context_line":"            help\u003d_(\u0027New Description for the firewall rule.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_e8bd2203","line":78,"in_reply_to":"7a2fa921_6b6fd792","updated":"2015-10-13 07:34:23.000000000","message":"Nice thought but to me \u0027new\u0027 sounds little odd during create. Anyways for Create operation is new.\n\nMoreover, this might be consistent with the help for others CLI\u0027s.\n\nIMHO, we can drop \u0027new\u0027","commit_id":"f5b7f7922d720f50aa309d90a0ca1b1b06785254"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"6bb15982ede2b8d61529b7c65b6222d8ddf9a55a","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def args2body(self, parsed_args):"},{"line_number":124,"context_line":"        body \u003d {}"},{"line_number":125,"context_line":"        neutronv20.update_dict(parsed_args, body,"},{"line_number":126,"context_line":"                               [\u0027name\u0027, \u0027description\u0027, \u0027shared\u0027, \u0027protocol\u0027,"},{"line_number":127,"context_line":"                                \u0027source_ip_address\u0027, \u0027destination_ip_address\u0027,"},{"line_number":128,"context_line":"                                \u0027source_port\u0027, \u0027destination_port\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_a873aab3","line":125,"updated":"2015-10-13 07:34:23.000000000","message":"This could be also common.","commit_id":"f5b7f7922d720f50aa309d90a0ca1b1b06785254"},{"author":{"_account_id":12999,"name":"James Arendt","email":"james.arendt@hpe.com","username":"jwarendt"},"change_message_id":"7c7934e4d8c27dc6a595cd4852ff8768438cad72","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def add_known_args(parser, isCreate\u003dTrue):"},{"line_number":73,"context_line":"        # If isCreate is True, protocol and shared become mandatory arguments."},{"line_number":74,"context_line":"        # CreateCommand \u003d isCreate : True"},{"line_number":75,"context_line":"        # UpdateCommand \u003d isCreate : False"},{"line_number":76,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_65a8d777","line":73,"updated":"2015-10-16 17:57:21.000000000","message":"Comment is wrong.  Protocol and action become mandatory, not shared.","commit_id":"a53c42dd5d4e03254071a4670a492c2a60309060"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a16870584259f02269a22c0dfb8469277bf2eeb8","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def add_known_args(parser, isCreate\u003dTrue):"},{"line_number":73,"context_line":"        # If isCreate is True, protocol and shared become mandatory arguments."},{"line_number":74,"context_line":"        # CreateCommand \u003d isCreate : True"},{"line_number":75,"context_line":"        # UpdateCommand \u003d isCreate : False"},{"line_number":76,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_5eec7b29","line":73,"in_reply_to":"5a2ca52d_5b1b2d81","updated":"2015-10-17 13:57:45.000000000","message":"+1","commit_id":"a53c42dd5d4e03254071a4670a492c2a60309060"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"4f53af63d215b86d46d9b96132ece99f35c5630a","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def add_known_args(parser, isCreate\u003dTrue):"},{"line_number":73,"context_line":"        # If isCreate is True, protocol and shared become mandatory arguments."},{"line_number":74,"context_line":"        # CreateCommand \u003d isCreate : True"},{"line_number":75,"context_line":"        # UpdateCommand \u003d isCreate : False"},{"line_number":76,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_5b1b2d81","line":73,"in_reply_to":"5a2ca52d_65a8d777","updated":"2015-10-17 13:25:50.000000000","message":"Oops, Thanks for the review .. You are right","commit_id":"a53c42dd5d4e03254071a4670a492c2a60309060"},{"author":{"_account_id":12999,"name":"James Arendt","email":"james.arendt@hpe.com","username":"jwarendt"},"change_message_id":"7c7934e4d8c27dc6a595cd4852ff8768438cad72","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \u0027--shared\u0027,"},{"line_number":84,"context_line":"            dest\u003d\u0027shared\u0027,"},{"line_number":85,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":86,"context_line":"            help\u003d_(\u0027Set shared to True (default is False).\u0027),"},{"line_number":87,"context_line":"            default\u003dargparse.SUPPRESS)"},{"line_number":88,"context_line":"        parser.add_argument("},{"line_number":89,"context_line":"            \u0027--source-ip-address\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_c57f6b15","line":86,"updated":"2015-10-16 17:57:21.000000000","message":"Breaks compatibility with old update in alternate form \u0027--shared True\u0027 based on extra value parsing.\n\nAlso doesn\u0027t allow update a way to set a shared\u003dTrue firewall rule into a \u0027shared\u003dFalse\u0027 form, hurting usability.","commit_id":"a53c42dd5d4e03254071a4670a492c2a60309060"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"4f53af63d215b86d46d9b96132ece99f35c5630a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \u0027--shared\u0027,"},{"line_number":84,"context_line":"            dest\u003d\u0027shared\u0027,"},{"line_number":85,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":86,"context_line":"            help\u003d_(\u0027Set shared to True (default is False).\u0027),"},{"line_number":87,"context_line":"            default\u003dargparse.SUPPRESS)"},{"line_number":88,"context_line":"        parser.add_argument("},{"line_number":89,"context_line":"            \u0027--source-ip-address\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_3b14314b","line":86,"in_reply_to":"5a2ca52d_c57f6b15","updated":"2015-10-17 13:25:50.000000000","message":"Ok, will correct it","commit_id":"a53c42dd5d4e03254071a4670a492c2a60309060"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ea5d24db59721b1c0e659e01ce819c3f58595d75","unresolved":false,"context_lines":[{"line_number":115,"context_line":"def common_args2body(parsed_args):"},{"line_number":116,"context_line":"    body \u003d {}"},{"line_number":117,"context_line":"    neutronv20.update_dict(parsed_args, body,"},{"line_number":118,"context_line":"                           [\u0027name\u0027, \u0027description\u0027, \u0027shared\u0027, \u0027protocol\u0027,"},{"line_number":119,"context_line":"                            \u0027source_ip_address\u0027, \u0027destination_ip_address\u0027,"},{"line_number":120,"context_line":"                            \u0027source_port\u0027, \u0027destination_port\u0027,"},{"line_number":121,"context_line":"                            \u0027action\u0027, \u0027enabled\u0027, \u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_35363804","line":118,"updated":"2015-10-19 04:00:57.000000000","message":"I think we can remove protocol from here. Anyways, \u0027protocol\u0027 operation is done in L123-L126.","commit_id":"6f020ea32165610892095b6ee755b4c1c194fe5d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a059ddaefbdd5243ef355df86953e98d1e849af5","unresolved":false,"context_lines":[{"line_number":115,"context_line":"def common_args2body(parsed_args):"},{"line_number":116,"context_line":"    body \u003d {}"},{"line_number":117,"context_line":"    neutronv20.update_dict(parsed_args, body,"},{"line_number":118,"context_line":"                           [\u0027name\u0027, \u0027description\u0027, \u0027shared\u0027, \u0027protocol\u0027,"},{"line_number":119,"context_line":"                            \u0027source_ip_address\u0027, \u0027destination_ip_address\u0027,"},{"line_number":120,"context_line":"                            \u0027source_port\u0027, \u0027destination_port\u0027,"},{"line_number":121,"context_line":"                            \u0027action\u0027, \u0027enabled\u0027, \u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_40045414","line":118,"in_reply_to":"3a29b11f_35363804","updated":"2015-10-19 04:03:20.000000000","message":"Ok, \nWill change it once the option for --shared is complete","commit_id":"6f020ea32165610892095b6ee755b4c1c194fe5d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4f3f45a924f60523731c28580c48130f95b31b61","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    resource \u003d \u0027firewall_rule\u0027"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def _add_common_args(parser, isCreate\u003dTrue):"},{"line_number":73,"context_line":"        # If isCreate is True, protocol and action become mandatory arguments."},{"line_number":74,"context_line":"        # CreateCommand \u003d isCreate : True"},{"line_number":75,"context_line":"        # UpdateCommand \u003d isCreate : False"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_bc259409","line":72,"updated":"2015-12-08 11:16:54.000000000","message":"The contents of the method have a wrong indentation. It should be 4.","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"796d2e2471f5cfb97967cce297ee5b918190c908","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    resource \u003d \u0027firewall_rule\u0027"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def _add_common_args(parser, isCreate\u003dTrue):"},{"line_number":73,"context_line":"        # If isCreate is True, protocol and action become mandatory arguments."},{"line_number":74,"context_line":"        # CreateCommand \u003d isCreate : True"},{"line_number":75,"context_line":"        # UpdateCommand \u003d isCreate : False"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_a81e7d09","line":72,"in_reply_to":"7a740942_bc259409","updated":"2015-12-09 04:55:17.000000000","message":"Done","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ec50eb0270f2f1e7da1b0d9fafc53ffc8d3aa0d4","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    resource \u003d \u0027firewall_rule\u0027"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def _add_common_args(parser, isCreate\u003dTrue):"},{"line_number":73,"context_line":"        # If isCreate is True, protocol and action become mandatory arguments."},{"line_number":74,"context_line":"        # CreateCommand \u003d isCreate : True"},{"line_number":75,"context_line":"        # UpdateCommand \u003d isCreate : False"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_53c9f357","line":72,"in_reply_to":"7a740942_bc259409","updated":"2015-12-08 14:32:54.000000000","message":"Guess pep8 missed it.....\nThen again, pep8 thinks this is ok ...\nAnyways, I will fix it in the upcoming PS","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"674baa0c252202ae3ef34a27aa0115c2a0b60da5","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def _add_common_args(parser, isCreate\u003dTrue):"},{"line_number":73,"context_line":"        # If isCreate is True, protocol and action become mandatory arguments."},{"line_number":74,"context_line":"        # CreateCommand \u003d isCreate : True"},{"line_number":75,"context_line":"        # UpdateCommand \u003d isCreate : False"},{"line_number":76,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_8dce9d2c","line":73,"updated":"2015-12-07 13:46:13.000000000","message":"We usually use an underscore delimited parameter instead of a calelcase name. \u0027is_create\u0027?","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"796d2e2471f5cfb97967cce297ee5b918190c908","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def _add_common_args(parser, isCreate\u003dTrue):"},{"line_number":73,"context_line":"        # If isCreate is True, protocol and action become mandatory arguments."},{"line_number":74,"context_line":"        # CreateCommand \u003d isCreate : True"},{"line_number":75,"context_line":"        # UpdateCommand \u003d isCreate : False"},{"line_number":76,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_48191921","line":73,"in_reply_to":"7a740942_8dce9d2c","updated":"2015-12-09 04:55:17.000000000","message":"Done","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d0c357317f57969469346fa2ae91919b4824ad7c","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def _add_common_args(parser, isCreate\u003dTrue):"},{"line_number":73,"context_line":"        # If isCreate is True, protocol and action become mandatory arguments."},{"line_number":74,"context_line":"        # CreateCommand \u003d isCreate : True"},{"line_number":75,"context_line":"        # UpdateCommand \u003d isCreate : False"},{"line_number":76,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_9c4d5140","line":73,"in_reply_to":"7a740942_8dce9d2c","updated":"2015-12-08 00:59:05.000000000","message":"Ok, will change this","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"674baa0c252202ae3ef34a27aa0115c2a0b60da5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"def _add_common_args(parser, isCreate\u003dTrue):"},{"line_number":73,"context_line":"        # If isCreate is True, protocol and action become mandatory arguments."},{"line_number":74,"context_line":"        # CreateCommand \u003d isCreate : True"},{"line_number":75,"context_line":"        # UpdateCommand \u003d isCreate : False"},{"line_number":76,"context_line":"        parser.add_argument("},{"line_number":77,"context_line":"            \u0027--name\u0027,"},{"line_number":78,"context_line":"            help\u003d_(\u0027Name for the firewall rule.\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_cd7ca5b7","line":75,"updated":"2015-12-07 13:46:13.000000000","message":"This should be a docsting.","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"796d2e2471f5cfb97967cce297ee5b918190c908","unresolved":false,"context_lines":[{"line_number":72,"context_line":"def _add_common_args(parser, isCreate\u003dTrue):"},{"line_number":73,"context_line":"        # If isCreate is True, protocol and action become mandatory arguments."},{"line_number":74,"context_line":"        # CreateCommand \u003d isCreate : True"},{"line_number":75,"context_line":"        # UpdateCommand \u003d isCreate : False"},{"line_number":76,"context_line":"        parser.add_argument("},{"line_number":77,"context_line":"            \u0027--name\u0027,"},{"line_number":78,"context_line":"            help\u003d_(\u0027Name for the firewall rule.\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_681415e8","line":75,"in_reply_to":"7a740942_cd7ca5b7","updated":"2015-12-09 04:55:17.000000000","message":"Done","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d0c357317f57969469346fa2ae91919b4824ad7c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"def _add_common_args(parser, isCreate\u003dTrue):"},{"line_number":73,"context_line":"        # If isCreate is True, protocol and action become mandatory arguments."},{"line_number":74,"context_line":"        # CreateCommand \u003d isCreate : True"},{"line_number":75,"context_line":"        # UpdateCommand \u003d isCreate : False"},{"line_number":76,"context_line":"        parser.add_argument("},{"line_number":77,"context_line":"            \u0027--name\u0027,"},{"line_number":78,"context_line":"            help\u003d_(\u0027Name for the firewall rule.\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_bc4a8d24","line":75,"in_reply_to":"7a740942_cd7ca5b7","updated":"2015-12-08 00:59:05.000000000","message":"Ok","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"674baa0c252202ae3ef34a27aa0115c2a0b60da5","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        parser.add_argument("},{"line_number":83,"context_line":"            \u0027--shared\u0027,"},{"line_number":84,"context_line":"            dest\u003d\u0027shared\u0027,"},{"line_number":85,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":86,"context_line":"            const\u003dTrue,"},{"line_number":87,"context_line":"            help\u003d_(\u0027Set shared flag for the firewall rule.\u0027),"},{"line_number":88,"context_line":"            default\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_ada83921","line":85,"updated":"2015-12-07 13:46:13.000000000","message":"Please describe the special reason you need to nargs\u003d\u0027?\u0027.\nIn the CLI option guideline, I discourage the usage of nargs\u003d\u0027?\u0027.\n\nNote that I will not be convinced if the reason is just to share the option definition between create and update. You can see many tricky behavior of nargs\u003d\u0027?\u0027 in the CLI option guideline.","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b68c082f070d25b2be3f4ab3eec658966d56879","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        parser.add_argument("},{"line_number":83,"context_line":"            \u0027--shared\u0027,"},{"line_number":84,"context_line":"            dest\u003d\u0027shared\u0027,"},{"line_number":85,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":86,"context_line":"            const\u003dTrue,"},{"line_number":87,"context_line":"            help\u003d_(\u0027Set shared flag for the firewall rule.\u0027),"},{"line_number":88,"context_line":"            default\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_d3b65ff8","line":85,"in_reply_to":"7a740942_7ced05b6","updated":"2015-12-08 04:49:44.000000000","message":"my suggestion is to keep \u0027--shared\u0027 only for create and use \u0027--shared True/False\u0027 for update. I don\u0027t think you case is special. For create, only \u0027--shared\u0027 is enough and for update \u0027--shared True/False\u0027 is enough because they cover all possible use cases.\n\nI see several tricky behavior of nargs\u003d\u0027?\u0027 when we try to use nargs\u003d\u0027?\u0027 in similar cases. You can see more concrete examples in  [1] (though it is does not cover all).\nCan you believe this NEVER brings this kind of confusion?\n\nI believe this kind of tricky behavior brings bad user experience and avoiding this has more benefit than supporting both \u0027--shared\u0027 and \u0027--shared True/False\u0027.\n\nI don\u0027t like an approach to introduce it first and then revert it if some trouble.\n\n[1] http://git.openstack.org/cgit/openstack/python-neutronclient/tree/doc/source/devref/cli_option_guideline.rst#n159","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d0c357317f57969469346fa2ae91919b4824ad7c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        parser.add_argument("},{"line_number":83,"context_line":"            \u0027--shared\u0027,"},{"line_number":84,"context_line":"            dest\u003d\u0027shared\u0027,"},{"line_number":85,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":86,"context_line":"            const\u003dTrue,"},{"line_number":87,"context_line":"            help\u003d_(\u0027Set shared flag for the firewall rule.\u0027),"},{"line_number":88,"context_line":"            default\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_7ced05b6","line":85,"in_reply_to":"7a740942_ada83921","updated":"2015-12-08 00:59:05.000000000","message":"The reason why I wanted to provide nargs\u003d? is to provide support of \n--shared, --shared True and --shared False.Earlier --shared only had the action of storing True.\nWhat do you suggest?","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"796d2e2471f5cfb97967cce297ee5b918190c908","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        parser.add_argument("},{"line_number":83,"context_line":"            \u0027--shared\u0027,"},{"line_number":84,"context_line":"            dest\u003d\u0027shared\u0027,"},{"line_number":85,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":86,"context_line":"            const\u003dTrue,"},{"line_number":87,"context_line":"            help\u003d_(\u0027Set shared flag for the firewall rule.\u0027),"},{"line_number":88,"context_line":"            default\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_08d6b127","line":85,"in_reply_to":"7a740942_d3b65ff8","updated":"2015-12-09 04:55:17.000000000","message":"Done","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ac429f9c4e7d248024a3aba5bfcdf09059c3d4e7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        parser.add_argument("},{"line_number":83,"context_line":"            \u0027--shared\u0027,"},{"line_number":84,"context_line":"            dest\u003d\u0027shared\u0027,"},{"line_number":85,"context_line":"            nargs\u003d\u0027?\u0027,"},{"line_number":86,"context_line":"            const\u003dTrue,"},{"line_number":87,"context_line":"            help\u003d_(\u0027Set shared flag for the firewall rule.\u0027),"},{"line_number":88,"context_line":"            default\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_937bf727","line":85,"in_reply_to":"7a740942_d3b65ff8","updated":"2015-12-08 04:52:27.000000000","message":"Ok, thanks for the suggestion.\nWill look into working on that in the next PS.\n\n( Note: considering the points mentioned in the devref guide , I have also changed some other neutronClient patch sets :) . Hope they help )","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"674baa0c252202ae3ef34a27aa0115c2a0b60da5","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    resource \u003d \u0027firewall_rule\u0027"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":149,"context_line":"        _add_common_args(parser, False)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def args2body(self, parsed_args):"},{"line_number":152,"context_line":"        return {self.resource: common_args2body(parsed_args)}"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_4d3e75db","line":149,"updated":"2015-12-07 13:46:13.000000000","message":"I prefer is_create\u003dFalse rather than False. It looks clearer.","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d0c357317f57969469346fa2ae91919b4824ad7c","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    resource \u003d \u0027firewall_rule\u0027"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":149,"context_line":"        _add_common_args(parser, False)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def args2body(self, parsed_args):"},{"line_number":152,"context_line":"        return {self.resource: common_args2body(parsed_args)}"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_5c0129ae","line":149,"in_reply_to":"7a740942_4d3e75db","updated":"2015-12-08 00:59:05.000000000","message":"ok, will update it","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"}],"neutronclient/tests/unit/fw/test_cli20_firewallrule.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"edcdbd709c9d0d80520657d6c3eae52aeb036ceb","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                                   [\u0027myid\u0027, \u0027--protocol\u0027, \u0027any\u0027],"},{"line_number":171,"context_line":"                                   {\u0027protocol\u0027: None, })"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test_update_firewall_rule_description(self):"},{"line_number":174,"context_line":"        \"\"\"firewall-rule-update myid --description any\"\"\""},{"line_number":175,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":176,"context_line":"        cmd \u003d firewallrule.UpdateFirewallRule(test_cli20.MyApp(sys.stdout),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_76c85355","line":173,"updated":"2015-10-11 06:26:48.000000000","message":"IMHO, we can have single test-case addressing all the updatable parameters.","commit_id":"b87db2fccc240a7b557be981eb3c3a4d0821c4e7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3fe0f29869b1b7802afc44479f4f3d8979bdf3e6","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                                   [\u0027myid\u0027, \u0027--protocol\u0027, \u0027any\u0027],"},{"line_number":171,"context_line":"                                   {\u0027protocol\u0027: None, })"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test_update_firewall_rule_description(self):"},{"line_number":174,"context_line":"        \"\"\"firewall-rule-update myid --description any\"\"\""},{"line_number":175,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":176,"context_line":"        cmd \u003d firewallrule.UpdateFirewallRule(test_cli20.MyApp(sys.stdout),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_0ca9ce23","line":173,"in_reply_to":"7a2fa921_76c85355","updated":"2015-10-11 13:51:30.000000000","message":"I think keeping them separatge is better, so that if anything is added/subtracted in the parameters later on, or if something is updated, it would be easier to track the test which corresponds to the change.","commit_id":"b87db2fccc240a7b557be981eb3c3a4d0821c4e7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"6bb15982ede2b8d61529b7c65b6222d8ddf9a55a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                                   [\u0027myid\u0027, \u0027--protocol\u0027, \u0027any\u0027],"},{"line_number":171,"context_line":"                                   {\u0027protocol\u0027: None, })"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test_update_firewall_rule_description(self):"},{"line_number":174,"context_line":"        \"\"\"firewall-rule-update myid --description any\"\"\""},{"line_number":175,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":176,"context_line":"        cmd \u003d firewallrule.UpdateFirewallRule(test_cli20.MyApp(sys.stdout),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_08009ea9","line":173,"updated":"2015-10-13 07:34:23.000000000","message":"I still feel we can have only one test-case for verifying all the update operation\u0027s. More tests will just increase the run time.","commit_id":"f5b7f7922d720f50aa309d90a0ca1b1b06785254"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"674baa0c252202ae3ef34a27aa0115c2a0b60da5","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                                   [\u0027myid\u0027, \u0027--name\u0027, \u0027newname\u0027],"},{"line_number":171,"context_line":"                                   {\u0027name\u0027: \u0027newname\u0027, })"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        \"\"\"firewall-rule-update myid --description any\"\"\""},{"line_number":174,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":175,"context_line":"        cmd \u003d firewallrule.UpdateFirewallRule(test_cli20.MyApp(sys.stdout),"},{"line_number":176,"context_line":"                                              None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_b86079d0","line":173,"updated":"2015-12-07 13:46:13.000000000","message":"It should be a comment with \u0027# \u0027.\nIt is not usual to use a triple quote in the middle of the method","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"796d2e2471f5cfb97967cce297ee5b918190c908","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                                   [\u0027myid\u0027, \u0027--name\u0027, \u0027newname\u0027],"},{"line_number":171,"context_line":"                                   {\u0027name\u0027: \u0027newname\u0027, })"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        \"\"\"firewall-rule-update myid --description any\"\"\""},{"line_number":174,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":175,"context_line":"        cmd \u003d firewallrule.UpdateFirewallRule(test_cli20.MyApp(sys.stdout),"},{"line_number":176,"context_line":"                                              None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_28e36dda","line":173,"in_reply_to":"7a740942_b86079d0","updated":"2015-12-09 04:55:17.000000000","message":"Done","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d0c357317f57969469346fa2ae91919b4824ad7c","unresolved":false,"context_lines":[{"line_number":170,"context_line":"                                   [\u0027myid\u0027, \u0027--name\u0027, \u0027newname\u0027],"},{"line_number":171,"context_line":"                                   {\u0027name\u0027: \u0027newname\u0027, })"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        \"\"\"firewall-rule-update myid --description any\"\"\""},{"line_number":174,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":175,"context_line":"        cmd \u003d firewallrule.UpdateFirewallRule(test_cli20.MyApp(sys.stdout),"},{"line_number":176,"context_line":"                                              None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_5ce369a4","line":173,"in_reply_to":"7a740942_b86079d0","updated":"2015-12-08 00:59:05.000000000","message":"I guess its not a rule, but ok, I will change it","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"796d2e2471f5cfb97967cce297ee5b918190c908","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                                   [\u0027myid\u0027, \u0027--enabled\u0027, \u0027False\u0027],"},{"line_number":217,"context_line":"                                   {\u0027enabled\u0027: \u0027False\u0027, })"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        \"\"\"firewall-rule-update myid --action reject\"\"\""},{"line_number":220,"context_line":"        cmd \u003d firewallrule.UpdateFirewallRule(test_cli20.MyApp(sys.stdout),"},{"line_number":221,"context_line":"                                              None)"},{"line_number":222,"context_line":"        self._test_update_resource(resource, cmd, \u0027myid\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_c8e509dc","line":219,"updated":"2015-12-09 04:55:17.000000000","message":"Additionally added a test case for shared","commit_id":"a76822ca333643a1405dd44c4d138ebbee338901"}]}
