)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"54931e21851c71ca241cec7dfd0d8692b6cfe82a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ryan Tidwell \u003cryan.tidwell@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-12 13:47:09 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for ip_version on AddressScope create."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Address scopes must now be created with an explicit ip_version. This patch"},{"line_number":10,"context_line":"enables ip_version to be passed on the neutron CLI."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a2fa921_4f51c061","line":7,"updated":"2015-10-13 06:25:43.000000000","message":"Please remove the period at the end of the first statement.\n\nJFR:\n¨The first line should be limited to 50 characters and should not end with a period.¨\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"b4dcea7ebd38a5240b3fb13b884be3b325aba627"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"589209540d9ffc6be214c72da90ae194911f3ed5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Address scopes must now be created with an explicit ip_version. This patch"},{"line_number":10,"context_line":"enables ip_version to be passed on the neutron CLI."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iee902e1539d2bc0cb03c24f483ab7bab8b6a657e"},{"line_number":13,"context_line":"Partially-Implements: blueprint address-scopes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a2ca52d_1c288b99","line":12,"updated":"2015-10-15 22:16:37.000000000","message":"Should this have this line?\n\nDepends-On:  Ibc6de08e0ef58a5da954d13f274f6003012a76cd","commit_id":"3d7e91646871e7b9efde1f0c022f7ebb2f4bc2c5"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"7ff9c47b1c50fc49dfe2201b900d721075397ec5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Address scopes must now be created with an explicit ip_version. This patch"},{"line_number":10,"context_line":"enables ip_version to be passed on the neutron CLI."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iee902e1539d2bc0cb03c24f483ab7bab8b6a657e"},{"line_number":13,"context_line":"Partially-Implements: blueprint address-scopes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a2ca52d_2d3f4f25","line":12,"in_reply_to":"5a2ca52d_1c288b99","updated":"2015-10-15 23:45:02.000000000","message":"Sure","commit_id":"3d7e91646871e7b9efde1f0c022f7ebb2f4bc2c5"}],"neutronclient/neutron/v2_0/address_scope.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"54931e21851c71ca241cec7dfd0d8692b6cfe82a","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--shared\u0027,"},{"line_number":44,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":45,"context_line":"            help\u003d_(\u0027Set the address scope as shared.\u0027))"},{"line_number":46,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_6f983c6b","line":43,"updated":"2015-10-13 06:25:43.000000000","message":"shouldn´t dest\u003dshared be added to this ?","commit_id":"b4dcea7ebd38a5240b3fb13b884be3b325aba627"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ca9b7167a4e9c184f6533a00c549c12c7f28e319","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027--shared\u0027,"},{"line_number":44,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":45,"context_line":"            help\u003d_(\u0027Set the address scope as shared.\u0027))"},{"line_number":46,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_e58f8b73","line":43,"in_reply_to":"7a2fa921_6f983c6b","updated":"2015-10-13 07:10:40.000000000","message":"Not required.","commit_id":"b4dcea7ebd38a5240b3fb13b884be3b325aba627"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"0860e6f3c03bd44a5dc708210a8ca04d37d05904","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027name\u0027,"},{"line_number":48,"context_line":"            help\u003d_(\u0027Specify the name of the address scope.\u0027))"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027ip_version\u0027,"},{"line_number":51,"context_line":"            help\u003d_(\u0027Specify the address family of the address scope.\u0027))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_dd090ddf","line":50,"updated":"2015-10-13 05:46:07.000000000","message":"How about adding:\n\ndefault\u003d\u0027IPv4\u0027, choices\u003d[\u0027IPv4\u0027, \u0027IPv6\u0027],","commit_id":"b4dcea7ebd38a5240b3fb13b884be3b325aba627"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"db23591036205778ca93c4f360ad77488e7572eb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027name\u0027,"},{"line_number":48,"context_line":"            help\u003d_(\u0027Specify the name of the address scope.\u0027))"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027ip_version\u0027,"},{"line_number":51,"context_line":"            help\u003d_(\u0027Specify the address family of the address scope.\u0027))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_89effbaf","line":50,"in_reply_to":"7a2fa921_8fb838e7","updated":"2015-10-13 14:58:34.000000000","message":"Why do we want this to default? This is a required param, an important one at that.  If no value is provided it should be interpreted as bad usage of the client, not a situation to apply a default value.  Adding the choices field might be a good idea though.","commit_id":"b4dcea7ebd38a5240b3fb13b884be3b325aba627"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"54931e21851c71ca241cec7dfd0d8692b6cfe82a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027name\u0027,"},{"line_number":48,"context_line":"            help\u003d_(\u0027Specify the name of the address scope.\u0027))"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027ip_version\u0027,"},{"line_number":51,"context_line":"            help\u003d_(\u0027Specify the address family of the address scope.\u0027))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_8fb838e7","line":50,"in_reply_to":"7a2fa921_dd090ddf","updated":"2015-10-13 06:25:43.000000000","message":"+1 Vikram","commit_id":"b4dcea7ebd38a5240b3fb13b884be3b325aba627"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ecf9f73c53e9c3bb5270aafb4bb8e691e0bfe12e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027name\u0027,"},{"line_number":48,"context_line":"            help\u003d_(\u0027Specify the name of the address scope.\u0027))"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027ip_version\u0027,"},{"line_number":51,"context_line":"            type\u003dint,"},{"line_number":52,"context_line":"            choices\u003d[4, 6],"},{"line_number":53,"context_line":"            help\u003d_(\u0027Specify the address family of the address scope.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_25e8357c","line":50,"updated":"2015-10-14 00:57:44.000000000","message":"ip_version for firewall takes up a default value of 4 and it is an optional value.\nThat is why I think Vikram stated that this also be optional and have a default value of 4, so that the behavior is consistent.","commit_id":"3d7e91646871e7b9efde1f0c022f7ebb2f4bc2c5"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"589209540d9ffc6be214c72da90ae194911f3ed5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027name\u0027,"},{"line_number":48,"context_line":"            help\u003d_(\u0027Specify the name of the address scope.\u0027))"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027ip_version\u0027,"},{"line_number":51,"context_line":"            type\u003dint,"},{"line_number":52,"context_line":"            choices\u003d[4, 6],"},{"line_number":53,"context_line":"            help\u003d_(\u0027Specify the address family of the address scope.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_5cb4c380","line":50,"in_reply_to":"5a2ca52d_0763b8dd","updated":"2015-10-15 22:16:37.000000000","message":"Let\u0027s start without a default.  It is easier to add a default than it is to take it away.","commit_id":"3d7e91646871e7b9efde1f0c022f7ebb2f4bc2c5"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7e9c727bdea8afc69a69ed52ab9ba96f4afccff8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027name\u0027,"},{"line_number":48,"context_line":"            help\u003d_(\u0027Specify the name of the address scope.\u0027))"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027ip_version\u0027,"},{"line_number":51,"context_line":"            type\u003dint,"},{"line_number":52,"context_line":"            choices\u003d[4, 6],"},{"line_number":53,"context_line":"            help\u003d_(\u0027Specify the address family of the address scope.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_0763b8dd","line":50,"in_reply_to":"5a2ca52d_25e8357c","updated":"2015-10-14 05:18:29.000000000","message":"I am okay having this as a mandatory param.","commit_id":"3d7e91646871e7b9efde1f0c022f7ebb2f4bc2c5"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"98d95339c7304fabb74f1ed3cfc3009b05e022fe","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027name\u0027,"},{"line_number":48,"context_line":"            help\u003d_(\u0027Specify the name of the address scope.\u0027))"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027ip_version\u0027,"},{"line_number":51,"context_line":"            type\u003dint,"},{"line_number":52,"context_line":"            choices\u003d[4, 6],"},{"line_number":53,"context_line":"            help\u003d_(\u0027Specify the address family of the address scope.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_0ca3ce50","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":24},"updated":"2015-12-24 06:30:12.000000000","message":"I get here because Ibc6de08e0ef58a5da954d13f274f6003012a76cd has been merged. And creating address-scope without specify ip version will fail.\n\nBut when I apply this patch in my local env, I get [1]. After adding choices, I think \"metavar\" should be used to decorate the output.\n\n[1] http://paste.openstack.org/show/482646/","commit_id":"100da20426640868443a89fd7757b13fb473e0bd"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7aa6ab41040b3d73e0e65826c05f3a78afc00a03","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027name\u0027,"},{"line_number":48,"context_line":"            help\u003d_(\u0027Specify the name of the address scope.\u0027))"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027ip_version\u0027,"},{"line_number":51,"context_line":"            type\u003dint,"},{"line_number":52,"context_line":"            choices\u003d[4, 6],"},{"line_number":53,"context_line":"            help\u003d_(\u0027Specify the address family of the address scope.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_4c90c043","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":24},"in_reply_to":"1a7b0d38_0265a9df","updated":"2015-12-26 11:59:54.000000000","message":"+1 for IPv4 as default.","commit_id":"100da20426640868443a89fd7757b13fb473e0bd"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6e1a1a7786743cdf8ec5981d4e05750afe63c8d0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027name\u0027,"},{"line_number":48,"context_line":"            help\u003d_(\u0027Specify the name of the address scope.\u0027))"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027ip_version\u0027,"},{"line_number":51,"context_line":"            type\u003dint,"},{"line_number":52,"context_line":"            choices\u003d[4, 6],"},{"line_number":53,"context_line":"            help\u003d_(\u0027Specify the address family of the address scope.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_e2c5fd8d","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":24},"in_reply_to":"1a7b0d38_0265a9df","updated":"2015-12-26 02:59:19.000000000","message":"Update ;Looing over the previous patches I asked the same question in this patch on the first set, and got a response.\nSorry for putting it up again :)","commit_id":"100da20426640868443a89fd7757b13fb473e0bd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c8b58280628183c145657a5810e02ac7264b1ab6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027name\u0027,"},{"line_number":48,"context_line":"            help\u003d_(\u0027Specify the name of the address scope.\u0027))"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027ip_version\u0027,"},{"line_number":51,"context_line":"            type\u003dint,"},{"line_number":52,"context_line":"            choices\u003d[4, 6],"},{"line_number":53,"context_line":"            help\u003d_(\u0027Specify the address family of the address scope.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_af406ca6","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":24},"in_reply_to":"1a7b0d38_0ca3ce50","updated":"2015-12-24 06:59:35.000000000","message":"+1 for adding metavar.\n\n metavar\u003d\u0027IP_VERSION\u0027\n\nor add \"--ip-version\" as mandatory.","commit_id":"100da20426640868443a89fd7757b13fb473e0bd"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bcd61a2a6802298ae1988920e768c71034ff7795","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027name\u0027,"},{"line_number":48,"context_line":"            help\u003d_(\u0027Specify the name of the address scope.\u0027))"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027ip_version\u0027,"},{"line_number":51,"context_line":"            type\u003dint,"},{"line_number":52,"context_line":"            choices\u003d[4, 6],"},{"line_number":53,"context_line":"            help\u003d_(\u0027Specify the address family of the address scope.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a7b0d38_0265a9df","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":24},"in_reply_to":"1a7b0d38_af406ca6","updated":"2015-12-26 02:55:54.000000000","message":"Yup, the metavar is required here....\nI am in favor of metavar\u003d\u0027IP_VERSION\u0027 , more, than adding --ip_version as a mandatory parameter.\n\n\nAlso, I have a question.\nIs it really mandatory to pass an IP_Version?\nCant we use a default value , i.e. if IP_Version is not passed, then IPv4 would be used ?\nJust a query","commit_id":"100da20426640868443a89fd7757b13fb473e0bd"}],"neutronclient/tests/unit/test_cli20_address_scope.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"54931e21851c71ca241cec7dfd0d8692b6cfe82a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        cmd \u003d address_scope.CreateAddressScope("},{"line_number":34,"context_line":"            test_cli20.MyApp(sys.stdout), None)"},{"line_number":35,"context_line":"        name \u003d \u0027foo-address-scope\u0027"},{"line_number":36,"context_line":"        ip_version \u003d \u00274\u0027"},{"line_number":37,"context_line":"        myid \u003d \u0027myid\u0027"},{"line_number":38,"context_line":"        args \u003d [name, ip_version]"},{"line_number":39,"context_line":"        position_names \u003d [\u0027name\u0027, \u0027ip_version\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_ef1f6cb5","line":36,"updated":"2015-10-13 06:25:43.000000000","message":"Can you add a test case for IPv6?","commit_id":"b4dcea7ebd38a5240b3fb13b884be3b325aba627"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"db23591036205778ca93c4f360ad77488e7572eb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        cmd \u003d address_scope.CreateAddressScope("},{"line_number":34,"context_line":"            test_cli20.MyApp(sys.stdout), None)"},{"line_number":35,"context_line":"        name \u003d \u0027foo-address-scope\u0027"},{"line_number":36,"context_line":"        ip_version \u003d \u00274\u0027"},{"line_number":37,"context_line":"        myid \u003d \u0027myid\u0027"},{"line_number":38,"context_line":"        args \u003d [name, ip_version]"},{"line_number":39,"context_line":"        position_names \u003d [\u0027name\u0027, \u0027ip_version\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_a92517c3","line":36,"in_reply_to":"7a2fa921_ef1f6cb5","updated":"2015-10-13 14:58:34.000000000","message":"Yes, and I\u0027ll add an IPv5 case as well so we verify that the client does some minimal validation.","commit_id":"b4dcea7ebd38a5240b3fb13b884be3b325aba627"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7e9c727bdea8afc69a69ed52ab9ba96f4afccff8","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self._test_create_resource(resource, cmd, name, myid, args,"},{"line_number":54,"context_line":"                                   position_names, position_values)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_create_address_scope_with_minimum_option_bad_ip_version(self):"},{"line_number":57,"context_line":"        \"\"\"Create address_scope: foo-address-scope with minimum option.\"\"\""},{"line_number":58,"context_line":"        resource \u003d \u0027address_scope\u0027"},{"line_number":59,"context_line":"        cmd \u003d address_scope.CreateAddressScope("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_27b7d43a","line":56,"updated":"2015-10-14 05:18:29.000000000","message":"Good test case for catching invalid version.","commit_id":"3d7e91646871e7b9efde1f0c022f7ebb2f4bc2c5"}]}