)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"61457dce5e9142ce5cb28ffa222c786a8cfff4a8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently firewall rule create/update allows only lower case values for"},{"line_number":10,"context_line":"its protocol and action arguments. Limiting the protocol/action attribute"},{"line_number":11,"context_line":"to lower case is not very user friendly. This patch allows the user to"},{"line_number":12,"context_line":"provide protocol and action fields in UPPER/lower case."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ib8b278fc89f81d89d30f4e8dde9797e9149d3919"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a29b11f_d3a72bbb","line":11,"updated":"2015-10-22 09:02:34.000000000","message":"The reason why I am stating that it is not user friendly is because several users and deployers generally read Transmission Control Protocol as TCP and not tcp.\nSimilarly for UDP and ICMP.\nAdditionally, it is my feeling that the ACTION can also be changed to complete upper case.\nA further improvement in the this would be Camel Casing, but I am not sure if that would be in scope.","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"}],"neutronclient/neutron/v2_0/fw/firewallrule.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d2728cd86f0f07b76896443609bb5236ebf14716","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def args2body(self, parsed_args):"},{"line_number":144,"context_line":"        body \u003d {}"},{"line_number":145,"context_line":"        protocol \u003d (parsed_args.protocol)"},{"line_number":146,"context_line":"        if protocol:"},{"line_number":147,"context_line":"            protocol \u003d protocol.lower()"},{"line_number":148,"context_line":"            if protocol \u003d\u003d \u0027any\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_46e6fe15","line":145,"updated":"2015-10-22 08:20:14.000000000","message":"Unnecessary brackets added(self review)","commit_id":"c99646084ea3d7002a38b2c18297b412a1785d45"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"425c43dba963c409bed8ac4d223bbda35071bfd6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutronclient.i18n import _"},{"line_number":21,"context_line":"from neutronclient.neutron import v2_0 as neutronv20"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"PROTOCOL_CHOICES \u003d [\u0027TCP\u0027, \u0027tcp\u0027, \u0027UDP\u0027, \u0027udp\u0027, \u0027ICMP\u0027, \u0027icmp\u0027, \u0027ANY\u0027, \u0027any\u0027]"},{"line_number":24,"context_line":"ACTION_CHOICES \u003d [\u0027ALLOW\u0027, \u0027allow\u0027, \u0027DENY\u0027, \u0027deny\u0027, \u0027REJECT\u0027, \u0027reject\u0027]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_03a8871e","line":23,"updated":"2015-11-04 13:13:42.000000000","message":"why you want to allow \u0027ANY\u0027 in caps?","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cf899ebff19f6d7a321b906855eb8dda8cd3e5ce","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutronclient.i18n import _"},{"line_number":21,"context_line":"from neutronclient.neutron import v2_0 as neutronv20"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"PROTOCOL_CHOICES \u003d [\u0027TCP\u0027, \u0027tcp\u0027, \u0027UDP\u0027, \u0027udp\u0027, \u0027ICMP\u0027, \u0027icmp\u0027, \u0027ANY\u0027, \u0027any\u0027]"},{"line_number":24,"context_line":"ACTION_CHOICES \u003d [\u0027ALLOW\u0027, \u0027allow\u0027, \u0027DENY\u0027, \u0027deny\u0027, \u0027REJECT\u0027, \u0027reject\u0027]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_c82056fa","line":23,"in_reply_to":"fa80f949_03a8871e","updated":"2015-11-04 15:44:25.000000000","message":"I don\u0027t like this kind of manual duplications :-(\n\nThis approach is too redundant.\n\nIf you go to this way, I would suggest to define a method and pass it to \u0027type\u0027 argument of add_argument().\n\nhttps://docs.python.org/2.7/library/argparse.html#type","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b51c30650374fcfb7ac3d1bc28e07ef42e1d2bd6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutronclient.i18n import _"},{"line_number":21,"context_line":"from neutronclient.neutron import v2_0 as neutronv20"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"PROTOCOL_CHOICES \u003d [\u0027TCP\u0027, \u0027tcp\u0027, \u0027UDP\u0027, \u0027udp\u0027, \u0027ICMP\u0027, \u0027icmp\u0027, \u0027ANY\u0027, \u0027any\u0027]"},{"line_number":24,"context_line":"ACTION_CHOICES \u003d [\u0027ALLOW\u0027, \u0027allow\u0027, \u0027DENY\u0027, \u0027deny\u0027, \u0027REJECT\u0027, \u0027reject\u0027]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_b9998c70","line":23,"in_reply_to":"fa80f949_03a8871e","updated":"2015-11-10 05:42:31.000000000","message":"Removed ... :)","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bfc275858a30770e857f7744945ea94a3ea5ff50","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutronclient.i18n import _"},{"line_number":21,"context_line":"from neutronclient.neutron import v2_0 as neutronv20"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"PROTOCOL_CHOICES \u003d [\u0027TCP\u0027, \u0027tcp\u0027, \u0027UDP\u0027, \u0027udp\u0027, \u0027ICMP\u0027, \u0027icmp\u0027, \u0027ANY\u0027, \u0027any\u0027]"},{"line_number":24,"context_line":"ACTION_CHOICES \u003d [\u0027ALLOW\u0027, \u0027allow\u0027, \u0027DENY\u0027, \u0027deny\u0027, \u0027REJECT\u0027, \u0027reject\u0027]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_c1157e49","line":23,"in_reply_to":"fa80f949_c82056fa","updated":"2015-11-05 01:29:24.000000000","message":"@Akihiro:\nThanks a lot for the suggestion. I would also like to avoid manual duplications , and I guess the above method seems more in line with my expectations.\nI will give it a try and update the code.\n\n@Vikram: \nYeah, ANY can be removed. I just wanted it to be kept in line with the other options, but I guess it is not required.","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b51c30650374fcfb7ac3d1bc28e07ef42e1d2bd6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutronclient.i18n import _"},{"line_number":21,"context_line":"from neutronclient.neutron import v2_0 as neutronv20"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"PROTOCOL_CHOICES \u003d [\u0027TCP\u0027, \u0027tcp\u0027, \u0027UDP\u0027, \u0027udp\u0027, \u0027ICMP\u0027, \u0027icmp\u0027, \u0027ANY\u0027, \u0027any\u0027]"},{"line_number":24,"context_line":"ACTION_CHOICES \u003d [\u0027ALLOW\u0027, \u0027allow\u0027, \u0027DENY\u0027, \u0027deny\u0027, \u0027REJECT\u0027, \u0027reject\u0027]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_d99c905f","line":23,"in_reply_to":"fa80f949_c82056fa","updated":"2015-11-10 05:42:31.000000000","message":"Updated :)","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"425c43dba963c409bed8ac4d223bbda35071bfd6","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                               [\u0027name\u0027, \u0027description\u0027, \u0027shared\u0027, \u0027protocol\u0027,"},{"line_number":117,"context_line":"                                \u0027source_ip_address\u0027, \u0027destination_ip_address\u0027,"},{"line_number":118,"context_line":"                                \u0027source_port\u0027, \u0027destination_port\u0027,"},{"line_number":119,"context_line":"                                \u0027action\u0027, \u0027enabled\u0027, \u0027tenant_id\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        protocol \u003d (parsed_args.protocol).lower()"},{"line_number":122,"context_line":"        if protocol \u003d\u003d \u0027any\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_a3bc1b6d","line":119,"updated":"2015-11-04 13:13:42.000000000","message":"please remove \u0027action\u0027 and \u0027protocol\u0027 fields from here. These are explicitly added in L127 and L128.","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b51c30650374fcfb7ac3d1bc28e07ef42e1d2bd6","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                               [\u0027name\u0027, \u0027description\u0027, \u0027shared\u0027, \u0027protocol\u0027,"},{"line_number":117,"context_line":"                                \u0027source_ip_address\u0027, \u0027destination_ip_address\u0027,"},{"line_number":118,"context_line":"                                \u0027source_port\u0027, \u0027destination_port\u0027,"},{"line_number":119,"context_line":"                                \u0027action\u0027, \u0027enabled\u0027, \u0027tenant_id\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        protocol \u003d (parsed_args.protocol).lower()"},{"line_number":122,"context_line":"        if protocol \u003d\u003d \u0027any\u0027:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_d9b330e8","line":119,"in_reply_to":"fa80f949_a3bc1b6d","updated":"2015-11-10 05:42:31.000000000","message":"If you verify the source code, it had protocol in both the locations :)\nI have removed it....","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"425c43dba963c409bed8ac4d223bbda35071bfd6","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        protocol \u003d (parsed_args.protocol).lower()"},{"line_number":122,"context_line":"        if protocol \u003d\u003d \u0027any\u0027:"},{"line_number":123,"context_line":"            protocol \u003d None"},{"line_number":124,"context_line":"        action \u003d (parsed_args.action).lower()"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        body[\u0027protocol\u0027] \u003d protocol"},{"line_number":127,"context_line":"        body[\u0027action\u0027] \u003d action"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_c336ff02","line":124,"updated":"2015-11-04 13:13:42.000000000","message":"Please move the action part together i.e. L124 and L127 at one place.","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b51c30650374fcfb7ac3d1bc28e07ef42e1d2bd6","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        protocol \u003d (parsed_args.protocol).lower()"},{"line_number":122,"context_line":"        if protocol \u003d\u003d \u0027any\u0027:"},{"line_number":123,"context_line":"            protocol \u003d None"},{"line_number":124,"context_line":"        action \u003d (parsed_args.action).lower()"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        body[\u0027protocol\u0027] \u003d protocol"},{"line_number":127,"context_line":"        body[\u0027action\u0027] \u003d action"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_59c0a02a","line":124,"in_reply_to":"fa80f949_c336ff02","updated":"2015-11-10 05:42:31.000000000","message":"The complete action section has been removed, thanks to change mentioned by Amotoki.","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ba89eaa59336cb702d9e3e6d61d4f060d8781d44","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def convert_to_lowercase(string):"},{"line_number":25,"context_line":"    return string.lower()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ListFirewallRule(neutronv20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_5970020b","line":25,"updated":"2015-12-09 10:36:04.000000000","message":"This can be shared by multiple commands.\nAs https://review.openstack.org/#/c/238325, it is better to define it in common.utils.","commit_id":"1d29903c22d550e1ec7692f4fbb7cde11d537f3d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"25c1396324a8ab919454e79ed729de466ec70a27","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def convert_to_lowercase(string):"},{"line_number":25,"context_line":"    return string.lower()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ListFirewallRule(neutronv20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_e34a2927","line":25,"in_reply_to":"7a740942_43245dae","updated":"2015-12-10 03:37:40.000000000","message":"Done","commit_id":"1d29903c22d550e1ec7692f4fbb7cde11d537f3d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"8e14356bd456d260ac932324157341b9cf266b8f","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def convert_to_lowercase(string):"},{"line_number":25,"context_line":"    return string.lower()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ListFirewallRule(neutronv20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_83c6ec47","line":25,"in_reply_to":"7a740942_4854a320","updated":"2015-12-09 13:25:55.000000000","message":"Sorry \"https://review.openstack.org/#/c/238325\" review i meant.","commit_id":"1d29903c22d550e1ec7692f4fbb7cde11d537f3d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"fd249e7ecad61f83bc3cb42e03ea6d99647effc9","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def convert_to_lowercase(string):"},{"line_number":25,"context_line":"    return string.lower()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ListFirewallRule(neutronv20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_7d9283a1","line":25,"in_reply_to":"7a740942_5970020b","updated":"2015-12-09 12:42:03.000000000","message":"Hi Akihiro,\nReference: https://review.openstack.org/#/c/140628/10/neutronclient/common/utils.py\n\nI have one proposal :\n- Let Manjeet\u0027s patch get merged\n- Then neutron-net-update ( above mentioned patch in this comment) can be merged ( I will remove the convert_to_uppercase from that file)\n- Post that, the current patch ( Update firewall *) can be merged.\n\nWhat do you suggest?","commit_id":"1d29903c22d550e1ec7692f4fbb7cde11d537f3d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"3018222473585a4e9c8980f64a8fdb20aeeafec6","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def convert_to_lowercase(string):"},{"line_number":25,"context_line":"    return string.lower()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ListFirewallRule(neutronv20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_4854a320","line":25,"in_reply_to":"7a740942_7d9283a1","updated":"2015-12-09 13:15:56.000000000","message":"+1: for making it dependent on \"https://review.openstack.org/#/c/140628\"","commit_id":"1d29903c22d550e1ec7692f4fbb7cde11d537f3d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ebbbb9caad3ea0092c4b73741e7a50292db40071","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def convert_to_lowercase(string):"},{"line_number":25,"context_line":"    return string.lower()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ListFirewallRule(neutronv20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_d5ea6bac","line":25,"in_reply_to":"7a740942_83c6ec47","updated":"2015-12-10 03:16:54.000000000","message":"So its a chain reaction :D\n\n238325 -\u003e140628 -\u003e 238392\n\nWhy do I think I am getting a weird share of the patches :)","commit_id":"1d29903c22d550e1ec7692f4fbb7cde11d537f3d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4628602ce47c31de856263fb04b1f3ed098a1749","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def convert_to_lowercase(string):"},{"line_number":25,"context_line":"    return string.lower()"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ListFirewallRule(neutronv20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_43245dae","line":25,"in_reply_to":"7a740942_d5ea6bac","updated":"2015-12-10 03:31:04.000000000","message":"Yes it will be ;)","commit_id":"1d29903c22d550e1ec7692f4fbb7cde11d537f3d"}],"neutronclient/tests/functional/adv-svcs/test_firewall.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bb7ceb53eead887e3eefa472c9d2ced65aa68aea","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def test_create_firewall_rule_net_name_first(self):"},{"line_number":24,"context_line":"        self.neutron(\u0027firewall-rule-create \u0027,"},{"line_number":25,"context_line":"                     params\u003d\u0027--name testrule --protocol Tcp \u0027"},{"line_number":26,"context_line":"                     \u0027--action Allow\u0027)"},{"line_number":27,"context_line":"        self.addCleanup(self.neutron, \u0027firewall-rule-delete testrule\u0027)"},{"line_number":28,"context_line":"        firewall_rule_list \u003d self.parser.listing(self.neutron("}],"source_content_type":"text/x-python","patch_set":15,"id":"7a740942_f2db8eeb","line":25,"updated":"2015-12-11 06:33:23.000000000","message":"I prefer to \u0027--protocol tcp\u0027.\n\nwe don\u0027t need to use a capitablized version in the functional test.","commit_id":"02aa1a2b71e0b392f2fd788b9ab6aa106de538b6"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"f8decfae5893340a41025935b5f3c10dfb428b02","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def test_create_firewall_rule_net_name_first(self):"},{"line_number":24,"context_line":"        self.neutron(\u0027firewall-rule-create \u0027,"},{"line_number":25,"context_line":"                     params\u003d\u0027--name testrule --protocol Tcp \u0027"},{"line_number":26,"context_line":"                     \u0027--action Allow\u0027)"},{"line_number":27,"context_line":"        self.addCleanup(self.neutron, \u0027firewall-rule-delete testrule\u0027)"},{"line_number":28,"context_line":"        firewall_rule_list \u003d self.parser.listing(self.neutron("}],"source_content_type":"text/x-python","patch_set":15,"id":"7a740942_92bfaa5f","line":25,"in_reply_to":"7a740942_f2db8eeb","updated":"2015-12-11 06:36:01.000000000","message":"ok.. but this is not a necessary condition, right?\nI mean would this have any impact? I just wanted to demonstrate that such a functionality is available....","commit_id":"02aa1a2b71e0b392f2fd788b9ab6aa106de538b6"}],"neutronclient/tests/unit/fw/test_cli20_firewallrule.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d2728cd86f0f07b76896443609bb5236ebf14716","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                                   {\u0027protocol\u0027: \u0027tcp\u0027, })"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def test_update_firewall_rule_protocol_ANY_captialized(self):"},{"line_number":192,"context_line":"        \"\"\"firewall-rule-update myid --protocol TCP.\"\"\""},{"line_number":193,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":194,"context_line":"        cmd \u003d firewallrule.UpdateFirewallRule(test_cli20.MyApp(sys.stdout),"},{"line_number":195,"context_line":"                                              None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_66b3fa0a","line":192,"updated":"2015-10-22 08:20:14.000000000","message":"Should be ANY (self review)","commit_id":"c99646084ea3d7002a38b2c18297b412a1785d45"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d2728cd86f0f07b76896443609bb5236ebf14716","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                                   {\u0027protocol\u0027: None, })"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def _test_create_firewall_rule_with_protocol_Capitalized(self):"},{"line_number":201,"context_line":"        \"\"\"firewall-rule-create with mandatory (none) params only.\"\"\""},{"line_number":202,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":203,"context_line":"        cmd \u003d firewallrule.CreateFirewallRule(test_cli20.MyApp(sys.stdout),"},{"line_number":204,"context_line":"                                              None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_86b656f7","line":201,"updated":"2015-10-22 08:20:14.000000000","message":"should be changed(self review)","commit_id":"c99646084ea3d7002a38b2c18297b412a1785d45"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cf899ebff19f6d7a321b906855eb8dda8cd3e5ce","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        args \u003d [my_id]"},{"line_number":180,"context_line":"        self._test_delete_resource(resource, cmd, my_id, args)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def test_update_firewall_rule_protocol_captialized(self):"},{"line_number":183,"context_line":"        \"\"\"firewall-rule-update myid --protocol TCP.\"\"\""},{"line_number":184,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":185,"context_line":"        cmd \u003d firewallrule.UpdateFirewallRule(test_cli20.MyApp(sys.stdout),"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_48e8e67c","line":182,"updated":"2015-11-04 15:44:25.000000000","message":"\u0027Capitalization\u0027 means \u0027Tcp\u0027 instead of \u0027TCP\u0027.","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cf899ebff19f6d7a321b906855eb8dda8cd3e5ce","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                   [\u0027myid\u0027, \u0027--protocol\u0027, \u0027TCP\u0027],"},{"line_number":189,"context_line":"                                   {\u0027protocol\u0027: \u0027tcp\u0027, })"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def test_update_firewall_rule_protocol_ANY_captialized(self):"},{"line_number":192,"context_line":"        \"\"\"firewall-rule-update myid --protocol TCP.\"\"\""},{"line_number":193,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":194,"context_line":"        cmd \u003d firewallrule.UpdateFirewallRule(test_cli20.MyApp(sys.stdout),"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_88c7ae11","line":191,"updated":"2015-11-04 15:44:25.000000000","message":"The method name is incorrect. I don\u0027t want to see upper case directly.\nHow about \u0027any_uppercase\u0027?","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b51c30650374fcfb7ac3d1bc28e07ef42e1d2bd6","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                                   [\u0027myid\u0027, \u0027--protocol\u0027, \u0027TCP\u0027],"},{"line_number":189,"context_line":"                                   {\u0027protocol\u0027: \u0027tcp\u0027, })"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def test_update_firewall_rule_protocol_ANY_captialized(self):"},{"line_number":192,"context_line":"        \"\"\"firewall-rule-update myid --protocol TCP.\"\"\""},{"line_number":193,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":194,"context_line":"        cmd \u003d firewallrule.UpdateFirewallRule(test_cli20.MyApp(sys.stdout),"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_bfa86021","line":191,"in_reply_to":"fa80f949_88c7ae11","updated":"2015-11-10 05:42:31.000000000","message":"As per vikramś earlier comment, ANY is not required.\nRemoving it and thus this test case.","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cf899ebff19f6d7a321b906855eb8dda8cd3e5ce","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                                   {\u0027protocol\u0027: \u0027tcp\u0027, })"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def test_update_firewall_rule_protocol_ANY_captialized(self):"},{"line_number":192,"context_line":"        \"\"\"firewall-rule-update myid --protocol TCP.\"\"\""},{"line_number":193,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":194,"context_line":"        cmd \u003d firewallrule.UpdateFirewallRule(test_cli20.MyApp(sys.stdout),"},{"line_number":195,"context_line":"                                              None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_e8f99a4e","line":192,"updated":"2015-11-04 15:44:25.000000000","message":"no TCP but ANY","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cf899ebff19f6d7a321b906855eb8dda8cd3e5ce","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                                   [\u0027myid\u0027, \u0027--protocol\u0027, \u0027ANY\u0027],"},{"line_number":198,"context_line":"                                   {\u0027protocol\u0027: None, })"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def _test_create_firewall_rule_with_protocol_Capitalized(self):"},{"line_number":201,"context_line":"        \"\"\"Combining 2 test cases for firewall-rule-create with"},{"line_number":202,"context_line":"           protocol \u003d TCP and protocol \u003d None"},{"line_number":203,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_c89376f9","line":200,"updated":"2015-11-04 15:44:25.000000000","message":"Each test method name should not start with underscore. For more detail, read unittest module description.\n\nCapitalized -\u003e uppercase\n\nIn addition, why do you have separate tests for update and one test for create. It looks inconsistent.","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cf899ebff19f6d7a321b906855eb8dda8cd3e5ce","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def _test_create_firewall_rule_with_protocol_Capitalized(self):"},{"line_number":201,"context_line":"        \"\"\"Combining 2 test cases for firewall-rule-create with"},{"line_number":202,"context_line":"           protocol \u003d TCP and protocol \u003d None"},{"line_number":203,"context_line":"        \"\"\""},{"line_number":204,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":205,"context_line":"        cmd \u003d firewallrule.CreateFirewallRule(test_cli20.MyApp(sys.stdout),"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_68bb6a73","line":202,"updated":"2015-11-04 15:44:25.000000000","message":"I don\u0027t see any \u0027None\u0027 in the command line.","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b51c30650374fcfb7ac3d1bc28e07ef42e1d2bd6","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def _test_create_firewall_rule_with_protocol_Capitalized(self):"},{"line_number":201,"context_line":"        \"\"\"Combining 2 test cases for firewall-rule-create with"},{"line_number":202,"context_line":"           protocol \u003d TCP and protocol \u003d None"},{"line_number":203,"context_line":"        \"\"\""},{"line_number":204,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":205,"context_line":"        cmd \u003d firewallrule.CreateFirewallRule(test_cli20.MyApp(sys.stdout),"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_bf7f00aa","line":202,"in_reply_to":"fa80f949_68bb6a73","updated":"2015-11-10 05:42:31.000000000","message":"The whole test case has been changed, wrt the comments given by you below.","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cf899ebff19f6d7a321b906855eb8dda8cd3e5ce","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                                   protocol\u003dprotocol, action\u003daction,"},{"line_number":234,"context_line":"                                   enabled\u003denabled, tenant_id\u003dtenant_id)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def _test_create_firewall_rule_with_action_Capitalized(self):"},{"line_number":237,"context_line":"        \"\"\"firewall-rule-create with action \u003d DENY .\"\"\""},{"line_number":238,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":239,"context_line":"        cmd \u003d firewallrule.CreateFirewallRule(test_cli20.MyApp(sys.stdout),"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_a8363201","line":236,"updated":"2015-11-04 15:44:25.000000000","message":"All tests are too similar and the only difference is a value of protocol.\nConsider preparing a common method and consume it in all tests.\nI hate this kind of copy-and-paste approach.","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b51c30650374fcfb7ac3d1bc28e07ef42e1d2bd6","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                                   protocol\u003dprotocol, action\u003daction,"},{"line_number":234,"context_line":"                                   enabled\u003denabled, tenant_id\u003dtenant_id)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def _test_create_firewall_rule_with_action_Capitalized(self):"},{"line_number":237,"context_line":"        \"\"\"firewall-rule-create with action \u003d DENY .\"\"\""},{"line_number":238,"context_line":"        resource \u003d \u0027firewall_rule\u0027"},{"line_number":239,"context_line":"        cmd \u003d firewallrule.CreateFirewallRule(test_cli20.MyApp(sys.stdout),"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa80f949_9f1f9c6b","line":236,"in_reply_to":"fa80f949_a8363201","updated":"2015-11-10 05:42:31.000000000","message":"Umm.. Ok, will do so :)","commit_id":"791724dcf8ed8583bb2c9948b6e1e883d3593e55"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0bb5c931fa496858f246397f6646a0d5f1d45220","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        tenant_id \u003d \u0027my-tenant\u0027"},{"line_number":33,"context_line":"        name \u003d \u0027\u0027"},{"line_number":34,"context_line":"        my_id \u003d \u0027myid\u0027"},{"line_number":35,"context_line":"        protocol \u003d protocol.lower()"},{"line_number":36,"context_line":"        action \u003d action.lower()"},{"line_number":37,"context_line":"        args \u003d [\u0027--tenant-id\u0027, tenant_id,"},{"line_number":38,"context_line":"                \u0027--admin-state-up\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba8a016a_97cc9162","line":35,"updated":"2015-11-23 15:21:22.000000000","message":"Why not leave the args uppercase?  Otherwise, what is the purpose of test_create_firewall_rule_with_protocol_or_action_uppercase() with respect to this patch set since this test is converting to lowercase before the create call.","commit_id":"8fdc9e2943b10726d3e93c7c7b723cf42b7f5b1b"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c709cf34e025253445df76a9b6d6d5beb8f3c895","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def test_create_firewall_rule_with_proto_action_upper_capitalized(self):"},{"line_number":108,"context_line":"        for protocol in (\u0027TCP\u0027, \u0027Tcp\u0027, \u0027ANY\u0027, \u0027AnY\u0027):"},{"line_number":109,"context_line":"            self._setup_create_firewall_rule_with_all_params("},{"line_number":110,"context_line":"                protocol\u003dprotocol.lower(),"},{"line_number":111,"context_line":"                protocol_cli\u003dprotocol)"},{"line_number":112,"context_line":"        for action in (\u0027Allow\u0027, \u0027DENY\u0027, \u0027reject\u0027):"},{"line_number":113,"context_line":"            self._setup_create_firewall_rule_with_all_params("}],"source_content_type":"text/x-python","patch_set":17,"id":"5a710552_b15f7340","line":110,"updated":"2015-12-15 19:13:05.000000000","message":"@vikram he is converting the value in test itself. for a test it should be converted by some function some validator. I don\u0027t see any point of adding such test ? assigning any lowercase value to lb algo and before creating pool just pass convert it  to upper case. makes no sense.","commit_id":"44df67482cfe2c1a702918089b380a3388ff0901"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"42bc7792ec70f757e497d60fd98f049be2dabcbf","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            self._test_create_resource(resource, cmd, name, my_id, args,"},{"line_number":95,"context_line":"                                       position_names, position_values,"},{"line_number":96,"context_line":"                                       description\u003ddescription, shared\u003dTrue,"},{"line_number":97,"context_line":"                                       protocol\u003dprotocol,"},{"line_number":98,"context_line":"                                       ip_version\u003dint(ip_version),"},{"line_number":99,"context_line":"                                       source_ip_address\u003dsource_ip,"},{"line_number":100,"context_line":"                                       destination_ip_address\u003ddestination_ip,"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_3ba9217c","line":97,"updated":"2016-02-04 08:50:59.000000000","message":"whoops, ignore my comments, didn\u0027t notice this use of protocol here","commit_id":"d35643974c28f900b4f976f728b9bd43f95eeba7"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e47501d0f281660b2139b0ab3c085fd591144f95","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def test_create_firewall_rule_with_proto_action_upper_capitalized(self):"},{"line_number":130,"context_line":"        for protocol in (\u0027TCP\u0027, \u0027Tcp\u0027, \u0027ANY\u0027, \u0027AnY\u0027):"},{"line_number":131,"context_line":"            self._setup_create_firewall_rule_with_all_params("},{"line_number":132,"context_line":"                protocol\u003dprotocol.lower(),"},{"line_number":133,"context_line":"                protocol_cli\u003dprotocol)"},{"line_number":134,"context_line":"        for action in (\u0027Allow\u0027, \u0027DENY\u0027, \u0027reject\u0027):"},{"line_number":135,"context_line":"            self._setup_create_firewall_rule_with_all_params("}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_3b684187","line":132,"updated":"2016-02-04 08:44:38.000000000","message":"actually this is a bit misleading because if I understand the function logic we are calling, protocol will not be used at all since protocol_cli is specified. Can you just skip the protocol kwarg completely? Same for action below","commit_id":"d35643974c28f900b4f976f728b9bd43f95eeba7"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"76300168d238b4e120d45da129267f9402c2c9ab","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def test_create_firewall_rule_with_proto_action_upper_capitalized(self):"},{"line_number":130,"context_line":"        for protocol in (\u0027TCP\u0027, \u0027Tcp\u0027, \u0027ANY\u0027, \u0027AnY\u0027):"},{"line_number":131,"context_line":"            self._setup_create_firewall_rule_with_all_params("},{"line_number":132,"context_line":"                protocol\u003dprotocol.lower(),"},{"line_number":133,"context_line":"                protocol_cli\u003dprotocol)"},{"line_number":134,"context_line":"        for action in (\u0027Allow\u0027, \u0027DENY\u0027, \u0027reject\u0027):"},{"line_number":135,"context_line":"            self._setup_create_firewall_rule_with_all_params("}],"source_content_type":"text/x-python","patch_set":27,"id":"5a5ae5dd_7bab19d7","line":132,"updated":"2016-02-04 08:41:14.000000000","message":"we\u0027re converting all of them to lowercase right here in the test, what is this really testing?","commit_id":"d35643974c28f900b4f976f728b9bd43f95eeba7"}]}
