)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"bac3caeca6ddb571078b71e9bd1733f84de4c62c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create floating IP on a specific subnet ID"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implemented optional parameter (with dashed arguments only)"},{"line_number":10,"context_line":"for python-neutronclient to create floating IP on a subnet"},{"line_number":11,"context_line":"ID. Created corresponding unit test cases."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa80f949_8d3c39c9","line":9,"updated":"2015-11-06 16:27:38.000000000","message":"supernit: In info paragraph you can have each line no more than 72 characters try to use that . you used only 59 here.","commit_id":"a77d3148b3ed087830ca78b94cf25271fca2de35"},{"author":{"_account_id":18334,"name":"Nandini Tata","email":"nandini.tata@intel.com","username":"ntata"},"change_message_id":"585c33646226682582ab6a895cfd7b87ba8be189","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create floating IP on a specific subnet ID"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implemented optional parameter (with dashed arguments only)"},{"line_number":10,"context_line":"for python-neutronclient to create floating IP on a subnet"},{"line_number":11,"context_line":"ID. Created corresponding unit test cases."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa80f949_adf7bd89","line":9,"in_reply_to":"fa80f949_8d3c39c9","updated":"2015-11-06 16:35:02.000000000","message":"Done","commit_id":"a77d3148b3ed087830ca78b94cf25271fca2de35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c4dc8e9b935916b372206faed5b2cc86ee51a5fd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Create floating IP on a specific subnet ID"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implemented optional parameter (with dashed arguments only)"},{"line_number":10,"context_line":"for python-neutronclient to create floating IP on a subnet"},{"line_number":11,"context_line":"ID. Created corresponding unit test cases."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da85f559_be953241","line":9,"in_reply_to":"fa80f949_adf7bd89","updated":"2015-11-08 22:45:51.000000000","message":"I don\u0027t think we need more spin of reviews only to address this comment.","commit_id":"a77d3148b3ed087830ca78b94cf25271fca2de35"}],"neutronclient/neutron/v2_0/floatingip.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"becdee13868128331aa2e89142c6e4e5f0db5ecc","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027--subnet-id\u0027,"},{"line_number":69,"context_line":"            help\u003d_(\u0027subnet ID on which you want to create the floating IP.\u0027))"},{"line_number":70,"context_line":"        parser.add_argument("},{"line_number":71,"context_line":"            \u0027--subnet_id\u0027,"},{"line_number":72,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_b36f222a","line":71,"updated":"2015-11-03 02:08:45.000000000","message":"I would prefer you not to add the _ option.\n\nBackground: CLI Arguments having _ option were used till Juno ( I guess) , and were deprecated hence forth.\nMost Openstack CLIs now use \u0027-\u0027 ( hyphenated) arguments.\nHowever, for backward compatibility , the  _ (underscored) arguments were kept.\nThey may be discontinued in the future.\nSo I would suggest you not to introduce any NEW parser argument with _ option. - ( hyphen) would be fine.","commit_id":"a75aaddd873f61ac7d7dc59a74863d9f46f6faac"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eb281378f3907974a22d85a0fb5ee4ff97784396","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027--floating-ip-address\u0027,"},{"line_number":66,"context_line":"            help\u003d_(\u0027IP address of the floating IP\u0027))"},{"line_number":67,"context_line":"        parser.add_argument("},{"line_number":68,"context_line":"            \u0027--subnet-id\u0027,"},{"line_number":69,"context_line":"            help\u003d_(\u0027subnet ID on which you want to create the floating IP.\u0027))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_e483feca","line":68,"updated":"2015-11-04 18:18:31.000000000","message":"Could you change the option name from \u0027--subnet-id\u0027 to \u0027--subnet\u0027\nand add \"dest\u003d\u0027subnet_id\u0027\"?\n\nIn most neutron subcommands, we usually look up ID from name, so in many cases we use \u0027--xxx\u0027 rather than \u0027--xxx-id\u0027 for an option name.\n\nIn this case, regular users can only know subnet ID from the output of net-list, but I believe it is better to use --subnet as an option name.","commit_id":"c8a8149a0c237de5e6462ab87f699ebde29dcb26"},{"author":{"_account_id":18334,"name":"Nandini Tata","email":"nandini.tata@intel.com","username":"ntata"},"change_message_id":"32aa2725fcb81a84f83e11edaee8ad2db0628feb","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027--floating-ip-address\u0027,"},{"line_number":66,"context_line":"            help\u003d_(\u0027IP address of the floating IP\u0027))"},{"line_number":67,"context_line":"        parser.add_argument("},{"line_number":68,"context_line":"            \u0027--subnet-id\u0027,"},{"line_number":69,"context_line":"            help\u003d_(\u0027subnet ID on which you want to create the floating IP.\u0027))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_455f2fe5","line":68,"in_reply_to":"fa80f949_4ccf857f","updated":"2015-11-05 21:26:38.000000000","message":"Learnt something new today. Thank you :)","commit_id":"c8a8149a0c237de5e6462ab87f699ebde29dcb26"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ba792995f6a3ec3ec515ce4245c120897cd6ec7d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027--floating-ip-address\u0027,"},{"line_number":66,"context_line":"            help\u003d_(\u0027IP address of the floating IP\u0027))"},{"line_number":67,"context_line":"        parser.add_argument("},{"line_number":68,"context_line":"            \u0027--subnet-id\u0027,"},{"line_number":69,"context_line":"            help\u003d_(\u0027subnet ID on which you want to create the floating IP.\u0027))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_e0ca036e","line":68,"in_reply_to":"fa80f949_ca92809f","updated":"2015-11-04 21:30:05.000000000","message":"dest\u003d\u0027subnet_id\u0027 means the option value is stored into parsed_args.subnet_id. If dest is not specified, the attribute name is determined from the option name and in this case it will be parsed_args.subnet.\n\nIf we use parsed_args.subnet, you need to deal with \u0027subnet\u0027 specially in args2body. By specifying dest\u003d\u0027subnet_id\u0027 here, you can still use update_dict in args2body.\n\nFor more detail behavior of \u0027dest\u0027, please see the documentation of python argparse module.","commit_id":"c8a8149a0c237de5e6462ab87f699ebde29dcb26"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"57e05c7de17266e8096725f7fa25b8bb4e5fa465","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027--floating-ip-address\u0027,"},{"line_number":66,"context_line":"            help\u003d_(\u0027IP address of the floating IP\u0027))"},{"line_number":67,"context_line":"        parser.add_argument("},{"line_number":68,"context_line":"            \u0027--subnet-id\u0027,"},{"line_number":69,"context_line":"            help\u003d_(\u0027subnet ID on which you want to create the floating IP.\u0027))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_4ccf857f","line":68,"in_reply_to":"fa80f949_e0ca036e","updated":"2015-11-05 01:42:21.000000000","message":"Just For Reference:\nYou can find it in the Action class definition in \n/opt/stack/python-neutronclient/.tox/py27/lib/python2.7/site-packages/argparse.py +739\n\nHope it helps :)","commit_id":"c8a8149a0c237de5e6462ab87f699ebde29dcb26"},{"author":{"_account_id":18334,"name":"Nandini Tata","email":"nandini.tata@intel.com","username":"ntata"},"change_message_id":"5b44370205a5b41d91d7317fbbcf5377d483398f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \u0027--floating-ip-address\u0027,"},{"line_number":66,"context_line":"            help\u003d_(\u0027IP address of the floating IP\u0027))"},{"line_number":67,"context_line":"        parser.add_argument("},{"line_number":68,"context_line":"            \u0027--subnet-id\u0027,"},{"line_number":69,"context_line":"            help\u003d_(\u0027subnet ID on which you want to create the floating IP.\u0027))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_ca92809f","line":68,"in_reply_to":"fa80f949_e483feca","updated":"2015-11-04 20:23:44.000000000","message":"Sure, I understood the part of referring to --subnet-id as --subnet. But I didn\u0027t understand the dest\u003d\u0027subnet_id\u0027. Could you please elaborate on that?","commit_id":"c8a8149a0c237de5e6462ab87f699ebde29dcb26"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eb281378f3907974a22d85a0fb5ee4ff97784396","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            help\u003d_(\u0027IP address of the floating IP\u0027))"},{"line_number":67,"context_line":"        parser.add_argument("},{"line_number":68,"context_line":"            \u0027--subnet-id\u0027,"},{"line_number":69,"context_line":"            help\u003d_(\u0027subnet ID on which you want to create the floating IP.\u0027))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def args2body(self, parsed_args):"},{"line_number":72,"context_line":"        _network_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_2464a620","line":69,"updated":"2015-11-04 18:18:31.000000000","message":"Needs to capitalize the first word: Subnet ID....","commit_id":"c8a8149a0c237de5e6462ab87f699ebde29dcb26"},{"author":{"_account_id":18334,"name":"Nandini Tata","email":"nandini.tata@intel.com","username":"ntata"},"change_message_id":"5b44370205a5b41d91d7317fbbcf5377d483398f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            help\u003d_(\u0027IP address of the floating IP\u0027))"},{"line_number":67,"context_line":"        parser.add_argument("},{"line_number":68,"context_line":"            \u0027--subnet-id\u0027,"},{"line_number":69,"context_line":"            help\u003d_(\u0027subnet ID on which you want to create the floating IP.\u0027))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def args2body(self, parsed_args):"},{"line_number":72,"context_line":"        _network_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_2aea2c10","line":69,"in_reply_to":"fa80f949_2464a620","updated":"2015-11-04 20:23:44.000000000","message":"Done","commit_id":"c8a8149a0c237de5e6462ab87f699ebde29dcb26"}],"neutronclient/tests/unit/test_cli20_floatingips.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"becdee13868128331aa2e89142c6e4e5f0db5ecc","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        myid \u003d \u0027myid\u0027"},{"line_number":94,"context_line":"        subnet_id \u003d \u0027mysubnetid\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        args \u003d [name, \u0027--subnet_id\u0027, subnet_id]"},{"line_number":97,"context_line":"        position_values \u003d [name, subnet_id]"},{"line_number":98,"context_line":"        position_names \u003d [\u0027floating_network_id\u0027, \u0027subnet_id\u0027]"},{"line_number":99,"context_line":"        self._test_create_resource(resource, cmd, name, myid, args,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_5367ae4c","line":96,"updated":"2015-11-03 02:08:45.000000000","message":"Based on the previous comment , please also change the test cases... thanks","commit_id":"a75aaddd873f61ac7d7dc59a74863d9f46f6faac"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eb281378f3907974a22d85a0fb5ee4ff97784396","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        pid \u003d \u0027mypid\u0027"},{"line_number":109,"context_line":"        subnet_id \u003d \u0027mysubnetid\u0027"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        args \u003d [name, \u0027--subnet-id\u0027, subnet_id, \u0027--port_id\u0027, pid]"},{"line_number":112,"context_line":"        position_values \u003d [name, subnet_id, pid]"},{"line_number":113,"context_line":"        position_names \u003d [\u0027floating_network_id\u0027, \u0027subnet_id\u0027, \u0027port_id\u0027]"},{"line_number":114,"context_line":"        self._test_create_resource(resource, cmd, name, myid, args,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_44676a25","line":111,"updated":"2015-11-04 18:18:31.000000000","message":"--port-id is suggested.","commit_id":"c8a8149a0c237de5e6462ab87f699ebde29dcb26"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"57e05c7de17266e8096725f7fa25b8bb4e5fa465","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        pid \u003d \u0027mypid\u0027"},{"line_number":109,"context_line":"        subnet_id \u003d \u0027mysubnetid\u0027"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        args \u003d [name, \u0027--subnet-id\u0027, subnet_id, \u0027--port_id\u0027, pid]"},{"line_number":112,"context_line":"        position_values \u003d [name, subnet_id, pid]"},{"line_number":113,"context_line":"        position_names \u003d [\u0027floating_network_id\u0027, \u0027subnet_id\u0027, \u0027port_id\u0027]"},{"line_number":114,"context_line":"        self._test_create_resource(resource, cmd, name, myid, args,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_4c730581","line":111,"in_reply_to":"fa80f949_44676a25","updated":"2015-11-05 01:42:21.000000000","message":"+1","commit_id":"c8a8149a0c237de5e6462ab87f699ebde29dcb26"},{"author":{"_account_id":18334,"name":"Nandini Tata","email":"nandini.tata@intel.com","username":"ntata"},"change_message_id":"5b44370205a5b41d91d7317fbbcf5377d483398f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        pid \u003d \u0027mypid\u0027"},{"line_number":109,"context_line":"        subnet_id \u003d \u0027mysubnetid\u0027"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        args \u003d [name, \u0027--subnet-id\u0027, subnet_id, \u0027--port_id\u0027, pid]"},{"line_number":112,"context_line":"        position_values \u003d [name, subnet_id, pid]"},{"line_number":113,"context_line":"        position_names \u003d [\u0027floating_network_id\u0027, \u0027subnet_id\u0027, \u0027port_id\u0027]"},{"line_number":114,"context_line":"        self._test_create_resource(resource, cmd, name, myid, args,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_8ae31833","line":111,"in_reply_to":"fa80f949_44676a25","updated":"2015-11-04 20:23:44.000000000","message":"Done","commit_id":"c8a8149a0c237de5e6462ab87f699ebde29dcb26"}]}