)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"23606a205bd15e43c66382df049cf28b484be990","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use os-client-config to construct the Client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"os-client-config knows how to properly turn a CloudConfig into a"},{"line_number":10,"context_line":"working client object with all of the arguments passed properly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: I1934cb086f905850941c06e0e79189f7642652d6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_d438d73f","line":9,"updated":"2015-11-10 06:51:00.000000000","message":"CloudConfig object?","commit_id":"030d2173f59f1b3d6e8910dea1ae7bc290fd3ae0"}],"neutronclient/common/clientmanager.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"23606a205bd15e43c66382df049cf28b484be990","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ClientCache(object):"},{"line_number":30,"context_line":"    \"\"\"Descriptor class for caching created client handles.\"\"\""},{"line_number":31,"context_line":"    # DEPRECATED - this is only here for backwards compat and is not actuall"},{"line_number":32,"context_line":"    # used by any internal library code-paths"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, factory):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_f4babbe0","line":31,"updated":"2015-11-10 06:51:00.000000000","message":"Can you mention the complete words here, if possible in the next patch?","commit_id":"030d2173f59f1b3d6e8910dea1ae7bc290fd3ae0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"23606a205bd15e43c66382df049cf28b484be990","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class ClientManager(object):"},{"line_number":46,"context_line":"    \"\"\"Manages access to API clients, including authentication.\"\"\""},{"line_number":47,"context_line":"    # DEPRECATED - this is only here for backwards compat and is not actuall"},{"line_number":48,"context_line":"    # used by any internal library code-paths"},{"line_number":49,"context_line":"    neutron \u003d ClientCache(neutron_client.make_client)"},{"line_number":50,"context_line":"    # Provide support for old quantum commands (for example"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_14165fa7","line":47,"updated":"2015-11-10 06:51:00.000000000","message":"Ditto","commit_id":"030d2173f59f1b3d6e8910dea1ae7bc290fd3ae0"}],"neutronclient/neutron/client.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"23606a205bd15e43c66382df049cf28b484be990","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def make_client(instance):"},{"line_number":29,"context_line":"    \"\"\"Returns an neutron client.\"\"\""},{"line_number":30,"context_line":"    # DEPRECATED - this is only here for backwards compat and is not actually"},{"line_number":31,"context_line":"    # used by any internal library code-paths"},{"line_number":32,"context_line":"    neutron_client \u003d utils.get_client_class("},{"line_number":33,"context_line":"        API_NAME,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_541ce7c0","line":30,"updated":"2015-11-10 06:51:00.000000000","message":"Same as earlier comment","commit_id":"030d2173f59f1b3d6e8910dea1ae7bc290fd3ae0"}],"neutronclient/tests/unit/test_shell.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"23606a205bd15e43c66382df049cf28b484be990","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _run_argv(argv):"},{"line_number":41,"context_line":"    shell \u003d openstack_shell.NeutronShell(\u00272.0\u0027)"},{"line_number":42,"context_line":"    parser \u003d shell.build_option_parser(\u0027descr\u0027, \u00272.0\u0027)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    shell.run(argv)"},{"line_number":45,"context_line":"    return shell"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_74cfab7f","line":42,"updated":"2015-11-10 06:51:00.000000000","message":"Parser is not used anywhere.Kindly remove the same","commit_id":"030d2173f59f1b3d6e8910dea1ae7bc290fd3ae0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"23606a205bd15e43c66382df049cf28b484be990","unresolved":false,"context_lines":[{"line_number":40,"context_line":"def _run_argv(argv):"},{"line_number":41,"context_line":"    shell \u003d openstack_shell.NeutronShell(\u00272.0\u0027)"},{"line_number":42,"context_line":"    parser \u003d shell.build_option_parser(\u0027descr\u0027, \u00272.0\u0027)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    shell.run(argv)"},{"line_number":45,"context_line":"    return shell"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_54c4e75d","line":43,"updated":"2015-11-10 06:51:00.000000000","message":"Is the new line required?","commit_id":"030d2173f59f1b3d6e8910dea1ae7bc290fd3ae0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e982e74b25bb93b35608e1c6a07441407b512d74","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            matchers.MatchesRegex(required))"},{"line_number":103,"context_line":"        self.assertFalse(stderr)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_bash_completion(self):"},{"line_number":106,"context_line":"        required \u003d \u0027.*os-user-domain-id.*\u0027"},{"line_number":107,"context_line":"        bash_completion, stderr \u003d self.shell(\u0027bash-completion\u0027)"},{"line_number":108,"context_line":"        self.assertThat("}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_8f6476e5","line":105,"updated":"2015-11-10 06:53:14.000000000","message":"This is failing :\n\n\n2015-11-05 15:14:20.149 | Traceback (most recent call last):\n\n2015-11-05 15:14:20.149 |   File \"neutronclient/tests/unit/test_shell.py\", line 107, in test_bash_completion\n\n2015-11-05 15:14:20.149 |     bash_completion, stderr \u003d self.shell(\u0027bash-completion\u0027)\n\n2015-11-05 15:14:20.149 |   File \"neutronclient/tests/unit/test_shell.py\", line 77, in shell\n\n2015-11-05 15:14:20.150 |     _shell \u003d openstack_shell.NeutronShell(\u00272.0\u0027)\n\n2015-11-05 15:14:20.150 |   File \"neutronclient/shell.py\", line 417, in __init__\n\n2015-11-05 15:14:20.150 |     command_manager\u003dcommandmanager.CommandManager(\u0027neutron.cli\u0027), )\n\n2015-11-05 15:14:20.150 |   File \"/home/jenkins/workspace/gate-python-neutronclient-python27/.tox/py27/local/lib/python2.7/site-packages/cliff/app.py\", line 79, in __init__\n\n2015-11-05 15:14:20.150 |     self.parser \u003d self.build_option_parser(description, version)\n\n2015-11-05 15:14:20.150 |   File \"neutronclient/shell.py\", line 453, in build_option_parser\n\n2015-11-05 15:14:20.150 |     self._openstack_config.register_argparse_arguments(\n\n2015-11-05 15:14:20.150 | AttributeError: \u0027OpenStackConfig\u0027 object has no attribute \u0027register_argparse_arguments\u0027\n\n2015-11-05 15:14:20.150 | Ran 1105 tests in 1.069s","commit_id":"030d2173f59f1b3d6e8910dea1ae7bc290fd3ae0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"23606a205bd15e43c66382df049cf28b484be990","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        # $OS_ENDPOINT_TYPE but not --endpoint-type"},{"line_number":192,"context_line":"        shell \u003d _run_argv([])"},{"line_number":193,"context_line":"        self.assertEqual("},{"line_number":194,"context_line":"            \"public\","},{"line_number":195,"context_line":"            shell.client_manager._cloud_config.config[\u0027interface\u0027])"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        # --endpoint-type and $OS_ENDPOINT_TYPE"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_6f14b243","line":194,"updated":"2015-11-10 06:51:00.000000000","message":"Not sure why \"\" here and \u0027\u0027 in the previous change ( L#178) . Though it doesnt matter much","commit_id":"030d2173f59f1b3d6e8910dea1ae7bc290fd3ae0"}]}