)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1a24003da21d365da38878a0d19ab277a5c931fc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for default subnetpools API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds support for creating, viewing, and updating subnetpools with the new"},{"line_number":10,"context_line":"\u0027is_default\u0027 property."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I80ad2a1407266eff5c66c75974d3cc467701a75e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_aa09282e","line":9,"updated":"2015-11-10 07:42:17.000000000","message":"Please limit the git body to 72 characters per line ( this one is 74)","commit_id":"d8f685c62dd0bd42547e26c1000529d7cba8e4e0"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ac28f4835834ef56b196034afdcb9512e84e0cdd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for default subnetpools API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds support for creating, viewing, and updating subnetpools with the new"},{"line_number":10,"context_line":"\u0027is_default\u0027 property."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I80ad2a1407266eff5c66c75974d3cc467701a75e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_7371efdf","line":9,"in_reply_to":"da85f559_aa09282e","updated":"2015-11-10 14:04:25.000000000","message":"Done","commit_id":"d8f685c62dd0bd42547e26c1000529d7cba8e4e0"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"32adf736f12a617838377bf729c397db4810244e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add support for default subnetpools API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds support for creating, viewing, and updating subnetpools with the"},{"line_number":10,"context_line":"new \u0027is_default\u0027 property."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I80ad2a1407266eff5c66c75974d3cc467701a75e"},{"line_number":13,"context_line":"Closes-Bug: 1508012"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da6ed579_c698736d","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":15},"updated":"2016-01-12 05:21:55.000000000","message":"IMO, this change needs Doc updation. Plz add the DocImpact Flag.","commit_id":"989f99ce7b7a46d0894f8ca3c921e48d817c7953"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"d233db1a404fab39503836debdbf9f297a472d59","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add support for default subnetpools API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds support for creating, viewing, and updating subnetpools with the"},{"line_number":10,"context_line":"new \u0027is_default\u0027 property."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I80ad2a1407266eff5c66c75974d3cc467701a75e"},{"line_number":13,"context_line":"Closes-Bug: 1508012"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da6ed579_9d357cdb","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":15},"in_reply_to":"da6ed579_c698736d","updated":"2016-01-13 21:27:32.000000000","message":"Done","commit_id":"989f99ce7b7a46d0894f8ca3c921e48d817c7953"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"32adf736f12a617838377bf729c397db4810244e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adds support for creating, viewing, and updating subnetpools with the"},{"line_number":10,"context_line":"new \u0027is_default\u0027 property."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I80ad2a1407266eff5c66c75974d3cc467701a75e"},{"line_number":13,"context_line":"Closes-Bug: 1508012"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da6ed579_a6a0df91","line":12,"updated":"2016-01-12 05:21:55.000000000","message":"Add release notes as well.","commit_id":"989f99ce7b7a46d0894f8ca3c921e48d817c7953"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"d233db1a404fab39503836debdbf9f297a472d59","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adds support for creating, viewing, and updating subnetpools with the"},{"line_number":10,"context_line":"new \u0027is_default\u0027 property."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I80ad2a1407266eff5c66c75974d3cc467701a75e"},{"line_number":13,"context_line":"Closes-Bug: 1508012"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da6ed579_5965d31b","line":12,"in_reply_to":"da6ed579_a6a0df91","updated":"2016-01-13 21:27:32.000000000","message":"Done","commit_id":"989f99ce7b7a46d0894f8ca3c921e48d817c7953"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"be1b95356d8b341f185969be1a62ab31f1ef3943","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Includes release notes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I80ad2a1407266eff5c66c75974d3cc467701a75e"},{"line_number":17,"context_line":"Closes-Bug: 1508012"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da6ed579_42433d6c","line":14,"updated":"2016-01-15 10:09:20.000000000","message":"We got to write a note about the change for DoCImpact Flag. It can\u0027t be empty.","commit_id":"3eaffeb03ea8a49725b0e94b34d07d65dce4a99a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e7e97edc5097136443ccc14d78d0448e9cbafcd4","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Includes release notes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I80ad2a1407266eff5c66c75974d3cc467701a75e"},{"line_number":17,"context_line":"Closes-Bug: 1508012"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a68dd71_7b6cb09c","line":14,"in_reply_to":"ba63e191_2a131bba","updated":"2016-01-20 19:05:59.000000000","message":"DocImpact flag with description is started by this mailing thread.\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-November/080294.html\n(At least it is applied to DefCore projects. neutron is not a part of DefCore projects at now. When neutron becomes a DefCore project, this rule will be enforced.)\n\nThanks for the clarification which manuals is affected. The background of my question is that neutron team is responsible to triage DocImpact bug which will be filed to neutronclient.\n\nIn this case, CLI reference is the only one affected by this patch.\nCLI reference is automatically generated after a new release of neutronclient is released, so there is no more action required.\nWhen a docimpact bug is filed, neutronclient bug team forward the bug to openstack-manuals, openstack-manuals bug team add some tag which indicated \u0027automatic generation\u0027 and change the status to Released when a client is released. All of these steps need to be done manually. Thus I have a question that DocImpact is really useful in this case and we would like not to spend time to triage such bugs. It seems it is not a right place to discuss. I will start the discussion in the ML.","commit_id":"3eaffeb03ea8a49725b0e94b34d07d65dce4a99a"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"de536661c09094e8775f0740b5a95afec85872b6","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Includes release notes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I80ad2a1407266eff5c66c75974d3cc467701a75e"},{"line_number":17,"context_line":"Closes-Bug: 1508012"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba63e191_2a131bba","line":14,"in_reply_to":"da6ed579_335baf30","updated":"2016-01-19 18:08:17.000000000","message":"In this case, the CLI reference.","commit_id":"3eaffeb03ea8a49725b0e94b34d07d65dce4a99a"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ef7ea6a5a737e373e7fd8789d46d27db76437d9a","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Includes release notes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I80ad2a1407266eff5c66c75974d3cc467701a75e"},{"line_number":17,"context_line":"Closes-Bug: 1508012"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da6ed579_7216f756","line":14,"in_reply_to":"da6ed579_335baf30","updated":"2016-01-18 10:26:35.000000000","message":"http://docs.openstack.org/cli-reference/neutron.html\n\nMoreover, we need to write a line about the change after DocImpact tag","commit_id":"3eaffeb03ea8a49725b0e94b34d07d65dce4a99a"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"de536661c09094e8775f0740b5a95afec85872b6","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Includes release notes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I80ad2a1407266eff5c66c75974d3cc467701a75e"},{"line_number":17,"context_line":"Closes-Bug: 1508012"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba63e191_caf4bf88","line":14,"in_reply_to":"da6ed579_42433d6c","updated":"2016-01-19 18:08:17.000000000","message":"I\u0027ll add more detail to the commit message.","commit_id":"3eaffeb03ea8a49725b0e94b34d07d65dce4a99a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b284e8df29c44dc601ead47a9ee2970bad4d0e6","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Includes release notes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I80ad2a1407266eff5c66c75974d3cc467701a75e"},{"line_number":17,"context_line":"Closes-Bug: 1508012"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"da6ed579_335baf30","line":14,"in_reply_to":"da6ed579_42433d6c","updated":"2016-01-18 04:26:19.000000000","message":"Which document is actually affected: the networking guide? CLI reference?","commit_id":"3eaffeb03ea8a49725b0e94b34d07d65dce4a99a"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"de536661c09094e8775f0740b5a95afec85872b6","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Includes release notes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I80ad2a1407266eff5c66c75974d3cc467701a75e"},{"line_number":17,"context_line":"Closes-Bug: 1508012"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba63e191_8ad7a7ec","line":14,"in_reply_to":"da6ed579_7216f756","updated":"2016-01-19 18:08:17.000000000","message":"The entire commit message is captured in the bug when using the DocImpact flag, I don\u0027t think it\u0027s necessary to add anything after the flag. See https://wiki.openstack.org/wiki/Documentation/DocImpact","commit_id":"3eaffeb03ea8a49725b0e94b34d07d65dce4a99a"}],"neutronclient/neutron/v2_0/subnetpool.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"503f12052ffce6dd385020cacbd8ae7841503203","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        help\u003d_(\u0027Subnetpool default prefix length.\u0027))"},{"line_number":31,"context_line":"    parser.add_argument("},{"line_number":32,"context_line":"        \u0027--is-default\u0027, type\u003dstr,"},{"line_number":33,"context_line":"        help\u003d_(\u0027Set the subnetpool as the default.\u0027))"},{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--pool-prefix\u0027,"},{"line_number":36,"context_line":"        action\u003d\u0027append\u0027, dest\u003d\u0027prefixes\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_391721a5","line":33,"updated":"2015-11-08 15:00:17.000000000","message":"is_default takes a boolean value. How about using add_boolean_argument in neutronclient.common.utils? I think it is more clear.","commit_id":"d8f685c62dd0bd42547e26c1000529d7cba8e4e0"},{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"db589e435fffd70b0819899787aa3ec8fb9d4a10","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        help\u003d_(\u0027Subnetpool default prefix length.\u0027))"},{"line_number":31,"context_line":"    parser.add_argument("},{"line_number":32,"context_line":"        \u0027--is-default\u0027, type\u003dstr,"},{"line_number":33,"context_line":"        help\u003d_(\u0027Set the subnetpool as the default.\u0027))"},{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--pool-prefix\u0027,"},{"line_number":36,"context_line":"        action\u003d\u0027append\u0027, dest\u003d\u0027prefixes\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_6149628b","line":33,"in_reply_to":"da85f559_391721a5","updated":"2015-11-09 08:38:22.000000000","message":"+1","commit_id":"d8f685c62dd0bd42547e26c1000529d7cba8e4e0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1a24003da21d365da38878a0d19ab277a5c931fc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        help\u003d_(\u0027Subnetpool default prefix length.\u0027))"},{"line_number":31,"context_line":"    parser.add_argument("},{"line_number":32,"context_line":"        \u0027--is-default\u0027, type\u003dstr,"},{"line_number":33,"context_line":"        help\u003d_(\u0027Set the subnetpool as the default.\u0027))"},{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--pool-prefix\u0027,"},{"line_number":36,"context_line":"        action\u003d\u0027append\u0027, dest\u003d\u0027prefixes\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_4a5e7c13","line":33,"in_reply_to":"da85f559_391721a5","updated":"2015-11-10 07:42:17.000000000","message":"+1 for this.\nAlso, I would advice you to please update the new parameters at the end ( i,e in this case, below pool-prefix)\n\nWould help in visualization","commit_id":"d8f685c62dd0bd42547e26c1000529d7cba8e4e0"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ac28f4835834ef56b196034afdcb9512e84e0cdd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        help\u003d_(\u0027Subnetpool default prefix length.\u0027))"},{"line_number":31,"context_line":"    parser.add_argument("},{"line_number":32,"context_line":"        \u0027--is-default\u0027, type\u003dstr,"},{"line_number":33,"context_line":"        help\u003d_(\u0027Set the subnetpool as the default.\u0027))"},{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--pool-prefix\u0027,"},{"line_number":36,"context_line":"        action\u003d\u0027append\u0027, dest\u003d\u0027prefixes\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_b363d6db","line":33,"in_reply_to":"da85f559_391721a5","updated":"2015-11-10 14:04:25.000000000","message":"Done","commit_id":"d8f685c62dd0bd42547e26c1000529d7cba8e4e0"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ac28f4835834ef56b196034afdcb9512e84e0cdd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        help\u003d_(\u0027Subnetpool default prefix length.\u0027))"},{"line_number":31,"context_line":"    parser.add_argument("},{"line_number":32,"context_line":"        \u0027--is-default\u0027, type\u003dstr,"},{"line_number":33,"context_line":"        help\u003d_(\u0027Set the subnetpool as the default.\u0027))"},{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--pool-prefix\u0027,"},{"line_number":36,"context_line":"        action\u003d\u0027append\u0027, dest\u003d\u0027prefixes\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_136502e0","line":33,"in_reply_to":"da85f559_4a5e7c13","updated":"2015-11-10 14:04:25.000000000","message":"Done","commit_id":"d8f685c62dd0bd42547e26c1000529d7cba8e4e0"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1a24003da21d365da38878a0d19ab277a5c931fc","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        body \u003d {}"},{"line_number":127,"context_line":"        updatable_args2body(parsed_args, body, for_create\u003dFalse)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        if parsed_args.is_default:"},{"line_number":130,"context_line":"            body[\u0027is_default\u0027] \u003d parsed_args.is_default"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Parse and update for \"address-scope\" option/s"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_ca126c09","line":129,"updated":"2015-11-10 07:42:17.000000000","message":"The Line#43 already takes care of is_default.\nIn such a case you can either remove the is_default from Line#43, or remove it from this location","commit_id":"d8f685c62dd0bd42547e26c1000529d7cba8e4e0"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ac28f4835834ef56b196034afdcb9512e84e0cdd","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        body \u003d {}"},{"line_number":127,"context_line":"        updatable_args2body(parsed_args, body, for_create\u003dFalse)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        if parsed_args.is_default:"},{"line_number":130,"context_line":"            body[\u0027is_default\u0027] \u003d parsed_args.is_default"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        # Parse and update for \"address-scope\" option/s"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_337da66e","line":129,"in_reply_to":"da85f559_ca126c09","updated":"2015-11-10 14:04:25.000000000","message":"Done","commit_id":"d8f685c62dd0bd42547e26c1000529d7cba8e4e0"},{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"62882d58eb0752e21c400457e4f9304d16d5c582","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        action\u003d\u0027append\u0027, dest\u003d\u0027prefixes\u0027,"},{"line_number":35,"context_line":"        help\u003d_(\u0027Subnetpool prefixes (This option can be repeated).\u0027))"},{"line_number":36,"context_line":"    utils.add_boolean_argument("},{"line_number":37,"context_line":"        parser, \u0027--is-default\u0027, dest\u003d\u0027is_default\u0027,"},{"line_number":38,"context_line":"        help\u003d_(\u0027Set the subnetpool as the default.\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_434b942a","line":37,"updated":"2015-11-11 04:26:51.000000000","message":"why dest\u003d\u0027is_default\u0027, required? by deault the param should be \u0027is_default\u0027 only","commit_id":"0dc191758027f1d8186dae7564828a6f229c0799"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"4c9882ed269d37409175f6304137a5c3b0676414","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        action\u003d\u0027append\u0027, dest\u003d\u0027prefixes\u0027,"},{"line_number":35,"context_line":"        help\u003d_(\u0027Subnetpool prefixes (This option can be repeated).\u0027))"},{"line_number":36,"context_line":"    utils.add_boolean_argument("},{"line_number":37,"context_line":"        parser, \u0027--is-default\u0027, dest\u003d\u0027is_default\u0027,"},{"line_number":38,"context_line":"        help\u003d_(\u0027Set the subnetpool as the default.\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_11b868c7","line":37,"in_reply_to":"da85f559_434b942a","updated":"2015-11-11 12:33:50.000000000","message":"Specifying it makes it more explicit, but yes, parser.add_argument() will infer it from the parameter name so it isn\u0027t strictly needed. I\u0027ll remove it.","commit_id":"0dc191758027f1d8186dae7564828a6f229c0799"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c73f2204cc4e84b02cf0895026cb42491c1bd603","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutronclient.common import utils"},{"line_number":18,"context_line":"from neutronclient.i18n import _"},{"line_number":19,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_dbc34237","line":18,"updated":"2016-01-08 03:56:34.000000000","message":"You have reverted Akihiro´s changes of _i18n , I thinkduring the merge conflict resolution.\nIdeally neutronclient should import _i18n and not i18n\n\nReference: https://review.openstack.org/#/c/250992/8/neutronclient/neutron/v2_0/subnetpool.py","commit_id":"2871e1f3dac1828468bb33145b2ef16946ea08eb"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"108e5b19ce46065ab8b1e2dd0c2c4e15e71b4db3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutronclient.common import utils"},{"line_number":18,"context_line":"from neutronclient.i18n import _"},{"line_number":19,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_dcdbf8eb","line":18,"in_reply_to":"fa69d971_dbc34237","updated":"2016-01-08 22:30:15.000000000","message":"Ah yes, my mistake. Fixed.","commit_id":"2871e1f3dac1828468bb33145b2ef16946ea08eb"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c73f2204cc4e84b02cf0895026cb42491c1bd603","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        help\u003d_(\u0027Subnetpool prefixes (This option can be repeated).\u0027))"},{"line_number":36,"context_line":"    utils.add_boolean_argument("},{"line_number":37,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":38,"context_line":"        help\u003d_(\u0027Set the subnetpool as the default.\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def updatable_args2body(parsed_args, body, for_create\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_5baaf286","line":38,"range":{"start_line":38,"start_character":14,"end_line":38,"end_character":16},"updated":"2016-01-08 03:56:34.000000000","message":"Rewording suggested :\n¨Specify if the current subnetpool should be used as the default subnetpool.( True meaning default)¨","commit_id":"2871e1f3dac1828468bb33145b2ef16946ea08eb"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"108e5b19ce46065ab8b1e2dd0c2c4e15e71b4db3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        help\u003d_(\u0027Subnetpool prefixes (This option can be repeated).\u0027))"},{"line_number":36,"context_line":"    utils.add_boolean_argument("},{"line_number":37,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":38,"context_line":"        help\u003d_(\u0027Set the subnetpool as the default.\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def updatable_args2body(parsed_args, body, for_create\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_7c668c2a","line":38,"range":{"start_line":38,"start_character":14,"end_line":38,"end_character":16},"in_reply_to":"fa69d971_5baaf286","updated":"2016-01-08 22:30:15.000000000","message":"Thanks for this suggestion, I\u0027ll modify the help text.","commit_id":"2871e1f3dac1828468bb33145b2ef16946ea08eb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e406e3721fdbcac20dd3cc0e4a9bb59e641accd2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    utils.add_boolean_argument("},{"line_number":37,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":38,"context_line":"        help\u003d_(\u0027Specify whether this should be the default subnetpool, with \u0027"},{"line_number":39,"context_line":"               \u0027True indicating that it should.\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def updatable_args2body(parsed_args, body, for_create\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_6c978890","line":39,"updated":"2016-01-11 14:25:06.000000000","message":"nit: As non-native speaker, \"with True indicating....\" is not easy to understand. How about dropping this phrase (or making it a separate sentence: \"True means the default subnetpool\")?","commit_id":"989f99ce7b7a46d0894f8ca3c921e48d817c7953"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"d233db1a404fab39503836debdbf9f297a472d59","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    utils.add_boolean_argument("},{"line_number":37,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":38,"context_line":"        help\u003d_(\u0027Specify whether this should be the default subnetpool, with \u0027"},{"line_number":39,"context_line":"               \u0027True indicating that it should.\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def updatable_args2body(parsed_args, body, for_create\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_7d03e80d","line":39,"in_reply_to":"da6ed579_c3af0a93","updated":"2016-01-13 21:27:32.000000000","message":"Done","commit_id":"989f99ce7b7a46d0894f8ca3c921e48d817c7953"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0fa77e5d99f65667b783f2320736d8227e8dc855","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    utils.add_boolean_argument("},{"line_number":37,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":38,"context_line":"        help\u003d_(\u0027Specify whether this should be the default subnetpool, with \u0027"},{"line_number":39,"context_line":"               \u0027True indicating that it should.\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def updatable_args2body(parsed_args, body, for_create\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_c3af0a93","line":39,"in_reply_to":"fa69d971_6c978890","updated":"2016-01-12 01:22:21.000000000","message":"+1 , a minor change in the second line is suggested.\n@John: ( True meaning default) is somewhat used in other neutronclient messages as well.\nReference: https://github.com/openstack/python-neutronclient/blob/e12960dcf8c83515b64fb7a49a42487318c0f892/neutronclient/neutron/v2_0/router.py#L106\n\nSo you can rewrite it in that sense","commit_id":"989f99ce7b7a46d0894f8ca3c921e48d817c7953"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"d233db1a404fab39503836debdbf9f297a472d59","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    utils.add_boolean_argument("},{"line_number":37,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":38,"context_line":"        help\u003d_(\u0027Specify whether this should be the default subnetpool, with \u0027"},{"line_number":39,"context_line":"               \u0027True indicating that it should.\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def updatable_args2body(parsed_args, body, for_create\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_5d006401","line":39,"in_reply_to":"fa69d971_6c978890","updated":"2016-01-13 21:27:32.000000000","message":"Done","commit_id":"989f99ce7b7a46d0894f8ca3c921e48d817c7953"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"be1b95356d8b341f185969be1a62ab31f1ef3943","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        action\u003d\u0027append\u0027, dest\u003d\u0027prefixes\u0027,"},{"line_number":35,"context_line":"        help\u003d_(\u0027Subnetpool prefixes (This option can be repeated).\u0027))"},{"line_number":36,"context_line":"    utils.add_boolean_argument("},{"line_number":37,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":38,"context_line":"        help\u003d_(\u0027Specify whether this should be the default subnetpool \u0027"},{"line_number":39,"context_line":"               \u0027(True meaning default).\u0027))"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_bd4a5c53","line":37,"updated":"2016-01-15 10:09:20.000000000","message":"How about setting it\u0027s value to \u0027False\u0027 by default? \nhttps://github.com/openstack/neutron/blob/1fdec464a6876be866a0e91c69fe5a92e4b9ece9/neutron/api/v2/attributes.py#L875","commit_id":"3eaffeb03ea8a49725b0e94b34d07d65dce4a99a"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ef7ea6a5a737e373e7fd8789d46d27db76437d9a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        action\u003d\u0027append\u0027, dest\u003d\u0027prefixes\u0027,"},{"line_number":35,"context_line":"        help\u003d_(\u0027Subnetpool prefixes (This option can be repeated).\u0027))"},{"line_number":36,"context_line":"    utils.add_boolean_argument("},{"line_number":37,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":38,"context_line":"        help\u003d_(\u0027Specify whether this should be the default subnetpool \u0027"},{"line_number":39,"context_line":"               \u0027(True meaning default).\u0027))"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_f22bc792","line":37,"in_reply_to":"da6ed579_330def37","updated":"2016-01-18 10:26:35.000000000","message":"I meant adding default\u003dFalse","commit_id":"3eaffeb03ea8a49725b0e94b34d07d65dce4a99a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b284e8df29c44dc601ead47a9ee2970bad4d0e6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        action\u003d\u0027append\u0027, dest\u003d\u0027prefixes\u0027,"},{"line_number":35,"context_line":"        help\u003d_(\u0027Subnetpool prefixes (This option can be repeated).\u0027))"},{"line_number":36,"context_line":"    utils.add_boolean_argument("},{"line_number":37,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":38,"context_line":"        help\u003d_(\u0027Specify whether this should be the default subnetpool \u0027"},{"line_number":39,"context_line":"               \u0027(True meaning default).\u0027))"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_330def37","line":37,"in_reply_to":"da6ed579_bd4a5c53","updated":"2016-01-18 04:26:19.000000000","message":"What do you actually suggest? The default value of \"is_default\" is already \"False\". If we don\u0027t specify this option, \"is_default\" will be \"False\". L.39 is talking about the default subnetpool or not.","commit_id":"3eaffeb03ea8a49725b0e94b34d07d65dce4a99a"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"de536661c09094e8775f0740b5a95afec85872b6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        action\u003d\u0027append\u0027, dest\u003d\u0027prefixes\u0027,"},{"line_number":35,"context_line":"        help\u003d_(\u0027Subnetpool prefixes (This option can be repeated).\u0027))"},{"line_number":36,"context_line":"    utils.add_boolean_argument("},{"line_number":37,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":38,"context_line":"        help\u003d_(\u0027Specify whether this should be the default subnetpool \u0027"},{"line_number":39,"context_line":"               \u0027(True meaning default).\u0027))"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba63e191_45f20071","line":37,"in_reply_to":"da6ed579_f22bc792","updated":"2016-01-19 18:08:17.000000000","message":"The default value of this property is already False, so it is not necessary to have the CLI specify False if the user does not use this flag. I think it\u0027s desirable to send as little data as is necessary in the API call.","commit_id":"3eaffeb03ea8a49725b0e94b34d07d65dce4a99a"}],"neutronclient/tests/unit/test_cli20_subnetpool.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1a24003da21d365da38878a0d19ab277a5c931fc","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        min_prefixlen \u003d 30"},{"line_number":70,"context_line":"        prefix1 \u003d \u002710.11.12.0/24\u0027"},{"line_number":71,"context_line":"        prefix2 \u003d \u002712.11.13.0/24\u0027"},{"line_number":72,"context_line":"        is_default \u003d \u0027true\u0027"},{"line_number":73,"context_line":"        args \u003d [name, \u0027--min-prefixlen\u0027, str(min_prefixlen),"},{"line_number":74,"context_line":"                \u0027--pool-prefix\u0027, prefix1, \u0027--pool-prefix\u0027, prefix2,"},{"line_number":75,"context_line":"                \u0027--is-default\u0027, is_default]"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_0a30749d","line":72,"updated":"2015-11-10 07:42:17.000000000","message":"Please modify the is_default if you are implementing Akihiro\u0027s comment for Boolean value.","commit_id":"d8f685c62dd0bd42547e26c1000529d7cba8e4e0"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ac28f4835834ef56b196034afdcb9512e84e0cdd","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        min_prefixlen \u003d 30"},{"line_number":70,"context_line":"        prefix1 \u003d \u002710.11.12.0/24\u0027"},{"line_number":71,"context_line":"        prefix2 \u003d \u002712.11.13.0/24\u0027"},{"line_number":72,"context_line":"        is_default \u003d \u0027true\u0027"},{"line_number":73,"context_line":"        args \u003d [name, \u0027--min-prefixlen\u0027, str(min_prefixlen),"},{"line_number":74,"context_line":"                \u0027--pool-prefix\u0027, prefix1, \u0027--pool-prefix\u0027, prefix2,"},{"line_number":75,"context_line":"                \u0027--is-default\u0027, is_default]"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_f3787ec6","line":72,"in_reply_to":"da85f559_0a30749d","updated":"2015-11-10 14:04:25.000000000","message":"I believe this still needs to be a string as this it how it will be parsed by the cli","commit_id":"d8f685c62dd0bd42547e26c1000529d7cba8e4e0"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"1087ea62c6a5f5d978176bee600c3369f4b48ddb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        min_prefixlen \u003d 30"},{"line_number":70,"context_line":"        prefix1 \u003d \u002710.11.12.0/24\u0027"},{"line_number":71,"context_line":"        prefix2 \u003d \u002712.11.13.0/24\u0027"},{"line_number":72,"context_line":"        is_default \u003d \u0027true\u0027"},{"line_number":73,"context_line":"        args \u003d [name, \u0027--min-prefixlen\u0027, str(min_prefixlen),"},{"line_number":74,"context_line":"                \u0027--pool-prefix\u0027, prefix1, \u0027--pool-prefix\u0027, prefix2,"},{"line_number":75,"context_line":"                \u0027--is-default\u0027, is_default]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_0311b103","line":72,"updated":"2015-11-12 14:43:17.000000000","message":"I think it would be good to add/update a test to verify non-default subnetpool.","commit_id":"6af4326516a4024413769b2943137762052cfa48"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"158f2e38a995489bd44a1746fc2c36ad3336ad50","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        min_prefixlen \u003d 30"},{"line_number":70,"context_line":"        prefix1 \u003d \u002710.11.12.0/24\u0027"},{"line_number":71,"context_line":"        prefix2 \u003d \u002712.11.13.0/24\u0027"},{"line_number":72,"context_line":"        is_default \u003d \u0027true\u0027"},{"line_number":73,"context_line":"        args \u003d [name, \u0027--min-prefixlen\u0027, str(min_prefixlen),"},{"line_number":74,"context_line":"                \u0027--pool-prefix\u0027, prefix1, \u0027--pool-prefix\u0027, prefix2,"},{"line_number":75,"context_line":"                \u0027--is-default\u0027, is_default]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_fef77fd0","line":72,"in_reply_to":"da85f559_0311b103","updated":"2015-11-19 16:04:47.000000000","message":"Done","commit_id":"6af4326516a4024413769b2943137762052cfa48"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"ecc062fabbb3ef421daf39b167327d2418c55587","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self._test_create_resource(resource, cmd, name, myid, args,"},{"line_number":82,"context_line":"                                   position_names, position_values)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_create_subnetpool_not_default(self):"},{"line_number":85,"context_line":"        \"\"\"Create subnetpool: myname.\"\"\""},{"line_number":86,"context_line":"        resource \u003d \u0027subnetpool\u0027"},{"line_number":87,"context_line":"        cmd \u003d subnetpool.CreateSubnetPool(test_cli20.MyApp(sys.stdout), None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_d2b12fe1","line":84,"updated":"2015-12-09 09:01:20.000000000","message":"many duplicate codes, could you combine them?","commit_id":"574dfd8a08d0ff33624a4a253054c6b71017ab89"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"28df9b1e8381464f1d8538af6a511a70a69484fc","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self._test_create_resource(resource, cmd, name, myid, args,"},{"line_number":82,"context_line":"                                   position_names, position_values)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_create_subnetpool_not_default(self):"},{"line_number":85,"context_line":"        \"\"\"Create subnetpool: myname.\"\"\""},{"line_number":86,"context_line":"        resource \u003d \u0027subnetpool\u0027"},{"line_number":87,"context_line":"        cmd \u003d subnetpool.CreateSubnetPool(test_cli20.MyApp(sys.stdout), None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_5aff5334","line":84,"in_reply_to":"7a740942_d2b12fe1","updated":"2016-01-08 02:46:18.000000000","message":"Done","commit_id":"574dfd8a08d0ff33624a4a253054c6b71017ab89"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c73f2204cc4e84b02cf0895026cb42491c1bd603","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self._test_create_resource(resource, cmd, name, myid, args,"},{"line_number":64,"context_line":"                                   position_names, position_values)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_create_subnetpool(self, default\u003d\u0027false\u0027):"},{"line_number":67,"context_line":"        \"\"\"Create subnetpool: myname.\"\"\""},{"line_number":68,"context_line":"        resource \u003d \u0027subnetpool\u0027"},{"line_number":69,"context_line":"        cmd \u003d subnetpool.CreateSubnetPool(test_cli20.MyApp(sys.stdout), None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_9b2aaae6","line":66,"updated":"2016-01-08 03:56:34.000000000","message":"+1 for this change","commit_id":"2871e1f3dac1828468bb33145b2ef16946ea08eb"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e406e3721fdbcac20dd3cc0e4a9bb59e641accd2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                   position_names, position_values)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_create_subnetpool(self, default\u003d\u0027false\u0027):"},{"line_number":67,"context_line":"        \"\"\"Create subnetpool: myname.\"\"\""},{"line_number":68,"context_line":"        resource \u003d \u0027subnetpool\u0027"},{"line_number":69,"context_line":"        cmd \u003d subnetpool.CreateSubnetPool(test_cli20.MyApp(sys.stdout), None)"},{"line_number":70,"context_line":"        name \u003d \u0027myname\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_86a2f7ac","line":67,"updated":"2016-01-11 14:25:06.000000000","message":"We now use # to start a comment.\n\n  # Create subnetpool: myname","commit_id":"989f99ce7b7a46d0894f8ca3c921e48d817c7953"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"32adf736f12a617838377bf729c397db4810244e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                   position_names, position_values)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_create_subnetpool(self, default\u003d\u0027false\u0027):"},{"line_number":67,"context_line":"        \"\"\"Create subnetpool: myname.\"\"\""},{"line_number":68,"context_line":"        resource \u003d \u0027subnetpool\u0027"},{"line_number":69,"context_line":"        cmd \u003d subnetpool.CreateSubnetPool(test_cli20.MyApp(sys.stdout), None)"},{"line_number":70,"context_line":"        name \u003d \u0027myname\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_867cbb21","line":67,"in_reply_to":"fa69d971_86a2f7ac","updated":"2016-01-12 05:21:55.000000000","message":"+1","commit_id":"989f99ce7b7a46d0894f8ca3c921e48d817c7953"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"d233db1a404fab39503836debdbf9f297a472d59","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                   position_names, position_values)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_create_subnetpool(self, default\u003d\u0027false\u0027):"},{"line_number":67,"context_line":"        \"\"\"Create subnetpool: myname.\"\"\""},{"line_number":68,"context_line":"        resource \u003d \u0027subnetpool\u0027"},{"line_number":69,"context_line":"        cmd \u003d subnetpool.CreateSubnetPool(test_cli20.MyApp(sys.stdout), None)"},{"line_number":70,"context_line":"        name \u003d \u0027myname\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_1d218c9f","line":67,"in_reply_to":"fa69d971_86a2f7ac","updated":"2016-01-13 21:27:32.000000000","message":"Done","commit_id":"989f99ce7b7a46d0894f8ca3c921e48d817c7953"}]}