)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"f4e4e251ead43ca74001e266c8ac3156a2bd9728","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently python-neutronclient and python-openstackclient have different"},{"line_number":10,"context_line":"views of what OS_NETWORK_API_VERSION should be. Rather than fighting a"},{"line_number":11,"context_line":"land war, how about we make both things accept both things, since it\u0027s"},{"line_number":12,"context_line":"generally understandable by humand that \u00272\u0027 and \u00272.0\u0027 are the same"},{"line_number":13,"context_line":"thing."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibf3c14e15b19c1aca696ce5c693588565a73a524"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_74732b81","line":12,"updated":"2015-11-10 06:18:37.000000000","message":"Are you referencing a village ?? ;)\nhttps://en.wikipedia.org/wiki/Humand\n\nIf not, then this might be type :D","commit_id":"c8b5d3190ec2532778f96a4e4597e750c19b31fd"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"a10d6885ac6003dc8615d883e6d385437ea9f26e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently python-neutronclient and python-openstackclient have different"},{"line_number":10,"context_line":"views of what OS_NETWORK_API_VERSION should be. Rather than fighting a"},{"line_number":11,"context_line":"land war, how about we make both things accept both things, since it\u0027s"},{"line_number":12,"context_line":"generally understandable by humand that \u00272\u0027 and \u00272.0\u0027 are the same"},{"line_number":13,"context_line":"thing."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibf3c14e15b19c1aca696ce5c693588565a73a524"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_6b56842b","line":12,"updated":"2015-12-08 10:30:29.000000000","message":"Nit: s/humand/humans","commit_id":"4044a8ae1b173959b33ed7664ea4cb3bbc530761"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a7bee0d51e2bda55815109c361453c45f5e02cc3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently python-neutronclient and python-openstackclient have different"},{"line_number":10,"context_line":"views of what OS_NETWORK_API_VERSION should be. Rather than fighting a"},{"line_number":11,"context_line":"land war, how about we make both things accept both things, since it\u0027s"},{"line_number":12,"context_line":"generally understandable by humand that \u00272\u0027 and \u00272.0\u0027 are the same"},{"line_number":13,"context_line":"thing."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibf3c14e15b19c1aca696ce5c693588565a73a524"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_5c2e9fa6","line":12,"in_reply_to":"7a740942_6b56842b","updated":"2015-12-09 15:49:59.000000000","message":"Done","commit_id":"4044a8ae1b173959b33ed7664ea4cb3bbc530761"}],"neutronclient/neutron/client.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"f4e4e251ead43ca74001e266c8ac3156a2bd9728","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    instance.initialize()"},{"line_number":37,"context_line":"    url \u003d instance._url"},{"line_number":38,"context_line":"    url \u003d url.rstrip(\"/\")"},{"line_number":39,"context_line":"    if instance._api_version[API_NAME] in (\u00272\u0027, \u00272.0\u0027):"},{"line_number":40,"context_line":"        client \u003d neutron_client(username\u003dinstance._username,"},{"line_number":41,"context_line":"                                tenant_name\u003dinstance._tenant_name,"},{"line_number":42,"context_line":"                                password\u003dinstance._password,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_74fa4bbf","line":39,"updated":"2015-11-10 06:18:37.000000000","message":"Can we possibly use the  keys in the API_VERSION?\nThat would allow future addition of API versions , isnt it, and avoid direct hardcoding.\n\nWhat say?","commit_id":"c8b5d3190ec2532778f96a4e4597e750c19b31fd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"758c39e6384d0cd8ca9afbe03281e44f6fe4c9ff","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    instance.initialize()"},{"line_number":37,"context_line":"    url \u003d instance._url"},{"line_number":38,"context_line":"    url \u003d url.rstrip(\"/\")"},{"line_number":39,"context_line":"    if instance._api_version[API_NAME] in (\u00272\u0027, \u00272.0\u0027):"},{"line_number":40,"context_line":"        client \u003d neutron_client(username\u003dinstance._username,"},{"line_number":41,"context_line":"                                tenant_name\u003dinstance._tenant_name,"},{"line_number":42,"context_line":"                                password\u003dinstance._password,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_fa5484fe","line":39,"in_reply_to":"da85f559_74fa4bbf","updated":"2015-12-08 09:22:47.000000000","message":"This if-clause is unnecessary.\nThe version check is already done at L.31 and there is no case to go \"else\".","commit_id":"c8b5d3190ec2532778f96a4e4597e750c19b31fd"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"a10d6885ac6003dc8615d883e6d385437ea9f26e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    )"},{"line_number":36,"context_line":"    instance.initialize()"},{"line_number":37,"context_line":"    url \u003d instance._url"},{"line_number":38,"context_line":"    url \u003d url.rstrip(\"/\")"},{"line_number":39,"context_line":"    client \u003d neutron_client(username\u003dinstance._username,"},{"line_number":40,"context_line":"                            tenant_name\u003dinstance._tenant_name,"},{"line_number":41,"context_line":"                            password\u003dinstance._password,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_eb0fd436","line":38,"updated":"2015-12-08 10:30:29.000000000","message":"How is the API version now checked?","commit_id":"4044a8ae1b173959b33ed7664ea4cb3bbc530761"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"ccacaa910e26221c73e772dd253024acad5c6cc4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    )"},{"line_number":36,"context_line":"    instance.initialize()"},{"line_number":37,"context_line":"    url \u003d instance._url"},{"line_number":38,"context_line":"    url \u003d url.rstrip(\"/\")"},{"line_number":39,"context_line":"    client \u003d neutron_client(username\u003dinstance._username,"},{"line_number":40,"context_line":"                            tenant_name\u003dinstance._tenant_name,"},{"line_number":41,"context_line":"                            password\u003dinstance._password,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_617f83ab","line":38,"in_reply_to":"7a740942_c13e7727","updated":"2015-12-08 11:03:51.000000000","message":"Nice and clean check. thanks.","commit_id":"4044a8ae1b173959b33ed7664ea4cb3bbc530761"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"225e984c6a88dba1f4326c4d456ae69595974fd7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    )"},{"line_number":36,"context_line":"    instance.initialize()"},{"line_number":37,"context_line":"    url \u003d instance._url"},{"line_number":38,"context_line":"    url \u003d url.rstrip(\"/\")"},{"line_number":39,"context_line":"    client \u003d neutron_client(username\u003dinstance._username,"},{"line_number":40,"context_line":"                            tenant_name\u003dinstance._tenant_name,"},{"line_number":41,"context_line":"                            password\u003dinstance._password,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_c13e7727","line":38,"in_reply_to":"7a740942_eb0fd436","updated":"2015-12-08 10:59:44.000000000","message":"utils.get_client_class does the same job.\nget_client_class takes API_VERSIONS and if a specified version is not found it raises UnsupportedVersion exception.\nI hope it makes sense.\n\nhttp://git.openstack.org/cgit/openstack/python-neutronclient/tree/neutronclient/common/utils.py#n45","commit_id":"4044a8ae1b173959b33ed7664ea4cb3bbc530761"}]}