)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"8d4529026ba4b76246577a663f6197534fd5456a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds support to enable naming LBaasV2 Members and Health"},{"line_number":10,"context_line":"Monitors(HMs) in python-neutronclient."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug : #1515506"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I27ac48953bb09841234fce6d852f062e2030284e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_2e8c797e","line":12,"updated":"2015-11-17 17:12:05.000000000","message":"nit...remove space before colon to allow proper link to bug.","commit_id":"7cf945ab025d5b76d1449d27b00d81e4b94a0434"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"8d4529026ba4b76246577a663f6197534fd5456a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Monitors(HMs) in python-neutronclient."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug : #1515506"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I27ac48953bb09841234fce6d852f062e2030284e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_2eba390b","line":13,"updated":"2015-11-17 17:12:05.000000000","message":"Should this patch set depend on https://review.openstack.org/#/c/245664/ ?","commit_id":"7cf945ab025d5b76d1449d27b00d81e4b94a0434"}],"neutronclient/neutron/v2_0/lb/v2/healthmonitor.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"8d4529026ba4b76246577a663f6197534fd5456a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"def add_common_args(parser):"},{"line_number":40,"context_line":"    parser.add_argument("},{"line_number":41,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":42,"context_line":"        help\u003d_(\u0027Name of the Health Monitor.\u0027))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class CreateHealthMonitor(neutronV20.CreateCommand):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_6eab61d7","line":42,"updated":"2015-11-17 17:12:05.000000000","message":"I don\u0027t think that \"Health Monitor\" should be capitalized to be consistent with the other help below.","commit_id":"7cf945ab025d5b76d1449d27b00d81e4b94a0434"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"11d11c82df3b93e11d712b2ff67f32283562e37a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"def add_common_args(parser):"},{"line_number":40,"context_line":"    parser.add_argument("},{"line_number":41,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":42,"context_line":"        help\u003d_(\u0027Name of the Health Monitor.\u0027))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class CreateHealthMonitor(neutronV20.CreateCommand):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_9e49378e","line":42,"updated":"2015-11-17 01:51:16.000000000","message":"This function has been added here, to avoid multiple code changes when the fix for https://bugs.launchpad.net/python-neutronclient/+bug/1515111 is proposed.\nSame has been done for \t\nneutronclient/neutron/v2_0/lb/v2/member.py","commit_id":"7cf945ab025d5b76d1449d27b00d81e4b94a0434"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"f29dd828b8e02d2079e7fa82ada87527f8cfecbe","unresolved":false,"context_lines":[{"line_number":39,"context_line":"def add_common_args(parser):"},{"line_number":40,"context_line":"    parser.add_argument("},{"line_number":41,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":42,"context_line":"        help\u003d_(\u0027Name of the Health Monitor.\u0027))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class CreateHealthMonitor(neutronV20.CreateCommand):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_f002b10a","line":42,"in_reply_to":"ba8a016a_6eab61d7","updated":"2015-11-18 01:12:12.000000000","message":"Done","commit_id":"7cf945ab025d5b76d1449d27b00d81e4b94a0434"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"f5bc043cc4badb2270ff63afaa28f99a936f4bd2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def add_common_args(parser):"},{"line_number":40,"context_line":"    parser.add_argument("},{"line_number":41,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":42,"context_line":"        help\u003d_(\u0027Name of the health monitor.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_bca0baf5","line":39,"updated":"2015-11-25 09:16:27.000000000","message":"I would call it as \"_add_updatable_args\", that is what it is doing and other module call it(not so consistent in other places, but general the same meaning)","commit_id":"9dc3889689fa0d4784884f646f2924da4574d47e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"dd1c043068ada3e79e046cf76d33f9ebe57f3375","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def add_common_args(parser):"},{"line_number":40,"context_line":"    parser.add_argument("},{"line_number":41,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":42,"context_line":"        help\u003d_(\u0027Name of the health monitor.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_bf30ac57","line":39,"in_reply_to":"9a8ffd7b_bca0baf5","updated":"2015-11-25 09:25:22.000000000","message":"Done","commit_id":"9dc3889689fa0d4784884f646f2924da4574d47e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8e868ec87187ceb3169bc5f629466715359c7541","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    resource \u003d \u0027healthmonitor\u0027"},{"line_number":26,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":27,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027type\u0027, \u0027admin_state_up\u0027, \u0027name\u0027]"},{"line_number":28,"context_line":"    pagination_support \u003d True"},{"line_number":29,"context_line":"    sorting_support \u003d True"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_64d12257","line":27,"updated":"2015-11-26 05:05:45.000000000","message":"Most list commands show \u0027name\u0027 field next to \u0027id\u0027.","commit_id":"9d5419750f51f376aecf02f457e3b5593df74a91"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"aaf0da7d4abfbb3337883aca768eb37fd25ea41e","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    resource \u003d \u0027healthmonitor\u0027"},{"line_number":26,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":27,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027type\u0027, \u0027admin_state_up\u0027, \u0027name\u0027]"},{"line_number":28,"context_line":"    pagination_support \u003d True"},{"line_number":29,"context_line":"    sorting_support \u003d True"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_4f10b7a8","line":27,"in_reply_to":"9a8ffd7b_44109ea8","updated":"2015-11-26 06:02:23.000000000","message":"Do we have a contract of the order of list output?","commit_id":"9d5419750f51f376aecf02f457e3b5593df74a91"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c6e52a34762d9e598549c03ee37219266211f94b","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    resource \u003d \u0027healthmonitor\u0027"},{"line_number":26,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":27,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027type\u0027, \u0027admin_state_up\u0027, \u0027name\u0027]"},{"line_number":28,"context_line":"    pagination_support \u003d True"},{"line_number":29,"context_line":"    sorting_support \u003d True"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_cfe1079c","line":27,"in_reply_to":"9a8ffd7b_4f10b7a8","updated":"2015-11-26 06:18:01.000000000","message":"I dont think so.\nAnyways, I guess I will change it.","commit_id":"9d5419750f51f376aecf02f457e3b5593df74a91"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"96d7193bbf3eb8ec813791b6dd591e8c56580354","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    resource \u003d \u0027healthmonitor\u0027"},{"line_number":26,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":27,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027type\u0027, \u0027admin_state_up\u0027, \u0027name\u0027]"},{"line_number":28,"context_line":"    pagination_support \u003d True"},{"line_number":29,"context_line":"    sorting_support \u003d True"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_44109ea8","line":27,"in_reply_to":"9a8ffd7b_64d12257","updated":"2015-11-26 05:25:52.000000000","message":"@Akihiro San:\nThis has been done keeping a specific case in mind.\n\nIf a customer has a bash script to automatically work on HealthMonitors, ( listing and taking the Nth element to work upon), changing the display attribute may cause a problem to them.\n\nIf you still think that this needs to be changed, then I will do it.\nLooking for some advice here.","commit_id":"9d5419750f51f376aecf02f457e3b5593df74a91"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1f6322bc5c24bde376c183d9cd040854e20d9e5e","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    resource \u003d \u0027healthmonitor\u0027"},{"line_number":118,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":119,"context_line":"    allow_names \u003d False"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":122,"context_line":"        _add_updatable_args(parser)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_fb209f4b","line":119,"updated":"2015-12-04 02:22:13.000000000","message":"allow_names \u003d True?","commit_id":"29d2483a29dcba285774bd4c0eeb33aefcb5b63f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b3bfe780675ca57ff046f25dd6318e06e24f0c44","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _add_updatable_args(parser):"},{"line_number":40,"context_line":"    parser.add_argument("},{"line_number":41,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":42,"context_line":"        help\u003d_(\u0027Name of the health monitor.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_e67ec2ad","line":39,"updated":"2015-12-04 03:29:11.000000000","message":"It will be better if we can define \"_parse_updatable_args(parser)\" which could be called from create and update function\u0027s. In this way we will not have redundant code in the future. Any thoughts?","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c2ad72c87bf6723095e87af35c733da96c977245","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _add_updatable_args(parser):"},{"line_number":40,"context_line":"    parser.add_argument("},{"line_number":41,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":42,"context_line":"        help\u003d_(\u0027Name of the health monitor.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_e1c1cc2f","line":39,"in_reply_to":"7a740942_0173b881","updated":"2015-12-04 03:47:29.000000000","message":"And if required, parse_updatable_args ( which would be used by args2body) would be created in the above mentioned patch.","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7fbd45b718ee63ff973f83803559ba4d6db51e19","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _add_updatable_args(parser):"},{"line_number":40,"context_line":"    parser.add_argument("},{"line_number":41,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":42,"context_line":"        help\u003d_(\u0027Name of the health monitor.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_ea7de0b1","line":39,"in_reply_to":"7a740942_c84b8caf","updated":"2015-12-07 00:45:54.000000000","message":"Hi Vikram, \nI am not sure about the purpose of the _add_common_args2body function.\nLets discuss it on the IRC, and if required, I will respin this patch.","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"19f130812a8998559d8fbf57b80195b3d4144bc5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _add_updatable_args(parser):"},{"line_number":40,"context_line":"    parser.add_argument("},{"line_number":41,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":42,"context_line":"        help\u003d_(\u0027Name of the health monitor.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_c84b8caf","line":39,"in_reply_to":"7a740942_e1c1cc2f","updated":"2015-12-04 09:36:02.000000000","message":"@Reedip: I am not asking to rename. What I mean is to have \"_add_common_args2body\" API which might be called from Create and Update function\u0027s.","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3c3500f0eb17082ed406d6412aa4428061925ab2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _add_updatable_args(parser):"},{"line_number":40,"context_line":"    parser.add_argument("},{"line_number":41,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":42,"context_line":"        help\u003d_(\u0027Name of the health monitor.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_0173b881","line":39,"in_reply_to":"7a740942_e67ec2ad","updated":"2015-12-04 03:44:17.000000000","message":"@Vikram:\nNot sure if the renaming is required.\nBut please see https://review.openstack.org/#/c/246077/1/neutronclient/neutron/v2_0/lb/v2/healthmonitor.py\n\nI have mentioned the same as a comment for future :)","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"9d1032682635415cffa458afc6af7fac1488b6be","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def _add_updatable_args(parser):"},{"line_number":40,"context_line":"    parser.add_argument("},{"line_number":41,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":42,"context_line":"        help\u003d_(\u0027Name of the health monitor.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_f8b13790","line":39,"in_reply_to":"7a740942_ea7de0b1","updated":"2015-12-07 05:21:56.000000000","message":"Sure!","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c59aa0d2d255424ebf551400f1d04b54361f1315","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    resource \u003d \u0027healthmonitor\u0027"},{"line_number":118,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":119,"context_line":"    allow_names \u003d True"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":122,"context_line":"        _add_updatable_args(parser)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_06dc2ee3","line":119,"updated":"2015-12-04 03:18:53.000000000","message":"allow_names \u003d True is the default value. No need to declare it here. you can remove it.","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b3bfe780675ca57ff046f25dd6318e06e24f0c44","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    resource \u003d \u0027healthmonitor\u0027"},{"line_number":118,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":119,"context_line":"    allow_names \u003d True"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":122,"context_line":"        _add_updatable_args(parser)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_a6f3da72","line":119,"in_reply_to":"7a740942_06dc2ee3","updated":"2015-12-04 03:29:11.000000000","message":"+1","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3c3500f0eb17082ed406d6412aa4428061925ab2","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    resource \u003d \u0027healthmonitor\u0027"},{"line_number":118,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":119,"context_line":"    allow_names \u003d True"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":122,"context_line":"        _add_updatable_args(parser)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_e100ecac","line":119,"in_reply_to":"7a740942_a6f3da72","updated":"2015-12-04 03:44:17.000000000","message":"Though its not a big influence, if there is a respin for this patch, I will change it","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"21235899412d61bfa5de671967f30aae080e9d9d","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    resource \u003d \u0027healthmonitor\u0027"},{"line_number":118,"context_line":"    shadow_resource \u003d \u0027lbaas_healthmonitor\u0027"},{"line_number":119,"context_line":"    allow_names \u003d True"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":122,"context_line":"        _add_updatable_args(parser)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_28536d18","line":119,"in_reply_to":"7a740942_e100ecac","updated":"2015-12-09 06:36:22.000000000","message":"Done","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b3bfe780675ca57ff046f25dd6318e06e24f0c44","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def args2body(self, parsed_args):"},{"line_number":125,"context_line":"        body \u003d {}"},{"line_number":126,"context_line":"        neutronV20.update_dict(parsed_args, body, [\u0027name\u0027])"},{"line_number":127,"context_line":"        return {self.resource: body}"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_c69386f9","line":126,"updated":"2015-12-04 03:29:11.000000000","message":"Since only one param is there so IMO, it\u0027s better to have direct assignment instead of calling update_dict.","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3c3500f0eb17082ed406d6412aa4428061925ab2","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def args2body(self, parsed_args):"},{"line_number":125,"context_line":"        body \u003d {}"},{"line_number":126,"context_line":"        neutronV20.update_dict(parsed_args, body, [\u0027name\u0027])"},{"line_number":127,"context_line":"        return {self.resource: body}"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_a10ae4d0","line":126,"in_reply_to":"7a740942_c69386f9","updated":"2015-12-04 03:44:17.000000000","message":"Please see my first comment ... This has been done intentionally","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a653057ffb50adabbf503595ad98533788817a66","unresolved":false,"context_lines":[{"line_number":39,"context_line":"def _add_updatable_args(parser):"},{"line_number":40,"context_line":"    parser.add_argument("},{"line_number":41,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":42,"context_line":"        help\u003d_(\u0027Name of the health monitor.\u0027))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class CreateHealthMonitor(neutronV20.CreateCommand):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_85c16231","line":42,"updated":"2015-12-13 00:43:57.000000000","message":"The help message should be consistent with your patch https://review.openstack.org/255697 . You add \"to be created\" to the help message of \u0027name\u0027 in review 255697, but you share the option registration here. I wonder what is your direction.... It seems you are proposing two  conflicting changes.","commit_id":"149420a8a55fc61667ef1f4eb431fab5e03fcfee"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"51199f4058b7063c8bc0e3932a04fa4e17dffa88","unresolved":false,"context_lines":[{"line_number":39,"context_line":"def _add_updatable_args(parser):"},{"line_number":40,"context_line":"    parser.add_argument("},{"line_number":41,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":42,"context_line":"        help\u003d_(\u0027Name of the health monitor.\u0027))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class CreateHealthMonitor(neutronV20.CreateCommand):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_45613a38","line":42,"in_reply_to":"7a740942_85c16231","updated":"2015-12-13 01:17:58.000000000","message":"Sorry, seems this was missed somehow.\nUpdating it","commit_id":"149420a8a55fc61667ef1f4eb431fab5e03fcfee"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"21b0163b980fbc1685c47767a23e51dd9514f595","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":46,"context_line":"        parser.add_argument("},{"line_number":47,"context_line":"            \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":48,"context_line":"            help\u003d_(\u0027Name of the health monitor to be created.\u0027))"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027--admin-state-down\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a710552_865bf72d","line":47,"updated":"2015-12-16 10:13:07.000000000","message":"This metavar is redundant, it isn\u0027t used anywhere and doesn\u0027t affect the format of the help message.","commit_id":"d0d088ab4d800f49927736c11c0451f33df140d5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ba8dc811a90e1233ea46eb7b506b5cf2c4dd0076","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":46,"context_line":"        parser.add_argument("},{"line_number":47,"context_line":"            \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":48,"context_line":"            help\u003d_(\u0027Name of the health monitor to be created.\u0027))"},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027--admin-state-down\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a7b0d38_a7f8ace6","line":47,"in_reply_to":"5a710552_865bf72d","updated":"2015-12-23 14:44:35.000000000","message":"metavar\u003d\u0027NAME\u0027 is unnecessary.\n\nMost other metavar\u003d\u0027NAME\u0027 are used in positional argument definitions. They are required to show \u0027NAME\u0027 in the help message (because \u0027name\u0027 is a default value), but this is an optional argument and \u0027--name NAME\u0027 is a default value, so it is unnecessary.","commit_id":"d0d088ab4d800f49927736c11c0451f33df140d5"}],"neutronclient/neutron/v2_0/lb/v2/member.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"f5bc043cc4badb2270ff63afaa28f99a936f4bd2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def add_common_args(parser):"},{"line_number":41,"context_line":"    parser.add_argument("},{"line_number":42,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":43,"context_line":"        help\u003d_(\u0027Name of the member.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_7caa52d6","line":40,"updated":"2015-11-25 09:16:27.000000000","message":"The same as my last comment.","commit_id":"9dc3889689fa0d4784884f646f2924da4574d47e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"dd1c043068ada3e79e046cf76d33f9ebe57f3375","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def add_common_args(parser):"},{"line_number":41,"context_line":"    parser.add_argument("},{"line_number":42,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":43,"context_line":"        help\u003d_(\u0027Name of the member.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_9f2b68eb","line":40,"in_reply_to":"9a8ffd7b_7caa52d6","updated":"2015-11-25 09:25:22.000000000","message":"Done","commit_id":"9dc3889689fa0d4784884f646f2924da4574d47e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8e868ec87187ceb3169bc5f629466715359c7541","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":43,"context_line":"        help\u003d_(\u0027Name of the member.\u0027))"},{"line_number":44,"context_line":"    parser.add_argument("},{"line_number":45,"context_line":"        \u0027--admin-state-down\u0027,"},{"line_number":46,"context_line":"        dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":47,"context_line":"        help\u003d_(\u0027Set admin state up to false.\u0027))"},{"line_number":48,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_c4ba4e0a","line":45,"updated":"2015-11-26 05:05:45.000000000","message":"Do you want \u0027--admin-state-down\u0027 option for the update command? however it is an existing option, so I am okay.","commit_id":"9d5419750f51f376aecf02f457e3b5593df74a91"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8e868ec87187ceb3169bc5f629466715359c7541","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        help\u003d_(\u0027Weight of member in the pool (default:1, [0..256]).\u0027))"},{"line_number":51,"context_line":"    parser.add_argument("},{"line_number":52,"context_line":"        \u0027pool\u0027, metavar\u003d\u0027POOL\u0027,"},{"line_number":53,"context_line":"        help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class ListMember(LbaasMemberMixin, neutronV20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_c451eed9","line":53,"updated":"2015-11-26 05:05:45.000000000","message":"It is a bit tricky. ID is not updatable....","commit_id":"9d5419750f51f376aecf02f457e3b5593df74a91"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"aaf0da7d4abfbb3337883aca768eb37fd25ea41e","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        help\u003d_(\u0027Weight of member in the pool (default:1, [0..256]).\u0027))"},{"line_number":51,"context_line":"    parser.add_argument("},{"line_number":52,"context_line":"        \u0027pool\u0027, metavar\u003d\u0027POOL\u0027,"},{"line_number":53,"context_line":"        help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class ListMember(LbaasMemberMixin, neutronV20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_cfeee7b3","line":53,"in_reply_to":"9a8ffd7b_245b1a89","updated":"2015-11-26 06:02:23.000000000","message":"Strange. ID is immutable. Even if \"name\" is specified, it is used to look up for ID of a given resource.\n\nI think you are talking \"name\" field is updateable, but it is about --name option.\n\nIn addition, L.51-53 is unnecessary if CreateMember/UpdateMember calls super() appropriately. It comes from non-standard implementation of these classes. See neutroncliient/neutron/v2_0/__init__.py.","commit_id":"9d5419750f51f376aecf02f457e3b5593df74a91"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2d3c16a4e93da07e85d6eaafd8692305ae29f540","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        help\u003d_(\u0027Weight of member in the pool (default:1, [0..256]).\u0027))"},{"line_number":51,"context_line":"    parser.add_argument("},{"line_number":52,"context_line":"        \u0027pool\u0027, metavar\u003d\u0027POOL\u0027,"},{"line_number":53,"context_line":"        help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class ListMember(LbaasMemberMixin, neutronV20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_8a3bed9b","line":53,"in_reply_to":"9a8ffd7b_4a80a546","updated":"2015-11-26 06:18:57.000000000","message":"I will rename the function :)","commit_id":"9d5419750f51f376aecf02f457e3b5593df74a91"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c6e52a34762d9e598549c03ee37219266211f94b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        help\u003d_(\u0027Weight of member in the pool (default:1, [0..256]).\u0027))"},{"line_number":51,"context_line":"    parser.add_argument("},{"line_number":52,"context_line":"        \u0027pool\u0027, metavar\u003d\u0027POOL\u0027,"},{"line_number":53,"context_line":"        help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class ListMember(LbaasMemberMixin, neutronV20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_aae83111","line":53,"in_reply_to":"9a8ffd7b_8fc0dfe1","updated":"2015-11-26 06:18:01.000000000","message":"@Akihiro San:\nOk, I think I now understand what you mean.\nLet me see and use one of the below methods:\n- Rename function\n- Call Super\n\nand respin the patch","commit_id":"9d5419750f51f376aecf02f457e3b5593df74a91"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"22354718cf546c6f2d7285fa9070dec871bb2051","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        help\u003d_(\u0027Weight of member in the pool (default:1, [0..256]).\u0027))"},{"line_number":51,"context_line":"    parser.add_argument("},{"line_number":52,"context_line":"        \u0027pool\u0027, metavar\u003d\u0027POOL\u0027,"},{"line_number":53,"context_line":"        help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class ListMember(LbaasMemberMixin, neutronV20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_4a80a546","line":53,"in_reply_to":"9a8ffd7b_8fc0dfe1","updated":"2015-11-26 06:16:56.000000000","message":"Really sorry.... my comment on super() was wrong...\nHowever, \"POOL\" is used as parent_id, so it is still not updateable.","commit_id":"9d5419750f51f376aecf02f457e3b5593df74a91"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"96d7193bbf3eb8ec813791b6dd591e8c56580354","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        help\u003d_(\u0027Weight of member in the pool (default:1, [0..256]).\u0027))"},{"line_number":51,"context_line":"    parser.add_argument("},{"line_number":52,"context_line":"        \u0027pool\u0027, metavar\u003d\u0027POOL\u0027,"},{"line_number":53,"context_line":"        help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class ListMember(LbaasMemberMixin, neutronV20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_245b1a89","line":53,"in_reply_to":"9a8ffd7b_c451eed9","updated":"2015-11-26 05:25:52.000000000","message":"Dear Akihiro San, \nThis is a modification/update of Members.\nIf the Member needs to be moved from Pool A to Pool B, then the Pool Name/Pool ID can be specified by the user.\nSo I think this is correct here.","commit_id":"9d5419750f51f376aecf02f457e3b5593df74a91"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3ffa311a9f73e6cb9f4da5f77848cf2ea2cee780","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        help\u003d_(\u0027Weight of member in the pool (default:1, [0..256]).\u0027))"},{"line_number":51,"context_line":"    parser.add_argument("},{"line_number":52,"context_line":"        \u0027pool\u0027, metavar\u003d\u0027POOL\u0027,"},{"line_number":53,"context_line":"        help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class ListMember(LbaasMemberMixin, neutronV20.ListCommand):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_8fc0dfe1","line":53,"in_reply_to":"9a8ffd7b_cfeee7b3","updated":"2015-11-26 06:06:24.000000000","message":"One thing to add.\n\nMy comment comes from the method name.\nThe method name says \"updatable_args\", so it looks odd to me to have non-updatable option in this method.\nIf the method name is like a name which defines common arguments shared by Create/UpdateMember, it looks good.\n\nAnyway, I would suggest to use super() appropriately.","commit_id":"9d5419750f51f376aecf02f457e3b5593df74a91"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1f6322bc5c24bde376c183d9cd040854e20d9e5e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    shadow_resource \u003d \u0027lbaas_member\u0027"},{"line_number":61,"context_line":"    list_columns \u003d ["},{"line_number":62,"context_line":"        \u0027id\u0027, \u0027address\u0027, \u0027protocol_port\u0027, \u0027weight\u0027,"},{"line_number":63,"context_line":"        \u0027subnet_id\u0027, \u0027admin_state_up\u0027, \u0027status\u0027, \u0027name\u0027"},{"line_number":64,"context_line":"    ]"},{"line_number":65,"context_line":"    pagination_support \u003d True"},{"line_number":66,"context_line":"    sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_7ba10fa9","line":63,"updated":"2015-12-04 02:22:13.000000000","message":"Why don\u0027t you put \u0027name\u0027 next to \u0027id\u0027?","commit_id":"29d2483a29dcba285774bd4c0eeb33aefcb5b63f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b3bfe780675ca57ff046f25dd6318e06e24f0c44","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _add_common_args(parser):"},{"line_number":41,"context_line":"    parser.add_argument("},{"line_number":42,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":43,"context_line":"        help\u003d_(\u0027Name of the member.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_66173252","line":40,"updated":"2015-12-04 03:29:11.000000000","message":"IMO, common function for update will be useful for code re-usability and easier maintenance.","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3c3500f0eb17082ed406d6412aa4428061925ab2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _add_common_args(parser):"},{"line_number":41,"context_line":"    parser.add_argument("},{"line_number":42,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":43,"context_line":"        help\u003d_(\u0027Name of the member.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_81d32838","line":40,"in_reply_to":"7a740942_66173252","updated":"2015-12-04 03:44:17.000000000","message":"I guess thats what this function is doing, isnt it ?? :).\nFor discussion on the naming, please see https://review.openstack.org/#/c/246077/3..6/neutronclient/neutron/v2_0/lb/v2/member.py","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"19f130812a8998559d8fbf57b80195b3d4144bc5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _add_common_args(parser):"},{"line_number":41,"context_line":"    parser.add_argument("},{"line_number":42,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":43,"context_line":"        help\u003d_(\u0027Name of the member.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_e3b0e98d","line":40,"in_reply_to":"7a740942_81d32838","updated":"2015-12-04 09:36:02.000000000","message":"@Reedip: I am not asking to rename. What I mean is to have \"_add_common_args2body\" API which might be called from Create and Update function\u0027s.","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"28f1ac780ecab2ddac8e7e862278a30e508e1da1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _add_common_args(parser):"},{"line_number":41,"context_line":"    parser.add_argument("},{"line_number":42,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":43,"context_line":"        help\u003d_(\u0027Name of the member.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_b0e0292a","line":40,"in_reply_to":"7a740942_e3b0e98d","updated":"2015-12-09 02:58:16.000000000","message":"As mentioned  in the health_monitor.py file, will do this in the next patch","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7e959e2f601a93aae0ea80229649a2df63d3748e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":43,"context_line":"        help\u003d_(\u0027Name of the member.\u0027))"},{"line_number":44,"context_line":"    parser.add_argument("},{"line_number":45,"context_line":"        \u0027--admin-state-down\u0027,"},{"line_number":46,"context_line":"        dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":47,"context_line":"        help\u003d_(\u0027Set admin state up to false.\u0027))"},{"line_number":48,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_4ddac04d","line":45,"updated":"2015-12-08 09:49:58.000000000","message":"This should not be used for UpdateMember.\nIn UpdateMember, we need to support --admin-state-up True/False.","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"28f1ac780ecab2ddac8e7e862278a30e508e1da1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":43,"context_line":"        help\u003d_(\u0027Name of the member.\u0027))"},{"line_number":44,"context_line":"    parser.add_argument("},{"line_number":45,"context_line":"        \u0027--admin-state-down\u0027,"},{"line_number":46,"context_line":"        dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":47,"context_line":"        help\u003d_(\u0027Set admin state up to false.\u0027))"},{"line_number":48,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_908acd62","line":45,"in_reply_to":"7a740942_4ddac04d","updated":"2015-12-09 02:58:16.000000000","message":"Actually in https://review.openstack.org/#/c/246077/3..6/neutronclient/neutron/v2_0/lb/v2/member.py, you considered it to be okay :)\n\nAnyhow, I better change it because it differs from other CLIs","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2ba11ad9c171478e0cc7dce42412a45b56662980","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":43,"context_line":"        help\u003d_(\u0027Name of the member.\u0027))"},{"line_number":44,"context_line":"    parser.add_argument("},{"line_number":45,"context_line":"        \u0027--admin-state-down\u0027,"},{"line_number":46,"context_line":"        dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":47,"context_line":"        help\u003d_(\u0027Set admin state up to false.\u0027))"},{"line_number":48,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_dd0dc58f","line":45,"in_reply_to":"7a740942_7dd13122","updated":"2015-12-09 08:38:39.000000000","message":"I would prefer deprecating it and introducing the --admin-state-up in the current cycle.\nWould bring this CLI closer to the other NeutronClient CLI behaviour","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"21235899412d61bfa5de671967f30aae080e9d9d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":43,"context_line":"        help\u003d_(\u0027Name of the member.\u0027))"},{"line_number":44,"context_line":"    parser.add_argument("},{"line_number":45,"context_line":"        \u0027--admin-state-down\u0027,"},{"line_number":46,"context_line":"        dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":47,"context_line":"        help\u003d_(\u0027Set admin state up to false.\u0027))"},{"line_number":48,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_e8580533","line":45,"in_reply_to":"7a740942_908acd62","updated":"2015-12-09 06:36:22.000000000","message":"Done","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dbe6d53e8f09072df07257d596611b0393c4bcb1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":43,"context_line":"        help\u003d_(\u0027Name of the member.\u0027))"},{"line_number":44,"context_line":"    parser.add_argument("},{"line_number":45,"context_line":"        \u0027--admin-state-down\u0027,"},{"line_number":46,"context_line":"        dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":47,"context_line":"        help\u003d_(\u0027Set admin state up to false.\u0027))"},{"line_number":48,"context_line":"    parser.add_argument("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_7dd13122","line":45,"in_reply_to":"7a740942_e8580533","updated":"2015-12-09 08:10:55.000000000","message":"Ah.. if so, we need to deprecate the option before removing it.\nThere are too many inconsistency and I cannot follow all of them.","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"1c3d0f83d2d7df35604a5491f3d184cf66993bda","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                   \u0027 (True meaning \"Up\")\u0027))"},{"line_number":130,"context_line":"        utils.add_boolean_argument("},{"line_number":131,"context_line":"            parser, \u0027--admin_state_up\u0027, dest\u003d\u0027admin_state_up\u0027,"},{"line_number":132,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def args2body(self, parsed_args):"},{"line_number":135,"context_line":"        self.parent_id \u003d _get_pool_id(self.get_client(), parsed_args.pool)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_662e87a6","line":132,"updated":"2015-12-09 04:34:41.000000000","message":"Removing this argument, as discussed over another patch","commit_id":"c7404c4232a43c3220ffb683513da0700f578de6"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7c4809ed11408a921bc29c7d3425e4de913d6eff","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":123,"context_line":"        _add_common_args(parser)"},{"line_number":124,"context_line":"        utils.add_boolean_argument("},{"line_number":125,"context_line":"            parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state_up\u0027,"},{"line_number":126,"context_line":"            help\u003d_(\u0027Specify the administrative state of the router\u0027"},{"line_number":127,"context_line":"                   \u0027 (True meaning \"Up\")\u0027))"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_1c7a7388","line":125,"updated":"2015-12-09 06:46:04.000000000","message":"IMO, removing an existing parameter would give different user experience. It\u0027s not good to remove it one shot. May be we can deprecate and remove it later.","commit_id":"6bede7e96568c1685e30ff9fd782adb32a9464a4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ccaf31e12053d45e166ac604fc3d38252fb3e403","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":123,"context_line":"        _add_common_args(parser)"},{"line_number":124,"context_line":"        utils.add_boolean_argument("},{"line_number":125,"context_line":"            parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state_up\u0027,"},{"line_number":126,"context_line":"            help\u003d_(\u0027Specify the administrative state of the router\u0027"},{"line_number":127,"context_line":"                   \u0027 (True meaning \"Up\")\u0027))"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_1de34dda","line":125,"in_reply_to":"7a740942_1c7a7388","updated":"2015-12-09 08:16:57.000000000","message":"vikram, you are right. When I commented in the last patch set, --admin-state-down was placed in _add_common_args and I was confused.","commit_id":"6bede7e96568c1685e30ff9fd782adb32a9464a4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d4b344ca8a2c355ad12f90222dc199e176bd2c3e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":123,"context_line":"        _add_common_args(parser)"},{"line_number":124,"context_line":"        utils.add_boolean_argument("},{"line_number":125,"context_line":"            parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state_up\u0027,"},{"line_number":126,"context_line":"            help\u003d_(\u0027Specify the administrative state of the router\u0027"},{"line_number":127,"context_line":"                   \u0027 (True meaning \"Up\")\u0027))"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_6ffbb479","line":125,"in_reply_to":"7a740942_1de34dda","updated":"2015-12-09 08:38:33.000000000","message":"So, should we mark --admin-state-down as deprecated and proceed with --admin-state-up to bring consistency between the Member Update and Update of other Neutron CLIs?","commit_id":"6bede7e96568c1685e30ff9fd782adb32a9464a4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d4b344ca8a2c355ad12f90222dc199e176bd2c3e","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        _add_common_args(parser)"},{"line_number":124,"context_line":"        utils.add_boolean_argument("},{"line_number":125,"context_line":"            parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state_up\u0027,"},{"line_number":126,"context_line":"            help\u003d_(\u0027Specify the administrative state of the router\u0027"},{"line_number":127,"context_line":"                   \u0027 (True meaning \"Up\")\u0027))"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_4fd598e2","line":126,"updated":"2015-12-09 08:38:33.000000000","message":"Sorry, wrong copy","commit_id":"6bede7e96568c1685e30ff9fd782adb32a9464a4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ccaf31e12053d45e166ac604fc3d38252fb3e403","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        _add_common_args(parser)"},{"line_number":124,"context_line":"        utils.add_boolean_argument("},{"line_number":125,"context_line":"            parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state_up\u0027,"},{"line_number":126,"context_line":"            help\u003d_(\u0027Specify the administrative state of the router\u0027"},{"line_number":127,"context_line":"                   \u0027 (True meaning \"Up\")\u0027))"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_5dec75ba","line":126,"updated":"2015-12-09 08:16:57.000000000","message":"router?","commit_id":"6bede7e96568c1685e30ff9fd782adb32a9464a4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ff39cf3c899a376b21a27cc52e140d4250cf60f1","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        _add_common_args(parser)"},{"line_number":124,"context_line":"        utils.add_boolean_argument("},{"line_number":125,"context_line":"            parser, \u0027--admin-state-up\u0027, dest\u003d\u0027admin_state_up\u0027,"},{"line_number":126,"context_line":"            help\u003d_(\u0027Specify the administrative state of the router\u0027"},{"line_number":127,"context_line":"                   \u0027 (True meaning \"Up\")\u0027))"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_8d86f663","line":126,"in_reply_to":"7a740942_4fd598e2","updated":"2015-12-10 02:26:35.000000000","message":"Hi Akihiro, Vikram,\nThe current patch should not change the admin-state-down to admin-state-up, because it is out of scope for this patch.( This concerns just introducing the name field)\n\nBut it is in scope for https://review.openstack.org/255093, so I will be modifying the contents there.","commit_id":"6bede7e96568c1685e30ff9fd782adb32a9464a4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a653057ffb50adabbf503595ad98533788817a66","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \u0027pool\u0027, metavar\u003d\u0027POOL\u0027,"},{"line_number":48,"context_line":"        help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":49,"context_line":"    parser.add_argument("},{"line_number":50,"context_line":"        \u0027--admin-state-down\u0027,"},{"line_number":51,"context_line":"        dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":52,"context_line":"        help\u003d_(\u0027Set admin state up to false\u0027))"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_25e98eb7","line":50,"updated":"2015-12-13 00:43:57.000000000","message":"How can I update admin_state_up to True?","commit_id":"149420a8a55fc61667ef1f4eb431fab5e03fcfee"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"51199f4058b7063c8bc0e3932a04fa4e17dffa88","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \u0027pool\u0027, metavar\u003d\u0027POOL\u0027,"},{"line_number":48,"context_line":"        help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":49,"context_line":"    parser.add_argument("},{"line_number":50,"context_line":"        \u0027--admin-state-down\u0027,"},{"line_number":51,"context_line":"        dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":52,"context_line":"        help\u003d_(\u0027Set admin state up to false\u0027))"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_857402fe","line":50,"in_reply_to":"7a740942_25e98eb7","updated":"2015-12-13 01:17:58.000000000","message":"Hi Akihiro, \nThe problem here is that if I go into modifiying the admin-state-down in this patch, then I need to change the Unit Tests\nThis patch just adds the Name field in the Members and HealthMonitors.\n\nModification of *Create and * Update is being tackled in a separate patch(https://review.openstack.org/255093), where these changes ( the one mentioned here and the admin-state-up mentioned below) would be tackled.\nI did not want to mix them together as the focus of this patch was just to add the Name field.","commit_id":"149420a8a55fc61667ef1f4eb431fab5e03fcfee"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a4a46373da1b59a48658782bca4b5c8e58121239","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        \u0027pool\u0027, metavar\u003d\u0027POOL\u0027,"},{"line_number":48,"context_line":"        help\u003d_(\u0027ID or name of the pool that this member belongs to.\u0027))"},{"line_number":49,"context_line":"    parser.add_argument("},{"line_number":50,"context_line":"        \u0027--admin-state-down\u0027,"},{"line_number":51,"context_line":"        dest\u003d\u0027admin_state\u0027, action\u003d\u0027store_false\u0027,"},{"line_number":52,"context_line":"        help\u003d_(\u0027Set admin state up to false\u0027))"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_41660752","line":50,"in_reply_to":"7a740942_857402fe","updated":"2015-12-13 15:29:31.000000000","message":"If so, I would suggest not to move untouched options. If you touch (including move) related code, it is an usual thing you will receive this kind of comments...\n\nReviewers do not remember the whole contexts, and I wasn\u0027t aware of it either.\n\nIt seems better you focus on just adding \u0027name\u0027 support without touching/moving others.","commit_id":"149420a8a55fc61667ef1f4eb431fab5e03fcfee"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a653057ffb50adabbf503595ad98533788817a66","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.parent_id \u003d _get_pool_id(self.get_client(), parsed_args.pool)"},{"line_number":126,"context_line":"        body \u003d {}"},{"line_number":127,"context_line":"        neutronV20.update_dict(parsed_args, body,"},{"line_number":128,"context_line":"                               [\u0027admin_state_up\u0027, \u0027weight\u0027, \u0027name\u0027])"},{"line_number":129,"context_line":"        return {self.resource: body}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_c5d20a00","line":128,"updated":"2015-12-13 00:43:57.000000000","message":"admin_state_up is not defined in _add_common_args().","commit_id":"149420a8a55fc61667ef1f4eb431fab5e03fcfee"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"21b0163b980fbc1685c47767a23e51dd9514f595","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            \u0027--weight\u0027,"},{"line_number":78,"context_line":"            help\u003d_(\u0027Weight of member in the pool (default:1, [0..256]).\u0027))"},{"line_number":79,"context_line":"        parser.add_argument("},{"line_number":80,"context_line":"            \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":81,"context_line":"            help\u003d_(\u0027Name of the member to be created.\u0027))"},{"line_number":82,"context_line":"        parser.add_argument("},{"line_number":83,"context_line":"            \u0027--subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a710552_e64c3b72","line":80,"updated":"2015-12-16 10:13:07.000000000","message":"ditto","commit_id":"d0d088ab4d800f49927736c11c0451f33df140d5"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"21b0163b980fbc1685c47767a23e51dd9514f595","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            \u0027pool\u0027, metavar\u003d\u0027POOL\u0027,"},{"line_number":128,"context_line":"            help\u003d_(\u0027ID or name of the pool that this member belongs to\u0027))"},{"line_number":129,"context_line":"        parser.add_argument("},{"line_number":130,"context_line":"            \u0027--name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":131,"context_line":"            help\u003d_(\u0027Updated name of the member.\u0027))"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a710552_a675d398","line":130,"updated":"2015-12-16 10:13:07.000000000","message":"ditto","commit_id":"d0d088ab4d800f49927736c11c0451f33df140d5"}],"neutronclient/tests/unit/lb/v2/test_cli20_healthmonitor.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b3bfe780675ca57ff046f25dd6318e06e24f0c44","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                \u0027--expected-codes\u0027, expected_codes, \u0027--url-path\u0027, url_path,"},{"line_number":63,"context_line":"                \u0027--type\u0027, type, \u0027--max-retries\u0027, max_retries,"},{"line_number":64,"context_line":"                \u0027--delay\u0027, delay, \u0027--timeout\u0027, timeout, \u0027--pool\u0027, pool,"},{"line_number":65,"context_line":"                \u0027--name\u0027, name]"},{"line_number":66,"context_line":"        position_names \u003d [\u0027admin_state_up\u0027, \u0027http_method\u0027, \u0027expected_codes\u0027,"},{"line_number":67,"context_line":"                          \u0027url_path\u0027, \u0027type\u0027, \u0027max_retries\u0027, \u0027delay\u0027,"},{"line_number":68,"context_line":"                          \u0027timeout\u0027, \u0027pool_id\u0027, \u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_4109c02b","line":65,"updated":"2015-12-04 03:29:11.000000000","message":"How about testing name update?","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3c3500f0eb17082ed406d6412aa4428061925ab2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                \u0027--expected-codes\u0027, expected_codes, \u0027--url-path\u0027, url_path,"},{"line_number":63,"context_line":"                \u0027--type\u0027, type, \u0027--max-retries\u0027, max_retries,"},{"line_number":64,"context_line":"                \u0027--delay\u0027, delay, \u0027--timeout\u0027, timeout, \u0027--pool\u0027, pool,"},{"line_number":65,"context_line":"                \u0027--name\u0027, name]"},{"line_number":66,"context_line":"        position_names \u003d [\u0027admin_state_up\u0027, \u0027http_method\u0027, \u0027expected_codes\u0027,"},{"line_number":67,"context_line":"                          \u0027url_path\u0027, \u0027type\u0027, \u0027max_retries\u0027, \u0027delay\u0027,"},{"line_number":68,"context_line":"                          \u0027timeout\u0027, \u0027pool_id\u0027, \u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_81a1e8ab","line":65,"in_reply_to":"7a740942_4109c02b","updated":"2015-12-04 03:44:17.000000000","message":"The test case for that was already written by the previous developer (:D)\n\nSee Line#132","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"19f130812a8998559d8fbf57b80195b3d4144bc5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                \u0027--expected-codes\u0027, expected_codes, \u0027--url-path\u0027, url_path,"},{"line_number":63,"context_line":"                \u0027--type\u0027, type, \u0027--max-retries\u0027, max_retries,"},{"line_number":64,"context_line":"                \u0027--delay\u0027, delay, \u0027--timeout\u0027, timeout, \u0027--pool\u0027, pool,"},{"line_number":65,"context_line":"                \u0027--name\u0027, name]"},{"line_number":66,"context_line":"        position_names \u003d [\u0027admin_state_up\u0027, \u0027http_method\u0027, \u0027expected_codes\u0027,"},{"line_number":67,"context_line":"                          \u0027url_path\u0027, \u0027type\u0027, \u0027max_retries\u0027, \u0027delay\u0027,"},{"line_number":68,"context_line":"                          \u0027timeout\u0027, \u0027pool_id\u0027, \u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_035c154a","line":65,"in_reply_to":"7a740942_81a1e8ab","updated":"2015-12-04 09:36:02.000000000","message":"Sorry I missed that. Thanks for correcting me ;)","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"}],"neutronclient/tests/unit/lb/v2/test_cli20_member.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b3bfe780675ca57ff046f25dd6318e06e24f0c44","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        pool_id \u003d \u0027pool-id\u0027"},{"line_number":54,"context_line":"        subnet_id \u003d \u0027subnet-id\u0027"},{"line_number":55,"context_line":"        weight \u003d \u0027100\u0027"},{"line_number":56,"context_line":"        name \u003d \u0027member1\u0027"},{"line_number":57,"context_line":"        args \u003d [\u0027--address\u0027, address, \u0027--protocol-port\u0027, protocol_port,"},{"line_number":58,"context_line":"                \u0027--subnet\u0027, subnet_id, pool_id, \u0027--weight\u0027, weight,"},{"line_number":59,"context_line":"                \u0027--admin-state-down\u0027, \u0027--name\u0027, name]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_21111453","line":56,"updated":"2015-12-04 03:29:11.000000000","message":"How about testing name update?","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"19f130812a8998559d8fbf57b80195b3d4144bc5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        pool_id \u003d \u0027pool-id\u0027"},{"line_number":54,"context_line":"        subnet_id \u003d \u0027subnet-id\u0027"},{"line_number":55,"context_line":"        weight \u003d \u0027100\u0027"},{"line_number":56,"context_line":"        name \u003d \u0027member1\u0027"},{"line_number":57,"context_line":"        args \u003d [\u0027--address\u0027, address, \u0027--protocol-port\u0027, protocol_port,"},{"line_number":58,"context_line":"                \u0027--subnet\u0027, subnet_id, pool_id, \u0027--weight\u0027, weight,"},{"line_number":59,"context_line":"                \u0027--admin-state-down\u0027, \u0027--name\u0027, name]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_c355ad1d","line":56,"in_reply_to":"7a740942_0196584c","updated":"2015-12-04 09:36:02.000000000","message":"Sorry I missed that. Thanks for correcting me ;)","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3c3500f0eb17082ed406d6412aa4428061925ab2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        pool_id \u003d \u0027pool-id\u0027"},{"line_number":54,"context_line":"        subnet_id \u003d \u0027subnet-id\u0027"},{"line_number":55,"context_line":"        weight \u003d \u0027100\u0027"},{"line_number":56,"context_line":"        name \u003d \u0027member1\u0027"},{"line_number":57,"context_line":"        args \u003d [\u0027--address\u0027, address, \u0027--protocol-port\u0027, protocol_port,"},{"line_number":58,"context_line":"                \u0027--subnet\u0027, subnet_id, pool_id, \u0027--weight\u0027, weight,"},{"line_number":59,"context_line":"                \u0027--admin-state-down\u0027, \u0027--name\u0027, name]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_0196584c","line":56,"in_reply_to":"7a740942_21111453","updated":"2015-12-04 03:44:17.000000000","message":"Again, see Line #136.\nI hardly had to write the test cases again :)","commit_id":"71c32dae907cc406068edda15b3264574f35f0fc"}]}