)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a332486294cafedd1e3efd657ffc8daa341e3357","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"APIImpact"},{"line_number":10,"context_line":"Partial-implements: rfe role-based access control for qos policies"},{"line_number":11,"context_line":"Related Blueprint: rbac-qos"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related-bug: #1512587"},{"line_number":14,"context_line":"Depends-On: I1c59073daa181005a3e878bc2fe033a0709fbf31"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5a5ae5dd_c43dfcc4","line":11,"updated":"2016-02-08 13:07:32.000000000","message":"Add release notes.","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f9af10b66a1120a4ff8a34d9c5cf9d80b5a1807f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     787bd92e (Merge \"Add DNS integration support to the client\")"},{"line_number":2,"context_line":"Author:     Haim Daniel \u003chdaniel@redhat.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2015-11-08 13:20:45 +0200"},{"line_number":4,"context_line":"Commit:     Haim Daniel \u003chdaniel@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9aed3d3a_8957b401","line":1,"updated":"2016-02-26 10:17:34.000000000","message":"vikram suggested before we should add release notes. Should we?","commit_id":"4728a3dd2a81e3e4ee395950ad076304cdc0b7ca"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"c0ad9d14cd300b966a9da3b4f5a5c585d3a916da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     787bd92e (Merge \"Add DNS integration support to the client\")"},{"line_number":2,"context_line":"Author:     Haim Daniel \u003chdaniel@redhat.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2015-11-08 13:20:45 +0200"},{"line_number":4,"context_line":"Commit:     Haim Daniel \u003chdaniel@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9aed3d3a_81646d22","line":1,"in_reply_to":"9aed3d3a_56a8a41f","updated":"2016-02-27 18:05:30.000000000","message":"Done.","commit_id":"4728a3dd2a81e3e4ee395950ad076304cdc0b7ca"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"eab496f04ff80064803cbe1e8776661ed21403fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     787bd92e (Merge \"Add DNS integration support to the client\")"},{"line_number":2,"context_line":"Author:     Haim Daniel \u003chdaniel@redhat.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2015-11-08 13:20:45 +0200"},{"line_number":4,"context_line":"Commit:     Haim Daniel \u003chdaniel@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9aed3d3a_56a8a41f","line":1,"in_reply_to":"9aed3d3a_8957b401","updated":"2016-02-26 11:30:12.000000000","message":"It\u0027s good to have it as it\u0027s after all a new feature we will be going to add in Mitaka.\n\nhttps://github.com/openstack/python-neutronclient/tree/master/releasenotes/notes","commit_id":"4728a3dd2a81e3e4ee395950ad076304cdc0b7ca"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"4a3d924edeabbf1c0d9021abedf203536c10419c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"APIImpact"},{"line_number":10,"context_line":"Partial-implements: rfe role-based access control for qos policies"},{"line_number":11,"context_line":"Related Blueprint: rbac-qos"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related-bug: #1512587"},{"line_number":14,"context_line":"Depends-On: I1c59073daa181005a3e878bc2fe033a0709fbf31"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"9aed3d3a_eea8aa79","line":11,"updated":"2016-02-29 08:33:34.000000000","message":"Note( only for future references): IIRC there is no tag for Related Blueprints yet :)","commit_id":"b667b32af4a8b635cbe3f5a3fa8a231b6114a138"}],"neutronclient/neutron/v2_0/rbac.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"988b0f6e322c00b25036a91083507a8b36292cfa","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutronclient.i18n import _"},{"line_number":17,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# k\u003dobject_type: v\u003d{k\u003dresource, v\u003dcmd_resource}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_727bc67b","line":16,"updated":"2016-02-07 11:27:55.000000000","message":"please dont revert the _i18n changes, given in the Base patch","commit_id":"41d2c2601c44fe97b8ecc4ad2fff6c94491d0f8a"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"49f1cc8934acf7971e8a3c9215cf8f12820e7810","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutronclient.i18n import _"},{"line_number":17,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# k\u003dobject_type: v\u003d{k\u003dresource, v\u003dcmd_resource}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_494ffc36","line":16,"in_reply_to":"5a5ae5dd_727bc67b","updated":"2016-02-07 15:42:59.000000000","message":"Done","commit_id":"41d2c2601c44fe97b8ecc4ad2fff6c94491d0f8a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6aacfd155b61799d47091f52c52c29c74ea2d78a","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# k\u003dobject_type: v\u003d{k\u003dresource, v\u003dcmd_resource}"},{"line_number":20,"context_line":"RBAC_OBJECTS \u003d {\u0027network\u0027: {\u0027network\u0027: \u0027network\u0027},"},{"line_number":21,"context_line":"                \u0027qos-policy\u0027: {\u0027policy\u0027: \u0027qos_policy\u0027}}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def _get_cmd_resource(obj_type):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_7e4dba98","line":21,"range":{"start_line":21,"start_character":21,"end_line":21,"end_character":27},"updated":"2016-02-08 12:29:31.000000000","message":"No strong opinion here, just an idea:\nwhat do you think about simplifying qos-policy/qos_policy and just accepting qos_policy on the command line?","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"c5e3eaee4b44eace44502e7c604dd4863d3a7f85","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# k\u003dobject_type: v\u003d{k\u003dresource, v\u003dcmd_resource}"},{"line_number":20,"context_line":"RBAC_OBJECTS \u003d {\u0027network\u0027: {\u0027network\u0027: \u0027network\u0027},"},{"line_number":21,"context_line":"                \u0027qos-policy\u0027: {\u0027policy\u0027: \u0027qos_policy\u0027}}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def _get_cmd_resource(obj_type):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_b9058c14","line":21,"range":{"start_line":21,"start_character":21,"end_line":21,"end_character":27},"in_reply_to":"5a5ae5dd_7e4dba98","updated":"2016-02-08 13:09:48.000000000","message":"That would actually make dev life more simple, but wouldn\u0027t that break any conventions for cli arguments ?","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ddd838b9f7265624b568d2e8078520933bd31132","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def _get_cmd_resource(obj_type):"},{"line_number":25,"context_line":"    resource \u003d list(RBAC_OBJECTS[obj_type])[0]"},{"line_number":26,"context_line":"    cmd_resource \u003d RBAC_OBJECTS[obj_type][resource]"},{"line_number":27,"context_line":"    return resource, cmd_resource"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_e1110a53","line":25,"updated":"2016-02-08 12:54:42.000000000","message":"If I get it right, you will receive \u0027n\u0027 for \u0027network\u0027 here, and \u0027q\u0027 for \u0027qos-policy\u0027, which is probably not what you want.\n\nI suspect tests don\u0027t fail because CLITestV20Base mocks out find_resourceid_by_name_or_id and does not check the passed args.\n\nPlease add unit tests that target these functions to make sure we don\u0027t sneak in a bug.","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"72a4126711d53c28c3630fbe71b686462966f9ac","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def _get_cmd_resource(obj_type):"},{"line_number":25,"context_line":"    resource \u003d list(RBAC_OBJECTS[obj_type])[0]"},{"line_number":26,"context_line":"    cmd_resource \u003d RBAC_OBJECTS[obj_type][resource]"},{"line_number":27,"context_line":"    return resource, cmd_resource"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_b0003a03","line":25,"in_reply_to":"5a5ae5dd_e10a6a25","updated":"2016-02-08 14:26:41.000000000","message":"OK, I interpreted local python output wrong. Thanks for checking.","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"c5e3eaee4b44eace44502e7c604dd4863d3a7f85","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def _get_cmd_resource(obj_type):"},{"line_number":25,"context_line":"    resource \u003d list(RBAC_OBJECTS[obj_type])[0]"},{"line_number":26,"context_line":"    cmd_resource \u003d RBAC_OBJECTS[obj_type][resource]"},{"line_number":27,"context_line":"    return resource, cmd_resource"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_e10a6a25","line":25,"in_reply_to":"5a5ae5dd_e1110a53","updated":"2016-02-08 13:09:48.000000000","message":"No, I receive the RBAC_OBJECTS key value here - and that is the exact reason why the tests pass :)","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6aacfd155b61799d47091f52c52c29c74ea2d78a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def get_rbac_obj_params(client, obj_type, obj_id_or_name):"},{"line_number":31,"context_line":"    rsrc, cmd_rsrc \u003d _get_cmd_resource(obj_type)"},{"line_number":32,"context_line":"    obj_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":33,"context_line":"        client\u003dclient, resource\u003drsrc, name_or_id\u003dobj_id_or_name,"},{"line_number":34,"context_line":"        cmd_resource\u003dcmd_rsrc)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_3e0bc27e","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":8},"updated":"2016-02-08 12:29:31.000000000","message":"meganit: I\u0027d use resource instead of \"rsrc\" and \"cmd_rsrc\" which are cryptic :)","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ddd838b9f7265624b568d2e8078520933bd31132","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def get_rbac_obj_params(client, obj_type, obj_id_or_name):"},{"line_number":31,"context_line":"    rsrc, cmd_rsrc \u003d _get_cmd_resource(obj_type)"},{"line_number":32,"context_line":"    obj_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":33,"context_line":"        client\u003dclient, resource\u003drsrc, name_or_id\u003dobj_id_or_name,"},{"line_number":34,"context_line":"        cmd_resource\u003dcmd_rsrc)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_f928e49b","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":8},"in_reply_to":"5a5ae5dd_3e0bc27e","updated":"2016-02-08 12:54:42.000000000","message":"+1","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"c5e3eaee4b44eace44502e7c604dd4863d3a7f85","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def get_rbac_obj_params(client, obj_type, obj_id_or_name):"},{"line_number":31,"context_line":"    rsrc, cmd_rsrc \u003d _get_cmd_resource(obj_type)"},{"line_number":32,"context_line":"    obj_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":33,"context_line":"        client\u003dclient, resource\u003drsrc, name_or_id\u003dobj_id_or_name,"},{"line_number":34,"context_line":"        cmd_resource\u003dcmd_rsrc)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_41025e0b","line":31,"range":{"start_line":31,"start_character":4,"end_line":31,"end_character":8},"in_reply_to":"5a5ae5dd_3e0bc27e","updated":"2016-02-08 13:09:48.000000000","message":"Done","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a332486294cafedd1e3efd657ffc8daa341e3357","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \"\"\"List RBAC policies that belong to a given tenant.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    resource \u003d \u0027rbac_policy\u0027"},{"line_number":43,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027object_id\u0027]"},{"line_number":44,"context_line":"    pagination_support \u003d True"},{"line_number":45,"context_line":"    sorting_support \u003d True"},{"line_number":46,"context_line":"    allow_names \u003d False"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_44ecac29","line":43,"updated":"2016-02-08 13:07:32.000000000","message":"How about adding type now as we can have multiple rbac object types.","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"0d71d227aba6057c088ddc16bef88a2890c6b2e4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \"\"\"List RBAC policies that belong to a given tenant.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    resource \u003d \u0027rbac_policy\u0027"},{"line_number":43,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027object_id\u0027]"},{"line_number":44,"context_line":"    pagination_support \u003d True"},{"line_number":45,"context_line":"    sorting_support \u003d True"},{"line_number":46,"context_line":"    allow_names \u003d False"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_757f14e0","line":43,"in_reply_to":"5a5ae5dd_24289032","updated":"2016-02-08 14:03:24.000000000","message":"Come to think about - that can come handy :)\nwill do that - thanks !","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"fac3dce8ed88eb71b8b35aa57d5f10d2e3c15939","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \"\"\"List RBAC policies that belong to a given tenant.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    resource \u003d \u0027rbac_policy\u0027"},{"line_number":43,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027object_id\u0027]"},{"line_number":44,"context_line":"    pagination_support \u003d True"},{"line_number":45,"context_line":"    sorting_support \u003d True"},{"line_number":46,"context_line":"    allow_names \u003d False"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_24289032","line":43,"in_reply_to":"5a5ae5dd_44ecac29","updated":"2016-02-08 13:11:32.000000000","message":"I can add it, though as a separate patch set.","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"151928c4c20cb6c691f008b9d031c4d9cf7e3c93","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutronclient._i18n import _"},{"line_number":17,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# k\u003dobject_type: v\u003d{k\u003dresource, v\u003dcmd_resource}"},{"line_number":20,"context_line":"RBAC_OBJECTS \u003d {\u0027network\u0027: {\u0027network\u0027: \u0027network\u0027},"},{"line_number":21,"context_line":"                \u0027qos-policy\u0027: {\u0027policy\u0027: \u0027qos_policy\u0027}}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_4fa3199f","line":19,"updated":"2016-02-19 13:40:21.000000000","message":"In the comment, it is better to use non-abbrev vesion of strings:\nk -\u003e key, v -\u003e value","commit_id":"43c567f4d333eccb147c6659388ea56df0b5e8ad"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"43c8fa6f6b71ad1944c157f40cee1ad0570a7ade","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutronclient._i18n import _"},{"line_number":17,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# k\u003dobject_type: v\u003d{k\u003dresource, v\u003dcmd_resource}"},{"line_number":20,"context_line":"RBAC_OBJECTS \u003d {\u0027network\u0027: {\u0027network\u0027: \u0027network\u0027},"},{"line_number":21,"context_line":"                \u0027qos-policy\u0027: {\u0027policy\u0027: \u0027qos_policy\u0027}}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_1f4c66c6","line":19,"in_reply_to":"bae84128_4fa3199f","updated":"2016-02-20 15:41:23.000000000","message":"Done","commit_id":"43c567f4d333eccb147c6659388ea56df0b5e8ad"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"151928c4c20cb6c691f008b9d031c4d9cf7e3c93","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \"\"\"List RBAC policies that belong to a given tenant.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    resource \u003d \u0027rbac_policy\u0027"},{"line_number":43,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027object_id\u0027, \u0027object_type\u0027]"},{"line_number":44,"context_line":"    pagination_support \u003d True"},{"line_number":45,"context_line":"    sorting_support \u003d True"},{"line_number":46,"context_line":"    allow_names \u003d False"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_0fe751e5","line":43,"updated":"2016-02-19 13:40:21.000000000","message":"how about the order of id, object_type and object_id?","commit_id":"43c567f4d333eccb147c6659388ea56df0b5e8ad"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"43c8fa6f6b71ad1944c157f40cee1ad0570a7ade","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \"\"\"List RBAC policies that belong to a given tenant.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    resource \u003d \u0027rbac_policy\u0027"},{"line_number":43,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027object_id\u0027, \u0027object_type\u0027]"},{"line_number":44,"context_line":"    pagination_support \u003d True"},{"line_number":45,"context_line":"    sorting_support \u003d True"},{"line_number":46,"context_line":"    allow_names \u003d False"}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_5fcc2e35","line":43,"in_reply_to":"bae84128_0fe751e5","updated":"2016-02-20 15:41:23.000000000","message":"Done","commit_id":"43c567f4d333eccb147c6659388ea56df0b5e8ad"}],"neutronclient/tests/unit/test_cli20_rbac.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ddd838b9f7265624b568d2e8078520933bd31132","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import abc"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutronclient.neutron.v2_0 import rbac"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_21df223b","line":17,"updated":"2016-02-08 12:54:42.000000000","message":"nit: six is 3party, belongs to a separate import section.","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"c5e3eaee4b44eace44502e7c604dd4863d3a7f85","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import abc"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutronclient.neutron.v2_0 import rbac"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_24cc10ba","line":17,"in_reply_to":"5a5ae5dd_21df223b","updated":"2016-02-08 13:09:48.000000000","message":"Done","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"1e396601189ca4ea8e2cca7e0f55bcebd1ffb257","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutronclient.tests.unit import test_cli20"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":25,"context_line":"class CLITestV20RBACBaseJSON(test_cli20.CLITestV20Base):"},{"line_number":26,"context_line":"    \"\"\"Base class for sharing RBAC tests."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_d98ac863","line":24,"range":{"start_line":24,"start_character":23,"end_line":24,"end_character":30},"updated":"2016-02-08 12:33:41.000000000","message":"This entire logic can still work with inheritance - there is no need to use metaclasses here. Use setUp() to check if the variables are None and if so skipTest()","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"c5e3eaee4b44eace44502e7c604dd4863d3a7f85","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutronclient.tests.unit import test_cli20"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":25,"context_line":"class CLITestV20RBACBaseJSON(test_cli20.CLITestV20Base):"},{"line_number":26,"context_line":"    \"\"\"Base class for sharing RBAC tests."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_245ad0f2","line":24,"range":{"start_line":24,"start_character":23,"end_line":24,"end_character":30},"in_reply_to":"5a5ae5dd_41ec9e29","updated":"2016-02-08 13:09:48.000000000","message":"I admit it - it grew over me :)\n\nSo should we keep that here to your opinion ?","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"c64cbb1a3f997b00945be25c09a5e8cde545f575","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutronclient.tests.unit import test_cli20"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":25,"context_line":"class CLITestV20RBACBaseJSON(test_cli20.CLITestV20Base):"},{"line_number":26,"context_line":"    \"\"\"Base class for sharing RBAC tests."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_a4c24051","line":24,"range":{"start_line":24,"start_character":23,"end_line":24,"end_character":30},"in_reply_to":"5a5ae5dd_81a93626","updated":"2016-02-08 13:12:35.000000000","message":"I\u0027m fine with that. When I run test suites I don\u0027t remember beforehand how many expected passes I should have - all I care about is that no tests failed.","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ddd838b9f7265624b568d2e8078520933bd31132","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutronclient.tests.unit import test_cli20"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":25,"context_line":"class CLITestV20RBACBaseJSON(test_cli20.CLITestV20Base):"},{"line_number":26,"context_line":"    \"\"\"Base class for sharing RBAC tests."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_41ec9e29","line":24,"range":{"start_line":24,"start_character":23,"end_line":24,"end_character":30},"in_reply_to":"5a5ae5dd_d98ac863","updated":"2016-02-08 12:54:42.000000000","message":":) Once you try metaclasses once, you continue applying them everywhere. That suggests they are so awesome you just can\u0027t resist.","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"c5e3eaee4b44eace44502e7c604dd4863d3a7f85","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutronclient.tests.unit import test_cli20"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":25,"context_line":"class CLITestV20RBACBaseJSON(test_cli20.CLITestV20Base):"},{"line_number":26,"context_line":"    \"\"\"Base class for sharing RBAC tests."},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_81a93626","line":24,"range":{"start_line":24,"start_character":23,"end_line":24,"end_character":30},"in_reply_to":"5a5ae5dd_d98ac863","updated":"2016-02-08 13:09:48.000000000","message":"Wouldn\u0027t skipTest() result in ambiguous tests\u0027 result output \ne.g.\npassed: 20\nskipped: 10 \n\netc ...  ?\n\nWhile with the metaclass solution that output would be simple passed: 20","commit_id":"51edeb41f8fff68c3744a9718645440efc1763a6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"151928c4c20cb6c691f008b9d031c4d9cf7e3c93","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutronclient.tests.unit import test_cli20"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":26,"context_line":"class CLITestV20RBACBaseJSON(test_cli20.CLITestV20Base):"},{"line_number":27,"context_line":"    \"\"\"Base class for sharing RBAC tests."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_8ffc0140","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":31},"updated":"2016-02-19 13:40:21.000000000","message":"Do you really need to use ABCMeta?\nHow about using testscenarios instead?\n\n  import testscenarios\n\n  load_tests \u003d testscenarios.load_tests_apply_scenarios\n\n  class CLITestV20RBAC(test_cli20.CLITestV20Base):\n      scenarios \u003d [\n            (\u0027network\u0027: {\u0027object_type_name\u0027: \u0027network\u0027,\n                         \u0027object_type_val\u0027: \u0027network\u0027}),\n            (\u0027qos\u0027: {\u0027object_type_name\u0027: \u0027qos-policy\u0027,\n                         \u0027object_type_val\u0027: \u0027qos_policy\u0027}),\n            ...\n      ]\n\n      \u003cwrite tests as usual\u003e\n\nWe can refer to object_type_name/val from each test\nas self.object_type_name/val.\nI think the diff would be much smaller.\n\nIf you are okay, I can refactor this for you.","commit_id":"43c567f4d333eccb147c6659388ea56df0b5e8ad"},{"author":{"_account_id":18485,"name":"Haim Daniel","email":"hdaniel@redhat.com","username":"hdaniel"},"change_message_id":"43c8fa6f6b71ad1944c157f40cee1ad0570a7ade","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutronclient.tests.unit import test_cli20"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":26,"context_line":"class CLITestV20RBACBaseJSON(test_cli20.CLITestV20Base):"},{"line_number":27,"context_line":"    \"\"\"Base class for sharing RBAC tests."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bae84128_ba0f48e0","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":31},"in_reply_to":"bae84128_8ffc0140","updated":"2016-02-20 15:41:23.000000000","message":"Done","commit_id":"43c567f4d333eccb147c6659388ea56df0b5e8ad"}]}
