)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"268ae382e2e1f3fe6352029eb94b24158ceb02c1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Property \u0027session-persistence\u0027 can be configured on VIP,"},{"line_number":10,"context_line":"this change add --session-persistence option to lb-vip-create CLI,"},{"line_number":11,"context_line":"allow user to use session-persistence explicitly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Babu Shanmugam \u003canbu@enovance.com\u003e"},{"line_number":14,"context_line":"(cherry picked from commit I766ad88b51ab241331fa869a61779659180b7d07)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_797ef4e5","line":11,"updated":"2015-12-04 06:33:48.000000000","message":"user -\u003eusers","commit_id":"6942a3654cac5e01834cd27447e056e4c6aaaae8"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"d55bf4468fc3ef96eb73126f07e5acfad14ee2a0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Property \u0027session-persistence\u0027 can be configured on VIP,"},{"line_number":10,"context_line":"this change add --session-persistence option to lb-vip-create CLI,"},{"line_number":11,"context_line":"allow user to use session-persistence explicitly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Babu Shanmugam \u003canbu@enovance.com\u003e"},{"line_number":14,"context_line":"(cherry picked from commit I766ad88b51ab241331fa869a61779659180b7d07)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a740942_b97e9cac","line":11,"in_reply_to":"7a740942_797ef4e5","updated":"2015-12-04 06:53:54.000000000","message":"Done","commit_id":"6942a3654cac5e01834cd27447e056e4c6aaaae8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"88b18f7f4cda02133d44146de5cd36d293c5e5a3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"allow users to use session-persistence explicitly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Babu Shanmugam \u003canbu@enovance.com\u003e"},{"line_number":14,"context_line":"(cherry picked from commit I766ad88b51ab241331fa869a61779659180b7d07)"},{"line_number":15,"context_line":"Closes-Bug: #1259504"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I52b83f85122386ff7eb12995dd874d1082c28fdb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7a740942_858de27d","line":14,"updated":"2015-12-12 23:47:55.000000000","message":"The mentioned commit ID is a commit hash of the abandoned review and it is not merged. In this case it is better to mention the review URL instead of referring to the commit ID.\n\n  It resumes the work of https://review.openstack.org/#/c/197877/\n\nor\n\n  Based on the work of https://review.openstack.org/#/c/197877/","commit_id":"075ed0c5f6f07eb07773e55659b767fb64e776dd"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"bd5c340df2b14b159244861b0cbe202d95b2ef96","unresolved":false,"context_lines":[{"line_number":11,"context_line":"allow users to use session-persistence explicitly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Babu Shanmugam \u003canbu@enovance.com\u003e"},{"line_number":14,"context_line":"(cherry picked from commit I766ad88b51ab241331fa869a61779659180b7d07)"},{"line_number":15,"context_line":"Closes-Bug: #1259504"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I52b83f85122386ff7eb12995dd874d1082c28fdb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7a740942_457a8c25","line":14,"in_reply_to":"7a740942_858de27d","updated":"2015-12-14 02:50:46.000000000","message":"Done","commit_id":"075ed0c5f6f07eb07773e55659b767fb64e776dd"}],"neutronclient/neutron/v2_0/lb/vip.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"268ae382e2e1f3fe6352029eb94b24158ceb02c1","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            metavar\u003d\u0027type\u003dTYPE[,cookie_name\u003dCOOKIE_NAME]\u0027,"},{"line_number":81,"context_line":"            choices\u003d[\u0027HTTP_COOKIE\u0027, \u0027APP_COOKIE\u0027, \u0027SOURCE_IP\u0027],"},{"line_number":82,"context_line":"            help\u003d_(\u0027The type of session persistence to use and associated \u0027"},{"line_number":83,"context_line":"                   \u0027cookie name\u0027))"},{"line_number":84,"context_line":"    def args2body(self, parsed_args):"},{"line_number":85,"context_line":"        _pool_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":86,"context_line":"            self.get_client(), \u0027pool\u0027, parsed_args.pool_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_5960d835","line":83,"updated":"2015-12-04 06:33:48.000000000","message":"Rewording suggested :   and ´the´ associated cookie name (fullstop)","commit_id":"6942a3654cac5e01834cd27447e056e4c6aaaae8"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"d55bf4468fc3ef96eb73126f07e5acfad14ee2a0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            metavar\u003d\u0027type\u003dTYPE[,cookie_name\u003dCOOKIE_NAME]\u0027,"},{"line_number":81,"context_line":"            choices\u003d[\u0027HTTP_COOKIE\u0027, \u0027APP_COOKIE\u0027, \u0027SOURCE_IP\u0027],"},{"line_number":82,"context_line":"            help\u003d_(\u0027The type of session persistence to use and associated \u0027"},{"line_number":83,"context_line":"                   \u0027cookie name\u0027))"},{"line_number":84,"context_line":"    def args2body(self, parsed_args):"},{"line_number":85,"context_line":"        _pool_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":86,"context_line":"            self.get_client(), \u0027pool\u0027, parsed_args.pool_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_5c0526c0","line":83,"in_reply_to":"7a740942_5960d835","updated":"2015-12-04 06:53:54.000000000","message":"Done","commit_id":"6942a3654cac5e01834cd27447e056e4c6aaaae8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"268ae382e2e1f3fe6352029eb94b24158ceb02c1","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        if parsed_args.session_persistence:"},{"line_number":95,"context_line":"            body.update("},{"line_number":96,"context_line":"                {\"session_persistence\": utils.str2dict("},{"line_number":97,"context_line":"                    parsed_args.session_persistence)})"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        neutronV20.update_dict(parsed_args, body,"},{"line_number":100,"context_line":"                               [\u0027address\u0027, \u0027connection_limit\u0027, \u0027description\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_d96da833","line":97,"updated":"2015-12-04 06:33:48.000000000","message":"I guess you can add session_persistence to the neutronV20.update_dict given below","commit_id":"6942a3654cac5e01834cd27447e056e4c6aaaae8"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"d55bf4468fc3ef96eb73126f07e5acfad14ee2a0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        if parsed_args.session_persistence:"},{"line_number":95,"context_line":"            body.update("},{"line_number":96,"context_line":"                {\"session_persistence\": utils.str2dict("},{"line_number":97,"context_line":"                    parsed_args.session_persistence)})"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        neutronV20.update_dict(parsed_args, body,"},{"line_number":100,"context_line":"                               [\u0027address\u0027, \u0027connection_limit\u0027, \u0027description\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_fcf652d6","line":97,"in_reply_to":"7a740942_d96da833","updated":"2015-12-04 06:53:54.000000000","message":"neutronV20.update_dict did not do str2dict.","commit_id":"6942a3654cac5e01834cd27447e056e4c6aaaae8"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"e5798819a55c2e03d101ee72915e3c9f83e41ad3","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            help\u003d_(\u0027The subnet on which to allocate the vip address.\u0027))"},{"line_number":78,"context_line":"        parser.add_argument("},{"line_number":79,"context_line":"            \u0027--session-persistence\u0027,"},{"line_number":80,"context_line":"            metavar\u003d\u0027type\u003dTYPE, [cookie_name\u003dCOOKIE_NAME]\u0027,"},{"line_number":81,"context_line":"            help\u003d_(\u0027The type of session persistence to use and the associated \u0027"},{"line_number":82,"context_line":"                   \u0027cookie name. Allowed type: HTTP_COOKIE, \u0027"},{"line_number":83,"context_line":"                   \u0027APP_COOKIE, SOURCE_IP.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_002ab22c","line":80,"updated":"2015-12-04 16:44:52.000000000","message":"The test doesn\u0027t use a space after comma.  Also, please add a unit test for not including cookie_name.  In such case, I assume that the trailing comma is not necessary but seems to be required from this argument metavar.","commit_id":"b73362652a93070d557e9dc4f73a23eb9f924d46"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"e48453e7782b9cf38f7f31cfa1ccf70949ba260b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            help\u003d_(\u0027The subnet on which to allocate the vip address.\u0027))"},{"line_number":78,"context_line":"        parser.add_argument("},{"line_number":79,"context_line":"            \u0027--session-persistence\u0027,"},{"line_number":80,"context_line":"            metavar\u003d\u0027type\u003dTYPE, [cookie_name\u003dCOOKIE_NAME]\u0027,"},{"line_number":81,"context_line":"            help\u003d_(\u0027The type of session persistence to use and the associated \u0027"},{"line_number":82,"context_line":"                   \u0027cookie name. Allowed type: HTTP_COOKIE, \u0027"},{"line_number":83,"context_line":"                   \u0027APP_COOKIE, SOURCE_IP.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_85ce8db2","line":80,"in_reply_to":"7a740942_002ab22c","updated":"2015-12-07 01:15:45.000000000","message":"Done","commit_id":"b73362652a93070d557e9dc4f73a23eb9f924d46"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fc27d06becd07e9bf95de5f1c0c55e741d390f87","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                \u0027admin_state_up\u0027: parsed_args.admin_state,"},{"line_number":93,"context_line":"                \u0027subnet_id\u0027: _subnet_id}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if parsed_args.session_persistence:"},{"line_number":96,"context_line":"            body.update("},{"line_number":97,"context_line":"                {\"session_persistence\": utils.str2dict("},{"line_number":98,"context_line":"                    parsed_args.session_persistence)})"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_bb1e4961","line":95,"updated":"2015-12-07 05:31:41.000000000","message":"I think we can follow as done in \n\nhttps://review.openstack.org/#/c/253878/1/neutronclient/neutron/v2_0/lb/v2/pool.py","commit_id":"fee0b6221a68eb2f788eabb43c54d168c12ae6d0"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"8bd0eb02886ade1532d7f82c4e26602025681f4b","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                \u0027admin_state_up\u0027: parsed_args.admin_state,"},{"line_number":93,"context_line":"                \u0027subnet_id\u0027: _subnet_id}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if parsed_args.session_persistence:"},{"line_number":96,"context_line":"            body.update("},{"line_number":97,"context_line":"                {\"session_persistence\": utils.str2dict("},{"line_number":98,"context_line":"                    parsed_args.session_persistence)})"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_3bd259d3","line":95,"updated":"2015-12-07 06:06:42.000000000","message":"Plz address PS6 comment.","commit_id":"1891e80ea9f411e3cd13abc6ed3389ffe040f48c"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"56c93183c94b541ab55f8f7bc71fe898967d5995","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                \u0027admin_state_up\u0027: parsed_args.admin_state,"},{"line_number":93,"context_line":"                \u0027subnet_id\u0027: _subnet_id}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if parsed_args.session_persistence:"},{"line_number":96,"context_line":"            body.update("},{"line_number":97,"context_line":"                {\"session_persistence\": utils.str2dict("},{"line_number":98,"context_line":"                    parsed_args.session_persistence)})"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_57021fb5","line":95,"in_reply_to":"7a740942_0d0cb839","updated":"2015-12-09 01:10:31.000000000","message":"How can I rebase my change up to that change ?\n\nI fetched https://review.openstack.org/#/c/253878/1, and create a branch for it in my local, and I rebase my change to it, but when I run git review, I get :\n\nYou are about to submit multiple commits. This is expected if you are\nsubmitting a commit that is dependent on one or more in-review\ncommits. Otherwise you should consider squashing your changes into one\ncommit before submitting.\n\nThe outstanding commits are:\n\nd33b347 (HEAD, bug-1259504) Add --session-persistence for lb-vip-create\ndda8438 (master) Improve str2dict key validation to avoid wrong keys\n\nDo you really want to submit the above commits?\nType \u0027yes\u0027 to confirm, other to cancel: yes\nPassword for \u0027https://chen-li@review.openstack.org:443\u0027: \nremote: Resolving deltas: 100% (10/10)\nremote: Processing changes: refs: 1, done    \nremote: (W) No changes between prior commit f7db664 and new commit dda8438\nTo https://chen-li@review.openstack.org:443/openstack/python-neutronclient.git\n ! [remote rejected] HEAD -\u003e refs/publish/master/bug/1259504 (no changes made)\nerror: failed to push some refs to \u0027https://chen-li@review.openstack.org:443/openstack/python-neutronclient.git\u0027","commit_id":"1891e80ea9f411e3cd13abc6ed3389ffe040f48c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e56a4e74337abf7a823bca5195116430e186e469","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                \u0027admin_state_up\u0027: parsed_args.admin_state,"},{"line_number":93,"context_line":"                \u0027subnet_id\u0027: _subnet_id}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if parsed_args.session_persistence:"},{"line_number":96,"context_line":"            body.update("},{"line_number":97,"context_line":"                {\"session_persistence\": utils.str2dict("},{"line_number":98,"context_line":"                    parsed_args.session_persistence)})"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_0d0cb839","line":95,"in_reply_to":"7a740942_3bd259d3","updated":"2015-12-08 09:42:09.000000000","message":"Yes, I hope so.","commit_id":"1891e80ea9f411e3cd13abc6ed3389ffe040f48c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ea6442d37d12249321028327f2d68b7f77de3012","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                \u0027admin_state_up\u0027: parsed_args.admin_state,"},{"line_number":93,"context_line":"                \u0027subnet_id\u0027: _subnet_id}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if parsed_args.session_persistence:"},{"line_number":96,"context_line":"            body.update("},{"line_number":97,"context_line":"                {\"session_persistence\": utils.str2dict("},{"line_number":98,"context_line":"                    parsed_args.session_persistence)})"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_3a7ada88","line":95,"in_reply_to":"7a740942_57021fb5","updated":"2015-12-09 01:51:32.000000000","message":"Also, if you do this change , this if condition would not be required, you can use session_persistence in the update_dict itself","commit_id":"1891e80ea9f411e3cd13abc6ed3389ffe040f48c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8e2f2428c57228f689688c29162fd6eeba9dff93","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        parser.add_argument("},{"line_number":79,"context_line":"            \u0027--session-persistence\u0027,"},{"line_number":80,"context_line":"            metavar\u003d\u0027type\u003dTYPE[,cookie_name\u003dCOOKIE_NAME]\u0027,"},{"line_number":81,"context_line":"            type\u003dutils.str2dict_type(valid_keys\u003d[\u0027type\u0027, \u0027cookie_name\u0027],"},{"line_number":82,"context_line":"                                     required_keys\u003d[\u0027type\u0027]),"},{"line_number":83,"context_line":"            help\u003d_(\u0027The type of session persistence to use and the associated \u0027"},{"line_number":84,"context_line":"                   \u0027cookie name. Allowed type: HTTP_COOKIE, \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aed3d3a_21b9ca15","line":81,"updated":"2016-03-01 03:08:22.000000000","message":"This changed to required_keys and Optional_keys once https://review.openstack.org/#/c/253878/9/neutronclient/common/utils.py was merged!","commit_id":"404065b139226aae70f0c648873aab883365e50c"}],"neutronclient/tests/unit/lb/test_cli20_vip.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ba3169b0e64f8b60f1a42f5f75e0ae2d277a594a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                                   position_names, position_values,"},{"line_number":116,"context_line":"                                   admin_state_up\u003dTrue)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_create_vip_with_session_persistence_params_with_cookie_name(self):"},{"line_number":119,"context_line":"        \"\"\"lb-vip-create with mandatory and session-persistence params.\"\"\""},{"line_number":120,"context_line":"        resource \u003d \u0027vip\u0027"},{"line_number":121,"context_line":"        cmd \u003d vip.CreateVip(test_cli20.MyApp(sys.stdout), None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_2b660a2a","line":118,"updated":"2015-12-09 03:47:49.000000000","message":"IMO, cookie name could be added to \"test_create_vip_with_session_persistence_params\" and there is no need to have a new testcase.","commit_id":"c04d5dca36b677460e0bdde620e4e691cfab28d4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"74966fb7b403a6ee89597f1cf5ba80e503be95e1","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                                   position_names, position_values,"},{"line_number":116,"context_line":"                                   admin_state_up\u003dTrue)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_create_vip_with_session_persistence_params_with_cookie_name(self):"},{"line_number":119,"context_line":"        \"\"\"lb-vip-create with mandatory and session-persistence params.\"\"\""},{"line_number":120,"context_line":"        resource \u003d \u0027vip\u0027"},{"line_number":121,"context_line":"        cmd \u003d vip.CreateVip(test_cli20.MyApp(sys.stdout), None)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_26295f8a","line":118,"in_reply_to":"7a740942_2b660a2a","updated":"2015-12-09 03:52:23.000000000","message":"Yeah, I guess you are right...","commit_id":"c04d5dca36b677460e0bdde620e4e691cfab28d4"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d1157ebba28cd71e87403eefe0fae4fcee628c8c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                   admin_state_up\u003dTrue)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        # test session persistence with cokkie name"},{"line_number":119,"context_line":"        args \u003d [\u0027--name\u0027, name,"},{"line_number":120,"context_line":"                \u0027--protocol-port\u0027, protocol_port,"},{"line_number":121,"context_line":"                \u0027--protocol\u0027, protocol,"},{"line_number":122,"context_line":"                \u0027--subnet-id\u0027, subnet_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_688df5d1","line":119,"updated":"2015-12-09 05:12:40.000000000","message":"Suggestion :\nWhat you can do is modify both the test cases:\nKeep the args list as \n args \u003d [ \u0027--name\u0027, name,\n                \u0027--protocol-port\u0027, protocol_port,\n                \u0027--protocol\u0027, protocol,\n                \u0027--subnet-id\u0027, subnet_id,\n                \u0027--tenant-id\u0027, tenant_id,\n                pool_id]\n\nand for  the first test case keep session_args as:\n\n   session_args \u003d [\u0027--session-persistence\u0027,\u0027type\u003dcookie\u0027,--optional-param\u0027, \u0027any\u0027]\n\nand for the second test case:\n\n  session_args \u003d [\u0027--session-persistence\u0027,\u0027type\u003dcookie,cookie_name\u003dpie\u0027,--optional-param\u0027, \u0027any\u0027]\n\nand add the list with args.\nThat would prevent redefinition of the args list, in a way","commit_id":"4942c01d3a4f876da9ec9509476256ebabf2a107"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"c83a330d971589ae1f3077fd3c98e7ba671f9c86","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                   admin_state_up\u003dTrue)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        # test session persistence with cokkie name"},{"line_number":119,"context_line":"        args \u003d [\u0027--name\u0027, name,"},{"line_number":120,"context_line":"                \u0027--protocol-port\u0027, protocol_port,"},{"line_number":121,"context_line":"                \u0027--protocol\u0027, protocol,"},{"line_number":122,"context_line":"                \u0027--subnet-id\u0027, subnet_id,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_eb5b1f84","line":119,"in_reply_to":"7a740942_688df5d1","updated":"2015-12-09 05:41:35.000000000","message":"Done","commit_id":"4942c01d3a4f876da9ec9509476256ebabf2a107"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d1157ebba28cd71e87403eefe0fae4fcee628c8c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                \u0027--session-persistence\u0027,"},{"line_number":126,"context_line":"                \u0027type\u003dcookie,cookie_name\u003dpie\u0027,"},{"line_number":127,"context_line":"                \u0027--optional-param\u0027, \u0027any\u0027]"},{"line_number":128,"context_line":"        position_values \u003d [pool_id, name, protocol_port, protocol,"},{"line_number":129,"context_line":"                           subnet_id, tenant_id, \u0027any\u0027,"},{"line_number":130,"context_line":"                           {\u0027type\u0027: \u0027cookie\u0027, \u0027cookie_name\u0027: \u0027pie\u0027}]"},{"line_number":131,"context_line":"        self._test_create_resource(resource, cmd, name, my_id, args,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_a8ae7d2b","line":128,"updated":"2015-12-09 05:12:40.000000000","message":"positional values can also be kept as a single variable, updated with the respective values when required,","commit_id":"4942c01d3a4f876da9ec9509476256ebabf2a107"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"c83a330d971589ae1f3077fd3c98e7ba671f9c86","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                \u0027--session-persistence\u0027,"},{"line_number":126,"context_line":"                \u0027type\u003dcookie,cookie_name\u003dpie\u0027,"},{"line_number":127,"context_line":"                \u0027--optional-param\u0027, \u0027any\u0027]"},{"line_number":128,"context_line":"        position_values \u003d [pool_id, name, protocol_port, protocol,"},{"line_number":129,"context_line":"                           subnet_id, tenant_id, \u0027any\u0027,"},{"line_number":130,"context_line":"                           {\u0027type\u0027: \u0027cookie\u0027, \u0027cookie_name\u0027: \u0027pie\u0027}]"},{"line_number":131,"context_line":"        self._test_create_resource(resource, cmd, name, my_id, args,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_8b57fb56","line":128,"in_reply_to":"7a740942_a8ae7d2b","updated":"2015-12-09 05:41:35.000000000","message":"Done","commit_id":"4942c01d3a4f876da9ec9509476256ebabf2a107"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fd536b3cd58afaa7207169143ec4de38f8c78cc4","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # test session persistence without cookie name"},{"line_number":114,"context_line":"        session_args \u003d [\u0027--session-persistence\u0027,"},{"line_number":115,"context_line":"                        \u0027type\u003dcookie\u0027,"},{"line_number":116,"context_line":"                        \u0027--optional-param\u0027, \u0027any\u0027]"},{"line_number":117,"context_line":"        session_position \u003d [{\u0027type\u0027: \u0027cookie\u0027}]"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7a740942_c32394a6","line":115,"updated":"2015-12-09 13:17:40.000000000","message":"How about adding \",cookie_name\u003dpie\u0027,\" over here rather doing it separately?","commit_id":"075ed0c5f6f07eb07773e55659b767fb64e776dd"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"627ce07ee045cb18b60c96c62d73aca07b3cb845","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # test session persistence without cookie name"},{"line_number":114,"context_line":"        session_args \u003d [\u0027--session-persistence\u0027,"},{"line_number":115,"context_line":"                        \u0027type\u003dcookie\u0027,"},{"line_number":116,"context_line":"                        \u0027--optional-param\u0027, \u0027any\u0027]"},{"line_number":117,"context_line":"        session_position \u003d [{\u0027type\u0027: \u0027cookie\u0027}]"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7a740942_0393b5a4","line":115,"in_reply_to":"7a740942_8fda6e16","updated":"2015-12-10 03:34:12.000000000","message":"we have 2 different cases here, with \u0026 without cookie_name.","commit_id":"075ed0c5f6f07eb07773e55659b767fb64e776dd"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"52f7fcd4edca3b15302c70410171acd6108a4ae3","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        # test session persistence without cookie name"},{"line_number":114,"context_line":"        session_args \u003d [\u0027--session-persistence\u0027,"},{"line_number":115,"context_line":"                        \u0027type\u003dcookie\u0027,"},{"line_number":116,"context_line":"                        \u0027--optional-param\u0027, \u0027any\u0027]"},{"line_number":117,"context_line":"        session_position \u003d [{\u0027type\u0027: \u0027cookie\u0027}]"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7a740942_8fda6e16","line":115,"in_reply_to":"7a740942_c32394a6","updated":"2015-12-10 01:32:54.000000000","message":"Vikram: They are 2 separate tests\na) type\u003dcookie\nb) type\u003dcookie, cookie_name\u003dpie\nSo adding it here would duplicate the test, right?","commit_id":"075ed0c5f6f07eb07773e55659b767fb64e776dd"}]}
