)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b4ab87d72f270096c9ac20ae04ea745ba815acaf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vic Howard \u003cvictor.r.howard@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-28 15:07:29 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"python neutronclient changes to reflect DSCP QoS implementation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding the neutronclient section of the dscp changes."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a5de9d1_d24c5572","line":7,"updated":"2016-01-29 00:29:19.000000000","message":"The Title of the commit seems longer than the body, and the body makes more sense being the title.\n\nCan you make it as: \nAdding DSCP chnages to neutronclient\n\nThe following patch implements the DSCP QoS support in NeutronClient.","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a47a16951f1f9259dcbf88792ec3155f37b140c0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"python neutronclient changes to reflect DSCP QoS implementation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding the neutronclient section of the dscp changes."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I25ad60c1b9a66e568276a772b8c496987d9f8299"},{"line_number":12,"context_line":"Depends-On: Ic3baefe176df05f049a2e06529c58fd65fe6b419"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a5de9d1_8c9d40be","line":9,"updated":"2016-01-29 15:24:25.000000000","message":"Add release notes.\n\nAdd DocImpact tag.","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7ac2c4bf6aafbb9bb8f6cf1431d9763f825a1b88","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vic Howard \u003cvictor.r.howard@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-03 17:02:24 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding DSCP chnages to neutronclient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following patch implements the DSCP QoS support in NeutronClient."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a5ae5dd_b673f17f","line":7,"updated":"2016-02-04 05:11:15.000000000","message":"%s/chnages/changes/g.\n\nIMO, heading can be just \"Adding DSCP commands for QoS\"","commit_id":"7725dad059be73225c42f858ecd81b1c05033dc4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7ac2c4bf6aafbb9bb8f6cf1431d9763f825a1b88","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding DSCP chnages to neutronclient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following patch implements the DSCP QoS support in NeutronClient."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I25ad60c1b9a66e568276a772b8c496987d9f8299"},{"line_number":12,"context_line":"Depends-On: Ic3baefe176df05f049a2e06529c58fd65fe6b419"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a5ae5dd_f6dde942","line":9,"updated":"2016-02-04 05:11:15.000000000","message":"%s/NeutronClient/neutronclient/g","commit_id":"7725dad059be73225c42f858ecd81b1c05033dc4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7ac2c4bf6aafbb9bb8f6cf1431d9763f825a1b88","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I25ad60c1b9a66e568276a772b8c496987d9f8299"},{"line_number":12,"context_line":"Depends-On: Ic3baefe176df05f049a2e06529c58fd65fe6b419"},{"line_number":13,"context_line":"DocImpact: Adressed by change 273638"},{"line_number":14,"context_line":"Partial-Bug: #1468353"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a5ae5dd_965115db","line":13,"updated":"2016-02-04 05:11:15.000000000","message":"better to provide change-id link \"I881b8f5bc9024c20275bc56062de72a1c70c8321\" instead of review-id number.","commit_id":"7725dad059be73225c42f858ecd81b1c05033dc4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7ac2c4bf6aafbb9bb8f6cf1431d9763f825a1b88","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Change-Id: I25ad60c1b9a66e568276a772b8c496987d9f8299"},{"line_number":12,"context_line":"Depends-On: Ic3baefe176df05f049a2e06529c58fd65fe6b419"},{"line_number":13,"context_line":"DocImpact: Adressed by change 273638"},{"line_number":14,"context_line":"Partial-Bug: #1468353"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a5ae5dd_d6e30d04","line":14,"updated":"2016-02-04 05:11:15.000000000","message":"Please add a release-notes as well.","commit_id":"7725dad059be73225c42f858ecd81b1c05033dc4"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"bb39fcfc40af3280deead082121d17fd713a430c","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I25ad60c1b9a66e568276a772b8c496987d9f8299"},{"line_number":14,"context_line":"Depends-On: Ic3baefe176df05f049a2e06529c58fd65fe6b419"},{"line_number":15,"context_line":"DocImpact: I881b8f5bc9024c20275bc56062de72a1c70c8321"},{"line_number":16,"context_line":"Partial-Bug: #1468353"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"5a5ae5dd_e2a97a7c","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":9},"updated":"2016-02-04 18:35:13.000000000","message":"Remove the DocImpact tag since this change is already documented in https://review.openstack.org/#/c/273638/ and https://review.openstack.org/#/c/275253","commit_id":"0e371d80569a593f8ad7418eaf546300a5206b0c"}],"neutronclient/neutron/v2_0/qos/bandwidth_limit_rule.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a47a16951f1f9259dcbf88792ec3155f37b140c0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def args2body(self, parsed_args):"},{"line_number":57,"context_line":"        body \u003d {}"},{"line_number":58,"context_line":"        update_bandwidth_limit_args2body(parsed_args, body)"},{"line_number":59,"context_line":"        return {BANDWIDTH_LIMIT_RULE_RESOURCE: body}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class ListQoSBandwidthLimitRules(qos_rule.QosRuleMixin,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_cc6a5881","line":59,"updated":"2016-01-29 15:24:25.000000000","message":"just use resource.","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a47a16951f1f9259dcbf88792ec3155f37b140c0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def args2body(self, parsed_args):"},{"line_number":73,"context_line":"        body \u003d {}"},{"line_number":74,"context_line":"        qos_rule.update_policy_args2body(parsed_args, body)"},{"line_number":75,"context_line":"        return {BANDWIDTH_LIMIT_RULE_RESOURCE: body}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class ShowQoSBandwidthLimitRule(qos_rule.QosRuleMixin, neutronv20.ShowCommand):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_4c0d08e7","line":75,"updated":"2016-01-29 15:24:25.000000000","message":"ditto","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a47a16951f1f9259dcbf88792ec3155f37b140c0","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    def args2body(self, parsed_args):"},{"line_number":97,"context_line":"        body \u003d {}"},{"line_number":98,"context_line":"        update_bandwidth_limit_args2body(parsed_args, body)"},{"line_number":99,"context_line":"        return {BANDWIDTH_LIMIT_RULE_RESOURCE: body}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"class DeleteQoSBandwidthLimitRule(qos_rule.QosRuleMixin,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_2cf9acc7","line":99,"updated":"2016-01-29 15:24:25.000000000","message":"ditto","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7ac2c4bf6aafbb9bb8f6cf1431d9763f825a1b88","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def args2body(self, parsed_args):"},{"line_number":72,"context_line":"        body \u003d {}"},{"line_number":73,"context_line":"        qos_rule.update_policy_args2body(parsed_args, body)"},{"line_number":74,"context_line":"        return {self.resource: body}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"class ShowQoSBandwidthLimitRule(qos_rule.QosRuleMixin, neutronv20.ShowCommand):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_f6e729e2","line":74,"updated":"2016-02-04 05:11:15.000000000","message":"This should be \u0027qos_rule\u0027.","commit_id":"7725dad059be73225c42f858ecd81b1c05033dc4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7ac2c4bf6aafbb9bb8f6cf1431d9763f825a1b88","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    \"\"\"Show information about the given qos bandwidth limit rule.\"\"\""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    allow_names \u003d False"},{"line_number":81,"context_line":"    resource \u003d BANDWIDTH_LIMIT_RULE_RESOURCE"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class UpdateQoSBandwidthLimitRule(qos_rule.QosRuleMixin,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_56a5ddb2","line":81,"updated":"2016-02-04 05:11:15.000000000","message":"Change looks un-necessary. Let\u0027s keep same as the base code and minimize the diff.","commit_id":"7725dad059be73225c42f858ecd81b1c05033dc4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7ac2c4bf6aafbb9bb8f6cf1431d9763f825a1b88","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    \"\"\"Delete a given qos bandwidth limit rule.\"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    allow_names \u003d False"},{"line_number":105,"context_line":"    resource \u003d BANDWIDTH_LIMIT_RULE_RESOURCE"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_3605c179","line":105,"updated":"2016-02-04 05:11:15.000000000","message":"ditto","commit_id":"7725dad059be73225c42f858ecd81b1c05033dc4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"cd6f6ed7ff5a8cdbc6fd32c60c95b04e75b7f764","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                                 neutronv20.ListCommand):"},{"line_number":64,"context_line":"    \"\"\"List all qos bandwidth limit rules belonging to the specified policy.\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    resource \u003d BANDWIDTH_LIMIT_RULE_RESOURCE"},{"line_number":67,"context_line":"    _formatters \u003d {}"},{"line_number":68,"context_line":"    pagination_support \u003d True"},{"line_number":69,"context_line":"    sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_bc6467e5","line":66,"updated":"2016-02-09 05:06:16.000000000","message":"unnecessary new line inserted below. IMO, this can be removed.","commit_id":"09661eae7d80278af27aa76c458e93dd823e99ee"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"5f6c299a41d29ab1dabe98284760da68d8d7e967","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                                 neutronv20.ListCommand):"},{"line_number":64,"context_line":"    \"\"\"List all qos bandwidth limit rules belonging to the specified policy.\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    resource \u003d BANDWIDTH_LIMIT_RULE_RESOURCE"},{"line_number":67,"context_line":"    _formatters \u003d {}"},{"line_number":68,"context_line":"    pagination_support \u003d True"},{"line_number":69,"context_line":"    sorting_support \u003d True"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_26e7ebad","line":66,"in_reply_to":"5a5ae5dd_bc6467e5","updated":"2016-02-09 15:06:38.000000000","message":"Done","commit_id":"09661eae7d80278af27aa76c458e93dd823e99ee"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"cd6f6ed7ff5a8cdbc6fd32c60c95b04e75b7f764","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def args2body(self, parsed_args):"},{"line_number":72,"context_line":"        body \u003d {}"},{"line_number":73,"context_line":"        qos_rule.update_policy_args2body(parsed_args, body)"},{"line_number":74,"context_line":"        return {qos_rule: body}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"class ShowQoSBandwidthLimitRule(qos_rule.QosRuleMixin, neutronv20.ShowCommand):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_fc5adf29","line":74,"updated":"2016-02-09 05:06:16.000000000","message":"Why you have changed \u0027qos_rule\u0027 to qos_rule?","commit_id":"09661eae7d80278af27aa76c458e93dd823e99ee"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"5f6c299a41d29ab1dabe98284760da68d8d7e967","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def args2body(self, parsed_args):"},{"line_number":72,"context_line":"        body \u003d {}"},{"line_number":73,"context_line":"        qos_rule.update_policy_args2body(parsed_args, body)"},{"line_number":74,"context_line":"        return {qos_rule: body}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"class ShowQoSBandwidthLimitRule(qos_rule.QosRuleMixin, neutronv20.ShowCommand):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_269e0b08","line":74,"in_reply_to":"5a5ae5dd_fc5adf29","updated":"2016-02-09 15:06:38.000000000","message":"Will investigate and fix.","commit_id":"09661eae7d80278af27aa76c458e93dd823e99ee"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f13dd8956e2915b8ccd0a6e2ccbba02d660f37a6","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    pagination_support \u003d True"},{"line_number":70,"context_line":"    sorting_support \u003d True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def args2body(self, parsed_args):"},{"line_number":73,"context_line":"        body \u003d {}"},{"line_number":74,"context_line":"        qos_rule.update_policy_args2body(parsed_args, body)"},{"line_number":75,"context_line":"        return {\u0027qos_rule\u0027: body}"}],"source_content_type":"text/x-python","patch_set":20,"id":"7af24918_6da70150","side":"PARENT","line":72,"updated":"2016-03-01 12:10:20.000000000","message":"hmm, don\u0027t we need args2body here? \n\nI\u0027ll manually check this.","commit_id":"0065371c2ce139c30ab4d2d1a517bb10ca408940"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a2a072bcffc4fcb190eb4d0e81661be55de39a35","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    pagination_support \u003d True"},{"line_number":70,"context_line":"    sorting_support \u003d True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def args2body(self, parsed_args):"},{"line_number":73,"context_line":"        body \u003d {}"},{"line_number":74,"context_line":"        qos_rule.update_policy_args2body(parsed_args, body)"},{"line_number":75,"context_line":"        return {\u0027qos_rule\u0027: body}"}],"source_content_type":"text/x-python","patch_set":20,"id":"7af24918_73ab1fd7","side":"PARENT","line":72,"in_reply_to":"7af24918_3f37bcb1","updated":"2016-03-02 09:09:06.000000000","message":"Moved to https://review.openstack.org/#/c/254280/20/neutronclient/neutron/v2_0/qos/rule.py@51","commit_id":"0065371c2ce139c30ab4d2d1a517bb10ca408940"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7aa682824133340ebec89477506346fdb3b94672","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    pagination_support \u003d True"},{"line_number":70,"context_line":"    sorting_support \u003d True"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def args2body(self, parsed_args):"},{"line_number":73,"context_line":"        body \u003d {}"},{"line_number":74,"context_line":"        qos_rule.update_policy_args2body(parsed_args, body)"},{"line_number":75,"context_line":"        return {\u0027qos_rule\u0027: body}"}],"source_content_type":"text/x-python","patch_set":20,"id":"7af24918_3f37bcb1","side":"PARENT","line":72,"in_reply_to":"7af24918_6da70150","updated":"2016-03-01 20:24:11.000000000","message":"Sorry, that was ok, not needed for list op.","commit_id":"0065371c2ce139c30ab4d2d1a517bb10ca408940"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f13dd8956e2915b8ccd0a6e2ccbba02d660f37a6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def args2body(self, parsed_args):"},{"line_number":57,"context_line":"        body \u003d {}"},{"line_number":58,"context_line":"        update_bandwidth_limit_args2body(parsed_args, body)"},{"line_number":59,"context_line":"        return {self.resource: body}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class ListQoSBandwidthLimitRules(qos_rule.QosRuleMixin,"}],"source_content_type":"text/x-python","patch_set":20,"id":"7af24918_0dd11dce","line":59,"updated":"2016-03-01 12:10:20.000000000","message":"oh nice :)","commit_id":"b695561c364b63eefc914d510f5d615181d0d473"}],"neutronclient/neutron/v2_0/qos/dscp_marking_rule.py":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"7404e00de412b8bd9b678cd42eccc205dd0298c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Huawei Technologies India Pvt Ltd, Inc."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_5526f015","line":1,"updated":"2015-12-07 17:03:15.000000000","message":"You\u0027re not from Huawei.","commit_id":"cb924408f2b76cc8f6d467be53967be6919fdfb0"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"e117c5b24d3a99541cf254e593af3ba374f002e6","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def add_dscp_marking_arguments(parser):"},{"line_number":28,"context_line":"    parser.add_argument("},{"line_number":29,"context_line":"        \u0027--dscp-tag\u0027,"},{"line_number":30,"context_line":"        help\u003d_(\u0027dscp marking to set\u0027))"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_f275b2f9","line":29,"updated":"2015-12-07 17:16:05.000000000","message":"This is called \"mark\" in the Rule.\nI can change it on my side as this is a bit more descriptive than just mark.","commit_id":"cb924408f2b76cc8f6d467be53967be6919fdfb0"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"7404e00de412b8bd9b678cd42eccc205dd0298c9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"def add_dscp_marking_arguments(parser):"},{"line_number":28,"context_line":"    parser.add_argument("},{"line_number":29,"context_line":"        \u0027--dscp-tag\u0027,"},{"line_number":30,"context_line":"        help\u003d_(\u0027dscp marking to set\u0027))"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def update_dscp_marking_args2body(parsed_args, body):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_553fd023","line":30,"updated":"2015-12-07 17:03:15.000000000","message":"Probably should provide an example to help users.","commit_id":"cb924408f2b76cc8f6d467be53967be6919fdfb0"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"49e2a88ac222064f6988067dce851d620c007e78","unresolved":false,"context_lines":[{"line_number":27,"context_line":"def add_dscp_marking_arguments(parser):"},{"line_number":28,"context_line":"    parser.add_argument("},{"line_number":29,"context_line":"        \u0027--dscp-mark\u0027,"},{"line_number":30,"context_line":"        help\u003d_(\u0027dscp marking to set: 0-255 numeric\u0027))"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def update_dscp_marking_args2body(parsed_args, body):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_713e6729","line":30,"updated":"2015-12-08 15:02:17.000000000","message":"From Nate Johnston\u0027s changes only certain values are allowed to be set as dscp values.\n\n\"DSCP_VALID_MARKS \u003d [0, 8, 10, 12, 14, 16, 18, 20, 22, 24, 26, 28, 30, 32,34, 36, 38, 40, 46, 48, 56]\"","commit_id":"f7cdc2e0e4ebd2dd802b9cd8f58701a2fc994953"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"94679e6e835d1711b1c9ab742871ef1b63b7434d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Comcast, Inc."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_cfbb1ce4","line":1,"updated":"2016-01-11 07:28:49.000000000","message":"Let\u0027s move to 2016","commit_id":"760c51bca5169678512f64600bc55ea6ebc2825f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"94679e6e835d1711b1c9ab742871ef1b63b7434d","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutronclient.common import exceptions"},{"line_number":19,"context_line":"from neutronclient.i18n import _"},{"line_number":20,"context_line":"from neutronclient.neutron import v2_0 as neutronv20"},{"line_number":21,"context_line":"from neutronclient.neutron.v2_0.qos import rule as qos_rule"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_0f1e14bb","line":19,"updated":"2016-01-11 07:28:49.000000000","message":"nit: Plz use \"from neutronclient._i18n import _\"","commit_id":"760c51bca5169678512f64600bc55ea6ebc2825f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"94679e6e835d1711b1c9ab742871ef1b63b7434d","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def add_dscp_marking_arguments(parser):"},{"line_number":30,"context_line":"    parser.add_argument("},{"line_number":31,"context_line":"        \u0027--dscp-mark\u0027,"},{"line_number":32,"context_line":"        help\u003d_(\u0027--dscp-mark \u003c0 and all ven numbers between 8-56\u003e\u0027))"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_cfb79cd6","line":31,"updated":"2016-01-11 07:28:49.000000000","message":"From L37, I can see this must be a mandatory field. Hence, request you to add \u0027required\u003dTrue\u0027","commit_id":"760c51bca5169678512f64600bc55ea6ebc2825f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"94679e6e835d1711b1c9ab742871ef1b63b7434d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"def add_dscp_marking_arguments(parser):"},{"line_number":30,"context_line":"    parser.add_argument("},{"line_number":31,"context_line":"        \u0027--dscp-mark\u0027,"},{"line_number":32,"context_line":"        help\u003d_(\u0027--dscp-mark \u003c0 and all ven numbers between 8-56\u003e\u0027))"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def update_dscp_marking_args2body(parsed_args, body):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_ef95c032","line":32,"updated":"2016-01-11 07:28:49.000000000","message":"%s/ven/even/g","commit_id":"760c51bca5169678512f64600bc55ea6ebc2825f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"94679e6e835d1711b1c9ab742871ef1b63b7434d","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def update_dscp_marking_args2body(parsed_args, body):"},{"line_number":36,"context_line":"    dscp_mark \u003d parsed_args.dscp_mark"},{"line_number":37,"context_line":"    if not (dscp_mark):"},{"line_number":38,"context_line":"        raise exceptions.CommandError(_(\"Must provide dscp_mark\"))"},{"line_number":39,"context_line":"    if int(dscp_mark) not in DSCP_VALID_MARKS:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_4f7e4c1a","line":36,"updated":"2016-01-11 07:28:49.000000000","message":"can\u0027t see a point defining a new local variable. Can\u0027t we use parsed_args.dscp_mark instead?","commit_id":"760c51bca5169678512f64600bc55ea6ebc2825f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"94679e6e835d1711b1c9ab742871ef1b63b7434d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    if int(dscp_mark) not in DSCP_VALID_MARKS:"},{"line_number":40,"context_line":"        raise exceptions.CommandError(_(\"dscp_mark must be valid\"))"},{"line_number":41,"context_line":"    neutronv20.update_dict(parsed_args, body,"},{"line_number":42,"context_line":"                           [\u0027dscp_mark\u0027, \u0027tenant_id\u0027])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class CreateQoSDscpMarkingRule(qos_rule.QosRuleMixin,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_0fc29434","line":42,"updated":"2016-01-11 07:28:49.000000000","message":"Why we need to add \u0027tenant_id\u0027 explicitly. IIRC, this will be added automatically.","commit_id":"760c51bca5169678512f64600bc55ea6ebc2825f"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"821a4883b196d33f0719e5d0a24abb9b2b3155eb","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class UpdateQoSDscpMarkingRule(qos_rule.QosRuleMixin,"},{"line_number":85,"context_line":"                               neutronv20.UpdateCommand):"},{"line_number":86,"context_line":"    \"\"\"Update the given qos dscp marking limit rule.\"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    resource \u003d DSCP_MARKING_RESOURCE"},{"line_number":89,"context_line":"    allow_names \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_2350cfd3","line":86,"range":{"start_line":86,"start_character":41,"end_line":86,"end_character":46},"updated":"2016-01-11 09:25:30.000000000","message":"Remove limit please!","commit_id":"760c51bca5169678512f64600bc55ea6ebc2825f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a56f60aa58b2bcfee9f4a4557a82d1419aa2b22f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutronclient.common import exceptions"},{"line_number":18,"context_line":"from neutronclient.i18n import _"},{"line_number":19,"context_line":"from neutronclient.neutron import v2_0 as neutronv20"},{"line_number":20,"context_line":"from neutronclient.neutron.v2_0.qos import rule as qos_rule"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_e148018a","line":18,"updated":"2016-01-12 07:15:11.000000000","message":"Plz use \"from neutronclient._i18n import _\"","commit_id":"ca1087c424356951af5f13cbc2c2e7e87f877635"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a56f60aa58b2bcfee9f4a4557a82d1419aa2b22f","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DSCP_MARKING_RESOURCE \u003d \u0027dscp_marking_rule\u0027"},{"line_number":24,"context_line":"DSCP_VALID_MARKS \u003d [0, 8, 10, 12, 14, 16, 18, 20, 22, 24, 26, 28, 30, 32,"},{"line_number":25,"context_line":"                    34, 36, 38, 40, 46, 48, 56]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_5c8d347a","line":24,"updated":"2016-01-12 07:15:11.000000000","message":"IMO, let\u0027s add comments next to each value for better understanding.\n\n\nDSCP_VALID_MARKS \u003d [0,  # Best Effort\n                    8,  # CS1\n                    10, # AF11\n                    ...","commit_id":"ca1087c424356951af5f13cbc2c2e7e87f877635"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a56f60aa58b2bcfee9f4a4557a82d1419aa2b22f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    parser.add_argument("},{"line_number":30,"context_line":"        \u0027--dscp-mark\u0027,"},{"line_number":31,"context_line":"        required\u003dTrue,"},{"line_number":32,"context_line":"        help\u003d_(\u0027--dscp-mark \u003c 0 and all even numbers between 8-56\u003e\u0027))"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def update_dscp_marking_args2body(parsed_args, body):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_37797a94","line":32,"updated":"2016-01-12 07:15:11.000000000","message":"Let\u0027s say something about DSCP. Do we accept negative values?","commit_id":"ca1087c424356951af5f13cbc2c2e7e87f877635"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a56f60aa58b2bcfee9f4a4557a82d1419aa2b22f","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def update_dscp_marking_args2body(parsed_args, body):"},{"line_number":36,"context_line":"    if not (parsed_args.dscp_mark):"},{"line_number":37,"context_line":"        raise exceptions.CommandError(_(\"Must provide dscp_mark\"))"},{"line_number":38,"context_line":"    if int(parsed_args.dscp_mark) not in DSCP_VALID_MARKS:"},{"line_number":39,"context_line":"        raise exceptions.CommandError(_(\"dscp_mark must be valid\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_21361904","line":36,"updated":"2016-01-12 07:15:11.000000000","message":"if not parsed_args.dscp_mark:","commit_id":"ca1087c424356951af5f13cbc2c2e7e87f877635"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a56f60aa58b2bcfee9f4a4557a82d1419aa2b22f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    if int(parsed_args.dscp_mark) not in DSCP_VALID_MARKS:"},{"line_number":39,"context_line":"        raise exceptions.CommandError(_(\"dscp_mark must be valid\"))"},{"line_number":40,"context_line":"    neutronv20.update_dict(parsed_args, body,"},{"line_number":41,"context_line":"                           [\u0027dscp_mark\u0027, \u0027tenant_id\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class CreateQoSDscpMarkingRule(qos_rule.QosRuleMixin,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_e116c154","line":41,"updated":"2016-01-12 07:15:11.000000000","message":"Plz address PS3 comment","commit_id":"ca1087c424356951af5f13cbc2c2e7e87f877635"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a56f60aa58b2bcfee9f4a4557a82d1419aa2b22f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        return {\u0027qos_rule\u0027: body}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class ShowQoSDscpMarkingRule(qos_rule.QosRuleMixin, neutronv20.ShowCommand):"},{"line_number":77,"context_line":"    \"\"\"Show information about the given qos dscp marking rule.\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    resource \u003d DSCP_MARKING_RESOURCE"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_5762eed9","line":76,"updated":"2016-01-12 07:15:11.000000000","message":"Let\u0027s put \u0027neutronv20.ShowCommand\u0027 in the next line.","commit_id":"ca1087c424356951af5f13cbc2c2e7e87f877635"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"866b986e74f392cffda2e1552d2362d4b64de22e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    parser.add_argument("},{"line_number":37,"context_line":"        \u0027--dscp-mark\u0027,"},{"line_number":38,"context_line":"        required\u003dTrue,"},{"line_number":39,"context_line":"        help\u003d_(\u0027--dscp-mark \u003e 0 and all even numbers between 8-56\u003e\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def update_dscp_marking_args2body(parsed_args, body):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_b02df0ff","line":39,"updated":"2016-01-14 07:00:18.000000000","message":"0 is not acceptable? but DSCP_VALID_MARKS says we accept 0. I am confused.","commit_id":"e7ea75a57bd7faa869a96f60e2c1c05586d2be55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14335b9e8b74fb1a46cc569a33d2521200d316aa","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        help\u003d_(\u0027--dscp-mark \u003e 0 and all even numbers between 8-56\u003e\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def update_dscp_marking_args2body(parsed_args, body):"},{"line_number":43,"context_line":"    if not parsed_args.dscp_mark:"},{"line_number":44,"context_line":"        raise exceptions.CommandError(_(\"Must provide dscp_mark\"))"},{"line_number":45,"context_line":"    if int(parsed_args.dscp_mark) not in DSCP_VALID_MARKS:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_992d9a48","line":42,"updated":"2016-01-22 04:17:41.000000000","message":"too big a function name, aint it?\nCan we rewrite it as dscp_args2body ??","commit_id":"e7ea75a57bd7faa869a96f60e2c1c05586d2be55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14335b9e8b74fb1a46cc569a33d2521200d316aa","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def update_dscp_marking_args2body(parsed_args, body):"},{"line_number":43,"context_line":"    if not parsed_args.dscp_mark:"},{"line_number":44,"context_line":"        raise exceptions.CommandError(_(\"Must provide dscp_mark\"))"},{"line_number":45,"context_line":"    if int(parsed_args.dscp_mark) not in DSCP_VALID_MARKS:"},{"line_number":46,"context_line":"        raise exceptions.CommandError(_(\"dscp_mark must be valid\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_1943ea43","line":43,"updated":"2016-01-22 04:17:41.000000000","message":"if dscp_mark is required, I do not think there will be any scenario where it can be None","commit_id":"e7ea75a57bd7faa869a96f60e2c1c05586d2be55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14335b9e8b74fb1a46cc569a33d2521200d316aa","unresolved":false,"context_lines":[{"line_number":42,"context_line":"def update_dscp_marking_args2body(parsed_args, body):"},{"line_number":43,"context_line":"    if not parsed_args.dscp_mark:"},{"line_number":44,"context_line":"        raise exceptions.CommandError(_(\"Must provide dscp_mark\"))"},{"line_number":45,"context_line":"    if int(parsed_args.dscp_mark) not in DSCP_VALID_MARKS:"},{"line_number":46,"context_line":"        raise exceptions.CommandError(_(\"dscp_mark must be valid\"))"},{"line_number":47,"context_line":"    neutronv20.update_dict(parsed_args, body,"},{"line_number":48,"context_line":"                           [\u0027dscp_mark\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_59f402f1","line":45,"updated":"2016-01-22 04:17:41.000000000","message":"This can be changed.\nYou can \na) Accept the values as INT directly from the Command line using type\u003dint in the parser.add_argument() function defined in Line#36.\nOR\nb) Define a function which does this validation check in the parser.add_argument(). Again you will need the ¨type¨ attribute, but it will perform the validation at the initial level itself.\nExample: http://stackoverflow.com/questions/14117415/using-argparse-allow-only-positive-integers","commit_id":"e7ea75a57bd7faa869a96f60e2c1c05586d2be55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14335b9e8b74fb1a46cc569a33d2521200d316aa","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    def args2body(self, parsed_args):"},{"line_number":62,"context_line":"        body \u003d {}"},{"line_number":63,"context_line":"        update_dscp_marking_args2body(parsed_args, body)"},{"line_number":64,"context_line":"        return {\u0027dscp_marking_rule\u0027: body}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class ListQoSDscpMarkingRules(qos_rule.QosRuleMixin,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_995fdae4","line":64,"updated":"2016-01-22 04:17:41.000000000","message":"please rewrite it as return{resource:body}\nSame in other locations","commit_id":"e7ea75a57bd7faa869a96f60e2c1c05586d2be55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"14335b9e8b74fb1a46cc569a33d2521200d316aa","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    def args2body(self, parsed_args):"},{"line_number":78,"context_line":"        body \u003d {}"},{"line_number":79,"context_line":"        qos_rule.update_policy_args2body(parsed_args, body)"},{"line_number":80,"context_line":"        return {\u0027qos_rule\u0027: body}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class ShowQoSDscpMarkingRule(qos_rule.QosRuleMixin,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_595962fd","line":80,"updated":"2016-01-22 04:17:41.000000000","message":"Why are you returning qos_rule here?","commit_id":"e7ea75a57bd7faa869a96f60e2c1c05586d2be55"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"a9c8829c530cc8e6aa1ba8b3d8ea01d370f96c78","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class DeleteQoSDscpMarkingRule(qos_rule.QosRuleMixin,"},{"line_number":109,"context_line":"                               neutronv20.DeleteCommand):"},{"line_number":110,"context_line":"    \"\"\"Delete a given qos dscp marking limit rule.\"\"\""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    resource \u003d DSCP_MARKING_RESOURCE"},{"line_number":113,"context_line":"    allow_names \u003d False"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_dbb2f7e4","line":110,"range":{"start_line":110,"start_character":39,"end_line":110,"end_character":44},"updated":"2016-01-14 11:45:01.000000000","message":"Remove limit please.","commit_id":"e7ea75a57bd7faa869a96f60e2c1c05586d2be55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b4ab87d72f270096c9ac20ae04ea745ba815acaf","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def check_valid_mark(value):"},{"line_number":36,"context_line":"    ivalue \u003d int(value)"},{"line_number":37,"context_line":"    if ivalue not in DSCP_VALID_MARKS:"},{"line_number":38,"context_line":"        raise exceptions.CommandError(_(\"dscp_mark must be valid\"))"},{"line_number":39,"context_line":"    return value"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_f21631f0","line":37,"updated":"2016-01-29 00:29:19.000000000","message":"You are not changing the value of ¨value¨\nThis function can be simply re-written as :\n\ndef check_valid_mark(value):\n    if value not in DSCP_VALID_MARKS:\n        raise exceptions.CommandError(_(¨dscp_mark must be valid.¨))\n    return value","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b4ab87d72f270096c9ac20ae04ea745ba815acaf","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        \u0027--dscp-mark\u0027,"},{"line_number":45,"context_line":"        required\u003dTrue,"},{"line_number":46,"context_line":"        type\u003dcheck_valid_mark,"},{"line_number":47,"context_line":"        help\u003d_(\u0027--dscp-mark can be 0 and all even numbers between 8-56\u0027))"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def update_dscp_args2body(parsed_args, body):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_92381da2","line":47,"updated":"2016-01-29 00:29:19.000000000","message":"Since this is a new Help message, I think we can follow a convention. Help message should first state , what this parameter is actually used for, that is , why should a new user, who does not have any idea , use it.\nThen it can be followed by the set of values it can take.","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b4ab87d72f270096c9ac20ae04ea745ba815acaf","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def args2body(self, parsed_args):"},{"line_number":66,"context_line":"        body \u003d {}"},{"line_number":67,"context_line":"        update_dscp_args2body(parsed_args, body)"},{"line_number":68,"context_line":"        return {DSCP_MARKING_RESOURCE: body}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class ListQoSDscpMarkingRules(qos_rule.QosRuleMixin,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_72456115","line":68,"updated":"2016-01-29 00:29:19.000000000","message":"or more simply:\n\n return {resource:body}","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a47a16951f1f9259dcbf88792ec3155f37b140c0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def args2body(self, parsed_args):"},{"line_number":66,"context_line":"        body \u003d {}"},{"line_number":67,"context_line":"        update_dscp_args2body(parsed_args, body)"},{"line_number":68,"context_line":"        return {DSCP_MARKING_RESOURCE: body}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class ListQoSDscpMarkingRules(qos_rule.QosRuleMixin,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_ac3efc89","line":68,"in_reply_to":"7a5de9d1_72456115","updated":"2016-01-29 15:24:25.000000000","message":"+1","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a47a16951f1f9259dcbf88792ec3155f37b140c0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def args2body(self, parsed_args):"},{"line_number":81,"context_line":"        body \u003d {}"},{"line_number":82,"context_line":"        qos_rule.update_policy_args2body(parsed_args, body)"},{"line_number":83,"context_line":"        return {DSCP_MARKING_RESOURCE: body}"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class ShowQoSDscpMarkingRule(qos_rule.QosRuleMixin,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_2c4bec2b","line":83,"updated":"2016-01-29 15:24:25.000000000","message":"ditto","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b4ab87d72f270096c9ac20ae04ea745ba815acaf","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    resource \u003d DSCP_MARKING_RESOURCE"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":101,"context_line":"        super(UpdateQoSDscpMarkingRule, self).add_known_arguments(parser)"},{"line_number":102,"context_line":"        add_dscp_marking_arguments(parser)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_d21bf519","line":101,"updated":"2016-01-29 00:29:19.000000000","message":"You are adding the arguments from QosRuleMixin here.\nBut you are not converting the arguments to Body in the args2body function below.\nAny reason fore the same?","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"651a79d6d07eef06ea106bbb5175ef3b67ba122f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    resource \u003d DSCP_MARKING_RESOURCE"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":101,"context_line":"        super(UpdateQoSDscpMarkingRule, self).add_known_arguments(parser)"},{"line_number":102,"context_line":"        add_dscp_marking_arguments(parser)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a5ae5dd_cd09412e","line":101,"in_reply_to":"7a5de9d1_d21bf519","updated":"2016-02-04 00:17:01.000000000","message":"missing in the current PS","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a47a16951f1f9259dcbf88792ec3155f37b140c0","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def args2body(self, parsed_args):"},{"line_number":105,"context_line":"        body \u003d {}"},{"line_number":106,"context_line":"        update_dscp_args2body(parsed_args, body)"},{"line_number":107,"context_line":"        return {DSCP_MARKING_RESOURCE: body}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class DeleteQoSDscpMarkingRule(qos_rule.QosRuleMixin,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_ac659cb5","line":107,"updated":"2016-01-29 15:24:25.000000000","message":"ditto","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7ac2c4bf6aafbb9bb8f6cf1431d9763f825a1b88","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def check_valid_mark(value):"},{"line_number":36,"context_line":"    if int(value) not in DSCP_VALID_MARKS:"},{"line_number":37,"context_line":"        raise exceptions.CommandError(_(\"dscp_mark must be valid\"))"},{"line_number":38,"context_line":"    return value"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_19f796f6","line":37,"updated":"2016-02-04 05:11:15.000000000","message":"How about providing more info upon failure. \n\n(\"dscp-value: %(value)s not supported. Please note value can either be 0 or any even number from 8-56 excluding 50, 52 and 54.\")","commit_id":"7725dad059be73225c42f858ecd81b1c05033dc4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7ac2c4bf6aafbb9bb8f6cf1431d9763f825a1b88","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        \u0027--dscp-mark\u0027,"},{"line_number":44,"context_line":"        required\u003dTrue,"},{"line_number":45,"context_line":"        type\u003dcheck_valid_mark,"},{"line_number":46,"context_line":"        help\u003d_(\u0027add dscp mark:value can be 0 and all even numbers from 8-56\u0027))"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def update_dscp_args2body(parsed_args, body):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_d6222d01","line":46,"updated":"2016-02-04 05:11:15.000000000","message":"Help can be misleading here. Note we values like 50,52 and 54 are not supported but we say \"all even numbers from 8-56\".","commit_id":"7725dad059be73225c42f858ecd81b1c05033dc4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7ac2c4bf6aafbb9bb8f6cf1431d9763f825a1b88","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def args2body(self, parsed_args):"},{"line_number":79,"context_line":"        body \u003d {}"},{"line_number":80,"context_line":"        qos_rule.update_policy_args2body(parsed_args, body)"},{"line_number":81,"context_line":"        return {self.resource: body}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class ShowQoSDscpMarkingRule(qos_rule.QosRuleMixin,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_79bfaafb","line":81,"updated":"2016-02-04 05:11:15.000000000","message":"should be \u0027qos_rule\u0027 instead of self.resource","commit_id":"7725dad059be73225c42f858ecd81b1c05033dc4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c78785ce620c1aea0334db89d0f1f281ba50a3d3","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def check_valid_mark(value):"},{"line_number":36,"context_line":"    if int(value) not in DSCP_VALID_MARKS:"},{"line_number":37,"context_line":"        raise exceptions.CommandError(_(\"dscp-value: %(value)s not supported.\\"},{"line_number":38,"context_line":"                                         Please note value can either be 0 \\"},{"line_number":39,"context_line":"                                         or any even number from 8-56 \\"},{"line_number":40,"context_line":"                                         excluding 50, 52 and 54.\"))"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_a9efd5e7","line":37,"updated":"2016-02-05 03:52:10.000000000","message":"You forgot to provide the value for the format specifier %(value)s. Plz check.","commit_id":"c2fc391ac1f67b38769460a911a4ff09d2b9a2c8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c78785ce620c1aea0334db89d0f1f281ba50a3d3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \u0027--dscp-mark\u0027,"},{"line_number":47,"context_line":"        required\u003dTrue,"},{"line_number":48,"context_line":"        type\u003dcheck_valid_mark,"},{"line_number":49,"context_line":"        help\u003d_(\u0027add dscp mark: value can be 0, even numbers from 8-56, \\"},{"line_number":50,"context_line":"                excluding 50, 52, and 54.\u0027))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_49b741f5","line":49,"updated":"2016-02-05 03:52:10.000000000","message":"Why \u0027add\u0027 is required?? IMO, we can remove it.","commit_id":"c2fc391ac1f67b38769460a911a4ff09d2b9a2c8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c78785ce620c1aea0334db89d0f1f281ba50a3d3","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class CreateQoSDscpMarkingRule(qos_rule.QosRuleMixin,"},{"line_number":59,"context_line":"                               neutronv20.CreateCommand):"},{"line_number":60,"context_line":"    \"\"\"Create a dscp marking rule.\"\"\""},{"line_number":61,"context_line":"    resource \u003d DSCP_MARKING_RESOURCE"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def add_known_arguments(self, parser):"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_c9c33156","line":60,"updated":"2016-02-05 03:52:10.000000000","message":"Let\u0027s have a new line after the doc string.","commit_id":"c2fc391ac1f67b38769460a911a4ff09d2b9a2c8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c78785ce620c1aea0334db89d0f1f281ba50a3d3","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class ShowQoSDscpMarkingRule(qos_rule.QosRuleMixin,"},{"line_number":89,"context_line":"                             neutronv20.ShowCommand):"},{"line_number":90,"context_line":"    \"\"\"Show information about the given qos dscp marking rule.\"\"\""},{"line_number":91,"context_line":"    resource \u003d DSCP_MARKING_RESOURCE"},{"line_number":92,"context_line":"    allow_names \u003d False"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_a9c6f565","line":90,"updated":"2016-02-05 03:52:10.000000000","message":"Let\u0027s have a new line after the doc string.","commit_id":"c2fc391ac1f67b38769460a911a4ff09d2b9a2c8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"cd6f6ed7ff5a8cdbc6fd32c60c95b04e75b7f764","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class CreateQoSDscpMarkingRule(qos_rule.QosRuleMixin,"},{"line_number":57,"context_line":"                               neutronv20.CreateCommand):"},{"line_number":58,"context_line":"    \"\"\"Create a dscp marking rule.\"\"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    resource \u003d DSCP_MARKING_RESOURCE"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_fcf65ff8","line":58,"updated":"2016-02-09 05:06:16.000000000","message":"Can you please add \u0027qos\u0027 in the description. This will make the doc string consistent.\n\n \"\"\"Create a qos dscp marking rule.\"\"\"","commit_id":"09661eae7d80278af27aa76c458e93dd823e99ee"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"5f6c299a41d29ab1dabe98284760da68d8d7e967","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class CreateQoSDscpMarkingRule(qos_rule.QosRuleMixin,"},{"line_number":57,"context_line":"                               neutronv20.CreateCommand):"},{"line_number":58,"context_line":"    \"\"\"Create a dscp marking rule.\"\"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    resource \u003d DSCP_MARKING_RESOURCE"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_e688f3c8","line":58,"in_reply_to":"5a5ae5dd_fcf65ff8","updated":"2016-02-09 15:06:38.000000000","message":"Done","commit_id":"09661eae7d80278af27aa76c458e93dd823e99ee"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4664a8165f159350d9a1b999fc05d790aca99d80","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    sorting_support \u003d True"},{"line_number":79,"context_line":"    resource \u003d DSCP_MARKING_RESOURCE"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def args2body(self, parsed_args):"},{"line_number":82,"context_line":"        body \u003d {}"},{"line_number":83,"context_line":"        qos_rule.update_policy_args2body(parsed_args, body)"},{"line_number":84,"context_line":"        return {qos_rule: body}"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_5dec3bc7","line":81,"updated":"2016-02-10 11:02:47.000000000","message":"How about defining this function in QosRuleMixin? This code looks same for ListQoSBandwidthLimitRules and ListQoSDscpMarkingRules. Any thoughts?","commit_id":"7b63e13b6ab4e8f4eb17105b405e15c36efd97ad"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"4225d1a4061c1bd1c62bbd594ddbe5a13445c412","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    sorting_support \u003d True"},{"line_number":79,"context_line":"    resource \u003d DSCP_MARKING_RESOURCE"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def args2body(self, parsed_args):"},{"line_number":82,"context_line":"        body \u003d {}"},{"line_number":83,"context_line":"        qos_rule.update_policy_args2body(parsed_args, body)"},{"line_number":84,"context_line":"        return {qos_rule: body}"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_4178b88f","line":81,"in_reply_to":"3a57f1b5_5dec3bc7","updated":"2016-02-10 19:56:23.000000000","message":"Yes, good idea.  Will do.","commit_id":"7b63e13b6ab4e8f4eb17105b405e15c36efd97ad"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4664a8165f159350d9a1b999fc05d790aca99d80","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    def args2body(self, parsed_args):"},{"line_number":82,"context_line":"        body \u003d {}"},{"line_number":83,"context_line":"        qos_rule.update_policy_args2body(parsed_args, body)"},{"line_number":84,"context_line":"        return {qos_rule: body}"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class ShowQoSDscpMarkingRule(qos_rule.QosRuleMixin,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_fddde770","line":84,"updated":"2016-02-10 11:02:47.000000000","message":"should be \u0027qos_rule\u0027","commit_id":"7b63e13b6ab4e8f4eb17105b405e15c36efd97ad"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"4225d1a4061c1bd1c62bbd594ddbe5a13445c412","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    def args2body(self, parsed_args):"},{"line_number":82,"context_line":"        body \u003d {}"},{"line_number":83,"context_line":"        qos_rule.update_policy_args2body(parsed_args, body)"},{"line_number":84,"context_line":"        return {qos_rule: body}"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class ShowQoSDscpMarkingRule(qos_rule.QosRuleMixin,"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_06a3b650","line":84,"in_reply_to":"3a57f1b5_fddde770","updated":"2016-02-10 19:56:23.000000000","message":"Done","commit_id":"7b63e13b6ab4e8f4eb17105b405e15c36efd97ad"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"29dd81fc13427a8a629d2db5e2341f6e862565db","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        required\u003dTrue,"},{"line_number":39,"context_line":"        type\u003dstr,"},{"line_number":40,"context_line":"        help\u003d_(\u0027dscp mark: value can be 0, even numbers from 8-56, \\"},{"line_number":41,"context_line":"                excluding 50, 52, and 54.\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def update_dscp_args2body(parsed_args, body):"}],"source_content_type":"text/x-python","patch_set":19,"id":"bae84128_f7fb50bf","line":41,"updated":"2016-02-23 07:36:23.000000000","message":"42 and 44 are also invalid. Please correct.","commit_id":"7101a9b46d8c52c3f3a797971793ac249338c1f0"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"fa242eb3750bcb15367fc8137c9df687f065af56","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        required\u003dTrue,"},{"line_number":39,"context_line":"        type\u003dstr,"},{"line_number":40,"context_line":"        help\u003d_(\u0027dscp mark: value can be 0, even numbers from 8-56, \\"},{"line_number":41,"context_line":"                excluding 50, 52, and 54.\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def update_dscp_args2body(parsed_args, body):"}],"source_content_type":"text/x-python","patch_set":19,"id":"bae84128_f8096a85","line":41,"in_reply_to":"bae84128_f7fb50bf","updated":"2016-02-23 15:24:42.000000000","message":"Done","commit_id":"7101a9b46d8c52c3f3a797971793ac249338c1f0"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"29dd81fc13427a8a629d2db5e2341f6e862565db","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        raise exceptions.CommandError(_(\"dscp-value: %s not supported.\\"},{"line_number":48,"context_line":"                                         Please note value can either be 0 \\"},{"line_number":49,"context_line":"                                         or any even number from 8-56 \\"},{"line_number":50,"context_line":"                                         excluding 50, 52 and \\"},{"line_number":51,"context_line":"                                         54.\") % dscp_mark)"},{"line_number":52,"context_line":"    neutronv20.update_dict(parsed_args, body,"},{"line_number":53,"context_line":"                           [\u0027dscp_mark\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"bae84128_17ffd4aa","line":50,"updated":"2016-02-23 07:36:23.000000000","message":"ditto","commit_id":"7101a9b46d8c52c3f3a797971793ac249338c1f0"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"fa242eb3750bcb15367fc8137c9df687f065af56","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        raise exceptions.CommandError(_(\"dscp-value: %s not supported.\\"},{"line_number":48,"context_line":"                                         Please note value can either be 0 \\"},{"line_number":49,"context_line":"                                         or any even number from 8-56 \\"},{"line_number":50,"context_line":"                                         excluding 50, 52 and \\"},{"line_number":51,"context_line":"                                         54.\") % dscp_mark)"},{"line_number":52,"context_line":"    neutronv20.update_dict(parsed_args, body,"},{"line_number":53,"context_line":"                           [\u0027dscp_mark\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"bae84128_3828f2e1","line":50,"in_reply_to":"bae84128_17ffd4aa","updated":"2016-02-23 15:24:42.000000000","message":"Done","commit_id":"7101a9b46d8c52c3f3a797971793ac249338c1f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d32fd8f2d177a65faf5a6158a47d9a32cec2d5c8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \u0027--dscp-mark\u0027,"},{"line_number":38,"context_line":"        required\u003dTrue,"},{"line_number":39,"context_line":"        type\u003dstr,"},{"line_number":40,"context_line":"        help\u003d_(\u0027dscp mark: value can be 0, even numbers from 8-56, \\"},{"line_number":41,"context_line":"                excluding 42, 44, 50, 52, and 54.\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_316c7dcf","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":20},"updated":"2016-03-03 17:01:24.000000000","message":"DSCP","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"dc248281b6a4daf266b63a615df4e55d8a5ed3ca","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        \u0027--dscp-mark\u0027,"},{"line_number":38,"context_line":"        required\u003dTrue,"},{"line_number":39,"context_line":"        type\u003dstr,"},{"line_number":40,"context_line":"        help\u003d_(\u0027dscp mark: value can be 0, even numbers from 8-56, \\"},{"line_number":41,"context_line":"                excluding 42, 44, 50, 52, and 54.\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_66e006ce","line":40,"range":{"start_line":40,"start_character":16,"end_line":40,"end_character":20},"in_reply_to":"7af24918_316c7dcf","updated":"2016-03-03 17:38:27.000000000","message":"Done","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d32fd8f2d177a65faf5a6158a47d9a32cec2d5c8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"def update_dscp_args2body(parsed_args, body):"},{"line_number":45,"context_line":"    dscp_mark \u003d parsed_args.dscp_mark"},{"line_number":46,"context_line":"    if int(dscp_mark) not in DSCP_VALID_MARKS:"},{"line_number":47,"context_line":"        raise exceptions.CommandError(_(\"dscp-value: %s not supported. \""},{"line_number":48,"context_line":"                                        \"Please note value can either be 0 \""},{"line_number":49,"context_line":"                                        \"or any even number from 8-56 \""},{"line_number":50,"context_line":"                                        \"excluding 42, 44, 50, 52 and \""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_9146314d","line":47,"range":{"start_line":47,"start_character":41,"end_line":47,"end_character":51},"updated":"2016-03-03 17:01:24.000000000","message":"should be \u0027DSCP mark\u0027 maybe?","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"dc248281b6a4daf266b63a615df4e55d8a5ed3ca","unresolved":false,"context_lines":[{"line_number":44,"context_line":"def update_dscp_args2body(parsed_args, body):"},{"line_number":45,"context_line":"    dscp_mark \u003d parsed_args.dscp_mark"},{"line_number":46,"context_line":"    if int(dscp_mark) not in DSCP_VALID_MARKS:"},{"line_number":47,"context_line":"        raise exceptions.CommandError(_(\"dscp-value: %s not supported. \""},{"line_number":48,"context_line":"                                        \"Please note value can either be 0 \""},{"line_number":49,"context_line":"                                        \"or any even number from 8-56 \""},{"line_number":50,"context_line":"                                        \"excluding 42, 44, 50, 52 and \""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_86e9d2b9","line":47,"range":{"start_line":47,"start_character":41,"end_line":47,"end_character":51},"in_reply_to":"7af24918_9146314d","updated":"2016-03-03 17:38:27.000000000","message":"Done","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d32fd8f2d177a65faf5a6158a47d9a32cec2d5c8","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class CreateQoSDscpMarkingRule(qos_rule.QosRuleMixin,"},{"line_number":57,"context_line":"                               neutronv20.CreateCommand):"},{"line_number":58,"context_line":"    \"\"\"Create a qos dscp marking rule.\"\"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    resource \u003d DSCP_MARKING_RESOURCE"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_f1833554","line":58,"range":{"start_line":58,"start_character":16,"end_line":58,"end_character":24},"updated":"2016-03-03 17:01:24.000000000","message":"QoS DSCP","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"dc248281b6a4daf266b63a615df4e55d8a5ed3ca","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class CreateQoSDscpMarkingRule(qos_rule.QosRuleMixin,"},{"line_number":57,"context_line":"                               neutronv20.CreateCommand):"},{"line_number":58,"context_line":"    \"\"\"Create a qos dscp marking rule.\"\"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    resource \u003d DSCP_MARKING_RESOURCE"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_c6cf5a54","line":58,"range":{"start_line":58,"start_character":16,"end_line":58,"end_character":24},"in_reply_to":"7af24918_f1833554","updated":"2016-03-03 17:38:27.000000000","message":"Done","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d32fd8f2d177a65faf5a6158a47d9a32cec2d5c8","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class DeleteQoSDscpMarkingRule(qos_rule.QosRuleMixin,"},{"line_number":108,"context_line":"                               neutronv20.DeleteCommand):"},{"line_number":109,"context_line":"    \"\"\"Delete a given qos dscp marking rule.\"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    allow_names \u003d False"},{"line_number":112,"context_line":"    resource \u003d DSCP_MARKING_RESOURCE"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_d1d6f94d","line":109,"range":{"start_line":109,"start_character":22,"end_line":109,"end_character":30},"updated":"2016-03-03 17:01:24.000000000","message":"QoS DSCP","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"dc248281b6a4daf266b63a615df4e55d8a5ed3ca","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"class DeleteQoSDscpMarkingRule(qos_rule.QosRuleMixin,"},{"line_number":108,"context_line":"                               neutronv20.DeleteCommand):"},{"line_number":109,"context_line":"    \"\"\"Delete a given qos dscp marking rule.\"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    allow_names \u003d False"},{"line_number":112,"context_line":"    resource \u003d DSCP_MARKING_RESOURCE"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_06d662f0","line":109,"range":{"start_line":109,"start_character":22,"end_line":109,"end_character":30},"in_reply_to":"7af24918_d1d6f94d","updated":"2016-03-03 17:38:27.000000000","message":"Done","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"eb1af5fc39d4e320f3fa0ffee1508a281103d921","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DSCP_MARKING_RESOURCE \u003d \u0027dscp_marking_rule\u0027"},{"line_number":24,"context_line":"# DSCP DETAILS"},{"line_number":25,"context_line":"# 0 - none  | 8 - cs1   | 10 - af11 | 12 - af12 | 14 - af13 |"},{"line_number":26,"context_line":"# 16 - cs2  | 18 - af21 | 20 - af22 | 22 - af23 | 24 - cs3  |"},{"line_number":27,"context_line":"# 26 - af31 | 28 - af32 | 30 - af33 | 32 - cs4  | 34 - af41 |"}],"source_content_type":"text/x-python","patch_set":22,"id":"5aef4532_6ddb0550","line":24,"updated":"2016-03-10 17:15:53.000000000","message":"(No action required) Idea for follow up: a good addition could be to take the names too and convert them to the right number.","commit_id":"8ff7d5cabaa755af13a08c144230b245daa3e39b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"72f70c8a733be9ae5a51e5f8e779f6f181666106","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"DSCP_MARKING_RESOURCE \u003d \u0027dscp_marking_rule\u0027"},{"line_number":24,"context_line":"# DSCP DETAILS"},{"line_number":25,"context_line":"# 0 - none  | 8 - cs1   | 10 - af11 | 12 - af12 | 14 - af13 |"},{"line_number":26,"context_line":"# 16 - cs2  | 18 - af21 | 20 - af22 | 22 - af23 | 24 - cs3  |"},{"line_number":27,"context_line":"# 26 - af31 | 28 - af32 | 30 - af33 | 32 - cs4  | 34 - af41 |"}],"source_content_type":"text/x-python","patch_set":22,"id":"1af94dfe_6fbdcb67","line":24,"in_reply_to":"5aef4532_6ddb0550","updated":"2016-03-17 07:13:20.000000000","message":"Sounds good!","commit_id":"8ff7d5cabaa755af13a08c144230b245daa3e39b"}],"neutronclient/tests/unit/qos/test_cli20_bandwidth_limit_rule.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b4ab87d72f270096c9ac20ae04ea745ba815acaf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutronclient.tests.unit import test_cli20"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class CLITestV20QoSBandwidthLimitRuleJSON(test_cli20.CLITestV20Base):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    non_admin_status_resources \u003d [\u0027bandwidth_limit_rule\u0027, \u0027dscp_marking_rule\u0027]"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_b27d19e9","line":23,"updated":"2016-01-29 00:29:19.000000000","message":"Test case for List is missing","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a47a16951f1f9259dcbf88792ec3155f37b140c0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutronclient.tests.unit import test_cli20"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class CLITestV20QoSBandwidthLimitRuleJSON(test_cli20.CLITestV20Base):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    non_admin_status_resources \u003d [\u0027bandwidth_limit_rule\u0027, \u0027dscp_marking_rule\u0027]"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_ccab3874","line":23,"in_reply_to":"7a5de9d1_b27d19e9","updated":"2016-01-29 15:24:25.000000000","message":"Already available in https://review.openstack.org/#/c/254280/8/neutronclient/tests/unit/qos/test_cli20_rule.py\n\nIMO, no need to re-add.","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a47a16951f1f9259dcbf88792ec3155f37b140c0","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class CLITestV20QoSBandwidthLimitRuleJSON(test_cli20.CLITestV20Base):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    non_admin_status_resources \u003d [\u0027bandwidth_limit_rule\u0027, \u0027dscp_marking_rule\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(CLITestV20QoSBandwidthLimitRuleJSON, self).setUp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_0ccdd065","line":25,"updated":"2016-01-29 15:24:25.000000000","message":"No need to add \u0027dscp_marking_rule\u0027. Plz remove.","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d32fd8f2d177a65faf5a6158a47d9a32cec2d5c8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import sys"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutronclient.neutron.v2_0.qos import bandwidth_limit_rule as bw_rule"},{"line_number":20,"context_line":"from neutronclient.tests.unit import test_cli20"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_51714975","line":17,"updated":"2016-03-03 17:01:24.000000000","message":"I presume the file is just code moved from another file","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"dc248281b6a4daf266b63a615df4e55d8a5ed3ca","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import sys"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutronclient.neutron.v2_0.qos import bandwidth_limit_rule as bw_rule"},{"line_number":20,"context_line":"from neutronclient.tests.unit import test_cli20"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_8637124c","line":17,"in_reply_to":"7af24918_51714975","updated":"2016-03-03 17:38:27.000000000","message":"Correct","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"}],"neutronclient/tests/unit/qos/test_cli20_dscp_marking_rule.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a47a16951f1f9259dcbf88792ec3155f37b140c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Huawei Technologies India Pvt Ltd."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_aca83c8e","line":1,"updated":"2016-01-29 15:24:25.000000000","message":"Please add your company details ;)","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a47a16951f1f9259dcbf88792ec3155f37b140c0","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class CLITestV20QoSDscpMarkingRuleJSON(test_cli20.CLITestV20Base):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    non_admin_status_resources \u003d [\u0027bandwidth_limit_rule\u0027, \u0027dscp_marking_rule\u0027]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def setUp(self):"},{"line_number":28,"context_line":"        super(CLITestV20QoSDscpMarkingRuleJSON, self).setUp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_cc9d7867","line":25,"updated":"2016-01-29 15:24:25.000000000","message":"why to mention \u0027bandwidth_limit_rule\u0027?","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b4ab87d72f270096c9ac20ae04ea745ba815acaf","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                   cmd_resource\u003dself.dscp_cmd_res,"},{"line_number":69,"context_line":"                                   parent_id\u003dpolicy_id)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_show_dscp_marking_rule(self):"},{"line_number":72,"context_line":"        cmd \u003d dscp_rule.ShowQoSDscpMarkingRule(test_cli20.MyApp(sys.stdout),"},{"line_number":73,"context_line":"                                               None)"},{"line_number":74,"context_line":"        policy_id \u003d \u0027policy_id\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_326a891b","line":71,"updated":"2016-01-29 00:29:19.000000000","message":"List?","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a47a16951f1f9259dcbf88792ec3155f37b140c0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                   cmd_resource\u003dself.dscp_cmd_res,"},{"line_number":69,"context_line":"                                   parent_id\u003dpolicy_id)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_show_dscp_marking_rule(self):"},{"line_number":72,"context_line":"        cmd \u003d dscp_rule.ShowQoSDscpMarkingRule(test_cli20.MyApp(sys.stdout),"},{"line_number":73,"context_line":"                                               None)"},{"line_number":74,"context_line":"        policy_id \u003d \u0027policy_id\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_4c97483a","line":71,"in_reply_to":"7a5de9d1_326a891b","updated":"2016-01-29 15:24:25.000000000","message":"Already available in https://review.openstack.org/#/c/254280/8/neutronclient/tests/unit/qos/test_cli20_rule.py\n\nIMO, no need to re-add.","commit_id":"824c79399540a390430fc2cd93195efd12d1652d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7ac2c4bf6aafbb9bb8f6cf1431d9763f825a1b88","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        cmd \u003d dscp_rule.CreateQoSDscpMarkingRule(test_cli20.MyApp(sys.stdout),"},{"line_number":36,"context_line":"                                                 None)"},{"line_number":37,"context_line":"        my_id \u003d \u0027my-id\u0027"},{"line_number":38,"context_line":"        dscp_mark \u003d \u002756\u0027"},{"line_number":39,"context_line":"        policy_id \u003d \u0027policy_id\u0027"},{"line_number":40,"context_line":"        args \u003d [\u0027--dscp-mark\u0027, dscp_mark, policy_id]"},{"line_number":41,"context_line":"        position_names \u003d [\u0027dscp_mark\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_f9263a67","line":38,"updated":"2016-02-04 05:11:15.000000000","message":"How about adding a test-case for verifying invalid dscp mark value say:\n* less than 0\n* between 0 - 8\n* 50/52/54\n* greater than 56","commit_id":"7725dad059be73225c42f858ecd81b1c05033dc4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c78785ce620c1aea0334db89d0f1f281ba50a3d3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.dscp_ress \u003d self.dscp_res + \u0027s\u0027"},{"line_number":32,"context_line":"        self.dscp_cmd_ress \u003d self.dscp_cmd_res + \u0027s\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_create_dscp_marking_rule_with_dscp_mark(self):"},{"line_number":35,"context_line":"        cmd \u003d dscp_rule.CreateQoSDscpMarkingRule(test_cli20.MyApp(sys.stdout),"},{"line_number":36,"context_line":"                                                 None)"},{"line_number":37,"context_line":"        my_id \u003d \u0027my-id\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_49850105","line":34,"updated":"2016-02-05 03:52:10.000000000","message":"Plz address PS9 comment.\n\nHow about adding a test-case for verifying invalid dscp mark value say:\n * less than 0\n * between 0 - 8\n * one of 50/52/54\n * greater than 56","commit_id":"c2fc391ac1f67b38769460a911a4ff09d2b9a2c8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"cd6f6ed7ff5a8cdbc6fd32c60c95b04e75b7f764","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                   parent_id\u003dpolicy_id)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_create_dscp_marking_rule_with_invalid_dscp_mark(self):"},{"line_number":50,"context_line":"        cmd \u003d dscp_rule.CreateQoSDscpMarkingRule(test_cli20.MyApp(sys.stdout),"},{"line_number":51,"context_line":"                                                 None)"},{"line_number":52,"context_line":"        my_id \u003d \u0027my-id\u0027"},{"line_number":53,"context_line":"        dscp_mark \u003d \u002760\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_dc5603ce","line":50,"updated":"2016-02-09 05:06:16.000000000","message":"IMO, let\u0027s test for all the boundary values.","commit_id":"09661eae7d80278af27aa76c458e93dd823e99ee"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"5f6c299a41d29ab1dabe98284760da68d8d7e967","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                   parent_id\u003dpolicy_id)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def test_create_dscp_marking_rule_with_invalid_dscp_mark(self):"},{"line_number":50,"context_line":"        cmd \u003d dscp_rule.CreateQoSDscpMarkingRule(test_cli20.MyApp(sys.stdout),"},{"line_number":51,"context_line":"                                                 None)"},{"line_number":52,"context_line":"        my_id \u003d \u0027my-id\u0027"},{"line_number":53,"context_line":"        dscp_mark \u003d \u002760\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a5ae5dd_86c01fe2","line":50,"in_reply_to":"5a5ae5dd_dc5603ce","updated":"2016-02-09 15:06:38.000000000","message":"Smart.  Done.","commit_id":"09661eae7d80278af27aa76c458e93dd823e99ee"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4664a8165f159350d9a1b999fc05d790aca99d80","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        cmd \u003d dscp_rule.CreateQoSDscpMarkingRule(test_cli20.MyApp(sys.stdout),"},{"line_number":51,"context_line":"                                                 None)"},{"line_number":52,"context_line":"        my_id \u003d \u0027my-id\u0027"},{"line_number":53,"context_line":"        dscp_mark \u003d \u002756\u0027"},{"line_number":54,"context_line":"        policy_id \u003d \u0027policy_id\u0027"},{"line_number":55,"context_line":"        args \u003d [\u0027--dscp-mark\u0027, dscp_mark, policy_id]"},{"line_number":56,"context_line":"        position_names \u003d [\u0027dscp_mark\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_5d40bb56","line":53,"range":{"start_line":53,"start_character":14,"end_line":53,"end_character":15},"updated":"2016-02-10 11:02:47.000000000","message":"This test-case code looks exactly the same as above testcase except the dscp_mark attribute value. How about defining a common function which will accept the dscp_mark value and does the validation. Following this style we can ensure less code duplication.\n\nMost of the code is duplicated for below testcases:\ntest_create_dscp_marking_rule_with_lowest_valid_dscp_mark\ntest_create_dscp_marking_rule_with_highest_valid_dscp_mark\ntest_create_dscp_marking_rule_with_highest_invalid_dscp_mark\ntest_create_dscp_marking_rule_with_invalid_dscp_mark\ntest_create_dscp_marking_rule_with_lowest_invalid_dscp_mark","commit_id":"7b63e13b6ab4e8f4eb17105b405e15c36efd97ad"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"4225d1a4061c1bd1c62bbd594ddbe5a13445c412","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        cmd \u003d dscp_rule.CreateQoSDscpMarkingRule(test_cli20.MyApp(sys.stdout),"},{"line_number":51,"context_line":"                                                 None)"},{"line_number":52,"context_line":"        my_id \u003d \u0027my-id\u0027"},{"line_number":53,"context_line":"        dscp_mark \u003d \u002756\u0027"},{"line_number":54,"context_line":"        policy_id \u003d \u0027policy_id\u0027"},{"line_number":55,"context_line":"        args \u003d [\u0027--dscp-mark\u0027, dscp_mark, policy_id]"},{"line_number":56,"context_line":"        position_names \u003d [\u0027dscp_mark\u0027]"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a57f1b5_81b55032","line":53,"range":{"start_line":53,"start_character":14,"end_line":53,"end_character":15},"in_reply_to":"3a57f1b5_5d40bb56","updated":"2016-02-10 19:56:23.000000000","message":"Excellent.  Your idea is much, much better.  Thank you so much for this.","commit_id":"7b63e13b6ab4e8f4eb17105b405e15c36efd97ad"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"29dd81fc13427a8a629d2db5e2341f6e862565db","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        policy_id \u003d \u0027policy_id\u0027"},{"line_number":40,"context_line":"        position_names \u003d [\u0027dscp_mark\u0027]"},{"line_number":41,"context_line":"        valid_dscp_marks \u003d [\u00270\u0027, \u002756\u0027]"},{"line_number":42,"context_line":"        invalid_dscp_marks \u003d [\u0027-1\u0027, \u002719\u0027, \u002757\u0027, \u002758\u0027]"},{"line_number":43,"context_line":"        for dscp_mark in valid_dscp_marks:"},{"line_number":44,"context_line":"            args \u003d [\u0027--dscp-mark\u0027, dscp_mark, policy_id]"},{"line_number":45,"context_line":"            position_values \u003d [dscp_mark]"}],"source_content_type":"text/x-python","patch_set":19,"id":"bae84128_1716b4f0","line":42,"updated":"2016-02-23 07:36:23.000000000","message":"include 42 \u0026 44 as well","commit_id":"7101a9b46d8c52c3f3a797971793ac249338c1f0"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"fa242eb3750bcb15367fc8137c9df687f065af56","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        policy_id \u003d \u0027policy_id\u0027"},{"line_number":40,"context_line":"        position_names \u003d [\u0027dscp_mark\u0027]"},{"line_number":41,"context_line":"        valid_dscp_marks \u003d [\u00270\u0027, \u002756\u0027]"},{"line_number":42,"context_line":"        invalid_dscp_marks \u003d [\u0027-1\u0027, \u002719\u0027, \u002757\u0027, \u002758\u0027]"},{"line_number":43,"context_line":"        for dscp_mark in valid_dscp_marks:"},{"line_number":44,"context_line":"            args \u003d [\u0027--dscp-mark\u0027, dscp_mark, policy_id]"},{"line_number":45,"context_line":"            position_values \u003d [dscp_mark]"}],"source_content_type":"text/x-python","patch_set":19,"id":"bae84128_f8804ac1","line":42,"in_reply_to":"bae84128_1716b4f0","updated":"2016-02-23 15:24:42.000000000","message":"Done","commit_id":"7101a9b46d8c52c3f3a797971793ac249338c1f0"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"afb01d0895f693fe7ea347989efaf85e80d499a9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        cmd \u003d dscp_rule.UpdateQoSDscpMarkingRule(test_cli20.MyApp(sys.stdout),"},{"line_number":63,"context_line":"                                                 None)"},{"line_number":64,"context_line":"        my_id \u003d \u0027my-id\u0027"},{"line_number":65,"context_line":"        dscp_mark \u003d \u002756\u0027"},{"line_number":66,"context_line":"        policy_id \u003d \u0027policy_id\u0027"},{"line_number":67,"context_line":"        args \u003d [\u0027--dscp-mark\u0027, dscp_mark,"},{"line_number":68,"context_line":"                my_id, policy_id]"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_eb563ed1","line":65,"updated":"2016-02-11 11:27:53.000000000","message":"This testcase looks useless as you have already covered this  @L41","commit_id":"7101a9b46d8c52c3f3a797971793ac249338c1f0"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ce215d0cd21c4925e603c7e23ff182e03d8c7064","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        cmd \u003d dscp_rule.UpdateQoSDscpMarkingRule(test_cli20.MyApp(sys.stdout),"},{"line_number":63,"context_line":"                                                 None)"},{"line_number":64,"context_line":"        my_id \u003d \u0027my-id\u0027"},{"line_number":65,"context_line":"        dscp_mark \u003d \u002756\u0027"},{"line_number":66,"context_line":"        policy_id \u003d \u0027policy_id\u0027"},{"line_number":67,"context_line":"        args \u003d [\u0027--dscp-mark\u0027, dscp_mark,"},{"line_number":68,"context_line":"                my_id, policy_id]"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_4c5bde2e","line":65,"in_reply_to":"3a57f1b5_1193c0a4","updated":"2016-02-11 14:49:47.000000000","message":"Ohhh... My mistake ;)","commit_id":"7101a9b46d8c52c3f3a797971793ac249338c1f0"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"510cdf223016e483fa1cec98ead5376273a73344","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        cmd \u003d dscp_rule.UpdateQoSDscpMarkingRule(test_cli20.MyApp(sys.stdout),"},{"line_number":63,"context_line":"                                                 None)"},{"line_number":64,"context_line":"        my_id \u003d \u0027my-id\u0027"},{"line_number":65,"context_line":"        dscp_mark \u003d \u002756\u0027"},{"line_number":66,"context_line":"        policy_id \u003d \u0027policy_id\u0027"},{"line_number":67,"context_line":"        args \u003d [\u0027--dscp-mark\u0027, dscp_mark,"},{"line_number":68,"context_line":"                my_id, policy_id]"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a57f1b5_1193c0a4","line":65,"in_reply_to":"3a57f1b5_eb563ed1","updated":"2016-02-11 13:47:33.000000000","message":"This is actually testing the update and not the create vikram, check line 46 vs. 69 ;).","commit_id":"7101a9b46d8c52c3f3a797971793ac249338c1f0"}],"neutronclient/tests/unit/qos/test_cli20_rule.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"866b986e74f392cffda2e1552d2362d4b64de22e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutronclient.tests.unit import test_cli20"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class CLITestV20QoSRuleJSON(test_cli20.CLITestV20Base):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    non_admin_status_resources \u003d [\u0027bandwidth_limit_rule\u0027, \u0027dscp_marking_rule\u0027]"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_108f1ccd","line":25,"updated":"2016-01-14 07:00:18.000000000","message":"Let\u0027s break this file into test_cli20_bandwidth_limit_rule.py and test_cli20_dscp_marking_rule.py, otherwise this file will just keep growing. Eventually we can 3 files.. \n\ntest_cli20_rule.py\ntest_cli20_bandwidth_limit_rule.py \ntest_cli20_dscp_marking_rule.py","commit_id":"e7ea75a57bd7faa869a96f60e2c1c05586d2be55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"81cdc2c78b15399dc29b5803411121296ee9132d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutronclient.tests.unit import test_cli20"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class CLITestV20QoSRuleJSON(test_cli20.CLITestV20Base):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    non_admin_status_resources \u003d [\u0027bandwidth_limit_rule\u0027, \u0027dscp_marking_rule\u0027]"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_59de4240","line":25,"in_reply_to":"da6ed579_108f1ccd","updated":"2016-01-22 04:21:12.000000000","message":"+1","commit_id":"e7ea75a57bd7faa869a96f60e2c1c05586d2be55"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"866b986e74f392cffda2e1552d2362d4b64de22e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.cmd_ress \u003d \u0027qos_bandwidth_limit_rules\u0027"},{"line_number":35,"context_line":"        self.dscp_res \u003d \u0027dscp_marking_rule\u0027"},{"line_number":36,"context_line":"        self.dscp_cmd_res \u003d \u0027qos_dscp_marking_rule\u0027"},{"line_number":37,"context_line":"        self.dscp_ress \u003d \u0027dscp_marking_rules\u0027"},{"line_number":38,"context_line":"        self.dscp_cmd_ress \u003d \u0027qos_dscp_marking_rules\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_create_bandwidth_limit_rule_with_max_kbps(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_f075a8f9","line":37,"updated":"2016-01-14 07:00:18.000000000","message":"I would prefer self.dscp_ress \u003d self.dscp_res + \u0027s\u0027","commit_id":"e7ea75a57bd7faa869a96f60e2c1c05586d2be55"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"81cdc2c78b15399dc29b5803411121296ee9132d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.cmd_ress \u003d \u0027qos_bandwidth_limit_rules\u0027"},{"line_number":35,"context_line":"        self.dscp_res \u003d \u0027dscp_marking_rule\u0027"},{"line_number":36,"context_line":"        self.dscp_cmd_res \u003d \u0027qos_dscp_marking_rule\u0027"},{"line_number":37,"context_line":"        self.dscp_ress \u003d \u0027dscp_marking_rules\u0027"},{"line_number":38,"context_line":"        self.dscp_cmd_ress \u003d \u0027qos_dscp_marking_rules\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_create_bandwidth_limit_rule_with_max_kbps(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_d9c9d279","line":37,"in_reply_to":"da6ed579_f075a8f9","updated":"2016-01-22 04:21:12.000000000","message":"something tells me resource_plural attribute from the main file can be used here....","commit_id":"e7ea75a57bd7faa869a96f60e2c1c05586d2be55"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"866b986e74f392cffda2e1552d2362d4b64de22e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.dscp_res \u003d \u0027dscp_marking_rule\u0027"},{"line_number":36,"context_line":"        self.dscp_cmd_res \u003d \u0027qos_dscp_marking_rule\u0027"},{"line_number":37,"context_line":"        self.dscp_ress \u003d \u0027dscp_marking_rules\u0027"},{"line_number":38,"context_line":"        self.dscp_cmd_ress \u003d \u0027qos_dscp_marking_rules\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_create_bandwidth_limit_rule_with_max_kbps(self):"},{"line_number":41,"context_line":"        cmd \u003d bw_rule.CreateQoSBandwidthLimitRule(test_cli20.MyApp(sys.stdout),"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_10739c16","line":38,"updated":"2016-01-14 07:00:18.000000000","message":"ditto","commit_id":"e7ea75a57bd7faa869a96f60e2c1c05586d2be55"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d32fd8f2d177a65faf5a6158a47d9a32cec2d5c8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        resources \u003d \u0027rule_types\u0027"},{"line_number":33,"context_line":"        cmd_resources \u003d \u0027qos_rule_types\u0027"},{"line_number":34,"context_line":"        response_contents \u003d [{\u0027type\u0027: \u0027bandwidth_limit\u0027,"},{"line_number":35,"context_line":"                             \u0027type\u0027: \u0027dscp_marking\u0027}]"},{"line_number":36,"context_line":"        cmd \u003d qos_rule.ListQoSRuleTypes(test_cli20.MyApp(sys.stdout),"},{"line_number":37,"context_line":"                                        None)"},{"line_number":38,"context_line":"        self._test_list_resources(resources, cmd, True,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_514ae926","line":35,"updated":"2016-03-03 17:01:24.000000000","message":"indentation a bit broken","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"dc248281b6a4daf266b63a615df4e55d8a5ed3ca","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        resources \u003d \u0027rule_types\u0027"},{"line_number":33,"context_line":"        cmd_resources \u003d \u0027qos_rule_types\u0027"},{"line_number":34,"context_line":"        response_contents \u003d [{\u0027type\u0027: \u0027bandwidth_limit\u0027,"},{"line_number":35,"context_line":"                             \u0027type\u0027: \u0027dscp_marking\u0027}]"},{"line_number":36,"context_line":"        cmd \u003d qos_rule.ListQoSRuleTypes(test_cli20.MyApp(sys.stdout),"},{"line_number":37,"context_line":"                                        None)"},{"line_number":38,"context_line":"        self._test_list_resources(resources, cmd, True,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_86b8b276","line":35,"in_reply_to":"7af24918_514ae926","updated":"2016-03-03 17:38:27.000000000","message":"Done","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7ac2c4bf6aafbb9bb8f6cf1431d9763f825a1b88","unresolved":false,"context_lines":[{"line_number":1589,"context_line":"    def list_bandwidth_limit_rules(self, policy_id,"},{"line_number":1590,"context_line":"                                   retrieve_all\u003dTrue, **_params):"},{"line_number":1591,"context_line":"        \"\"\"Fetches a list of all qos rules for the given policy.\"\"\""},{"line_number":1592,"context_line":"        return self.list(\u0027bandwidth_limit_rules\u0027,"},{"line_number":1593,"context_line":"                         self.qos_bandwidth_limit_rules_path % policy_id,"},{"line_number":1594,"context_line":"                         retrieve_all, **_params)"},{"line_number":1595,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_d991fe53","line":1592,"updated":"2016-02-04 05:11:15.000000000","message":"%s/qos rules/bandwidth limit rules/g","commit_id":"7725dad059be73225c42f858ecd81b1c05033dc4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7ac2c4bf6aafbb9bb8f6cf1431d9763f825a1b88","unresolved":false,"context_lines":[{"line_number":1620,"context_line":"    @APIParamsCall"},{"line_number":1621,"context_line":"    def list_dscp_marking_rules(self, policy_id,"},{"line_number":1622,"context_line":"                                retrieve_all\u003dTrue, **_params):"},{"line_number":1623,"context_line":"        \"\"\"Fetches a list of all qos rules for the given policy.\"\"\""},{"line_number":1624,"context_line":"        return self.list(\u0027dscp_marking_rules\u0027,"},{"line_number":1625,"context_line":"                         self.qos_dscp_marking_rules_path % policy_id,"},{"line_number":1626,"context_line":"                         retrieve_all, **_params)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_59a50eb3","line":1623,"updated":"2016-02-04 05:11:15.000000000","message":"%s/qos rules/dscp marking rules/g","commit_id":"7725dad059be73225c42f858ecd81b1c05033dc4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c78785ce620c1aea0334db89d0f1f281ba50a3d3","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"    @APIParamsCall"},{"line_number":1589,"context_line":"    def list_bandwidth_limit_rules(self, policy_id,"},{"line_number":1590,"context_line":"                                   retrieve_all\u003dTrue, **_params):"},{"line_number":1591,"context_line":"        \"\"\"Fetches a list of all qos rules for the given policy.\"\"\""},{"line_number":1592,"context_line":"        return self.list(\u0027bandwidth_limit_rules\u0027,"},{"line_number":1593,"context_line":"                         self.qos_bandwidth_limit_rules_path % policy_id,"},{"line_number":1594,"context_line":"                         retrieve_all, **_params)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_89ce992c","line":1591,"updated":"2016-02-05 03:52:10.000000000","message":"nit: Can you change \u0027qos rules\u0027 to \u0027bandwidth limit rule\u0027?","commit_id":"c2fc391ac1f67b38769460a911a4ff09d2b9a2c8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c78785ce620c1aea0334db89d0f1f281ba50a3d3","unresolved":false,"context_lines":[{"line_number":1620,"context_line":"    @APIParamsCall"},{"line_number":1621,"context_line":"    def list_dscp_marking_rules(self, policy_id,"},{"line_number":1622,"context_line":"                                retrieve_all\u003dTrue, **_params):"},{"line_number":1623,"context_line":"        \"\"\"Fetches a list of all qos rules for the given policy.\"\"\""},{"line_number":1624,"context_line":"        return self.list(\u0027dscp_marking_rules\u0027,"},{"line_number":1625,"context_line":"                         self.qos_dscp_marking_rules_path % policy_id,"},{"line_number":1626,"context_line":"                         retrieve_all, **_params)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_8967794c","line":1623,"updated":"2016-02-05 03:52:10.000000000","message":"plz change \"qos rules\" to \"dscp marking rule\"","commit_id":"c2fc391ac1f67b38769460a911a4ff09d2b9a2c8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c78785ce620c1aea0334db89d0f1f281ba50a3d3","unresolved":false,"context_lines":[{"line_number":1627,"context_line":""},{"line_number":1628,"context_line":"    @APIParamsCall"},{"line_number":1629,"context_line":"    def show_dscp_marking_rule(self, rule, policy, body\u003dNone):"},{"line_number":1630,"context_line":"        \"\"\"Shows a new dscp marking rule.\"\"\""},{"line_number":1631,"context_line":"        return self.get(self.qos_dscp_marking_rule_path %"},{"line_number":1632,"context_line":"                        (policy, rule), body\u003dbody)"},{"line_number":1633,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5a5ae5dd_e9a5cda1","line":1630,"updated":"2016-02-05 03:52:10.000000000","message":"new??? can\u0027t we display an old rule?? I think we can word it as ---\n\n\"\"\"Fetches information of a certain dscp marking rule.\"\"\"","commit_id":"c2fc391ac1f67b38769460a911a4ff09d2b9a2c8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d32fd8f2d177a65faf5a6158a47d9a32cec2d5c8","unresolved":false,"context_lines":[{"line_number":1830,"context_line":"    @APIParamsCall"},{"line_number":1831,"context_line":"    def list_dscp_marking_rules(self, policy_id,"},{"line_number":1832,"context_line":"                                retrieve_all\u003dTrue, **_params):"},{"line_number":1833,"context_line":"        \"\"\"Fetches a list of all dscp marking rules for the given policy.\"\"\""},{"line_number":1834,"context_line":"        return self.list(\u0027dscp_marking_rules\u0027,"},{"line_number":1835,"context_line":"                         self.qos_dscp_marking_rules_path % policy_id,"},{"line_number":1836,"context_line":"                         retrieve_all, **_params)"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_91fe31ac","line":1833,"range":{"start_line":1833,"start_character":33,"end_line":1833,"end_character":37},"updated":"2016-03-03 17:01:24.000000000","message":"DSCP","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"dc248281b6a4daf266b63a615df4e55d8a5ed3ca","unresolved":false,"context_lines":[{"line_number":1830,"context_line":"    @APIParamsCall"},{"line_number":1831,"context_line":"    def list_dscp_marking_rules(self, policy_id,"},{"line_number":1832,"context_line":"                                retrieve_all\u003dTrue, **_params):"},{"line_number":1833,"context_line":"        \"\"\"Fetches a list of all dscp marking rules for the given policy.\"\"\""},{"line_number":1834,"context_line":"        return self.list(\u0027dscp_marking_rules\u0027,"},{"line_number":1835,"context_line":"                         self.qos_dscp_marking_rules_path % policy_id,"},{"line_number":1836,"context_line":"                         retrieve_all, **_params)"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_e67a56bc","line":1833,"range":{"start_line":1833,"start_character":33,"end_line":1833,"end_character":37},"in_reply_to":"7af24918_91fe31ac","updated":"2016-03-03 17:38:27.000000000","message":"Done","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d32fd8f2d177a65faf5a6158a47d9a32cec2d5c8","unresolved":false,"context_lines":[{"line_number":1837,"context_line":""},{"line_number":1838,"context_line":"    @APIParamsCall"},{"line_number":1839,"context_line":"    def show_dscp_marking_rule(self, rule, policy, body\u003dNone):"},{"line_number":1840,"context_line":"        \"\"\"Shows information of a certain dscp marking rule.\"\"\""},{"line_number":1841,"context_line":"        return self.get(self.qos_dscp_marking_rule_path %"},{"line_number":1842,"context_line":"                        (policy, rule), body\u003dbody)"},{"line_number":1843,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_f12df546","line":1840,"range":{"start_line":1840,"start_character":42,"end_line":1840,"end_character":46},"updated":"2016-03-03 17:01:24.000000000","message":"ditto","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"dc248281b6a4daf266b63a615df4e55d8a5ed3ca","unresolved":false,"context_lines":[{"line_number":1837,"context_line":""},{"line_number":1838,"context_line":"    @APIParamsCall"},{"line_number":1839,"context_line":"    def show_dscp_marking_rule(self, rule, policy, body\u003dNone):"},{"line_number":1840,"context_line":"        \"\"\"Shows information of a certain dscp marking rule.\"\"\""},{"line_number":1841,"context_line":"        return self.get(self.qos_dscp_marking_rule_path %"},{"line_number":1842,"context_line":"                        (policy, rule), body\u003dbody)"},{"line_number":1843,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_2681de8f","line":1840,"range":{"start_line":1840,"start_character":42,"end_line":1840,"end_character":46},"in_reply_to":"7af24918_f12df546","updated":"2016-03-03 17:38:27.000000000","message":"Done","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d32fd8f2d177a65faf5a6158a47d9a32cec2d5c8","unresolved":false,"context_lines":[{"line_number":1843,"context_line":""},{"line_number":1844,"context_line":"    @APIParamsCall"},{"line_number":1845,"context_line":"    def create_dscp_marking_rule(self, policy, body\u003dNone):"},{"line_number":1846,"context_line":"        \"\"\"Creates a new dscp marking rule.\"\"\""},{"line_number":1847,"context_line":"        return self.post(self.qos_dscp_marking_rules_path % policy,"},{"line_number":1848,"context_line":"                         body\u003dbody)"},{"line_number":1849,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_d13279a6","line":1846,"range":{"start_line":1846,"start_character":25,"end_line":1846,"end_character":29},"updated":"2016-03-03 17:01:24.000000000","message":"ditto","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"dc248281b6a4daf266b63a615df4e55d8a5ed3ca","unresolved":false,"context_lines":[{"line_number":1843,"context_line":""},{"line_number":1844,"context_line":"    @APIParamsCall"},{"line_number":1845,"context_line":"    def create_dscp_marking_rule(self, policy, body\u003dNone):"},{"line_number":1846,"context_line":"        \"\"\"Creates a new dscp marking rule.\"\"\""},{"line_number":1847,"context_line":"        return self.post(self.qos_dscp_marking_rules_path % policy,"},{"line_number":1848,"context_line":"                         body\u003dbody)"},{"line_number":1849,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_664da699","line":1846,"range":{"start_line":1846,"start_character":25,"end_line":1846,"end_character":29},"in_reply_to":"7af24918_d13279a6","updated":"2016-03-03 17:38:27.000000000","message":"Done","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d32fd8f2d177a65faf5a6158a47d9a32cec2d5c8","unresolved":false,"context_lines":[{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"    @APIParamsCall"},{"line_number":1851,"context_line":"    def update_dscp_marking_rule(self, rule, policy, body\u003dNone):"},{"line_number":1852,"context_line":"        \"\"\"Updates a dscp marking rule.\"\"\""},{"line_number":1853,"context_line":"        return self.put(self.qos_dscp_marking_rule_path %"},{"line_number":1854,"context_line":"                        (policy, rule), body\u003dbody)"},{"line_number":1855,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_71228553","line":1852,"range":{"start_line":1852,"start_character":21,"end_line":1852,"end_character":25},"updated":"2016-03-03 17:01:24.000000000","message":"ditto","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"dc248281b6a4daf266b63a615df4e55d8a5ed3ca","unresolved":false,"context_lines":[{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"    @APIParamsCall"},{"line_number":1851,"context_line":"    def update_dscp_marking_rule(self, rule, policy, body\u003dNone):"},{"line_number":1852,"context_line":"        \"\"\"Updates a dscp marking rule.\"\"\""},{"line_number":1853,"context_line":"        return self.put(self.qos_dscp_marking_rule_path %"},{"line_number":1854,"context_line":"                        (policy, rule), body\u003dbody)"},{"line_number":1855,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_46506a32","line":1852,"range":{"start_line":1852,"start_character":21,"end_line":1852,"end_character":25},"in_reply_to":"7af24918_71228553","updated":"2016-03-03 17:38:27.000000000","message":"Done","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d32fd8f2d177a65faf5a6158a47d9a32cec2d5c8","unresolved":false,"context_lines":[{"line_number":1855,"context_line":""},{"line_number":1856,"context_line":"    @APIParamsCall"},{"line_number":1857,"context_line":"    def delete_dscp_marking_rule(self, rule, policy):"},{"line_number":1858,"context_line":"        \"\"\"Deletes a dscp marking rule.\"\"\""},{"line_number":1859,"context_line":"        return self.delete(self.qos_dscp_marking_rule_path %"},{"line_number":1860,"context_line":"                           (policy, rule))"},{"line_number":1861,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_b1188d1f","line":1858,"range":{"start_line":1858,"start_character":21,"end_line":1858,"end_character":25},"updated":"2016-03-03 17:01:24.000000000","message":"ditto","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"dc248281b6a4daf266b63a615df4e55d8a5ed3ca","unresolved":false,"context_lines":[{"line_number":1855,"context_line":""},{"line_number":1856,"context_line":"    @APIParamsCall"},{"line_number":1857,"context_line":"    def delete_dscp_marking_rule(self, rule, policy):"},{"line_number":1858,"context_line":"        \"\"\"Deletes a dscp marking rule.\"\"\""},{"line_number":1859,"context_line":"        return self.delete(self.qos_dscp_marking_rule_path %"},{"line_number":1860,"context_line":"                           (policy, rule))"},{"line_number":1861,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_8646f278","line":1858,"range":{"start_line":1858,"start_character":21,"end_line":1858,"end_character":25},"in_reply_to":"7af24918_b1188d1f","updated":"2016-03-03 17:38:27.000000000","message":"Done","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"}],"releasenotes/notes/dscp_qos-4a26d3c0363624b0.yaml":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c78785ce620c1aea0334db89d0f1f281ba50a3d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Addition of DSCP Marking commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - List, show, delete, update, create new dscp markings."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a5ae5dd_c9ed71b8","line":3,"updated":"2016-02-05 03:52:10.000000000","message":"Adding new QoS DSCP marking rule commands.","commit_id":"c2fc391ac1f67b38769460a911a4ff09d2b9a2c8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c78785ce620c1aea0334db89d0f1f281ba50a3d3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Addition of DSCP Marking commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - List, show, delete, update, create new dscp markings."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5a5ae5dd_e96f0d29","line":5,"updated":"2016-02-05 03:52:10.000000000","message":"New create, update, list, show and delete commands lines are added for qos dscp marking rule functionality.","commit_id":"c2fc391ac1f67b38769460a911a4ff09d2b9a2c8"},{"author":{"_account_id":14033,"name":"James Reeves","email":"james.reeves5546@gmail.com","username":"trombongod"},"change_message_id":"4bf63c2ded6ad2d3edf9c4552aad809d2c3811ef","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS DSCP marking rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create,update,list,show and delete command lines are added for qos dscp marking rule functionality."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5a5ae5dd_38d98357","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":42},"updated":"2016-02-08 18:03:28.000000000","message":"New create, update, list, show, and delete","commit_id":"c3bbf14c04b345f984dfb124fd44d008bce88e47"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"e981f387865920f5475091573ceb5fe079acb75a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS DSCP marking rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create,update,list,show and delete command lines are added for qos dscp marking rule functionality."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5a5ae5dd_f8452b6e","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":42},"in_reply_to":"5a5ae5dd_38d98357","updated":"2016-02-08 18:13:59.000000000","message":"Done","commit_id":"c3bbf14c04b345f984dfb124fd44d008bce88e47"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"cd6f6ed7ff5a8cdbc6fd32c60c95b04e75b7f764","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS DSCP marking rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete command lines are added for qos dscp marking rule functionality."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5a5ae5dd_dc24c361","line":5,"updated":"2016-02-09 05:06:16.000000000","message":"Let\u0027s have a max of 80 chars per line for better readability during review.","commit_id":"09661eae7d80278af27aa76c458e93dd823e99ee"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"5f6c299a41d29ab1dabe98284760da68d8d7e967","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS DSCP marking rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete command lines are added for qos dscp marking rule functionality."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5a5ae5dd_a6a99b26","line":5,"in_reply_to":"5a5ae5dd_dc24c361","updated":"2016-02-09 15:06:38.000000000","message":"Done","commit_id":"09661eae7d80278af27aa76c458e93dd823e99ee"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4664a8165f159350d9a1b999fc05d790aca99d80","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS DSCP marking rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete command lines are added for qos "},{"line_number":6,"context_line":"    dscp marking rule functionality."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a57f1b5_0f6e8ac9","line":5,"updated":"2016-02-10 11:02:47.000000000","message":"remove the extra space from the end.","commit_id":"7b63e13b6ab4e8f4eb17105b405e15c36efd97ad"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"4225d1a4061c1bd1c62bbd594ddbe5a13445c412","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS DSCP marking rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete command lines are added for qos "},{"line_number":6,"context_line":"    dscp marking rule functionality."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a57f1b5_21833c58","line":5,"in_reply_to":"3a57f1b5_0f6e8ac9","updated":"2016-02-10 19:56:23.000000000","message":"Done","commit_id":"7b63e13b6ab4e8f4eb17105b405e15c36efd97ad"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d32fd8f2d177a65faf5a6158a47d9a32cec2d5c8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS DSCP marking rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete command lines are added for qos"},{"line_number":6,"context_line":"    dscp marking rule functionality."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7af24918_d1c0b952","line":5,"range":{"start_line":5,"start_character":47,"end_line":5,"end_character":60},"updated":"2016-03-03 17:01:24.000000000","message":"commands","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"dc248281b6a4daf266b63a615df4e55d8a5ed3ca","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS DSCP marking rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete command lines are added for qos"},{"line_number":6,"context_line":"    dscp marking rule functionality."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7af24918_e628969c","line":5,"range":{"start_line":5,"start_character":47,"end_line":5,"end_character":60},"in_reply_to":"7af24918_d1c0b952","updated":"2016-03-03 17:38:27.000000000","message":"Done","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d32fd8f2d177a65faf5a6158a47d9a32cec2d5c8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS DSCP marking rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete command lines are added for qos"},{"line_number":6,"context_line":"    dscp marking rule functionality."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7af24918_31b2bd06","line":6,"range":{"start_line":5,"start_character":75,"end_line":6,"end_character":8},"updated":"2016-03-03 17:01:24.000000000","message":"QoS DSCP","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"},{"author":{"_account_id":7244,"name":"Victor Howard","email":"victor.r.howard@gmail.com","username":"vichoward"},"change_message_id":"dc248281b6a4daf266b63a615df4e55d8a5ed3ca","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS DSCP marking rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete command lines are added for qos"},{"line_number":6,"context_line":"    dscp marking rule functionality."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7af24918_c623dabb","line":6,"range":{"start_line":5,"start_character":75,"end_line":6,"end_character":8},"in_reply_to":"7af24918_31b2bd06","updated":"2016-03-03 17:38:27.000000000","message":"Done","commit_id":"dc5162ef9ec1302aba164b7faae57e1a6894532d"}]}