)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d77d020e65192617fe4787c145fcc25b3f3774ca","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will show choices of allowed protocols for security group"},{"line_number":10,"context_line":"rule create and also indicate type and code in help when protocol is"},{"line_number":11,"context_line":"ICMP"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib79be78c253332e27991795e8add370ae351e9a6"},{"line_number":14,"context_line":"Closes-Bug: #1523063"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_17a7e90b","line":11,"updated":"2015-12-13 02:09:10.000000000","message":"nit  : full stop","commit_id":"19aa9a49b0f86f3701d6357ef1a5d44a518ce4a1"},{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"87cf11db1ee8878faca9c8fba1bb328120e21236","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will show choices of allowed protocols for security group"},{"line_number":10,"context_line":"rule create and also indicate type and code in help when protocol is"},{"line_number":11,"context_line":"ICMP"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib79be78c253332e27991795e8add370ae351e9a6"},{"line_number":14,"context_line":"Closes-Bug: #1523063"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_6ba9998f","line":11,"in_reply_to":"7a740942_17a7e90b","updated":"2015-12-14 04:25:18.000000000","message":"+1","commit_id":"19aa9a49b0f86f3701d6357ef1a5d44a518ce4a1"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"0f545f5ef87d8b49b0be365720f8719425669a10","unresolved":false,"context_lines":[{"line_number":10,"context_line":"rule create and also indicate type and code in help when protocol is"},{"line_number":11,"context_line":"ICMP."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib79be78c253332e27991795e8add370ae351e9a6"},{"line_number":16,"context_line":"Closes-Bug: #1523063"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a7b0d38_447174a7","line":13,"updated":"2015-12-27 05:04:13.000000000","message":"Please provide some information about the impact.","commit_id":"5fb1025e7d15939b9975565c342b333e1a635ff7"},{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"0715213e0c8276040dc690e77e5daf9a2a6f4838","unresolved":false,"context_lines":[{"line_number":10,"context_line":"rule create and also indicate type and code in help when protocol is"},{"line_number":11,"context_line":"ICMP."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib79be78c253332e27991795e8add370ae351e9a6"},{"line_number":16,"context_line":"Closes-Bug: #1523063"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a7b0d38_9891f449","line":13,"in_reply_to":"1a7b0d38_447174a7","updated":"2015-12-28 05:03:22.000000000","message":"+1","commit_id":"5fb1025e7d15939b9975565c342b333e1a635ff7"}],"neutronclient/common/utils.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d77d020e65192617fe4787c145fcc25b3f3774ca","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def convert_to_lowercase(string):"},{"line_number":50,"context_line":"    return string.lower()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def get_client_class(api_name, version, version_map):"},{"line_number":54,"context_line":"    \"\"\"Returns the client class for the requested API version."}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_d7ade1e9","line":51,"updated":"2015-12-13 02:09:10.000000000","message":"Please make this patch dependent on https://review.openstack.org/#/c/140628/\n\nThe lowercase has already been taken care in that patch.\nThis is to avoid conflicts during merging of the patches  :)","commit_id":"19aa9a49b0f86f3701d6357ef1a5d44a518ce4a1"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4ee1468fa17adc81bdf0b82c72175cfef88a8ac1","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def generate_random_integer(range_begin\u003d0, range_end\u003d255):"},{"line_number":51,"context_line":"    return random.randint(range_begin, range_end)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def get_client_class(api_name, version, version_map):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_b425c209","line":51,"updated":"2015-12-29 02:56:15.000000000","message":"I am not sure if we can add a utility function for test. Why you don\u0027t use it directly in the test-cases.","commit_id":"8c6cc75eb8ce6009beb2ce09a9e22e5d65e64dd6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7f818d6cbfdd1eaf37ebaae76d781bc0148ca6cf","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def generate_random_integer(range_begin\u003d0, range_end\u003d255):"},{"line_number":51,"context_line":"    return random.randint(range_begin, range_end)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def get_client_class(api_name, version, version_map):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_91371be3","line":51,"in_reply_to":"1a7b0d38_b425c209","updated":"2015-12-29 20:49:28.000000000","message":"A method for testing should not be placed here.\nIn addition, if a method exists in utils, it should have corresponding unit tests.","commit_id":"8c6cc75eb8ce6009beb2ce09a9e22e5d65e64dd6"}],"neutronclient/neutron/v2_0/securitygroup.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"434d254ba16e0fbf80c71e81c36d610f76dcff8f","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet.\u0027),"},{"line_number":321,"context_line":"            choices\u003d[\u0027icmp\u0027, \u0027icmpv6\u0027, \u0027tcp\u0027, \u0027udp\u0027])"},{"line_number":322,"context_line":"        parser.add_argument("},{"line_number":323,"context_line":"            \u0027--port-range-min\u0027,"},{"line_number":324,"context_line":"            help\u003d_(\u0027Starting port range. For ICMP it is type.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_53e10f29","line":321,"updated":"2015-12-12 06:40:50.000000000","message":"how about adding type\u003dconvert_lowercase as well for allowing uppercase as well?","commit_id":"fe57fd19627dfc80b41a450507f6ec3c239e6f25"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0acc3ef79c8d46a10b7f951ee0ed668d6e7fa943","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet.\u0027),"},{"line_number":321,"context_line":"            choices\u003d[\u0027icmp\u0027, \u0027icmpv6\u0027, \u0027tcp\u0027, \u0027udp\u0027])"},{"line_number":322,"context_line":"        parser.add_argument("},{"line_number":323,"context_line":"            \u0027--port-range-min\u0027,"},{"line_number":324,"context_line":"            help\u003d_(\u0027Starting port range. For ICMP it is type.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_b6d5bee5","line":321,"in_reply_to":"7a740942_53e10f29","updated":"2015-12-12 14:37:00.000000000","message":"Okay will do that thanks","commit_id":"fe57fd19627dfc80b41a450507f6ec3c239e6f25"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d79510efd6d783ce8345277fba5a926d19a1ab26","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet.\u0027),"},{"line_number":321,"context_line":"            choices\u003d[\u0027icmp\u0027, \u0027icmpv6\u0027, \u0027tcp\u0027, \u0027udp\u0027])"},{"line_number":322,"context_line":"        parser.add_argument("},{"line_number":323,"context_line":"            \u0027--port-range-min\u0027,"},{"line_number":324,"context_line":"            help\u003d_(\u0027Starting port range. For ICMP it is type.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_0596d23d","line":321,"in_reply_to":"7a740942_b6d5bee5","updated":"2015-12-13 00:33:26.000000000","message":"We can specify an protocol number as well as the above listed names.\nThis changes is too strict.","commit_id":"fe57fd19627dfc80b41a450507f6ec3c239e6f25"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0819c8116b04a685486c5a4fa8e20b3a1649fb20","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        parser.add_argument("},{"line_number":320,"context_line":"            \u0027--protocol\u0027,"},{"line_number":321,"context_line":"            help\u003d_(\u0027Protocol of packet.\u0027),"},{"line_number":322,"context_line":"            choices\u003d[\u0027icmp\u0027, \u0027icmpv6\u0027, \u0027tcp\u0027, \u0027udp\u0027],"},{"line_number":323,"context_line":"            type\u003dutils.convert_to_lowercase)"},{"line_number":324,"context_line":"        parser.add_argument("},{"line_number":325,"context_line":"            \u0027--port-range-min\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_d7cf2154","line":322,"updated":"2015-12-13 15:19:42.000000000","message":"This choice is too strict as I mentioned in the previous patch set.\nWe can pass an integer to \u0027protocol\u0027 but this change prevents it.\n\nIn addition, I don\u0027t think it is a good idea to have the strict choices in neutronclient side. IMO these kind of validation can be done in the neutron server side. There are many IP protocol numbers/names and I don\u0027t think we can sync available lists between server and client easily.","commit_id":"19aa9a49b0f86f3701d6357ef1a5d44a518ce4a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d90e13167aa46f349b63e0807cc042ce36df275c","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        parser.add_argument("},{"line_number":320,"context_line":"            \u0027--protocol\u0027,"},{"line_number":321,"context_line":"            help\u003d_(\u0027Protocol of packet.\u0027),"},{"line_number":322,"context_line":"            choices\u003d[\u0027icmp\u0027, \u0027icmpv6\u0027, \u0027tcp\u0027, \u0027udp\u0027],"},{"line_number":323,"context_line":"            type\u003dutils.convert_to_lowercase)"},{"line_number":324,"context_line":"        parser.add_argument("},{"line_number":325,"context_line":"            \u0027--port-range-min\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_c6fce440","line":322,"in_reply_to":"7a740942_149d7809","updated":"2015-12-15 09:51:01.000000000","message":"I am okay to add more description in the help text.\nWe relies on validations in the server side.","commit_id":"19aa9a49b0f86f3701d6357ef1a5d44a518ce4a1"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"97e0fb9a78a75b7bad3c14fa2432c885b5b6ed5e","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        parser.add_argument("},{"line_number":320,"context_line":"            \u0027--protocol\u0027,"},{"line_number":321,"context_line":"            help\u003d_(\u0027Protocol of packet.\u0027),"},{"line_number":322,"context_line":"            choices\u003d[\u0027icmp\u0027, \u0027icmpv6\u0027, \u0027tcp\u0027, \u0027udp\u0027],"},{"line_number":323,"context_line":"            type\u003dutils.convert_to_lowercase)"},{"line_number":324,"context_line":"        parser.add_argument("},{"line_number":325,"context_line":"            \u0027--port-range-min\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_149d7809","line":322,"in_reply_to":"7a740942_d7cf2154","updated":"2015-12-14 15:54:30.000000000","message":"Akihiro I will remove choices. is it ok to add possible values in help mesage ? I think there is validation already on client side. i worked on patch to correct ethertype while creating sg rule. I think validation is already been done on server side ?","commit_id":"19aa9a49b0f86f3701d6357ef1a5d44a518ce4a1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d77d020e65192617fe4787c145fcc25b3f3774ca","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            type\u003dutils.convert_to_lowercase)"},{"line_number":324,"context_line":"        parser.add_argument("},{"line_number":325,"context_line":"            \u0027--port-range-min\u0027,"},{"line_number":326,"context_line":"            help\u003d_(\u0027Starting port range. For ICMP it is type.\u0027))"},{"line_number":327,"context_line":"        parser.add_argument("},{"line_number":328,"context_line":"            \u0027--port_range_min\u0027,"},{"line_number":329,"context_line":"            help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_77b66d3f","line":326,"updated":"2015-12-13 02:09:10.000000000","message":"Just wondering, why cant we use introduce something specific to ICMP instead of utilizing ports","commit_id":"19aa9a49b0f86f3701d6357ef1a5d44a518ce4a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0819c8116b04a685486c5a4fa8e20b3a1649fb20","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            type\u003dutils.convert_to_lowercase)"},{"line_number":324,"context_line":"        parser.add_argument("},{"line_number":325,"context_line":"            \u0027--port-range-min\u0027,"},{"line_number":326,"context_line":"            help\u003d_(\u0027Starting port range. For ICMP it is type.\u0027))"},{"line_number":327,"context_line":"        parser.add_argument("},{"line_number":328,"context_line":"            \u0027--port_range_min\u0027,"},{"line_number":329,"context_line":"            help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_c13d172c","line":326,"in_reply_to":"7a740942_77b66d3f","updated":"2015-12-13 15:19:42.000000000","message":"We are using port-range-min/max to specify ICMP type/code in our API definition, so I think it is good to have this kind of descriptions at least.\n\nIt is also good to add more clearer options for better usability, but it does not block adding this description.","commit_id":"19aa9a49b0f86f3701d6357ef1a5d44a518ce4a1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b97ca9e26330b4cca82bc0d2b452ffb75809f995","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            type\u003dutils.convert_to_lowercase)"},{"line_number":324,"context_line":"        parser.add_argument("},{"line_number":325,"context_line":"            \u0027--port-range-min\u0027,"},{"line_number":326,"context_line":"            help\u003d_(\u0027Starting port range. For ICMP it is type.\u0027))"},{"line_number":327,"context_line":"        parser.add_argument("},{"line_number":328,"context_line":"            \u0027--port_range_min\u0027,"},{"line_number":329,"context_line":"            help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_2bcdd165","line":326,"in_reply_to":"7a740942_c13d172c","updated":"2015-12-14 04:30:42.000000000","message":"Hi Akihiro, I agree that this implementation should not be blocked.\nJust considering that it would be better to have a different set of attributes for ICMP than port-min/max in the future.","commit_id":"19aa9a49b0f86f3701d6357ef1a5d44a518ce4a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0819c8116b04a685486c5a4fa8e20b3a1649fb20","unresolved":false,"context_lines":[{"line_number":329,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":330,"context_line":"        parser.add_argument("},{"line_number":331,"context_line":"            \u0027--port-range-max\u0027,"},{"line_number":332,"context_line":"            help\u003d_(\u0027Ending port range. For ICMP it is code.\u0027))"},{"line_number":333,"context_line":"        parser.add_argument("},{"line_number":334,"context_line":"            \u0027--port_range_max\u0027,"},{"line_number":335,"context_line":"            help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_2113bbb9","line":332,"updated":"2015-12-13 15:19:42.000000000","message":"Consider rewording:\n\n  For ICMP protocol, this specifies ICMP code; the valid value is [0..255].\n\nThis applies to ICMP type above too.","commit_id":"19aa9a49b0f86f3701d6357ef1a5d44a518ce4a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"546a30c5475651e599c03c9349a85cbf5910d63e","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet. Allowed values are \u0027"},{"line_number":321,"context_line":"                   \u0027icmp, icmpv6, tcp, udp\u0027))"},{"line_number":322,"context_line":"        parser.add_argument("},{"line_number":323,"context_line":"            \u0027--port-range-min\u0027,"},{"line_number":324,"context_line":"            help\u003d_(\u0027Starting port range. For ICMP it is type.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_d286a664","line":321,"updated":"2015-12-16 07:25:10.000000000","message":"This description is not correct. I think you need to describe the logic of https://github.com/openstack/neutron/blob/master/neutron/extensions/securitygroup.py#L137-L156 . We can pass an integer protocol value.","commit_id":"4b944b79200b63e75000063c4950cd0f0ad2c65b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"006389a946d7cbebab5457826b1c849e63a45f07","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet. Allowed values are \u0027"},{"line_number":321,"context_line":"                   \u0027icmp, icmpv6, tcp, udp\u0027))"},{"line_number":322,"context_line":"        parser.add_argument("},{"line_number":323,"context_line":"            \u0027--port-range-min\u0027,"},{"line_number":324,"context_line":"            help\u003d_(\u0027Starting port range. For ICMP it is type.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_5b5da813","line":321,"in_reply_to":"3a7e1126_dae439e1","updated":"2015-12-20 07:37:57.000000000","message":"@amotoki: I am confused with your saying \"We can pass an integer protocol value.\". If we allow an integer then this might change the behaviour. What you think?","commit_id":"4b944b79200b63e75000063c4950cd0f0ad2c65b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3ef4c223d8c9cd6cb5bcf902216e91ac9fdf48fd","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet. Allowed values are \u0027"},{"line_number":321,"context_line":"                   \u0027icmp, icmpv6, tcp, udp\u0027))"},{"line_number":322,"context_line":"        parser.add_argument("},{"line_number":323,"context_line":"            \u0027--port-range-min\u0027,"},{"line_number":324,"context_line":"            help\u003d_(\u0027Starting port range. For ICMP it is type.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_dae439e1","line":321,"in_reply_to":"5a710552_b82c1903","updated":"2015-12-19 14:52:49.000000000","message":"Are you proposing to change the current neutron API? The above document describes nova security group behavior. I know someone uses an integer value to specify other protocols and changing this breaks existing neutron users.","commit_id":"4b944b79200b63e75000063c4950cd0f0ad2c65b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"93ce7e4a79fd09bbef0ea4d6dd14d6e28e23bed3","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet. Allowed values are \u0027"},{"line_number":321,"context_line":"                   \u0027icmp, icmpv6, tcp, udp\u0027))"},{"line_number":322,"context_line":"        parser.add_argument("},{"line_number":323,"context_line":"            \u0027--port-range-min\u0027,"},{"line_number":324,"context_line":"            help\u003d_(\u0027Starting port range. For ICMP it is type.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_b82c1903","line":321,"in_reply_to":"5a710552_d286a664","updated":"2015-12-16 08:21:46.000000000","message":"I think passing an integer value will change user experience from the older version\u0027s.\n\nprotocol\nThe protocol that is matched by the security group rule. Valid values are null, tcp, udp, and icmp.\n\nhttp://docs.openstack.org/openstack-ops/content/security_groups.html","commit_id":"4b944b79200b63e75000063c4950cd0f0ad2c65b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"431652c267ab9cea29c7fae0069452f50577e7ae","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet. Allowed values are \u0027"},{"line_number":321,"context_line":"                   \u0027icmp, icmpv6, tcp, udp, null\u0027))"},{"line_number":322,"context_line":"        parser.add_argument("},{"line_number":323,"context_line":"            \u0027--port-range-min\u0027,"},{"line_number":324,"context_line":"            help\u003d_(\u0027Starting port range. For ICMP it is type.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a7b0d38_23f90781","line":321,"updated":"2015-12-23 18:24:23.000000000","message":"We can\u0027t specify null.\n\n  $ neutron security-group-rule-create --protocol null --remote-ip-prefix 0.0.0.0 default\n  Security group rule protocol null not supported. Only protocol values [None, \u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027] and integer representations [0 to 255] are supported.\n\nIn addition, please add a description about \u0027integer value\u0027.","commit_id":"455939a96eec099aea66334f1c02265c69e06a81"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4e6e574d40e49400f533e634ce6b20274646a574","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet. Allowed values are \u0027"},{"line_number":321,"context_line":"                   \u0027icmp, icmpv6, tcp, udp, null\u0027))"},{"line_number":322,"context_line":"        parser.add_argument("},{"line_number":323,"context_line":"            \u0027--port-range-min\u0027,"},{"line_number":324,"context_line":"            help\u003d_(\u0027Starting port range. For ICMP it is type.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a7b0d38_e2a52b04","line":321,"in_reply_to":"1a7b0d38_23f90781","updated":"2015-12-24 07:20:58.000000000","message":"Adding description about integer value need DOCImpact flag to be mentioned in the commit msg.","commit_id":"455939a96eec099aea66334f1c02265c69e06a81"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7f818d6cbfdd1eaf37ebaae76d781bc0148ca6cf","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet. Allowed values are \u0027"},{"line_number":321,"context_line":"                   \u0027[None, icmp, icmpv6, tcp, udp] and \u0027"},{"line_number":322,"context_line":"                   \u0027Integer Representations [0-255]\u0027))"},{"line_number":323,"context_line":"        parser.add_argument("},{"line_number":324,"context_line":"            \u0027--port-range-min\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_71414739","line":321,"updated":"2015-12-29 20:49:28.000000000","message":"Sorry that my last comment is incomplete.\n\nWhy do you need to add \u0027None\u0027 here?\n\nIf you specify \u0027None\u0027 to --protocol, you will get an error message. This means the help message is confusing. Could you consider dropping \u0027None\u0027 from the message?\n\n  $ neutron security-group-rule-create --protocol None default\n  Security group rule protocol None not supported. Only protocol values [None, \u0027tcp\u0027, \u0027udp\u0027, \u0027icmp\u0027, \u0027icmpv6\u0027] and integer representations [0 to 255] are supported.","commit_id":"8c6cc75eb8ce6009beb2ce09a9e22e5d65e64dd6"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c1049fc86eab77c702400f7760bf136d97d740b3","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet. Allowed values are \u0027"},{"line_number":321,"context_line":"                   \u0027[icmp, icmpv6, tcp, udp] and \u0027"},{"line_number":322,"context_line":"                   \u0027Integer Representations [0-255]\u0027))"},{"line_number":323,"context_line":"        parser.add_argument("},{"line_number":324,"context_line":"            \u0027--port-range-min\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_763ff525","line":321,"updated":"2015-12-30 07:28:54.000000000","message":"If we specify icmp protocol with IPv6 ethertype then probably that is an error. My worry is protocol field depends upon ethertype field and vice-versa. Do we really need to handle such case or just depend upon neutron-server to thrown an error instead?","commit_id":"1f643fdd4f88f96544bac09f477ab14895171503"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"8183fafaeed0be7c72e554b4dda552611292e50e","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet. Allowed values are \u0027"},{"line_number":321,"context_line":"                   \u0027[icmp, icmpv6, tcp, udp] and \u0027"},{"line_number":322,"context_line":"                   \u0027Integer Representations [0-255]\u0027))"},{"line_number":323,"context_line":"        parser.add_argument("},{"line_number":324,"context_line":"            \u0027--port-range-min\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_c2ddb171","line":321,"in_reply_to":"fa69d971_728dba7a","updated":"2015-12-30 11:38:47.000000000","message":"Do we really need to allow ICMP protocol for IPv6? RFC 2463 (https://tools.ietf.org/html/rfc2463) says to use ICMPv6 for IPv6 protocol.\n\n\"The Internet Protocol, version 6 (IPv6) is a new version of IP.  IPv6 uses the Internet Control Message Protocol (ICMP) as defined for IPv4 [RFC-792], with a number of changes.  The resulting protocol is called ICMPv6, and has an IPv6 Next Header value of 58.\"","commit_id":"1f643fdd4f88f96544bac09f477ab14895171503"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e853be9616468566c71649fe75090d0496f56956","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet. Allowed values are \u0027"},{"line_number":321,"context_line":"                   \u0027[icmp, icmpv6, tcp, udp] and \u0027"},{"line_number":322,"context_line":"                   \u0027Integer Representations [0-255]\u0027))"},{"line_number":323,"context_line":"        parser.add_argument("},{"line_number":324,"context_line":"            \u0027--port-range-min\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_728dba7a","line":321,"in_reply_to":"fa69d971_763ff525","updated":"2015-12-30 10:26:57.000000000","message":"Do we really get an error when specifying IPv6 ethertype and icmp protocol? In the original APi design, ICMP protocol can be used both for IPv4 and IPv6 ethertype. IIRC IPv6 protocol was introduced later because ICMPv6 takes additional types or code.\n\nAccording to my test, the combo of IPv6 ethertype and ICMP protocol works.\n\n  $ neutron security-group-create sg1\n  $ neutron security-group-rule-create --protocol icmp --ethertype IPv6 sg1\n  $ neutron security-group-rule-list --security-group-id a40bf9eb-a64a-45aa-b9e0-fbff2d6347b9\n  +--------------------------------------+----------------+-----------+-----------+---------------+--------+\n  | id                                   | security_group | direction | ethertype | port/protocol | remote |\n  +--------------------------------------+----------------+-----------+-----------+---------------+--------+\n  | 5640464a-f018-4bae-bd36-31376116fa86 | sg1            | ingress   | IPv6      | icmp          | any    |\n  | b011024b-083f-4a0b-82d6-29ad936090e4 | sg1            | egress    | IPv6      | any           | any    |\n  | f59e9342-2ecb-4250-8429-dee410f48c28 | sg1            | egress    | IPv4      | any           | any    |\n  +--------------------------------------+----------------+-----------+-----------+---------------+--------+","commit_id":"1f643fdd4f88f96544bac09f477ab14895171503"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9f2744f23c2ea2672ba5ce84d1c9cd1e6137716","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet. Allowed values are \u0027"},{"line_number":321,"context_line":"                   \u0027[icmp, icmpv6, tcp, udp] and \u0027"},{"line_number":322,"context_line":"                   \u0027Integer Representations [0-255]\u0027))"},{"line_number":323,"context_line":"        parser.add_argument("},{"line_number":324,"context_line":"            \u0027--port-range-min\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_3b5aaf84","line":321,"in_reply_to":"fa69d971_c2ddb171","updated":"2015-12-30 19:02:48.000000000","message":"if we specify icmp with IPV6 it does not give error. error will be when we specify icpmv6 with IPV4. This should be at api side. I submit a bug and patch for that 2 months ago. \nI think icmp is used with ipv6 by default it will icmpv6 and ip icmp is used with IPv4 it will be icmpv4","commit_id":"1f643fdd4f88f96544bac09f477ab14895171503"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e853be9616468566c71649fe75090d0496f56956","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet. Allowed values are \u0027"},{"line_number":321,"context_line":"                   \u0027[icmp, icmpv6, tcp, udp] and \u0027"},{"line_number":322,"context_line":"                   \u0027Integer Representations [0-255]\u0027))"},{"line_number":323,"context_line":"        parser.add_argument("},{"line_number":324,"context_line":"            \u0027--port-range-min\u0027,"},{"line_number":325,"context_line":"            help\u003d_(\u0027Starting port range. For ICMP it is type.\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_d2f26606","line":322,"updated":"2015-12-30 10:26:57.000000000","message":"There is no need of capitalization.\n\n integer representation","commit_id":"1f643fdd4f88f96544bac09f477ab14895171503"}],"neutronclient/tests/unit/test_cli20_securitygroup.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e853be9616468566c71649fe75090d0496f56956","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                                   position_names, position_values)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def test_create_security_group_rule_with_integer_protocol_value(self):"},{"line_number":178,"context_line":"        \"\"\"Create security group rule.\"\"\""},{"line_number":179,"context_line":"        resource \u003d \u0027security_group_rule\u0027"},{"line_number":180,"context_line":"        cmd \u003d securitygroup.CreateSecurityGroupRule("},{"line_number":181,"context_line":"            test_cli20.MyApp(sys.stdout), None)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_122c7e49","line":178,"updated":"2015-12-30 10:26:57.000000000","message":"Now we are not using docstring for test comments. Could you use # .... style or drop the docstring (because it describes nothing more than the method name)?","commit_id":"1f643fdd4f88f96544bac09f477ab14895171503"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c9f2744f23c2ea2672ba5ce84d1c9cd1e6137716","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                                   position_names, position_values)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def test_create_security_group_rule_with_integer_protocol_value(self):"},{"line_number":178,"context_line":"        \"\"\"Create security group rule.\"\"\""},{"line_number":179,"context_line":"        resource \u003d \u0027security_group_rule\u0027"},{"line_number":180,"context_line":"        cmd \u003d securitygroup.CreateSecurityGroupRule("},{"line_number":181,"context_line":"            test_cli20.MyApp(sys.stdout), None)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_9bccfb36","line":178,"in_reply_to":"fa69d971_122c7e49","updated":"2015-12-30 19:02:48.000000000","message":"Done","commit_id":"1f643fdd4f88f96544bac09f477ab14895171503"}]}
