)]}'
{"id":"openstack%2Fpython-neutronclient~25705","triplet_id":"openstack%2Fpython-neutronclient~master~I3146dd8974990c94e5f9b3b5bf6a8b28a245d64e","project":"openstack/python-neutronclient","branch":"master","topic":"bug/1161853","hashtags":[],"change_id":"I3146dd8974990c94e5f9b3b5bf6a8b28a245d64e","subject":"Change variable name of admin_state_down to admin_state","status":"MERGED","created":"2013-05-10 10:29:04.000000000","updated":"2013-05-10 10:29:04.000000000","submitted":"2013-05-10 10:29:04.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dd3d35dc626de53f0abe8478e51e16b64eb25ab7","_number":25705,"virtual_id_number":25705,"owner":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-05-10 10:29:04.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-05-10 10:29:04.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":2,"date":"2013-05-10 10:29:04.000000000","_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"date":"2013-05-10 10:29:04.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":1,"date":"2013-05-10 10:29:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-05-10 10:29:04.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":1,"date":"2013-05-10 10:29:04.000000000","_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"date":"2013-05-10 10:29:04.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-10 10:29:04.000000000","updated_by":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"reviewer":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"state":"REVIEWER"},{"updated":"2013-05-10 10:29:04.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2013-05-10 10:29:04.000000000","updated_by":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"reviewer":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"state":"REVIEWER"},{"updated":"2013-05-10 10:29:04.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1e1a13f9a7f8d9bcac057f1b08ba7d0dd3121608","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-10 10:29:04.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25705/1/check/gate-python-quantumclient-pep8/598 : SUCCESS\n- http://logs.openstack.org/25705/1/check/gate-python-quantumclient-docs/502 : SUCCESS\n- http://logs.openstack.org/25705/1/check/gate-python-quantumclient-python26/562 : SUCCESS\n- http://logs.openstack.org/25705/1/check/gate-python-quantumclient-python26-rhel6/28 : SUCCESS (non-voting)\n- http://logs.openstack.org/25705/1/check/gate-python-quantumclient-python27/561 : SUCCESS\n- http://logs.openstack.org/25705/1/check/gate-tempest-devstack-vm-full/10987 : SUCCESS\n- http://logs.openstack.org/25705/1/check/gate-tempest-devstack-vm-postgres-full/10703 : SUCCESS\n- http://logs.openstack.org/25705/1/check/gate-tempest-devstack-vm-quantum/16608 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"819eb1e397869702d83882b6b9c872628f9e1edd","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-05-10 10:29:04.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"fca270c83fe0b9ee1aba4d21448a249d9bb53118","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-10 10:29:04.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"19e13c280677e49fe4dea5587ca8af14d5b622e0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-10 10:29:04.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/25705/2/check/gate-python-quantumclient-pep8/645 : SUCCESS\n- http://logs.openstack.org/25705/2/check/gate-python-quantumclient-docs/545 : SUCCESS\n- http://logs.openstack.org/25705/2/check/gate-python-quantumclient-python26/605 : SUCCESS\n- http://logs.openstack.org/25705/2/check/gate-python-quantumclient-python26-rhel6/61 : SUCCESS (non-voting)\n- http://logs.openstack.org/25705/2/check/gate-python-quantumclient-python27/604 : SUCCESS\n- http://logs.openstack.org/25705/2/check/gate-tempest-devstack-vm-full/11898 : SUCCESS\n- http://logs.openstack.org/25705/2/check/gate-tempest-devstack-vm-postgres-full/11613 : SUCCESS\n- http://logs.openstack.org/25705/2/check/gate-tempest-devstack-vm-quantum/17672 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"6b9e3864b7f45927cb97c5cd2b0b14d198d2d48b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-10 10:29:04.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/25705/2/check/gate-python-quantumclient-pep8/636 : SUCCESS\n- http://logs.openstack.org/25705/2/check/gate-python-quantumclient-docs/536 : SUCCESS\n- http://logs.openstack.org/25705/2/check/gate-python-quantumclient-python26/596 : FAILURE\n- http://logs.openstack.org/25705/2/check/gate-python-quantumclient-python26-rhel6/53 : FAILURE (non-voting)\n- http://logs.openstack.org/25705/2/check/gate-python-quantumclient-python27/595 : FAILURE\n- http://logs.openstack.org/25705/2/check/gate-tempest-devstack-vm-full/11831 : SUCCESS\n- http://logs.openstack.org/25705/2/check/gate-tempest-devstack-vm-postgres-full/11546 : SUCCESS\n- http://logs.openstack.org/25705/2/check/gate-tempest-devstack-vm-quantum/17597 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"4cadfdf36eb67c6a75fd93a863886d7bccfa5415","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-05-10 10:29:04.000000000","message":"Patch Set 2:\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"289db8a33b727093b55930103e67b39cc475d69d","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2013-05-10 10:29:04.000000000","message":"Patch Set 2: Abandoned\n\ncode review expired after 2 weeks of no activity, it can be restored using the `Restore Change` button  under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":2},{"id":"a0adbf903b8b168d873fc152d13a7bc10fefcd89","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2013-05-10 10:29:04.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"ba902a5804c210b4fa5d91769ad6caf287a8159d","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-05-10 10:29:04.000000000","message":"Patch Set 2: Restored","accounts_in_message":[],"_revision_number":2},{"id":"7c1e0f034009fdbc46debafd656760e8e673b97c","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-05-10 10:29:04.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"65e394fc6a369a62d2985e71c2d862cd4a5e3095","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-05-10 10:29:04.000000000","message":"Patch Set 2:\n\nHmm... the following tests in master branch fails:\n- tests.unit.test_cli20_network.CLITestV20Network.test_list_nets_empty_with_column\n- tests.unit.test_cli20_network.CLITestV20Network.test_list_external_nets_empty_with_column","accounts_in_message":[],"_revision_number":2},{"id":"c525eed1a93a699508095359f05d2b44ca9008ad","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-05-10 10:29:04.000000000","message":"Patch Set 2:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":2},{"id":"2be87fb94b1372829d50c4bc1d1e053d81efc457","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-05-10 10:29:04.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"93039bd41ef367f96e5c6dc966a931dee00a9a79","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-05-10 10:29:04.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"aa590d658d61082b7dd4f58f3d494b55f2cdde6e","author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"date":"2013-05-10 10:29:04.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"182267fa301b2c83d1d1b8ca78e259d8136ff504","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-10 10:29:04.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"79f563c189d072f76d0181a7fdade84032f852f8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-10 10:29:04.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/25705/2/gate/gate-python-quantumclient-docs/591/doc/build/html/ : SUCCESS in 00:01:05\n- http://logs.openstack.org/25705/2/gate/gate-python-quantumclient-pep8/691 : SUCCESS in 00:00:49\n- http://logs.openstack.org/25705/2/gate/gate-python-quantumclient-python26/651 : SUCCESS in 00:01:03\n- http://logs.openstack.org/25705/2/gate/gate-python-quantumclient-python27/650 : SUCCESS in 00:00:52\n- http://logs.openstack.org/25705/2/gate/gate-tempest-devstack-vm-full/15373 : SUCCESS in 00:44:10\n- http://logs.openstack.org/25705/2/gate/gate-tempest-devstack-vm-postgres-full/15089 : FAILURE in 00:45:56 (non-voting)\n- http://logs.openstack.org/25705/2/gate/gate-tempest-devstack-vm-quantum/21659 : SUCCESS in 00:20:41\n- http://logs.openstack.org/25705/2/gate/gate-grenade-devstack-vm/3104 : FAILURE in 00:09:55 (non-voting)\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ad7caef9c302575427dfc46cea1c5b84fef8e061","revisions":{"d242bd9063064102c5df89009472a1179e915848":{"kind":"REWORK","_number":1,"created":"2013-05-10 10:29:04.000000000","uploader":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"ref":"refs/changes/05/25705/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/05/25705/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/05/25705/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/05/25705/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/05/25705/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/05/25705/1"}}},"commit":{"parents":[{"commit":"3277d38002ceea6ba0a6a09874b1f07ea01ae0b4","subject":"Merge \"Handle auth_token and endpoint_url if passed to the http client constructor\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/3277d38002ceea6ba0a6a09874b1f07ea01ae0b4"}]}],"author":{"name":"Akihiro MOTOKI","email":"motoki@da.jp.nec.com","date":"2013-03-28 18:15:55.000000000","tz":540},"committer":{"name":"Akihiro MOTOKI","email":"motoki@da.jp.nec.com","date":"2013-03-29 12:22:42.000000000","tz":540},"subject":"Change variable name of admin_state_down to admin_state","message":"Change variable name of admin_state_down to admin_state\n\nIt is confusing that admin_state_down\u003dFalse means admin-state is DOWN.\nIt is easy to understand if the varialbe name matches its value.\n\nAlso removes \u0027default\u003dxxx\u0027 from options with store_true/false action\nsince store_true/false sets the default value implicitly.\n\nFixes bug 1161853\n\nChange-Id: I3146dd8974990c94e5f9b3b5bf6a8b28a245d64e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/d242bd9063064102c5df89009472a1179e915848"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/d242bd9063064102c5df89009472a1179e915848"}]},"branch":"refs/heads/master"},"ad7caef9c302575427dfc46cea1c5b84fef8e061":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2013-05-10 10:29:04.000000000","uploader":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"ref":"refs/changes/05/25705/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/05/25705/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/05/25705/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/05/25705/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/05/25705/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/05/25705/2"}}},"commit":{"parents":[{"commit":"00935b8c1fb18351f8ff584f6b57596cdb5d7684","subject":"Merge \"Exclude top level \u0027tests dir\u0027 from packages.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/00935b8c1fb18351f8ff584f6b57596cdb5d7684"}]}],"author":{"name":"Akihiro MOTOKI","email":"motoki@da.jp.nec.com","date":"2013-03-28 18:15:55.000000000","tz":540},"committer":{"name":"Akihiro MOTOKI","email":"motoki@da.jp.nec.com","date":"2013-04-08 01:31:14.000000000","tz":540},"subject":"Change variable name of admin_state_down to admin_state","message":"Change variable name of admin_state_down to admin_state\n\nIt is confusing that admin_state_down\u003dFalse means admin-state is DOWN.\nIt is easy to understand if the variable name matches its value.\n\nAlso removes \u0027default\u003dxxx\u0027 from options with store_true/false action\nsince store_true/false sets the default value implicitly.\n\nFixes bug 1161853\n\nChange-Id: I3146dd8974990c94e5f9b3b5bf6a8b28a245d64e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/ad7caef9c302575427dfc46cea1c5b84fef8e061"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/ad7caef9c302575427dfc46cea1c5b84fef8e061"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}