)]}'
{"tests/unit/test_cli20.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a9f755efea623d11e75ac239755bc214c2ef0fdf","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def _test_list_resources(self, resources, cmd, detail\u003dFalse, tags\u003d[],"},{"line_number":256,"context_line":"                             fields_1\u003d[], fields_2\u003d[], page_size\u003dNone,"},{"line_number":257,"context_line":"                             sort_key\u003d[], sort_dir\u003d[], res_contents\u003dNone):"},{"line_number":258,"context_line":"        self.mox.StubOutWithMock(cmd, \"get_client\")"},{"line_number":259,"context_line":"        self.mox.StubOutWithMock(self.client.httpclient, \"request\")"},{"line_number":260,"context_line":"        cmd.get_client().MultipleTimes().AndReturn(self.client)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2Func%3D","line":257,"updated":"2013-05-24 10:41:18.000000000","message":"res_contents -\u003e result_contents?","commit_id":"3c182f811e871310ca286cf30a580d22b970e198"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def _test_list_resources(self, resources, cmd, detail\u003dFalse, tags\u003d[],"},{"line_number":256,"context_line":"                             fields_1\u003d[], fields_2\u003d[], page_size\u003dNone,"},{"line_number":257,"context_line":"                             sort_key\u003d[], sort_dir\u003d[], res_contents\u003dNone):"},{"line_number":258,"context_line":"        self.mox.StubOutWithMock(cmd, \"get_client\")"},{"line_number":259,"context_line":"        self.mox.StubOutWithMock(self.client.httpclient, \"request\")"},{"line_number":260,"context_line":"        cmd.get_client().MultipleTimes().AndReturn(self.client)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2Fr6Y%3D","line":257,"in_reply_to":"AAAAPH%2F%2Func%3D","updated":"2013-05-27 05:42:42.000000000","message":"The reason I used \u0027res_\u0027 is just to keep consistency with \u0027reses\u0027 and \u0027resstr\u0027. I am not sure what \u0027res\u0027 in \u0027reses\u0027 and \u0027resstr\u0027 means. resource? response?  result? These names should have a same prefix. \u0027response\u0027 seems better to me.","commit_id":"3c182f811e871310ca286cf30a580d22b970e198"}],"tests/unit/test_cli20_extensions.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a9f755efea623d11e75ac239755bc214c2ef0fdf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from quantumclient.quantum.v2_0.extension import ListExt"},{"line_number":21,"context_line":"from quantumclient.quantum.v2_0.extension import ShowExt"},{"line_number":22,"context_line":"from tests.unit.test_cli20 import CLITestV20Base"},{"line_number":23,"context_line":"from tests.unit.test_cli20 import MyApp"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class CLITestV20Extension(CLITestV20Base):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOX%2F%2F6OI%3D","line":23,"updated":"2013-04-08 01:41:54.000000000","message":"can u please further improve it by importing only modules?","commit_id":"843e7c41531b3f93ec69a27962dacb184ea9eb09"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a9f755efea623d11e75ac239755bc214c2ef0fdf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from quantumclient.quantum.v2_0.extension import ListExt"},{"line_number":21,"context_line":"from quantumclient.quantum.v2_0.extension import ShowExt"},{"line_number":22,"context_line":"from tests.unit.test_cli20 import CLITestV20Base"},{"line_number":23,"context_line":"from tests.unit.test_cli20 import MyApp"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class CLITestV20Extension(CLITestV20Base):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F%2Fh0%3D","line":23,"in_reply_to":"AAAAOX%2F%2F6N8%3D","updated":"2013-04-08 22:08:13.000000000","message":"I agree to change in a separate patch if u like to do it.","commit_id":"843e7c41531b3f93ec69a27962dacb184ea9eb09"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"from quantumclient.quantum.v2_0.extension import ListExt"},{"line_number":21,"context_line":"from quantumclient.quantum.v2_0.extension import ShowExt"},{"line_number":22,"context_line":"from tests.unit.test_cli20 import CLITestV20Base"},{"line_number":23,"context_line":"from tests.unit.test_cli20 import MyApp"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class CLITestV20Extension(CLITestV20Base):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOX%2F%2F6N8%3D","line":23,"in_reply_to":"AAAAOX%2F%2F6OI%3D","updated":"2013-04-08 15:39:06.000000000","message":"This import style is commonly used in quantumclient tests.  Are you suggesting to change these to module level imports in this file? or is it better to change import style in all files (in a separate patch)?\n\nI have updated the imports in this file.","commit_id":"843e7c41531b3f93ec69a27962dacb184ea9eb09"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"from quantumclient.quantum.v2_0.extension import ListExt"},{"line_number":21,"context_line":"from quantumclient.quantum.v2_0.extension import ShowExt"},{"line_number":22,"context_line":"from tests.unit.test_cli20 import CLITestV20Base"},{"line_number":23,"context_line":"from tests.unit.test_cli20 import MyApp"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class CLITestV20Extension(CLITestV20Base):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2F7IY%3D","line":23,"in_reply_to":"AAAAOn%2F%2F%2Fh0%3D","updated":"2013-04-11 12:40:00.000000000","message":"I filed it https://bugs.launchpad.net/python-quantumclient/+bug/1167901","commit_id":"843e7c41531b3f93ec69a27962dacb184ea9eb09"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a9f755efea623d11e75ac239755bc214c2ef0fdf","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def test_list_extensions(self):"},{"line_number":30,"context_line":"        resources \u003d \u0027extensions\u0027"},{"line_number":31,"context_line":"        cmd \u003d ListExt(MyApp(sys.stdout), None)"},{"line_number":32,"context_line":"        self._test_list_resources(resources, cmd)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_show_extension(self):"},{"line_number":35,"context_line":"        \"\"\"Show extension: --fields alias.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2FvSw%3D","line":32,"updated":"2013-05-24 02:11:57.000000000","message":"quantum ext-list -F name -F links\n\n+-----------------+--------------------------+\n\n| alias           | name                     |\n\n+-----------------+--------------------------+\n\n| agent_scheduler | Agent Schedulers         |\n\n| binding         | Port Binding             |\n\n| quotas          | Quota management support |\n\n| agent           | agent                    |\n\n| provider        | Provider Network         |\n\n| router          | Quantum L3 Router        |\n\n| lbaas           | LoadBalancing service    |\n\n| extraroute      | Quantum Extra Route      |\n\n+-----------------+--------------------------+\n\n$ quantum subnet-list  -F id -F name\n\n+--------------------------------------+----------+\n\n| id                                   | name     |\n\n+--------------------------------------+----------+\n\n| 131740ac-8ef0-4e8e-b571-2246e05d470a |          |\n\n| 193dc2ec-9893-423a-a59f-77eca753f197 |          |\n\n| 8512d106-a8a2-4b13-8457-e11716f3bb58 |          |\n\n| d0afd7dc-d818-46fd-b7fd-081d44b41aae | asubnet1 |\n\n+--------------------------------------+----------+","commit_id":"6a8a1ad673f5a8cc76616e606f48578ee85089cc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def test_list_extensions(self):"},{"line_number":30,"context_line":"        resources \u003d \u0027extensions\u0027"},{"line_number":31,"context_line":"        cmd \u003d ListExt(MyApp(sys.stdout), None)"},{"line_number":32,"context_line":"        self._test_list_resources(resources, cmd)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_show_extension(self):"},{"line_number":35,"context_line":"        \"\"\"Show extension: --fields alias.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2FusM%3D","line":32,"in_reply_to":"AAAAPH%2F%2Fu%2Fg%3D","updated":"2013-05-24 09:58:18.000000000","message":"I changed the test to check only the default columns are displayed.","commit_id":"6a8a1ad673f5a8cc76616e606f48578ee85089cc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def test_list_extensions(self):"},{"line_number":30,"context_line":"        resources \u003d \u0027extensions\u0027"},{"line_number":31,"context_line":"        cmd \u003d ListExt(MyApp(sys.stdout), None)"},{"line_number":32,"context_line":"        self._test_list_resources(resources, cmd)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_show_extension(self):"},{"line_number":35,"context_line":"        \"\"\"Show extension: --fields alias.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2Fu%2Fg%3D","line":32,"in_reply_to":"AAAAPH%2F%2FvSw%3D","updated":"2013-05-24 06:18:08.000000000","message":"I haven\u0027t understood what is the problem. -F option just specifies query fields and does not limit the field displayed.\n\nI think it is an issue of the server side. quantum-server seems not to support field query for ext-list. http://paste.openstack.org/show/37719/\nThe client sends GET http://10.56.51.210:9696/v2.0/extensions.json?fields\u003did\u0026fields\u003dname, but all attributes are returned.\n\nIn such case, we need to use -c option instead. \"quantum ext-list -c alias -c name -c description\" works as I expected.\nI miss something?","commit_id":"6a8a1ad673f5a8cc76616e606f48578ee85089cc"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a9f755efea623d11e75ac239755bc214c2ef0fdf","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cmd \u003d ShowExt(MyApp(sys.stdout), None)"},{"line_number":38,"context_line":"        args \u003d [\u0027--fields\u0027, \u0027alias\u0027, self.test_id]"},{"line_number":39,"context_line":"        ext_alias \u003d self.test_id"},{"line_number":40,"context_line":"        self._test_show_resource(resource, cmd, ext_alias, args, [\u0027alias\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2FvS0%3D","line":40,"updated":"2013-05-24 02:11:57.000000000","message":"quantum subnet-show asubnet1 -F name\n\n+-------+----------+\n\n| Field | Value    |\n\n+-------+----------+\n\n| name  | asubnet1 |\n\n+-------+----------+\n\nquantum ext-show binding -F alias\n\n+-------------+----------------------------------------------------------------+\n\n| Field       | Value                                                          |\n\n+-------------+----------------------------------------------------------------+\n\n| alias       | binding                                                        |\n\n| description | Expose port bindings of a virtual port to external application |\n\n| links       |                                                                |\n\n| name        | Port Binding                                                   |\n\n| namespace   | http://docs.openstack.org/ext/binding/api/v1.0                 |\n\n| updated     | 2012-11-14T10:00:00-00:00                                      |\n\n+-------------+----------------------------------------------------------------+","commit_id":"6a8a1ad673f5a8cc76616e606f48578ee85089cc"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a9f755efea623d11e75ac239755bc214c2ef0fdf","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cmd \u003d ShowExt(MyApp(sys.stdout), None)"},{"line_number":38,"context_line":"        args \u003d [\u0027--fields\u0027, \u0027alias\u0027, self.test_id]"},{"line_number":39,"context_line":"        ext_alias \u003d self.test_id"},{"line_number":40,"context_line":"        self._test_show_resource(resource, cmd, ext_alias, args, [\u0027alias\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2Fu9A%3D","line":40,"in_reply_to":"AAAAPH%2F%2Fu%2FM%3D","updated":"2013-05-24 06:37:41.000000000","message":"If u are fixing the -c problem, we should have a test case for -c instead of --fields. also we can have a bug fix on the server side to recognize the -F.","commit_id":"6a8a1ad673f5a8cc76616e606f48578ee85089cc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cmd \u003d ShowExt(MyApp(sys.stdout), None)"},{"line_number":38,"context_line":"        args \u003d [\u0027--fields\u0027, \u0027alias\u0027, self.test_id]"},{"line_number":39,"context_line":"        ext_alias \u003d self.test_id"},{"line_number":40,"context_line":"        self._test_show_resource(resource, cmd, ext_alias, args, [\u0027alias\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2FusA%3D","line":40,"in_reply_to":"AAAAPH%2F%2Fu7s%3D","updated":"2013-05-24 09:58:18.000000000","message":"Since field query does not work for ext-show, it is sufficient if we can confirm show_resource works, ie all fields in the response are contained.","commit_id":"6a8a1ad673f5a8cc76616e606f48578ee85089cc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cmd \u003d ShowExt(MyApp(sys.stdout), None)"},{"line_number":38,"context_line":"        args \u003d [\u0027--fields\u0027, \u0027alias\u0027, self.test_id]"},{"line_number":39,"context_line":"        ext_alias \u003d self.test_id"},{"line_number":40,"context_line":"        self._test_show_resource(resource, cmd, ext_alias, args, [\u0027alias\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2Fu7s%3D","line":40,"in_reply_to":"AAAAPH%2F%2Fu9A%3D","updated":"2013-05-24 06:58:23.000000000","message":"I am just trying to set the default columns for ext-list. Previously ext-list/show uses its own implementation and my change applies the common List/ShowCommand class to ext-list/show.  I don\u0027t change the behavior of -c or -F.\n\nI\u0027ll consider what tests are suitable here. At least -F option is a bad choice.","commit_id":"6a8a1ad673f5a8cc76616e606f48578ee85089cc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":37,"context_line":"        cmd \u003d ShowExt(MyApp(sys.stdout), None)"},{"line_number":38,"context_line":"        args \u003d [\u0027--fields\u0027, \u0027alias\u0027, self.test_id]"},{"line_number":39,"context_line":"        ext_alias \u003d self.test_id"},{"line_number":40,"context_line":"        self._test_show_resource(resource, cmd, ext_alias, args, [\u0027alias\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2Fu%2FM%3D","line":40,"in_reply_to":"AAAAPH%2F%2FvS0%3D","updated":"2013-05-24 06:18:08.000000000","message":"Same comment as ext-list.\n\n-F option does not seem to work for extension list/show.\nShould I remove --fields option from L.38?","commit_id":"6a8a1ad673f5a8cc76616e606f48578ee85089cc"}]}