)]}'
{"quantumclient/quantum/v2_0/port.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"920cd18aee99a6c5c9fd452f514042cc5f6e0c9a","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    def args2body(self, parsed_args):"},{"line_number":200,"context_line":"        body \u003d {\u0027port\u0027: {}}"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        _sgids \u003d []"},{"line_number":203,"context_line":"        for sg in parsed_args.security_groups:"},{"line_number":204,"context_line":"            _sgids.append(quantumv20.find_resourceid_by_name_or_id("},{"line_number":205,"context_line":"                self.get_client(), \u0027security_group\u0027, sg))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2Fvxw%3D","line":202,"updated":"2013-03-29 15:17:53.000000000","message":"suggest put this in an else leg after line 210. don\u0027t need to do this if no_security_groups.","commit_id":"75fb63f190d2f4781aa3dc2f2d0b39b9d470984a"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"04d6d8b4c1051b52fba8e68eaca7f33d3dc7ef94","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        group_sg.add_argument("},{"line_number":90,"context_line":"            \u0027--no-security-groups\u0027,"},{"line_number":91,"context_line":"            default\u003dFalse, action\u003d\u0027store_true\u0027,"},{"line_number":92,"context_line":"            help\u003d\u0027no security groups associated with the port\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _resolv_sgid(self, secgroup):"},{"line_number":95,"context_line":"        return quantumv20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOX%2F%2F%2FA4%3D","line":92,"updated":"2013-04-03 15:56:43.000000000","message":"I think the old message \u0027remove security groups from port\u0027 was clearer about what this does.","commit_id":"c9d0864e2526bf09d92178e2389c4d95718cef31"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":89,"context_line":"        group_sg.add_argument("},{"line_number":90,"context_line":"            \u0027--no-security-groups\u0027,"},{"line_number":91,"context_line":"            default\u003dFalse, action\u003d\u0027store_true\u0027,"},{"line_number":92,"context_line":"            help\u003d\u0027no security groups associated with the port\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _resolv_sgid(self, secgroup):"},{"line_number":95,"context_line":"        return quantumv20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOX%2F%2F9gA%3D","line":92,"in_reply_to":"AAAAOX%2F%2F%2B5k%3D","updated":"2013-04-04 14:10:18.000000000","message":"I changed the message to \"associate no security groups with the port\".","commit_id":"c9d0864e2526bf09d92178e2389c4d95718cef31"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"a5b5e789a4613fe45d7b16a443d033a8c22ab2c7","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        group_sg.add_argument("},{"line_number":90,"context_line":"            \u0027--no-security-groups\u0027,"},{"line_number":91,"context_line":"            default\u003dFalse, action\u003d\u0027store_true\u0027,"},{"line_number":92,"context_line":"            help\u003d\u0027no security groups associated with the port\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _resolv_sgid(self, secgroup):"},{"line_number":95,"context_line":"        return quantumv20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOX%2F%2F%2B5k%3D","line":92,"in_reply_to":"AAAAOX%2F%2F%2B9o%3D","updated":"2013-04-03 16:42:09.000000000","message":"Ah, I see.  That makes sense.\n\nMaybe just add \u0027set\u0027 to the message?  So \u0027set no security groups...\u0027  I think that would still work for both, and it clarifies what is happening on the update for me.","commit_id":"c9d0864e2526bf09d92178e2389c4d95718cef31"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"51f07d0eaf06b9ea1f9c95f9a4264704e06ce617","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        group_sg.add_argument("},{"line_number":90,"context_line":"            \u0027--no-security-groups\u0027,"},{"line_number":91,"context_line":"            default\u003dFalse, action\u003d\u0027store_true\u0027,"},{"line_number":92,"context_line":"            help\u003d\u0027no security groups associated with the port\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _resolv_sgid(self, secgroup):"},{"line_number":95,"context_line":"        return quantumv20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOX%2F%2F%2B9o%3D","line":92,"in_reply_to":"AAAAOX%2F%2F%2FA4%3D","updated":"2013-04-03 16:16:27.000000000","message":"This message is used in both port-create and port-update. I feel \u0027remove security groups from port\u0027 in port-create a little odd, so I changes the message.\n\nIs it better to define these argument separately in CreatePort and UpdatePort for clearer help message? I think the duplicated logic is not a problem since the logic is small.","commit_id":"c9d0864e2526bf09d92178e2389c4d95718cef31"}],"tests/unit/test_cli20_port.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d142b279294e52efa04c9af8a807fd4c0bcbe160","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                                   position_names, position_values)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_create_port_secgroup_off(self):"},{"line_number":133,"context_line":"        \"\"\"Create port: --no-security-groups netid.\"\"\""},{"line_number":134,"context_line":"        resource \u003d \u0027port\u0027"},{"line_number":135,"context_line":"        cmd \u003d port.CreatePort(test_cli20.MyApp(sys.stdout), None)"},{"line_number":136,"context_line":"        name \u003d \u0027myname\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2Fmhc%3D","line":133,"updated":"2013-06-26 22:21:14.000000000","message":"not sure of the value of these docstrings (I made similar comments to another review). The body of the method is already clear at it is, and so its test goal. I would remove them.","commit_id":"37b59d6f353e32ac976e17ca06ee8ac38ca6faa8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":130,"context_line":"                                   position_names, position_values)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_create_port_secgroup_off(self):"},{"line_number":133,"context_line":"        \"\"\"Create port: --no-security-groups netid.\"\"\""},{"line_number":134,"context_line":"        resource \u003d \u0027port\u0027"},{"line_number":135,"context_line":"        cmd \u003d port.CreatePort(test_cli20.MyApp(sys.stdout), None)"},{"line_number":136,"context_line":"        name \u003d \u0027myname\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAP3%2F%2F%2BZs%3D","line":133,"in_reply_to":"AAAAPn%2F%2FeqM%3D","updated":"2013-07-08 08:59:48.000000000","message":"I removed docstring for the unit tests I added in this patch.\nCleaning up other docstrings is not a scope of this patch.","commit_id":"37b59d6f353e32ac976e17ca06ee8ac38ca6faa8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":130,"context_line":"                                   position_names, position_values)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_create_port_secgroup_off(self):"},{"line_number":133,"context_line":"        \"\"\"Create port: --no-security-groups netid.\"\"\""},{"line_number":134,"context_line":"        resource \u003d \u0027port\u0027"},{"line_number":135,"context_line":"        cmd \u003d port.CreatePort(test_cli20.MyApp(sys.stdout), None)"},{"line_number":136,"context_line":"        name \u003d \u0027myname\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FeqM%3D","line":133,"in_reply_to":"AAAAPn%2F%2Fmhc%3D","updated":"2013-07-01 02:02:40.000000000","message":"In my understanding docstrings of unit tests in quantumclient describe commandline parameters to be tested and I just follow the convention.\n\nI agree with you. The method name describe what it tests clearly and we can know what the command line options are passed from \"args\" at L.139.\n\nAlmost all docstrings of unit tests looks unnecessary. I will remove them from my patch, but we still have many such docstrings in the tests :-(","commit_id":"37b59d6f353e32ac976e17ca06ee8ac38ca6faa8"}]}