)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b7ff60eec085f98c411398d63c67cea3eec81bbd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace string format arguments with function parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are files containing string format arguments inside logging messages."},{"line_number":10,"context_line":"Using logging function parameters should be preferred."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Based on the work of https://review.openstack.org/#/c/94345/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a7e1126_f63c5794","line":9,"updated":"2015-12-22 12:48:54.000000000","message":"Please update the commit message to explain the refactor as well.","commit_id":"8a23b69a80b2f7bea3d85bce290f9edf4942748e"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"df1b922c1d59ef6d397ffe7b9f7e9d80d9fb99f9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Details available at http://legacy.python.org/dev/peps/pep-0282/."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also, move log.debug() to neutronclient.shell module to make sure"},{"line_number":14,"context_line":"all commands have log.debug in run()to keep consistent."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Based on the work of https://review.openstack.org/#/c/94345/"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa69d971_c967c623","line":14,"updated":"2016-01-04 14:43:37.000000000","message":"nit...missing space after run()","commit_id":"91bb1002da7492a1bba64625ed154c428a32fab2"}],"neutronclient/neutron/v2_0/agentscheduler.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"48dd8d3f8e69b0b58c92738a182a3950724737e3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            help\u003d_(\u0027Network to add.\u0027))"},{"line_number":39,"context_line":"        return parser"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def run(self, parsed_args):"},{"line_number":42,"context_line":"        neutron_client \u003d self.get_client()"},{"line_number":43,"context_line":"        _net_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":44,"context_line":"            neutron_client, \u0027network\u0027, parsed_args.network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_4cbbe0e5","line":41,"updated":"2015-12-26 11:54:34.000000000","message":"What problem it creates if we use format specifiers for the debug function? Can you please explain why this change is required?","commit_id":"8a23b69a80b2f7bea3d85bce290f9edf4942748e"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"0219a6e94cd801d9deec033ebc92c8e71923a0f2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            help\u003d_(\u0027Network to add.\u0027))"},{"line_number":39,"context_line":"        return parser"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def run(self, parsed_args):"},{"line_number":42,"context_line":"        neutron_client \u003d self.get_client()"},{"line_number":43,"context_line":"        _net_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":44,"context_line":"            neutron_client, \u0027network\u0027, parsed_args.network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_ba150b4a","line":41,"in_reply_to":"1a7b0d38_4cbbe0e5","updated":"2016-01-04 02:22:38.000000000","message":"Using logging function parameters should be preferred. Details available at http://legacy.python.org/dev/peps/pep-0282/.\n\n\n[1]: https://bugs.launchpad.net/python-neutronclient/+bug/1321754","commit_id":"8a23b69a80b2f7bea3d85bce290f9edf4942748e"}],"neutronclient/shell.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0abfcccd424435b237e8ec559d80ce69097957c0","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            _values_specs.remove(cidr)"},{"line_number":104,"context_line":"    cmd.values_specs \u003d (index \u003d\u003d -1 and _values_specs or values_specs)"},{"line_number":105,"context_line":"    if hasattr(cmd, \u0027log\u0027):"},{"line_number":106,"context_line":"        cmd.log.debug(\u0027run(%s)\u0027, known_args)"},{"line_number":107,"context_line":"    return cmd.run(known_args)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba63e191_4e37a0b0","line":106,"updated":"2016-01-19 10:08:21.000000000","message":"This approach looks tricky.\n\nI am now refactoring command class inheritance in a series of patches: https://review.openstack.org/#/q/topic:cliff-convention and the last patch https://review.openstack.org/#/c/265287/ of the series fixes this bug. Though I do not intend to override your patch, I still think my approach is cleaner.","commit_id":"083ccc48cc05e78df4b33e5594c7c45727e994d3"}]}