)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"df6af8a0cc5adcfa3ffcf44236ca8ca13a49e990","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     chen-li \u003cshchenli@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-24 21:26:01 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make security-group-rule-create accept \"any\" protocol"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1470051"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1a7b0d38_e273bd7e","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":19},"updated":"2015-12-26 03:10:42.000000000","message":"When I read it first, I had the question :Why do we need it?\n\nCan you add a body to this message, so that we know the reason? from a reviewer point of view?","commit_id":"f2c91025fb8146cab6e3dbb8f808466143b82109"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a3d19f4949d228df7939fb9b424e2ee951e76ec0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"only when user do not specified the protocol. This change"},{"line_number":12,"context_line":"makes security-group-rule-create accept \"any\" protocol to allow"},{"line_number":13,"context_line":"user explictly specify \u0027any\u0027 protocol, and make the behavior consistent"},{"line_number":14,"context_line":"with FWaaS API and CLI ouputs."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1470051"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"ba63e191_e44b1e2a","line":14,"range":{"start_line":14,"start_character":5,"end_line":14,"end_character":14},"updated":"2016-01-19 07:12:35.000000000","message":"FWaaS API does not take \"any\" as a valid value.\nIsn\u0027t it specific to CLI?","commit_id":"ef6174ddd70c6b9544e4ec73393601776a71b164"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4630355a43cfbb79eeacec52af992cbdcc735543","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, all protocols are allowed only when user do not specified the"},{"line_number":10,"context_line":"protocol. This change makes security-group-rule-create accept protocol"},{"line_number":11,"context_line":"\"any\" to allow user explictly specify \u0027any\u0027 protocol, and keep behavior"},{"line_number":12,"context_line":"consistent with FWaaS CLI and ouputs of \"neutron security-group-rule-list\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1470051"},{"line_number":15,"context_line":"Closes-Bug: #1469642"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"9a68dd71_706861bb","line":12,"updated":"2016-01-20 14:13:59.000000000","message":"nit...typo on \"ouputs\".","commit_id":"8939c3c71cb7a3f05d917082ab005684d18a08aa"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4630355a43cfbb79eeacec52af992cbdcc735543","unresolved":false,"context_lines":[{"line_number":12,"context_line":"consistent with FWaaS CLI and ouputs of \"neutron security-group-rule-list\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1470051"},{"line_number":15,"context_line":"Closes-Bug: #1469642"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I14a31458f5c97aea356c7afe083e13fd6f79c2df"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"9a68dd71_fc350df7","line":15,"updated":"2016-01-20 14:13:59.000000000","message":"I think that one bug should be marked as a duplicate of the other.","commit_id":"8939c3c71cb7a3f05d917082ab005684d18a08aa"}],"neutronclient/neutron/v2_0/securitygroup.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7d5cd7addc77207d0c68c9f7ad2dcc61e7314b90","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet. \u0027"},{"line_number":321,"context_line":"                   \u0027Supported protocol values are: any, tcp, udp, icmp \u0027"},{"line_number":322,"context_line":"                   \u0027icmpv6 and integer representations [0 to 255]\u0027))"},{"line_number":323,"context_line":"        parser.add_argument("},{"line_number":324,"context_line":"            \u0027--port-range-min\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_5b712843","line":321,"updated":"2015-12-20 08:56:01.000000000","message":"Plz add \u0027,\u0027 after icmp","commit_id":"426922282b43a0f52e0f98ed1664be08b26c747b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7d5cd7addc77207d0c68c9f7ad2dcc61e7314b90","unresolved":false,"context_lines":[{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet. \u0027"},{"line_number":321,"context_line":"                   \u0027Supported protocol values are: any, tcp, udp, icmp \u0027"},{"line_number":322,"context_line":"                   \u0027icmpv6 and integer representations [0 to 255]\u0027))"},{"line_number":323,"context_line":"        parser.add_argument("},{"line_number":324,"context_line":"            \u0027--port-range-min\u0027,"},{"line_number":325,"context_line":"            help\u003d_(\u0027Starting port range.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_fbded40f","line":322,"updated":"2015-12-20 08:56:01.000000000","message":"How about rephrasing:\n\n\"Supported protocol values can be either [any, tcp, udp, icmp, icmp6] or an integer value in [0, 255]\"","commit_id":"426922282b43a0f52e0f98ed1664be08b26c747b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ac80706842869945881fd2c3bcec2fb69160c23","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    def args2body(self, parsed_args):"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        if parsed_args.protocol \u003d\u003d \u0027any\u0027:"},{"line_number":351,"context_line":"            parsed_args.protocol \u003d None"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        _security_group_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":354,"context_line":"            self.get_client(), \u0027security_group\u0027, parsed_args.security_group_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_38d4c545","line":351,"updated":"2015-12-24 04:59:55.000000000","message":"It is not a good idea to update parsed_args.\nInstead I would suggest to assign \u0027protocol\u0027 field of \u0027body\u0027 directly.","commit_id":"df054c2e79fce41364d03d0a1b3972f202fc7504"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"3fff8865fb5a2fb07801d9856e5e4223ba3f1d57","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    def args2body(self, parsed_args):"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        if parsed_args.protocol \u003d\u003d \u0027any\u0027:"},{"line_number":351,"context_line":"            parsed_args.protocol \u003d None"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        _security_group_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":354,"context_line":"            self.get_client(), \u0027security_group\u0027, parsed_args.security_group_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_38ba85c1","line":351,"in_reply_to":"1a7b0d38_38d4c545","updated":"2015-12-24 05:24:55.000000000","message":"Done","commit_id":"df054c2e79fce41364d03d0a1b3972f202fc7504"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"df6af8a0cc5adcfa3ffcf44236ca8ca13a49e990","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        parser.add_argument("},{"line_number":319,"context_line":"            \u0027--protocol\u0027,"},{"line_number":320,"context_line":"            help\u003d_(\u0027Protocol of packet. \u0027"},{"line_number":321,"context_line":"                   \u0027Supported protocol values can be either [any, tcp, \u0027"},{"line_number":322,"context_line":"                   \u0027udp, icmp, icmp6] or an integer value in [0, 255]\u0027))"},{"line_number":323,"context_line":"        parser.add_argument("},{"line_number":324,"context_line":"            \u0027--port-range-min\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_a26db599","line":321,"range":{"start_line":321,"start_character":30,"end_line":321,"end_character":38},"updated":"2015-12-26 03:10:42.000000000","message":"Suggestion:\nIn other similar patches, we introduced the concept of removing the Capitalization check ( convert all strings to Lower or Upper).\nYou can also do it, so that ANY, any and Any , all the 3 combinations can work","commit_id":"f2c91025fb8146cab6e3dbb8f808466143b82109"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"df6af8a0cc5adcfa3ffcf44236ca8ca13a49e990","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        body \u003d {\u0027security_group_id\u0027: _security_group_id,"},{"line_number":352,"context_line":"                \u0027direction\u0027: parsed_args.direction,"},{"line_number":353,"context_line":"                \u0027ethertype\u0027: parsed_args.ethertype or"},{"line_number":354,"context_line":"                generate_default_ethertype(parsed_args.protocol)}"},{"line_number":355,"context_line":"        neutronV20.update_dict(parsed_args, body,"},{"line_number":356,"context_line":"                               [\u0027protocol\u0027, \u0027port_range_min\u0027, \u0027port_range_max\u0027,"},{"line_number":357,"context_line":"                                \u0027remote_ip_prefix\u0027, \u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_021da90e","line":354,"range":{"start_line":354,"start_character":16,"end_line":354,"end_character":42},"updated":"2015-12-26 03:10:42.000000000","message":"By the way, what the default ethertype if protocol is ANY?","commit_id":"f2c91025fb8146cab6e3dbb8f808466143b82109"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"313734966a9e3242aeb9ff00099265be35a6d1a7","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        body \u003d {\u0027security_group_id\u0027: _security_group_id,"},{"line_number":352,"context_line":"                \u0027direction\u0027: parsed_args.direction,"},{"line_number":353,"context_line":"                \u0027ethertype\u0027: parsed_args.ethertype or"},{"line_number":354,"context_line":"                generate_default_ethertype(parsed_args.protocol)}"},{"line_number":355,"context_line":"        neutronV20.update_dict(parsed_args, body,"},{"line_number":356,"context_line":"                               [\u0027protocol\u0027, \u0027port_range_min\u0027, \u0027port_range_max\u0027,"},{"line_number":357,"context_line":"                                \u0027remote_ip_prefix\u0027, \u0027tenant_id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_c7f34309","line":354,"range":{"start_line":354,"start_character":16,"end_line":354,"end_character":42},"in_reply_to":"1a7b0d38_021da90e","updated":"2016-01-04 03:17:44.000000000","message":"IPv4. \n\nAll  default ethertype  is IPv4 except protocol icmpv6","commit_id":"f2c91025fb8146cab6e3dbb8f808466143b82109"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1c215b0f7a7c33d4a252af386138be98321e09cf","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                                \u0027remote_ip_prefix\u0027, \u0027tenant_id\u0027])"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        if parsed_args.protocol \u003d\u003d \u0027any\u0027:"},{"line_number":360,"context_line":"            body.pop(\u0027protocol\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if parsed_args.remote_group_id:"},{"line_number":363,"context_line":"            _remote_group_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_4c30f69e","line":360,"updated":"2015-12-24 06:05:54.000000000","message":"Doesn\u0027t this mean that \u0027protocol\u0027 is never sent even if \u0027protocol\u0027 \u003d\u003d None (any) is specified? I think if the option is specified the corresponding attribute is sent to the server.","commit_id":"f2c91025fb8146cab6e3dbb8f808466143b82109"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4db48be7c6d55511e310326f5754120e7ca1d7a7","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                                \u0027remote_ip_prefix\u0027, \u0027tenant_id\u0027])"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        if parsed_args.protocol \u003d\u003d \u0027any\u0027:"},{"line_number":360,"context_line":"            body.pop(\u0027protocol\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if parsed_args.remote_group_id:"},{"line_number":363,"context_line":"            _remote_group_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_4f678825","line":360,"in_reply_to":"1a7b0d38_4c30f69e","updated":"2015-12-24 07:10:48.000000000","message":"I think by default all the protocols are allowed and \u0027any\u0027 has the same notion.","commit_id":"f2c91025fb8146cab6e3dbb8f808466143b82109"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"7db7da94ec1ac9b5476386bb856a4675a900be03","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                                \u0027remote_ip_prefix\u0027, \u0027tenant_id\u0027])"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        if parsed_args.protocol \u003d\u003d \u0027any\u0027:"},{"line_number":360,"context_line":"            body.pop(\u0027protocol\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if parsed_args.remote_group_id:"},{"line_number":363,"context_line":"            _remote_group_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_8219c77b","line":360,"in_reply_to":"1a7b0d38_4f678825","updated":"2015-12-24 07:17:16.000000000","message":"Yes, none \u003d\u003d any.","commit_id":"f2c91025fb8146cab6e3dbb8f808466143b82109"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"df6af8a0cc5adcfa3ffcf44236ca8ca13a49e990","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                                \u0027remote_ip_prefix\u0027, \u0027tenant_id\u0027])"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        if parsed_args.protocol \u003d\u003d \u0027any\u0027:"},{"line_number":360,"context_line":"            body.pop(\u0027protocol\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if parsed_args.remote_group_id:"},{"line_number":363,"context_line":"            _remote_group_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_8230b99f","line":360,"in_reply_to":"1a7b0d38_8219c77b","updated":"2015-12-26 03:10:42.000000000","message":"Then in that case, the better option would be NOT to update the protocol value in Line Number 356 , isnt it ?\nYou dont need to pop it if you dont push it :)\nAnd if its not set to ANY ( It is IPv4, IPv6)  then you update the body....\nWould reduce some level of confusion...I guess","commit_id":"f2c91025fb8146cab6e3dbb8f808466143b82109"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ee217e46908b88ddbbe2bea87ddaecdca8d37de0","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                                \u0027remote_ip_prefix\u0027, \u0027tenant_id\u0027])"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        if parsed_args.protocol \u003d\u003d \u0027any\u0027:"},{"line_number":360,"context_line":"            body.pop(\u0027protocol\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if parsed_args.remote_group_id:"},{"line_number":363,"context_line":"            _remote_group_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_8cc9c87a","line":360,"in_reply_to":"1a7b0d38_8230b99f","updated":"2015-12-26 11:57:04.000000000","message":"+1: for Reedip\u0027s suggestion for not putting \u0027protocol\u0027 in L356.","commit_id":"f2c91025fb8146cab6e3dbb8f808466143b82109"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"9479cbbacf7f27b7ef6e464905a5a462411656f2","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                                \u0027remote_ip_prefix\u0027, \u0027tenant_id\u0027])"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        if parsed_args.protocol \u003d\u003d \u0027any\u0027:"},{"line_number":360,"context_line":"            body.pop(\u0027protocol\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if parsed_args.remote_group_id:"},{"line_number":363,"context_line":"            _remote_group_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_3c14e2f3","line":360,"in_reply_to":"1a7b0d38_8cc9c87a","updated":"2015-12-31 01:05:49.000000000","message":"In previous change, I dropped the change from parsed_args, but I get suggestion that better not change parsed_args...","commit_id":"f2c91025fb8146cab6e3dbb8f808466143b82109"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"959f7f4f1136863cdd4d8d499654cc0c848daab5","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                                \u0027remote_ip_prefix\u0027, \u0027tenant_id\u0027])"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        if parsed_args.protocol \u003d\u003d \u0027any\u0027:"},{"line_number":360,"context_line":"            body.pop(\u0027protocol\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if parsed_args.remote_group_id:"},{"line_number":363,"context_line":"            _remote_group_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_d736bc02","line":360,"in_reply_to":"fa69d971_3c14e2f3","updated":"2015-12-31 07:01:17.000000000","message":"Yes, I know None is the default value and \u0027any\u0027 is same as \u0027not specified\u0027.\n\nMy points are:\n\n- I would like to send nothing (i.e. \u0027not specified\u0027) if an option is not specified.\n- If something is specified, we will send a corresponding value.\n\nMy suggestion is to add the following before L.355:\n\n  if parsed_args.protocol \u003d\u003d \u0027any\u0027:\n      body[\u0027protocol\u0027] \u003d None\n  elif parsed_args.protocol:\n      body[\u0027protocol\u0027] \u003d parsed_args.protocol\n\nI suggested in the previous patch set that it is not a good idea to change parsed_args itself. \u0027parsed_args\u0027 returned from parse_args()  should be considered as an constant, and it is used in other places too.","commit_id":"f2c91025fb8146cab6e3dbb8f808466143b82109"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"313734966a9e3242aeb9ff00099265be35a6d1a7","unresolved":false,"context_lines":[{"line_number":357,"context_line":"                                \u0027remote_ip_prefix\u0027, \u0027tenant_id\u0027])"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        if parsed_args.protocol \u003d\u003d \u0027any\u0027:"},{"line_number":360,"context_line":"            body.pop(\u0027protocol\u0027)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        if parsed_args.remote_group_id:"},{"line_number":363,"context_line":"            _remote_group_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_a7d96f85","line":360,"in_reply_to":"fa69d971_d736bc02","updated":"2016-01-04 03:17:44.000000000","message":"Understand ! Thanks for the kindly explanation.","commit_id":"f2c91025fb8146cab6e3dbb8f808466143b82109"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a3d19f4949d228df7939fb9b424e2ee951e76ec0","unresolved":false,"context_lines":[{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        if parsed_args.protocol \u003d\u003d \u0027any\u0027:"},{"line_number":357,"context_line":"            body[\u0027protocol\u0027] \u003d None"},{"line_number":358,"context_line":"        else:"},{"line_number":359,"context_line":"            body[\u0027protocol\u0027] \u003d parsed_args.protocol"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        neutronV20.update_dict(parsed_args, body,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba63e191_44f8eae5","line":358,"range":{"start_line":358,"start_character":8,"end_line":358,"end_character":13},"updated":"2016-01-19 07:12:35.000000000","message":"Consider:\n\n  elif parsed_args.protocol:\n\nI believe we should not send any value if --protocol option is unspecified.","commit_id":"ef6174ddd70c6b9544e4ec73393601776a71b164"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4630355a43cfbb79eeacec52af992cbdcc735543","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        neutronV20.update_dict(parsed_args, body,"},{"line_number":360,"context_line":"                               [\u0027port_range_min\u0027, \u0027port_range_max\u0027,"},{"line_number":361,"context_line":"                                \u0027remote_ip_prefix\u0027, \u0027tenant_id\u0027])"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        if parsed_args.remote_group_id:"},{"line_number":364,"context_line":"            _remote_group_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":365,"context_line":"                self.get_client(), \u0027security_group\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a68dd71_1c2fc1a2","line":362,"updated":"2016-01-20 14:13:59.000000000","message":"nit...new line added","commit_id":"8939c3c71cb7a3f05d917082ab005684d18a08aa"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4630355a43cfbb79eeacec52af992cbdcc735543","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                self.get_client(), \u0027security_group\u0027,"},{"line_number":366,"context_line":"                parsed_args.remote_group_id)"},{"line_number":367,"context_line":"            body[\u0027remote_group_id\u0027] \u003d _remote_group_id"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        return {\u0027security_group_rule\u0027: body}"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9a68dd71_3c2c05ab","line":368,"updated":"2016-01-20 14:13:59.000000000","message":"nit...new line added","commit_id":"8939c3c71cb7a3f05d917082ab005684d18a08aa"}],"neutronclient/tests/unit/test_cli20_securitygroup.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"df6af8a0cc5adcfa3ffcf44236ca8ca13a49e990","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    def _create_args(self, protocol):"},{"line_number":150,"context_line":"        remote_ip_prefix \u003d \u002710.0.0.0/24\u0027"},{"line_number":151,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":152,"context_line":"        ethertype \u003d \u0027IPv4\u0027"},{"line_number":153,"context_line":"        port_range_min \u003d \u002722\u0027"},{"line_number":154,"context_line":"        port_range_max \u003d \u002722\u0027"},{"line_number":155,"context_line":"        remote_group_id \u003d \u00271\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_e2e89de4","line":152,"range":{"start_line":152,"start_character":8,"end_line":152,"end_character":17},"updated":"2015-12-26 03:10:42.000000000","message":"Try a test case where you do not pass ethertype, and pass protocol\u003dany ( as my comment suggests earlier...) you might be surprised...\nAlso, its an interesting test case to add","commit_id":"f2c91025fb8146cab6e3dbb8f808466143b82109"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5a916495bf4b893df058a262f118a86667fbe9a1","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # test with protocal \u0027any\u0027"},{"line_number":189,"context_line":"        protocol \u003d \u0027any\u0027"},{"line_number":190,"context_line":"        args, position_names, position_values \u003d self._create_args(protocol)"},{"line_number":191,"context_line":"        self._test_create_resource(resource, cmd, None, myid, args,"},{"line_number":192,"context_line":"                                   position_names, position_values)"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa69d971_bf2ac47c","line":190,"updated":"2016-01-04 15:03:49.000000000","message":"Could you split the second test into a separate test?","commit_id":"174b40aa967b9b903d7cd4f164bfc825062c47e9"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"242df6ef4fc71fad22c47fe1191e51cd4102963b","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        # test with protocal \u0027any\u0027"},{"line_number":189,"context_line":"        protocol \u003d \u0027any\u0027"},{"line_number":190,"context_line":"        args, position_names, position_values \u003d self._create_args(protocol)"},{"line_number":191,"context_line":"        self._test_create_resource(resource, cmd, None, myid, args,"},{"line_number":192,"context_line":"                                   position_names, position_values)"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"fa69d971_f47e0818","line":190,"in_reply_to":"fa69d971_bf2ac47c","updated":"2016-01-05 00:47:41.000000000","message":"Done","commit_id":"174b40aa967b9b903d7cd4f164bfc825062c47e9"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"127bae71be7696f26100af81fc9a1f847750115e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        cmd \u003d securitygroup.CreateSecurityGroupRule("},{"line_number":204,"context_line":"            test_cli20.MyApp(sys.stdout), None)"},{"line_number":205,"context_line":"        myid \u003d \u0027myid\u0027"},{"line_number":206,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":207,"context_line":"        ethertype \u003d \u0027IPv4\u0027"},{"line_number":208,"context_line":"        protocol \u003d \u00272\u0027"},{"line_number":209,"context_line":"        port_range_min \u003d \u002722\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa69d971_34b2474d","line":206,"updated":"2016-01-05 13:42:00.000000000","message":"Maybe I\u0027m missing something, but it seems like you should use _create_args() for this test just like the others.","commit_id":"2e667332b2912ddabdefd6c467c1347e52fb74ce"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"e14b6390e578b7ab70ae4e930809312b0824c9a2","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        cmd \u003d securitygroup.CreateSecurityGroupRule("},{"line_number":204,"context_line":"            test_cli20.MyApp(sys.stdout), None)"},{"line_number":205,"context_line":"        myid \u003d \u0027myid\u0027"},{"line_number":206,"context_line":"        direction \u003d \u0027ingress\u0027"},{"line_number":207,"context_line":"        ethertype \u003d \u0027IPv4\u0027"},{"line_number":208,"context_line":"        protocol \u003d \u00272\u0027"},{"line_number":209,"context_line":"        port_range_min \u003d \u002722\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa69d971_64fa3145","line":206,"in_reply_to":"fa69d971_34b2474d","updated":"2016-01-06 01:03:09.000000000","message":"Done","commit_id":"2e667332b2912ddabdefd6c467c1347e52fb74ce"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"36e6cbbc381ff360d753977175b71a83251db500","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            test_cli20.MyApp(sys.stdout), None)"},{"line_number":181,"context_line":"        myid \u003d \u0027myid\u0027"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        protocol \u003d \u0027tcp\u0027"},{"line_number":184,"context_line":"        args, position_names, position_values \u003d self._create_args(protocol)"},{"line_number":185,"context_line":"        self._test_create_resource(resource, cmd, None, myid, args,"},{"line_number":186,"context_line":"                                   position_names, position_values)"}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_e74843b5","line":183,"updated":"2016-01-15 09:47:58.000000000","message":"local variable looks un-necessary.","commit_id":"ef6174ddd70c6b9544e4ec73393601776a71b164"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"36e6cbbc381ff360d753977175b71a83251db500","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        myid \u003d \u0027myid\u0027"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        # test with protocal \u0027any\u0027"},{"line_number":196,"context_line":"        protocol \u003d \u0027any\u0027"},{"line_number":197,"context_line":"        args, position_names, position_values \u003d self._create_args(protocol)"},{"line_number":198,"context_line":"        self._test_create_resource(resource, cmd, None, myid, args,"},{"line_number":199,"context_line":"                                   position_names, position_values)"}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_67d3f3d5","line":196,"updated":"2016-01-15 09:47:58.000000000","message":"ditto","commit_id":"ef6174ddd70c6b9544e4ec73393601776a71b164"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"36e6cbbc381ff360d753977175b71a83251db500","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            test_cli20.MyApp(sys.stdout), None)"},{"line_number":205,"context_line":"        myid \u003d \u0027myid\u0027"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        protocol \u003d \u00272\u0027"},{"line_number":208,"context_line":"        args, position_names, position_values \u003d self._create_args(protocol)"},{"line_number":209,"context_line":"        self._test_create_resource(resource, cmd, None, myid, args,"},{"line_number":210,"context_line":"                                   position_names, position_values)"}],"source_content_type":"text/x-python","patch_set":14,"id":"da6ed579_c7e41fad","line":207,"updated":"2016-01-15 09:47:58.000000000","message":"ditto","commit_id":"ef6174ddd70c6b9544e4ec73393601776a71b164"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"4630355a43cfbb79eeacec52af992cbdcc735543","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                                   position_names, position_values)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def test_create_security_group_rule_any(self):"},{"line_number":188,"context_line":"        # Create security group rule."},{"line_number":189,"context_line":"        resource \u003d \u0027security_group_rule\u0027"},{"line_number":190,"context_line":"        cmd \u003d securitygroup.CreateSecurityGroupRule("},{"line_number":191,"context_line":"            test_cli20.MyApp(sys.stdout), None)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a68dd71_7013815d","line":188,"updated":"2016-01-20 14:13:59.000000000","message":"nit...update comment to note this test if for \u0027any\u0027.","commit_id":"8939c3c71cb7a3f05d917082ab005684d18a08aa"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"81cd9220da7ae7bcabc7fe722df3375a27d95fc3","unresolved":false,"context_lines":[{"line_number":751,"context_line":""},{"line_number":752,"context_line":"        if body.get(\u0027security_group_rule\u0027):"},{"line_number":753,"context_line":"            if body[\u0027security_group_rule\u0027].get(\u0027protocol\u0027) \u003d\u003d \u0027any\u0027:"},{"line_number":754,"context_line":"                body[\u0027security_group_rule\u0027].pop(\u0027protocol\u0027)"},{"line_number":755,"context_line":"        if body.get(\u0027security_group_rules\u0027):"},{"line_number":756,"context_line":"            for rule in body[\u0027security_group_rules\u0027]:"},{"line_number":757,"context_line":"                if rule.get(\u0027protocol\u0027) \u003d\u003d \u0027any\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_454365b2","line":754,"updated":"2015-12-21 13:52:16.000000000","message":"This needs a unit test.","commit_id":"129ea404bd4f0d22b7c4db48b5439d6b4d3f2827"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"81cd9220da7ae7bcabc7fe722df3375a27d95fc3","unresolved":false,"context_lines":[{"line_number":755,"context_line":"        if body.get(\u0027security_group_rules\u0027):"},{"line_number":756,"context_line":"            for rule in body[\u0027security_group_rules\u0027]:"},{"line_number":757,"context_line":"                if rule.get(\u0027protocol\u0027) \u003d\u003d \u0027any\u0027:"},{"line_number":758,"context_line":"                    rule.pop(\u0027protocol\u0027)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        return self.post(self.security_group_rules_path, body\u003dbody)"},{"line_number":761,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_c515159c","line":758,"updated":"2015-12-21 13:52:16.000000000","message":"This needs a unit test.","commit_id":"129ea404bd4f0d22b7c4db48b5439d6b4d3f2827"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"edc2453733a9491bece54dc04ad8b1313bf56db2","unresolved":false,"context_lines":[{"line_number":749,"context_line":"    def create_security_group_rule(self, body\u003dNone):"},{"line_number":750,"context_line":"        \"\"\"Creates a new security group rule.\"\"\""},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"        if body.get(\u0027security_group_rule\u0027):"},{"line_number":753,"context_line":"            if body[\u0027security_group_rule\u0027].get(\u0027protocol\u0027) \u003d\u003d \u0027any\u0027:"},{"line_number":754,"context_line":"                body[\u0027security_group_rule\u0027].pop(\u0027protocol\u0027)"},{"line_number":755,"context_line":"        if body.get(\u0027security_group_rules\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_69b065f5","line":752,"updated":"2015-12-23 10:05:22.000000000","message":"Why we need to handle this here? Can\u0027t we handle it inside https://github.com/openstack/python-neutronclient/blob/master/neutronclient/neutron/v2_0/securitygroup.py#L131-L135.","commit_id":"3ffcfa1b09b50b9171c7c083d9e744a160ef307f"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"86b5985d59d676ae0299ff36dfda1116d606f687","unresolved":false,"context_lines":[{"line_number":749,"context_line":"    def create_security_group_rule(self, body\u003dNone):"},{"line_number":750,"context_line":"        \"\"\"Creates a new security group rule.\"\"\""},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"        if body.get(\u0027security_group_rule\u0027):"},{"line_number":753,"context_line":"            if body[\u0027security_group_rule\u0027].get(\u0027protocol\u0027) \u003d\u003d \u0027any\u0027:"},{"line_number":754,"context_line":"                body[\u0027security_group_rule\u0027].pop(\u0027protocol\u0027)"},{"line_number":755,"context_line":"        if body.get(\u0027security_group_rules\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a7b0d38_77682088","line":752,"in_reply_to":"1a7b0d38_69b065f5","updated":"2015-12-24 02:02:15.000000000","message":"Thanks!","commit_id":"3ffcfa1b09b50b9171c7c083d9e744a160ef307f"}]}
