)]}'
{"neutronclient/shell.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"c15b0ebea24114f6ce663e6c2865c28c1dd774a9","unresolved":false,"context_lines":[{"line_number":841,"context_line":"        auth \u003d None"},{"line_number":842,"context_line":"        auth_session \u003d None"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        if(not self.options.os_token and not self.options.os_url):"},{"line_number":845,"context_line":"            auth \u003d cloud_config.get_auth()"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"            auth_session \u003d session.Session("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_c4d504e5","line":844,"updated":"2016-01-06 14:05:57.000000000","message":"Should token endpoint authentication only be done if both os_token and os_url are set?  Maybe the \"and\" should be an \"or\" here.","commit_id":"3dd2abbe22af5a4a1fd749c4ba8c265def5b20bb"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"bb118a725f58e677a26ed16b742c3fc7cfca2271","unresolved":false,"context_lines":[{"line_number":841,"context_line":"        auth \u003d None"},{"line_number":842,"context_line":"        auth_session \u003d None"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        if(not self.options.os_token and not self.options.os_url):"},{"line_number":845,"context_line":"            auth \u003d cloud_config.get_auth()"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"            auth_session \u003d session.Session("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_705c0f7d","line":844,"in_reply_to":"fa69d971_c4d504e5","updated":"2016-01-06 16:46:12.000000000","message":"Good catch Richard. In the current case, if self.options.os_token were to have a value, then it would assume to do token endpoint authentication without even checking the other condition.","commit_id":"3dd2abbe22af5a4a1fd749c4ba8c265def5b20bb"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"122b581b1a9995450166a8ed69d24cf5874fa77c","unresolved":false,"context_lines":[{"line_number":841,"context_line":"        auth \u003d None"},{"line_number":842,"context_line":"        auth_session \u003d None"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        if(not self.options.os_token or not self.options.os_url):"},{"line_number":845,"context_line":"            auth \u003d cloud_config.get_auth()"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"            auth_session \u003d session.Session("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_3bf088c9","line":844,"updated":"2016-01-07 15:34:25.000000000","message":"Style nit: Please remove the parentheses here, or transform using De Morgan\u0027s law to the following (which IMO is easier to read):\n\n    if not (self.options.os_token and self.options.os_url)","commit_id":"06703dd595ccd84029d75f8a6500b15278577fb0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2a887a6df707e409db1c5afd4acf29d981b7687c","unresolved":false,"context_lines":[{"line_number":841,"context_line":"        auth \u003d None"},{"line_number":842,"context_line":"        auth_session \u003d None"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        if(not self.options.os_token or not self.options.os_url):"},{"line_number":845,"context_line":"            auth \u003d cloud_config.get_auth()"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"            auth_session \u003d session.Session("}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_ea5c0e7f","line":844,"in_reply_to":"fa69d971_3bf088c9","updated":"2016-01-08 11:38:08.000000000","message":"+1\n\nIn addition, I would like to see L.841-842 inside the condition. It sounds clearer to me.\n\n  if self.options.os_token and self.options.os_url:\n      auth \u003d None\n      auth_session \u003d None\n  else:\n      ....","commit_id":"06703dd595ccd84029d75f8a6500b15278577fb0"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"1b875a232f81323f30265db0c4f55c3804c00007","unresolved":false,"context_lines":[{"line_number":841,"context_line":"        auth \u003d None"},{"line_number":842,"context_line":"        auth_session \u003d None"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        if(not self.options.os_token or not self.options.os_url):"},{"line_number":845,"context_line":"            auth \u003d cloud_config.get_auth()"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"            auth_session \u003d session.Session("}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_37d70825","line":844,"in_reply_to":"fa69d971_3bf088c9","updated":"2016-01-12 22:55:13.000000000","message":"This is much cleaner but went with Akihiro\u0027s suggestion since it\u0027s more clear.","commit_id":"06703dd595ccd84029d75f8a6500b15278577fb0"},{"author":{"_account_id":18658,"name":"Jas Singh","email":"singhj@us.ibm.com","username":"singhj"},"change_message_id":"1b875a232f81323f30265db0c4f55c3804c00007","unresolved":false,"context_lines":[{"line_number":841,"context_line":"        auth \u003d None"},{"line_number":842,"context_line":"        auth_session \u003d None"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        if(not self.options.os_token or not self.options.os_url):"},{"line_number":845,"context_line":"            auth \u003d cloud_config.get_auth()"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"            auth_session \u003d session.Session("}],"source_content_type":"text/x-python","patch_set":4,"id":"da6ed579_17bbe4e6","line":844,"in_reply_to":"fa69d971_ea5c0e7f","updated":"2016-01-12 22:55:13.000000000","message":"Done","commit_id":"06703dd595ccd84029d75f8a6500b15278577fb0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"38373555a5541523cf3d50f0a4d295aa9fcc1762","unresolved":false,"context_lines":[{"line_number":837,"context_line":"            cloud\u003dself.options.os_cloud, argparse\u003dself.options,"},{"line_number":838,"context_line":"            network_api_version\u003dself.api_version)"},{"line_number":839,"context_line":"        verify, cert \u003d cloud_config.get_requests_verify_args()"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"        if self.options.os_token and self.options.os_url:"},{"line_number":842,"context_line":"            auth \u003d None"},{"line_number":843,"context_line":"            auth_session \u003d None"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_d9e8fa12","line":840,"updated":"2016-01-13 14:38:48.000000000","message":"Could you add a note that HTTPClient is used when os_url and os_token are specified and otherwise SessionClient is used. I believe it is worth commented here.","commit_id":"2a9b507dfd100184afb832df458ed208886a1a7f"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"63db7575fa08f30c0ace42c72b28619a3abd15d1","unresolved":false,"context_lines":[{"line_number":899,"context_line":"            network_api_version\u003dself.api_version)"},{"line_number":900,"context_line":"        verify, cert \u003d cloud_config.get_requests_verify_args()"},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"        # TODO(singhj): Remove dependancy on HTTPClient"},{"line_number":903,"context_line":"        # for the case of token-endpoint authentication"},{"line_number":904,"context_line":""},{"line_number":905,"context_line":"        # When using token-endpoint authentication legacy"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_88e59bdd","line":902,"updated":"2016-03-02 23:36:45.000000000","message":"nit: dependency","commit_id":"0740766467a3c8de0bf9d03689158a86591bd506"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cc6eccf111bad99561d05abec1171fc861b456df","unresolved":false,"context_lines":[{"line_number":899,"context_line":"            network_api_version\u003dself.api_version)"},{"line_number":900,"context_line":"        verify, cert \u003d cloud_config.get_requests_verify_args()"},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"        # TODO(singhj): Remove dependancy on HTTPClient"},{"line_number":903,"context_line":"        # for the case of token-endpoint authentication"},{"line_number":904,"context_line":""},{"line_number":905,"context_line":"        # When using token-endpoint authentication legacy"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_c88b23c2","line":902,"in_reply_to":"7af24918_88e59bdd","updated":"2016-03-02 23:42:52.000000000","message":"Let\u0027s correct it in a follow-up patch.\nThis fix is worth included in the next neutronclient release.","commit_id":"0740766467a3c8de0bf9d03689158a86591bd506"}],"releasenotes/notes/add-token-endpoint-auth-support-26bf7ee12e4ec833.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e0b0422e07f6cf61ecbe53bc081f22fae7a2093f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    CLI support for token-endpoint authentication."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7af24918_88dbdb4e","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":8},"updated":"2016-03-02 23:34:00.000000000","message":"This is actually a bug fix. To shorten the gate time, I would like to update it after merging this patch.","commit_id":"0740766467a3c8de0bf9d03689158a86591bd506"}]}