)]}'
{"neutronclient/shell.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b8605f625c7650dcdd089a9864404c2df1793b38","unresolved":false,"context_lines":[{"line_number":823,"context_line":"            raise"},{"line_number":824,"context_line":"        except Exception as e:"},{"line_number":825,"context_line":"            if self.options.verbose_level \u003e\u003d self.DEBUG_LEVEL:"},{"line_number":826,"context_line":"                self.log.exception(\"%s\", e)"},{"line_number":827,"context_line":"                raise"},{"line_number":828,"context_line":"            self.log.error(\"%s\", e)"},{"line_number":829,"context_line":"        return 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_573061e8","side":"PARENT","line":826,"range":{"start_line":826,"start_character":35,"end_line":826,"end_character":42},"updated":"2016-01-13 11:00:32.000000000","message":"I think this is a better way to pass an exception message. It is more clear than log.exception(six.text_type(e)) and developers needs more knowledge. what is the reason you suggest log.xxx(six.text_type(e)) over log.xxx(\"%s\", e)? If there is no special reason, I would suggest to use log.xxx(\"%s\", e).","commit_id":"1ee3ecd0ec3ecce93804217ccddb8374ae0127d5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b9df0efb4331354ce4ef140169233be62c94dbe4","unresolved":false,"context_lines":[{"line_number":823,"context_line":"            raise"},{"line_number":824,"context_line":"        except Exception as e:"},{"line_number":825,"context_line":"            if self.options.verbose_level \u003e\u003d self.DEBUG_LEVEL:"},{"line_number":826,"context_line":"                self.log.exception(\"%s\", e)"},{"line_number":827,"context_line":"                raise"},{"line_number":828,"context_line":"            self.log.error(\"%s\", e)"},{"line_number":829,"context_line":"        return 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_889b9f65","side":"PARENT","line":826,"range":{"start_line":826,"start_character":35,"end_line":826,"end_character":42},"in_reply_to":"da6ed579_573061e8","updated":"2016-02-23 20:29:49.000000000","message":"An exception object shouldn\u0027t be passed in to log.exception anyway. log.exception already logs whatever exception is currently in scope. So log.exception(\u0027Some error string\u0027) would be better, else log.error(\u0027Some error: %s\u0027, e)","commit_id":"1ee3ecd0ec3ecce93804217ccddb8374ae0127d5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b8605f625c7650dcdd089a9864404c2df1793b38","unresolved":false,"context_lines":[{"line_number":795,"context_line":"            self.initialize_app(remainder)"},{"line_number":796,"context_line":"        except Exception as err:"},{"line_number":797,"context_line":"            if self.options.verbose_level \u003e\u003d self.DEBUG_LEVEL:"},{"line_number":798,"context_line":"                self.log.exception(six.text_type(err))"},{"line_number":799,"context_line":"                raise"},{"line_number":800,"context_line":"            self.log.error(six.text_type(err))"},{"line_number":801,"context_line":"            return 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_7769e5bd","line":798,"updated":"2016-01-13 11:00:32.000000000","message":"As I commented below, if you prefer to using a consistent usage, log.xxx(\"%s\", e) is preferred.","commit_id":"c4a47ad66772fdb27e57717dbaa319f0a485d637"}]}