)]}'
{"id":"openstack%2Fpython-neutronclient~269402","triplet_id":"openstack%2Fpython-neutronclient~master~Ifea1a984aeb8335c8f715799f0222c8dec13a8a1","project":"openstack/python-neutronclient","branch":"master","topic":"1422371","hashtags":[],"change_id":"Ifea1a984aeb8335c8f715799f0222c8dec13a8a1","subject":"Fix neutron-client can repeat (set/clear) gateway in router","status":"ABANDONED","created":"2016-01-19 02:55:17.000000000","updated":"2016-12-23 13:06:58.000000000","total_comment_count":15,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"641bf1df069a7f2a29cbcf7ea176d6db09da9042","_number":269402,"virtual_id_number":269402,"owner":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-03-10 07:38:06.000000000","_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},{"value":-1,"date":"2016-11-25 10:36:44.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-02-02 12:36:56.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"date":"2016-01-29 01:34:03.000000000","_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"date":"2016-12-23 13:06:58.000000000","_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-02-02 12:40:49.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},{"value":-1,"date":"2016-01-28 14:13:20.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-19 09:05:13.000000000","updated_by":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"reviewer":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"state":"REVIEWER"},{"updated":"2016-01-28 14:13:20.000000000","updated_by":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"reviewer":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"state":"REVIEWER"},{"updated":"2016-02-02 12:36:56.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2016-03-10 07:38:06.000000000","updated_by":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"reviewer":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"state":"REVIEWER"},{"updated":"2016-11-25 10:36:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-12-23 13:06:58.000000000","updated_by":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"reviewer":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"state":"REVIEWER"}],"messages":[{"id":"a99e4985f0e71ece3097790de702f70742881a18","author":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"date":"2016-01-19 02:55:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8b450408431613fe1a1099a28f63c572f917791d","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-01-19 03:00:52.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"70d0a053c0c1b0742ad6e2c5f97dcda8e05993d5","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-01-19 03:01:28.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nfor the commit message","accounts_in_message":[],"_revision_number":1},{"id":"7e760bf5559732d80f71a3e97f91b72239048d66","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-19 04:22:38.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/02/269402/1/check/gate-python-neutronclient-pep8/0c3887b/ : SUCCESS in 58s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/02/269402/1/check/gate-python-neutronclient-docs/7b9e4f7//doc/build/html/ : SUCCESS in 1m 47s\n- gate-python-neutronclient-python27 http://logs.openstack.org/02/269402/1/check/gate-python-neutronclient-python27/8507a01/ : FAILURE in 1m 11s\n- gate-python-neutronclient-python34 http://logs.openstack.org/02/269402/1/check/gate-python-neutronclient-python34/9afdc05/ : FAILURE in 2m 03s\n- gate-python-neutronclient-pypy http://logs.openstack.org/02/269402/1/check/gate-python-neutronclient-pypy/8a4d6ca/ : FAILURE in 1m 59s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/02/269402/1/check/gate-tempest-dsvm-neutron-src-python-neutronclient/1ea57f2/ : SUCCESS in 1h 27m 10s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/02/269402/1/check/gate-neutronclient-test-dsvm-functional/d66b499/ : SUCCESS in 25m 44s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/02/269402/1/check/gate-neutronclient-test-dsvm-functional-adv-svcs/b1f5c6b/ : SUCCESS in 30m 16s","accounts_in_message":[],"_revision_number":1},{"id":"950b1cabf23ec70884384e5bb965e39377031577","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-01-19 08:46:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"306d49a3c40a03830bd14eed5fa0d1833ac24de1","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-01-19 08:49:02.000000000","message":"Topic changed from (detached to bug/1422371","accounts_in_message":[],"_revision_number":2},{"id":"c054020a2ff22032ea3bcb454df9f51f4e2c0f83","author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"date":"2016-01-19 09:05:13.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"34bbc0318e25a969709e76d78d3c848122dc7a68","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-01-19 09:11:06.000000000","message":"Patch Set 2:\n\n@Bo Chi: ex_info is coming out to be a List actually","accounts_in_message":[],"_revision_number":2},{"id":"6eee56e4d46786351916de763cabcd556cb78fcc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-19 10:37:42.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/02/269402/2/check/gate-python-neutronclient-pep8/6373e21/ : SUCCESS in 1m 00s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/02/269402/2/check/gate-python-neutronclient-docs/f8ac4a9//doc/build/html/ : SUCCESS in 1m 58s\n- gate-python-neutronclient-python27 http://logs.openstack.org/02/269402/2/check/gate-python-neutronclient-python27/7d4fb8d/ : SUCCESS in 2m 24s\n- gate-python-neutronclient-python34 http://logs.openstack.org/02/269402/2/check/gate-python-neutronclient-python34/96e4af9/ : SUCCESS in 1m 42s\n- gate-python-neutronclient-pypy http://logs.openstack.org/02/269402/2/check/gate-python-neutronclient-pypy/25f145f/ : SUCCESS in 2m 57s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/02/269402/2/check/gate-tempest-dsvm-neutron-src-python-neutronclient/85ce16d/ : SUCCESS in 1h 49m 18s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/02/269402/2/check/gate-neutronclient-test-dsvm-functional/296ce19/ : SUCCESS in 37m 29s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/02/269402/2/check/gate-neutronclient-test-dsvm-functional-adv-svcs/028576e/ : SUCCESS in 28m 22s","accounts_in_message":[],"_revision_number":2},{"id":"328556e4b3e606c8547e16bd4f575725773b41c9","author":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"date":"2016-01-20 06:16:45.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e9f3d16a2ace964e9381db33c280ce9571df6237","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-20 08:01:28.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/02/269402/3/check/gate-python-neutronclient-pep8/ea5188a/ : SUCCESS in 1m 06s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/02/269402/3/check/gate-python-neutronclient-docs/a9b78a6//doc/build/html/ : SUCCESS in 1m 01s\n- gate-python-neutronclient-python27 http://logs.openstack.org/02/269402/3/check/gate-python-neutronclient-python27/8813bca/ : FAILURE in 1m 06s\n- gate-python-neutronclient-python34 http://logs.openstack.org/02/269402/3/check/gate-python-neutronclient-python34/b3e6084/ : FAILURE in 2m 01s\n- gate-python-neutronclient-pypy http://logs.openstack.org/02/269402/3/check/gate-python-neutronclient-pypy/421af95/ : FAILURE in 1m 56s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/02/269402/3/check/gate-tempest-dsvm-neutron-src-python-neutronclient/f6dfc98/ : SUCCESS in 1h 35m 40s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/02/269402/3/check/gate-neutronclient-test-dsvm-functional/8d36bb8/ : SUCCESS in 32m 00s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/02/269402/3/check/gate-neutronclient-test-dsvm-functional-adv-svcs/3bd67c6/ : SUCCESS in 37m 09s","accounts_in_message":[],"_revision_number":3},{"id":"d8cd7bc579ddf4143ed3ef559ff5ab4a8d39c29a","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-01-20 08:12:23.000000000","message":"Patch Set 3:\n\n@Bo chi, @ Jacky : Please refer http://logs.openstack.org/02/269402/3/check/gate-python-neutronclient-python27/8813bca/console.html#_2016-01-20_06_27_01_936\n\nex_info is coming out to be a list unfortunately it seems","accounts_in_message":[],"_revision_number":3},{"id":"3316aa422e9dae79887dcc8d4b8a8a0267409fc3","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-01-21 01:42:03.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"72e6d323a890a89cba6c6f9d1ff32252d07e4773","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-01-21 01:43:22.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"af1b8b03a34ebcde0f9e63688319201995e9dcb5","author":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"date":"2016-01-21 02:08:52.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"a7d1376bb9326b40203b5a1d3c3636442a389893","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-01-21 03:15:32.000000000","message":"Patch Set 6: Published edit on patch set 5","accounts_in_message":[],"_revision_number":6},{"id":"911823a4ea29972dd696a76cf476dc8379394006","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-21 04:48:26.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/02/269402/6/check/gate-python-neutronclient-pep8/70d50b9/ : SUCCESS in 1m 05s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/02/269402/6/check/gate-python-neutronclient-docs/6d8dc30//doc/build/html/ : SUCCESS in 1m 14s\n- gate-python-neutronclient-python27 http://logs.openstack.org/02/269402/6/check/gate-python-neutronclient-python27/9330fce/ : FAILURE in 1m 15s\n- gate-python-neutronclient-python34 http://logs.openstack.org/02/269402/6/check/gate-python-neutronclient-python34/073ded7/ : FAILURE in 1m 41s\n- gate-python-neutronclient-pypy http://logs.openstack.org/02/269402/6/check/gate-python-neutronclient-pypy/638fd10/ : FAILURE in 3m 27s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/02/269402/6/check/gate-tempest-dsvm-neutron-src-python-neutronclient/0e7981a/ : SUCCESS in 1h 29m 14s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/02/269402/6/check/gate-neutronclient-test-dsvm-functional/67f28cb/ : SUCCESS in 23m 59s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/02/269402/6/check/gate-neutronclient-test-dsvm-functional-adv-svcs/fd298b3/ : SUCCESS in 23m 21s","accounts_in_message":[],"_revision_number":6},{"id":"7433a4541e9839958c0217d41e5417865fabfa90","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-01-22 02:30:06.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"f26ab50ff672dd37c66b4aa88722e327e717bd94","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-01-22 03:17:18.000000000","message":"Topic changed from (detached to bug/1422371","accounts_in_message":[],"_revision_number":7},{"id":"1d7c053da8ba95f26e2d79ad6107c126f571877d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-22 03:28:48.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/02/269402/7/check/gate-python-neutronclient-pep8/5b4fac7/ : SUCCESS in 1m 12s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/02/269402/7/check/gate-python-neutronclient-docs/7437e8f//doc/build/html/ : SUCCESS in 1m 09s\n- gate-python-neutronclient-python27 http://logs.openstack.org/02/269402/7/check/gate-python-neutronclient-python27/7af0eb4/ : SUCCESS in 1m 41s\n- gate-python-neutronclient-python34 http://logs.openstack.org/02/269402/7/check/gate-python-neutronclient-python34/d0c64b9/ : SUCCESS in 1m 40s\n- gate-python-neutronclient-pypy http://logs.openstack.org/02/269402/7/check/gate-python-neutronclient-pypy/bbd9fab/ : SUCCESS in 2m 02s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/02/269402/7/check/gate-tempest-dsvm-neutron-src-python-neutronclient/9520f2c/ : SUCCESS in 49m 48s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/02/269402/7/check/gate-neutronclient-test-dsvm-functional/7426d4b/ : SUCCESS in 25m 14s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/02/269402/7/check/gate-neutronclient-test-dsvm-functional-adv-svcs/70659c9/ : SUCCESS in 28m 17s","accounts_in_message":[],"_revision_number":7},{"id":"24d824c4f9dae8078d851fb1efe0a66fce3bf0df","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2016-01-24 18:55:47.000000000","message":"Patch Set 7: Code-Review-1\n\n(5 comments)\n\nAccording to the bug report, the problem is that we can router-gateway-set is accepted even when a router already has an external gateway. Similarly, the problem is that we can do router-gateway-clear even when a router has no external gateway.\n\nThis patch proposed more complicated solution.\nIf an external gateway is unchanged, it raises an exception, but if something is changed, an request will be accepted. I am not sure this is the right direction. It seems it makes a situation more complicated.\nMy vote is to make the condition simpler.\n\nIn addition, we cannot assume ext-gw-mode is supported by all plugins.\nIt is a different extension from \u0027l3\u0027 extension.  The current logic seems to assume ext-gw-mode extension is always supported.","accounts_in_message":[],"_revision_number":7},{"id":"05cbe57c6ce2d1f986924b2c0582c67616c0345a","author":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"date":"2016-01-27 02:56:54.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"108d944b35805489e60c80ad3e872c09dfa8c2d4","author":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"date":"2016-01-27 03:00:29.000000000","message":"Patch Set 8:\n\n\u003e (5 comments)\n \u003e \n \u003e According to the bug report, the problem is that we can\n \u003e router-gateway-set is accepted even when a router already has an\n \u003e external gateway. Similarly, the problem is that we can do\n \u003e router-gateway-clear even when a router has no external gateway.\n \u003e \n \u003e This patch proposed more complicated solution.\n \u003e If an external gateway is unchanged, it raises an exception, but if\n \u003e something is changed, an request will be accepted. I am not sure\n \u003e this is the right direction. It seems it makes a situation more\n \u003e complicated.\n \u003e My vote is to make the condition simpler.\n \u003e \n \u003e In addition, we cannot assume ext-gw-mode is supported by all\n \u003e plugins.\n \u003e It is a different extension from \u0027l3\u0027 extension.  The current logic\n \u003e seems to assume ext-gw-mode extension is always supported.\n\nHi Akihiro Motoki,\n\nI think you are right on Line268 comments,on set-gateway function,we should check if new params same as existed one(1.network_id 2.fix_ip 3.snat-enable)\n\nThanks","accounts_in_message":[],"_revision_number":8},{"id":"a583aac71d350c7e860e8412611c319bdde1a5fa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-27 04:09:09.000000000","message":"Patch Set 8: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/02/269402/8/check/gate-python-neutronclient-pep8/af0075d/ : SUCCESS in 1m 37s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/02/269402/8/check/gate-python-neutronclient-docs/3f9c2a2//doc/build/html/ : SUCCESS in 1m 16s\n- gate-python-neutronclient-python27 http://logs.openstack.org/02/269402/8/check/gate-python-neutronclient-python27/0adf566/ : FAILURE in 1m 08s\n- gate-python-neutronclient-python34 http://logs.openstack.org/02/269402/8/check/gate-python-neutronclient-python34/a6586c8/ : FAILURE in 1m 43s\n- gate-python-neutronclient-pypy http://logs.openstack.org/02/269402/8/check/gate-python-neutronclient-pypy/6658ab6/ : FAILURE in 1m 42s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/02/269402/8/check/gate-tempest-dsvm-neutron-src-python-neutronclient/f136d58/ : SUCCESS in 1h 09m 42s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/02/269402/8/check/gate-neutronclient-test-dsvm-functional/37753df/ : SUCCESS in 32m 28s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/02/269402/8/check/gate-neutronclient-test-dsvm-functional-adv-svcs/0e73c21/ : SUCCESS in 44m 00s","accounts_in_message":[],"_revision_number":8},{"id":"1fb227a109a8ec97be24fed11ebcb9216f681388","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-01-27 04:51:37.000000000","message":"Patch Set 8: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"c3d0192e029bb76ced118fe890485e04080a2d48","author":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"date":"2016-01-27 05:02:55.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"497c28a1856444460625a9b014269919e65cf73e","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-01-27 05:22:02.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"0cc740ef7c08df1f23af6e470ad2b0aa6009655b","author":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"date":"2016-01-27 05:38:25.000000000","message":"Patch Set 8:\n\n\u003e (1 comment)\n\nHi Reedip,\n\nI think from CLI params,only have --disable-snat option(not have enable-enable command).so if --disable-snat existed,router[\u0027enable_snat\u0027] \u003d\u003dFalse,if nothing input,router[\u0027enable_snat\u0027] \u003d\u003dTrue by default\n\nfrom neutron/neutron/db/l3_gwmode_db.py\n\nLOG \u003d logging.getLogger(__name__)\nOPTS \u003d [\n    cfg.BoolOpt(\u0027enable_snat_by_default\u0027, default\u003dTrue,\n                help\u003d_(\u0027Define the default value of enable_snat if not \u0027\n                       \u0027provided in external_gateway_info.\u0027))\n]\n\n\ndef _get_enable_snat(info):\n        if info and \u0027enable_snat\u0027 in info:\n            return info[\u0027enable_snat\u0027]\n        # if enable_snat is not specified then use the default value\n        return cfg.CONF.enable_snat_by_default","accounts_in_message":[],"_revision_number":8},{"id":"ca5042d77d6fb99129fdcef2b499b4456411225e","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-01-27 06:00:40.000000000","message":"Patch Set 8:\n\nOk, I checked with the following 3 CLIs:\n- router-gateway-set ROUTER NETWORK : enable_snat \u003d True\n- router-gateway-set ROUTER NETWORK : enable_snat \u003d False ( this is the same router)\n- router-gateway-set ROUTER NETWORK : enable_snat \u003d True ( this is the same router)\n\nSo I agree with you , but even if we do not pass enable_snat, still it will be set to True, as it is the default behaviour, isnt it?","accounts_in_message":[],"_revision_number":8},{"id":"a12f3cdc8746bd765d045ff824657284c9306be5","author":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"date":"2016-01-27 06:13:18.000000000","message":"Patch Set 8:\n\n\u003e Ok, I checked with the following 3 CLIs:\n \u003e - router-gateway-set ROUTER NETWORK : enable_snat \u003d True\n \u003e - router-gateway-set ROUTER NETWORK : enable_snat \u003d False ( this is\n \u003e the same router)\n \u003e - router-gateway-set ROUTER NETWORK : enable_snat \u003d True ( this is\n \u003e the same router)\n \u003e \n \u003e So I agree with you , but even if we do not pass enable_snat, still\n \u003e it will be set to True, as it is the default behaviour, isnt it?\n\nYes,I try to set True on here just want try to make the condition simpler.if we set True on here the snat_enable only True or False,if we do not set here,we should consider True False and None","accounts_in_message":[],"_revision_number":8},{"id":"e4a415c0a4346f960ba451b7717cd424c62d98af","author":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"date":"2016-01-27 06:37:17.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"691fefe7d17c6ec9cdbf052d6aece5f478b5fe78","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-27 07:31:21.000000000","message":"Patch Set 9: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/02/269402/9/check/gate-python-neutronclient-pep8/4627476/ : FAILURE in 1m 02s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/02/269402/9/check/gate-python-neutronclient-docs/86bc203//doc/build/html/ : SUCCESS in 1m 13s\n- gate-python-neutronclient-python27 http://logs.openstack.org/02/269402/9/check/gate-python-neutronclient-python27/9eecdd0/ : SUCCESS in 1m 27s\n- gate-python-neutronclient-python34 http://logs.openstack.org/02/269402/9/check/gate-python-neutronclient-python34/4a0ef74/ : SUCCESS in 1m 39s\n- gate-python-neutronclient-pypy http://logs.openstack.org/02/269402/9/check/gate-python-neutronclient-pypy/26635d1/ : SUCCESS in 2m 01s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/02/269402/9/check/gate-tempest-dsvm-neutron-src-python-neutronclient/ff12af1/ : SUCCESS in 50m 51s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/02/269402/9/check/gate-neutronclient-test-dsvm-functional/7c3f251/ : SUCCESS in 31m 43s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/02/269402/9/check/gate-neutronclient-test-dsvm-functional-adv-svcs/2e458b3/ : SUCCESS in 23m 59s","accounts_in_message":[],"_revision_number":9},{"id":"85963ca16507cd1d2a317a1ab565cff3e1d5627b","author":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"date":"2016-01-27 07:41:38.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"fa0c10abd72aaef7de01f0a6dc04245056f1f318","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-27 08:44:47.000000000","message":"Patch Set 10: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/02/269402/10/check/gate-python-neutronclient-pep8/b9a7ad8/ : SUCCESS in 1m 08s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/02/269402/10/check/gate-python-neutronclient-docs/5869d31//doc/build/html/ : SUCCESS in 1m 12s\n- gate-python-neutronclient-python27 http://logs.openstack.org/02/269402/10/check/gate-python-neutronclient-python27/4a235d5/ : SUCCESS in 1m 23s\n- gate-python-neutronclient-python34 http://logs.openstack.org/02/269402/10/check/gate-python-neutronclient-python34/d0754cb/ : SUCCESS in 2m 04s\n- gate-python-neutronclient-pypy http://logs.openstack.org/02/269402/10/check/gate-python-neutronclient-pypy/9bcbafb/ : SUCCESS in 1m 57s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/02/269402/10/check/gate-tempest-dsvm-neutron-src-python-neutronclient/067b516/ : SUCCESS in 58m 42s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/02/269402/10/check/gate-neutronclient-test-dsvm-functional/d01457b/ : SUCCESS in 22m 58s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/02/269402/10/check/gate-neutronclient-test-dsvm-functional-adv-svcs/7d40319/ : SUCCESS in 36m 58s","accounts_in_message":[],"_revision_number":10},{"id":"22aa7e55e05ee482462e6e49f9fdbad7fdb50174","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-01-28 14:13:20.000000000","message":"Patch Set 10: Code-Review-1\n\n(1 comment)\n\nSome concerns about the behavior change here...","accounts_in_message":[],"_revision_number":10},{"id":"fa2557e39fa87d57549cc82d301546aa4cde385d","author":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"date":"2016-01-29 01:34:03.000000000","message":"Patch Set 10:\n\n\u003e (1 comment)\n \u003e \n \u003e Some concerns about the behavior change here...\n\n \u003e (1 comment)\n \u003e \n \u003e Some concerns about the behavior change here...\n\nHi,please see this Bug description:\n\n\n\nAs an API operation, router-gateway-set/clear is PUT operation, so it is not a problem that you can issue the command multiple times.\n\nAs a point of view of CLI user experience, it is a good idea to check a gateway is already set or not.\nThe similar thing is done in Horizon.\nChanged in python-neutronclient:\nimportance: \tUndecided → Wishlist\nstatus: \tNew → Confirmed","accounts_in_message":[],"_revision_number":10},{"id":"059ac5d035f009846435646d61118925a8981a68","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-01-29 13:39:50.000000000","message":"Patch Set 10:\n\nI did review the bug description, but am not sure this is a good idea.  If others are okay with this, I\u0027ll remove my review.","accounts_in_message":[],"_revision_number":10},{"id":"c8cfdfc485b2a3830f25b7953addbfd610c7b677","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2016-02-02 12:36:56.000000000","message":"Patch Set 10:\n\nApart from a core reviewer, as one user, personally it is easy to understand if a command blocks repeated gatewa-set/clear command. router-gateway-set/clear is not a normal commands which correspond to REST API and they are purpose-specific commands, so I think it is okay with the proposed behavior.\n\nOne difficult thing around this proposal is that the condition becomes complicated. I don\u0027t think we need to allow update operation for router-gateway-set. For example, there is no need to update enable_snat for a router which already has a gateway.\n\nIf the logic becomes complicated, I would suggest to do nothing and to keep the current behavior.","accounts_in_message":[],"_revision_number":10},{"id":"fcede78ec17f231b71200b7e5f640f98c694a9b8","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2016-02-02 12:40:49.000000000","message":"Patch Set 10: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":10},{"id":"b0cc13ad25304ebf5b8fb49b2af912d5178efda6","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2016-02-02 12:41:06.000000000","message":"Patch Set 10:\n\nIt seem we need a broader consensus.","accounts_in_message":[],"_revision_number":10},{"id":"f8b7d5f60ed8dd7da63630d70fa6d807c1c4715f","author":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"date":"2016-02-03 04:36:48.000000000","message":"Patch Set 10:\n\n(1 comment)","accounts_in_message":[],"_revision_number":10},{"id":"de275d55f79dc1ff9f8b4be132896ecf5309ea82","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-03-10 07:38:06.000000000","message":"Patch Set 10:\n\nSeems to be my understanding as well","accounts_in_message":[],"_revision_number":10},{"id":"c970327b486f0981dd406a3ad1f7134dd9ab3673","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-04-22 03:48:39.000000000","message":"Patch Set 10:\n\nAny progres??","accounts_in_message":[],"_revision_number":10},{"id":"0113cc65039e17a97b0489f826c1c6132d3d99e2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-25 10:36:44.000000000","message":"Patch Set 10: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":10},{"id":"692761995923ff1b28f3a2eae1314920794d5a3b","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-12-23 13:06:58.000000000","message":"Patch Set 10:\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":10},{"id":"52bd24692f6b1f01f077327ea6a2c7f400067714","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-12-23 13:06:58.000000000","message":"Abandoned\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":10}],"current_revision_number":10,"current_revision":"23c0d784c7f8af46f8f5f3ef96ac3ec836f673a7","revisions":{"9478e4adda5e95b5d0a723661ede411055bac1af":{"kind":"REWORK","_number":1,"created":"2016-01-19 02:55:17.000000000","uploader":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"ref":"refs/changes/02/269402/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/02/269402/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/1"}}},"commit":{"parents":[{"commit":"a0134f89af21a274d5f0cc7c2e1696755543c713","subject":"Merge \"Setup for translation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/a0134f89af21a274d5f0cc7c2e1696755543c713"}]}],"author":{"name":"lei zhang","email":"shleiz@cn.ibm.com","date":"2015-12-06 05:51:49.000000000","tz":480},"committer":{"name":"lei zhang","email":"shleiz@cn.ibm.com","date":"2015-12-06 06:05:05.000000000","tz":480},"subject":"Fix repeat set-gateway to same ip address and clear None gateway in neutron-client","message":"Fix repeat set-gateway to same ip address and clear None gateway in neutron-client\n\nFrom neutron-client,we can repeat set-gateway to sanme ip address and clear router\ngateway which is not set gateway.\n\nThis patch add check in set-gateway and gateway-clear function\n\nChange-Id: Ifea1a984aeb8335c8f715799f0222c8dec13a8a1\nCloses-Bug: #1422371\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/9478e4adda5e95b5d0a723661ede411055bac1af"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/9478e4adda5e95b5d0a723661ede411055bac1af"}]},"branch":"refs/heads/master"},"19514faeaa21dd4c5d6890230020c634f28ca259":{"kind":"REWORK","_number":2,"created":"2016-01-19 08:46:31.000000000","uploader":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"ref":"refs/changes/02/269402/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/02/269402/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/2"}}},"commit":{"parents":[{"commit":"a0134f89af21a274d5f0cc7c2e1696755543c713","subject":"Merge \"Setup for translation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/a0134f89af21a274d5f0cc7c2e1696755543c713"}]}],"author":{"name":"lei zhang","email":"shleiz@cn.ibm.com","date":"2015-12-06 05:51:49.000000000","tz":480},"committer":{"name":"reedip","email":"reedip.banerjee@nectechnologies.in","date":"2016-01-19 08:44:24.000000000","tz":540},"subject":"Fix repeat (set/clear) gateway in router","message":"Fix repeat (set/clear) gateway in router\n\nCurrently neutron-client allows user to repeatedly update the\ngateway to same ip address. It also allows user to clear the\ngateway for a router which does not have any gateway associated\nto it.\nThis patch adds a check in set-gateway and gateway-clear function\nto fix the same.\n\nChange-Id: Ifea1a984aeb8335c8f715799f0222c8dec13a8a1\nCo-Authored-By: Reedip Banerjee \u003creedip.banerjee@nectechnologies.in\u003e\nCloses-Bug: #1422371\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/19514faeaa21dd4c5d6890230020c634f28ca259"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/19514faeaa21dd4c5d6890230020c634f28ca259"}]},"branch":"refs/heads/master"},"7afdc04ea96cb7acca7906c6a2fa43d6c2e39d9d":{"kind":"REWORK","_number":3,"created":"2016-01-20 06:16:45.000000000","uploader":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"ref":"refs/changes/02/269402/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/02/269402/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/3"}}},"commit":{"parents":[{"commit":"a0134f89af21a274d5f0cc7c2e1696755543c713","subject":"Merge \"Setup for translation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/a0134f89af21a274d5f0cc7c2e1696755543c713"}]}],"author":{"name":"lei zhang","email":"shleiz@cn.ibm.com","date":"2015-12-06 05:51:49.000000000","tz":480},"committer":{"name":"lei zhang","email":"shleiz@cn.ibm.com","date":"2015-12-07 09:26:44.000000000","tz":480},"subject":"Fix repeat (set/clear) gateway in router","message":"Fix repeat (set/clear) gateway in router\n\nCurrently neutron-client allows user to repeatedly update the\ngateway to same ip address. It also allows user to clear the\ngateway for a router which does not have any gateway associated\nto it.\nThis patch adds a check in set-gateway and gateway-clear function\nto fix the same.\n\nChange-Id: Ifea1a984aeb8335c8f715799f0222c8dec13a8a1\nCo-Authored-By: Reedip Banerjee \u003creedip.banerjee@nectechnologies.in\u003e\nCloses-Bug: #1422371\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/7afdc04ea96cb7acca7906c6a2fa43d6c2e39d9d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/7afdc04ea96cb7acca7906c6a2fa43d6c2e39d9d"}]},"branch":"refs/heads/master"},"c70693be6bbc1006a948a2e4880afaab86cb05d2":{"kind":"REWORK","_number":4,"created":"2016-01-21 01:42:03.000000000","uploader":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"ref":"refs/changes/02/269402/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/02/269402/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/4"}}},"commit":{"parents":[{"commit":"a0134f89af21a274d5f0cc7c2e1696755543c713","subject":"Merge \"Setup for translation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/a0134f89af21a274d5f0cc7c2e1696755543c713"}]}],"author":{"name":"lei zhang","email":"shleiz@cn.ibm.com","date":"2015-12-06 05:51:49.000000000","tz":480},"committer":{"name":"reedip","email":"reedip.banerjee@nectechnologies.in","date":"2016-01-21 01:43:21.000000000","tz":540},"subject":"Fix repeat (set/clear) gateway in router","message":"Fix repeat (set/clear) gateway in router\n\nCurrently neutron-client allows user to repeatedly update the\ngateway to same ip address. It also allows user to clear the\ngateway for a router which does not have any gateway associated\nto it.\nThis patch adds a check in set-gateway and gateway-clear function\nto fix the same.\n\nChange-Id: Ifea1a984aeb8335c8f715799f0222c8dec13a8a1\nCo-Authored-By: Reedip Banerjee \u003creedip.banerjee@nectechnologies.in\u003e\nCloses-Bug: #1422371\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/c70693be6bbc1006a948a2e4880afaab86cb05d2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/c70693be6bbc1006a948a2e4880afaab86cb05d2"}]},"branch":"refs/heads/master"},"dc4b7807bfde1cac9eeb51c992a1caafeced6db5":{"kind":"REWORK","_number":5,"created":"2016-01-21 01:43:22.000000000","uploader":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"ref":"refs/changes/02/269402/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/02/269402/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/5"}}},"commit":{"parents":[{"commit":"a0134f89af21a274d5f0cc7c2e1696755543c713","subject":"Merge \"Setup for translation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/a0134f89af21a274d5f0cc7c2e1696755543c713"}]}],"author":{"name":"lei zhang","email":"shleiz@cn.ibm.com","date":"2015-12-06 05:51:49.000000000","tz":480},"committer":{"name":"reedip","email":"reedip.banerjee@nectechnologies.in","date":"2016-01-21 01:45:08.000000000","tz":540},"subject":"Fix repeat (set/clear) gateway in router","message":"Fix repeat (set/clear) gateway in router\n\nCurrently neutron-client allows user to repeatedly update the\ngateway to same ip address. It also allows user to clear the\ngateway for a router which does not have any gateway associated\nto it.\nThis patch adds a check in set-gateway and gateway-clear function\nto fix the same.\n\nChange-Id: Ifea1a984aeb8335c8f715799f0222c8dec13a8a1\nCo-Authored-By: Reedip Banerjee \u003creedip.banerjee@nectechnologies.in\u003e\nCloses-Bug: #1422371\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/dc4b7807bfde1cac9eeb51c992a1caafeced6db5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/dc4b7807bfde1cac9eeb51c992a1caafeced6db5"}]},"branch":"refs/heads/master"},"deba5fdbcf34d21fcb706d2a566c7a6e2ddb59d0":{"kind":"REWORK","_number":6,"created":"2016-01-21 03:15:32.000000000","uploader":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"ref":"refs/changes/02/269402/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/02/269402/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/6"}}},"commit":{"parents":[{"commit":"a0134f89af21a274d5f0cc7c2e1696755543c713","subject":"Merge \"Setup for translation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/a0134f89af21a274d5f0cc7c2e1696755543c713"}]}],"author":{"name":"lei zhang","email":"shleiz@cn.ibm.com","date":"2015-12-06 05:51:49.000000000","tz":480},"committer":{"name":"Reedip","email":"reedip.banerjee@nectechnologies.in","date":"2016-01-21 03:15:29.000000000","tz":0},"subject":"Fix repeat (set/clear) gateway in router","message":"Fix repeat (set/clear) gateway in router\n\nCurrently neutron-client allows user to repeatedly update the\ngateway to same ip address. It also allows user to clear the\ngateway for a router which does not have any gateway associated\nto it.\nThis patch adds a check in set-gateway and gateway-clear function\nto fix the same.\n\nChange-Id: Ifea1a984aeb8335c8f715799f0222c8dec13a8a1\nCo-Authored-By: Reedip Banerjee \u003creedip.banerjee@nectechnologies.in\u003e\nCloses-Bug: #1422371\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/deba5fdbcf34d21fcb706d2a566c7a6e2ddb59d0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/deba5fdbcf34d21fcb706d2a566c7a6e2ddb59d0"}]},"branch":"refs/heads/master"},"892f1f0566f1f97934e736128e7a45695756e2ce":{"kind":"REWORK","_number":7,"created":"2016-01-22 02:30:06.000000000","uploader":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"ref":"refs/changes/02/269402/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/02/269402/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/7"}}},"commit":{"parents":[{"commit":"a0134f89af21a274d5f0cc7c2e1696755543c713","subject":"Merge \"Setup for translation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/a0134f89af21a274d5f0cc7c2e1696755543c713"}]}],"author":{"name":"lei zhang","email":"shleiz@cn.ibm.com","date":"2015-12-06 05:51:49.000000000","tz":480},"committer":{"name":"reedip","email":"reedip.banerjee@nectechnologies.in","date":"2016-01-22 02:32:22.000000000","tz":540},"subject":"Fix repeat (set/clear) gateway in router","message":"Fix repeat (set/clear) gateway in router\n\nCurrently neutron-client allows user to repeatedly update the\ngateway to same ip address. It also allows user to clear the\ngateway for a router which does not have any gateway associated\nto it.\nThis patch adds a check in set-gateway and gateway-clear function\nto fix the same.\n\nChange-Id: Ifea1a984aeb8335c8f715799f0222c8dec13a8a1\nCo-Authored-By: Reedip Banerjee \u003creedip.banerjee@nectechnologies.in\u003e\nCloses-Bug: #1422371\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/892f1f0566f1f97934e736128e7a45695756e2ce"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/892f1f0566f1f97934e736128e7a45695756e2ce"}]},"branch":"refs/heads/master"},"558b82492fa48e32792e638b5a3c295abf1dc1fc":{"kind":"REWORK","_number":8,"created":"2016-01-27 02:56:54.000000000","uploader":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"ref":"refs/changes/02/269402/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/02/269402/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/8"}}},"commit":{"parents":[{"commit":"a0134f89af21a274d5f0cc7c2e1696755543c713","subject":"Merge \"Setup for translation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/a0134f89af21a274d5f0cc7c2e1696755543c713"}]}],"author":{"name":"lei zhang","email":"shleiz@cn.ibm.com","date":"2015-12-06 05:51:49.000000000","tz":480},"committer":{"name":"lei zhang","email":"shleiz@cn.ibm.com","date":"2015-12-03 05:46:43.000000000","tz":480},"subject":"Fix neutron-client can repeat (set/clear) gateway in router","message":"Fix neutron-client can repeat (set/clear) gateway in router\n\nCurrently neutron-client allows user to repeatedly update the\ngateway to same ip address. It also allows user to clear the\ngateway for a router which does not have any gateway associated\nto it.\nThis patch adds a check in set-gateway,if update same gateway info\nfor a router,should display command error message.\nThis patch adds a check in clear-gateway,if router does not have\nany gateway associated to it,should display command error message\n\nChange-Id: Ifea1a984aeb8335c8f715799f0222c8dec13a8a1\nCo-Authored-By: Reedip Banerjee \u003creedip.banerjee@nectechnologies.in\u003e\nCloses-Bug: #1422371\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/558b82492fa48e32792e638b5a3c295abf1dc1fc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/558b82492fa48e32792e638b5a3c295abf1dc1fc"}]},"branch":"refs/heads/master"},"16bbdf264ed268d06b1605bd0b8ab782b84c8545":{"kind":"REWORK","_number":9,"created":"2016-01-27 06:37:17.000000000","uploader":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"ref":"refs/changes/02/269402/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/02/269402/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/9"}}},"commit":{"parents":[{"commit":"a0134f89af21a274d5f0cc7c2e1696755543c713","subject":"Merge \"Setup for translation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/a0134f89af21a274d5f0cc7c2e1696755543c713"}]}],"author":{"name":"lei zhang","email":"shleiz@cn.ibm.com","date":"2015-12-06 05:51:49.000000000","tz":480},"committer":{"name":"lei zhang","email":"shleiz@cn.ibm.com","date":"2015-12-03 09:35:28.000000000","tz":480},"subject":"Fix neutron-client can repeat (set/clear) gateway in router","message":"Fix neutron-client can repeat (set/clear) gateway in router\n\nCurrently neutron-client allows user to repeatedly update the\ngateway to same ip address. It also allows user to clear the\ngateway for a router which does not have any gateway associated\nto it.\nThis patch adds a check in set-gateway,if update same gateway info\nfor a router,should display command error message.\nThis patch adds a check in clear-gateway,if router does not have\nany gateway associated to it,should display command error message\n\nChange-Id: Ifea1a984aeb8335c8f715799f0222c8dec13a8a1\nCo-Authored-By: Reedip Banerjee \u003creedip.banerjee@nectechnologies.in\u003e\nCloses-Bug: #1422371\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/16bbdf264ed268d06b1605bd0b8ab782b84c8545"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/16bbdf264ed268d06b1605bd0b8ab782b84c8545"}]},"branch":"refs/heads/master"},"23c0d784c7f8af46f8f5f3ef96ac3ec836f673a7":{"kind":"REWORK","_number":10,"created":"2016-01-27 07:41:38.000000000","uploader":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"ref":"refs/changes/02/269402/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/02/269402/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/02/269402/10"}}},"commit":{"parents":[{"commit":"a0134f89af21a274d5f0cc7c2e1696755543c713","subject":"Merge \"Setup for translation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/a0134f89af21a274d5f0cc7c2e1696755543c713"}]}],"author":{"name":"lei zhang","email":"shleiz@cn.ibm.com","date":"2015-12-06 05:51:49.000000000","tz":480},"committer":{"name":"lei zhang","email":"shleiz@cn.ibm.com","date":"2015-12-03 10:39:50.000000000","tz":480},"subject":"Fix neutron-client can repeat (set/clear) gateway in router","message":"Fix neutron-client can repeat (set/clear) gateway in router\n\nCurrently neutron-client allows user to repeatedly update the\ngateway to same ip address. It also allows user to clear the\ngateway for a router which does not have any gateway associated\nto it.\nThis patch adds a check in set-gateway,if update same gateway info\nfor a router,should display command error message.\nThis patch adds a check in clear-gateway,if router does not have\nany gateway associated to it,should display command error message\n\nChange-Id: Ifea1a984aeb8335c8f715799f0222c8dec13a8a1\nCo-Authored-By: Reedip Banerjee \u003creedip.banerjee@nectechnologies.in\u003e\nCloses-Bug: #1422371\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/23c0d784c7f8af46f8f5f3ef96ac3ec836f673a7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/23c0d784c7f8af46f8f5f3ef96ac3ec836f673a7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}