)]}'
{"neutronclient/neutron/v2_0/router.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e03f60d39f3a3a8123fe2864dfbc122a953675e4","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        _ext_net_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":242,"context_line":"            neutron_client, \u0027network\u0027, parsed_args.external_network)"},{"line_number":243,"context_line":"        router_dict \u003d {\u0027network_id\u0027: _ext_net_id}"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        if parsed_args.disable_snat:"},{"line_number":246,"context_line":"            router_dict[\u0027enable_snat\u0027] \u003d False"},{"line_number":247,"context_line":"        if parsed_args.fixed_ip:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_bd997e70","line":244,"updated":"2016-01-20 01:52:09.000000000","message":"Not required","commit_id":"49836f7de304f04cdc8b5a124a376d6bcb8d32d5"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"c234590f59c863ddd60d35883bef8b0af380cc41","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        _ext_net_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":242,"context_line":"            neutron_client, \u0027network\u0027, parsed_args.external_network)"},{"line_number":243,"context_line":"        router_dict \u003d {\u0027network_id\u0027: _ext_net_id}"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        if parsed_args.disable_snat:"},{"line_number":246,"context_line":"            router_dict[\u0027enable_snat\u0027] \u003d False"},{"line_number":247,"context_line":"        if parsed_args.fixed_ip:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_d8856007","line":244,"in_reply_to":"ba63e191_bd997e70","updated":"2016-01-20 03:00:59.000000000","message":"Done","commit_id":"49836f7de304f04cdc8b5a124a376d6bcb8d32d5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e03f60d39f3a3a8123fe2864dfbc122a953675e4","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                    ip_dict[\u0027subnet_id\u0027] \u003d subnet_id"},{"line_number":256,"context_line":"                ips.append(ip_dict)"},{"line_number":257,"context_line":"            router_dict[\u0027external_fixed_ips\u0027] \u003d ips"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        self.update_dict_with_extra_values(router_dict)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        neutron_client.add_gateway_router(_router_id, router_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_dd9c725f","line":258,"updated":"2016-01-20 01:52:09.000000000","message":"Not required","commit_id":"49836f7de304f04cdc8b5a124a376d6bcb8d32d5"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"c234590f59c863ddd60d35883bef8b0af380cc41","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                    ip_dict[\u0027subnet_id\u0027] \u003d subnet_id"},{"line_number":256,"context_line":"                ips.append(ip_dict)"},{"line_number":257,"context_line":"            router_dict[\u0027external_fixed_ips\u0027] \u003d ips"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        self.update_dict_with_extra_values(router_dict)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        neutron_client.add_gateway_router(_router_id, router_dict)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_787d541b","line":258,"in_reply_to":"ba63e191_dd9c725f","updated":"2016-01-20 03:00:59.000000000","message":"Done","commit_id":"49836f7de304f04cdc8b5a124a376d6bcb8d32d5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e03f60d39f3a3a8123fe2864dfbc122a953675e4","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            help\u003d_(\u0027ID or name of the router.\u0027))"},{"line_number":277,"context_line":"        return parser"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def run(self, parsed_args):"},{"line_number":280,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":281,"context_line":"        neutron_client \u003d self.get_client()"},{"line_number":282,"context_line":"        _router_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_9d9fda4f","line":279,"updated":"2016-01-20 01:52:09.000000000","message":"Please add the function here as well","commit_id":"49836f7de304f04cdc8b5a124a376d6bcb8d32d5"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"c234590f59c863ddd60d35883bef8b0af380cc41","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            help\u003d_(\u0027ID or name of the router.\u0027))"},{"line_number":277,"context_line":"        return parser"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def run(self, parsed_args):"},{"line_number":280,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":281,"context_line":"        neutron_client \u003d self.get_client()"},{"line_number":282,"context_line":"        _router_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_b883cccb","line":279,"in_reply_to":"ba63e191_9d9fda4f","updated":"2016-01-20 03:00:59.000000000","message":"remove_gateway_router() only accept an router_id as argument, so I think there\u0027s no need to add extra attributes.","commit_id":"49836f7de304f04cdc8b5a124a376d6bcb8d32d5"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"df3285b3e579cf238d6a93a3464b3d5a1f51ed9f","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    def run(self, parsed_args):"},{"line_number":164,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":165,"context_line":"        if self.values_specs:"},{"line_number":166,"context_line":"            raise exceptions.CommandError(_(\u0027Unknown arguments are passed: %s\u0027)"},{"line_number":167,"context_line":"                                          % self.values_specs)"},{"line_number":168,"context_line":"        neutron_client \u003d self.get_client()"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_cb0fe22c","line":166,"updated":"2016-01-28 14:17:54.000000000","message":"Since this is a generic message, maybe it should be a new exception in neutronclient.common.exceptions.","commit_id":"09fa3af06c3288aac15d4db1979a1d023031b7d7"}],"neutronclient/tests/unit/test_cli20_router.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"97fe35123de758d82cd3d974edf501bb76941dd3","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        args \u003d [\u0027myid\u0027, \u0027port\u003dportid\u0027]"},{"line_number":320,"context_line":"        self._test_add_remove_interface(\u0027add\u0027, \u0027port\u0027, cmd, args)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    def test_add_interface_with_wrong_attribute(self):"},{"line_number":323,"context_line":"        # Add interface to router: myid port\u003dportid --wrong_attr wrong_value."},{"line_number":324,"context_line":"        # wrong_attr and wrong_value should exist in the request body"},{"line_number":325,"context_line":"        cmd \u003d router.AddInterfaceRouter(test_cli20.MyApp(sys.stdout), None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_25175249","line":322,"range":{"start_line":322,"start_character":32,"end_line":322,"end_character":37},"updated":"2016-01-24 23:43:36.000000000","message":"wrong -\u003e extra?\n\nIf an argument is really wrong, we don\u0027t need to send it to neutron-server.","commit_id":"7413851dc33e776c0498288d4780f815e8237105"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"8a7800e7533213548c859adb39f2918a02045d6d","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        args \u003d [\u0027myid\u0027, \u0027port\u003dportid\u0027]"},{"line_number":320,"context_line":"        self._test_add_remove_interface(\u0027add\u0027, \u0027port\u0027, cmd, args)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    def test_add_interface_with_wrong_attribute(self):"},{"line_number":323,"context_line":"        # Add interface to router: myid port\u003dportid --wrong_attr wrong_value."},{"line_number":324,"context_line":"        # wrong_attr and wrong_value should exist in the request body"},{"line_number":325,"context_line":"        cmd \u003d router.AddInterfaceRouter(test_cli20.MyApp(sys.stdout), None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a68dd71_4dcd8d85","line":322,"range":{"start_line":322,"start_character":32,"end_line":322,"end_character":37},"in_reply_to":"9a68dd71_25175249","updated":"2016-01-26 09:29:20.000000000","message":"neutronclient don\u0027t know whether an unknown argument is extra or wrong. change wrong to extra should avoid misunderstanding","commit_id":"7413851dc33e776c0498288d4780f815e8237105"}]}
