)]}'
{"id":"openstack%2Fpython-neutronclient~269547","triplet_id":"openstack%2Fpython-neutronclient~master~I68cb9b03c211eece32ab77dea866fd8f98dfab63","project":"openstack/python-neutronclient","branch":"master","topic":"extra_attr","hashtags":[],"change_id":"I68cb9b03c211eece32ab77dea866fd8f98dfab63","subject":"Deny extra arguments for router gateway and interface CLIs","status":"ABANDONED","created":"2016-01-19 10:40:32.000000000","updated":"2016-04-14 17:23:13.000000000","total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8bdc108d630c606c941aa2b915b328d6250bc236","_number":269547,"virtual_id_number":269547,"owner":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"date":"2016-02-02 12:18:53.000000000","_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},{"value":-1,"date":"2016-03-02 22:07:21.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-02-19 02:11:39.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},{"date":"2016-04-14 17:23:13.000000000","_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"disliked":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"all":[{"value":1,"date":"2016-02-19 02:23:15.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-02-19 02:12:27.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":1,"date":"2016-02-03 17:13:16.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":-1,"date":"2016-02-05 00:33:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"value":1,"date":"2016-02-03 16:20:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-03 16:20:36.000000000","updated_by":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"reviewer":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"state":"REVIEWER"},{"updated":"2016-02-03 17:13:16.000000000","updated_by":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"reviewer":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"state":"REVIEWER"},{"updated":"2016-02-05 00:33:46.000000000","updated_by":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"reviewer":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"state":"REVIEWER"},{"updated":"2016-02-19 02:11:39.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2016-02-19 02:23:15.000000000","updated_by":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"reviewer":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"state":"REVIEWER"},{"updated":"2016-03-02 22:07:21.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-04-14 17:23:13.000000000","updated_by":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"reviewer":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"state":"REVIEWER"}],"messages":[{"id":"4badad53536c125566ecde6fc9e3ba1972d7d456","author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"date":"2016-01-19 10:40:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7374ecd7d8c84ded715631d95bc601ffdcbe8efa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-19 12:27:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/47/269547/1/check/gate-python-neutronclient-pep8/d1c6c31/ : SUCCESS in 1m 22s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/47/269547/1/check/gate-python-neutronclient-docs/103e22f//doc/build/html/ : SUCCESS in 1m 18s\n- gate-python-neutronclient-python27 http://logs.openstack.org/47/269547/1/check/gate-python-neutronclient-python27/ad55584/ : SUCCESS in 1m 17s\n- gate-python-neutronclient-python34 http://logs.openstack.org/47/269547/1/check/gate-python-neutronclient-python34/a3a38cc/ : SUCCESS in 1m 55s\n- gate-python-neutronclient-pypy http://logs.openstack.org/47/269547/1/check/gate-python-neutronclient-pypy/b06b01e/ : SUCCESS in 2m 09s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/47/269547/1/check/gate-tempest-dsvm-neutron-src-python-neutronclient/9cb4477/ : SUCCESS in 1h 37m 10s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/47/269547/1/check/gate-neutronclient-test-dsvm-functional/3aa0827/ : SUCCESS in 29m 34s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/47/269547/1/check/gate-neutronclient-test-dsvm-functional-adv-svcs/ac73476/ : SUCCESS in 30m 44s","accounts_in_message":[],"_revision_number":1},{"id":"e03f60d39f3a3a8123fe2864dfbc122a953675e4","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-01-20 01:52:09.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)\n\nCan you add some test cases, as well as the nits below?","accounts_in_message":[],"_revision_number":1},{"id":"c234590f59c863ddd60d35883bef8b0af380cc41","author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"date":"2016-01-20 03:00:59.000000000","message":"Patch Set 1:\n\n(3 comments)\n\n\u003e (3 comments)\n \u003e \n \u003e Can you add some test cases, as well as the nits below?\n\ndone","accounts_in_message":[],"_revision_number":1},{"id":"4e1c0d01a5518f8ba709af1ed6919a7078989b75","author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"date":"2016-01-20 03:13:00.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"44d0aea46275dfa701359850391aeac9cab9d9e0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-20 03:36:29.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/47/269547/2/check/gate-python-neutronclient-pep8/98bb0d5/ : SUCCESS in 1m 04s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/47/269547/2/check/gate-python-neutronclient-docs/785fb1a//doc/build/html/ : SUCCESS in 1m 06s\n- gate-python-neutronclient-python27 http://logs.openstack.org/47/269547/2/check/gate-python-neutronclient-python27/6716bbb/ : SUCCESS in 1m 02s\n- gate-python-neutronclient-python34 http://logs.openstack.org/47/269547/2/check/gate-python-neutronclient-python34/4386004/ : SUCCESS in 1m 34s\n- gate-python-neutronclient-pypy http://logs.openstack.org/47/269547/2/check/gate-python-neutronclient-pypy/f56b347/ : SUCCESS in 2m 17s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/47/269547/2/check/gate-tempest-dsvm-neutron-src-python-neutronclient/bf1ae40/ : FAILURE in 9m 14s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/47/269547/2/check/gate-neutronclient-test-dsvm-functional/1162dd7/ : FAILURE in 9m 27s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/47/269547/2/check/gate-neutronclient-test-dsvm-functional-adv-svcs/3948c67/ : FAILURE in 13m 57s","accounts_in_message":[],"_revision_number":2},{"id":"4b6d5df4df8599ffba4d4f3a56b078243ed11762","author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"date":"2016-01-20 05:12:10.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"c27a7b0dcbf433619224633947daa58cf75f4919","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-20 05:32:51.000000000","message":"Patch Set 2:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/47/269547/2/check/gate-python-neutronclient-pep8/177ec51/ : SUCCESS in 1m 05s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/47/269547/2/check/gate-python-neutronclient-docs/e5d445f//doc/build/html/ : SUCCESS in 1m 06s\n- gate-python-neutronclient-python27 http://logs.openstack.org/47/269547/2/check/gate-python-neutronclient-python27/87d38a1/ : SUCCESS in 1m 14s\n- gate-python-neutronclient-python34 http://logs.openstack.org/47/269547/2/check/gate-python-neutronclient-python34/7a681ee/ : SUCCESS in 1m 37s\n- gate-python-neutronclient-pypy http://logs.openstack.org/47/269547/2/check/gate-python-neutronclient-pypy/56928e0/ : SUCCESS in 1m 40s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/47/269547/2/check/gate-tempest-dsvm-neutron-src-python-neutronclient/64c3eb5/ : FAILURE in 10m 00s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/47/269547/2/check/gate-neutronclient-test-dsvm-functional/fb3e4a1/ : FAILURE in 7m 15s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/47/269547/2/check/gate-neutronclient-test-dsvm-functional-adv-svcs/5ed9bd8/ : FAILURE in 7m 34s","accounts_in_message":[],"_revision_number":2},{"id":"72b08152d9b77fce398b7ea8f724c26b5d360c64","author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"date":"2016-01-21 02:31:38.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"f9547a070fc1d1020955a887b68eb4280c8a7402","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-21 04:03:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/47/269547/2/check/gate-python-neutronclient-pep8/0d7cc8c/ : SUCCESS in 1m 47s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/47/269547/2/check/gate-python-neutronclient-docs/41348b1//doc/build/html/ : SUCCESS in 2m 31s\n- gate-python-neutronclient-python27 http://logs.openstack.org/47/269547/2/check/gate-python-neutronclient-python27/ed6cd32/ : SUCCESS in 1m 32s\n- gate-python-neutronclient-python34 http://logs.openstack.org/47/269547/2/check/gate-python-neutronclient-python34/a3bd0d1/ : SUCCESS in 1m 31s\n- gate-python-neutronclient-pypy http://logs.openstack.org/47/269547/2/check/gate-python-neutronclient-pypy/c41d9db/ : SUCCESS in 2m 00s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/47/269547/2/check/gate-tempest-dsvm-neutron-src-python-neutronclient/da950e3/ : SUCCESS in 1h 28m 38s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/47/269547/2/check/gate-neutronclient-test-dsvm-functional/f803854/ : SUCCESS in 37m 49s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/47/269547/2/check/gate-neutronclient-test-dsvm-functional-adv-svcs/4f48abc/ : SUCCESS in 31m 12s","accounts_in_message":[],"_revision_number":2},{"id":"97fe35123de758d82cd3d974edf501bb76941dd3","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2016-01-24 23:43:36.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nDo we really need to pass extra arguments to neutron-server?\nI think we can deny extra arguments for such commands with specific purposes.\n\n  if self.values_specs:\n      raise CommandError(\u0027Unknown arguments are passed: %s\u0027 % self.values_specs)","accounts_in_message":[],"_revision_number":2},{"id":"8a7800e7533213548c859adb39f2918a02045d6d","author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"date":"2016-01-26 09:29:20.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nHi Akihiro, \nI don\u0027t what\u0027s the problem with sending extra arguments, but I\u0027ve changed according to your suggestion.","accounts_in_message":[],"_revision_number":2},{"id":"0ef12e39bab420ab67e15ed332466b31cdd85e56","author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"date":"2016-01-26 09:34:49.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f1eb4073b4f5f845d571e80ebd62d7dfb2a5e714","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-26 10:48:37.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/47/269547/3/check/gate-python-neutronclient-pep8/8a0e0db/ : SUCCESS in 1m 14s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/47/269547/3/check/gate-python-neutronclient-docs/0ab2998//doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-neutronclient-python27 http://logs.openstack.org/47/269547/3/check/gate-python-neutronclient-python27/d2705e1/ : SUCCESS in 1m 29s\n- gate-python-neutronclient-python34 http://logs.openstack.org/47/269547/3/check/gate-python-neutronclient-python34/8d1d0c3/ : SUCCESS in 1m 54s\n- gate-python-neutronclient-pypy http://logs.openstack.org/47/269547/3/check/gate-python-neutronclient-pypy/d405788/ : SUCCESS in 2m 23s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/47/269547/3/check/gate-tempest-dsvm-neutron-src-python-neutronclient/e6e61a6/ : SUCCESS in 1h 10m 39s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/47/269547/3/check/gate-neutronclient-test-dsvm-functional/f056216/ : SUCCESS in 33m 04s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/47/269547/3/check/gate-neutronclient-test-dsvm-functional-adv-svcs/656aba3/ : SUCCESS in 24m 00s","accounts_in_message":[],"_revision_number":3},{"id":"df3285b3e579cf238d6a93a3464b3d5a1f51ed9f","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-01-28 14:17:54.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"690dd0d7f06f205185a4fb05ded62fa89be7266f","author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"date":"2016-02-02 06:22:42.000000000","message":"Patch Set 3:\n\n\u003e (1 comment)\n\ndone","accounts_in_message":[],"_revision_number":3},{"id":"24a6a3fc872cd33d040c559c5691c33fec5352a1","author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"date":"2016-02-02 06:33:54.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"d1e993bdcfa0bb68e59f4c0044baf3725d1108b2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-02 07:02:43.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/47/269547/4/check/gate-python-neutronclient-pep8/2042f7c/ : SUCCESS in 1m 21s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/47/269547/4/check/gate-python-neutronclient-docs/e9c8146//doc/build/html/ : SUCCESS in 1m 26s\n- gate-python-neutronclient-python27 http://logs.openstack.org/47/269547/4/check/gate-python-neutronclient-python27/a6e14c2/ : SUCCESS in 1m 20s\n- gate-python-neutronclient-python34 http://logs.openstack.org/47/269547/4/check/gate-python-neutronclient-python34/359b2ce/ : SUCCESS in 1m 37s\n- gate-python-neutronclient-pypy http://logs.openstack.org/47/269547/4/check/gate-python-neutronclient-pypy/b3a8982/ : SUCCESS in 3m 15s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/47/269547/4/check/gate-tempest-dsvm-neutron-src-python-neutronclient/d92d5c9/ : FAILURE in 12m 37s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/47/269547/4/check/gate-neutronclient-test-dsvm-functional/f11b751/ : SUCCESS in 25m 54s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/47/269547/4/check/gate-neutronclient-test-dsvm-functional-adv-svcs/21686c5/ : SUCCESS in 28m 41s","accounts_in_message":[],"_revision_number":4},{"id":"e93484aca4fd9f32b80120d49490098d549ce61f","author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"date":"2016-02-02 12:18:53.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"83ab83c72ec951fa4da6c28d7f00cee867716d49","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-02 13:25:56.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/47/269547/4/check/gate-python-neutronclient-pep8/e22f387/ : SUCCESS in 1m 05s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/47/269547/4/check/gate-python-neutronclient-docs/ddcef26//doc/build/html/ : SUCCESS in 1m 08s\n- gate-python-neutronclient-python27 http://logs.openstack.org/47/269547/4/check/gate-python-neutronclient-python27/799eab0/ : SUCCESS in 1m 07s\n- gate-python-neutronclient-python34 http://logs.openstack.org/47/269547/4/check/gate-python-neutronclient-python34/fa9338b/ : SUCCESS in 1m 53s\n- gate-python-neutronclient-pypy http://logs.openstack.org/47/269547/4/check/gate-python-neutronclient-pypy/c00b136/ : SUCCESS in 2m 04s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/47/269547/4/check/gate-tempest-dsvm-neutron-src-python-neutronclient/98cf31d/ : SUCCESS in 59m 20s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/47/269547/4/check/gate-neutronclient-test-dsvm-functional/dec862b/ : SUCCESS in 24m 23s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/47/269547/4/check/gate-neutronclient-test-dsvm-functional-adv-svcs/47aa39c/ : SUCCESS in 29m 19s","accounts_in_message":[],"_revision_number":4},{"id":"5b676308e95b344a55fc21318d447972545e5c0f","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-02-02 15:26:36.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"1e2a855849848e3e4a19b20515df34dc06809aaa","author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"date":"2016-02-03 16:20:36.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"e6827ceca712344ab434f8924403b1a86dd70a8c","author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"date":"2016-02-03 17:13:16.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"eeeef2a05c3c195eb317c3e65f52c9accd6e5db4","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2016-02-05 00:33:46.000000000","message":"Patch Set 4: Code-Review-1\n\nIf neutron allow new arguments then the assumption made by this change will be invalid.","accounts_in_message":[],"_revision_number":4},{"id":"a9f15d245bb6a0299e5cd023e517fb589e8c5b83","author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"date":"2016-02-17 07:37:45.000000000","message":"Patch Set 4:\n\n\u003e If neutron allow new arguments then the assumption made by this\n \u003e change will be invalid.\n\nHi Cedric, Akihiro suggested that for this specific command, we can deny extra arguments, so I did it. Are you suggesting that the arguments for this command might change? so we should send extra arguments?","accounts_in_message":[],"_revision_number":4},{"id":"af7b3fcfa35e774c6c5c3a4ac35891ecf2f3937e","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2016-02-19 02:11:39.000000000","message":"Patch Set 4:\n\nI am not sure we need to allow users to send extra arguments for such commands for specific purposes.\n\nIf we support extra arguments for classes which inherit the generic NeutronCommand, can we clean up all of them or to introduce a generic base class.\n\nThought?","accounts_in_message":[],"_revision_number":4},{"id":"faaa48f261c4800664ef78d83ec3e5fb1dc0359d","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2016-02-19 02:12:27.000000000","message":"Patch Set 4: Code-Review+1\n\nIMO it looks good, but it is better to get a consensus, so just +1 from me.","accounts_in_message":[],"_revision_number":4},{"id":"46ad7b84aa4f7e45c774ad2b420bcf37a10f3f37","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-02-19 02:23:15.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"b7842186dafd9e94c76993636ea897ba23a2d2a5","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-02-19 02:33:12.000000000","message":"Patch Set 4:\n\n@Akihiro:I would vote for keeping this sort of function in the NeutronCommand class itself.\nHowever, I would really enforce this movement ( Generic Base Class / NeutronCommand) only after the NeutronAPI is completely mapped to the python-neutronclient.\n\nOtherwise, this would have a side-effect:\n\n- User knows that ( for example ) Neutron Network can be updated with \n\" neutron net-update --router:external\". Although this option is not visible and sent as an extra argument to the NeutronServer, where is it easily resolved.\n\n- The following( or similar) patch gets merged, with the check for extra-arguments at Generic/NeutronCommand Level.\n\n- User would not be able to use the \"neutron net-update --router:external\" CLI, until that option is actually available in \"neutron net-update\" command.","accounts_in_message":[],"_revision_number":4},{"id":"91dc0d726279a7b6a82b6a1bc43e2bac94668d87","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-02 22:07:21.000000000","message":"Patch Set 4: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":4},{"id":"fc15a9ee437f3e76de2fbbddbe43af79677c953a","author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"date":"2016-03-23 11:32:50.000000000","message":"Removed the following votes:\n\n* Code-Review+1 by Richard Theis \u003crtheis@us.ibm.com\u003e\n","accounts_in_message":[],"_revision_number":4},{"id":"c2eeded58c4b357f1cd30c0266b9a6b6e7dd704a","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-04-14 17:23:13.000000000","message":"Patch Set 4:\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":4},{"id":"cb4302b62a3520dede1aadff9b41ed03c1fd01b3","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-04-14 17:23:13.000000000","message":"Abandoned\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"83cef494e544241b6adb57b2ed738ee38460fe74","revisions":{"49836f7de304f04cdc8b5a124a376d6bcb8d32d5":{"kind":"REWORK","_number":1,"created":"2016-01-19 10:40:32.000000000","uploader":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"ref":"refs/changes/47/269547/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/47/269547/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/1"}}},"commit":{"parents":[{"commit":"2fc5ed63a04221e8cf226de3dc5b6b754c0b5c27","subject":"Merge \"Delete python bytecode before every test run\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/2fc5ed63a04221e8cf226de3dc5b6b754c0b5c27"}]}],"author":{"name":"Bo Chi","email":"shcbo@cn.ibm.com","date":"2016-01-19 10:30:08.000000000","tz":-300},"committer":{"name":"Bo Chi","email":"shcbo@cn.ibm.com","date":"2016-01-19 10:37:14.000000000","tz":-300},"subject":"Send extra attributes in body","message":"Send extra attributes in body\n\nIn classes that implements it\u0027s own run() method, it didn\u0027t add extra\nattributes in body, so they are not sent to neutron server. This lead to\na problem that if you type a wrong attribute, it is silently striped,\nand no error will occor.\nThis patch added the extra attributes in request body, so that neutron\nserver will raise an error if the attributes are wrong.\n\nChange-Id: I68cb9b03c211eece32ab77dea866fd8f98dfab63\nCloses-Bug: #1535209\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/49836f7de304f04cdc8b5a124a376d6bcb8d32d5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/49836f7de304f04cdc8b5a124a376d6bcb8d32d5"}]},"branch":"refs/heads/master"},"7413851dc33e776c0498288d4780f815e8237105":{"kind":"REWORK","_number":2,"created":"2016-01-20 03:13:00.000000000","uploader":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"ref":"refs/changes/47/269547/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/47/269547/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/2"}}},"commit":{"parents":[{"commit":"b12d19df92311f43d1d21e8b7232a7b41f9a6801","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/b12d19df92311f43d1d21e8b7232a7b41f9a6801"}]}],"author":{"name":"Bo Chi","email":"shcbo@cn.ibm.com","date":"2016-01-20 03:03:29.000000000","tz":-300},"committer":{"name":"Bo Chi","email":"shcbo@cn.ibm.com","date":"2016-01-20 03:09:43.000000000","tz":-300},"subject":"Send extra attributes in body","message":"Send extra attributes in body\n\nIn classes that implements it\u0027s own run() method, it didn\u0027t add extra\nattributes in body, so they are not sent to neutron server. This lead to\na problem that if you type a wrong attribute, it is silently striped,\nand no error will occor.\nThis patch added the extra attributes in request body, so that neutron\nserver will raise an error if the attributes are wrong.\n\nChange-Id: I68cb9b03c211eece32ab77dea866fd8f98dfab63\nCloses-Bug: #1535209\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/7413851dc33e776c0498288d4780f815e8237105"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/7413851dc33e776c0498288d4780f815e8237105"}]},"branch":"refs/heads/master"},"09fa3af06c3288aac15d4db1979a1d023031b7d7":{"kind":"REWORK","_number":3,"created":"2016-01-26 09:34:49.000000000","uploader":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"ref":"refs/changes/47/269547/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/47/269547/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/3"}}},"commit":{"parents":[{"commit":"11d9cc87e0031ee95f39c2949eb5065c6145458f","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/11d9cc87e0031ee95f39c2949eb5065c6145458f"}]}],"author":{"name":"Bo Chi","email":"shcbo@cn.ibm.com","date":"2016-01-26 09:25:59.000000000","tz":-300},"committer":{"name":"Bo Chi","email":"shcbo@cn.ibm.com","date":"2016-01-26 09:25:59.000000000","tz":-300},"subject":"Deny extra arguments for router gateway and interface CLIs","message":"Deny extra arguments for router gateway and interface CLIs\n\nFor router-gateway-set/clear, router-interface-add/delete commands,\nif user passed some wrong arguments, no error will shown.\nThis patch deny extra arguments for these commands and display an error message.\n\nChange-Id: I68cb9b03c211eece32ab77dea866fd8f98dfab63\nCloses-Bug: #1535209\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/09fa3af06c3288aac15d4db1979a1d023031b7d7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/09fa3af06c3288aac15d4db1979a1d023031b7d7"}]},"branch":"refs/heads/master"},"83cef494e544241b6adb57b2ed738ee38460fe74":{"kind":"REWORK","_number":4,"created":"2016-02-02 06:33:54.000000000","uploader":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"ref":"refs/changes/47/269547/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/47/269547/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/47/269547/4"}}},"commit":{"parents":[{"commit":"11d9cc87e0031ee95f39c2949eb5065c6145458f","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/11d9cc87e0031ee95f39c2949eb5065c6145458f"}]}],"author":{"name":"Bo Chi","email":"shcbo@cn.ibm.com","date":"2016-01-26 09:25:59.000000000","tz":-300},"committer":{"name":"Bo Chi","email":"shcbo@cn.ibm.com","date":"2016-02-02 06:28:47.000000000","tz":-300},"subject":"Deny extra arguments for router gateway and interface CLIs","message":"Deny extra arguments for router gateway and interface CLIs\n\nFor router-gateway-set/clear, router-interface-add/delete commands,\nif user passed some wrong arguments, no error will shown.\nThis patch deny extra arguments for these commands and display an error message.\n\nChange-Id: I68cb9b03c211eece32ab77dea866fd8f98dfab63\nCloses-Bug: #1535209\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/83cef494e544241b6adb57b2ed738ee38460fe74"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/83cef494e544241b6adb57b2ed738ee38460fe74"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
